summaryrefslogtreecommitdiffstats
path: root/chrome/installer
Commit message (Collapse)AuthorAgeFilesLines
* Add a CEEE mode to the ChromeFrame distribution class.robertshield@chromium.org2010-12-1326-163/+300
| | | | | | | | | | | | | | Pass a MasterPreferences into BrowserDistribution et al. to allow for preferences-based behaviour. Add a GetComDllList() method that returns the set of registerable components for that distribution. Change GetKeyFile() on BrowserDistribution to GetKeyFiles(). Refactor GetMasterPreferencesForCurrentProcess into a static method on MasterPreferences. BUG=61609 TEST=None Review URL: http://codereview.chromium.org/5558006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68996 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary workaround to get tests that reference singletons either directly ↵tommi@chromium.org2010-12-091-1/+1
| | | | | | | | | | | | | | | | or indirectly to pass. With the recent Singleton refactoring, these tests started exposing some inherent problems with singletons, namely that one test can reference a state set by a different test, which can cause all sorts of flakiness. Furthermore, some of these tests could reference the registry which may have some user specific settings that could cause the tests to fail To work around these issues, I'm adding a few utility classes for tests (registry virtualization) and exposing a method to reset singletons before a test is run. TEST=Fixes flakiness and a few tests that could fail on the waterfall. BUG=none Review URL: http://codereview.chromium.org/5564009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68701 0039d316-1c4b-4281-b951-d872f2087c98
* Some installer cleanup: introduced ChannelInfo class for fiddling with "ap" ↵grt@chromium.org2010-12-086-101/+495
| | | | | | | | | | | ClientState value. BUG=61609 TEST=added to and modified chrome/installer_util_unittests.exe appropriately Review URL: http://codereview.chromium.org/5656002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68603 0039d316-1c4b-4281-b951-d872f2087c98
* When COM DLL registration fails, return false from DoPostInstallTasks.tommi@chromium.org2010-12-071-1/+4
| | | | | | | | | | | This was a regression from my refactoring change last week. Thanks for spotting this Greg. TEST=This fixes a case where if registering a COM dll failed, we wouldn't roll back. BUG=61609 Review URL: http://codereview.chromium.org/5511011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68521 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the GetVersionEnvKey method from BrowserDistribution.tommi@chromium.org2010-12-079-28/+0
| | | | | | | | | | | This function is not used by the installer and since we're moving towards using shared binaries, all components should rely on using the same version env var. It's also one less thing that the chrome code relies on from the installer code. TEST=Should be no change. BUG=61609 Review URL: http://codereview.chromium.org/5602001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68505 0039d316-1c4b-4281-b951-d872f2087c98
* Add svn:eol-style to this .gyp file since if it checkos out in CRLF mode the ↵pkasting@chromium.org2010-12-061-66/+66
| | | | | | | | | | build breaks. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68386 0039d316-1c4b-4281-b951-d872f2087c98
* Take care of an old todo: Use ScopedVariant instead of VariantHelper.tommi@chromium.org2010-12-031-29/+13
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5499001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68184 0039d316-1c4b-4281-b951-d872f2087c98
* Support for checking multiple keyfiles when removing an installation package.tommi@chromium.org2010-12-0214-63/+163
| | | | | | | | | BUG=61609 TEST=No change right now (multi-install related). Review URL: http://codereview.chromium.org/5429002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67968 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup some installer style nits.thestig@chromium.org2010-12-023-4/+4
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5430003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67931 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a problem with the delete-after-reboot code. Removing pending renames of ↵robertshield@chromium.org2010-12-013-4/+71
| | | | | | | | | | | | files not currently on disk would fail due to calls to GetShortPathName failing for already-deleted files. Now we just attempt to keep using the long path names for the already-deleted-file case. Also test. BUG=64503 TEST=Uninstall CF while it is in use. Delete the in use files. Reinstall. Ensure that the CF files are no longer scheduled for deletion by looking at HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Session Manager\PendingFileRenameOperations. Review URL: http://codereview.chromium.org/5354006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67889 0039d316-1c4b-4281-b951-d872f2087c98
* Fix x64 builder.tommi@chromium.org2010-12-011-1/+1
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67821 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the installer to support multi-install.tommi@chromium.org2010-12-0134-1243/+2356
| | | | | | | | | | | | | | | | | | The installer now does its work based on distributions and target installation paths. Each distribution has exactly one target installation path but each installation path can have more than one distribution. In the absense of the --multi-install switch, the installer should continue to work as before. The biggest difference here is that we don't rely on a single global distribution object that controls the entire installation flow and we have a few classes for the new abstractions instead of global functions. It's far from perfect, but it's a step towards separating the core file package required for all distributions from the distributions themselves. Additionally, there are tons of little changes here such as consistant usage of FilePath and CommandLine instead of mixing them with std::wstring. TEST=Install, uninstall, upgrade, etc. Everything install related. BUG=61609 Review URL: http://codereview.chromium.org/5172011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67818 0039d316-1c4b-4281-b951-d872f2087c98
* Fix setup_unittest.exe so it, you know, can ever possibly pass.robertshield@chromium.org2010-11-301-22/+16
| | | | | | | | | | BUG=61609 TEST=setup_unittest.exe should now pass. Review URL: http://codereview.chromium.org/5274003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67753 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new type of WorkItemList: NoRollbackWorkItemList.tommi@chromium.org2010-11-2410-26/+89
| | | | | | | | | | | | | | | | | | | | | | | This list does a best-effort execution of the items in the work list and always executes all items even if one of the items fails. Because of this, the list does also not support Rollback. The usage for this list is intended for uninstallation actions such as when unregistering a COM dll fails and we cannot "rollback" from it since we don't know what went wrong, what is the current state, etc and rolling back would really mean to re-register the DLL. Same applies for registry keys and files that might have been removed by the user. I also added a basic implementation of the Dump() method to all WorkItem derived classes for better diagnostics in the future. BUG=61609 TEST=The class is only used in a pending change list, so there should be no change in current behavior. Review URL: http://codereview.chromium.org/5260002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67309 0039d316-1c4b-4281-b951-d872f2087c98
* Add infrastructure enabling tests of installer upgrade scenarios.grt@chromium.org2010-11-2311-0/+1161
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5236002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67099 0039d316-1c4b-4281-b951-d872f2087c98
* Add awareness of the CEEE broker to BrowserDistribution. If the code called ↵hansl@google.com2010-11-223-1/+12
| | | | | | | | | | | is inside the Broker, behave as if it was ChromeFrame. BUG=None TEST=None Review URL: http://codereview.chromium.org/5247001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66921 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the collection of Chrome uninstall survey results which regressed a year ↵robertshield@chromium.org2010-11-201-3/+5
| | | | | | | | | | ago in r23631. BUG=63904 TEST=Install Chrome, ensure metrics collection is enabled in the Privacy settings, visit a few pages, uninstall Chrome. Note that the URL in the survey page contains stats such as pageviews, install date etc. Review URL: http://codereview.chromium.org/5137007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66899 0039d316-1c4b-4281-b951-d872f2087c98
* On windows, send audio hardware info with speech input requests if user ↵satish@chromium.org2010-11-192-0/+49
| | | | | | | | | | | | | consented. This may help identify quality issues. BUG=61677 TEST=none Review URL: http://codereview.chromium.org/4724001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66749 0039d316-1c4b-4281-b951-d872f2087c98
* Land http://codereview.chromium.org/5049001/ again (sigh)tommi@chromium.org2010-11-161-0/+8
| | | | | | | | | | | Enable ETW logging in setup. BUG=none TEST=Should be no change Review URL: http://codereview.chromium.org/5017003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66299 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 66286 - Enable ETW logging in setup.tommi@chromium.org2010-11-161-7/+0
| | | | | | | | | | | | BUG=none TEST=Should be no change Review URL: http://codereview.chromium.org/5049001 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/5069002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66292 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ETW logging in setup.tommi@chromium.org2010-11-161-0/+7
| | | | | | | | | BUG=none TEST=Should be no change Review URL: http://codereview.chromium.org/5049001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66286 0039d316-1c4b-4281-b951-d872f2087c98
* The UI language rather than the locale is now used to pick Chrome's language ↵grt@chromium.org2010-11-165-217/+518
| | | | | | | | | | | | | | | on Windows. (Also fixed some unrelated lint errors.) With this change, l10n_util::GetApplicationLocale first checks for an override of the "configured locale" (in base::i18n) containing the list of preferred Windows UI languages. The browser triggers an override early in startup before the ApplicationLocale is determined. In effect, the browser no longer uses ICU on Windows for language detection. (This locale override mechanism is borrowed from the OS X port.) Changes in Chrome Frame are largely a refactor, as some Win32 code in there has been moved into base/win. Also cleaned up language selection in installer_util so that the proper language is chosen for the EULA, installer messages, and shortcuts. In so doing, replaced hand-crafted lists of supported languages with either auto-generated lists (static consts) or logic so that the addition of translations in the future doesn't require code motion (that being said, there may be reason to update the alias and/or wildcard tables in language_selector.cc). In so doing, this change unlocks Amharic, Farsi, and Swahili translations for installer messages and shortcuts. BUG=39986,40496,26470 TEST=New MUI/Win32 calls are tested in base/win/i18n_unittest.cc. To test the overall functionality, uninstall Chrome, remove intl.app_locale user pref, switch to a supported display language (via the "Keyboards and Languages" tab of Win7's "Regional and Language" control panel, and install with { "distribution": { "require_eula": true } } in master_preferences (via -installerdata arg to setup.exe). If all goes well, both EULA and outer frame are in the same language as Windows. Also, from gwilson: "Install system-level Chrome in audit mode on a new machine, then go through the out-of-box-experience, select a language, and the in -product EULA (triggered by "require_eula" : true) and Chrome's UI should be in the language that the user selected." Review URL: http://codereview.chromium.org/4139010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66275 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to reland http://codereview.chromium.org/4928002/tommi@chromium.org2010-11-1512-171/+154
| | | | | | | | | | | | | | | | | | | | | | | | For some reason the Win bot failed to compile the sandbox unit test. Trybots and my machines don't have these build problems, so I'm going to try again, unchanged. Original description: Changing the installer switches from wchar_t[] to char[]. Because of this I'm also refactoring some code that before was using wstring to build command lines by hand instead of using the CommandLine class. Now we use CommandLine. To get this to work correctly, I also needed to fix CommandLine::AppendArguments so I added a little test for it. TEST=There should be no changes in functionality. Run all installer tests. BUG=61609 TBR=robertshield Review URL: http://codereview.chromium.org/4989001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66096 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 66088 - Changing the installer switches from wchar_t[] to char[].tommi@chromium.org2010-11-1512-154/+171
| | | | | | | | | | | | | | | | | | Because of this I'm also refactoring some code that before was using wstring to build command lines by hand instead of using the CommandLine class. Now we use CommandLine. To get this to work correctly, I also needed to fix CommandLine::AppendArguments so I added a little test for it. TEST=There should be no changes in functionality. Run all installer tests. BUG=61609 Review URL: http://codereview.chromium.org/4928002 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/4988001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66089 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the installer switches from wchar_t[] to char[].tommi@chromium.org2010-11-1412-171/+154
| | | | | | | | | | | | | | | Because of this I'm also refactoring some code that before was using wstring to build command lines by hand instead of using the CommandLine class. Now we use CommandLine. To get this to work correctly, I also needed to fix CommandLine::AppendArguments so I added a little test for it. TEST=There should be no changes in functionality. Run all installer tests. BUG=61609 Review URL: http://codereview.chromium.org/4928002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66088 0039d316-1c4b-4281-b951-d872f2087c98
* Add some verbose logging when registering COM components.tommi@chromium.org2010-11-111-0/+5
| | | | | | | | | BUG=none TEST=When using --verbose-logging with the installer, there will be entries for each COM component we [un]register. Review URL: http://codereview.chromium.org/4821001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65865 0039d316-1c4b-4281-b951-d872f2087c98
* Add multi install support to MasterPreferences and start using it in a few ↵tommi@chromium.org2010-11-1113-106/+328
| | | | | | | | | | | | | places.I'm also adding a constant for CEEE - I named it kCeee instead of kEnableCeee since it's also used in uninstalls.This change is just a beginning of being aware of having more than one product available in setup. I added some todos and dcheck for myself to keep track of places that will need more significant changes when running multiple installs. BUG=61609 TEST=All installations (chrome, chrome frame, ceee) should work as before with the exception that the CEEE switch is now --ceee and not --enable-ceee. Review URL: http://codereview.chromium.org/4635006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65855 0039d316-1c4b-4281-b951-d872f2087c98
* Wait a bit for the helper to exit before continuing with removing files.tommi@chromium.org2010-11-112-6/+48
| | | | | | | | | | | Also adding a bit of logging for easier diagnostics when we can't remove a folder due to files being in use on uninstall. TEST=Should improve our chances of being able to uninstall without needing to reboot. BUG=61609 Review URL: http://codereview.chromium.org/4773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65814 0039d316-1c4b-4281-b951-d872f2087c98
* Preferences: remove log spam.evan@chromium.org2010-11-111-5/+3
| | | | | | | | | | | The common case is for this file to not be available; we don't need to report it as an error each time. I improved this in r59984, but it regressed in r64945. Review URL: http://codereview.chromium.org/4740003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65770 0039d316-1c4b-4281-b951-d872f2087c98
* Add base::ThreadRestrictions::ScopedAllowIO allow_io;georgey@chromium.org2010-11-091-0/+4
| | | | | | | | | to google_update_settings.cc until the bug is fixed BUG=62121 TEST=none Review URL: http://codereview.chromium.org/4655005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65573 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring the master_preferences functions.tommi@chromium.org2010-11-0310-453/+372
| | | | | | | | | | | | | | | | | | | | | * Now there's a class named MasterPreferences that owns the json dictionary and supports methods that previously were global. * There's now a global object for the current process' master preference object, which avoids parsing the preference file multiple times. * Refactored the tests to be more data driven TEST=Run the installer util unit tests. Set the filter to *MasterPref* if you only want to run the tests affected by this change. BUG=none Review URL: http://codereview.chromium.org/4342001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64945 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move CaseInsensitiveCompare traits into the base namespace.tfarina@chromium.org2010-11-032-4/+5
| | | | | | | | | | | | | | | This should fix conflicts like: 2>d:\src\chromium_src2\src\base/string_util.h(480) : error C2904: 'CaseInsensitiveCompare' : name already used for a template in the current scope 2> d:\src\chromium_src2\src\third_party\xulrunner-sdk\win\include\xpcom\nsStringAPI.h(1406) : see declaration of 'CaseInsensitiveCompare' Reported-by: Jeff Timanus <twiz@google.com> BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4366001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64877 0039d316-1c4b-4281-b951-d872f2087c98
* Change miscellaneous LOG(INFO)s to VLOG()s that I missed the first time ↵pkasting@chromium.org2010-10-271-1/+1
| | | | | | | | | | | | through, either because they were LOG_IF() (which I didn't search for) or they were added during the week I was changing things. Plus a few misc. cleanup bits. BUG=none TEST=none Review URL: http://codereview.chromium.org/4111002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63998 0039d316-1c4b-4281-b951-d872f2087c98
* Update installer error strings to include Chrome Frame specific branding ↵robertshield@chromium.org2010-10-262-2/+14
| | | | | | | | | | | | | when running in Chrome Frame mode. Also fix the installer_util_strings target that had a broken dependency on a file that has since been moved. BUG=46013 TEST=Google Chrome Frame is correctly displayed when the installer is run in Chrome Frame mode. Review URL: http://codereview.chromium.org/3968005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63888 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - chrome/installer/.pkasting@chromium.org2010-10-2020-244/+215
| | | | | | | | | | Also remove some extra {}s, avoid "else" after "return"/use some early returns, and simplify some code. BUG=none TEST=none Review URL: http://codereview.chromium.org/3931004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63258 0039d316-1c4b-4281-b951-d872f2087c98
* Mark CopyTreeWorkItemTest tests as flaky.phajdan.jr@chromium.org2010-10-191-3/+6
| | | | | | | | | | | TBR=kuchhal BUG=59783, 59784, 59785 TEST=installer_util_unittests Review URL: http://codereview.chromium.org/3764015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63054 0039d316-1c4b-4281-b951-d872f2087c98
* Move pe_image and registry from base to base/win and use the namespace. It ↵brettw@chromium.org2010-10-1722-129/+177
| | | | | | | | | | | | removes windows_message_list which isn't used. This keeps a stub for registry in the old location until we can update that. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3836005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62888 0039d316-1c4b-4281-b951-d872f2087c98
* Move the windows-specific scoped_* stuff from base to base/win and in the ↵brettw@chromium.org2010-10-161-17/+18
| | | | | | | | | | | | | | | | base::win namespace. This keeps old headers that forward to the new versions and have using declarations that allow the existing code to compile. I fixed all the callers in base to use the new ones, and also the other files I happened to touch. This splits out the stuff from scoped_handle into a few separate files. I just deleted ScopedFindFile since it was only used in one place and it wasn't even really helping there. I removed StackBstr which was a #define and used the "regular" ScopedBstr in the 7 places that used it. This is an optimization to avoid an extra allocation, but none of the callers are remotely performance critical. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3781009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62843 0039d316-1c4b-4281-b951-d872f2087c98
* Move windows version-related stuff out of base/win_util and into ↵brettw@chromium.org2010-10-155-15/+15
| | | | | | | | | | | | | | base/win/windows_version. Many files now only need to include this instead of all of win_util. Remove a bunch of unused code from base/win_util. There was a surprising amount. Replace the AppUserModel property key with the one from the SDK now that we use the Win7 SDK. Move GetLogonSessionOnlyDACL from win_util to ipc since it's only used in that one place. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62694 0039d316-1c4b-4281-b951-d872f2087c98
* CommandLine: remove wstring-based program() accessorevan@chromium.org2010-10-146-51/+61
| | | | | | | | | | | | | | This was already removed on non-Windows, so this change modifies the remaining Windows-specific usage. In a few places I converted use of wstring paths into FilePath, but in general for Windows-specific code I don't think it's too important to use FilePath everywhere, because it is equivalent on Windows and the current code already works. BUG=23581 Review URL: http://codereview.chromium.org/3817001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62637 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move SplitString functions into the base namespace and update the callers.tfarina@chromium.org2010-10-143-4/+4
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3750001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
* Move wmi_util out of base and into chrome/installer/util since that's the ↵brettw@chromium.org2010-10-105-12/+398
| | | | | | | | | | only place where it's used. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3696001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62123 0039d316-1c4b-4281-b951-d872f2087c98
* Implement new strategy for default apps. Instead of usingaa@chromium.org2010-10-091-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the component extension system, simply install them as normal apps the first time Chrome runs. Remove the old style default apps. This also removes support for --disable-apps, which doesn't seem necessary since we already have --disable-extensions. BUG=53972 TEST=Uninstall any installed apps. Remove the "default_apps_installed" and "app_promo_counter" keys from Preferences if they are present. Start Chrome with the --enable-default-apps flag, navigate to chrome://extensions/, and click "update now" in the developer tools. This is to make the updater grab the apps from the store quicker, so that you don't have to wait while testing. Normally Chrome would do this by itself after 5-40 mins. Go to NTP. You should see gmail, calendar, and docs default apps show up along with the promo (the text that says "New! A world of ..."). Refresh the NTP 10 times. The promo should go away on the 10th time. There are other details. To test each of these, remove all installed apps and remove the keys from the preferences to reset the state. * If you close Chrome before getting the default apps. They should still show up the next time Chrome is started (after clicking 'Update now') * Clicking "hide this message" should hide the promo and it shouldn't come back on refresh. * Installing or uninstalling any app should hide the promo, and it shouldn't come back. * If the keys from the preferences are removed, but apps are left installed, the default apps should not be installed when clicking 'update now'. * The default apps should only be installed in locale en-US. Review URL: http://codereview.chromium.org/3522015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62084 0039d316-1c4b-4281-b951-d872f2087c98
* base: Finish moving the SplitString functions from string_util.h to ↵tfarina@chromium.org2010-09-243-0/+3
| | | | | | | | | | | string_split.h BUG=None TEST=trybos Review URL: http://codereview.chromium.org/3447008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60422 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce console spam from master_preferences.evan@chromium.org2010-09-201-4/+2
| | | | | | | | | | It's ok (and common) for master preferences to not exist. TEST=compiles Review URL: http://codereview.chromium.org/3413022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59984 0039d316-1c4b-4281-b951-d872f2087c98
* When uninstalling, only attempt to unregister DLLs if in ChromeFrame mode.robertshield@chromium.org2010-09-161-2/+3
| | | | | | | | | BUG=53135 TEST=When uninstalling Chrome, there are no DLL unregistration messages in the uninstall log. Review URL: http://codereview.chromium.org/3461001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59648 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies the toast randomization behavior to be en-US only.gwilson@google.com2010-09-161-2/+5
| | | | | | | | | | | R=finnur BUG=none TEST=toast should not have experimental text in non-en-US locales. Review URL: http://codereview.chromium.org/3399010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59647 0039d316-1c4b-4281-b951-d872f2087c98
* Make licenses.py happy about xz license.phajdan.jr@chromium.org2010-09-132-1/+1
| | | | | | | | BUG=55166 TEST=licenses.py scan Review URL: http://codereview.chromium.org/3333032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59273 0039d316-1c4b-4281-b951-d872f2087c98
* Change the toast text and make sure errors are written tofinnur@chromium.org2010-09-101-34/+47
| | | | | | | | | | | | | | | | | | | HKLM too (not just success messages). The toast text changes are listed in the bug; basically we have 4 experiments that differ only in the text we display as a headline. I also fixed an issue raised by QA with error codes being written to HKCU as opposed to HKLM. This should fix that issue. BUG=http://crbug.com/54835, http://crbug.com/44378 TEST=Requires manual testing by QA. Review URL: http://codereview.chromium.org/3341026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59102 0039d316-1c4b-4281-b951-d872f2087c98
* Add termination of the chrome frame helper process to the uninstaller.robertshield@chromium.org2010-09-093-18/+36
| | | | | | | | | | | Also, alphabetize constants in util_constants.h|cc. BUG=53127 TEST=Uninstall user-level Chrome Frame. The chrome_frame_helper.exe process is no longer running. Review URL: http://codereview.chromium.org/3298020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58940 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 14:25:43 +0000