| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
It's ok (and common) for master preferences to not exist.
TEST=compiles
Review URL: http://codereview.chromium.org/3413022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53135
TEST=When uninstalling Chrome, there are no DLL unregistration messages in the uninstall log.
Review URL: http://codereview.chromium.org/3461001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=finnur
BUG=none
TEST=toast should not have experimental text in non-en-US locales.
Review URL: http://codereview.chromium.org/3399010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=55166
TEST=licenses.py scan
Review URL: http://codereview.chromium.org/3333032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HKLM too (not just success messages).
The toast text changes are listed in the bug; basically we
have 4 experiments that differ only in the text we display
as a headline.
I also fixed an issue raised by QA with error codes being
written to HKCU as opposed to HKLM. This should fix that
issue.
BUG=http://crbug.com/54835, http://crbug.com/44378
TEST=Requires manual testing by QA.
Review URL: http://codereview.chromium.org/3341026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, alphabetize constants in util_constants.h|cc.
BUG=53127
TEST=Uninstall user-level Chrome Frame. The chrome_frame_helper.exe process is no longer running.
Review URL: http://codereview.chromium.org/3298020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3232003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53127
TEST=chrome_frame_helper.exe and chrome_frame_helper.dll are included in the installation files.
Review URL: http://codereview.chromium.org/3308011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54506
TEST=mini_installer.exe
Review URL: http://codereview.chromium.org/3329013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
installs to the right registry key.
This time with the two boolean parameters in process_util_win.cc:281 flipped to match the function signature.
TBR=cpu
BUG=44378
TEST=None
Review URL: http://codereview.chromium.org/3297015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This seems to have caused some ui_tests to fail (AllowCookies, BlockCookies)
Original comment:
Write the outcome of the Toast Experiment for system-level installs to the right registry key.
BUG=44378
TEST=None
Review URL: http://codereview.chromium.org/3308003
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3369002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
right registry key.
BUG=44378
TEST=None
Review URL: http://codereview.chromium.org/3308003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DLLS to the installer registration code when not running as system-level. This provides means for DLLs to register in different modes depending on installation type.
BUG=53127
TEST=NONE
Review URL: http://codereview.chromium.org/3299008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
install.
Read "make_default_for_user" preference from master_preferences file and set Chrome to default in installer if we are updating Chrome instead of installing a new version.
The problem here is that now that we set the default browser preference from a web page, we are using master_preferences to communicate this desire to the browser.
Because the user already has Chrome installed on his/her machine, the master_preferences file will not be written to their machine.
Instead, we check for this preference in the installer itself, and set Chrome to be default for the user here.
BUG=53656
TEST=Have Chrome installed on your machine, but *not* default browser. Run setup.exe to install a new version of Chrome, with a master_preferences file that includes the distribution preference "make_default_for_user":true. (This reflects what happens when the user downloads Chrome with the "make default" option checked).
Chrome should be default browser.
Review URL: http://codereview.chromium.org/3342002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a runtime dependency of D3DX9 which is needed to make ANGLE work on Windows.
TEST=will run try when blocking CL is landed
BUG=none
Review URL: http://codereview.chromium.org/3134037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44644
TEST=base_unittests --gtest_filter=RegistryTest.*
Review URL: http://codereview.chromium.org/3104032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landed issue 3032040 on darin@'s behalf. Original:
http://codereview.chromium.org/3032040/show
The issue with the introducation of a dependency on msvcr80.dll mentioned in the original issue comments is resolved. It seemed to be specific to darin's build configuration.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/3118001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
utf_string_conversions.h
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3148019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Doc updates will follow in another CL.
BUG=48117
TEST=ExtensionsServiceTest.(UpdatePendingExternalCrx,UpdatePendingCrxThemeMismatch,ExternalPrefProvider), ExtensionManagmentTest.ExternalUrlUpdate, manual testing.
Review URL: http://codereview.chromium.org/3005057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3093013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Get{Boolean,Integer,Real,Binary,Dictionary,List}().
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3187004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3117017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3179017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove the default arguments from the constructor.
- Add a empty constructor to handle the case of the default arguments were used.
BUG=44644
TEST=trybots
Review URL: http://codereview.chromium.org/3172009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move destructor implementation to source file.
- Remove the default argument used in CreateWithDisposition function.
BUG=44644
TEST=trybots
Review URL: http://codereview.chromium.org/3100001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unify extension package creation code between command line and GUI methods.
Properly handle extension names with periods or trailing slashes.
Don't DCHECK when creating packages from the command line.
BUG=14720, 19103, 51110
TEST=run 'chrome --pack-extension=has.a.dot/' on an extension with period in its name; make sure it is packed correctly and a message indicating success is printed.
Review URL: http://codereview.chromium.org/3077022
Patch from Ilya Sherman <isherman@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
installs and only to HKLM for system-level installs. This avoids touching registry keys that we shouldn't when installing system-level and that we can't when installing user-level.
BUG=33532
TEST=System-level installs do not touch HKCU, user-level installs do not try to touch HKLM. (Can be verified with e.g. procmon).
Review URL: http://codereview.chromium.org/3056016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
--delete-profile flag.
BUG=51692
TEST=CF uninstalls delete the profile directory.
Review URL: http://codereview.chromium.org/3172001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use wchar_t instead of TCHAR.
- Use DCHECK instead of assert.
- Remove this keyword (we don't use it on chromium).
- Add DISALLOW_COPY_AND_ASSIGN to the classes.
- Make it more compliant with chromium code style.
- Remove ununsed methods.
- Use arraysize macro for array size calculation instead of doing it manually.
BUG=44644
TEST=trybots
TODO: Write unittests for this API.
TODO: Remove all the default arguments from the methods in this API. They aren't allowed by our style guide.
Review URL: http://codereview.chromium.org/3007037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2819094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3057033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3071012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r54966.
Meant to try it, not commit it, sorry everyone. :(
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3057033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
string_number_conversions.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3054036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ASCIIToUTF16. I removed string_util includes from a few places where it
obviously wasn't needed.
In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm
going to do an even later pass to find the unnecessary string_util.h includes
and remove them.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3058027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
weird that UTF8ToWide is in utf_string_conversions, but ASCIIToWide is in
string_util.h. This should help some dependencies since string_util changes
much more frequently than utf_string_conversions and fewer files will now need
string_utils.
Since this requires a lot of changes, this keeps a forward-declaration in
string_util so I can update the entire project incrementally. This change
updates base and net only.
I removed some includes of string_util from header files in net. In particular,
url_request_context which involved creating a new .cc file to implement a
function (already virtual so there's no speed penalty). It turns out a lot of
files were getting string_util from this include, so I had to update a bunch of
random files to now explicitly include string_util.h
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3076013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
string_number_conversions.h
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3013046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mal
Review URL: http://codereview.chromium.org/3057026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=mal
Review URL: http://codereview.chromium.org/3032040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Everything now needs to be changed to avoid the deprecated wstring methods; this
includes the unit tests.
BUG=23581
TEST=all our tests still pass
Review URL: http://codereview.chromium.org/3075010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3037034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3068004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=50266
TEST=None
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/3046028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.
r=jar
BUG=47469
Review URL: http://codereview.chromium.org/3032024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=compile
BUG=44549
Review URL: http://codereview.chromium.org/3032025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=run with --organic --first-run
Review URL: http://codereview.chromium.org/3047011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=asargent
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This only shows the existing exceptions (doesn't allow you to add or remove them). It also only works for image exceptions. It always shows the exceptions, instead of hiding/showing them when you press the exceptions button.
BUG=48862
TEST=manual
Review URL: http://codereview.chromium.org/2856058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53542 0039d316-1c4b-4281-b951-d872f2087c98
|