| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
GetChannel was confused in multi-user installs. It treated them as
CHANNEL_UNKNOWN instead of their correct channels.
BUG=81218
TEST=none
Review URL: http://codereview.chromium.org/6893158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UserExperimentDetails. The lesson learned is that braces must be present for the following pattern:
if (cond) {
DCHECK_*(...);
} else
...
Since the DCHECK_op macros expand to if (blahdebla).
BUG=none
TEST=none
R=finnur@chromium.org
Review URL: http://codereview.chromium.org/6883264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is absent (an absent "ap" means the same thing as an empty "ap" value, namely Stable). Do this by causing ChannelInfo::Initialize to not return false when the "ap" value is missing.
Update unit tests that were checking for the old behaviour of ChannelInfo.
BUG=80683
TEST=Install Stable channel Chrome on Windows. Go to the about box. Observe that the string "unknown" does not show up in the version number.
Review URL: http://codereview.chromium.org/6901070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76996
TEST=none
Review URL: http://codereview.chromium.org/6894040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
canary, matching the Mac canary and the new approved naming.
BUG=79814
TEST=The About window
Review URL: http://codereview.chromium.org/6895022
Review URL: http://codereview.chromium.org/6897028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the Windowscanary, matching the Mac canary and the new approved naming.BUG=79814TEST=The About windowReview URL: http://codereview.chromium.org/6895022
Get rid of redness in official bulder
TBR=mark@chromium.org
Review URL: http://codereview.chromium.org/6900027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
canary, matching the Mac canary and the new approved naming.
BUG=79814
TEST=The About window
Review URL: http://codereview.chromium.org/6895022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=79814
TEST=none
Review URL: http://codereview.chromium.org/6900013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
use base.dll from chrome.
BUG=76996
TEST=none
Review URL: http://codereview.chromium.org/6877053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=79814
TEST=none
Review URL: http://codereview.chromium.org/6883056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content now.
TBR=avi
Review URL: http://codereview.chromium.org/6875018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=74035
TEST=see bug
Review URL: http://codereview.chromium.org/6813099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=78938,78143
TEST=Icon updates correctly between versions and is created correctly on first install.
Review URL: http://codereview.chromium.org/6865004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
could be in use while npchrome_frame.dll isn't.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6677078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6840056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
function.
BUG=79203
TEST=None
R=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/6838025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fix linux_chromeos build by adding an appropriate #ifdef on upgrade_util_linux.cc.
BUG=79203
TEST=None
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/6839021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Revert 81409 - first-run: Refactor Upgrade class into a common upgrade_util API.BUG=79203TEST=NoneR=jhawkins@chromium.orgReview URL: http://codereview.chromium.org/6840003
TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/6835022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=79203
TEST=None
R=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/6840003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix up all the callers to use the new location and namespace.
Also, delete the stub file since it isn't included by anyone more.
(Note: This was a TODO for brettw).
BUG=None
TEST=None
R=brettw@chromium.org
Review URL: http://codereview.chromium.org/6825055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=See repro steps in bug report.
BUG=79178
Review URL: http://codereview.chromium.org/6823086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=73854
TEST=unit_tests
Review URL: http://codereview.chromium.org/6793008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
accessors to the singleton for more values that various code wants, then convert almost everyone using OSVERSIONINFO or SYSTEM_INFO structs to calling these accessors. Declare an AtExitManager in the out-of-process test runner since it didn't have one and that breaks singleton-using code in the test executable (as opposed to in chrome.dll).
A few other minor cleanups along the way (binding of "*", shorter code, etc.). Because I ran into problems with it while modifying gcapi.cc, I cleaned up our usage of strsafe.h a bit, so that files that don't need it don't include it and files that do use STRSAFE_NO_DEPRECATE instead of a modified #include order.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6816027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=pkasting@chromium.org
Review URL: http://codereview.chromium.org/6816024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
accessors to the singleton for more values that various code wants, then convert almost everyone using OSVERSIONINFO or SYSTEM_INFO structs to calling these accessors. Declare an AtExitManager in the out-of-process test runner since it didn't have one and that breaks singleton-using code in the test executable (as opposed to in chrome.dll).
A few other minor cleanups along the way (binding of "*", shorter code, etc.). Because I ran into problems with it while modifying gcapi.cc, I cleaned up our usage of strsafe.h a bit, so that files that don't need it don't include it and files that do use STRSAFE_NO_DEPRECATE instead of a modified #include order.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6713107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6802015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
buffer class that doesn't throw exceptions.
The new buffer class is pretty simple and relies on the MemoryAllocator class that I previously to back large
allocations with mapped files when memory is scarce. That reduced the number of crashes quite a bit but we
still crash on machines that are simply out of diskspace as well. So, the right thing to do is to expect and
handle failures which is what this cl is all about. What we should see once this has landed is that crash
dumps due to courgette running out of disk space should disappear from crash/ and instead we should see the
number of users that run into this particular problem in dashboards.
TEST=Courgette out-of-memory/out-of-diskspace errors should disappear from crash/
BUG=74777
Review URL: http://codereview.chromium.org/6677141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
dialog based on brand codes.
Also, remove crufty old FirstRun::InSearchExperimentLocale.
BUG=none
TEST=new google_update_settings_unittest, and search engine selection shows only for brand codes beginning with EU or GG.
Review URL: http://codereview.chromium.org/6677134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
installed on top of user-level installations.
Remove a now-unused installer string.
BUG=73253
TEST=Install user-level Chrome at version X. Install system-level install at the same version. System level install succeeds.
Review URL: http://codereview.chromium.org/6726032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the default browser on pre-Vista systems (and/or for software running on Vista that checks legacy registry keys).
BUG=67355
TEST=install Chrome, making it the default browser. uninstall it and check the box to make Firefox or IE the new default. try following a link in some application which should result in a browser starting up. notice that the chosen default browser starts.
Review URL: http://codereview.chromium.org/6746006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=12947,13008,13087,13144,13280,13479,13480,13574,13575,13576,13580,13594,
13595,14186,14351
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/6733043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
system-level chrome creates a shortcut in the user's current desktop.
BUG=5073
TEST=Install system-level Chrome, observe a Chrome shortcut is created in the All Users desktop. Run Chrome, observe that no duplicate shortcut is created.
Review URL: http://codereview.chromium.org/6731018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
R=darin@chromium.org,brettw@chromium.org,jam@chromium.org,ben@chromium.org
Review URL: http://codereview.chromium.org/6534012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
In r79038, I moved the inspector files into resources.pak, so
we don't need to include the directory anymore.
Review URL: http://codereview.chromium.org/6722010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add the ability to have different experiments based on brand code.
BUG=76594
TEST=For the en-US locale, take an old build and a build that includes this fix. Install the old build, set the brand code in the registry to SKPN and set the clock forward by more than a month. Install the new build and make sure you get a toast that references Skype. Change the brand code to anything else, ABCD for example, and make sure you get the generic toast (there are four possible). Then try with locale 'ja' and make sure you get a Japanese toast. Please test this also with system-install of Chrome (enough to just do Skype brand code, I guess).
Review URL: http://codereview.chromium.org/6712015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gives 'out of the box' compatability with VC2008 express - i.e. no modifications needed to system headers or .gyp* files or related hacks. Just set the GYP_MSVS_VERSION to 200Xe (e for express, same as the linked blog on the issue and first google hit as well).
1) Changes to build\common.gypi to turn off to define COMPILER_MSVC_EXPRESS if a express is detected (through the GYP_MSVC_VERSION environment variable), turn off the _SECURE_ATL define (which is flagged as an error with WinDDK's ATL, _SECURE_ATL adds [more] CRT checks to other ATL versions) and hard to link to the atl stdthunk library with express editions. Also, explicitly link to the base WinSDK libraries in common.gypi and mini_installer.gypi for MSVC 2005 express.
2) Fixes a few .cc files that have the wrong include order with the ATL headers when using the Windows DDK ATL. The Windows DDK ATL brings in intsafe.h (WinSDK, not WinDDK) with atlwin.h and generates multiple INTXX_MIN/MAX def warnings which get
flagged as errors with the warnings as errors flag if not included before other libraries that have the same definitions like ICU.
3) Changes to .rc files to avoid pulling in afxres.h (an MFC header -
it's available in the WinDDK) and winres.h which VCExpress doesn't have (it's available in a WinSDK sample, but that kind of the purpose of it). The main Chromium .rc files are already structured this way, I just changed the rest and changed the output of grit to do the same.
4) Removes the memset obj file linking in mini_installer.gyp and simply implements memset for mini_installer.cc.
Only changes to the chromium branch now. There are some .rc files in the Python26, Native Client, and Angle in samples that could #3 changes. They are not required for Chromium, however.
------
VC2005SP1 can be downloaded at
http://www.microsoft.com/downloads/en/details.aspx?FamilyId=7B0B0339-613A-46E6-AB4D-080D4D4A8C4E&displaylang=en
(or non-SP1 at http://download.microsoft.com/download/8/3/a/83aad8f9-38ba-4503-b3cd-ba28c360c27b/ENU/vcsetup.exe)
VC2008SP1 can be downloaded at
http://www.microsoft.com/downloads/en/details.aspx?FamilyId=F3FBB04E-92C2-4701-B4BA-92E26E408569&displaylang=en
currently.
The base developer instructions work fine afterwards with a couple tweaks for express versions:
http://www.chromium.org/developers/how-tos/build-instructions-windows
Under "Additional (free) downloads" under step 2:
X) Only the first 3 Non-SP KB Patches are needed for express. Don't forget to forget GYP_MSVS_VERSION environment as appropriate - 2008e for Visual C++ 2008 Express, for example.
Under "Additional (free) downloads" after step 5
[These only apply to 2008 express, 2005 works fine out of the box]:
6A) Download the WinDDK for the atl headers and libs -
http://msdn.microsoft.com/en-us/windows/hardware/gg487463.aspx. It works fine, but you do not need to install the whole DDK. In the WDK directory just install headers.msi, libs_x86fre.msi, and libs_x64fre.msi; just grab the atl headers and atl*.lib libs; right click the installers and uninstall afterwards. Add the appropriate include and lib paths to your global settings.
6B) To build x64 targets (x64 Native Client) download:
http://www.cppblog.com/Files/xcpp/VCE64BIT_WIN7SDK.zip
Follow the readme instructions.
Further information behind that and x64 target building with express:
- http://jenshuebel.wordpress.com/2009/02/12/visual-c-2008-express-edition-and-64-bit-targets/
- http://www.cppblog.com/xcpp/archive/2009/09/09/vc2008express_64bit_win7sdk.html
----------------
BUG=1433, 5026, 72885
TEST=Compiles in both Debug and Release mode in Visual C++ Express 2008/2005 and does not effect other build setups. In addition, the WinDDK ATL compiles with the secure_atl=0 in the GYP_DEFINES environment variable on non-express versions of MSVC.
Review URL: http://codereview.chromium.org/6676030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76400
TEST=Try out the toast experiment, both at user- and system-level.
Review URL: http://codereview.chromium.org/6670087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/6672070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
represented by pv and opv, don't keep an arbritarily large number of intermediate versions across in-use updates.
BUG=75951,22293
TEST=Intermediate update folders are deleted during successive upgrades with an in-use chrome. Also, installer_util_unittests.exe.
Review URL: http://codereview.chromium.org/6670047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The setup API and tools such as expand.exe and makecab.exe all use the cabinet API.
However, the setup API has additional dependencies that we don't need or want
in the mini installer. So, this is a part of a pet pieve effort of mine to
remove these dependencies and hopefully reduce the number of installation failures.
TEST=Run accompanied unit test and also make sure that the mini installer works as before.
BUG=none
Review URL: http://codereview.chromium.org/6693015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Installation failures due to out-of-disk-space seem to be getting more
and more frequent and upon inspection, I found that we can in some cases
do a terrible job and leave cruft behind. Worst of all we can do this if
an installation fails due to low free disk space, thus only adding to the
problem. I suspect there maybe users stuck on a specific revision of
Chrome because of this.
I'm also implementing Robert's idea of supporting for a --cleanup command
line arg that can be passed to the mini installer to only do the cleanup
and not the installation.
BUG=74777
TEST=This should reduce the number of crashes we're getting due to out of disk space.
Review URL: http://codereview.chromium.org/6670023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=fixes crash in unit test
TBR=grt
Review URL: http://codereview.chromium.org/6670048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61609
TEST=Did run value gets written to the multi-install clientstate key as well as to the product client state key.
Review URL: http://codereview.chromium.org/6648008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: http://codereview.chromium.org/6679007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to save some disk space.
BUG=none
TEST=do an upgrade and see that the chrome.7z in the old version folder is gone.
Review URL: http://codereview.chromium.org/6683005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
anymore.
BUG=75842
TEST=
TBR=jshin@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
There are probably a few more bits and pieces that can be removed, but I think this is the majority of it.
BUG=51934
Review URL: http://codereview.chromium.org/6576020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=69484
TEST=Follow steps in bug. Upon cancel, Chrome and Chrome Frame ready-mode should both still be installed.
Review URL: http://codereview.chromium.org/6679009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also add check for multi-install Chrome, and update comment for GoogleUpdateSettings::GetChromeChannel to indicate "-m" tags on multi-install channels.
BUG=75783
TEST=promo shows up correctly for stable build, not where it shouldn't.
Review URL: http://codereview.chromium.org/6685003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77850 0039d316-1c4b-4281-b951-d872f2087c98
|