| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3068004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=50266
TEST=None
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/3046028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.
r=jar
BUG=47469
Review URL: http://codereview.chromium.org/3032024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=compile
BUG=44549
Review URL: http://codereview.chromium.org/3032025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=run with --organic --first-run
Review URL: http://codereview.chromium.org/3047011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=asargent
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This only shows the existing exceptions (doesn't allow you to add or remove them). It also only works for image exceptions. It always shows the exceptions, instead of hiding/showing them when you press the exceptions button.
BUG=48862
TEST=manual
Review URL: http://codereview.chromium.org/2856058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DeleteTreeWorkItems with simple deletes, since we don't care to rollback the attempts to delete our temp files. This avoids a redundant copy and deletion of the temp files.
BUG=25878
TEST=Chrome / Chrome Frame installer spends less time between the verbose log traces "Deleting temporary directory" and "list execution succeeded".
Review URL: http://codereview.chromium.org/2870066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
<iostream> creates a static initializer. Most people don't need <iostream>
anyway--they really need <ostream> for operator<< overloads. <iostream>
should *never* be included in a header file; <iosfwd> exists for that purpose.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3014015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38334,48921
TEST="mini_installer --chrome-sxs", check about box, about:version, start menu shortcut name
Review URL: http://codereview.chromium.org/2931018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
namespace.
This function is used in one place and is deprecated, so would be good to move
it there so no one can make other uses of it.
BUG=24672
TEST=trybots
Review URL: http://codereview.chromium.org/2809049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be registered (and thus used) if the installer is run with the --chrome-frame flag.
Remove a bunch of CF-specific code in the process.
BUG=46818
TEST=Can use the same mini_installer.exe to install either Chrome or Chrome Frame.
Review URL: http://codereview.chromium.org/2839009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2836041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
malloced separately.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2810030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now with one line fix to fix the mac build.
BUG=35793,42770
TEST=none
TBR=tony
Review URL: http://codereview.chromium.org/2842025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=35793,42770
TEST=none
Review URL: http://codereview.chromium.org/2817026
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/2855021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to be even more effective. This reduces the size of liblzma_decompress.dylib
by 16kB, and reduces the size of differential updater disk images by 8kB.
BUG=47199
TEST=none
Review URL: http://codereview.chromium.org/2860019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35793,42770
TEST=none
Review URL: http://codereview.chromium.org/2817026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2838025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18185
TEST= add "suppress_first_run_bubble:true" to distribution section of master_preferences. run as first_run, and watch bubble not appear.
Review URL: http://codereview.chromium.org/2812022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows for the bookmark manager to work after upgrading
in the background on Linux.
BUG=42770
TEST=Bookmark manager still works
Review URL: http://codereview.chromium.org/2814009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=47199
TEST=none
Review URL: http://codereview.chromium.org/2866015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In testing, cases were discovered where fread would read until EOF, but
lzma_code would not be able to decompress that entire block in one call
because not enough space was available in the output buffer. Calling lzma_code
with LZMA_FINISH followed by LZMA_RUN is incorrect. Once LZMA_FINISH is used
once, subsequent calls to lzma_code must also use LZMA_FINISH.
From <lzma/base.h>:
* After the first use of LZMA_SYNC_FLUSH, LZMA_FULL_FLUSH, or LZMA_FINISH,
* the same `action' must is used until lzma_code() returns LZMA_STREAM_END.
* Also, the amount of input (that is, strm->avail_in) must not be modified
* by the application until lzma_code() returns LZMA_STREAM_END. Changing the
* `action' or modifying the amount of input will make lzma_code() return
* LZMA_PROG_ERROR.
This bug caused goobspatch to exit prematurely with a message like
goobspatch: xzread(extra, 216): 11
11 is LZMA_PROG_ERROR.
BUG=47199
TEST=none
Review URL: http://codereview.chromium.org/2875008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50537 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=47199
TEST=none
Review URL: http://codereview.chromium.org/2801016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=47199
TEST=none
Review URL: http://codereview.chromium.org/2805024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
OS X:
Add an unpatched version of xz, XZ Utils, to /trunk/deps/third_party.
BUG=47199
TEST=none
Review URL: http://codereview.chromium.org/2846025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=erg
Review URL: http://codereview.chromium.org/2827019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the same as r50257 with 2 fixes:
1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will
work for things tests.
2) Add back the check in chrome_paths.cc to see if we're in a
mac bundle or not.
BUG=35793,42770
TEST=none
Review URL: http://codereview.chromium.org/2865010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
indices.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2820015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add an option in the master_preferences to randomize the order of logos in the search engine selection screen. This allows us to cull out a small subset of users to take part in a test of the effects of logo position on search engine choice.
I also filed http://crbug.com/46606 to remind me to revert this change when testing is complete.
BUG=46302
TEST=Add the following options to master_preferences:
"distribution": {
"search_engine_experiment": true,
"search_engine_experiment_randomize": true
}
Run a few times as --first-run, and see search engines appear in random order in the selection box.
Review URL: http://codereview.chromium.org/2808006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I'm pretty sure the problem is due to users downgrading to versions where --product-version is not available. See the bug for more details.
BUG=46547
TEST=none
Review URL: http://codereview.chromium.org/2813005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There is no standalone dmgpatcher tool because the operation is tied too
closely to Keystone update application, but keystone_install is now able to
perform the dmgpatcher operation as an inverse to what dmgdiffer does when it
creates patch update disk images given an "old" and "new" existing disk image.
If keystone_install detects a .patch directory, it applies the dirpatches that
are contained therein using dirpatcher and goobspatch. keystone_install
expects two dirpatches: one for the versioned directory, and one for the outer
app bundle. These two dirpatches correspond exactly to the two rsyncs that
keystone_install performs when updating from a full-install disk image.
BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2832005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2799006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2821001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in the update. This will allow keystone_install.sh to read the correct values
for the intended purposes.
BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2821002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fix MIN_BUILD. Oops.
BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2833002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use += to append to arrays.
Declare err before it's used.
Use -L to test for symbolic links.
BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2799003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original change: Fix problem whereby the "-full" magic value is removed from the
"ap" value when a differential update for CF fails (it should remain unless the
update succeeds).
Also, fix problem with installer return codes being squashed. This was a
regression introduced in
http://src.chromium.org/viewvc/chrome?view=rev&revision=41322.
BUG=46051,40607
TEST=Cause a differential update to fail, observe that the "ap" value contains a
"-full".
TBR=ananta
Review URL: http://codereview.chromium.org/2737006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
disk images.
BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2761006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2765008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to be signed independently of the outer browser application bundle.
BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2749014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
installer-related files from chrome/tools/build/mac to chrome/installer/mac.
BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2755007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
dirdiffer.
BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2715011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44572
TEST=see bug
Review URL: http://codereview.chromium.org/2616002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
or a signal is received during operation.
BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2737007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and to drive directory tree patching. dirdiffer wraps goobsdiff, and
dirpatcher wraps goobspatch.
BUG=45017
TEST=none
Review URL: http://codereview.chromium.org/2765003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 49346 - Fix problem whereby the "-full" magic value is removed from the "ap" value when a differential update for CF fails (it should remain unless the update succeeds).
Also, fix problem with installer return codes being squashed. This was a regression introduced in http://src.chromium.org/viewvc/chrome?view=rev&revision=41322.
BUG=46051,40607
TEST=Cause a differential update to fail, observe that the "ap" value contains a "-full".
Review URL: http://codereview.chromium.org/2773002
TBR=robertshield@chromium.org
Review URL: http://codereview.chromium.org/2725007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37129,38334
TEST=install sxs, check about box, about:version, start menu shortcut name
Review URL: http://codereview.chromium.org/2753003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49352 0039d316-1c4b-4281-b951-d872f2087c98
|