| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
places.I'm also adding a constant for CEEE - I named it kCeee instead of kEnableCeee since it's also used in uninstalls.This change is just a beginning of being aware of having more than one product available in setup.
I added some todos and dcheck for myself to keep track of places that will need more significant changes when running multiple installs.
BUG=61609
TEST=All installations (chrome, chrome frame, ceee) should work as before with the exception that the CEEE switch is now --ceee and not --enable-ceee.
Review URL: http://codereview.chromium.org/4635006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also adding a bit of logging for easier diagnostics when we can't remove a folder due to files being in use on uninstall.
TEST=Should improve our chances of being able to uninstall without needing to reboot.
BUG=61609
Review URL: http://codereview.chromium.org/4773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The common case is for this file to not be available; we don't need
to report it as an error each time.
I improved this in r59984, but it regressed in r64945.
Review URL: http://codereview.chromium.org/4740003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
to google_update_settings.cc until the bug is fixed
BUG=62121
TEST=none
Review URL: http://codereview.chromium.org/4655005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65573 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Now there's a class named MasterPreferences that owns
the json dictionary and supports methods that previously
were global.
* There's now a global object for the current process'
master preference object, which avoids parsing the
preference file multiple times.
* Refactored the tests to be more data driven
TEST=Run the installer util unit tests. Set the filter to
*MasterPref* if you only want to run the tests affected by
this change.
BUG=none
Review URL: http://codereview.chromium.org/4342001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should fix conflicts like:
2>d:\src\chromium_src2\src\base/string_util.h(480) : error C2904: 'CaseInsensitiveCompare' : name already used for a template in the current scope
2> d:\src\chromium_src2\src\third_party\xulrunner-sdk\win\include\xpcom\nsStringAPI.h(1406) : see declaration of 'CaseInsensitiveCompare'
Reported-by: Jeff Timanus <twiz@google.com>
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/4366001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
through, either because they were LOG_IF() (which I didn't search for) or they were added during the week I was changing things.
Plus a few misc. cleanup bits.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4111002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
when running in Chrome Frame mode.
Also fix the installer_util_strings target that had a broken dependency on a file that has since been moved.
BUG=46013
TEST=Google Chrome Frame is correctly displayed when the installer is run in Chrome Frame mode.
Review URL: http://codereview.chromium.org/3968005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also remove some extra {}s, avoid "else" after "return"/use some early returns, and simplify some code.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3931004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=kuchhal
BUG=59783, 59784, 59785
TEST=installer_util_unittests
Review URL: http://codereview.chromium.org/3764015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
removes windows_message_list which isn't used.
This keeps a stub for registry in the old location until we can update that.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3836005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base::win namespace.
This keeps old headers that forward to the new versions and have using declarations that allow the existing code to compile. I fixed all the callers in base to use the new ones, and also the other files I happened to touch.
This splits out the stuff from scoped_handle into a few separate files. I just deleted ScopedFindFile since it was only used in one place and it wasn't even really helping there.
I removed StackBstr which was a #define and used the "regular" ScopedBstr in the 7 places that used it. This is an optimization to avoid an extra allocation, but none of the callers are remotely performance critical.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3781009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/win/windows_version. Many files now only need to include this instead of all of win_util.
Remove a bunch of unused code from base/win_util. There was a surprising amount.
Replace the AppUserModel property key with the one from the SDK now that we use the Win7 SDK. Move GetLogonSessionOnlyDACL from win_util to ipc since it's only used in that one place.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was already removed on non-Windows, so this change modifies
the remaining Windows-specific usage. In a few places I converted
use of wstring paths into FilePath, but in general for Windows-specific
code I don't think it's too important to use FilePath everywhere,
because it is equivalent on Windows and the current code already works.
BUG=23581
Review URL: http://codereview.chromium.org/3817001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3750001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
only place where it's used.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3696001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the component extension system, simply install them as
normal apps the first time Chrome runs. Remove the old
style default apps.
This also removes support for --disable-apps, which doesn't
seem necessary since we already have --disable-extensions.
BUG=53972
TEST=Uninstall any installed apps. Remove the
"default_apps_installed" and "app_promo_counter" keys from
Preferences if they are present.
Start Chrome with the --enable-default-apps flag, navigate
to chrome://extensions/, and click "update now" in the
developer tools. This is to make the updater grab the
apps from the store quicker, so that you don't have to wait
while testing. Normally Chrome would do this by itself
after 5-40 mins.
Go to NTP. You should see gmail, calendar, and docs default
apps show up along with the promo (the text that says "New!
A world of ...").
Refresh the NTP 10 times. The promo should go away on the
10th time.
There are other details. To test each of these, remove all
installed apps and remove the keys from the preferences to
reset the state.
* If you close Chrome before getting the default apps. They
should still show up the next time Chrome is started (after
clicking 'Update now')
* Clicking "hide this message" should hide the promo and it
shouldn't come back on refresh.
* Installing or uninstalling any app should hide the promo,
and it shouldn't come back.
* If the keys from the preferences are removed, but apps
are left installed, the default apps should not be
installed when clicking 'update now'.
* The default apps should only be installed in locale
en-US.
Review URL: http://codereview.chromium.org/3522015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
string_split.h
BUG=None
TEST=trybos
Review URL: http://codereview.chromium.org/3447008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It's ok (and common) for master preferences to not exist.
TEST=compiles
Review URL: http://codereview.chromium.org/3413022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53135
TEST=When uninstalling Chrome, there are no DLL unregistration messages in the uninstall log.
Review URL: http://codereview.chromium.org/3461001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=finnur
BUG=none
TEST=toast should not have experimental text in non-en-US locales.
Review URL: http://codereview.chromium.org/3399010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=55166
TEST=licenses.py scan
Review URL: http://codereview.chromium.org/3333032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HKLM too (not just success messages).
The toast text changes are listed in the bug; basically we
have 4 experiments that differ only in the text we display
as a headline.
I also fixed an issue raised by QA with error codes being
written to HKCU as opposed to HKLM. This should fix that
issue.
BUG=http://crbug.com/54835, http://crbug.com/44378
TEST=Requires manual testing by QA.
Review URL: http://codereview.chromium.org/3341026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, alphabetize constants in util_constants.h|cc.
BUG=53127
TEST=Uninstall user-level Chrome Frame. The chrome_frame_helper.exe process is no longer running.
Review URL: http://codereview.chromium.org/3298020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3232003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53127
TEST=chrome_frame_helper.exe and chrome_frame_helper.dll are included in the installation files.
Review URL: http://codereview.chromium.org/3308011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54506
TEST=mini_installer.exe
Review URL: http://codereview.chromium.org/3329013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
installs to the right registry key.
This time with the two boolean parameters in process_util_win.cc:281 flipped to match the function signature.
TBR=cpu
BUG=44378
TEST=None
Review URL: http://codereview.chromium.org/3297015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This seems to have caused some ui_tests to fail (AllowCookies, BlockCookies)
Original comment:
Write the outcome of the Toast Experiment for system-level installs to the right registry key.
BUG=44378
TEST=None
Review URL: http://codereview.chromium.org/3308003
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3369002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
right registry key.
BUG=44378
TEST=None
Review URL: http://codereview.chromium.org/3308003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DLLS to the installer registration code when not running as system-level. This provides means for DLLs to register in different modes depending on installation type.
BUG=53127
TEST=NONE
Review URL: http://codereview.chromium.org/3299008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58621 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
install.
Read "make_default_for_user" preference from master_preferences file and set Chrome to default in installer if we are updating Chrome instead of installing a new version.
The problem here is that now that we set the default browser preference from a web page, we are using master_preferences to communicate this desire to the browser.
Because the user already has Chrome installed on his/her machine, the master_preferences file will not be written to their machine.
Instead, we check for this preference in the installer itself, and set Chrome to be default for the user here.
BUG=53656
TEST=Have Chrome installed on your machine, but *not* default browser. Run setup.exe to install a new version of Chrome, with a master_preferences file that includes the distribution preference "make_default_for_user":true. (This reflects what happens when the user downloads Chrome with the "make default" option checked).
Chrome should be default browser.
Review URL: http://codereview.chromium.org/3342002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a runtime dependency of D3DX9 which is needed to make ANGLE work on Windows.
TEST=will run try when blocking CL is landed
BUG=none
Review URL: http://codereview.chromium.org/3134037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44644
TEST=base_unittests --gtest_filter=RegistryTest.*
Review URL: http://codereview.chromium.org/3104032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landed issue 3032040 on darin@'s behalf. Original:
http://codereview.chromium.org/3032040/show
The issue with the introducation of a dependency on msvcr80.dll mentioned in the original issue comments is resolved. It seemed to be specific to darin's build configuration.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/3118001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
utf_string_conversions.h
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3148019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Doc updates will follow in another CL.
BUG=48117
TEST=ExtensionsServiceTest.(UpdatePendingExternalCrx,UpdatePendingCrxThemeMismatch,ExternalPrefProvider), ExtensionManagmentTest.ExternalUrlUpdate, manual testing.
Review URL: http://codereview.chromium.org/3005057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3093013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Get{Boolean,Integer,Real,Binary,Dictionary,List}().
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3187004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3117017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=builds
Review URL: http://codereview.chromium.org/3179017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Remove the default arguments from the constructor.
- Add a empty constructor to handle the case of the default arguments were used.
BUG=44644
TEST=trybots
Review URL: http://codereview.chromium.org/3172009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move destructor implementation to source file.
- Remove the default argument used in CreateWithDisposition function.
BUG=44644
TEST=trybots
Review URL: http://codereview.chromium.org/3100001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unify extension package creation code between command line and GUI methods.
Properly handle extension names with periods or trailing slashes.
Don't DCHECK when creating packages from the command line.
BUG=14720, 19103, 51110
TEST=run 'chrome --pack-extension=has.a.dot/' on an extension with period in its name; make sure it is packed correctly and a message indicating success is printed.
Review URL: http://codereview.chromium.org/3077022
Patch from Ilya Sherman <isherman@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
installs and only to HKLM for system-level installs. This avoids touching registry keys that we shouldn't when installing system-level and that we can't when installing user-level.
BUG=33532
TEST=System-level installs do not touch HKCU, user-level installs do not try to touch HKLM. (Can be verified with e.g. procmon).
Review URL: http://codereview.chromium.org/3056016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
--delete-profile flag.
BUG=51692
TEST=CF uninstalls delete the profile directory.
Review URL: http://codereview.chromium.org/3172001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Use wchar_t instead of TCHAR.
- Use DCHECK instead of assert.
- Remove this keyword (we don't use it on chromium).
- Add DISALLOW_COPY_AND_ASSIGN to the classes.
- Make it more compliant with chromium code style.
- Remove ununsed methods.
- Use arraysize macro for array size calculation instead of doing it manually.
BUG=44644
TEST=trybots
TODO: Write unittests for this API.
TODO: Remove all the default arguments from the methods in this API. They aren't allowed by our style guide.
Review URL: http://codereview.chromium.org/3007037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2819094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3057033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3071012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55034 0039d316-1c4b-4281-b951-d872f2087c98
|