| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a bug in the DllRedirector module loading code.
Expand the alternate version generator code to provide a function for generating new versions of single modules.
Remove the LI SACL from the shared memory lock for Win XP.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6600001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A bunch of hard-coded references to icudt42.dll are updated to
refer to icudt46.dll.
See also http://codereview.chromium.org/6575042/ (and there's one more accompanying CL - internal).
I'll follow up this CL with a change to rename icudtXX.dll to icudt.dll
so that I don't have to do this again next time.
BUG=73991,61514
TEST=daily archived builds have icudt46.dll
Review URL: http://codereview.chromium.org/6580046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
and/or %SystemRoot%. We now do temp work on the same volume as the eventual install. In the case of system-level installs, this has the nice side-effect of allowing us to move the install into place rather than copy it, which should also speed up system-level installs.
BUG=70368
TEST=Set TMP and TEMP env vars to some volume other than the one holding %USERPROFILE% (for user-level installs) or %SystemRoot% (for system-level installs), then see if in-use updates work.
Review URL: http://codereview.chromium.org/6538091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
allow for unconditional overwriting of the output file.
BUG=NONE
TEST=Run alternate_version_generator.exe --force in a directory that already has a mini_installer.exe and a mini_installer_new.exe, observer mini_installer_new.exe get regenerated.
Review URL: http://codereview.chromium.org/6546027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fixes a regression that prevented in-place upgrades of Chrome Frame from working.
BUG=73329
TEST=Follow the steps in the bug. Between steps 4 and 5, check that the "cmd" registry value in HKLM\Software\Google\Update\Clients\{8BA986DA-5100-405E-AA35-86F34A02ACBF} contains "--chrome-frame".
Review URL: http://codereview.chromium.org/6541029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- use ScopedTempDir in work items that need backup space for rollback
- all work items that need backup space take a parent dir in which they create temp dirs
- use ScopedTempDir in a few other places
- renamed some parameters in certain functions so that the same name is used everywhere
While I was at it, I couldn't help but replace Append(UTF8ToWide(version.GetString())) with the more pleasing AppendASCII(version.GetString())
BUG=70368
TEST=existing tests in installer_util_unittests cover the changes
Review URL: http://codereview.chromium.org/6538025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Fix for crash in setup. See bug for details.
BUG=73212
Review URL: http://codereview.chromium.org/6533009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
contains the third and final part of the validator: helper functions to cause the firing of nonfatal test failures for violations. These are to be used by other tests that mutate the machine state.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6499010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
contains the first two parts of the validator:
1. installer::InstallationValidator class, used by setup.exe to confirm that all is well following an installer operation. Violations are logged at ERROR level.
2. validate_installation.exe, used by humans to check the overall state of a machine.
The third part, in which violations fire nonfatal test failures for use in other tests, will follow in a subsequent CL.
BUG=none
TEST=Run validate_installation.exe on machine(s) containing all conceivable permutations of Chrome and Chrome Frame, and see if it reports any violations.
Review URL: http://codereview.chromium.org/6490024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
crt/src/intel/mt_lib/memset.obj and P4_memset.obj
are not distributed with VS2010. For now, include those distributed with 2009. The downside is that you can't
compile with only VS2010 installed.
BUG=25628
Review URL: http://codereview.chromium.org/6509008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
into chrome.packed.7z
BUG=http://code.google.com/p/nativeclient/issues/detail?id=1418
TEST=None
Review URL: http://codereview.chromium.org/6502008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Not handling correctly caused a crash. Added unit tests to cover those cases.
BUG=71953
TEST=covered by installer util unit tests
Review URL: http://codereview.chromium.org/6485026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
broken since r66096.
BUG=72620
TEST=Install user level Chrome then system level Chrome. Observer that user level Chrome removes itself and delegates to system level.
Review URL: http://codereview.chromium.org/6490008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
installation archive.
This is mostly to keep the noise level in the log down (the "directory already exists" entries were over half of the verbose log).
TEST=The only change should be that the verbose installer log should be smaller.
BUG=none
Review URL: http://codereview.chromium.org/6484009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Error 102 (0x66) has one of the highest occurances in setup failures.
Once reason could be failure to successfully invoke expand.exe to
extract setup.exe.
Hopefully this should make this step more reliable.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6250175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After installing chrome with multi-install, you can run setup from the Installer folder with --quick-enable-cf to install Chrome Frame from the same location (using the same binaries). The operation is quick since all the shared binaries are already there and only need to be registered.
NOTE: The switch needs to be coupled with --system-level for system installs and always requires --multi-install.
TEST=After installing Chrome with --multi-install, run setup from the Installer folder with --quick-enable-cf --multi-install. For system installations also remember to include --system-level. Chrome Frame should then be installed as well from the same folder in multi mode.
BUG=none
Review URL: http://codereview.chromium.org/6349098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/6286105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
version folder from the file system against which to apply diff updates. Change that to pick the most recent one instead.
BUG=69165
TEST=Apply a diff update from version x.x.x.x to version y.y.y.y when there are at least two version folders already present in the install directory on the file system (i.e. x.x.x.x and other versions lower than x.x.x.x). Observe that the diff update succeeds by picking the correct version folder.
Review URL: http://codereview.chromium.org/6334100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"-multifail" was added if a --multi-install run failed for any reason. Now, setup.exe always removes it. As a result, it is only left behind when setup.exe crashes (it is added by mini_installer.exe).
BUG=70878
TEST=run a mini_installer.exe with --multi-install (e.g., --multi-install --system-level --chrome --verbose-logging) and try two things: 1) kill setup.exe and make sure that -multifail is left in an "ap" value; 2) cause setup.exe to fail in a non-crash way (e.g., bump up "pv" in Chrome's Clients key so that setup.exe exits with HIGHER_VERSION_EXISTS) then make sure that -multifail is not left in any "ap" value.
Review URL: http://codereview.chromium.org/6286044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=Run unit test. Verify that there's an elevation policy registered after install and that it gets properly removed on uninstall (ping me for more details).
BUG=none
Review URL: http://codereview.chromium.org/6368043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=69467
Review URL: http://codereview.chromium.org/6334030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bump up or down
- upgrade_test::GenerateAlternateVersion returns the old and new versions
- added alternate_version_generator.exe command-line tool.
BUG=none
TEST=run alternate_version_generator.exe --help and explore it
Review URL: http://codereview.chromium.org/6338020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=70936
TEST=All unit tests should pass.
Review URL: http://codereview.chromium.org/6317016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=69467
Review URL: http://codereview.chromium.org/6332018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=69467
Review URL: http://codereview.chromium.org/6377011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
things up:
- Introduced ProductOperations: an interface implemented for each product that takes care of product-specific functions. Each Product owns an instance and delegates certain operations to it.
- Removed the use of MasterPreferences by BrowserDistribution so that the former isn't needed outside of the installer.
- Replaced PackageProperties with a new BrowserDistribution type (CHROME_BINARIES)
- Plumbed the concept of InstallerState more thoroughly through installer
- Removed ProductPackageMapping and Package
- Moved more registry read ops into ProductState
- Validation of products to be installed is now done in CheckPreInstallConditions
- Ignore --chrome-frame --ready-mode if chrome is also being installed/updated and a SxS GCF is found (chrome is updated).
- Migrates existing single-install Chrome to multi-install where appropriate.
- Fixes update to Chrome's uninstallation arguments when Chrome Frame is uninstalled.
- Removed dead code from install.cc.
- Added code to update products' "ap" values when ready-mode is accepted.
- Skip post-install things such as launching the browser when Chrome was implicitly added to the install/upgrade process by virtue of being part of a multi-install.
BUG=61609
TEST=run the installer, see it work. existing tests in installer_util_unittests have been updated; new tests are included for ProductState, ChannelInfo, etc.
Review URL: http://codereview.chromium.org/6288009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=61609
TEST=none
Review URL: http://codereview.chromium.org/6260017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the base namespace. Fix several files including lock.h unnecessarily.
BUG=none
TEST=none
Original review=http://codereview.chromium.org/6142009/
Patch by leviw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=70092
TEST=GoogleUpdateTest.StatsConsent
Review URL: http://codereview.chromium.org/6339005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the Regkey helper to consistently use and return LONG
instead of bool. Fix RegKey usage all over the code base and
get rid of workarounds due to lack of return value.
Reviewers:
brettw: everything (skip parts for other reviewers if you wish)
robertshield,grt: chrome_frame, installer
siggi: ceee
BUG=none
TEST=covered by existing tests
Review URL: http://codereview.chromium.org/6090006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=61609
TEST=none
Review URL: http://codereview.chromium.org/6310011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
list for better testability.
Write preliminary test framework for testing these functions.
BUG=61609
TEST=setup_unittests.exe
Review URL: http://codereview.chromium.org/6153003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
prompts are displayed when the user browses to GCF-enabled sites, allowing the user to permanently activate, permanently decline, or temporarily decline Chrome Frame.
BUG=None
TEST=chrome_frame_unittests --gtest_filter=Ready* && chrome_frame_unittests --gtest_filter=Infobar* && setup.exe --chrome-frame --ready-mode --multi-install --system--level --chrome
Review URL: http://codereview.chromium.org/6040003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=trybots
Review URL: http://codereview.chromium.org/6152003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix problem with uninstallation of multi-install products.
We would incorrectly uninstall both installed products when we should only uninstall one.
BUG=68876
TEST=See bug description.
Review URL: http://codereview.chromium.org/6186006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=68877
TEST=Installing Chrome with --multi and then Chrome Frame with --multi works.
Review URL: http://codereview.chromium.org/6109006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6086003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made --enable-dcheck a parameter to InitLogging() and fixed up all
callsites.
BUG=62736
TEST=Manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70920
Review URL: http://codereview.chromium.org/6070006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made --enable-dcheck a parameter to InitLogging() and fixed up all
callsites.
BUG=62736
TEST=Manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782
Review URL: http://codereview.chromium.org/6070006
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/6099012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made --enable-dcheck a parameter to InitLogging() and fixed up all
callsites.
BUG=62736
TEST=Manual
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70782
Review URL: http://codereview.chromium.org/6070006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed the problem with rlz library. Now should be fine to land this again.
This reverts commit 3620d9501af7bff688862c54fdd60f7eb41797f3.
Original Review URL: http://codereview.chromium.org/6126002/
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6110005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the new location and namespace."
This reverts r 70795, it broke the build.
TBR=vandebo
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
location and namespace.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6126002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made --enable-dcheck a parameter to InitLogging() and fixed up all
callsites.
BUG=62736
TEST=Manual
Review URL: http://codereview.chromium.org/6070006
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/6100007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70783 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made --enable-dcheck a parameter to InitLogging() and fixed up all
callsites.
BUG=62736
TEST=Manual
Review URL: http://codereview.chromium.org/6070006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the callers and remove the deprecated function.
BUG=24672
TEST=trybots
Review URL: http://codereview.chromium.org/6111003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on the command line.
BUG=61609
TEST=Run mini_installer.exe and notice that -multifail is added to the "ap" value in the ClientState key when --multi-install is on the command-line. The value is removed by setup.exe at the end of a successful install.
Review URL: http://codereview.chromium.org/6005016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61609
TEST=install Chrome with --multi-install, monitor GoogleUpdate's log (e.g., via Sawbuck), and confirm that an update check uses the multi-installer package's app guid.
Review URL: http://codereview.chromium.org/6100003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61609
TEST=none
Review URL: http://codereview.chromium.org/6058009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61609
TEST=none
Review URL: http://codereview.chromium.org/5984009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70507 0039d316-1c4b-4281-b951-d872f2087c98
|