| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Support for multiple languages has been added to chromium_strings.grd. This change updates language_selector to make these languages available. As a side effect the debug version of the chromium setup.exe works again.
BUG=120351
TEST=Added unit test
Review URL: http://codereview.chromium.org/9965007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID=103697
TBR= tommi@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/9956044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The function CreateOrUpdateChromeShortcuts will now keep trying
to create shortcuts even if there is an unexpected failure.
BUG=120097
TEST=Test shortcut creation continues if |ret| forced to false after the first shortcut is created.
Review URL: http://codereview.chromium.org/9858004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=cpu
Review URL: https://chromiumcodereview.appspot.com/9969005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
revisions noted
in the bug. Revert was done manually due to refactoring, etc.
BUG=85988
Review URL: https://chromiumcodereview.appspot.com/9802030
TBR=cevans@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
in the bug. Revert was done manually due to refactoring, etc.
BUG=85988
Review URL: https://chromiumcodereview.appspot.com/9802030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/9866051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
These files don't use any localized strings.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/9861022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add in a fake version of that destructor to keep master_preferences_dummy.cc linking on 64-bit windows builds.
[This is just like http://codereview.chromium.org/9104001].
BUG=114484
TEST=none this roll; without it, valgrind blows up when the larger GURL change goes in.
Review URL: http://codereview.chromium.org/9866001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
reactivation functions.
gcapi.cc: CanOfferReactivation returns TRUE whenever it's invoked from an elevated shell
gcapi.h: modify LaunchGoogleChrome function pointer to work with GetProcAddress when using run-time dynamic linking
gcapi_reactivation.cc: don't reactivate Chrome if it's already been reactivated, regardless of what the reactivation brandcode was
TEST=Invoke CanOfferReactivation from an elevated shell. Try reactivating Chrome with a different brandcode. Call LaunchGoogleChrome with GetProcAddress.
Review URL: http://codereview.chromium.org/9704022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=115346
TES=right-click menu on flash -> global settings works. You see the native control
panel instead of an error dialog.
NOTRY=true
Review URL: http://codereview.chromium.org/9810031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=110794
TEST=Built official Chrome and let it run
Review URL: http://codereview.chromium.org/9782002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
canary users.
BUG=110794
TEST=Built official Chrome and let it run
Review URL: http://codereview.chromium.org/9722019
TBR=simonjam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9727013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=110794
TEST=Built official Chrome and let it run
Review URL: http://codereview.chromium.org/9722019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127579 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix a few minor issues that the compiler complains about on mac, mostly
wstring/string16 confusion. All these changes are no-ops on windows.
95: Move SupplementaryBranding from win/lib/rlz_lib.h to lib/rlz_lib.h
96: Move ClearAllProductEvents() to use RlzValueStore.
97: Move ClearAllProductEvents() to shared code. Pure code move.
98: Move ClearProductState() to RlzValueStore.
99: Move ClearProductState() to common code.
BUG=46579
TEST=none
TBR=rogerta
Review URL: http://codereview.chromium.org/9717012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
88: Add a ReadProductEvents() method to RlzValueStore.
89: Change return type of GetProductEventsAsCgiHelper() from DWORD to bool.
90-94: Change SupplementalBranding from wchar_t to char.
BUG=46579
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9704089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
So it can self-destruct if Chrome (or Chrome Frame) was the last Omaha-managed product on the system.
BUG=114786
TEST=Install Google Update 1.3.21.105 or later and Chrome w/ --verbose-logging. Uninstall Chrome and see that Google Update vanishes immediately. Take a look at chrome_installer.log and look for messages related to Launching Google Update's uninstaller.
Review URL: http://codereview.chromium.org/9693055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
CID_COUNT=2
CID=103425,103426
BUG=none
TEST=none
R=groby
Review URL: https://chromiumcodereview.appspot.com/9547014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=110794
TEST=Ran modified build with this enabled.
Review URL: http://codereview.chromium.org/9636001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/installer.
BUG=24672
TEST=install Chrome and make it the default browser. verify that filetype (double-click an .html file) and protocol registrations (enter http://www.google.com/ in the Run... dialog) still work.
Review URL: http://codereview.chromium.org/9616046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=115784
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9513006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=114101
TEST=none
Review URL: http://codereview.chromium.org/9565025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pin chrome to the taskbar on Windows 7 and higher when performing a new install.
Also unpin from the taskbar when uninstalling.
Landing for benwells@chromium.org; originally reviewed at http://codereview.chromium.org/9406008/
BUG=103977
TEST=Manually tested on Windows 7
TBR=benwells@chromium.org,robertshield@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9477025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
registered.
BUG=114377
TEST=NONE
Review URL: http://codereview.chromium.org/9474039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I believe this regressed in Chrome 9 (http://crrev.com/67818). $5 to whomever writes a test for this so it doesn't regress again.
Highlights:
* Don't DCHECK in setup_main when handling --system-level-toast
* Rename AppendUninstallFlags to AppendProductFlags
* Pass the product-specific flags to child invocations of setup.exe
* Propagage --verbose-logging to child invocations of setup.exe
BUG=114101
TEST=install system-level chrome (at HH:MM C:\some\path\mini_installer.exe --system-level --verbose-logging --multi-install --chrome), set brand="CHXX" in HKLM\SOFTWARE\Google\Update\ClientState\{8A69D345-D564-463c-AFF1-A69D9E530F96}, then update chrome (at HH:MM C:\some\newer\mini_installer.exe --system-level --verbose-logging --multi-install --chrome) and see that the toast appears. Also make sure it still works for user-level installs.
Review URL: https://chromiumcodereview.appspot.com/9465039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
current elevation level.
I added some minor style changes and fixed up the tests.
BUG=NONE
TEST=gcapi_test
Review URL: https://chromiumcodereview.appspot.com/9465013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This will allow the use of JSONStringValueSerializer in the NaCl sandbox.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9465030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(Visual Studio 2010 Express).
Review URL: http://codereview.chromium.org/9466017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=none
Review URL: http://codereview.chromium.org/9442038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is valid code:
void f(int i) {
const int kI = i;
}
This file declared an array of structs containing VLAs. That's
nonstandard (and clang doesn't like it).
BUG=82385
TEST=none
Review URL: http://codereview.chromium.org/9447001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
logo certification.
BUG=103305
TEST=none
Review URL: http://codereview.chromium.org/9389015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=84299,99469,90557,109292,38497,45243,84854,59785,59783,59784,100567,62777,60426
TBR=thakis
Review URL: https://chromiumcodereview.appspot.com/9406017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
When writing to the registry key, append a hash of the profile directory path, so as to not clobber settings between profiles and add the --profile-directory=foo component to the directory as well.
BUG=112118
TEST=Test this as you would test the autolaunch experiment normally (see original autolaunch bug), but make sure to test it with multiple profiles and side-by-side installations. Note: Only the Default profile gets to set this value at present time.
Review URL: https://chromiumcodereview.appspot.com/9358052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When writing to the registry key, append a hash of the profile directory path, so as to not clobber settings between profiles and add the --profile-directory=foo component to the directory as well.
BUG=112118
TEST=Test this as you would test the autolaunch experiment normally (see original autolaunch bug), but make sure to test it with multiple profiles and side-by-side installations. Note: Only the Default profile gets to set this value at present time.
Review URL: https://chromiumcodereview.appspot.com/9317002
TBR=finnur@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9361057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
When writing to the registry key, append a hash of the profile directory path, so as to not clobber settings between profiles and add the --profile-directory=foo component to the directory as well.
BUG=112118
TEST=Test this as you would test the autolaunch experiment normally (see original autolaunch bug), but make sure to test it with multiple profiles and side-by-side installations. Note: Only the Default profile gets to set this value at present time.
Review URL: https://chromiumcodereview.appspot.com/9317002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=97186
Review URL: http://codereview.chromium.org/9371010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
set the default browser
This is for windows 8.
BUG=113326
TEST=see bug
Review URL: https://chromiumcodereview.appspot.com/9370008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=111453
TEST=gcapi_test.exe
Review URL: https://chromiumcodereview.appspot.com/9323068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=104418
TEST=none
Review URL: http://codereview.chromium.org/9316007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dependencies.
During gclient runhooks, update LASTCHANGE so that it will be updated at least as often as runhooks is run (i.e. for every sync).
LASTCHANGE moved to build/util rather than SHARED_INTERMEDIATE_DIR because that directory isn't known to runhooks.
BUG=111731
Review URL: https://chromiumcodereview.appspot.com/9169105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
VS2005 unhappy.
Revert "Revert 119841 - Implementation of GCAPI reactivation."
This reverts commit b0eebb403ad069142ec43e566134f4000f0f0f19.
BUG=NONE
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/9302035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, some cleanup in gcapi_tests such that it now only runs gtest tests by default.
BUG=111453
TEST=gcapi_tests.exe
Review URL: https://chromiumcodereview.appspot.com/9288056
TBR=robertshield@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9302029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, some cleanup in gcapi_tests such that it now only runs gtest tests by default.
BUG=111453
TEST=gcapi_tests.exe
Review URL: https://chromiumcodereview.appspot.com/9288056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Old bubble:
---------------------------------------------
There's a new safer version of Google Chrome
[x] Try it out
[ ] Uninstall
[OK] [Don't Bug Me]
{Why am I seeing this?}
---------------------------------------------
Newer, more compact bubble:
---------------------------------------------
There's a new safer version of Google Chrome
[x] Try it out
[ ] Don't Bug Me
[OK]
---------------------------------------------
BUG=None
TEST=This should be tested like any other attrition toast experiment, but needs a special branded build.
Review URL: https://chromiumcodereview.appspot.com/9129021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
installs. Turns out they are always unconditionally written to HKCU for each user.
Update gcapi test to account for lastrun only being written to HKCU.
Fix bug that leaves a bogus registry value behind when calling VerifyHKLMAccess().
BUG=NONE
TEST=gcapi_tests.exe
Review URL: https://chromiumcodereview.appspot.com/9113084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No changes to the Gtk and Mac first-run (reporting & default browser) dialog.
Tested optionally with GYP_DEFINES="branding=Chrome" and "--first-run --organic".
Chromium (all platforms): Shows the browser window directly (no dialog).
Chrome (Windows): Shows the browser window directly (no dialog).
Chrome (Linux and Mac): Shows the first-run (reporting & default browser) dialog before the browser window.
TODO(msw): Close crbug.com/111062 for removed test.
TODO(msw): Remove search engine icon/image resources (TemplateURL::logo_id_).
BUG=107005
TEST=No more standalone search engine selection dialog/ballot, Gtk and Mac first-run dialog works as before.
Review URL: http://codereview.chromium.org/9285002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
No functionality change.
BUG=82385
TEST=none
Review URL: http://codereview.chromium.org/9200009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The locale comparison was being done on pointers as opposed to the strings being pointed at.
Also sync up with changes made on 912 branch (enterprise brands should not be used for toasting).
BUG=107770
TEST=The locale change can only be tested by making a code change to show the toast for all locales, or on the 912 branch with Mark's changes. Basically, use chrome.exe --try-chrome-again=0 on the branch and the toast should show up. The enterprise brand code can be tested by setting your brand to GGRV and no toast should appear when you launch chrome.exe with --try-chrome-again=0.
Review URL: https://chromiumcodereview.appspot.com/9178010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=existing googleurl unit tests continue to pass
Review URL: https://chromiumcodereview.appspot.com/9104001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
create desktop shortcuts, rather than the no-first-run flag.
BUG=108362
TEST=Ensure that installing Chrome Frame and visiting a Chrome Frame enabled page does not create any desktop shortcuts in Windows. Ensure that running a pyauto test that runs the OpenNewBrowserWindowWithNewProfile hook also creates desktop shortcuts.
Review URL: http://codereview.chromium.org/9227010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117910 0039d316-1c4b-4281-b951-d872f2087c98
|