summaryrefslogtreecommitdiffstats
path: root/chrome/installer
Commit message (Collapse)AuthorAgeFilesLines
...
* Making AddVersionKeyWorkItems() take version_key and product_name instead of ↵huangs@chromium.org2014-07-302-11/+19
| | | | | | | | | | | | | | a BrowserDistribution This change allows us to call AddVersionKeyWorkItems() when we don't have a BrowserDistribution. This allows us to use it to remove the "shadow" registry key for App Launcher during Chrome uninstall. BUG=297647 Review URL: https://codereview.chromium.org/427963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286545 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Remove some dead app host code.grt@chromium.org2014-07-2513-358/+30
| | | | | | | | | | | | | | | | | | | | | | app_host.exe was removed in r220555. This change removes some dead code that was left behind. Specifically: - chrome_launcher_support no longer exposes any methods related to the AppHost. - Chrome's uninstall prompt no longer has a special case to handle suppressing the "delete your profile" checkbox. - Chrome and its installer no longer have a dependency on launcher_support. - The installer no longer supports installing items from the webstore. - GetUntrustedDataValue no longer has consumers and is gone. BUG=297647 R=benwells@chromium.org,huangs@chromium.org,gab@chromium.org TBR=grt@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/419913005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285715 0039d316-1c4b-4281-b951-d872f2087c98
* Fix google chrome build break from r285661.grt@chromium.org2014-07-251-3/+5
| | | | | | | | | | BUG=397693 TBR=gab@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/422433004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285710 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 285661 "Remove some dead app host code."mpearson@chromium.org2014-07-2513-30/+358
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Causes compile failures on official builders: e.g., http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/ FAILED: ninja -t msvc -e environment.x64 -- c:\b\build\goma/gomacc "c:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\chrome\installer\util\installer_util_nacl_win64.chrome_app_host_distribution.obj.rsp /c ..\..\chrome\installer\util\chrome_app_host_distribution.cc /Foobj\chrome\installer\util\installer_util_nacl_win64.chrome_app_host_distribution.obj /Fdobj\chrome\installer_util_nacl_win64.cc.pdb c:\b\build\slave\google-chrome-rel-win\build\src\chrome\installer\util\chrome_app_host_distribution.cc(126) :error C2065: 'kChromeAppHostGuid' : undeclared identifier ninja: build stopped: subcommand failed. > Remove some dead app host code. > > app_host.exe was removed in r220555. This change removes some dead code > that was left behind. Specifically: > - chrome_launcher_support no longer exposes any methods related to the > AppHost. > - Chrome's uninstall prompt no longer has a special case to handle > suppressing the "delete your profile" checkbox. > - Chrome and its installer no longer have a dependency on > launcher_support. > - The installer no longer supports installing items from the webstore. > - GetUntrustedDataValue no longer has consumers and is gone. > > BUG=297647 > R=benwells@chromium.org,huangs@chromium.org,gab@chromium.org > > Review URL: https://codereview.chromium.org/422453004 TBR=grt@chromium.org Review URL: https://codereview.chromium.org/422593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285706 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some dead app host code.grt@chromium.org2014-07-2513-358/+30
| | | | | | | | | | | | | | | | | | | | app_host.exe was removed in r220555. This change removes some dead code that was left behind. Specifically: - chrome_launcher_support no longer exposes any methods related to the AppHost. - Chrome's uninstall prompt no longer has a special case to handle suppressing the "delete your profile" checkbox. - Chrome and its installer no longer have a dependency on launcher_support. - The installer no longer supports installing items from the webstore. - GetUntrustedDataValue no longer has consumers and is gone. BUG=297647 R=benwells@chromium.org,huangs@chromium.org,gab@chromium.org Review URL: https://codereview.chromium.org/422453004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285661 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate WorkItemListTest to use RegistryOverrideManager instead of rolling ↵robertshield@chromium.org2014-07-241-15/+5
| | | | | | | | | | | its own attempt at temp registry keys. BUG=396405 TEST=installer_util_unittest.exe Review URL: https://codereview.chromium.org/412983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285310 0039d316-1c4b-4281-b951-d872f2087c98
* Fix installer variable name bugaboo.grt@chromium.org2014-07-231-6/+6
| | | | | | | | | | | | | This is a rare codepath used only by Chrome Frame uninstalls. It's rare that it will be hit now, but leave correct code in place until the great installer GCF cleanup rather than remove this one small piece now. BUG=NONE R=gab@chromium.org Review URL: https://codereview.chromium.org/410923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285017 0039d316-1c4b-4281-b951-d872f2087c98
* Disable all the tests that are flaking more than 5% on Windows builders.jam@chromium.org2014-07-231-2/+4
| | | | | | | | | | | | Data from http://chromium-build-logs.appspot.com/flakiness_dashboard?master=chromium.win. BUG=386891,387124,396373,396384,396386,396387,396388,396390,396392,387124,396393,396395,396399,396402,396403,396404,396405,393149,396409,95557,396413,396414,375894 R=viettrungluu@chromium.org TBR=brettw, rvargas, sky Review URL: https://codereview.chromium.org/410843003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284977 0039d316-1c4b-4281-b951-d872f2087c98
* Retrieve client_id from GoogleUpdateSettings when its missing from Local State.gab@chromium.org2014-07-225-13/+52
| | | | | | | | | | | | | | Precursor refactoring CL @ https://codereview.chromium.org/365133005/ Precursor kInstallDate move to metrics_pref_names @ https://codereview.chromium.org/370813003/ This is the Windows implementation, POSIX implementation to follow in https://codereview.chromium.org/377713002/ (easier to develop and test on Linux in a follow-up CL) BUG=391338 Review URL: https://codereview.chromium.org/372473004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284805 0039d316-1c4b-4281-b951-d872f2087c98
* Update ARM sysroot package.sbc@chromium.org2014-07-221-14/+14
| | | | | | | | | | | This change is the result of running: ./sysroot-creator-wheezy.sh UpdatePackageListsARM R=thestig@chromium.org Review URL: https://codereview.chromium.org/406353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284787 0039d316-1c4b-4281-b951-d872f2087c98
* App Launcher dr=1: limit to Chrome, and stop using ChromeAppHostDistribution ↵huangs@chromium.org2014-07-222-7/+9
| | | | | | | | | | | | | | | | | | | | | | to set it. This CL does 2 things: 1. The setting of App Launcher dr=1 is now only used for GOOGLE_CHROME_BUILD. 2. Refactoring: In r273321, we extracted AppRegistrationData from BrowserDistribution, and make it part of BrowserDistribution by composition. In this CL, we use this new flexibility, and cut the dependence of app_list_service_win.cc on ChromeAppHostDistribution by just giving it the AppRegistrationData part it needs. The required const kAppLauncherGuid now lives in chrome_launcher_support. BUG=297647 Review URL: https://codereview.chromium.org/374413004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284605 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for re-enabling more MSVC level 4 warnings: chrome/ editionpkasting@chromium.org2014-07-163-13/+15
| | | | | | | | | | | | | | | This contains fixes for the following sorts of issues: * Signedness mismatch * Assignment inside conditional * Constant value was truncated * Possibly-uninitialized local variable BUG=81439 TEST=none Review URL: https://codereview.chromium.org/377683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283305 0039d316-1c4b-4281-b951-d872f2087c98
* Split linux library expectations for debian into 32 and 64 bit, remove ↵thakis@chromium.org2014-07-103-2/+33
| | | | | | | | | | | libgcc1 from 64 after clang switch BUG=360311 NOTRY=true Review URL: https://codereview.chromium.org/385693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282379 0039d316-1c4b-4281-b951-d872f2087c98
* More flailing around for official library deps.thakis@chromium.org2014-07-103-6/+1
| | | | | | | | | | | | | This reverts https://codereview.chromium.org/387513002/ which was wrong, and applies something like https://codereview.chromium.org/376403002/ to the 64bit rpm expectations. BUG=360311 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/382773005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282338 0039d316-1c4b-4281-b951-d872f2087c98
* Update x64 library deps after clang switchthakis@chromium.org2014-07-102-1/+1
| | | | | | | | | | | | Follow-up to https://codereview.chromium.org/376403002/ , looks like the 64bit bot just hadn't cycled yet. BUG=360311 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/387513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282324 0039d316-1c4b-4281-b951-d872f2087c98
* Update size expectations and shared lib expectations after clang switchthakis@chromium.org2014-07-101-4/+1
| | | | | | | | | BUG=360311 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/376403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282261 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor SetClientID such that metrics rather than crash backs up the client idgab@chromium.org2014-07-092-7/+7
| | | | | | | | | | | | | | | | | | | in Google Update settings. Consequentially, the backed up client_id now keeps its dashes and crash_keys strips them at runtime rather than when backing it up (https://codereview.chromium.org/372473004/ will add support for stripped client_id backups for some time). Also rename a lot of methods involved in setting the client id; having all of them named "SetClientID" makes this series of calls very hard to follow! BUG=391338 TBR=thestig Review URL: https://codereview.chromium.org/365133005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282093 0039d316-1c4b-4281-b951-d872f2087c98
* mini_installer code cleanups (no functional changes).grt@chromium.org2014-07-097-103/+177
| | | | | | | | | | | | - Move constants into *_constants.{cc,h}. - Remove unused constants. - Lay foundation for detailed process exit codes. BUG=385419 Review URL: https://codereview.chromium.org/365143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282032 0039d316-1c4b-4281-b951-d872f2087c98
* Installer refactoring: using string16 instead of wstring for ↵huangs@chromium.org2014-07-085-80/+81
| | | | | | | | | | GoogleUpdateSettings. BUG=297647 Review URL: https://codereview.chromium.org/371753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281740 0039d316-1c4b-4281-b951-d872f2087c98
* reinterpret_cast is not allowed to cast away const.thakis@chromium.org2014-07-071-12/+15
| | | | | | | | | | | | Rather than add a const_cast, tweak things so that const doesn't have to be casted away. BUG=82385 R=grt@chromium.org Review URL: https://codereview.chromium.org/372703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281543 0039d316-1c4b-4281-b951-d872f2087c98
* clang wants an initializer for a static const struct. Humor it.thakis@chromium.org2014-07-051-2/+2
| | | | | | | | | | | | (Filed http://llvm.org/PR20208 to discuss if this is required, and that the diagnostic for this is not very good at the moment.) BUG=82385 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/365333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281452 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing Pass() calls for passing scoped_ptrs on Windows.thakis@chromium.org2014-07-047-16/+19
| | | | | | | | | | | BUG=82385 TBR=awong@chromium.org R=joaodasilva@chromium.org,sergeyu@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/367403002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281366 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed i#389250: Uninit error at RegistryEntry::StatusInRegistryUnderRootzhaoqin@google.com2014-06-271-4/+7
| | | | | | | | | | | - only read read_value and set correct_value if found is true R=gab@chromium.org BUG=389250 Review URL: https://codereview.chromium.org/358843003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280263 0039d316-1c4b-4281-b951-d872f2087c98
* Remove per-user browser blacklist state from the registry on uninstall.krstnmnlsn@chromium.org2014-06-262-0/+18
| | | | | | | | In particular, the set up beacons and any names in the finch blacklist. Review URL: https://codereview.chromium.org/346293003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280086 0039d316-1c4b-4281-b951-d872f2087c98
* Don't bind a temporary to a reference.thakis@chromium.org2014-06-261-6/+7
| | | | | | | | | | | | | | THe style guide doesn't allow non-const references either, so also convert the reference to a pointer while here. No intended behavior change. BUG=82385 NOTRY=true Review URL: https://codereview.chromium.org/352893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279926 0039d316-1c4b-4281-b951-d872f2087c98
* Split UNPACKING_FAILED exit code out from UNCOMPRESSION_FAILED.grt@chromium.org2014-06-172-3/+5
| | | | | | | | | | | To ease failure diagnosis. BUG=385421 R=gab@chromium.org Review URL: https://codereview.chromium.org/338273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277780 0039d316-1c4b-4281-b951-d872f2087c98
* Support side-by-side install in RPM packagesphajdan.jr@chromium.org2014-06-171-13/+10
| | | | | | | | | BUG=38598 R=thestig@chromium.org Review URL: https://codereview.chromium.org/333023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277601 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Change expected glib dependency version from 2.26 to 2.28.thestig@chromium.org2014-06-141-1/+1
| | | | | | | | | | | | This is an ok change since all supported Linux distros have 2.32 or higher. It is not exactly obvious what CL caused this. The code review will be updated with more info afterwards. NOTRY=true Review URL: https://codereview.chromium.org/333073003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277139 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Revert of Convert installer_util_unittests, ↵alph@chromium.org2014-06-091-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sbox_integration_tests, sbox_validation_tests, sbox_unittests to … (https://codereview.chromium.org/314173005/) Reason for revert: Looks like it was a flake. Original issue's description: > Revert of Convert installer_util_unittests, sbox_integration_tests, sbox_validation_tests, sbox_unittests to … (https://codereview.chromium.org/315403006/) > > Reason for revert: > Broke a bunch of unit tests on Win. > http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/19568 > > Original issue's description: > > Convert installer_util_unittests, sbox_integration_tests, sbox_validation_tests, sbox_unittests to new test launcher > > > > Also add them to the Windows trybots > > > > BUG=381071 > > R=grt@chromium.org, rvargas@chromium.org > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275801 > > TBR=gab@chromium.org,rvargas@chromium.org,grt@chromium.org,phajdan.jr@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=381071 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275805 TBR=gab@chromium.org,rvargas@chromium.org,grt@chromium.org,phajdan.jr@chromium.org NOTREECHECKS=true NOTRY=true BUG=381071 Review URL: https://codereview.chromium.org/327543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275806 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Convert installer_util_unittests, sbox_integration_tests, ↵alph@chromium.org2014-06-091-8/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | sbox_validation_tests, sbox_unittests to … (https://codereview.chromium.org/315403006/) Reason for revert: Broke a bunch of unit tests on Win. http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/19568 Original issue's description: > Convert installer_util_unittests, sbox_integration_tests, sbox_validation_tests, sbox_unittests to new test launcher > > Also add them to the Windows trybots > > BUG=381071 > R=grt@chromium.org, rvargas@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275801 TBR=gab@chromium.org,rvargas@chromium.org,grt@chromium.org,phajdan.jr@chromium.org NOTREECHECKS=true NOTRY=true BUG=381071 Review URL: https://codereview.chromium.org/314173005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275805 0039d316-1c4b-4281-b951-d872f2087c98
* Convert installer_util_unittests, sbox_integration_tests, ↵phajdan.jr@chromium.org2014-06-091-1/+8
| | | | | | | | | | | | | sbox_validation_tests, sbox_unittests to new test launcher Also add them to the Windows trybots BUG=381071 R=grt@chromium.org, rvargas@chromium.org Review URL: https://codereview.chromium.org/315403006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275801 0039d316-1c4b-4281-b951-d872f2087c98
* Sanitize standard file descriptors in launcher scriptmdempsky@chromium.org2014-06-061-0/+6
| | | | | | | | BUG=376567 Review URL: https://codereview.chromium.org/314133003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275522 0039d316-1c4b-4281-b951-d872f2087c98
* Move branding information out of google_utilblundell@chromium.org2014-06-061-2/+2
| | | | | | | | | | | | | google_util is intended for componentization, whereas the information of what the current brand is and whether a given brand is organic is inherently embedder-specific. This functionality is moved to a new google_brand namespace. BUG=373224 TBR=jochen Review URL: https://codereview.chromium.org/316963002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275413 0039d316-1c4b-4281-b951-d872f2087c98
* Remove stale references to PlatformFile flags, errors or functions.rvargas@chromium.org2014-06-051-1/+1
| | | | | | | | BUG=322664 Review URL: https://codereview.chromium.org/318753007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275258 0039d316-1c4b-4281-b951-d872f2087c98
* Read multi-install chrome's channel from the binaries.grt@chromium.org2014-06-042-14/+80
| | | | | | | | | BUG=380828 R=robertshield@chromium.org Review URL: https://codereview.chromium.org/316103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274909 0039d316-1c4b-4281-b951-d872f2087c98
* Always read and write Google Update registry values from the 32-bit hive, ↵wfh@chromium.org2014-06-041-9/+12
| | | | | | | | | | even on 64-bit systems. BUG=380371 Review URL: https://codereview.chromium.org/316753003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274907 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed mistake in logical check for rollback.vitalybuka@chromium.org2014-05-301-1/+1
| | | | | | | | BUG=379002 Review URL: https://codereview.chromium.org/307943008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273771 0039d316-1c4b-4281-b951-d872f2087c98
* Make various string_util functions take StringPieces instead of char[].pkasting@chromium.org2014-05-302-41/+42
| | | | | | | | | | | | | | | This allows most callers to pass string literals or results of ASCIIToUTF16(), rather than construct error-prone character arrays that must be manually nul-terminated. Also cleans up various bits of the callers. BUG=104260 TEST=none Review URL: https://codereview.chromium.org/296593003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273765 0039d316-1c4b-4281-b951-d872f2087c98
* Cause mini_installer tests to noop on component builds.robertshield@chromium.org2014-05-293-6/+28
| | | | | | | | | BUG=377839, 264859 TEST=/src/chrome/test/mini_installer/test_installer.py Review URL: https://codereview.chromium.org/304673004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273429 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor: Extracting base interface from BrowserDistribution to simplify ↵huangs@chromium.org2014-05-2821-265/+290
| | | | | | | | | | | | | | | | | | | | | | | | | | | Google Update registry writes. The following member functions of BrowserDistribution: - GetAppGuid(), - GetStateKey(), - GetStateMediumKey(), - GetVersionKey(), are extracted to a new interface AppRegistrationData, which is then made a member of BrowserDistribution. To prevent massive changes existing code, the extracted routines are kept in BrowserDistribution as adaptors to the AppRegistrationData within. Next, calls related to setting the "did-run" flags are refactored to take AppRegistrationData instead of BrowserDistribution. This is to help us remove ChromeAppHostDistribution, since now we just have to implement AppRegistrationData. Also, changes in google_update_settings: - UpdateDidRunStateForDistribution() => UpdateDidRunStateForApp(). - Added UpdateDidRunStateForBinaries(). - Logic changes regarding multi_install, affecting App Launcher caller. BUG=297647 Review URL: https://codereview.chromium.org/252893005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273321 0039d316-1c4b-4281-b951-d872f2087c98
* linux_aura: Update Debian packaging to Depend: on libappindicator1.erg@chromium.org2014-05-281-2/+2
| | | | | | | | BUG=374686 Review URL: https://codereview.chromium.org/300063014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273158 0039d316-1c4b-4281-b951-d872f2087c98
* Omaha configuration parameters now use Wow6432Node (32-bit registry) on ↵wfh@chromium.org2014-05-2818-148/+197
| | | | | | | | | | | | | | | 64-bit installs. GCAPI configuration parameters also use these same accesses since they read/write the same data. Also, force installation of Win64 into C:\Program Files (x86) until the code is added to support moving the files to the right place during upgrade and downgrade. Uninstall information will remain stored in the 32-bit registry (even on 64-bit) until the installation location is changed. This fixes system installs on Win64. BUG=338706 R=grt@chromium.org Review URL: https://codereview.chromium.org/300593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273108 0039d316-1c4b-4281-b951-d872f2087c98
* Remove HTTP pipelining support.mmenke@chromium.org2014-05-279-28/+0
| | | | | | | | | | | | | | | | It's been a couple years since anyone worked on it, and there are no plans to enable it by default. Cached pipelining-related server information will automatically be cleared when server information is next saved, so there are no issues on that front. BUG=364557 R=asvitkine@chromium.org, eroman@chromium.org, grt@chromium.org, sky@chromium.org, willchan@chromium.org, zea@chromium.org Review URL: https://codereview.chromium.org/275953002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272903 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup, mostly replacing uses of SplitStringUsingSubstr() with SplitString(),pkasting@chromium.org2014-05-234-32/+29
| | | | | | | | | | | also some other misc. changes to shorten code, remove a using directive, etc. BUG=none TEST=none Review URL: https://codereview.chromium.org/291653007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272624 0039d316-1c4b-4281-b951-d872f2087c98
* Add a flag to all of the registry related work items to specify whether to ↵wfh@chromium.org2014-05-2334-718/+769
| | | | | | | | | | | | | | | | | | | operate on the 64-bit or 32-bit hive on a WOW64 system. Make DeleteRegKeyWorkItem call down into RegKey so WOW64 support works for delete work items. All calls changed to use the Wow64_Default (0) parameter, so the behavior is identical. This is prep for adding 64-bit support to the installer. BUG=348626,338706 R=grt@chromium.org, grt TBR=sky TEST=installer_util_unittests Review URL: https://codereview.chromium.org/282363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272539 0039d316-1c4b-4281-b951-d872f2087c98
* Simpler memset, avoids ICE on VS2013 Update2scottmg@chromium.org2014-05-211-23/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous code is causing: FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\chrome\installer\mini_installer\mini_installer.mini_installer.obj.rsp /c ..\..\chrome\installer\mini_installer\mini_installer.cc /Foobj\chrome\installer\mini_installer\mini_installer.mini_installer.obj /Fdobj\chrome\installer\mini_installer.cc.pdb c:\b\build\slave\win-latest-rel\build\src\chrome\installer\mini_installer\mini_installer.cc(857) : fatalerror C1001: An internal error has occurred in the compiler. (compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 228) To work around this problem, try simplifying or changing the program near the locations listed above. Please choose the Technical Support command on the Visual C++ Help menu, or open the Technical Support help file for more information INTERNAL COMPILER ERROR in 'C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe' Please choose the Technical Support command on the Visual C++ Help menu, or open the Technical Support help file for more information after Update 2. The CRT's implementation looks like the simple char loop, so simplify here too. In practice, I think this will only rarely get used, as the compiler is allowed to "know" what memset does and replace it with an optimized version. There's an upstream bug filed here: https://connect.microsoft.com/VisualStudio/feedback/details/878340/ice-on-memset-implementation-at-o2 R=grt@chromium.org BUG=372451 Review URL: https://codereview.chromium.org/294943005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271919 0039d316-1c4b-4281-b951-d872f2087c98
* linux_aura: Compile ash into chrome.erg@chromium.org2014-05-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | [This is take three. I believe that I've now fixed all the static initializers (including both files named debug_utils.cc that were including <iostream>), the packaging failures, and the black border on the app list as pointed out by mgiuca@.] Running chrome with the "--open-ash" parameter will create an ash desktop window. Ash on Linux has some problems, but at least we're now compiling the code into the binary. TODO: The applist isn't positioned correctly, and some details of the system tray aren't correct. BUG=300084, 303862 TBR=sky@chromium.org First Review URL: https://codereview.chromium.org/25108005 Review URL: https://codereview.chromium.org/292443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271725 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup various Windows installer/breakpad bits.thestig@chromium.org2014-05-203-8/+5
| | | | | | Review URL: https://codereview.chromium.org/295893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271699 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Remove gcrypt initialization workaround.thestig@chromium.org2014-05-205-3/+2
| | | | | | | | | BUG=369973 TEST=ctrl + p does not crash. Review URL: https://codereview.chromium.org/270553003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271563 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add a check to the startup script to check for SSE2 support.thestig@chromium.org2014-05-201-0/+19
| | | | | | | | | BUG=348761 NOTRY=true Review URL: https://codereview.chromium.org/296663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271529 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-14 10:14:53 +0000