summaryrefslogtreecommitdiffstats
path: root/chrome/installer
Commit message (Collapse)AuthorAgeFilesLines
* Modify bsdiff 4.3 to create goobsdiff, which is appropriate for use as the Macmark@chromium.org2010-06-095-291/+574
| | | | | | | | | | binary differ/patcher. BUG=45017 TEST=none Review URL: http://codereview.chromium.org/2716005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49316 0039d316-1c4b-4281-b951-d872f2087c98
* Add unpatched bsdiff 4.3 to chrome/installer/mac/third_party/bsdiffmark@chromium.org2010-06-097-0/+782
| | | | | | | | | | | | | | | | I have non-algorithmic changes to bsdiff and bspatch, and they'll be easier to review and easier to identify in the future if an unpatched copy is checked in first. The bsdiff and bspatch that you'll find elsewhere in the repository are actually different forks of bsdiff, and aren't quite as appropriate for use in the Mac binary patcher. The other copies are Mozilla's variant of bsdiff. BUG=45017 TEST=none Review URL: http://codereview.chromium.org/2789003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49280 0039d316-1c4b-4281-b951-d872f2087c98
* Include plugin.vch in mini_installer.viettrungluu@chromium.org2010-06-082-0/+2
| | | | | | | | | BUG=none TEST=new-style Flash DRM plays on Windows Review URL: http://codereview.chromium.org/2752003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49186 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of issues with MSI support through upgrades:robertshield@chromium.org2010-06-074-40/+101
| | | | | | | | | | | | | | 1) When installing from an msi, remove any uninstall shortcuts currently present for that type (system/per-user) of install. 2) When uninstalling, proactively delete the MSI marker from the Omaha ClientState key to avoid an uninstall-reinstall scenario which can cause a reinstall of a non-msi build to be tagged as being msi-managed. BUG=45252,45273 TEST=Install non-MSI GCF, then install MSI GCF. Observe only a single ARP dialog entry. Then uninstall MSI GCF and quickly reinstall non-MSI GCF, again observe a single ARP dialog entry. Review URL: http://codereview.chromium.org/2459003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49069 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the old RLZ dll from the chrome code. There are no code dependenciesrogerta@google.com2010-06-072-2/+0
| | | | | | | | | | | | | | | on this project; its only purpose is to copy the rlz.dll file to the correct spot in the output directory. This is the first step in getting the new open source RLZ library into chromium. A following CL will add the calls to new implementation. BUG=none TEST=none Review URL: http://codereview.chromium.org/2640003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49059 0039d316-1c4b-4281-b951-d872f2087c98
* Use DISALLOW_COPY_AND_ASSIGN instead of DISALLOW_EVIL_CONSTRUCTORS in chrome ↵tfarina@chromium.org2010-06-061-2/+2
| | | | | | | | | | | directory. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2657003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49024 0039d316-1c4b-4281-b951-d872f2087c98
* Win SxS: Creating a new shortcut with enable-udd-profiles uses wrong icon.mattm@chromium.org2010-06-035-13/+9
| | | | | | | | | BUG=44847 TEST=see bug Review URL: http://codereview.chromium.org/2557001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48871 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/GTK: implement update notification.estade@chromium.org2010-06-032-16/+15
| | | | | | | | | BUG=45148 TEST=compile chrome with PRODUCT_VERSION manually set to something higher than the current version (e.g. 7.0.0.0), and manually set the upgrade detector time to something short (like 10 seconds). Launch chrome and wait a short time for the update notification to appear. The update notification should pulse every few seconds, and should stop pulsing when the user opens the wrench menu. The about menu item should launch a dialog that allows the user to restart chrome, restoring the current session. Review URL: http://codereview.chromium.org/2365003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48795 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] packaging process cleanup: Net of this is the zip off the official ↵thomasvl@chromium.org2010-06-024-0/+817
| | | | | | | | | | | | | | builder will have everything for packaging so the final signing/dmg creation is self contained instead of having to live in both places. - Move all the installer related bits into the installer folder - Add the collection of these bits into a specific target - Collect the internal bits also during the installer target BUG=42635 TEST=none Review URL: http://codereview.chromium.org/2417007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48732 0039d316-1c4b-4281-b951-d872f2087c98
* Separate version env variable for different distributions.huanr@chromium.org2010-05-285-1/+13
| | | | | | | | BUG=26819 Review URL: http://codereview.chromium.org/2339001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48495 0039d316-1c4b-4281-b951-d872f2087c98
* Use different product IO for SxS in mini installer.huanr@chromium.org2010-05-284-1/+14
| | | | | | | | | | BUG=44846 TEST=mini_installer --chrome-sxs Review URL: http://codereview.chromium.org/2267003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48465 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the spdy A/B test for SxS installations. npn_with_http and npn_with_spdy lzheng@chromium.org2010-05-272-2/+8
| | | | | | | | | | | | will be enabled at 50% of chance. BUG=45022 TEST=Use command-line flag --chrome-sxs to force the browser as SxS, go to gmail.com, login/logout, check about:histograms, you should see xx_spdytrial_xxx histograms. Review URL: http://codereview.chromium.org/2188001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48404 0039d316-1c4b-4281-b951-d872f2087c98
* Enable warning 4389 as an error on windows builds. This will make mbelshe@chromium.org2010-05-271-2/+2
| | | | | | | | | | | | windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2222002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Another dependency the bbot missed!!!"rafaelw@chromium.org2010-05-261-2/+2
| | | | | | | | | | | | | | | | | | This reverts commit 161f7fd3bdd425167af9fe26fdc5373a2ff44c98. Revert "Missed a file as part of checkin for r48186" This reverts commit cff86beba5938209393a6c3bccced62a7f3ff36b. Revert "Enable warning 4389 as an error on windows builds. This will make" This reverts commit c78936bcfc65b98edf288191d927a495b0364621. TBR=mbelshe Review URL: http://codereview.chromium.org/2253001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48238 0039d316-1c4b-4281-b951-d872f2087c98
* file_util: Convert the wstring version of IsDirectoryEmpty to FilePath.tfarina@chromium.org2010-05-261-3/+2
| | | | | | | | | BUG=24672 TEST=compiles Review URL: http://codereview.chromium.org/2153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48237 0039d316-1c4b-4281-b951-d872f2087c98
* Another dependency the bbot missed!!!mbelshe@chromium.org2010-05-251-2/+2
| | | | | | | | | BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2201001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48198 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath::DirName instead of the deprecated file_util::GetDirectoryFromPath.tfarina@chromium.org2010-05-241-10/+11
| | | | | | | | | BUG=24672 TEST=compiles Review URL: http://codereview.chromium.org/2110021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48014 0039d316-1c4b-4281-b951-d872f2087c98
* Fix import path for create_string_rc.pytony@chromium.org2010-05-241-0/+1
| | | | | | | | TBR=mark Review URL: http://codereview.chromium.org/2089022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48009 0039d316-1c4b-4281-b951-d872f2087c98
* Break gyp cycles on Linux.tony@chromium.org2010-05-243-936/+1
| | | | | | | | | | The cycle is between installer.gyp and chrome.gyp. The fix is to switch installer.gyp into installer.gypi and include it into chrome.gyp BUG=35308 Review URL: http://codereview.chromium.org/2067018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48007 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable nacl_ui_tests on Windows + fix win64 issue.gregoryd@google.com2010-05-201-3/+5
| | | | | | | | | | Some functions in master_preferences_dummy.cc are now called but they are still not relevant for the 64-bit binary. BUG=44371 Review URL: http://codereview.chromium.org/2115011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47825 0039d316-1c4b-4281-b951-d872f2087c98
* Using different Version environment variable for SxS.huanr@chromium.org2010-05-196-3/+11
| | | | | | | | | | | BUG=44474 TEST=mini_installer.exe --chrome-sxs. The first run should start regardless what is set for CHROME_VERSION. Review URL: http://codereview.chromium.org/2101006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47600 0039d316-1c4b-4281-b951-d872f2087c98
* GYP changes for FreeBSD and OpenBSDpvalchev@google.com2010-05-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/1480002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47327 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the toast inactive duration to 3000 days to effectively disable it.gwilson@google.com2010-05-121-1/+1
| | | | | | | | | | | BUG=43891 TEST=Trigger toast scenario, it should only appear if user data dir is 3000 days old. R=cpu Review URL: http://codereview.chromium.org/2016009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46994 0039d316-1c4b-4281-b951-d872f2087c98
* Try harder to clean up temp files in case we have a failed install / upgrade.robertshield@chromium.org2010-05-111-1/+16
| | | | | | | | | | BUG=37497 TEST=Fail an upgrade (for example, try to apply a differential installer to the wrong base version) while somehow endeavouring to lock the temp files mid upgrade (a debugger or a quick hand will be necessary) and observe that the temp files are scheduled for deletion on reboot. Review URL: http://codereview.chromium.org/1936006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46883 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Make file_util::Delete("c:\\foo_dir", false) work correctly. Add ↵thestig@chromium.org2010-05-077-7/+7
| | | | | | | | | | more unit tests for Delete. BUG=42374 TEST=included Review URL: http://codereview.chromium.org/1763008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46725 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 46633 - Windows: Make file_util::Delete("c:\\foo_dir", false) work ↵zork@chromium.org2010-05-077-7/+7
| | | | | | | | | | | | | correctly. Add more unit tests for Delete. BUG=42374 TEST=included Review URL: http://codereview.chromium.org/1763008 TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/2038004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46640 0039d316-1c4b-4281-b951-d872f2087c98
* Windows: Make file_util::Delete("c:\\foo_dir", false) work correctly. Add ↵thestig@chromium.org2010-05-067-7/+7
| | | | | | | | | | more unit tests for Delete. BUG=42374 TEST=included Review URL: http://codereview.chromium.org/1763008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46633 0039d316-1c4b-4281-b951-d872f2087c98
* Escape special characters in installer strings (rc file).tony@chromium.org2010-05-061-1/+5
| | | | | | Review URL: http://codereview.chromium.org/1980006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46549 0039d316-1c4b-4281-b951-d872f2087c98
* Win SxS: Use SxS icon on the shortcuts in start menu, etc.mattm@chromium.org2010-05-051-2/+10
| | | | | | | | | BUG=37119 TEST=build official mini_installer, install with and without --chrome-sxs, check icons of created entries Review URL: http://codereview.chromium.org/1959003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46502 0039d316-1c4b-4281-b951-d872f2087c98
* Add shared/images to chrome.releasearv@chromium.org2010-05-041-0/+1
| | | | | | | | | BUG=42817 TEST=Build the installer and make sure that icons are included. Review URL: http://codereview.chromium.org/1913001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46309 0039d316-1c4b-4281-b951-d872f2087c98
* r46025 reverted r46023 which caused a build break on chromeos.prasadt@chromium.org2010-04-302-6/+0
| | | | | | | | | | | | | | | This change reverts r46025 and fixes the build break which is just a one line change in chrome/browser/first_run_gtk.cc to move the definition of Upgrade::new_command_line_ to be inside a #if. Details on the change and code review feedback for the original CL can be found at http://codereview.chromium.org/1633021. BUG=40975 TEST=none Review URL: http://codereview.chromium.org/1691022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46103 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r46023: "Detect new instance of the browser when running in the ↵willchan@chromium.org2010-04-302-0/+6
| | | | | | | | | | background in persistent" Broke the build. Review URL: http://codereview.chromium.org/1718024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46025 0039d316-1c4b-4281-b951-d872f2087c98
* Detect new instance of the browser when running in the background in persistentprasadt@chromium.org2010-04-302-6/+0
| | | | | | | | | | | | | | | | | | mode, shutdown and restart the new instance. This is already done for Windows, this CL enables the functionality for Linux. We don't yet have a unit test for this. Local testing is done by: 1) Reducing the timer to 30 seconds. 2) Changing BrowserList::IsInPersistentMode to return true. 3) Setting BrowserProcessImpl::autoupdate_timer_ to 30 seconds interval. 4) Running "touch" command on chrome exe to pretend there is an update. BUG=40975 TEST=none Review URL: http://codereview.chromium.org/1633021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46023 0039d316-1c4b-4281-b951-d872f2087c98
* Add shared resources to the installer chrome.release filefeldstein@chromium.org2010-04-291-2/+4
| | | | | | | | | | | | Since all the cr.js resources were moved to the shared folder, chrome.release needs to be updated to copy it to the installer BUG=none TEST=Test that the bookmark manager works from the installer Review URL: http://codereview.chromium.org/1796003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45895 0039d316-1c4b-4281-b951-d872f2087c98
* Add the component apps to the installer, so that they work in installed builds.aa@chromium.org2010-04-291-0/+3
| | | | | | Review URL: http://codereview.chromium.org/1706018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45892 0039d316-1c4b-4281-b951-d872f2087c98
* Additional changes to support Chrome / CF installation wrapped in an MSI:robertshield@chromium.org2010-04-2810-57/+160
| | | | | | | | | | | | | | | Disables start menu uninstall shortcuts. Tweaks quoting of uninstall command to follow msi ca rules. Adds a ClientState registry entry to flag that this installation is managed by an MSI. Set said registry flag on first MSI install. BUG=19370 TEST=Install with generated MSI, upgrade, uninstall. Review URL: http://codereview.chromium.org/1525042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45802 0039d316-1c4b-4281-b951-d872f2087c98
* gyp: unify toolkit_views usageevan@chromium.org2010-04-271-4/+4
| | | | | | | | | | | Now that we can rely on toolkit_views to be set when appropriate, we can simplify a bunch of logic in gyp. TEST=compiles Review URL: http://codereview.chromium.org/1741010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45727 0039d316-1c4b-4281-b951-d872f2087c98
* Win SxS: Show SxS in about box version instead of unknown.mattm@chromium.org2010-04-235-3/+17
| | | | | | | | | BUG=37129,38334 TEST=install sxs, check about box and about:version Review URL: http://codereview.chromium.org/1771003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45496 0039d316-1c4b-4281-b951-d872f2087c98
* Win: Use different icon for SxSmattm@chromium.org2010-04-234-0/+11
| | | | | | | | | BUG=37119 TEST=build official exe, run with --chrome-sxs Review URL: http://codereview.chromium.org/1727006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45388 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the window class name references to Chrome_WindowImpl instead of ↵gwilson@google.com2010-04-221-4/+4
| | | | | | | | | | | | | Chrome_WidgetWin -- it looks like these names changed at some point. R=cpu,kuchhal BUG=none TEST=Run GCAPI test, Chrome should launch and resize at 250x250 Review URL: http://codereview.chromium.org/1768001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45325 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies Installation return codes to not return success (0) if an existing ↵gwilson@google.com2010-04-211-1/+0
| | | | | | | | | | | | | version was launched. Omaha needs to know the correct error result if it is to show the right error message to the user. R=cpu BUG=40607 TEST=Over-install trunk/dev channel over a system-level stable install, you should see error code 3 Review URL: http://codereview.chromium.org/1747001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45236 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure GoogleUpdateSettings::GetChromeChannel does not read siggi@chromium.org2010-04-203-8/+27
| | | | | | | | | | | | | from the wrong section of registry when a per-user install has left some registrations behind. Fix the odd race and other bugs I encountered along the way. BUG=40994 TEST=Unittests in this change. Open about box and look at the channel string. Review URL: http://codereview.chromium.org/1582035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45043 0039d316-1c4b-4281-b951-d872f2087c98
* Twiddle the DACLs in setup.exe before re-launch at user levelcpu@chromium.org2010-04-191-1/+58
| | | | | | | | | | | | In Vista and above the c:\windows\temp directory does not seem to allow RX for other accounts. So we add RX for the authenticated_users group before doing the user-level relaunch. BUG=41699 TEST= see bug Review URL: http://codereview.chromium.org/1585044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44986 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 44805 - Make sure GoogleUpdateSettings::GetChromeChannel does not readsiggi@chromium.org2010-04-165-102/+16
| | | | | | | | | | | | | | | | from the wrong section of registry when a peruser install has left some registrations behind. Fix the odd race and other bugs I encountered along the way. BUG=40994 TEST=Unittests in this change. Open about box and look at the channel string. Review URL: http://codereview.chromium.org/1582035 TBR=siggi@chromium.org Review URL: http://codereview.chromium.org/1610034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44812 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure GoogleUpdateSettings::GetChromeChannel does not readsiggi@chromium.org2010-04-165-16/+102
| | | | | | | | | | | | | from the wrong section of registry when a per-user install has left some registrations behind. Fix the odd race and other bugs I encountered along the way. BUG=40994 TEST=Unittests in this change. Open about box and look at the channel string. Review URL: http://codereview.chromium.org/1582035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44805 0039d316-1c4b-4281-b951-d872f2087c98
* Add new search engine dialog for first run process.mirandac@chromium.org2010-04-133-2/+9
| | | | | | | | | | BUG= 37564 TEST= start Chrome with --first-run enabled -- you should see a new search engine selection dialog. Review URL: http://codereview.chromium.org/1586005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44416 0039d316-1c4b-4281-b951-d872f2087c98
* Add the Resources/net_internals directory to mini_installer's manifest.eroman@chromium.org2010-04-121-0/+1
| | | | | | | | BUG=38611 Review URL: http://codereview.chromium.org/1649001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44280 0039d316-1c4b-4281-b951-d872f2087c98
* Auto restart when update available while running in the background on windows.atwilson@chromium.org2010-04-092-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | Landing on behalf of dbelenko@google.com. This is a new version of the older patch. Main changes include: 1. Rebased to a never Git revision to make things easier to land. 2. Chrome will now preserve the command line switches except for those that are blacklisted. 3. Fixed a race condition that would cause the browser to think it didn't exit cleanly after it's been restarted. 4. Fixed minor nits and omissions (indentation, etc). This patch adds a timer which fires every 6 hours and checks whether the browser is in the "persistent" (background) mode, and whether there's an update pending restart. If both conditions are true, the browser is restarted with blacklisted command line keys and all loose values stripped. In order to restart the browser in the background mode, the --long-lived-extensions key is also added to the command line. This change is Windows-only, and it won't become fully functional until Drew (atwilson) checks in his work that enables Chrome to go into background. Additionally, this addresses an issue where a restarted browser might load its profile data before the previous browser process exited - we now load the profile data *after* trying to contact the other browser. This exposed a race condition in SessionRestoreUITest.RestoreAfterClosingTabbedBrowserWithAppAndLaunching, so we disabled that test and logged http://crbug.com/40946. BUG=40975,40946 Review URL: http://codereview.chromium.org/1618012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44121 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies setup's fallback language order. If Omaha has a language specified ↵gwilson@google.com2010-04-091-5/+20
| | | | | | | | | | | | in the registry, use that one first. R=cpu,kuchhal BUG=39986 TEST=Install Chrome with a "lang" parameter specified to Omaha different than the system language. Then run setup.exe --show-eula and observe the EULA dialog is in one language, the one specified in the "lang" parameter. Review URL: http://codereview.chromium.org/1518019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44088 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43989 - This is a new version of the older patch. Main changes include:atwilson@chromium.org2010-04-092-8/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | 1. Rebased to a never Git revision to make things easier to land. 2. Chrome will now preserve the command line switches except for those that are blacklisted. 3. Fixed a race condition that would cause the browser to think it didn't exit cleanly after it's been restarted. 4. Fixed minor nits and omissions (indentation, etc). This patch adds a timer which fires every 6 hours and checks whether the browser is in the "persistent" (background) mode, and whether there's an update pending restart. If both conditions are true, the browser is restarted with blacklisted command line keys and all loose values stripped. In order to restart the browser in the background mode, the longlivedextensions key is also added to the command line. This change is Windowsonly, and it won't become fully functional until Drew (atwilson) checks in his work that enables Chrome to go into background. Review URL: http://codereview.chromium.org/1617001 TBR=atwilson@chromium.org Review URL: http://codereview.chromium.org/1517027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44041 0039d316-1c4b-4281-b951-d872f2087c98