| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
blocking updates for individual products are conflicting with the effective update policy for the multi-install binaries.
In so doing, I moved the GP update policy checking code that was in browser into installer_util.
BUG=none
TEST=Install multi-install Chrome version N-1, disable updates for Chrome, then try to update to version N. With luck, you'll find that the update failed on account of inconsistent GP settings.
R=robertshield@chromium.org,pastarmovj@chromium.org,gwilson@chromium.org
Review URL: http://codereview.chromium.org/7111012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=85988
TEST=see bug
Review URL: http://codereview.chromium.org/7148004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
connectivity from the browser (first cut). Collect
stats for TCP connectivity also.
- What percentage of users can get a message end-to-end
to an TCP and UDP server.
- What is the latency for TCP and UDP messages.
Added TCP and UDP echo servers to testserver.py
for unittests.
BUG=82565
TEST=udp tests
Review URL: http://codereview.chromium.org/7056031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
following r82170.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7033053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7033050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update's installer result API. A future change will stop putting the value in the Google Update "ap" value ("-stage:foo") and clear any stage info laying around.
BUG=none
TEST=confirm that the InstallerExtraCode1 rolls along throughout processing and is removed when all is well.
Review URL: http://codereview.chromium.org/7027036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to the "ap" value during the end stage of the installer (where we seem to encounter most of our crashes / timeouts).
Note that this CL alters the length of the InstallerStage enum (and modifies the guarding COMPILE_ASSERT). This is safe right now because we don't report the numeric values directly.
BUG=NONE
TEST=We start getting more useful data about the point at which the installer crashes / times out.
Review URL: http://codereview.chromium.org/7080058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
update checks for installs where the machine was left in the ensemble_patching stage. I blieve that in most of these cases, setup.exe was patched without a crash. It's better if we clear the stage so that these cases aren't confused with true crashes while patching.
BUG=none
TEST=stage info should be cleared at the conclusion of --update-setup-exe processing.
R=robertshield@chromium.org
Review URL: http://codereview.chromium.org/6975058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is run with only the --multi-install switch. This will allow us to greatly simplify the Google Update server config for the Chrome binaries app id, as it will no longer need to call out every permutation of product installations.
BUG=76695
TEST=On a system with one or more multi-install products installed, run the installer with --multi-install [ --system-level ] [ --verbose-logging ] and notice that all multi-install products are updated. Run it on a system with no multi-install products and notice that it returns 15 (CHROME_NOT_INSTALLED) and puts the proper error info into the Chrome binaries' ClientState key.
Review URL: http://codereview.chromium.org/7087030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
multi. Previously, we were missing the current version, which could have led to:
- failing to set "opv" on in-use update
- failing to unregister Chrome Frame COM DLLs
- returning INSTALL_FAILED instead of SAME_VERSION_REPAIR_FAILED
- returning FIRST_INSTALL_SUCCESS instead of INSTALL_REPAIRED, IN_USE_UPDATED, or NEW_VERSION_UPDATED
- leaving behind old version directories
- failing to check for duplicates on same version repair
BUG=none
TEST=install single chrome. run mini_installer.exe with --multi-install --chrome to migrate to multi-install. make sure the installer result code is correct as above.
TBR=robertshield@chromium.org
Review URL: http://codereview.chromium.org/7085006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
install of Chrome is around on a different channel.
BUG=83571
TEST=install user level single Chrome then install user level multi Chrome Frame from a different channel.
R=robertshield@chromium.org
Review URL: http://codereview.chromium.org/6966035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
multi. Previously, we were missing the current version, which could have led to:
- failing to set "opv" on in-use update
- failing to unregister Chrome Frame COM DLLs
- returning INSTALL_FAILED instead of SAME_VERSION_REPAIR_FAILED
- returning FIRST_INSTALL_SUCCESS instead of INSTALL_REPAIRED, IN_USE_UPDATED, or NEW_VERSION_UPDATED
- leaving behind old version directories
- failing to check for duplicates on same version repair
BUG=none
TEST=install single chrome. run mini_installer.exe with --multi-install --chrome to migrate to multi-install. make sure the installer result code is correct as above.
Review URL: http://codereview.chromium.org/6976049
TBR=grt@chromium.org
Review URL: http://codereview.chromium.org/7085003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, we were missing the current version, which could have led to:
- failing to set "opv" on in-use update
- failing to unregister Chrome Frame COM DLLs
- returning INSTALL_FAILED instead of SAME_VERSION_REPAIR_FAILED
- returning FIRST_INSTALL_SUCCESS instead of INSTALL_REPAIRED, IN_USE_UPDATED, or NEW_VERSION_UPDATED
- leaving behind old version directories
- failing to check for duplicates on same version repair
BUG=none
TEST=install single chrome. run mini_installer.exe with --multi-install --chrome to migrate to multi-install. make sure the installer result code is correct as above.
Review URL: http://codereview.chromium.org/6976049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
that system-level Chrome Frame is present. This is a first step to handling user-to-system-level handoff.
It will cause a user-level install to be correctly replaced with a system-level one once the user logs out and back in again. Additional changelists
will follow that:
1) Ensure full clean-up of the user-level installation.
2) Handle notifications such that logging out and in again isn't required.
BUG=82816
TEST=Install user-level Chrome Frame.
Review URL: http://codereview.chromium.org/7065024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mac/win.
Note this is unused currently, but will be hooked up to
navigator.registerProtocolHandler in a subsequent change.
BUG=83556
TEST=Manual
Review URL: http://codereview.chromium.org/6961013
Patch from Ben Wells <benwells@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86793 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keystone 1.0.9.2318 or later is present.
Providing this data to Keystone will cause it to check the application's
Info.plist to determine the installed version, rather than using the version
embedded within the ticket. The version in the ticket can become stale in
some rare situations through innocent user action.
This allows a user to replace Chrome with an earlier version (perhaps on
another channel) and not get "stuck" without autoupdates until that channel
catches up with the version listed in the ticket. (b/2506062)
This also prevents Keystone from believing an update is still available if
Chrome is updated but not restarted and the user subsequently promotes
Chrome's user ticket to a system ticket from within Chrome. (crbug.com/38696)
BUG=38696, 83082
TEST=none
Review URL: http://codereview.chromium.org/7029034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=83180
TEST=none
Review URL: http://codereview.chromium.org/7049027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like they got moved accidentally in http://codereview.chromium.org/6714032
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7048007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We provided <(library) as a variable to support a peculiar
build configuration on Linux. We no longer support that build
configuration, so we can simplify this code to no longer use
a variable.
Review URL: http://codereview.chromium.org/7051014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
initializes VAR if not already set.
BUG=83180
TEST=Run dirdiffer.sh under bash 4.0 or newer (4.2.10 is current)
Review URL: http://codereview.chromium.org/7050013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
longer initializes VAR if not already set.
BUG=83180
TEST=Run .keystone_install under bash 4.0 or newer (4.2.10 is current)
Review URL: http://codereview.chromium.org/7050012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that Google Update will pick them up regardless of which one it happens to be monitoring.
BUG=none
TEST=Google Update continues to properly report install errors to its servers.
Review URL: http://codereview.chromium.org/7036017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=82922
TEST=none
Review URL: http://codereview.chromium.org/7017019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Significant refactoring with some notable behavior changes:
1. Switches are appended preceding existing arguments (after other swtiches).
2. (Windows) command_line_string() is generated and properly quoted/escaped.
3. Appended switches will retain their (optional) included prefixes (--,-,/).
Notable internal changes (shouldn't affect behavior):
1. (Windows) Generate the cl string, instead of storing&updating the original.
2. Explicitly retain switch prefixes (--,-,/) (was automatic in init*/ctor).
Update (obvious) code expecting switches to be appended antecedent to args.
Add Nico's test from: codereview.chromium.org/6728016/.
An intermediary CL landed between patch set 3 and 4, see:
http://codereview.chromium.org/6596020
BUG=73195,67764
TEST=Commandline usage.
Review URL: http://codereview.chromium.org/6526040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
target directory heirarchy (regression introduced in r75899).
BUG=82424
TEST=Install system-level Chrome as some admin user X. Switch to admin user Y and try to uninstall.
R=robertshield@chromium.org
Review URL: http://codereview.chromium.org/7011018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now we not just call it from chrome.exe (chrome/app) but it
is also called periodically from chrome.dll itself
BUG=82180
TEST=see bug
Review URL: http://codereview.chromium.org/7005008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
that contains similar files. This will be used to allow "repair" installs to succeed when the same version of the Chrome binaries are both in use and look similar (same files, same file sizes) but will still allow us to fix installs that have missing or obviously changed files.
This should reduce a lot of the user-visible errors seen when people attempt to install version X of chrome on top of an already-running indentical version.
BUG=82146
TEST=Install Chrome, run it, install it again. See a success message.
Review URL: http://codereview.chromium.org/7001004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=82207
TEST=See if in-use updates in the canaries and in Chrome Frame work.
Review URL: http://codereview.chromium.org/7005019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=75951
TEST=NONE
Review URL: http://codereview.chromium.org/6982002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=n/a
BUG=0
Review URL: http://codereview.chromium.org/6981011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The dependencies in mini_installer.gyp should be OK, because the
target that produces chrome.exe also copies nacl_irt_* into
<(PRODUCT_DIR) as a side effect.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=1595
TEST=not sure how to test this, apart from manually testing the
install images that are produced after this is committed
Review URL: http://codereview.chromium.org/6995015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
--rename-chrome-exe command lines.
BUG=79935
TEST=Install version N-1 w/ --verbose-logging --chrome --chrome-frame --multi-install --ready-mode --system-level, navigate to gcf:about:version in IE, then install version N with same args. Inspect chrome_frame_installer.log and note the lack of validation errors. Close IE and note that the update completes and all "opv" and "cmd" values are removed from the various ClientState keys.
Review URL: http://codereview.chromium.org/6951016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Check logs after ordinary installation runs to be sure no errors are reported. Optionally run validate_installation.exe manually and see what it reports.
Review URL: http://codereview.chromium.org/6930036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac (x86-32 only):
chrome/chrome_dll.gypi
Linux (x86-32 or x86-64, depending on the target arch):
chrome/chrome_installer.gypi
chrome/tools/build/linux/FILES.cfg
Windows (both x86-32 and x86-64 in the same install image)
chrome/installer/mini_installer.gyp
chrome/installer/mini_installer/chrome.release
chrome/tools/build/win/FILES.cfg
I am not sure if I need to add to the lists in
chrome/tools/build/{linux,win}/FILES. Since there are files listed in
FILES.cfg that are not in FILES, I will assume not.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=1595
TEST=not sure how to test this, apart from manually testing the
install images that are produced after this is committed
Review URL: http://codereview.chromium.org/6927015
TBR=mseaborn@chromium.org
Review URL: http://codereview.chromium.org/6927050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac (x86-32 only):
chrome/chrome_dll.gypi
Linux (x86-32 or x86-64, depending on the target arch):
chrome/chrome_installer.gypi
chrome/tools/build/linux/FILES.cfg
Windows (both x86-32 and x86-64 in the same install image)
chrome/installer/mini_installer.gyp
chrome/installer/mini_installer/chrome.release
chrome/tools/build/win/FILES.cfg
I am not sure if I need to add to the lists in
chrome/tools/build/{linux,win}/FILES. Since there are files listed in
FILES.cfg that are not in FILES, I will assume not.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=1595
TEST=not sure how to test this, apart from manually testing the
install images that are produced after this is committed
Review URL: http://codereview.chromium.org/6927015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the multi-install binaries' ClientState{Medium} key.
BUG=none
TEST=Confirm no substantive change in single-install Chrome. In multi-install, usagestats should be in the ClientState\{4DC8B4CA-1BDA-483e-B5FA-D3C12E15B62D} and/or ClientStateMedium\{4DC8B4CA-1BDA-483e-B5FA-D3C12E15B62D} key. Enabling/disabling usage stats for multi-install Chrome (via Under the Hood) should control crash reports and UMA for multi-install Chrome Frame.
Review URL: http://codereview.chromium.org/6936001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
GetChannel was confused in multi-user installs. It treated them as
CHANNEL_UNKNOWN instead of their correct channels.
BUG=81218
TEST=none
Review URL: http://codereview.chromium.org/6893158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UserExperimentDetails. The lesson learned is that braces must be present for the following pattern:
if (cond) {
DCHECK_*(...);
} else
...
Since the DCHECK_op macros expand to if (blahdebla).
BUG=none
TEST=none
R=finnur@chromium.org
Review URL: http://codereview.chromium.org/6883264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
is absent (an absent "ap" means the same thing as an empty "ap" value, namely Stable). Do this by causing ChannelInfo::Initialize to not return false when the "ap" value is missing.
Update unit tests that were checking for the old behaviour of ChannelInfo.
BUG=80683
TEST=Install Stable channel Chrome on Windows. Go to the about box. Observe that the string "unknown" does not show up in the version number.
Review URL: http://codereview.chromium.org/6901070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=76996
TEST=none
Review URL: http://codereview.chromium.org/6894040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
canary, matching the Mac canary and the new approved naming.
BUG=79814
TEST=The About window
Review URL: http://codereview.chromium.org/6895022
Review URL: http://codereview.chromium.org/6897028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the Windowscanary, matching the Mac canary and the new approved naming.BUG=79814TEST=The About windowReview URL: http://codereview.chromium.org/6895022
Get rid of redness in official bulder
TBR=mark@chromium.org
Review URL: http://codereview.chromium.org/6900027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
canary, matching the Mac canary and the new approved naming.
BUG=79814
TEST=The About window
Review URL: http://codereview.chromium.org/6895022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=79814
TEST=none
Review URL: http://codereview.chromium.org/6900013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
use base.dll from chrome.
BUG=76996
TEST=none
Review URL: http://codereview.chromium.org/6877053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=79814
TEST=none
Review URL: http://codereview.chromium.org/6883056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content now.
TBR=avi
Review URL: http://codereview.chromium.org/6875018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=74035
TEST=see bug
Review URL: http://codereview.chromium.org/6813099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=78938,78143
TEST=Icon updates correctly between versions and is created correctly on first install.
Review URL: http://codereview.chromium.org/6865004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
could be in use while npchrome_frame.dll isn't.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/6677078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81739 0039d316-1c4b-4281-b951-d872f2087c98
|