| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
| |
- I mean to spawn setup.exe --flag but it does setup.exe --uninstall
- sweet overloaded functions also let you shoot yourself in the foot
BUG=b/1484308
TEST=see the bug
Review URL: http://codereview.chromium.org/147253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15410
Review URL: http://codereview.chromium.org/147216
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Toast experiment was missing a space before "--"
- Quote the first param (exe path) because it can contain spaces
BUG= none
TEST=chrome should uninstall as usual (launches chrome to confirm user action)
Review URL: http://codereview.chromium.org/149048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/146097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
definitions file for installation.)
Review URL: http://codereview.chromium.org/146109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
installation."
This reverts commit r19170.
Review URL: http://codereview.chromium.org/146106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14201
Review URL: http://codereview.chromium.org/147092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- The analisis team needs a control group; these are users that qualify don't get the experiment.
- Select 50 % at random
BUG= b/1484308
TEST = see the bug
Review URL: http://codereview.chromium.org/147057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15095
Review URL: http://codereview.chromium.org/146063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I am not sure why we had split install.h functions into setup.cc and install.cc.
I think we only need install.{h|cc} just like we have uninstall.{h|cc}.
BUG=12849
Review URL: http://codereview.chromium.org/147016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Google Chrome build.
Note that the inclusion of this value is contingent upon the user having opted to send up anonymous usage information.
BUG=b/1484308
TEST=Verify uninstall survey URL contains &client=<client-string>
Review URL: http://codereview.chromium.org/146014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
setup to finish fast.
- Added new cmd line flag to setup.exe: --inactive-user-toast
BUG= b/1484308
TEST = see the bug
Review URL: http://codereview.chromium.org/144015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base path.
This make it possible to actually build all.sln!
BUG=None
TEST=None
TBR=gspencer
Review URL: http://codereview.chromium.org/147030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/141024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Dependency on gtest.
* Add intel\mt_lib\{P4_,}memset.obj as AdditionalDependencies.
* Update library directories.
* Make sure BasicRuntimeChecks=0 for both Debug and Release.
* The manifest now comes from the sources list,
not in AdditionalManifestFiles.
* AdditionalOptions to override the build/common.gypi defaults.
* GenerateMapFile
* Fix spelling errors.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/141015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adds read-write to the client key of google_update
- Adds the logic to track experiment outcome
- Some new geric exitc codes (non error codes)
BUG= b/1484308
TEST= see the bug
Review URL: http://codereview.chromium.org/132058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
to 'chrome'.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/131011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
AdditionalManifestFiles of setup.exe and mini_installer.exe.
BUG=14439
TEST=none
Review URL: http://codereview.chromium.org/125273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adds the inactive user toast logic
- Some refactoring of helper functions
BUG=b/1484308
TEST=see the bug
Review URL: http://codereview.chromium.org/125234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
execution of installer_util_unittests.exe and mini_installer_tests.exe.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126261
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Consistent use of <(SHARED_INTERMEDIATE_DIR)/setup for the
output directory of the generated setup_exe_version.rc file.
* Add setup/setup_util.{cc,h}.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/125237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/125236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18589 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/125199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14007
TEST=Uninstall a build with this patch and verify that the uninstall survey window has ap=XXXX in the URL.
Review URL: http://codereview.chromium.org/126154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
3 stage updates.
BUG=12832
Review URL: http://codereview.chromium.org/126157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
of the last targets to gyp:
* 'unit_tests' depends on 'chrome_dll_version'.
* Various VCCLCompilerTool and VCLinkerTool settings for mini_installer.exe.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/125136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=6471
TEST=set TMP to invalid dir and run mini_installer.exe, it should still work.
Review URL: http://codereview.chromium.org/125068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
always existed, but was never hooked up to an installerdata preference.
R=cpu
BUG=13752
TEST=Run the installer with a line in the distribution block of the installerdata that reads: "import_home_page" : true. The home page of the previous default browser should be imported.
Review URL: http://codereview.chromium.org/118512
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=successful build
Review URL: http://codereview.chromium.org/119411
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
name installer_util_unittests instead of util_unittests.
BUG=12849
Review URL: http://codereview.chromium.org/119322
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118324
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
project with only one unit test for now.
BUG=12849
TEST=none
Review URL: http://codereview.chromium.org/118247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118241
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
and installer_util_strings.{rc,h}.
BUG=none
TEST=successful build
Review URL: http://codereview.chromium.org/118284
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
See also http://codereview.chromium.org/118192
Review URL: http://codereview.chromium.org/118272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
indicates it's necessary (now that fetching the last change
info is in a separate target executed every build) by
getting rid of the never-built .bogus files in the rules.
Update chrome/installer/installer.gyp with the new patterns.
Make the use of the *_path variable names more consistent.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/119181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=12832
TEST=Build a mini_installer that has setup.exe patch only and make sure the installer still works.
Review URL: http://codereview.chromium.org/118144
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=12832
TEST=Build a mini_installer that has setup.exe patch only and make sure the installer still works.
Review URL: http://codereview.chromium.org/115839
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
installer.
BUG=12832
TEST=While building mini_installer try various values of DiffAlgorithm and SetupExeFormat property and make sure generated installer works.
Review URL: http://codereview.chromium.org/114073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/118141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/119027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Doing this by using existing vcproj files.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/119021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=12832
TEST=Either test new command line options (update-setup-exe, new-setup-exe) of setup.exe individually or get a mini_installer that has setup.exe patch only and make sure the installer still works.
Review URL: http://codereview.chromium.org/115866
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
messages a little bit.
BUG=11553
TEST=Uninstall system level chrome and select "delete profile data", %LOCALAPPDATA%\Chromium folder should get deleted.
Review URL: http://codereview.chromium.org/115945
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
variable for the 'OS=="win"' targets that use it, to work around
an apparent problem in the gyp variable expansion.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/118015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17204 0039d316-1c4b-4281-b951-d872f2087c98
|