| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These were mostly due to blind copy-paste. read_only:1 is the default so there's
no point in specifying it.
As per crbug.com/342913, only unit_tests has issue with running from read only
files.
R=jam@chromium.org
BUG=116251
Review URL: https://codereview.chromium.org/1240303002
Cr-Commit-Position: refs/heads/master@{#339490}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #2 id:20001 of https://codereview.chromium.org/1221333013/)
Reason for revert:
Speculative revert: appreas to have broken the GPU mac builders.
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%2010.9%20%28Intel%29%20%28dbg%29/builds/11045 .. 11141
Original issue's description:
> Add support for escaped target names in isolate driver (4th try)
>
> Currently the isolate_driver.py which creates the dependency files
> used by the isolate system, does a simple split on all spaces when
> trying to identify targets.
>
> This can fail if the target name contains a space in the name. In
> ninja, spaces are escaped with a $-prefix. An example would be
> 'Content$ Shell$ Helper.app'.
>
> This CL adds support for such target names and ensures that they
> stay as one item. Doing this uncovered a few missing dependencies
> and a missing file in some .isolate-files for the component build
> on Mac.
>
> 1st try: https://codereview.chromium.org/970203003/
> 1st revert: https://codereview.chromium.org/985753002/
> 2nd try: https://codereview.chromium.org/1103793002/
> 2nd revert: https://codereview.chromium.org/1129493003/
> 3rd try: https://codereview.chromium.org/1130523003/
> 3rd revert: https://codereview.chromium.org/1131363003/
> BUG=462248
>
> Committed: https://crrev.com/c58992cc880b5bff5813276ee9d20a79be70b31f
> Cr-Commit-Position: refs/heads/master@{#338402}
TBR=thakis@chromium.org,vadimsh@chromium.org,nyquist@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462248
Review URL: https://codereview.chromium.org/1227843004
Cr-Commit-Position: refs/heads/master@{#338497}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the isolate_driver.py which creates the dependency files
used by the isolate system, does a simple split on all spaces when
trying to identify targets.
This can fail if the target name contains a space in the name. In
ninja, spaces are escaped with a $-prefix. An example would be
'Content$ Shell$ Helper.app'.
This CL adds support for such target names and ensures that they
stay as one item. Doing this uncovered a few missing dependencies
and a missing file in some .isolate-files for the component build
on Mac.
1st try: https://codereview.chromium.org/970203003/
1st revert: https://codereview.chromium.org/985753002/
2nd try: https://codereview.chromium.org/1103793002/
2nd revert: https://codereview.chromium.org/1129493003/
3rd try: https://codereview.chromium.org/1130523003/
3rd revert: https://codereview.chromium.org/1131363003/
BUG=462248
Review URL: https://codereview.chromium.org/1221333013
Cr-Commit-Position: refs/heads/master@{#338402}
|
|
|
|
|
|
|
|
|
|
| |
They're not needed anymore now that NPAPI plugin support is disabled.
BUG=493212
Review URL: https://codereview.chromium.org/1182303010
Cr-Commit-Position: refs/heads/master@{#334711}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Motivations:
1. Eliminates a large number of windows crashes hit while loading the DLL (see bugs)
2. Reducing the size of binary (about 400KB on linux, about 265KB on 32bit windows) due to dead-code elimination
3. Simplifying media library initialization (Remove bool-ness, it just works)
Licensing:
We've audited all the licenses for the files we actually use and have the green light from legal as long as we include the license text in the credits.
BUG=435455, 429131, 441908
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/bfef6d6ba82b172ac0e48c80d9ccf1a1ca0ea5c5
Cr-Commit-Position: refs/heads/master@{#332891}
Review URL: https://codereview.chromium.org/1141703002
Cr-Commit-Position: refs/heads/master@{#333423}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverting because of component test failures around isolate expectations.
This change may not actually be directly responsible, but I'm out of time
to investigate for the day. Will re-land it soon.
BUG=496975
TBR=enne@chromium.org, gunsch@chromium.org, jochen@chromium.org, isherman@chromium.org, thomasvl@chromium.org, phajdan@chromium.org, grt@chromium.org, mmoss@chromium.org, sergeyu@chromium.org, sky@chromium.org, dalecurtis@chromium.org
This reverts commit bfef6d6ba82b172ac0e48c80d9ccf1a1ca0ea5c5.
NOPRESUBMIT=true
NOTRY=true
Review URL: https://codereview.chromium.org/1161183003
Cr-Commit-Position: refs/heads/master@{#332994}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Motivations:
1. Eliminates a large number of windows crashes hit while loading the DLL (see bugs)
2. Reducing the size of binary (about 400KB on linux, about 265KB on 32bit windows) due to dead-code elimination
3. Simplifying media library initialization (Remove bool-ness, it just works)
Licensing:
We've audited all the licenses for the files we actually use and have the green light from legal as long as we include the license text in the credits.
BUG=435455, 429131, 441908
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1141703002
Cr-Commit-Position: refs/heads/master@{#332891}
|
|
|
|
|
|
|
|
|
|
| |
This should have been part of https://codereview.chromium.org/1136493003.
BUG=419383
Review URL: https://codereview.chromium.org/1139913002
Cr-Commit-Position: refs/heads/master@{#329390}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #2 id:20001 of https://codereview.chromium.org/1130523003/)
Reason for revert:
Looks like interactive_ui_tests needs a dep on chrome too:
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/40889/steps/compile/logs/stdio
FAILED: cd ../../chrome; python ../tools/isolate_driver.py check --isolated "../out/Release/interactive_ui_tests.isolated" --isolate "interactive_ui_tests.isolate" --path-variable DEPTH .. --path-variable PRODUCT_DIR "../out/Release " --extra-variable "version_full=44.0.2398.0" --config-variable "CONFIGURATION_NAME=Release" --config-variable "OS=linux" --config-variable "asan=0" --config-variable "branding=Chrome" --config-variable "chromeos=0" --config-variable "component=static_library" --config-variable "disable_nacl=0" --config-variable "enable_pepper_cdms=1" --config-variable "enable_plugins=1" --config-variable "fastbuild=0" --config-variable "icu_use_data_file_flag=1" --config-variable "internal_gles2_conform_tests=0" --config-variable "kasko=0" --config-variable "libpeer_target_type=static_library" --config-variable "lsan=0" --config-variable "msan=0" --config-variable "target_arch=ia32" --config-variable "tsan=0" --config-variable "use_custom_libcxx=0" --config-variable "use_instrumented_libraries=0" --config-variable "use_prebuilt_instrumented_libraries=0" --config-variable "use_openssl=0" --config-variable "use_ozone=0" --config-variable "use_x11=1" --config-variable "v8_use_external_startup_data=1"
Failed to find an input file: Input file /b/build/slave/google-chrome-rel-linux/build/src/out/Release/chrome doesn't exist
Reverting for now, but should be easy to fix.
Original issue's description:
> Add support for escaped target names in isolate driver (3rd try)
>
> Currently the isolate_driver.py which creates the dependency files
> used by the isolate system, does a simple split on all spaces when
> trying to identify targets.
>
> This can fail if the target name contains a space in the name. In
> ninja, spaces are escaped with a $-prefix. An example would be
> 'Content$ Shell$ Helper.app'.
>
> This CL adds support for such target names and ensures that they
> stay as one item. Doing this uncovered a few missing dependencies
> and a missing file in some .isolate-files for the component build
> on Mac.
>
> 1st try: https://codereview.chromium.org/970203003/
> 1st revert: https://codereview.chromium.org/985753002/
> 2nd try: https://codereview.chromium.org/1103793002/
> 2nd revert: https://codereview.chromium.org/1129493003/
> BUG=462248
>
> Committed: https://crrev.com/e94fb8bb82056ce3a255691a9326fd12707cf0cb
> Cr-Commit-Position: refs/heads/master@{#329038}
TBR=vadimsh@chromium.org,nyquist@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462248
Review URL: https://codereview.chromium.org/1131363003
Cr-Commit-Position: refs/heads/master@{#329064}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the isolate_driver.py which creates the dependency files
used by the isolate system, does a simple split on all spaces when
trying to identify targets.
This can fail if the target name contains a space in the name. In
ninja, spaces are escaped with a $-prefix. An example would be
'Content$ Shell$ Helper.app'.
This CL adds support for such target names and ensures that they
stay as one item. Doing this uncovered a few missing dependencies
and a missing file in some .isolate-files for the component build
on Mac.
1st try: https://codereview.chromium.org/970203003/
1st revert: https://codereview.chromium.org/985753002/
2nd try: https://codereview.chromium.org/1103793002/
2nd revert: https://codereview.chromium.org/1129493003/
BUG=462248
Review URL: https://codereview.chromium.org/1130523003
Cr-Commit-Position: refs/heads/master@{#329038}
|
|
|
|
|
|
|
|
|
| |
BUG=478209
TBR=dpranke
Review URL: https://codereview.chromium.org/1120083003
Cr-Commit-Position: refs/heads/master@{#328185}
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 919dce4400651813d5ff6e8a85b944a5987adcb7.
BUG=None
TBR=akuegel
Review URL: https://codereview.chromium.org/1094553002
Cr-Commit-Position: refs/heads/master@{#325412}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I am reverting all CLs that could have caused this failure:
http://build.chromium.org/p/chromium.linux/builders/
Android%20Tests%20%28dbg%29/builds/27276
I will start re-landing vindicated CLs shortly.
Revert "Convert a11y_page.css to a11y_page_style.html. See http://goo.gl/vIGSCO for more information."
This reverts commit eb48d65705e44b80d1d7a3b4f21c567802c102bb.
Revert "Supply build properties to run-bisect-perf regression for android bisects."
This reverts commit 9d70bb94984b02c17678ccf482d1a7b7c760a43f.
Revert "[cros New-GAIA] Webview login and new GAIA endpoint enabled by default"
This reverts commit 29061783f8b59f1e78286a87a3bb7d18129f639a.
Revert "Prime the landing pad for the new video rendering pipeline."
This reverts commit 45a3c93f745eabf6c1b1cbdac87ed4350a919e76.
Revert "Implement separate error dialog for cws widget container"
This reverts commit 7ed1f876f6f4d79ac074b25f2066d514603aa18d.
Revert "Create device_bluetooth watchlist; add scheib."
This reverts commit 40514c99cd45d1c8e9caef3245d42533d9810179.
Revert "Convert checkbox.css to checkbox_style.html. See http://goo.gl/vIGSCO for more information."
This reverts commit a687f31a786645508622482e9033f497364a43cd.
Revert "Created new URLRequestContext for secure proxy check."
This reverts commit 652eabf1141c00594aa6e9ed81beb980aec89198.
Revert "Revert of Fix scroll regression when specifying an extension id. (patchset #4 id:60001 of https://codereview.chromium.org/1064573003/)"
This reverts commit 488846cd562f444831982d82ef0bc9ca0dd79028.
Revert "Sync: Add Android test for downloading a bookmark"
This reverts commit 9c052713563111ac3d6cc64d4b5cfdfa27c202f4.
Revert "ScreenOrientationController to start observing even without an internal display."
This reverts commit 31fed68a524d49f99cebf02dca6ad49019e9900c.
Revert "Fix MB configurations for Mac and Win GN bots."
This reverts commit 31a66f3e705d20a39033a7b7d7f09a60517e6b9d.
Revert "Add tool/perf/measurements path to check for CQ jobs."
This reverts commit 99e1ac1d217174dad7a862f6a0fc44950d503737.
Revert "Implement Notification.data for persistent notifications."
This reverts commit 539f51d6af62097059c34b1c19dfbc4352413ad7.
Revert "Fix playback rate calculations for WallClockTimeSource."
This reverts commit 3ec02d642465872d9ab7d7db600d0480a57b3cab.
Revert "Roll src/third_party/pdfium eddab44:b330016"
This reverts commit 81d51e253cfacd5648cca9f12b605e63971a9ab1.
Revert "cc: Make DisplayItemList::Append replay into an SkPicture"
This reverts commit ec7c07e57bc5f91e3ba0bdeba8b6f534978615b0.
Revert "Clean up URLFetcher unit tests, part 5."
This reverts commit 8eeb3bf4a02be612cacb3cdbb5c223d909939527.
BUG=None
TBR=akuegel
Review URL: https://codereview.chromium.org/1083683003
Cr-Commit-Position: refs/heads/master@{#325411}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For devices with Remora/Shark requisition webview is still disabled (http://crbug.com/464049)
webview is disabled for these tests:
* WizardControllerProxyAuthOnSigninTest* (http://crbug.com/452452)
* ProxyAuthOnUserBoardScreenTest* (http://crbug.com/452452)
* Tests that are based on LoginManagerTest/OobeBaseTest and are not yet parametrized (http://crbug.com/477402)
BUG=475529, 452452, 472664, 464049, 477402
TBR=jhawkins@chromium.org
Review URL: https://codereview.chromium.org/1079083002
Cr-Commit-Position: refs/heads/master@{#325307}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These are used, e.g., for the Bookmark -> Edit... dialogs on Cocoa and
Views.
This gets WidgetTestInteractive.*Window*ModalWindowDestroyedActivationTest
passing.
WidgetTestInteractive.*System*ModalWindowReleasesCapture is disabled in
this CL. System modal windows are not needed on Mac.
Currently the implementation on MacViews assumes all modal dialogs are
shown using a sheet. On Cocoa, this is not always true for
WebContents-Modal dialogs (e.g. cookies and site data), but it is true
for some WebContents-Modal dialogs (e.g. certificate information).
A follow-up will add logic to ensure WebContents-Modal dialogs are
handled appropriately, and have good test coverage.
After this all tests pass on the current mac trybot configuration with
toolkit_views=1.
BUG=403679
Review URL: https://codereview.chromium.org/993253002
Cr-Commit-Position: refs/heads/master@{#320977}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't need a virtual X server for ozone testing, and it is causing
problems running the tests with swarming. This changes all isolate files
to only run Xvfb if use_x11==1 is set in GYP_DEFINES, and merges ozone
with Windows & Mac (none of which need to run their own display server).
BUG=440882
TEST=isolate.py run -s out_ozone/Debug/<various>
TBR=maruel
Review URL: https://codereview.chromium.org/908313004
Cr-Commit-Position: refs/heads/master@{#319919}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This flag cannot be derived from GYP defines. Rather, the configuration of each
specific tester determines whether it should be passed.
BUG=455521
R=jam@chromium.org
Review URL: https://codereview.chromium.org/957383002
Cr-Commit-Position: refs/heads/master@{#318447}
|
|
|
|
|
|
|
|
|
| |
BUG=444835
TBR=jyasskin@chromium.org,piman@chromium.org
Review URL: https://codereview.chromium.org/906973003
Cr-Commit-Position: refs/heads/master@{#315547}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to issue 444835 there were at least two problems with debug info on
the swarming bots:
- the .dSYM bundles for the test binaries and other applications weren't
uploaded to swarming servers;
- for some binaries (e.g. Chromium Framework) their names were replaced with
SHA-1 hashes that confused llvm-symbolizer and made finding the .dSYM bundles
impossible.
This CL adds the necessary .dSYM paths to .isolate files for the tests
currently being ran on swarming bots (for other tests their .dSYM paths will be
added as needed).
It also extends tools/valgrind/asan/asan_symbolize.py with a binary name filter
that replaces the hashes with the corresponding file names in the product
directory.
BUG=444835
R=earthdok@chromium.org,maruel@chromium.org,csharp@chromium.org
Review URL: https://codereview.chromium.org/859293002
Cr-Commit-Position: refs/heads/master@{#315059}
|
|
|
|
|
|
|
|
|
|
| |
BUG=454828
R=maruel@chromium.org,glider@chromium.org
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/895923002
Cr-Commit-Position: refs/heads/master@{#314587}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 8a7be0714892c0c6360c45d0d602c119873b468e.
We've been seeing a problem with tab_capture_end2end_tests
taking too much time on linux_gpu_triggered_tests (over 1 hour
as opposed to below 30 seconds).
This was traced to wrong command on the isolate server,
as can be seen e.g. with [1] (good) and [2] (bad).
From builder history I was able to narrow down suspect revision range to just
cafcab99f5ea (good) [3] and 8a7be0714892 (bad) [4].
There are only two CLs in that range, https://codereview.chromium.org/841693004
and https://codereview.chromium.org/813363003 . First one is just a histogram
description change, while the latter changes *.isolate files, which is much more
suspect.
[1] https://isolateserver.appspot.com/browse?namespace=default-gzip&hash=13030c2ece3e5467ba858a978c685865181d32a6
[2] https://isolateserver.appspot.com/browse?namespace=default-gzip&hash=104dec9bff0fc701eac105a80d7d64be5b43b033
[3] http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/97223
[4] http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/97224
TBR=spang
BUG=440882
Review URL: https://codereview.chromium.org/843713002
Cr-Commit-Position: refs/heads/master@{#310464}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't need a virtual X server for ozone testing, and it is causing
problems running the tests with swarming. This changes all isolate files
to only run Xvfb if use_x11==1 is set in GYP_DEFINES, and merges ozone
with Windows & Mac (none of which need to run their own display server).
BUG=440882
TEST=isolate.py run -s out_ozone/Debug/<various>
TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/813363003
Cr-Commit-Position: refs/heads/master@{#310434}
|
|
|
|
|
|
|
|
|
| |
R=sebmarchand@chromium.org
BUG=
Review URL: https://codereview.chromium.org/776543003
Cr-Commit-Position: refs/heads/master@{#306461}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Disable 4996 (deprecated functions in 8.1, these don't help us because we have to run on old OSs anyway)
- Simplify Bluetooth LE header hacks (these headers are buggy in 8.0 and 8.1 SDKs, but less buggy in 8.1)
- Revert attempt to centralize toolchain hashes as it didn't work well, and made it hard to roll anyway (see 400830).
- Instead of basing C4702 (unreachable code) on Pro vs. Express, check whether it's actually disabled in the xtree header
- Remove automatic calling of Express toolchain setup script. It hasn't worked well since post VS2013 RTM because of being distributed as .msp files, and the new Community edition is relatively easy to install so can subsume that usage (that being the motivation for the 4702 change above)
- goma package for u4 is pushed
- ANGLE is switched to load d3dcompiler_47 and build against 8.1 sdk, roll included here.
Xrefs:
- https://codereview.chromium.org/719343004/
- https://chromium-review.googlesource.com/#/c/229616/
- b2/18365241
- https://codereview.chromium.org/733563003/
- https://codereview.chromium.org/732673002/
- https://codereview.chromium.org/729453004/
- https://chromereviews.googleplex.com/120597013/
BUG=311488,432748,400830
Review URL: https://codereview.chromium.org/720033003
Cr-Commit-Position: refs/heads/master@{#304329}
|
|
|
|
|
|
|
|
|
|
|
|
| |
files as opposed to being statically linked to the binary.
This is not currently supported on any architecture.
BUG=421063
Review URL: https://codereview.chromium.org/594603003
Cr-Commit-Position: refs/heads/master@{#301595}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This revisits focus handling logic relating to Flash fullscreen in
WebContentsImpl. Before this change, calls to WebContentsImpl::Focus()
would directly call RenderWidgetHostView::Focus(), but this prevented
WebContentsView and its delegate from "shadowing" these focus changes in
the browser UI. In other words, on Windows/Linux/CrOS, the focus state
for widgets in the ui::views toolkit were not necessarily synchronized
with the render widget's focus state (see bug for details).
90% of this change adds regression testing for everything described
above. The tests run a simulated fullscreened Flash widget, and then
invoke user keyboard and mouse actions on the browser UI to confirm both
the Flash widget and ui::views are in agreement and respond correctly to
focus changes; also, including focus store/restore when switching tabs.
BUG=403641
TEST=Repro steps in bug 403641; and also that focus remains with the omnibox or tab contents when switching back and forth to other tabs. New automated interactive_ui_tests.
Review URL: https://codereview.chromium.org/670653005
Cr-Commit-Position: refs/heads/master@{#301269}
|
|
|
|
|
|
|
|
|
|
|
| |
wow_helper.exe is needed by the sandbox.
BUG=414808
TBR=maruel@chromium.org
Review URL: https://codereview.chromium.org/667513002
Cr-Commit-Position: refs/heads/master@{#300185}
|
|
|
|
|
|
|
|
|
| |
BUG=414808
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/638183002
Cr-Commit-Position: refs/heads/master@{#298803}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Merges the lists when relevant. This simplify the management significantly.
Remove the .isolate from the '*_run' target 'includes' section.
TBR=vadimsh@chromium.org
BUG=swarming:148
Review URL: https://codereview.chromium.org/614923005
Cr-Commit-Position: refs/heads/master@{#297633}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sandbox when it's set.
This copies the logic from tools/build/scripts/slave/runtest.py in swarming.
I changed test_env.py so that it sets CHROME_DEVEL_SANDBOX to be an empty string, instead of unsetting it. The latter doesn't work as Chrome triggers checks in content/browser/browser_main_loop.cc. This is what runtest.py does.
BUG=414808,336218
Review URL: https://codereview.chromium.org/605063004
Cr-Commit-Position: refs/heads/master@{#297330}
|
|
|
|
|
|
|
|
|
| |
BUG=414808
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/601283005
Cr-Commit-Position: refs/heads/master@{#296800}
|
|
|
|
|
|
|
|
|
|
|
| |
LoggedInSpokenFeedbackTest.AddBookmark pass.
BUG=414808
TBR=dmazzoni@chromium.org
Review URL: https://codereview.chromium.org/607543002
Cr-Commit-Position: refs/heads/master@{#296708}
|
|
|
|
|
|
|
|
|
|
|
| |
LoggedInSpokenFeedbackTest.AddBookmark pass.
BUG=414808
TBR=dmazzoni@chromium.org
Review URL: https://codereview.chromium.org/597283004
Cr-Commit-Position: refs/heads/master@{#296669}
|
|
|
|
|
|
|
|
|
| |
BUG=414808
TBR=phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/599863003
Cr-Commit-Position: refs/heads/master@{#296590}
|
|
|
|
|
|
|
|
|
|
| |
BUG=414808
R=scottmg@chromium.org
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/589633002
Cr-Commit-Position: refs/heads/master@{#295754}
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=405074
R=scottmg@chromium.org
TBR=brettw, davidben
Review URL: https://codereview.chromium.org/468773003
Cr-Commit-Position: refs/heads/master@{#290612}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change links the trusted plugin into the renderer, making it easier for
the trusted plugin to use libraries in Chromium. This removes the
ppGoogleNaClPlugin loadable module file on various platforms.
This is part of a larger effort to remove the "trusted plugin" used to
bootstrap NaCl plugins.
It introduces an "internal_module" interface for setting the value returned by
pp::Module::Get(). This is so that both the trusted plugin and the remoting
plugin can be linked into the renderer. However, I believe this is safe because
the trusted plugin runs in-process and the remoting plugin runs out-of-process.
BUG=394497
R=dmichael@chromium.org, mseaborn@chromium.org, phajdan.jr@chromium.org, thestig@chromium.org, wez@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287071
Review URL: https://codereview.chromium.org/397243004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The reverted change broke the ChromeOS builder, which depends on the loadable
module file existing. Argh.
This reverts commit b0b91c06bc2ed6afc0611f00d68f72b19dd06d26.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change links the trusted plugin into the renderer, making it easier for
the trusted plugin to use libraries in Chromium. This removes the
ppGoogleNaClPlugin loadable module file on various platforms.
This is part of a larger effort to remove the "trusted plugin" used to
bootstrap NaCl plugins.
It introduces an "internal_module" interface for setting the value returned by
pp::Module::Get(). This is so that both the trusted plugin and the remoting
plugin can be linked into the renderer. However, I believe this is safe because
the trusted plugin runs in-process and the remoting plugin runs out-of-process.
BUG=394497
R=dmichael@chromium.org, mseaborn@chromium.org, phajdan.jr@chromium.org, thestig@chromium.org, wez@chromium.org
Review URL: https://codereview.chromium.org/397243004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/419973006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/216443005/)
Reason for revert:
Breaking Mac 10.6 release testers. (no idea why, but it is)
Original issue's description:
> Reapply "Media Galleries API Metadata: Image metadata"
>
> Original patch (also PS1) https://codereview.chromium.org/191583002
>
> CQ can't catch the breakages of this patch.
>
> TBR=
> BUG=318450
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261864
TBR=ccameron@chromium.org,thestig@chromium.org,grt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=318450
Review URL: https://codereview.chromium.org/225023014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original patch (also PS1) https://codereview.chromium.org/191583002
CQ can't catch the breakages of this patch.
TBR=
BUG=318450
Review URL: https://codereview.chromium.org/216443005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This tool will ultimately process the .ninja files, in the meantime it archives
all the DLLs. It's cheezy but this will unblock the component build short term.
This is very crude but this will get folks going. This means once it's done, we
can remove all the .isolate representing the dynamic libraries.
Remove swarming_client/ as a dependency in the .isolate files, it's not needed
anymore.
R=vadimsh@chromium.org
BUG=333473
Review URL: https://codereview.chromium.org/196283016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Media Galleries API Metadata: Image metadata
>
> Enables libexif and uses it to parse some image tags into the GetMetadata call.
>
> BUG=318450
>
> Review URL: https://codereview.chromium.org/191583002
TBR=tommycli@chromium.org
Review URL: https://codereview.chromium.org/217233005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Enables libexif and uses it to parse some image tags into the GetMetadata call.
BUG=318450
Review URL: https://codereview.chromium.org/191583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We've figured out a way to make things work without a shared library, so libmojo_system is no more.
BUG=none
TEST=none
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/215153007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=353602
TEST=none
R=csharp@chromium.org, mmoss@google.com, thestig@chromium.org, mmoss@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258062
Review URL: https://codereview.chromium.org/203963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=353602
TEST=none
R=bradnelson@chromium.org, csharp@chromium.org, grt@chromium.org
Review URL: https://codereview.chromium.org/204023002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Turns on use_mojo=1 for linux.
>
> BUG=353602
> TEST=none
> R=csharp@chromium.org, mmoss@google.com, thestig@chromium.org, mmoss@chromium.org
>
> Review URL: https://codereview.chromium.org/203963003
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/200033005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=353602
TEST=none
R=csharp@chromium.org, mmoss@google.com, thestig@chromium.org, mmoss@chromium.org
Review URL: https://codereview.chromium.org/203963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258062 0039d316-1c4b-4281-b951-d872f2087c98
|