summaryrefslogtreecommitdiffstats
path: root/chrome/nacl
Commit message (Collapse)AuthorAgeFilesLines
* Convert LOG(INFO) to VLOG(1) - chrome/nacl/.pkasting@chromium.org2010-10-203-18/+17
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3939001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63256 0039d316-1c4b-4281-b951-d872f2087c98
* nacl: disable seccomp initialization in NaClMain()evan@chromium.org2010-10-191-8/+10
| | | | | | | | | | | | | It fails when seccomp is available; it appears like the code was just copied from RendererMain without it working yet. BUG=59423 TEST=nacl tests still pass when seccomp is on by default (because this disables seccomp for nacl) Review URL: http://codereview.chromium.org/3845008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63063 0039d316-1c4b-4281-b951-d872f2087c98
* Update the interface between Chrome and sel_main_chrome. Added a debug flag ↵noelallen@google.com2010-09-283-11/+13
| | | | | | | | | | | | | | | in the nacl_thread class. Moved static LaunchNaClChildProcess inline since we need access to variables from the single caller. BUG=http://code.google.com/p/nativeclient/issues/detail?id=728 TEST=none Test to be added to NaCl integration bots. Review URL: http://codereview.chromium.org/3527001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60864 0039d316-1c4b-4281-b951-d872f2087c98
* Support for building Chrome using Clang.evan@chromium.org2010-09-181-1/+2
| | | | | | | | | | | | | | | | To build, set the clang=1 gyp_define. This patch is the culmination of many months of effort and many patches. It contains the minimal changes to Chrome that are Clang-specific. With this, I can build the "chrome" target. Once this patch is in, we can incrementally fix bits of Chrome and various tests and remove the Clang-specific workarounds. Review URL: http://codereview.chromium.org/522020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59882 0039d316-1c4b-4281-b951-d872f2087c98
* nacl: Use a scoped_array rather than a bare pointer.evan@chromium.org2010-09-171-3/+3
| | | | | | | | | | | The bug was that we had a new[] without a matching delete[], using a scoped_array fixes this and simplifies the code. TEST=compiles Review URL: http://codereview.chromium.org/3410009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59856 0039d316-1c4b-4281-b951-d872f2087c98
* Pull seccomp-sandbox in via DEPS rather than using an in-tree copy mseaborn@chromium.org2010-09-011-1/+1
| | | | | | | | | | | | | | | | This means changes to the sandbox won't have to be committed twice, to both trees. This is a retry of r57921, which was committed with git-svn and failed to remove the "seccomp" directory. This caused problems when trying to "svn checkout" to the same location, and the change was reverted. This time I will use SVN to commit the change. BUG=none TEST=smoke test of running chromium with --enable-seccomp-sandbox Review URL: http://codereview.chromium.org/3225010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58184 0039d316-1c4b-4281-b951-d872f2087c98
* * Fix style issues in nacl_sandbox_test ↵jvoung@google.com2010-08-315-67/+74
| | | | | | | | | | | | | | (http://codereview.chromium.org/1549046/show). * Use base/native_library instead of dlopen, LoadLibrary, etc. * Change error path so that it does not simply fail a CHECK. BUG=none TEST=Manually test success/fail case (force failure by passing -no-sandbox flag). Review URL: http://codereview.chromium.org/3008024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58090 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move some heavy, repeatedly emitted symbols to implementation files.erg@google.com2010-08-302-0/+3
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3162047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57896 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 6)thestig@chromium.org2010-08-191-2/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3093013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56641 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Header cleanup in chrome/common. Part 1.jhawkins@chromium.org2010-08-171-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3106016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56444 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetSwitchValue() from chrome/* where easy.evan@chromium.org2010-08-061-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3057033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55176 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Remove GetSwitchValue() from chrome/* where easy."evan@chromium.org2010-08-041-1/+1
| | | | | | | | This reverts commit r54966. Meant to try it, not commit it, sorry everyone. :( git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54969 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetSwitchValue() from chrome/* where easy.evan@chromium.org2010-08-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/3057033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54966 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/ (part 2)thestig@chromium.org2010-07-311-7/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3066014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54437 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated CommandLine API.evan@chromium.org2010-07-301-2/+3
| | | | | | | | | Cleaned up the final few callers, punting the remaining harder ones to TODOs. Review URL: http://codereview.chromium.org/3043033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54400 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix.evan@chromium.org2010-07-301-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54289 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a bunch of easy AppendSwitchWithValue to *ASCII.evan@chromium.org2010-07-301-4/+4
| | | | | | | | | For this patch, I skipped over any instance where it wasn't a nearly trivial change. Review URL: http://codereview.chromium.org/3069014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54285 0039d316-1c4b-4281-b951-d872f2087c98
* NaCl: Allow setting up multiple sockets for subprocess instead of just onemseaborn@chromium.org2010-07-292-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | Remove the "channel number" parameter from messages, since this is now fixed in the NaCl plugin code in sel_main_chrome.c. Replace pair_ and descriptor_ with sockets_for_renderer_ and sockets_for_sel_ldr_. NaClProcessMsg_Start: Pass an array of FDs instead of one FD. ViewHostMsg_LaunchNaCl: * Add socket count. * Return an array of FDs instead of one FD. Expose this functionality to the NaCl plugin via a new function, "launch_nacl_process_multi_fd". BUG=50626 TEST=nacl_ui_tests Review URL: http://codereview.chromium.org/2832093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54113 0039d316-1c4b-4281-b951-d872f2087c98
* Make NaCl/Chromium startup interface easier to maintainmseaborn@chromium.org2010-07-282-199/+5
| | | | | | | | | | | | | | | | | | Use the new NaClMainForChromium() from the NaCl tree, instead of sel_main.cc in the Chromium tree. Use the new variant of RegisterInternalNaClPlugin() that can receive multiple functions instead of just one. This depends on r2744 from NaCl. BUG=http://code.google.com/p/nativeclient/issues/detail?id=642 BUG=http://code.google.com/p/nativeclient/issues/detail?id=469 TEST=Chromium's nacl_ui_tests Review URL: http://codereview.chromium.org/3039016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53952 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-263-0/+3
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary EXTERN_C_BEGIN and EXTERN_C_ENDgregoryd@google.com2010-07-221-2/+0
| | | | | | | | | BUG=46024 TEST=None Review URL: http://codereview.chromium.org/2969002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53393 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 53333 - Make NaCl/Chromium startup interface easier to maintaindanno@chromium.org2010-07-222-5/+201
| | | | | | | | | | | | | | | | | | | | | Use the new NaClMainForChromium() from the NaCl tree, instead of sel_main.cc in the Chromium tree. Use the new variant of RegisterInternalNaClPlugin() that can receive multiple functions instead of just one. This depends on r2744 from NaCl. BUG=http://code.google.com/p/nativeclient/issues/detail?id=642 BUG=http://code.google.com/p/nativeclient/issues/detail?id=469 TEST=Chromium's nacl_ui_tests Review URL: http://codereview.chromium.org/3039016 TBR=mseaborn@chromium.org Review URL: http://codereview.chromium.org/2832071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53335 0039d316-1c4b-4281-b951-d872f2087c98
* Make NaCl/Chromium startup interface easier to maintainmseaborn@chromium.org2010-07-222-201/+5
| | | | | | | | | | | | | | | | | | Use the new NaClMainForChromium() from the NaCl tree, instead of sel_main.cc in the Chromium tree. Use the new variant of RegisterInternalNaClPlugin() that can receive multiple functions instead of just one. This depends on r2744 from NaCl. BUG=http://code.google.com/p/nativeclient/issues/detail?id=642 BUG=http://code.google.com/p/nativeclient/issues/detail?id=469 TEST=Chromium's nacl_ui_tests Review URL: http://codereview.chromium.org/3039016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53333 0039d316-1c4b-4281-b951-d872f2087c98
* Set up tests to exercise the chrome outersandbox from the nacl loader.jvoung@google.com2010-07-155-34/+280
| | | | | | | | | | | | | | | | | | | It is similar to the renderer sandbox tests in that the test code is separated into a DLL and only loaded based on commandline flags. Currently tests file open, process creation, and connect. This is currently not set up for Linux. To set it up for Linux, we need to be more careful about what tests are expected to pass, and will need to look into zygote process for how to get the test shared lib loaded. BUG=39409 TEST=none Review URL: http://codereview.chromium.org/1549046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52567 0039d316-1c4b-4281-b951-d872f2087c98
* NaCl: Remove call to NaClAppDtor()mseaborn@chromium.org2010-06-091-6/+1
| | | | | | | | | | | | | | | | Calling NaClAppDtor() is unnecessary because the process is about to exit anyway, and it happens only in the error path because NaClAppDtor() is not able to shut down running NaCl threads safely. There is a TODO for its removal in the NaCl tree. This is related to http://codereview.chromium.org/2659002. BUG=http://code.google.com/p/nativeclient/issues/detail?id=560 TEST=nacl_ui_test Review URL: http://codereview.chromium.org/2753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49324 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Chrome threads to use a "Cr" prefix.evan@chromium.org2010-06-091-9/+2
| | | | | | | | | | | Before we carefully used the app (Chrome/Chromium) name, but: 1) these are for internal debugging use only, so why compute this name 2) on Linux the thread ids are limited to 16 characters, and "Chromium" is too long Review URL: http://codereview.chromium.org/2741003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49296 0039d316-1c4b-4281-b951-d872f2087c98
* Remove possible nullptr deref from an unused (with non-null values) variable.nsylvain@chromium.org2010-04-131-3/+1
| | | | | | | | Change by Jan Voung (jvoung@google.com) Review URL: http://codereview.chromium.org/1585033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44393 0039d316-1c4b-4281-b951-d872f2087c98
* Make _ovly_debug_event extern "C" for nacl-gdbnfullagar@google.com2010-03-261-1/+3
| | | | | | Review URL: http://codereview.chromium.org/1378004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42775 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate Chrome sandbox changes with NaCl (add Win64 support)gregoryd@google.com2010-03-241-2/+7
| | | | | | | | | Two significant changes: - Explicitly allow processes to act as servers for named pipes for pipes with chrome.nacl prefix. This worked implicitly on Win32 but doesn't on Win64. - NaCl broker process does not run in the sandbox (by design) Review URL: http://codereview.chromium.org/1098009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42552 0039d316-1c4b-4281-b951-d872f2087c98
* Don't keep a pointer to NaClBrokerHost in NaClBrokerService - use ↵gregoryd@google.com2010-03-171-1/+0
| | | | | | | | | | | | ChildProcessHost::Iterator instead. This change fixes the crash that occured if the browser was closed while the NaCl module was still running (found by nacl_ui_tests). Also make nacl_ui_tests depend on nacl win64 binary (required to run the tests on Win64) BUG=none TEST=nacl_ui_tests Review URL: http://codereview.chromium.org/875005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41804 0039d316-1c4b-4281-b951-d872f2087c98
* Final removal of the bad dependency of chrome/common on chrome/browserphajdan.jr@chromium.org2010-03-101-3/+2
| | | | | | | | | | | Also convert app/gtk_dnd_util.h from a class to a namespace for consistency with added app/gtk_util.h. TEST=none BUG=none Review URL: http://codereview.chromium.org/669268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41177 0039d316-1c4b-4281-b951-d872f2087c98
* Terminate NaCl broker process when no loader processes are runninggregoryd@google.com2010-03-082-1/+9
| | | | | | | | | | BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40744 Review URL: http://codereview.chromium.org/669019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40941 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 40744 - Terminate NaCl broker process when no loader processes are ↵gregoryd@google.com2010-03-052-9/+1
| | | | | | | | | | | | | running BUG=none TEST=none Review URL: http://codereview.chromium.org/669019 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/668165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40746 0039d316-1c4b-4281-b951-d872f2087c98
* Terminate NaCl broker process when no loader processes are runninggregoryd@google.com2010-03-052-1/+9
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/669019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40744 0039d316-1c4b-4281-b951-d872f2087c98
* 64-bit Windows support for NaCl: update NaCl revision in Chrome, enable the ↵gregoryd@google.com2010-02-251-5/+0
| | | | | | | | 64-bit loader code and fix some build issues. Review URL: http://codereview.chromium.org/651065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40062 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bugs in the broker that cause the browser to crash when trying to unload ↵gregoryd@google.com2010-02-221-1/+1
| | | | | | | | a NaCl module or to load another one. Review URL: http://codereview.chromium.org/650088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39639 0039d316-1c4b-4281-b951-d872f2087c98
* Enabled in-process NaCl plugin on Linux. Turns out it's remarkably similar ↵cbiffle@google.com2010-02-031-2/+2
| | | | | | | | | | to OS X support, so this CL simply tweaks the #ifdefs. BUG=32602 TEST=none Review URL: http://codereview.chromium.org/569018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37993 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the broker process that launches NaCl loader processes on 64-bit ↵gregoryd@google.com2010-02-015-5/+175
| | | | | | | | | | | | Windows systems. BUG=28176 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37578 Review URL: http://codereview.chromium.org/542030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37720 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 37578 - Implement the broker process that launches NaCl loader ↵gregoryd@google.com2010-01-305-175/+5
| | | | | | | | | | | | processes on 64bit Windows systems. BUG=28176 TEST=none Review URL: http://codereview.chromium.org/542030 TBR=gregoryd@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37580 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the broker process that launches NaCl loader processes on 64-bit ↵gregoryd@google.com2010-01-305-5/+175
| | | | | | | | | | Windows systems. BUG=28176 TEST=none Review URL: http://codereview.chromium.org/542030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37578 0039d316-1c4b-4281-b951-d872f2087c98
* Make NaCl run in Chrome on the Mac.dspringer@google.com2010-01-271-14/+39
| | | | | | | | | | | | Note: this is a *slight* rework of CL 555082, which accidentally broke the build. That CL was reviewed and LGTM'd byt sehr@ and bsy@. BUG=none TEST=none Review URL: http://codereview.chromium.org/551172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37279 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 37254 - Make NaCl run in Chrome on the Mac.viettrungluu@chromium.org2010-01-271-39/+14
| | | | | | | | | | | | | | | NOTE: This uses some assembly that is NOT SECURE. This CL is for development ONLY. BUG=none TEST=none Review URL: http://codereview.chromium.org/555082 TBR=dspringer@google.com Review URL: http://codereview.chromium.org/548163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37255 0039d316-1c4b-4281-b951-d872f2087c98
* Make NaCl run in Chrome on the Mac.dspringer@google.com2010-01-271-14/+39
| | | | | | | | | | | | NOTE: This uses some assembly that is NOT SECURE. This CL is for development ONLY. BUG=none TEST=none Review URL: http://codereview.chromium.org/555082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37254 0039d316-1c4b-4281-b951-d872f2087c98
* Split more targets from chrome.gyp to add support for building Native Client ↵gregoryd@google.com2009-12-281-0/+9
| | | | | | | | | | | | | | | | for 64-bit Windows. This CL is required for supporting Native Client on 64-bit Windows. On Win64 we will use a 64-bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32-bit Chrome binaries. For the targets that are required for both 32-bit and 64-bit builds, this CL moves the shared parts of the target definitions into target-specific gypi files (such as base.gypi). New 64-bit only targets are added. Since we would like to port as few code as possible at this point, some 64-bit targets include less source files or less dependencies than the original 32-bit targets. These targets will have nacl_win64 in their name - to emphasize that they should be used for NaCl only. Some 64-bit targets are identical to the 32-bit targets in everything except for the target platform - these will have only win64 in their name. TEST=none BUG=28176 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35237 Review URL: http://codereview.chromium.org/384068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35305 0039d316-1c4b-4281-b951-d872f2087c98
* revert r35237 since it causes Mac unit tests to fail.jeremy@chromium.org2009-12-241-9/+0
| | | | | | | | | | "Split more targets from chrome.gyp to add support for building Native Client for 64-bit Windows. " BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/520006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35259 0039d316-1c4b-4281-b951-d872f2087c98
* Split more targets from chrome.gyp to add support for building Native Client ↵gregoryd@google.com2009-12-231-0/+9
| | | | | | | | | | | | | | for 64-bit Windows. This CL is required for supporting Native Client on 64-bit Windows. On Win64 we will use a 64-bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32-bit Chrome binaries. For the targets that are required for both 32-bit and 64-bit builds, this CL moves the shared parts of the target definitions into target-specific gypi files (such as base.gypi). New 64-bit only targets are added. Since we would like to port as few code as possible at this point, some 64-bit targets include less source files or less dependencies than the original 32-bit targets. These targets will have nacl_win64 in their name - to emphasize that they should be used for NaCl only. Some 64-bit targets are identical to the 32-bit targets in everything except for the target platform - these will have only win64 in their name. TEST=none BUG=28176 Review URL: http://codereview.chromium.org/384068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35237 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35230 - Split more targets from chrome.gyp to add support for ↵gregoryd@google.com2009-12-231-9/+0
| | | | | | | | | | | | | | | | | | building Native Client for 64bit Windows. This CL is required for supporting Native Client on 64bit Windows. On Win64 we will use a 64bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32bit Chrome binaries. For the targets that are required for both 32bit and 64bit builds, this CL moves the shared parts of the target definitions into targetspecific gypi files (such as base.gypi). New 64bit only targets are added. Since we would like to port as few code as possible at this point, some 64bit targets include less source files or less dependencies than the original 32bit targets. These targets will have nacl_win64 in their name to emphasize that they should be used for NaCl only. Some 64bit targets are identical to the 32bit targets in everything except for the target platform these will have only win64 in their name. TEST=none BUG=28176 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34983 Review URL: http://codereview.chromium.org/384068 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/516013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35232 0039d316-1c4b-4281-b951-d872f2087c98
* Split more targets from chrome.gyp to add support for building Native Client ↵gregoryd@google.com2009-12-231-0/+9
| | | | | | | | | | | | | | | for 64-bit Windows. This CL is required for supporting Native Client on 64-bit Windows. On Win64 we will use a 64-bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32-bit Chrome binaries. For the targets that are required for both 32-bit and 64-bit builds, this CL moves the shared parts of the target definitions into target-specific gypi files (such as base.gypi). New 64-bit only targets are added. Since we would like to port as few code as possible at this point, some 64-bit targets include less source files or less dependencies than the original 32-bit targets. These targets will have nacl_win64 in their name - to emphasize that they should be used for NaCl only. Some 64-bit targets are identical to the 32-bit targets in everything except for the target platform - these will have only win64 in their name. TEST=none BUG=28176 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34983 Review URL: http://codereview.chromium.org/384068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35230 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34983 - Split more targets from chrome.gyp to add support for ↵slightlyoff@chromium.org2009-12-181-9/+0
| | | | | | | | | | | | | | | | | building Native Client for 64bit Windows. This CL is required for supporting Native Client on 64bit Windows. On Win64 we will use a 64bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32bit Chrome binaries. For the targets that are required for both 32bit and 64bit builds, this CL moves the shared parts of the target definitions into targetspecific gypi files (such as base.gypi). New 64bit only targets are added. Since we would like to port as few code as possible at this point, some 64bit targets include less source files or less dependencies than the original 32bit targets. These targets will have nacl_win64 in their name to emphasize that they should be used for NaCl only. Some 64bit targets are identical to the 32bit targets in everything except for the target platform these will have only win64 in their name. TEST=none BUG=28176 Review URL: http://codereview.chromium.org/384068 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/501125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34990 0039d316-1c4b-4281-b951-d872f2087c98
* Split more targets from chrome.gyp to add support for building Native Client ↵gregoryd@google.com2009-12-181-0/+9
| | | | | | | | | | | | | for 64-bit Windows. This CL is required for supporting Native Client on 64-bit Windows. On Win64 we will use a 64-bit executable to load NaCl modules. Since we have only one version of Chrome on Windows, this executable has to be built together with 32-bit Chrome binaries. For the targets that are required for both 32-bit and 64-bit builds, this CL moves the shared parts of the target definitions into target-specific gypi files (such as base.gypi). New 64-bit only targets are added. Since we would like to port as few code as possible at this point, some 64-bit targets include less source files or less dependencies than the original 32-bit targets. These targets will have nacl_win64 in their name - to emphasize that they should be used for NaCl only. Some 64-bit targets are identical to the 32-bit targets in everything except for the target platform - these will have only win64 in their name. TEST=none BUG=28176 Review URL: http://codereview.chromium.org/384068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34983 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-28 10:25:28 +0000