| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
For Chrome Endure, use the memory benchmarking V8 extension instead.
For the old ChromeDriver, just mark the messages as deprecated on the client side. I'll remove all the old ChromeDriver code later. I want to keep it here since we release ChromeDriver from HEAD, and we might need to do critical fixes for Chrome 28 and below still.
BUG=240580
Review URL: https://chromiumcodereview.appspot.com/14977013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch needs to be landed at the same time as
https://chromiumcodereview.appspot.com/14703004/
Since WebFrame now uses the non-shifted(ranges [minPos, maxPos]) scroll offset.
BUG=232063
TEST=AutomationRendererHelperTest.RTLSnapshot
R=darin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15006004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Waiting for Blink to roll and we'll land https://codereview.chromium.org/15006004/
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/14660023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/14945002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193020
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e59558b78e8c6a1b0bd916a724724b638c3c91b6.
Revert "Fix build after r193020."
This reverts commit 558a35897f6b3ffbcaefde927c1f150b815d140a.
Revert "Really fix build after r193020."
This reverts commit e3748a79b523a8d365d4a33ef986eebb4186fa78.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.
BUG=none
Review URL: https://codereview.chromium.org/13145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No changes in behavior. This is a trivial class that has only one actual use outside
of unit tests.
The reason for the removal is specific to Windows component builds and somewhat
complicated. The pattern of exporting a class that inherits a non exported template
causes the template to be implicitly exported on Windows. That might cause multiple
definition linker errors for users of the template in other DLLs. For more info refer
to this blog post:
http://www.codesynthesis.com/~boris/blog/2010/01/18/dll-export-cxx-templates/
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12972002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=175186
TBR=brettw@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12378016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
string_number_conversions in some chrome subdirectories.
Review URL: https://codereview.chromium.org/12218065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Platform directory
Review URL: https://chromiumcodereview.appspot.com/11833008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class behaves like scoped_refptr and wraps the raw SkRefCnt subclass
so that we don't have to call ref() and unref() directly on the pointers.
Tested by:
unit_tests:RefPtrTest.ReferenceCounting
unit_tests:RefPtrTest.Construct
unit_tests:RefPtrTest.DeclareAndAssign
unit_tests:RefPtrTest.Assign
unit_tests:RefPtrTest.Upcast
BUG=163454
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11418217
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
actually extend
SkCanvas in any way, other than provide a host of constructors (and delayed constructors
in the form of 'initialize' methods).
These late initializers are a problem, as SkCanvas is deprecating its setDevice() call,
moving to model where the backingstore/device for the canvas must be created before the
canvas is created. This is necessary to allow skia to continue to extend SkCanvas for
its backends (e.g. GPU, PDF, Picture, Pipe, etc.).
The practical change in this CL is to make PlatformCanvas just a typedef for SkCanvas,
and change the call-sites that want to call initialize() to instead create the canvas
using one of the provided Factory functions (e.g. CreatePlatformCanvas). The modifier
Platform is maintained, to document that this canvas may be backed by platform-specific
pixels (e.g. allocated by GDI or cairo).
Review URL: https://codereview.chromium.org/11138024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10876004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For context see this thread:
https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II
TBR=thakis,pkasting,jam
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the new name in preparation for deleting the backwards-compatible typedef.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10532162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This way we can enforce that internal content headers don't leak to embedders.
I moved the SendKeyEvent from RenderViewTest to RenderViewImplTest, which was the only class it was used in. This way we don't have to expose mock_keyboard.h as well.
BUG=98716
TBR=phajdan.jr
Review URL: https://chromiumcodereview.appspot.com/10497013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
renderer.
This is only the browser-side implementation. In this patch we send some scripts from the client which the renderer evaluates to determine where to move or click the mouse. I tried to keep the renderer code as small and as simple as possible. I plan on eventually removing the script-based location finding in favor of some scrollIntoView-like method in WebKit. Currently scrollIntoView does not work. See http://code.google.com/p/chromium/issues/detail?id=73953.
BUG=chromedriver:22,chromedriver:36,chromedriver:44
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10384023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=123752
TEST=none
Review URL: http://codereview.chromium.org/10035055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
interstitial pages which are in content, and also browser tests in content.
In followup changes, I'll make interstitial pages not have to derive from a concrete class, and instead implement some sort of delegate interface like we did with WebUI.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9310094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=darin
Review URL: http://codereview.chromium.org/8784004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We try not to include bind.h in header files for compilation speed.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/8680004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't inherit from content::RenderViewObserver, instead just
create it on the fly when needed in tests.
BUG=69370, 66371, 63022
TEST=none
Review URL: http://codereview.chromium.org/8416024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
initializers) - Fix test snapshotting on linux by creating a separate automation path for
snapshots outside of the thumbnail generator.
BUG=69370,66371,63022
TEST=none
Review URL: http://codereview.chromium.org/8294030
TBR=kkania@chromium.org
Review URL: http://codereview.chromium.org/8416022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
snapshots outside of the thumbnail generator.
BUG=69370,66371,63022
TEST=none
Review URL: http://codereview.chromium.org/8294030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
to the interface. In a future change I'll rename RenderView to RenderViewImpl.
BUG=98716
Review URL: http://codereview.chromium.org/8201029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=darin@chromium.org
BUG=92044
TEST=
Review URL: http://codereview.chromium.org/8165009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content\public\renderer and put them in the content namespace.
BUG=98716
Review URL: http://codereview.chromium.org/8124001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Remove JsOnlyV8Extensions since we can just create instances of ChromeV8Extension where necessary.
Instead of using made-up names like "chrome/extensionprocessbindings", standardize on the path to the file as the name of an extension.
Review URL: http://codereview.chromium.org/8100014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DomAutomationV8Extension header.
BUG=None
TEST=None
R=kkania@chromium.org
Review URL: http://codereview.chromium.org/7809012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/7767011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeViewMsg_, ChromeViewHostMsg, etc.
This makes it easier to identify which messages are specific to content and chrome.
This is a preparation CL for bug http://code.google.com/p/chromium/issues/detail?id=87335 which
requires IPC's to not span across content and chrome. When IPC's cross these boundaries they need
to be handled as API calls.
BUG=87335
Review URL: http://codereview.chromium.org/7631063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
necessary because there were other copies of this data
already in ExtensionDispatcher.
Moved the remaining required data to ExtensionDispatcher
because it simplifies implementation (no need for statics
since ExtensionDispatcher is already 1-per-renderer).
BUG=70516
Review URL: http://codereview.chromium.org/6880169
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
content now.
TBR=avi
Review URL: http://codereview.chromium.org/6875018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The RenderViewObserver currently sends two messages to the browser related
to tracking client redirects, which is needed for determining whether to
wait for a future navigation.
This is particularly needed to wait correctly in chromedriver for form
submissions and javascript redirects. However, timed redirects still need
to be considered.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6676136
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a small step towards making all singleton classes use the Singleton<T> pattern within their code and not expect the callers to know about it.
This CL includes all files except those under chrome/browser, chrome/net, chrome/service and third_party/WebKit (these will be done in future CLs).
Suggested files to focus for reviewers:
- joi@ for files under src/ceee
- tommi@ for files under src/chrome_frame
- maruel@ for the rest of the files.
BUG=65298
TEST=all existing tests should continue to pass.
Review URL: http://codereview.chromium.org/5581008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WARN_UNUSED_RESULT to make it less likely that callers ignore failures.
BUG=57216
TEST=tests should still run
Review URL: http://codereview.chromium.org/3569005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Reivew url: http://codereview.chromium.org/660046
Review URL: http://codereview.chromium.org/1051005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/660046
TBR=kkania@chromium.org
Review URL: http://codereview.chromium.org/971004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/660046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41789 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/385023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This splits the ipc code from the common project. The 'common' project pulls in
all of webkit, the v8 bindings, skia, googleurl, and a number of other projects
which makes it very difficult to deal with especially for external projects
wanting just to use some of Chromium's infrastructure. This puts the ipc code
into its top-level ipc/ directory with a dependency only on base. The common
project depends on the new ipc/ipc.gyp:ipc target so that all projects currently
pulling common in to get the IPC code still have it available. This mostly
follows agl's pre-gyp attempt to do this which was r13062.
Known issues:
- Currently a number of projects depend on chrome/chrome.gyp:common in order to
use the IPC infrastructure. Rather than fixing all of these dependencies I have
made common depend on ipc/ipc.gyp:ipc and added "ipc" to the include_rules
section of DEPS so that checkdeps.py doesn't complain. Over time projects that
need IPC should depend on the IPC project themselves and dependencies on common
removed, although I don't think many projects that need IPC will be able to get
away without common currently.
- ipc/ipc_message_macros.h still has #include "chrome/common/..." inside of a
ipc/ should not refer to files in chrome/... now. I'm not sure how to resolve
this since it's really an IDE bug
- the named pipe name (windows+linux) and the logging event name (all) + env
variable (posix) refer explicitly to 'Chrome' which somewhat hurts the illusion
of ipc/ being an independent library. I think this should be examined in a
subsequent, much smaller patch.
- I've eliminated the IPC.SendMsgCount counter since it was implemented in a way
to create a dependency from ipc/ to chrome/common/chrome_counters. This is the
same approach that r13062 took.
http://codereview.chromium.org/155905
(Patch from James Robinson)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99177
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit r13062 which, unsurprisingly, broke the build.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
(No review URL: Rietvelt couldn't cope)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Normalize end of file newlines in chrome/. All files end in a single newline.
Review URL: http://codereview.chromium.org/42015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
message sender, i.e. to send replies to javascript requests issued by the browser.
The DOM automation controller object is bound to the frame in the WindowObjectcleared code path.The current implementation maintains the message sender object as a static pointer, which causes a crash if the RenderView instance goes out of scope.
This can be reproduced with a page which causes a popup window to show up and close. If we attempt to use the Dom Automation controller instance bound to the original Renderview, which is still valid, we crash.
The fix is to maintain the message sender as a member variable. The lifetime of the Dom Automation controller instance depends on the RenderView lifetime anyway as it is a member variable. This mimics the other CppBindings like the external host bindings, etc.
Added an automation test to test this case. I verified that the test crashes without this fix.
This fixes bug http://code.google.com/p/chromium/issues/detail?id=3941
Bug=3941
Review URL: http://codereview.chromium.org/21441
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Bug=6535
Review URL: http://codereview.chromium.org/20009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/15071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7340 0039d316-1c4b-4281-b951-d872f2087c98
|