summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/extensions
Commit message (Collapse)AuthorAgeFilesLines
* Fix for flow control in terminalPrivate APItbarzic2016-01-081-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes problem where terminalPrivate API floods IPC channel by sending crosh extension too many onProcessOutput events in short amount of time. The API uses chromeos/process_proxy/process_output_watcher to observe stdout of terminal process. Whenever some data is detected a chrome.terminalPrivate.onProcessOutput event is dispatched to crosh extension with the observed data. This may overwhelm communication channel to the extension when there is too much output from the process. To fix this the following is done: - When process_output_watcher sends some data, further process output observation/reporting is paused until the sent data is acknowledged by the receiver. - Callback used by process_output_watcher is passed a closure that unpauses the process_output_watcher. The callback is cached before sending chrome.terminalPrivate.onProcessOutput event. - chrome.terminalPrivate.ackOutput(int terminalId) is introduced that invokes cached (if it exists) the closure for the terminal process identified by terminalId. - When chrome.terminalPrivate.onProcessOutput is dispatched to the extension code, terminalPrivate.ackOutput is called for the target terminal. This is done internally in the APIs custom bindings (from the extension renderer process). - To ensure process output is acknowledged at most once, terminalPrivate.onProcessOutput is internally passed target tab ID as an argument. The tab ID is passed back as an argument of ackOutput, and the method is ignored if called from web contents with different tab ID. The tab ID is stripped from the argument list before dispatching onProcessOutput event to the extension. BUG=527475, 398901 Review URL: https://codereview.chromium.org/1455793003 Cr-Commit-Position: refs/heads/master@{#368277}
* Use FrameTreeNode ID as frameId in extension APIsrob2016-01-061-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use FrameTreeNode IDs instead of RenderFrame routing IDs as "frame id" in the extension APIs (webNavigation, webRequest, extension messaging) because FTN IDs are globally unique, and RFH IDs are not. This extends the public content API with: - RenderFrameHost::FromFrameTreeNodeId - RenderFrameHost::GetFrameTreeNodeId - WebContents::FindFrameByFrameTreeNodeId The extension APIs are modified as follows: - webRequest: * Frame IDs may be unavailable after frame removal (crbug.com/572930). * Blocking webRequest handlers may be slower than before due to an extra IO->UI->IO hop to determine the frameId (but this happens only once per frame load). - webNavigation: * processId is no longer required in chrome.webNavigation.getFrame, but marked as optional (deprecated) to make sure that the API is backwards-compatible. * frameId is constant across navigations. - Extension messaging (chrome.runtime.connect and friends): * Small change for extension developers in the following scenario: 1. Open port to tab. 2. Accept the port by listening to onConnect *in a child frame*. 3. Unload the document in the frame. Old behavior: onDisconnect was not triggered in the background until the tab was reloaded or closed. New behavior: onDisconnect is called. * Extension messaging works correctly in out-of-process frames. * Move port lifetime management from renderer to browser. * Tie port lifetime to frames instead of processes. * Only notify frames in renderers if they have accepted the port. * Remove obsolete work-around for crbug.com/520303. * Unify open/close/postMessage logic in ChromeExtensionMessageFilter (crbug.com/394383#c7) - The extension frameId logic is no longer scattered over several files, but resides in a single class (ExtensionApiFrameIdMap). - IDs are now guaranteed to be -1 or higher (before this, -2 was occasionally seen). Depends on https://codereview.chromium.org/1413853005/ BUG=432875 TEST=browser_tests --gtest_filter=\ ExtensionWebRequestApiTest.*:\ WebNavigationApiTest.*:\ ExtensionApiTest.Messaging*:\ ExternallyConnectableMessagingTest.*:\ ExternallyConnectableMessagingWithTlsChannelIdTest.* Review URL: https://codereview.chromium.org/1413543005 Cr-Commit-Position: refs/heads/master@{#367914}
* Convert Pass()→std::move() in //chromedcheng2015-12-274-9/+14
| | | | | | | | | | | | ☃ BUG=557422 R=avi@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1551503002 Cr-Commit-Position: refs/heads/master@{#366918}
* Switch to standard integer types in chrome/.avi2015-12-2622-15/+46
| | | | | | | | | | BUG=138542 TBR=thakis@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1548153002 Cr-Commit-Position: refs/heads/master@{#366893}
* Switch to standard integer types in ui/base/.avi2015-12-231-0/+1
| | | | | | | | | BUG=138542 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/1547893002 Cr-Commit-Position: refs/heads/master@{#366729}
* Use rvalue reference instead of extensions::DictionaryBuilder::pass()limasdf2015-12-191-6/+7
| | | | | | | | | | | C++ 11 enables rvalue reference with std::move() so that removing DictionaryBuilder::Pass(). BUG=563649 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1532193003 Cr-Commit-Position: refs/heads/master@{#366280}
* cast: Support for low-latency interactive modeisheriff2015-12-091-0/+7
| | | | | | | | | | | | | | | | | | | | | Add support to detect the presence of user interaction while playing non-animated content and then adapt the target playout latency accordingly. We leverage the detection of animation content added for ZeroConfig and switch to a low-latency target playout mode when there is sufficient user interaction and the content being played is not detected to be animation content. The goal is to address clear interactive user cases (slides presentation etc.,) while keeping the impact on animated content watching experience minimal. Testing involved switching between static and animated content while interacting and using a UDP proxy to observe the target playout time reduce during interaction with low-frame rate content and observe it go up once the sender observes a drop while playing animated content. BUG=405339 Review URL: https://codereview.chromium.org/1484403002 Cr-Commit-Position: refs/heads/master@{#364160}
* Fix CrossesExtensionExtents to handle hosted apps with --isolate-extensions.alexmos2015-12-091-12/+6
| | | | | | | | | | | | | | | | | | | | | | | Currently, when determining whether a process swap is necessary for a new window that was just window.open'ed, CrossesExtensionExtents checks for --site-per-process and --isolate-extensions flags to determine whether to look at an opener or the opener's top frame for the source url. This logic is busted with --isolate-extensions and hosted apps, since --isolate-extensions doesn't isolate hosted apps. This caused AppApiTest.OpenAppFromIframe to fail for --isolate-extensions. This CL changes CrossesExtensionExtents to instead check the opener's local frame root for this scenario, which should work for all current and future Site Isolation modes. To facilitate this, the local frame root is now exposed from WebLocalFrame. BUG=532666 TEST=AppApiTest.OpenAppFromIframe for --isolate-extensions. Review URL: https://codereview.chromium.org/1511003002 Cr-Commit-Position: refs/heads/master@{#364147}
* Use rvalue reference instead of extensions::ListBuilder::Pass()limasdf2015-12-091-4/+7
| | | | | | | | | | | | C++ 11 enables rvalue reference with std::move() so that removing legacy ListBuilder::Pass() stuff. TEST=unit_tests BUG=563649 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1497753002 Cr-Commit-Position: refs/heads/master@{#363970}
* Complete live region support in ChromeVox Next.dmazzoni2015-12-012-6/+154
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Optimizes tree change notifications so that ChromeVox can only listen to those relevant to live regions, and skip the rest. Implements aria-atomic, and adds some code to avoid duplicate speaking of changes to a live region due to multiple tree changes. Improves speech queue mode support by always flushing following any key event, queueing otherwise, and doing a category flush when a new live region event happens 500 ms after the last one. The last one is a heuristic, but the idea is that multiple live region events at the same time should queue up, but a new live region some discrete time later should interrupt previous live region events. Adds some tests for live region output including flushing and queueing behavior. Manual tests include the live region test suite created for Google Docs testing. There are probably some bugs and corner cases left, but this gets us a lot closer. BUG=478217 Review URL: https://codereview.chromium.org/1457683009 Cr-Commit-Position: refs/heads/master@{#362500}
* Finish implementing ChromeVox Next active indicator.dmazzoni2015-11-232-11/+189
| | | | | | | | | | | | | | | | | | | | | | 1. Scrolls the page when navigating to a node, and updates the active indicator location when a scroll event is received. 2. Update the active indicator location on every Output, rather than only for speech or only for braille. (It was sometimes getting set and then overwritten with nothing.) 3. Handle subranges within a node with a new boundsForRange API. 4. Automation API: implement boundsForRange, take frame offsets and scroll offsets into account when returning a node's bounding box, and use heuristics to avoid returning an empty bounding box. BUG=537248 TBR=aboxhall Review URL: https://codereview.chromium.org/1458723002 Cr-Commit-Position: refs/heads/master@{#361160}
* Reland of [Extensions] Finish migrating ServiceWorker off the Behavior ↵alemate2015-11-181-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Feature system (patchset #1 id:1 of https://codereview.chromium.org/1461563002/ ) Reason for revert: Reverting speculative revert as it didn't help tests. Original issue's description: > Revert of [Extensions] Finish migrating ServiceWorker off the Behavior Feature system (patchset #1 id:40001 of https://codereview.chromium.org/1442183003/ ) > > Reason for revert: > Speculatively reverting this CL because of cros_trunk build bot failure. See crbug.com/557449 for details. > > Original issue's description: > > [Extensions] Finish migrating ServiceWorker off the Behavior Feature system > > > > The feature system is flaky for some reason and causing crashes. Move at least > > service worker off it, since it's easy and is causing the most crashes. > > > > BUG=461915 > > > > Committed: https://crrev.com/9a55fac787ba88f4139c2db41ea87be669272246 > > Cr-Commit-Position: refs/heads/master@{#360173} > > TBR=rockot@chromium.org,thestig@chromium.org,rdevlin.cronin@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=461915,557449 > > Committed: https://crrev.com/cf65af41f474e5118c2c8bfdd00999b39e24f291 > Cr-Commit-Position: refs/heads/master@{#360311} TBR=rockot@chromium.org,thestig@chromium.org,rdevlin.cronin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=461915,557449 Review URL: https://codereview.chromium.org/1455133002 Cr-Commit-Position: refs/heads/master@{#360321}
* Revert of [Extensions] Finish migrating ServiceWorker off the Behavior ↵alemate2015-11-181-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Feature system (patchset #1 id:40001 of https://codereview.chromium.org/1442183003/ ) Reason for revert: Speculatively reverting this CL because of cros_trunk build bot failure. See crbug.com/557449 for details. Original issue's description: > [Extensions] Finish migrating ServiceWorker off the Behavior Feature system > > The feature system is flaky for some reason and causing crashes. Move at least > service worker off it, since it's easy and is causing the most crashes. > > BUG=461915 > > Committed: https://crrev.com/9a55fac787ba88f4139c2db41ea87be669272246 > Cr-Commit-Position: refs/heads/master@{#360173} TBR=rockot@chromium.org,thestig@chromium.org,rdevlin.cronin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=461915,557449 Review URL: https://codereview.chromium.org/1461563002 Cr-Commit-Position: refs/heads/master@{#360311}
* [Extensions] Finish migrating ServiceWorker off the Behavior Feature systemrdevlin.cronin2015-11-171-1/+2
| | | | | | | | | | | The feature system is flaky for some reason and causing crashes. Move at least service worker off it, since it's easy and is causing the most crashes. BUG=461915 Review URL: https://codereview.chromium.org/1442183003 Cr-Commit-Position: refs/heads/master@{#360173}
* Fix crashes in AutomationInternalCustomBindings due to no v8 context.dmazzoni2015-11-092-3/+17
| | | | | | | | | | | | Add null check so we don't try to make v8 calls when there's no v8 context. Also speed up the destuctor by avoiding callbacks during destruction altogether. BUG=550624 Review URL: https://codereview.chromium.org/1413033012 Cr-Commit-Position: refs/heads/master@{#358644}
* Remove WebNode::childNodes().esprehn2015-11-061-5/+2
| | | | | | | | | | | This is a bad API since it allocates multiple rare data objects on a node or element. Instead users of WebNode should walk the firstChild and nextSibling pointers which is cheaper and doesn't cause a permanent memory increase. Review URL: https://codereview.chromium.org/1405293011 Cr-Commit-Position: refs/heads/master@{#358270}
* Reland of [Extensions] Migrate ServiceWorker off behavior feature system ↵rdevlin.cronin2015-10-261-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/1412683007/ ) Reason for revert: Talked to Anthony offline and we agreed the error was probably not my CL. Original issue's description: > Revert of [Extensions] Migrate ServiceWorker off behavior feature system (patchset #1 id:1 of https://codereview.chromium.org/1417563005/ ) > > Reason for revert: > Reverting because this CL appears to be causing failures on this bot: https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/14499 . > > Original issue's description: > > [Extensions] Migrate ServiceWorker off behavior feature system > > > > The FeatureSystem is failing to retrieve the behavior feature for service > > workers, but the only reason this seems to be the case is because of > > potential corruption in the JSON files (or the JSON parser otherwise choking). > > For now, to reduce the crash rates, just migrate the service worker restriction > > off the behavior feature system. > > > > BUG=461915 > > > > Committed: https://crrev.com/2507a2fcd25244dadb7dfcc316426bee7b1df275 > > Cr-Commit-Position: refs/heads/master@{#356123} > > TBR=rockot@chromium.org,rdevlin.cronin@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=461915 > > Committed: https://crrev.com/5708524cd0517ad825093d8cb4e9171ca99b3f42 > Cr-Commit-Position: refs/heads/master@{#356137} TBR=rockot@chromium.org,anthonyvd@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=461915 Review URL: https://codereview.chromium.org/1406083004 Cr-Commit-Position: refs/heads/master@{#356152}
* Revert of [Extensions] Migrate ServiceWorker off behavior feature system ↵anthonyvd2015-10-261-6/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:1 of https://codereview.chromium.org/1417563005/ ) Reason for revert: Reverting because this CL appears to be causing failures on this bot: https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/14499 . Original issue's description: > [Extensions] Migrate ServiceWorker off behavior feature system > > The FeatureSystem is failing to retrieve the behavior feature for service > workers, but the only reason this seems to be the case is because of > potential corruption in the JSON files (or the JSON parser otherwise choking). > For now, to reduce the crash rates, just migrate the service worker restriction > off the behavior feature system. > > BUG=461915 > > Committed: https://crrev.com/2507a2fcd25244dadb7dfcc316426bee7b1df275 > Cr-Commit-Position: refs/heads/master@{#356123} TBR=rockot@chromium.org,rdevlin.cronin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=461915 Review URL: https://codereview.chromium.org/1412683007 Cr-Commit-Position: refs/heads/master@{#356137}
* [Extensions] Migrate ServiceWorker off behavior feature systemrdevlin.cronin2015-10-261-0/+6
| | | | | | | | | | | | | | The FeatureSystem is failing to retrieve the behavior feature for service workers, but the only reason this seems to be the case is because of potential corruption in the JSON files (or the JSON parser otherwise choking). For now, to reduce the crash rates, just migrate the service worker restriction off the behavior feature system. BUG=461915 Review URL: https://codereview.chromium.org/1417563005 Cr-Commit-Position: refs/heads/master@{#356123}
* [Extensions] Remove kalman@ from OWNERS filesrdevlin.cronin2015-10-261-2/+0
| | | | | | | | BUG=484381 Review URL: https://codereview.chromium.org/1417313004 Cr-Commit-Position: refs/heads/master@{#356106}
* Exclude the Chrome Web Store from the iframe+popup workaround.creis2015-10-231-16/+21
| | | | | | | | | | | | New non-CWS windows opened from iframes in the CWS should not stay in the CWS process. BUG=477041 TEST=See bug for repro steps. Review URL: https://codereview.chromium.org/1420743003 Cr-Commit-Position: refs/heads/master@{#355846}
* Move some AX attrs from AXNodeData to AXTreeData.dmazzoni2015-10-222-332/+431
| | | | | | | | | | | | | | | | | | | | Previously all accessibility attributes had to be stored in AXNodeData. The root of a tree had a lot of extra attributes that only applied to that node. This introduces AXTreeData, a simple serializable struct with the data that applies to the whole tree, including the title, url, loading progress, and selection information. Later it will include focus information too. Note: this CL doesn't change any functionality or send any new data via an IPC, it just refactors things. BUG=none Review URL: https://codereview.chromium.org/1407413002 Cr-Commit-Position: refs/heads/master@{#355626}
* Add common method for checking extension isolation.nasko2015-10-221-2/+1
| | | | | | | | | | | | This CL adds a common method to check if extensions are running in Site Isolation mode. Follow up CL will add check based on field trial configuration. BUG=546050 Review URL: https://codereview.chromium.org/1411703006 Cr-Commit-Position: refs/heads/master@{#355466}
* Move more extensions code into ChromeExtensionsRendererClient.thestig2015-10-202-0/+340
| | | | | | Review URL: https://codereview.chromium.org/1394283003 Cr-Commit-Position: refs/heads/master@{#354921}
* Cast: extracting RTP Payload type and Video min/max bitrate into constantsmcasas2015-10-141-5/+5
| | | | | | | | | | | | | | | | | This CL is a cleanup that extracts a few constants: - RTP Video Payload, 96 - RTP Audio Payload 127 - Video Min/Max by-default bitrate (this is less pervasive though). The constants are moved to media/cast/cast_defines.h No new code is added. BUG=522661 Review URL: https://codereview.chromium.org/1399273006 Cr-Commit-Position: refs/heads/master@{#354029}
* Add content_switches include to files that need it.brettw2015-10-101-0/+1
| | | | | | | | | | | | | | | | | | This patch is from grepping for any identifier in content_switches.h and adds an include for it in those files. The reason for this is to be able to remove the include of content_switches.h from chrome_switches.h. That needs to be removed because the minimal chrome constants target that chrome_switches is part of technically doesn't depend on content. I want to be able to turn on GN header checking for the Chrome Windows installer targets so we can keep the dependencies under control (these targets try to be as small as possible). TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1395263002 Cr-Commit-Position: refs/heads/master@{#353430}
* Cast.streaming.receiverSession API bug fixesmiu2015-10-021-28/+21
| | | | | | | | | | | | | Fixes two bugs, one prevented use of this API: 1) An off-by-one error in processing the argument list values, making the impl unable to access the blink::WebMediaStream object. 2) A subtle memory leak in the processing of the "transport options" dictionary argument. BUG=537850 Review URL: https://codereview.chromium.org/1378193003 Cr-Commit-Position: refs/heads/master@{#352134}
* Dispatch automation events to the last used profile.dmazzoni2015-09-143-4/+21
| | | | | | | | | | | | | | | Specifically, on Chrome OS only, when the same extension (like ChromeVox) is loaded into more than one profile, send a flag along with the event and only pass the event to the JavaScript layer for the active profile. The other inactive ones will still update their accessibility trees silently in the background. BUG=515538 Review URL: https://codereview.chromium.org/1268163002 Cr-Commit-Position: refs/heads/master@{#348570}
* This patch allows the webview.partitions.accessible_resources entry in ↵paulmeyer2015-09-092-19/+28
| | | | | | | | | | | | chrome app manifests to work fully as intended. Previously, web pages attempting to use resources specified as webview accessible would fail to load those resources. This happened because a check in the renderer would stop the resource request from being made before the request ever reached the browser process where the webview accessible resources are checked in the manifest. This patch corrects this problem by propagating webview partition IDs to webview guest renderer processes, so that they can check the correct entry in the manifest for accessible resources and allow valid requests to go through to the browser process. BUG=460797 Review URL: https://codereview.chromium.org/1312653003 Cr-Commit-Position: refs/heads/master@{#347936}
* Add new certificateProvider extension API.pneubeck2015-09-091-0/+2
| | | | | | | | BUG=514575 Review URL: https://codereview.chromium.org/1232553003 Cr-Commit-Position: refs/heads/master@{#347916}
* Merge media::VideoCapturePixelFormat with media::VideoPixelFormatemircan2015-09-011-3/+2
| | | | | | | | | | | | | | | | This CL merges these 2 enums that overlap and represent pixel formats. - Moved types that do not exist to media::VideoPixelFormat - Updated histograms.xml for UMA values - Updated media_types.mojom for matching mojo enums - Added kWinSupportedCaptureFormats to capability_list_win.cc such that we are no longer dependant on the order of media::VideoCapturePixelFormat for choosing the preferred type. BUG=521068, 504160 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1301133002 Cr-Commit-Position: refs/heads/master@{#346711}
* Create thread-safe RendererExtensionRegistry from ExtensionSetannekao2015-08-194-11/+9
| | | | | | | | | | The worker thread needs to be able to access the set of current extensions in order to associate a v8::context with an extension. BUG=501569 Review URL: https://codereview.chromium.org/1293673002 Cr-Commit-Position: refs/heads/master@{#344244}
* Cleanup VersionInfo after componentization.sdefresne2015-08-031-1/+2
| | | | | | | | | | | | | | | | | | | Remove wrapper methods around version_info free functions and directly call them instead and fixes #include if only the component is required. Convert VersionInfo methods to free functions (as they do not have state) and rename GetVersionStringModifier to GetChannelString. Rename chrome/common/{chrome_version_info => channel_info}*. Forward-declare version_info::Channel in channel_info.h and add the missing #include of components/version_info/version_info.h were needed. BUG=514562 Review URL: https://codereview.chromium.org/1269773002 Cr-Commit-Position: refs/heads/master@{#341568}
* Componentize VersionInfo.sdefresne2015-07-301-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Create a new component version_info that allows to get information about the current version of Chrome running, except for the channel (which has to be provided by the embedder). The method to get the channel is not moved to the component because on Windows it depends on //chrome/installer which would be non-trivial to componentize. Since the method is embedder-specific (though it have no bad dependencies on the other platform) it makes sense to not move it into the component. Fixes VersionInfo API to only expose static method (since the class did not have any state and the API was a mix of "const" and "static" methods) and to delegate the job to version_info component in order to limit the API changes. Mass rename (chrome::)VersionInfo::(Channel|CHANNEL) after the enum was moved to the version_info namespace in the corresponding component using tools/git/mffr.py. Change Channel enumeration to be a "class enum" and add static_cast<int> where needed (as class enum do not implicitly convert to int). BUG=511912 Review URL: https://codereview.chromium.org/1257633002 Cr-Commit-Position: refs/heads/master@{#341085}
* Re-land (2): Reimplement automation API on top of C++-backed AXTree.dmazzoni2015-07-272-28/+618
| | | | | | | | | | | | | | | | | | | | | | | | Original review: https://codereview.chromium.org/1155183006 Landed: r335183 Reverted: r335343 (bug 502311) Landed again: r339929 Reverted again: r340091 (bug 502311 again) One fix to ax_tree.cc - bug 502311 was triggered from two different code paths, now both have tests. Also adds tiny fixes to automation_event_router.cc and automation_internal_custom_bindings.cc to prevent crashes when toggling ChromeVox off and on. TBRing dcheng, kalman since none of those files have changed since the original review. BUG=495323,502311 TBR=dcheng,kalman Review URL: https://codereview.chromium.org/1259703002 Cr-Commit-Position: refs/heads/master@{#340602}
* Revert of Re-land: Reimplement automation API on top of C++-backed AXTree. ↵asvitkine2015-07-232-612/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #6 id:100001 of https://codereview.chromium.org/1231603009/) Reason for revert: Top crasher in today's canary - 74% of browser crashes. Reverting per stability sheriff guidelines (go/stability-sheriff). Original issue's description: > Re-land: Reimplement automation API on top of C++-backed AXTree. > > Original review: https://codereview.chromium.org/1155183006 > Landed in: r335183 > Reverted in: r335343 (bug 502311) > > BUG=495323,502311 > > Committed: https://crrev.com/1777fbdbd234ddc8e19d4ba3a42cfd3234b8a158 > Cr-Commit-Position: refs/heads/master@{#339929} TBR=dcheng@chromium.org,aboxhall@chromium.org,dtseng@chromium.org,kalman@chromium.org,dmazzoni@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=495323,502311 Review URL: https://codereview.chromium.org/1251723003 Cr-Commit-Position: refs/heads/master@{#340091}
* Re-land: Reimplement automation API on top of C++-backed AXTree.dmazzoni2015-07-222-28/+612
| | | | | | | | | | | | Original review: https://codereview.chromium.org/1155183006 Landed in: r335183 Reverted in: r335343 (bug 502311) BUG=495323,502311 Review URL: https://codereview.chromium.org/1231603009 Cr-Commit-Position: refs/heads/master@{#339929}
* Crash fix: Add CastStreamingNativeHandler::Invalidate() impl.miu2015-07-142-42/+61
| | | | | | | | | | | | This handler never implemented Invalidate(), which is called when the V8 context is about to become invalid. Crashes ensued when callbacks were run that tried to dereference a null V8Context pointer. BUG=509128 Review URL: https://codereview.chromium.org/1236083002 Cr-Commit-Position: refs/heads/master@{#338615}
* [Extensions] Kill chrome.app.getDetailsForFramerdevlin.cronin2015-07-132-65/+5
| | | | | | | | | | No longer needed. Die die die! BUG=509101 Review URL: https://codereview.chromium.org/1227193004 Cr-Commit-Position: refs/heads/master@{#338552}
* media: extract Format and ColorSpace enum from VideoFrame.dongseong.hwang2015-07-131-3/+2
| | | | | | | | | | | | These enums are used in IPC as well as many classes. It's too big to include video_frame.h for only these enums. BUG=489744 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1165003008 Cr-Commit-Position: refs/heads/master@{#338514}
* [Extensions OOPI] Update AppBindings for OOPIrdevlin.cronin2015-07-102-13/+16
| | | | | | | | BUG=455776 Review URL: https://codereview.chromium.org/1225243004 Cr-Commit-Position: refs/heads/master@{#338344}
* Remove multiple function calls for RequestPeer.yhirano2015-07-083-36/+79
| | | | | | | | | | | | | | | Some classes are calling RequestPeer functions repeatedly. This is problematic because on each call that RequestPeer instance may be destructed and it is unable for the caller to detect the destruction. This CL introduces a combined notification in order to remove such repetitive calls. BUG=485413 Review URL: https://codereview.chromium.org/1218633004 Cr-Commit-Position: refs/heads/master@{#337774}
* [Extensions OOPI] Clean up extension IPC to use RenderFramesrdevlin.cronin2015-07-075-26/+22
| | | | | | | | | | | | Update a bunch of extension IPC messages to use render frames instead of render views. Remove the ScriptContext::GetRenderView() method to discourage future use. BUG=455776 Review URL: https://codereview.chromium.org/1215503002 Cr-Commit-Position: refs/heads/master@{#337596}
* Remove myself from the extensions owners files.jyasskin2015-07-061-1/+0
| | | | | | Review URL: https://codereview.chromium.org/1210403011 Cr-Commit-Position: refs/heads/master@{#337471}
* Update StartsWith calls to use new versions in chrome and contentbrettw2015-07-063-4/+6
| | | | | | | | | | | | | true -> base::CompareCase::SENSITIVE false with punctuation only -> base::CompareCase::SENSITIVE false with ascii constants -> base::CompareCase::INSENSITIVE_ASCII false with arbitrary string16 -> base::CompareCase::SENSITIVE with base::i18n::ToLower() on the arguments. BUG=506920, 506255 Review URL: https://codereview.chromium.org/1214183008 Cr-Commit-Position: refs/heads/master@{#337439}
* [Extensions] Kill off ExtensionMsg_AddMessageToConsolerdevlin.cronin2015-06-241-1/+3
| | | | | | | | | | | | | | | ExtensionMsg_AddMessageToConsole does the same things as RenderFrameHost::AddMessageToConsole, and adds a fair amount of code bloat. Remove it. In addition to being a nice cleanup, this kills off a bunch of RenderViewHost dependencies, as well. BUG=455776 TBR=timvolodine@chromium.org Review URL: https://codereview.chromium.org/1200503002 Cr-Commit-Position: refs/heads/master@{#335991}
* Populate render frame id to make desktopCapture work from webview.jiayl2015-06-231-0/+3
| | | | | | | | | | TESTED=verified screen cast works from the Hangouts Call app, using the enable_hangout_services_extension flag. BUG=415228, 500001 Review URL: https://codereview.chromium.org/1178063006 Cr-Commit-Position: refs/heads/master@{#335771}
* Revert of Reimplement automation API on top of C++-backed AXTree. (patchset ↵dmazzoni2015-06-192-611/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | #15 id:280001 of https://codereview.chromium.org/1155183006/) Reason for revert: Reverting as likely cause of bug 502311 Original issue's description: > Reimplement automation API on top of C++-backed AXTree. > > Design doc: https://docs.google.com/a/google.com/document/d/1nKMfTbS5W6uGlqRHf0XRZLVzAcKD_vqu8lw7l9zHoBw/edit?usp=sharing > > BUG=495323 > > Committed: https://crrev.com/0e90449a7c9bd8f051fce4988a8cccd6c1c64661 > Cr-Commit-Position: refs/heads/master@{#335183} TBR=dcheng@chromium.org,aboxhall@chromium.org,dtseng@chromium.org,kalman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=495323 Review URL: https://codereview.chromium.org/1198613002 Cr-Commit-Position: refs/heads/master@{#335343}
* Reimplement automation API on top of C++-backed AXTree.dmazzoni2015-06-192-28/+611
| | | | | | | | | | Design doc: https://docs.google.com/a/google.com/document/d/1nKMfTbS5W6uGlqRHf0XRZLVzAcKD_vqu8lw7l9zHoBw/edit?usp=sharing BUG=495323 Review URL: https://codereview.chromium.org/1155183006 Cr-Commit-Position: refs/heads/master@{#335183}
* Execute distiller in isolated worldmdjones2015-06-171-1/+1
| | | | | | | | | | | This change runs the dom distiller in an isolated world instead of the main world. BUG=484843 Review URL: https://codereview.chromium.org/1124973002 Cr-Commit-Position: refs/heads/master@{#334954}
generated by cgit v1.1 at 2025-02-07 19:33:49 +0000