summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/net
Commit message (Collapse)AuthorAgeFilesLines
* Convert Pass()→std::move() in //chromedcheng2015-12-271-10/+5
| | | | | | | | | | | | ☃ BUG=557422 R=avi@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1551503002 Cr-Commit-Position: refs/heads/master@{#366918}
* Switch to standard integer types in chrome/.avi2015-12-262-0/+2
| | | | | | | | | | BUG=138542 TBR=thakis@chromium.org NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1548153002 Cr-Commit-Position: refs/heads/master@{#366893}
* Attempt to fix a renderer crash in NetErrorHelperCore.mmenke2015-12-101-0/+5
| | | | | | | | | | | | | | | | | The code was not distinguishing between same page navigations, which do not have a provision load start event (But do have a provisional commit) from other navigations, which have both events. The old code would cause a crash in the case of a same page navigation on the error page. This could be causing a crash we're seeing, but it's unclear why the error page would be making same page navigations in the first place. BUG=557541 Review URL: https://codereview.chromium.org/1516623002 Cr-Commit-Position: refs/heads/master@{#364388}
* Add "Show saved copy" button in dino page when there's offline copyjianli2015-11-244-48/+77
| | | | | | | | | | When there is offline copy for the page, "Show saved copy" will be shown. Otherwise when there is offline copy for other pages, "Show all saved pages" will be shown. BUG=559354 Review URL: https://codereview.chromium.org/1442433003 Cr-Commit-Position: refs/heads/master@{#361305}
* Add "SHOW ALL SAVED PAGES" button to offline error pagejianli2015-11-124-2/+41
| | | | | | | | BUG=491352 Review URL: https://codereview.chromium.org/1410343007 Cr-Commit-Position: refs/heads/master@{#359205}
* Use the same reload policy of the failed request in NetErrorHelper's ↵horo2015-11-112-8/+9
| | | | | | | | | | | | | | | | | | | auto-reload. When the user does a hard refresh (ctrl+ shift + r) and a network error happens, NetErrorHelper tries to auto-reload the page. But NetErrorHelper::ReloadPage() doesn't care about the |ignoreCache| flag. So the reloaded page will be the result of normal reload. This cl introduces was_ignoring_cache flag to ErrorPageInfo and set the |ignoreCache| flag if the cache policy of the failed first reload request was ReloadBypassingCache which is set in FrameLoader::resourceRequestForReload(). BUG=489051 Review URL: https://codereview.chromium.org/1414603009 Cr-Commit-Position: refs/heads/master@{#359010}
* Make NetErrorHelper more OOPIF-friendly.mmenke2015-10-272-51/+32
| | | | | | | | | | | | Now create one per frame instead of creating them only for main frames, and get the WebFrame directly from a WebFrame rather than by going through the RenderView. BUG=543226,529976 Review URL: https://codereview.chromium.org/1406303002 Cr-Commit-Position: refs/heads/master@{#356395}
* Alter Google cached copy button experiment, remove label variationsedwardjung2015-08-284-24/+8
| | | | | | | | | | | - Switch button label to 'Show saved copy' per launch review. - Experiment will focus on promoting the link doctor link to a button. BUG=474848 Review URL: https://codereview.chromium.org/1306053006 Cr-Commit-Position: refs/heads/master@{#346128}
* Remove error page UMA and safety checks added for issue 500556mmenke2015-08-261-3/+1
| | | | | | | | | | | | | The underlying bug appears to have been fixed in https://codereview.chromium.org/1259653003. UMA indicates that the conditions that caused the crash have not happened on any version of Chrome since the putative fix landed. BUG=500556 Review URL: https://codereview.chromium.org/1309973002 Cr-Commit-Position: refs/heads/master@{#345644}
* Put components/error_page code in namespace error_page.thestig2015-08-181-4/+4
| | | | | | Review URL: https://codereview.chromium.org/1301733002 Cr-Commit-Position: refs/heads/master@{#344019}
* Move DNS functions from net_error_info.h into error_page namespace.tfarina2015-08-101-2/+2
| | | | | | | | | | | | This was a TODO for hashimoto. The rest of the file will be moved into error_page in a separate CL. BUG=None R=mmenke@chromium.org,thestig@chromium.org Review URL: https://codereview.chromium.org/1277213003 Cr-Commit-Position: refs/heads/master@{#342699}
* Add link to OSX's diagnostic tool on error page.mmenke2015-08-054-3/+34
| | | | | | | | | | Will add Windows in a followup CL. BUG=468037 Review URL: https://codereview.chromium.org/1266873002 Cr-Commit-Position: refs/heads/master@{#341836}
* Fix case where ErrorPageController outlives the frame it's attached to.mmenke2015-08-044-45/+66
| | | | | | | | | | | | | ErrorPageController could call into NetErrorHelper after the page it's attached to was destroyed. This CL gives the controller a weak pointer to the NetErrorHelper that's invalidated on commit, which should fix the issue. BUG=500556 Review URL: https://codereview.chromium.org/1259653003 Cr-Commit-Position: refs/heads/master@{#341785}
* Unify LowerCaseEqualsASCII and EqualsASCII functions.brettw2015-07-231-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This removes the many overrides and unifies on StringPIece implementations. StringPiece did not exist when these functions were written. The lack of StringPiece versions make it difficult to use when (typically newer) code has a StringPiece (for example, see affiliation_utils.cc), and StringPiece versions can't be added because it will be ambiguous with the std::string versions. There are a few dozen places where a WebString is passed into these functions. A WebString can not be implicitly converted into a StringPiece, so I added explicit base::StringPiece16 wrappers around the necessary parameters. This is actually nice because it emphasizes that a temporary is created. In a few places it does this redundantly and I pulled a string16 out (for example, drop_data_builder.cc). Callers that were using the iterator versions got converted to constructing a StringPiece with iterators. This was the case mostly for net where this pattern seems common. A few cases, such as data_reduction_proxy_config.cc were actually trying to do prefix matches. I converted these to StartsWith (cur current, more- convenient version of StartsWith is relatively new). Theoretically these aren't equivalent because StartsWith doesn't assume a previously-lower-cased 2nd argument. But the strings are short and the convenience makes up for the difference. I converted the define HTTP_LWS to a constant kHttpLinearWhitespace to avoid polluting the global namespace. This traces back to the original commit with a vague comment about overriding at buildtime (which can't happen). I kept the define in the .cc file because header pollution is less and C constant concatenation is used with this in a few places that would require a constant with confusing description or a temporary to be created. http_response_headers.cc: changed some functions to StringPIeces that used iterators for convenience and clarity. Added a TrimLWSPiece to NetUtil for convenience in the header parsing code. Significantly updated HttpUtil::ParseContentType to use StringPieces. Review URL: https://codereview.chromium.org/1242673002 Cr-Commit-Position: refs/heads/master@{#340176}
* Add UMA histograms for Google cached copy experiment on network error ↵edwardjung2015-07-214-1/+29
| | | | | | | | | | | | | | interstitial Tracks usage: + of promoted 'Google cached copy' link doctor button. + on each of the two button label variants. BUG=474848 Review URL: https://codereview.chromium.org/1214303003 Cr-Commit-Position: refs/heads/master@{#339714}
* Check whether the handle returned by PeekNext() is empty before accessing itjochen2015-07-131-1/+1
| | | | | | | | | BUG=507625 R=haraken@chromium.org Review URL: https://codereview.chromium.org/1232343004 Cr-Commit-Position: refs/heads/master@{#338480}
* Attempt to fix a crash in NerErrorHelperCore.mmenke2015-07-084-51/+25
| | | | | | | | | | | | | | It looks like we're getting button press events when committed_error_page_info_ is NULL. This CL checks for that case, to prevent the crash. As it's unclear what's causing this, it also adds a pair of histograms to help investigate the cause of the underlying issue. BUG=500556 Review URL: https://codereview.chromium.org/1180693006 Cr-Commit-Position: refs/heads/master@{#337852}
* Change FetchNavigationCorrections FrameType to FrameTypeNoneclamy2015-07-081-1/+1
| | | | | | | | | | | | | | | The FrameType to fetch navigations corrections for the error page is currently set to FrameTypeTopLevel. However, this is closer to an xmlhttprequest, which according to https://fetch.spec.whatwg.org/#concept-request-context-frame-type corresponds to FrameTypeNone. This is an issue in PlzNavigate, in which the WebURLLoader does not expect to get a direct request for a top-level frame (ie a navigation) without going to the browser. BUG=504347 Review URL: https://codereview.chromium.org/1217443023 Cr-Commit-Position: refs/heads/master@{#337826}
* Move EqualsASCII to the base namespace.brettw2015-06-101-1/+2
| | | | | | Review URL: https://codereview.chromium.org/1176583003 Cr-Commit-Position: refs/heads/master@{#333676}
* Convert JsonWriter::Write to taking a const ref for the in-paramestade2015-05-161-1/+1
| | | | | | | | | | | | Clearer API; flushes out a lot of unnecessary heap allocations. depends on https://codereview.chromium.org/1129083003/ BUG=none Review URL: https://codereview.chromium.org/1131113004 Cr-Commit-Position: refs/heads/master@{#330255}
* Use v8::Local inplace of v8::Handle in src/chrome/*deepak.s2015-04-301-2/+2
| | | | | | | | | | Replace Handle with Local BUG=424445 Review URL: https://codereview.chromium.org/1103273009 Cr-Commit-Position: refs/heads/master@{#327673}
* Improvements to the offline intersitial and easter eggedwardjung2015-04-034-1/+23
| | | | | | | | | | | | | | - Fix right click restart bug. - Switched image assets to use sprite sheets. - Fix resizing whilst jumping causes delays bug. - Add UMA counter for easter egg. - Gameplay tweaks. BUG=464330,453853 Review URL: https://codereview.chromium.org/1051433002 Cr-Commit-Position: refs/heads/master@{#323703}
* Three way experiment for "Show saved copy" button.megjablon2015-03-114-24/+15
| | | | | | | | BUG=368049 Review URL: https://codereview.chromium.org/961443002 Cr-Commit-Position: refs/heads/master@{#320113}
* Add is_same_page_navigation to RFO::DidCommitProvisionalLoad.mlamouri2015-02-272-2/+4
| | | | | | | | | | | This seems to be something that most consumers want to know. Better to pass a boolean instead of expecting all consumers to do the right thing. BUG=459242 Review URL: https://codereview.chromium.org/950653002 Cr-Commit-Position: refs/heads/master@{#318441}
* Cleanup: properly permit access to components/error_page in DEPS files.thestig2015-01-201-0/+1
| | | | | | Review URL: https://codereview.chromium.org/837683003 Cr-Commit-Position: refs/heads/master@{#312295}
* Make callers of CommandLine use it via the base:: namespace, and remove the ↵avi2014-12-251-3/+3
| | | | | | | | | | | | global alias. BUG=422426 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/812353003 Cr-Commit-Position: refs/heads/master@{#309644}
* Adds DNS prefetch support to Chromecast.gunsch2014-12-112-48/+0
| | | | | | | | | R=lcwu@chromium.org,ttuttle@chromium.org BUG=419909 Review URL: https://codereview.chromium.org/785693002 Cr-Commit-Position: refs/heads/master@{#307967}
* Componentize renderer side of DNS prefetching.gunsch2014-11-187-805/+2
| | | | | | | | BUG=419909 Review URL: https://codereview.chromium.org/644123002 Cr-Commit-Position: refs/heads/master@{#304529}
* Standardize usage of virtual/override/final in chrome/renderer/dcheng2014-10-212-25/+24
| | | | | | | | | | | | This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=jhawkins@chromium.org Review URL: https://codereview.chromium.org/663333002 Cr-Commit-Position: refs/heads/master@{#300451}
* Componentize NetErrorHelperCorehashimoto2014-10-155-3656/+15
| | | | | | | | | | | | | | | | | | Create a new component error_page which will host NetErrorHelper to make it usable from binaries other than chrome. Move NetErrorHelperCore and net_error_info.{cc,h} to components/error_page. Split LocalizedError::ErrorPageParams to components/error_page/common/error_page_params. Move string resources to error_page_strings.grdp Fix GYP, GN, DEPS. Copy OWNERS from chrome/renderer/net to components/error_page. BUG=398173 TEST=build TBR=sky@chromium.org for +ui/base in DEPS Review URL: https://codereview.chromium.org/570253002 Cr-Commit-Position: refs/heads/master@{#299647}
* Replacing the OVERRIDE with override and in chrome/renderermohan.reddy2014-10-104-31/+31
| | | | | | | | | | | This step is a giant search and replace for OVERRIDE to replace them with their lowercase versions. BUG=417463 Review URL: https://codereview.chromium.org/630603003 Cr-Commit-Position: refs/heads/master@{#299042}
* Implement ManifestFetcher, helper to fetch Web Manifests.mlamouri2014-09-131-0/+2
| | | | | | | | | | This is implemented on top of ResourceFetcher. BUG=410414 Review URL: https://codereview.chromium.org/532773002 Cr-Commit-Position: refs/heads/master@{#294744}
* Return WebLocalFrame from RenderFrame::GetWebFrame().mlamouri2014-09-102-2/+2
| | | | | | | | BUG=409995 Review URL: https://codereview.chromium.org/547093002 Cr-Commit-Position: refs/heads/master@{#294173}
* Rework UMAHistogramHelper and StatisticsDeltaReader into ↵mlerman@chromium.org2014-08-211-89/+48
| | | | | | | | | | | | | | | [Chrome]HistogramTester. Design Doc (Googlers Only): https://docs.google.com/a/google.com/document/d/1RUY0BcxBppdkwFP3T8qbQmQStBRFGsLmuR4WuIXhiCA/edit BUG=384011 TBR=timsteele@chromium.org Review URL: https://codereview.chromium.org/379283002 Cr-Commit-Position: refs/heads/master@{#291207} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291207 0039d316-1c4b-4281-b951-d872f2087c98
* Use a qualified path for grit includes in various chrome/ directories.thestig@chromium.org2014-08-132-2/+2
| | | | | | | | | BUG=401588 Review URL: https://codereview.chromium.org/450053003 Cr-Commit-Position: refs/heads/master@{#289213} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289213 0039d316-1c4b-4281-b951-d872f2087c98
* Shift the error page "More" button over to text and float to side.rdsmith@chromium.org2014-08-052-4/+5
| | | | | | | | | | | | | | | | Note that this also involved copying neterror.css/js over to chrome/browser/resources/ssl so as to break the dependency between blocking.html in that directory and the css/js files in chrome/renderer/resources. That copy means that, while I'm going through presubmit errors before uploading, I"m not fixing them all-- there are pre-existing errors in neterror.css that I don't have the expertise to fix. BUG=None Review URL: https://codereview.chromium.org/422933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287538 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 286241 "Revert 286126 "Remove 'WebURLRequest::TargetType'..."kbr@chromium.org2014-07-291-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This and related CLs were not the cause of apparent flakiness. Apologies. Re-landing. > Revert 286126 "Remove 'WebURLRequest::TargetType' from 'content:..." > > Believe this and related changes are the cause of recently introduced > flakiness on the GPU bots. See Issue 390497. > > > Remove 'WebURLRequest::TargetType' from 'content::ResourceFetcher::Start' > > > > 'WebURLRequest::TargetType' has been dropped in Blink in favor of > > 'RequestContext' and 'FrameType', matching the Fetch specification's > > changes, and allowing both more granularity in various Blink-side checks > > and more clarity around the thing that caused a request, and the frame > > that the request affects. > > > > This CL should have zero practical effect, as it's simply hoisting the > > translation work that 'WebURLRequest::setTargetType' is already doing > > up into the content layer to bring us one step closer to removing the > > concept entirely. > > > > BUG=390497 > > > > Review URL: https://codereview.chromium.org/403313005 > > TBR=mkwst@chromium.org > > Review URL: https://codereview.chromium.org/423163003 TBR=kbr@chromium.org Review URL: https://codereview.chromium.org/423303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286338 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 286126 "Remove 'WebURLRequest::TargetType' from 'content:..."kbr@chromium.org2014-07-291-9/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Believe this and related changes are the cause of recently introduced flakiness on the GPU bots. See Issue 390497. > Remove 'WebURLRequest::TargetType' from 'content::ResourceFetcher::Start' > > 'WebURLRequest::TargetType' has been dropped in Blink in favor of > 'RequestContext' and 'FrameType', matching the Fetch specification's > changes, and allowing both more granularity in various Blink-side checks > and more clarity around the thing that caused a request, and the frame > that the request affects. > > This CL should have zero practical effect, as it's simply hoisting the > translation work that 'WebURLRequest::setTargetType' is already doing > up into the content layer to bring us one step closer to removing the > concept entirely. > > BUG=390497 > > Review URL: https://codereview.chromium.org/403313005 TBR=mkwst@chromium.org Review URL: https://codereview.chromium.org/423163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286241 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 'WebURLRequest::TargetType' from 'content::ResourceFetcher::Start'mkwst@chromium.org2014-07-291-3/+9
| | | | | | | | | | | | | | | | | | | 'WebURLRequest::TargetType' has been dropped in Blink in favor of 'RequestContext' and 'FrameType', matching the Fetch specification's changes, and allowing both more granularity in various Blink-side checks and more clarity around the thing that caused a request, and the frame that the request affects. This CL should have zero practical effect, as it's simply hoisting the translation work that 'WebURLRequest::setTargetType' is already doing up into the content layer to bring us one step closer to removing the concept entirely. BUG=390497 Review URL: https://codereview.chromium.org/403313005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286126 0039d316-1c4b-4281-b951-d872f2087c98
* Remove preconnect implementation from PrescientNetworkingDispatcherkouhei@chromium.org2014-06-252-47/+0
| | | | | | | | | | | | | | The preconnect implementation is only used from preconnect-on-mousedown experiment which was suspended. This CL removes the implementation so that this interface can be safely removed from Blink. BUG=386888 Review URL: https://codereview.chromium.org/351773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279633 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove more dead GTK code.thestig@chromium.org2014-06-171-21/+5
| | | | | | | | TBR=sky@chromium.org Review URL: https://codereview.chromium.org/326043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277881 0039d316-1c4b-4281-b951-d872f2087c98
* Add flag to auto-reload only visible tabs.ellyjones@chromium.org2014-06-161-2/+3
| | | | | | | | | | | | | Adds a new flag, enable-offline-auto-reload-visible-only, which causes auto-reload to only operate on tabs that are visible. This flag will be set by a fieldtrial for mobile platforms, although it might also be useful on desktop. TEST=trybot BUG=chromium:355569 Review URL: https://codereview.chromium.org/325853003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277453 0039d316-1c4b-4281-b951-d872f2087c98
* autoreload: conditionally only run when foregroundedellyjones@chromium.org2014-06-055-495/+583
| | | | | | | | | | | On mobile devices, to avoid burning battery and causing spurious wakeups, autoreload now supports running only when the tab being autoreloaded is visible. BUG= Review URL: https://codereview.chromium.org/284193007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275090 0039d316-1c4b-4281-b951-d872f2087c98
* Fix auto-reload histograms.ellyjones@chromium.org2014-05-164-145/+457
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Two bugs, and general state-machine grotesqueness, prevented auto-reload histograms from working properly in production: 1. Success could only be reported in OnCommitLoad() if can_auto_reload_page_ was true, but can_auto_reload_page_ would be set to false in OnStartLoad(), since OnStartLoad() had no way of knowing that the non-error page load it saw starting was actually part of an attempt to auto-reload the page. This has been patched around by tracking is_auto_reloading in committed_error_page_info_; when the auto reload timer fires, it sets is_auto_reloading to indicate to OnCommitLoad that auto-reload was running. OnCommitLoad can then use is_auto_reloading and the loading URL to decide whether the committing load represents a success or failure for auto-reload. 2. Whenever a non-error load started, OnStartLoad() would call CancelPendingFetches(), intending to prevent auto-reload from replacing the starting load with its own; as a side-effect, CancelPendingFetches() would assume that if there was an existing error page which looked auto-reloadable that the cancel represented a failure of auto-reload and log a histogram entry. Unfortunately, this logic would trigger at each reload attempt by auto-reload, inflating the failure count with nonexistent failures. To prevent this misbehavior, CancelPendingFetches() is now no longer responsible for logging auto-reload failures; instead, failures are detected and logged in OnCommitLoad() (for "user navigated elsewhere" failures), OnStop (for "user pressed Stop to abort auto-reload" failures), and the NetErrorHelperCore destructor (for "user closed the tab" failures). To help clean up the code, statistics are now reported through ReportAutoReloadSuccess() and ReportAutoReloadFailure(). There are new unit tests covering these cases: 1. Auto-reload succeeding on the first attempt; 2. Auto-reload succeeding on the second attempt; 3. The user manually stopping an auto-reload; 4. The user manually stopping a non-auto-reload load; 5. The user navigating to a different URL; As part of this cleanup, simplify the state machine; the ambiguous "can_auto_reload_page_" flag is gone, replaced by an implicit state bit in whether the timer is running (or paused) or not. BUG= Review URL: https://codereview.chromium.org/259613003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271007 0039d316-1c4b-4281-b951-d872f2087c98
* Add tracking requests using the new fixurl API for Link Doctor.mmenke@chromium.org2014-05-067-225/+610
| | | | | | | | | | | | | | These requests can't use XHRs, unfortunately, since they're considered cross domain, and XHRs are cancelled on navigation. Their cross-domain-ness also makes them unsuitable for the upcoming beacon API. As a result, they have to use special hooks. BUG=64832,359131 Review URL: https://codereview.chromium.org/247313003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268546 0039d316-1c4b-4281-b951-d872f2087c98
* Make Load Stale Cache dependent on flag and field trial.rdsmith@chromium.org2014-05-021-2/+12
| | | | | | | | | | BUG=329620 R=ellyjones@chromium.org R=mmenke@chromium.org Review URL: https://codereview.chromium.org/266583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267797 0039d316-1c4b-4281-b951-d872f2087c98
* Added histograms to https://codereview.chromium.org/207553008/.rdsmith@chromium.org2014-04-293-11/+12
| | | | | | | | | | | | | Also includes some nits from jar@'s review of that CL. BUG=329620 R=jar@chromium.org R=mmenke@chromium.org Review URL: https://codereview.chromium.org/248123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266711 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure gin Handles exist before using themjochen@chromium.org2014-04-281-0/+3
| | | | | | | | | | | When we run out of stack space for example, we can't create an handle. BUG=363417 R=dcarney@chromium.org Review URL: https://codereview.chromium.org/259993003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266545 0039d316-1c4b-4281-b951-d872f2087c98
* Move auto-reload count increment to timer fire.ellyjones@chromium.org2014-04-223-7/+15
| | | | | | | | | | | | | | | Incrementing the auto-reload count when the timer starts can have adverse effects if the timer is stopped and restarted by network change notifications - the backoff count can rapidly grow, effectively disabling auto-reload. To fix this, increment the count when the timer actually fires, and adjust unit tests to match. BUG=chromium:363258 TEST=unit Review URL: https://codereview.chromium.org/245583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265275 0039d316-1c4b-4281-b951-d872f2087c98
* Surface button for loading stale cache copy on net error page.rdsmith@chromium.org2014-04-189-144/+331
| | | | | | | | | | | | | | In cases in which a network error occurs, and we have a stale copy of the top level resource that was attempting to be loaded, show a button on the network error page that the user can use to load that stale copy. BUG=329620 R=mmenke@chromium.org R=ellyjones@chromium.org Review URL: https://codereview.chromium.org/207553008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264696 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-16 03:32:29 +0000