summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/prerender
Commit message (Collapse)AuthorAgeFilesLines
* Make the renderer-side prerendering code use RenderFrames instead of ↵jam@chromium.org2013-12-104-27/+30
| | | | | | | | | | | | | RenderViews. This is also part of the work of making ContentRendererClient's OverrideCreatePlugin and CreatePluginReplacement take only a RenderFrame. BUG=304341 R=creis@chromium.org, mmenke@chromium.org, tburkard@chromium.org Review URL: https://codereview.chromium.org/107893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239860 0039d316-1c4b-4281-b951-d872f2087c98
* Rename WebKit namespace to blink (part 4)abarth@chromium.org2013-11-077-16/+16
| | | | | | | | | | | | This CL updates all references to the WebKit namespace in chrome and components. TBR=darin@chromium.org BUG=295096 Review URL: https://codereview.chromium.org/63273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233464 0039d316-1c4b-4281-b951-d872f2087c98
* Release prerenders in the PrerenderDispatcher on abandon/cancel.davidben@chromium.org2013-10-191-4/+18
| | | | | | | | | | | | | | | | | | There's no need to maintain the reference; once abandon or cancel is called, the LinkLoader (as PrerenderClient) has already been removed from the Prerender in Blink, so it is no longer consuming didStopPrerender and friends. Rather, this is causing us to leak cancelled prerenders because the browser process does not send OnPrerenderStop for canceled prerenders either, leaving nothing to release PrerenderDispatcher's reference to the Prerender (via WebPrerender). This introduces the possibility of an OnPrerenderStart from the browser racing with an (asynchronous) cancel message to the browser, so handle that case. BUG=290197 Review URL: https://codereview.chromium.org/27195006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229604 0039d316-1c4b-4281-b951-d872f2087c98
* Rename PrerenderWebMediaPlayer to PrerenderMediaLoadDeferrer.scherkus@chromium.org2013-07-092-19/+18
| | | | | | | | As of r209797 it no longer inherits from WebKit::WebMediaPlayer. Review URL: https://chromiumcodereview.appspot.com/18587003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210495 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Migrate from googleurl/ includes to url/ ones. Part 3.tfarina@chromium.org2013-07-042-2/+2
| | | | | | | | | | BUG=229660 TBR=thestig@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/18523004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210197 0039d316-1c4b-4281-b951-d872f2087c98
* Update content API in preparation for migrating webkit/renderer/media/ to ↵scherkus@chromium.org2013-07-022-69/+16
| | | | | | | | | | | | content/renderer/media/. The biggest change is to replace the coarse-grained WebMediaPlayer-based content API with finer-grained APIs for controlling media resource loads (e.g., prerendering) and media stream audio/video rendering (e.g., WebRTC layout tests). BUG=239826,251306 Review URL: https://chromiumcodereview.appspot.com/18123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209797 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in chrome/common/, chrome/installer, ↵avi@chromium.org2013-06-281-1/+1
| | | | | | | | | | | | chrome/renderer/, chrome/service/. BUG=254986 TEST=none TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/18147002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209157 0039d316-1c4b-4281-b951-d872f2087c98
* Update Blink include pathsabarth@chromium.org2013-06-174-5/+5
| | | | | | | | | | | | | This CL changes the majority of include paths from the old Source/WebKit/chromium/public to the new public/web directory. TBR=darin BUG=239545 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/17148003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206664 0039d316-1c4b-4281-b951-d872f2087c98
* Prerendering: Defering load of WebMediaSource while in prerender mode.shishir@chromium.org2013-06-132-5/+32
| | | | | | | | | | | | | Currently prerendered pages can end up playing video/audio in the back ground if they are using Media Source. After this change the loading of the files will be deferred till the prerender is swapped in. TEST=PrerenderBrowserTest.PrerenderHTML5MediaSourceVideo BUG=136262 Review URL: https://chromiumcodereview.appspot.com/16797002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206144 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dominich as a prerender owner, as he's nommenke@chromium.org2013-06-111-1/+0
| | | | | | | | | | longer working on chrome. R=gavinp@chromium.org Review URL: https://codereview.chromium.org/16109012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205535 0039d316-1c4b-4281-b951-d872f2087c98
* Remove override of never-called WebKit::WebMediaPlayer::cancelLoad methodadamk@chromium.org2013-06-102-10/+0
| | | | | | | | | | Missed this one when I removed the other overrides in r204601. R=dominich Review URL: https://chromiumcodereview.appspot.com/16566004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205299 0039d316-1c4b-4281-b951-d872f2087c98
* Move webkit/media/ into webkit/renderer/mediajamesr@chromium.org2013-05-302-2/+2
| | | | | | | | | | | | This code is only used in renderer processes, this just moves the files to reflect that fact in the directory structure so we can verify it with DEPS. BUG=237267 Review URL: https://chromiumcodereview.appspot.com/15842010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203248 0039d316-1c4b-4281-b951-d872f2087c98
* Update refernces to Blink's Platform API (chrome)abarth@chromium.org2013-05-304-7/+7
| | | | | | | | | | | | | | These headers have moved from Source/Platform/chromium/public to public/platform. This CL updates chrome's references to the old location to point to the new location. After this CL lands, I'll remove the forwarding headers that are letting these references still work. TBR=jamesr@chromium.org BUG=239545 Review URL: https://chromiumcodereview.appspot.com/16109004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203133 0039d316-1c4b-4281-b951-d872f2087c98
* Broadcast prerender URLs to all render processes.cbentzel@chromium.org2013-05-153-24/+66
| | | | | | | | | | | | | | Before this change, a render-initiated navigation could only swap to a prerender if the prerender was created via a <link rel="prerender"> element from a RenderView within the same render process. Now that we are experimenting with local-browsing based prerenders, this means that a lot of prerenders may never be used. The prerenders are created in the browser process, and need to be advertised to all render processes. There is a slight risk that an owned render process can spy on some navigations that a user does due to the broadcast. BUG=239180 Review URL: https://chromiumcodereview.appspot.com/15027009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200223 0039d316-1c4b-4281-b951-d872f2087c98
* Guard against duplicate adds in prerender dispatcher.gavinp@chromium.org2013-03-121-0/+5
| | | | | | | | | | | | | | | | | The earlier patch in issue 12253035 didn't fix all cases; this more conservative renderer side guard should work better. The renderer data structure should strictly have longer lifetime than the browser side structure, so this should totally eliminate the race (at the cost of stopping some prerenders that while "valid" are very weird and unexpected). R=mmenke@chromium.org BUG=173012 Review URL: https://chromiumcodereview.appspot.com/12521012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187698 0039d316-1c4b-4281-b951-d872f2087c98
* Update some #includes in chrome/renderer/prerender for headers in the new ↵pilgrim@chromium.org2013-01-151-1/+1
| | | | | | | | Platform directory Review URL: https://chromiumcodereview.appspot.com/11826035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176788 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Fix a bunch of lint errors in chrome.thestig@chromium.org2013-01-041-1/+1
| | | | | | Review URL: https://chromiumcodereview.appspot.com/11745025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175221 0039d316-1c4b-4281-b951-d872f2087c98
* Pass load events from prerenders to launching elements.gavinp@chromium.org2013-01-032-0/+15
| | | | | | | | | | | | The event is already on the webkit side, this patch plumbs it through. Note that this patch is downstream from https://codereview.chromium.org/11551003/ and so it can't land until after that one. R=mmenke@chromium.org,jschuh@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/11571037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175011 0039d316-1c4b-4281-b951-d872f2087c98
* Vanquish the remnants of media::MessageLoopFactory.scherkus@chromium.org2013-01-022-30/+3
| | | | | | | | | | | | Now that media code runs on a single thread we no longer need to worry about creating additional threads at runtime. To make changes like this easier in the future, webkit_media::WebMediaPlayerParams is introduced to avoid plumbing parameters through Chrome's various abstraction layers. BUG=116873 Review URL: https://codereview.chromium.org/11468033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174808 0039d316-1c4b-4281-b951-d872f2087c98
* Add Start/Stop event signalling on Prerenders.gavinp@chromium.org2012-12-183-14/+26
| | | | | | | | | | | | | We've switched to our new event names, we've made sure that the PrerenderHandle and the PrerenderLinkManager are connected, and now, we pass these events into WebKit. This change depends on the WebKit changes in https://bugs.webkit.org/show_bug.cgi?id=96474 landing first. As well, this CL depends on the earlier work in https://chromiumcodereview.appspot.com/11316311/ , which makes the PrerenderHandle an observer of the PrerenderContents, being landed first. As well, since this code depends on WebPrerender.h changing, it actually needs to be staged carefully between WebKit & Chrome. Careful readers will also observe that this change obsoletes https://chromiumcodereview.appspot.com/10918189/ . R=mmenke@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/11459003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173625 0039d316-1c4b-4281-b951-d872f2087c98
* Make PrerenderHandle an observer of PrerenderContents.gavinp@chromium.org2012-12-153-95/+110
| | | | | | | | | | | | | | | The big implication of this is that PrerenderLinkManager is an observer of PrerenderHandle, and so messaging to/from the browser process about prerenders ends up mostly in the same place. Interestingly, we basically can toss out the pending_prerenders_ list in the PrerenderManager; the only thing it bought us was tracking cancelation, which is now done with a bool in PrerenderHandle, just as easily. The earlier work on the lifetime of PrerenderContents and PrerenderHandle was building up to this. This CL depends on https://codereview.chromium.org/11348357/ , and can't land until after it. R=mmenke@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/11316311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173322 0039d316-1c4b-4281-b951-d872f2087c98
* Remove prerendering RenderView histograms.mmenke@chromium.org2012-11-172-148/+22
| | | | | | | | | TBR=ben@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/11415030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168361 0039d316-1c4b-4281-b951-d872f2087c98
* Lose chrome/renderer/prerender/prerendering_support.*gavinp@chromium.org2012-10-254-103/+56
| | | | | | | | | | | | | | | | | Move the prerendering_support. functionality into the prerender dispatcher, which is the logical place to handle messages from either the browser or WebKit. This is being done in preparation for adding events on prerenders, which require more connection between the WebKit/browser messaging. There's no test, as this should be refactoring only. BUG=none R=mmenke@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11288002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163960 0039d316-1c4b-4281-b951-d872f2087c98
* WebMediaPlayerImpl needs to own the audio source provider.rtoy@google.com2012-07-162-0/+4
| | | | | | | | | | | | WebMediaPlayerImpl needs to own the audio source provider to keep it from being destroyed too soon. BUG=132890 TEST=See test in bug report. Review URL: https://chromiumcodereview.appspot.com/10662030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146897 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-116-6/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Rename IPC Sender and Listener in ppapi, content/public, and content/rendererbrettw@chromium.org2012-06-201-0/+1
| | | | | | | | | | | This is the new name in preparation for deleting the backwards-compatible typedef. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10532162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143282 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare PrerenderWebMediaPlayer for CORS support addition in WebKit.fischman@chromium.org2012-06-072-6/+11
| | | | | | | | | BUG=123369 TEST=PrerenderBrowserTest.PrerenderHTML5VideoNetwork passes again Review URL: https://chromiumcodereview.appspot.com/10540053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141027 0039d316-1c4b-4281-b951-d872f2087c98
* Add an OWNERS file for chrome/renderer/prerender.gavinp@chromium.org2012-05-251-0/+4
| | | | | | | | | | | | There's enough renderer-side for Prerendering that we should make sure there's prerender reviewer coverage for changes there. BUG=None Review URL: https://chromiumcodereview.appspot.com/10441017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139126 0039d316-1c4b-4281-b951-d872f2087c98
* Adding unit tests for PrerenderDispatcher.dominich@chromium.org2012-05-242-0/+128
| | | | | | | | | | BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10424002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138877 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in PrerenderDispatcher.gavinp@chromium.org2012-05-232-3/+15
| | | | | | | | | | | Make the PrerenderingInterface into a scoped pointer. BUG=127953 Review URL: https://chromiumcodereview.appspot.com/10391134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138494 0039d316-1c4b-4281-b951-d872f2087c98
* New link rel=prerender api, using WebKit::WebPrerenderingPlatformgavinp@chromium.org2012-05-117-0/+211
| | | | | | | | | | | | | | | This patch implements the renderer side classes corresponding to https://bugs.webkit.org/show_bug.cgi?id=85005 , and adds messaging up to the browser process for link prerender events. A new PrerenderLinkManager is introduced to handle these events for the LinkManager. BUG=84236 Review URL: https://chromiumcodereview.appspot.com/10198040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136611 0039d316-1c4b-4281-b951-d872f2087c98
* Prerendered pages are swapped in at browser::Navigate time. cbentzel@chromium.org2012-03-094-5/+106
| | | | | | | | | | | | | | | | | | They used to get swapped in by observing provisional loads. This is being changed to Navigate so renderer-issued navigations into a prerender can be handled with the same mechanism that is used to handle renderer-issued navigations which need to cross process boundaries, such as clicking into a hosted app. For browser issued navigations, this means that we will immediately swap in the prerender, instead of sending a Navigate message to the render view and swapping in on the provisional load statement. For renderer issued navigations, decidePolicyForNavigation will ultimately cancel the navigation in the renderer and send an OpenURL up to the browser process. In order to make the renderer know that a navigation could be prerendered, a set of prerendered URLs need to be sent to a render process. BUG=104493 TEST=Existing browser tests, manual tests that omnibox prerenders work. There should be no user-visible changes. Review URL: http://codereview.chromium.org/9623018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125836 0039d316-1c4b-4281-b951-d872f2087c98
* Fold media::PipelineImpl into media::Pipeline as there is only one ↵scherkus@chromium.org2012-01-181-1/+1
| | | | | | | | | | implementation of the interface. Three years ago I thought that having a separate interface would be A Good Thing. Needless to say there has never been a case where having an interface defintion of Pipeline came in handy as all clients create and access PipelineImpl objects directly. Review URL: http://codereview.chromium.org/9243025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118082 0039d316-1c4b-4281-b951-d872f2087c98
* Fold WebMediaPlayerImpl::Initialize() into the constructor.scherkus@chromium.org2012-01-132-3/+6
| | | | | | | | | | | OverrideCreateWebMediaPlayer() was simplified to return a pointer instead of relying on a bool+out-param since unlike OverrideCreatePlugin() we don't require blocking creation of media players. BUG=109958 Review URL: http://codereview.chromium.org/9187045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117607 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate HTMLMediaElement with Web Audio API's MediaElementAudioSourceNode ↵crogers@google.com2012-01-072-0/+3
| | | | | | | | | | | | | | (take 2) RenderAudioSourceProvider implements WebKit::WebAudioSourceProvider using AudioRendererImpl BUG=none TEST=none (tested locally) Original Code Review: http://codereview.chromium.org/8980008/ Review URL: http://codereview.chromium.org/9122009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116778 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 116643 - Integrate HTMLMediaElement with Web Audio API's ↵msw@chromium.org2012-01-062-3/+0
| | | | | | | | | | | | | | | | MediaElementAudioSourceNode RenderAudioSourceProvider implements WebKit::WebAudioSourceProvider using AudioRendererImpl BUG=none TEST=none (tested locally) Review URL: http://codereview.chromium.org/8980008 TBR=crogers@google.com Review URL: http://codereview.chromium.org/9121001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116647 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate HTMLMediaElement with Web Audio API's MediaElementAudioSourceNodecrogers@google.com2012-01-062-0/+3
| | | | | | | | | | | RenderAudioSourceProvider implements WebKit::WebAudioSourceProvider using AudioRendererImpl BUG=none TEST=none (tested locally) Review URL: http://codereview.chromium.org/8980008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116643 0039d316-1c4b-4281-b951-d872f2087c98
* Link rel=prefetch was disabled during prerender development; for nowgavinp@chromium.org2011-12-271-2/+2
| | | | | | | | | | | | | | let's turn it back on and see if it's a useful intermediate between preconnect and prerendering. This is the first of two CLs, this one renames the existing field trial, the next CL will actually flip the switch and add prefetch historgrams. BUG=107897 Review URL: http://codereview.chromium.org/8965032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115832 0039d316-1c4b-4281-b951-d872f2087c98
* Defer loading of audio/video tags while prerendering.shishir@chromium.org2011-12-094-14/+132
| | | | | | | | | | BUG=98690 TEST= Review URL: http://codereview.chromium.org/8095007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113742 0039d316-1c4b-4281-b951-d872f2087c98
* chrome.loadTimes() shouldn't be affected by in-document navigation.simonjam@chromium.org2011-11-171-5/+5
| | | | | | | | | | | | | | | | Data that's only pertinent to initially loading the document is stored in LoadTimes. These are carried over when the NavigationState changes due to in-document navigation. I'd be interested in feedback on the position of LoadTimes. I'm not happy with it. I'd prefer to have it on WebDataSource, but I expect NavigationState was hidden in ExtraData for a reason. This also impacts PLT histograms. In-document navigation is the cause of some of the missing start types. So, by fixing this, we should get more complete page load data. There are probably whole classes of sites where we have no PLT data, such as Google Docs. BUG=79078 TEST=ui_tests Review URL: http://codereview.chromium.org/8404018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110392 0039d316-1c4b-4281-b951-d872f2087c98
* Make RenderView inherit from content::RenderView, and add missing functions ↵jam@chromium.org2011-10-102-12/+11
| | | | | | | | | to the interface. In a future change I'll rename RenderView to RenderViewImpl. BUG=98716 Review URL: http://codereview.chromium.org/8201029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104727 0039d316-1c4b-4281-b951-d872f2087c98
* Move NavigationState to content\public\renderer and put it in the content ↵jam@chromium.org2011-10-041-1/+3
| | | | | | | | | namespace. BUG=98716 Review URL: http://codereview.chromium.org/8114019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103826 0039d316-1c4b-4281-b951-d872f2087c98
* Move RenderViewObserver and RenderViewObserverTracker to ↵jam@chromium.org2011-10-032-6/+7
| | | | | | | | | content\public\renderer and put them in the content namespace. BUG=98716 Review URL: http://codereview.chromium.org/8124001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103758 0039d316-1c4b-4281-b951-d872f2087c98
* Prefix all IPC messages used by src\chrome with Chrome. For e.g ↵ananta@chromium.org2011-08-191-2/+2
| | | | | | | | | | | | | | | ChromeViewMsg_, ChromeViewHostMsg, etc. This makes it easier to identify which messages are specific to content and chrome. This is a preparation CL for bug http://code.google.com/p/chromium/issues/detail?id=87335 which requires IPC's to not span across content and chrome. When IPC's cross these boundaries they need to be handled as API calls. BUG=87335 Review URL: http://codereview.chromium.org/7631063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97536 0039d316-1c4b-4281-b951-d872f2087c98
* Fix visibility state of prerendered pages openedmmenke@chromium.org2011-06-302-0/+15
| | | | | | | | | | | | | in a new background tab not updating. Also adds a couple tests for the visibility API. BUG=87926 TEST=PrerenderBrowserTest.PrerenderVisibilityBackgroundTab, PrerenderBrowserTest.PrerenderVisibilityForegroundTab, PrerenderBrowserTest.PrerenderVisibility Review URL: http://codereview.chromium.org/7282013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91182 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member variables.jhawkins@chromium.org2011-06-211-1/+2
| | | | | | | | | | | | | CID=6462,16139,16144,16145,16233,16322,16402,16421,16422,16423,16660,16663, 16942,17035,17118,17120,17144,17243,17266,17267,17268 BUG=none TEST=none R=kmadhusu@chromium.org Review URL: http://codereview.chromium.org/7206047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89894 0039d316-1c4b-4281-b951-d872f2087c98
* Using the "prerender" state as the page visibility value when a page is inshishir@chromium.org2011-06-072-2/+2
| | | | | | | | | | | | | prerender mode. BUG=None TEST=None Review URL: http://codereview.chromium.org/7054064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88117 0039d316-1c4b-4281-b951-d872f2087c98
* Add one-time randomization support for FieldTrial, and the ability tojoi@chromium.org2011-05-101-2/+1
| | | | | | | | | | | | | | | | | | | | | | | disable field trials. I am going to have a need for both soon. Update some documentation about empty trial names, add TrialExists() method and update many call-sites to use this (it simplifies the previous logic which checked for existence and then for non-empty name, which can no longer happen). Refactor a bit in browser_main. While I'm in there and needing base/OWNERS approval, add an OWNERS file for base/metrics that adds jar@chromium.org as an owner for that directory. Initially committed as r84197. Rolled back due to DCHECK in official builds, r84373. Will re-submit with fix. BUG=81750 TEST=base_unittests Review URL: http://codereview.chromium.org/6883102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84801 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 84197 - Add one-time randomization support for FieldTrial, and the ↵joi@chromium.org2011-05-061-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | ability to disable field trials. I am going to have a need for both soon. Cleaning up some comments about empty trial names, adding static method TrialExists() and simplifying many call sites by using this method. While I'm in there and needing base/OWNERS approval, add an OWNERS file for base/metrics that adds jar@chromium.org as an owner for that directory. BUG=none TEST=base_unittests TBR=jam@chromium.org R=jar@chromium.org,phajdan.jr@chromium.org,mark@chromium.org,wtc@chromium.org Reason for revert: See http://crbug.com/81750 BUG=81750 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/6931048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84373 0039d316-1c4b-4281-b951-d872f2087c98
* Add one-time randomization support for FieldTrial, and the ability tojoi@chromium.org2011-05-051-2/+1
| | | | | | | | | | | | | | | | | | disable field trials. I am going to have a need for both soon. Cleaning up some comments about empty trial names, adding static method TrialExists() and simplifying many call sites by using this method. While I'm in there and needing base/OWNERS approval, add an OWNERS file for base/metrics that adds jar@chromium.org as an owner for that directory. BUG=none TEST=base_unittests TBR=jam@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84197 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 10:56:08 +0000