summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/render_thread.cc
Commit message (Collapse)AuthorAgeFilesLines
* Merge 34534 - Mac: make it even less likely that the renderer+Breakpad leaks ↵viettrungluu@chromium.org2009-12-151-0/+17
| | | | | | | | | | | | | | | | | | Mach ports. SuicideOnChannelErrorFilter::OnChannelError() does get called under certain (unknown) circumstances, with some regularity. This causes a leak of a Mach port when used with Breakpad. BUG=28547 TEST=See bug. Review URL: http://codereview.chromium.org/500010 TBR=viettrungluu@chromium.org,mark@chromium.org,jrg@chromium.org Review URL: http://codereview.chromium.org/501016 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@34537 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 32698 - Turn on HTML5 DBs by default.dumi@chromium.org2009-11-231-1/+1
| | | | | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/414048 TBR=dumi@chromium.org Review URL: http://codereview.chromium.org/437022 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@32875 0039d316-1c4b-4281-b951-d872f2087c98
* Revert changes that moved spellchecker to renderer for 249 branch since ↵estade@chromium.org2009-11-181-45/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | there were some crashes and pulling in the fixes is hard. This reverts: ------------------------------------------------------------------------ r31875 | estade@chromium.org | 2009-11-12 17:36:50 -0800 (Thu, 12 Nov 2009) | 4 lines Use renderer spellchecker for windows. BUG=25677 Review URL: http://codereview.chromium.org/372075 ------------------------------------------------------------------------ r31529 | estade@chromium.org | 2009-11-09 17:33:05 -0800 (Mon, 09 Nov 2009) | 8 lines Couple of prospective fix for memory test flakiness: addref/release the url request context getter appropriately; fix a leak. Passing as a straight pointer without addreffing was copied from the previous spellchecker impl. Using .release() instead of = NULL was a plain old mistake. BUG=none TEST=memory test flakiness goes away hopefully? Review URL: http://codereview.chromium.org/379015 ------------------------------------------------------------------------ r31199 | estade@chromium.org | 2009-11-05 19:05:46 -0800 (Thu, 05 Nov 2009) | 28 lines Move the spellchecker to the renderer. The motivation is that this removes the sync IPC on every call to the spellchecker. Also, currently we spellcheck in the IO thread, which frequently needs to go to disk (in particular, the entire spellcheck dictionary starts paged out), so this will block just the single renderer when that happens, rather than the whole IO thread. This breaks the SpellChecker class into two new classes. 1) On the browser side, we have SpellCheckHost. This class handles browser-wide tasks, such as keeping the custom words list in sync with the on-disk custom words dictionary, downloading missing dictionaries, etc. On Posix, it also opens the bdic file since the renderer isn't allowed to open files. SpellCheckHost is created and destroyed on the UI thread. It is initialized on the file thread. 2) On the renderer side, SpellChecker2. This class will one day be renamed SpellChecker. It handles actual checking of the words, memory maps the dictionary file, loads hunspell, etc. There is one SpellChecker2 per RenderThread (hence one per render process). My intention is for this patch to move Linux to this new approach, and follow up with ports for Windows (which will involve passing a dictionary file name rather than a file descriptor through to the renderer) and Mac (which will involve adding sync ViewHost IPC callsfor when the platform spellchecker is enabled). Note that anyone using the platform spellchecker rather than Hunspell will get no benefit out of this refactor. There should be no loss of functionality for Linux (or any other platform) in this patch. The following should all still work: - dictionary is loaded lazily - hunspell is initialized lazily, per renderer - language changes work. - Dynamic downloading of new dictionaries - auto spell correct works (as well as toggling it). - disabling spellcheck works. - custom words work (including adding in one renderer and immediately having it take effect in other renderers, for certain values of "immediate") TODO: - move spellchecker unit tests to test SpellCheck2 - add sync IPC for platform spellchecker; port to Mac - add dictionary location fallback; port to Windows - remove SpellChecker classes from browser/ BUG=25677 Review URL: http://codereview.chromium.org/357003 git-svn-id: svn://svn.chromium.org/chrome/branches/249/src@32436 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31999 - Enable HTML5 DBs by default (except in incognito mode).dumi@chromium.org2009-11-141-1/+1
| | | | | | | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/397001 TBR=michael@chromium.org Review URL: http://codereview.chromium.org/397004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32001 0039d316-1c4b-4281-b951-d872f2087c98
* Enable HTML5 DBs by default (except in incognito mode).dumi@chromium.org2009-11-141-1/+1
| | | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/397001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31999 0039d316-1c4b-4281-b951-d872f2087c98
* Remove (actually, reverse meaning of) command line flag for desktop ↵johnnyg@chromium.org2009-11-141-2/+2
| | | | | | | | | | | | | notifications, so that is is available by default in Windows. Security review at http://b/issue?id=2161143 BUG=25975 TEST=none Review URL: http://codereview.chromium.org/391064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31990 0039d316-1c4b-4281-b951-d872f2087c98
* Use renderer spellchecker for windows.estade@chromium.org2009-11-131-2/+4
| | | | | | | BUG=25677 Review URL: http://codereview.chromium.org/372075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31875 0039d316-1c4b-4281-b951-d872f2087c98
* Upstreaming WebKit.gypyaar@chromium.org2009-11-121-11/+11
| | | | | | | | | | | | This mega patch contains a few simple but tightly dependent changes: 1. Deletion of webkit/api/WebKit.gyp. The file now lives in webkit.org. 2. Rename of webkit/webkit.gyp to webkit/webkit_glue.gyp. Having two webkit.gyp was a source of developer confusion. 3. Gyp dependencies are updated across chromium to point at the upstream WebKit.gyp and the renamed webkit_glue.gyp. 4. Some 200+ files include paths fixed to point to third_party/WebKit/WebKit/chromium instead of webkit/api. The later will be deleted in a subsequent patch. Review URL: http://codereview.chromium.org/387020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31749 0039d316-1c4b-4281-b951-d872f2087c98
* A large number of style nits in preparation for turning on automated cpplint.py.erg@google.com2009-11-111-5/+5
| | | | | | Review URL: http://codereview.chromium.org/385023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31669 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a 'V8' column to task manager to track amount of memory in JavaScript heapjamesr@chromium.org2009-11-111-0/+10
| | | | | | | | | BUG=27226 TEST=open task manager, enable column, compare with V8 heap profiler Review URL: http://codereview.chromium.org/377037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31641 0039d316-1c4b-4281-b951-d872f2087c98
* Change application cache cmd line enabling to use the new ↵jennb@chromium.org2009-11-071-0/+3
| | | | | | | | | | | RuntimeEnabledFeatures code. TEST=none BUG=none Review URL: http://codereview.chromium.org/377002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31349 0039d316-1c4b-4281-b951-d872f2087c98
* Turn LocalStorage on by default.jorlow@chromium.org2009-11-061-1/+1
| | | | | | | | | TEST=none BUG=4360 Review URL: http://codereview.chromium.org/366032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31256 0039d316-1c4b-4281-b951-d872f2087c98
* Move the spellchecker to the renderer.estade@chromium.org2009-11-061-0/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The motivation is that this removes the sync IPC on every call to the spellchecker. Also, currently we spellcheck in the IO thread, which frequently needs to go to disk (in particular, the entire spellcheck dictionary starts paged out), so this will block just the single renderer when that happens, rather than the whole IO thread. This breaks the SpellChecker class into two new classes. 1) On the browser side, we have SpellCheckHost. This class handles browser-wide tasks, such as keeping the custom words list in sync with the on-disk custom words dictionary, downloading missing dictionaries, etc. On Posix, it also opens the bdic file since the renderer isn't allowed to open files. SpellCheckHost is created and destroyed on the UI thread. It is initialized on the file thread. 2) On the renderer side, SpellChecker2. This class will one day be renamed SpellChecker. It handles actual checking of the words, memory maps the dictionary file, loads hunspell, etc. There is one SpellChecker2 per RenderThread (hence one per render process). My intention is for this patch to move Linux to this new approach, and follow up with ports for Windows (which will involve passing a dictionary file name rather than a file descriptor through to the renderer) and Mac (which will involve adding sync ViewHost IPC callsfor when the platform spellchecker is enabled). Note that anyone using the platform spellchecker rather than Hunspell will get no benefit out of this refactor. There should be no loss of functionality for Linux (or any other platform) in this patch. The following should all still work: - dictionary is loaded lazily - hunspell is initialized lazily, per renderer - language changes work. - Dynamic downloading of new dictionaries - auto spell correct works (as well as toggling it). - disabling spellcheck works. - custom words work (including adding in one renderer and immediately having it take effect in other renderers, for certain values of "immediate") TODO: - move spellchecker unit tests to test SpellCheck2 - add sync IPC for platform spellchecker; port to Mac - add dictionary location fallback; port to Windows - remove SpellChecker classes from browser/ BUG=25677 Review URL: http://codereview.chromium.org/357003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31199 0039d316-1c4b-4281-b951-d872f2087c98
* Enable WebSockets by defaultukai@chromium.org2009-11-051-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/360007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31083 0039d316-1c4b-4281-b951-d872f2087c98
* Switch over to the new way of enabling/disabling session/local storage. jorlow@chromium.org2009-11-051-0/+5
| | | | | | | | BUG=none TEST=|'localStorage' in window| should only be true iff --enable-local-storage is specified Review URL: http://codereview.chromium.org/335034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31082 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the URL portion of storage events. This is mostly just plumbing + a ↵jorlow@chromium.org2009-11-051-1/+1
| | | | | | | | | | | | | hack for making them work in test shell and single process mode. This replaces http://codereview.chromium.org/335034/show TEST=none BUG=24581 Review URL: http://codereview.chromium.org/363014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31081 0039d316-1c4b-4281-b951-d872f2087c98
* First half of http://codereview.chromium.org/274014/showjorlow@chromium.org2009-11-041-7/+6
| | | | | | | | | | | | This fixes storage events in single process mode, fixes a bug due to the glue/webkitclient_impl not being updated when I introduced quota support, introduces a params struct for storage events, and is general cleanup. Submitting this first since the change to add the url param made things bigger than I liked. TBR=darin TEST=none BUG=25427 Review URL: http://codereview.chromium.org/348071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30945 0039d316-1c4b-4281-b951-d872f2087c98
* Purge memory for DBs in the renderer process.pkasting@chromium.org2009-11-021-5/+15
| | | | | | | | BUG=23400 TEST=none Review URL: http://codereview.chromium.org/350012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30723 0039d316-1c4b-4281-b951-d872f2087c98
* Change notification cmd line enabling to use the new RuntimeEnabledFeatures ↵johnnyg@chromium.org2009-10-311-0/+6
| | | | | | | | | | | code. BUG=25318 TEST=none Review URL: http://codereview.chromium.org/339093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30660 0039d316-1c4b-4281-b951-d872f2087c98
* Move various runtime enabled features into a WebRuntimeFeatures class.darin@chromium.org2009-10-301-6/+8
| | | | | | | | | | | | There are separate functions to set/test each feature. R=jorlow BUG=25286 TEST=none Review URL: http://codereview.chromium.org/343001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30564 0039d316-1c4b-4281-b951-d872f2087c98
* WebSocket support in chromium.ukai@chromium.org2009-10-291-0/+4
| | | | | | | | | | | Run with --enable-web-sockets enables WebSocket features. BUG=12497 TEST=none Review URL: http://codereview.chromium.org/292044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30440 0039d316-1c4b-4281-b951-d872f2087c98
* Implementing WebDatabaseObserver in the renderer process.dumi@chromium.org2009-10-241-0/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/293038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29993 0039d316-1c4b-4281-b951-d872f2087c98
* Instructing V8 to disable the binding for the window.openDatabase()dumi@chromium.org2009-10-241-0/+3
| | | | | | | | | | | | function. BUG=none TEST=none Review URL: http://codereview.chromium.org/295053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29980 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce WebScriptController for script related methods.mhm@chromium.org2009-10-231-26/+38
| | | | | | | | | | | Made it into a class with static methods. BUG=24602 TEST=Compiled Webkit/Chromium and Try Bot'd Review URL: http://codereview.chromium.org/308015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29912 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce WebSecurityPolicy for security related methods.mhm@chromium.org2009-10-221-4/+6
| | | | | | | | | | | | | | | | | Move security related methods out of WebKit.h into its own class WebSecurityPolicy. This involves these functions: - registerURLSchemeAsLocal - registerURLSchemeAsNoAccess - whiteListAccessFromOrigin - resetOriginAccessWhiteLists BUG=24601 TEST=Compiled locally, try bot'ed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29639 Review URL: http://codereview.chromium.org/293021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29758 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 29747 - Switch over to the new way of enabling/disabling ↵nsylvain@chromium.org2009-10-221-5/+0
| | | | | | | | | | | | | | | session/local storage. BUG=none TEST=|'localStorage' in window| should only be true iff enablelocalstorage is specified Review URL: http://codereview.chromium.org/293032 TBR=jorlow@chromium.org Review URL: http://codereview.chromium.org/315009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29754 0039d316-1c4b-4281-b951-d872f2087c98
* Switch over to the new way of enabling/disabling session/local storage.jorlow@chromium.org2009-10-221-0/+5
| | | | | | | | | | BUG=none TEST=|'localStorage' in window| should only be true iff --enable-local-storage is specified Review URL: http://codereview.chromium.org/293032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29747 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: darinmhm@chromium.org2009-10-211-6/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29642 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce WebSecurityPolicy for security related methods.mhm@chromium.org2009-10-211-4/+6
| | | | | | | | | | | | | | | Move security related methods out of WebKit.h into its own class WebSecurityPolicy. This involves these functions: - registerURLSchemeAsLocal - registerURLSchemeAsNoAccess - whiteListAccessFromOrigin - resetOriginAccessWhiteLists BUG=24601 TEST=Compiled locally, try bot'ed. Review URL: http://codereview.chromium.org/293021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29639 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: change PIDs to base::ProcessId (or pid_t, as appropriate).viettrungluu@chromium.org2009-10-201-1/+1
| | | | | | | | | | | We probably want to discourage the use of ints for PIDs. This is a start; there are many other places where we should fix this. BUG=25272 TEST=none Review URL: http://codereview.chromium.org/300010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29511 0039d316-1c4b-4281-b951-d872f2087c98
* add enableWebSockets in WebKit APIukai@chromium.org2009-10-201-0/+3
| | | | | | | | | | | | and remove experimentalWebSocketsEnabled from WebPreferences/Settings. Patch for http://bugs.webkit.org/show_bug.cgi?id=29896 will remove Settings::experimentalWebSocketsEnabled(), so we need to remove it from WebPreferences too. This is because such configuration in Settings confuses other WebKit developers and such control is only required for chromium. Instead add WebKit::enableWebSockets() in this change to control WebSockets feature. Review URL: http://codereview.chromium.org/292012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29497 0039d316-1c4b-4281-b951-d872f2087c98
* Delete glue/webview{_delegate}.hdarin@chromium.org2009-10-191-2/+3
| | | | | | | | | | R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/293001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29390 0039d316-1c4b-4281-b951-d872f2087c98
* Move scripting / v8 related methods out of WebKit.hmhm@chromium.org2009-10-161-0/+1
| | | | | | | | | BUG=24602 TEST=Compiled Webkit/Chromium Review URL: http://codereview.chromium.org/275026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29245 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Move scripting / v8 related methods out of WebKit.h"tony@chromium.org2009-10-161-1/+0
| | | | | | | | | | This reverts commit r29218. TBR=mhm Review URL: http://codereview.chromium.org/283004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29225 0039d316-1c4b-4281-b951-d872f2087c98
* Move scripting / v8 related methods out of WebKit.hmhm@chromium.org2009-10-161-0/+1
| | | | | | | | | BUG=24602 TEST=Compiled Webkit/Chromium Review URL: http://codereview.chromium.org/275026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29218 0039d316-1c4b-4281-b951-d872f2087c98
* Add functionality to the renderer thread to purge memory. Not yet called.pkasting@chromium.org2009-10-081-0/+32
| | | | | | | | BUG=23400 TEST=none Review URL: http://codereview.chromium.org/267021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28415 0039d316-1c4b-4281-b951-d872f2087c98
* Display tcmalloc debug output from renderer processes in about:tcmalloc.sgk@chromium.org2009-10-081-0/+16
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/255080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28384 0039d316-1c4b-4281-b951-d872f2087c98
* Put headers in right order. Ensure WebKit is initialized everywhere ↵pkasting@chromium.org2009-10-081-7/+5
| | | | | | | | | | necessary. Remove unnecessary V8::IsDead() check (IdleNotification() already checks IsRunning(), which is mutually exclusive with IsDead()). BUG=none TEST=none Review URL: http://codereview.chromium.org/265019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28360 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 1.3.15.sgjesse@chromium.org2009-10-071-1/+1
| | | | | | | | | | | | | This change contails the layout test expectation changes from http://codereview.chromium.org/248001 and http://codereview.chromium.org/251071 as the V8 update requires these. This change also contains a change to compile against the changes IdleNotification API in the new V8 version. BUG=none TEST=none TBR=ager@chromium.org Review URL: http://codereview.chromium.org/263008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28246 0039d316-1c4b-4281-b951-d872f2087c98
* Another stab at the Chromium side of storage events. Re-submission of ↵jorlow@chromium.org2009-10-031-0/+16
| | | | | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=27756 with slight changes in dom_storage_dispatch er_host.cc TBR=darin TEST=Manually inspected that storage events fired. Will turn on more layout tests in a subsequent patch. BUG=19972 Original review URL: http://codereview.chromium.org/223013 Review URL: http://codereview.chromium.org/258010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27943 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27756.jorlow@chromium.org2009-10-011-16/+0
| | | | | | Review URL: http://codereview.chromium.org/249058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27759 0039d316-1c4b-4281-b951-d872f2087c98
* Another stab at the Chromium side of storage events. The WebKit side can be ↵jorlow@chromium.org2009-10-011-0/+16
| | | | | | | | | | | found here: https://bugs.webkit.org/show_bug.cgi?id=29655 TEST=Manually inspected that storage events fired. Will turn on more layout tests in a subsequent patch. BUG=19972 Review URL: http://codereview.chromium.org/223013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27756 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback Scavenge implemetation and rely on existing functionality to freejar@chromium.org2009-10-011-2/+2
| | | | | | | | | | | | | | This is a landing of a patch provided by antonm. See: http://codereview.chromium.org/235022 Also included change to browser_about_handler.cc to fix build, and I set TCMALLOC_RELEASE_RATE to 1.0 on line 40 of page_heap.cc (I think this was an inadvertent rollback element). r=antonm Review URL: http://codereview.chromium.org/257009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27692 0039d316-1c4b-4281-b951-d872f2087c98
* Fix deadlock when plugin puts an alert and right afterwards the browser ↵jam@chromium.org2009-09-281-10/+2
| | | | | | | | | | process makes a win32 call that ends up waiting on the plugin. Since the plugin thread is blocked, the Windows message doesn't get dispatched and the browser ui thread deadlocks. The message from the renderer would make the plugin run a nested message loop but it doesn't get run on the browser ui thread since it's blocked. The fix is to set the event that runs nested message loop in the renderer process. BUG=23147 TEST=ui tests already cover nested message loops and plugins. This particular scenario is hard to write a test case for because it's a race condition involving the browser. Review URL: http://codereview.chromium.org/243018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27421 0039d316-1c4b-4281-b951-d872f2087c98
* Implement about:ipc dialog for Mac.jrg@chromium.org2009-09-281-0/+5
| | | | | | | | | Convert IPC logging trigger from x-process waitable event to a messages sent to all processes. Review URL: http://codereview.chromium.org/192070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27405 0039d316-1c4b-4281-b951-d872f2087c98
* Implementing chrome.i18n.getMessage call, that loads message from the ↵cira@chromium.org2009-09-281-0/+9
| | | | | | | | | | | | | | | | | | | extension catalog, and if necessary replaces placeholders (up to 9). I have 3 forms of getMessage call: getMessage("name") for simple messages without placeholders. getMessage("name", "one param") for messages with only one placeholder. getMessage("name", ["one", "two"]) for messages with only one or more placeholders. getMessage returns string. BUG=12131 TEST=Load samples/i18n extension (switch Chrome to sr locale) and observe ext. name, description and toolstrip texts should be in Serbian. Review URL: http://codereview.chromium.org/225009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27393 0039d316-1c4b-4281-b951-d872f2087c98
* Update renderer plugin cache when we load/unload extensions with plugins.mpcomplete@chromium.org2009-09-211-2/+2
| | | | | | | | | BUG=12306 TEST=Load and unload extensions that contain plugins and visit pages that use them. Also covered by tests. Review URL: http://codereview.chromium.org/201111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26748 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 172109: Enable scavenging in RenderThread::IdleHandler.agl@chromium.org2009-09-151-18/+22
| | | | | | | | | | | | Landing of Anton Muhin's patch (antonm@google.com) (Reland. First landed in r26264, reverted in r26276. This reland hopefully doesn't build tcmalloc on Linux.) Review URL: http://codereview.chromium.org/206017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26298 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Issue 172109: Enable scavenging in RenderThread::IdleHandler."agl@chromium.org2009-09-151-22/+18
| | | | | | | This reverts commit r26264. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26276 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 172109: Enable scavenging in RenderThread::IdleHandler.mbelshe@google.com2009-09-151-18/+22
| | | | | | | | | | | | Landing of Anton Muhin's patch (antonm@google.com) BUG=none TEST=none Review URL: http://codereview.chromium.org/206017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26264 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-17 20:44:56 +0000