summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/render_view.cc
Commit message (Collapse)AuthorAgeFilesLines
* Clean up unnecessary includes in render_view.ccbrettw@chromium.org2009-02-061-2/+0
| | | | | | Review URL: http://codereview.chromium.org/24005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9347 0039d316-1c4b-4281-b951-d872f2087c98
* Reference and create a RenderView when needed.jrg@chromium.org2009-02-061-4/+16
| | | | | | | | | This initiates the landslide of linker hell in Chromium.app, bringing in webkit, v8, and the kitchen sink. Review URL: http://codereview.chromium.org/21123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9335 0039d316-1c4b-4281-b951-d872f2087c98
* Finish taking out render_messages.h includes from headers.jam@chromium.org2009-02-051-3/+4
| | | | | | Review URL: http://codereview.chromium.org/20072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9209 0039d316-1c4b-4281-b951-d872f2087c98
* Commiting the changes from my previous cl that are specific to not including ↵jam@chromium.org2009-02-041-6/+1
| | | | | | | | | | render_messages.h/plugin_message.h unless necessary. TBR=mpcomplete Review URL: http://codereview.chromium.org/20059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9189 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my change to get the tree green. Not sure why the tests became ↵jam@chromium.org2009-02-041-1/+6
| | | | | | | | | | flaky. I'll try to check them in again but in smaller chunks tomorrow. TBR=mpcomplete Review URL: http://codereview.chromium.org/21039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9132 0039d316-1c4b-4281-b951-d872f2087c98
* Make it easier/less work/less error-prone to create new IPC channel types ↵jam@chromium.org2009-02-041-6/+1
| | | | | | | | (i.e. renderer/plugin).Instead of having each message file include the internal one several times with different ifdefs, move that logic to ipc_message_macros.h. Also make the message class starting IDs come from an enum to ensure we don't use a value twice. I simplified the logging code a bit so we don't need X_messages.cc files.Clean up places that we were doing manual packing/unpacking. Most of this was in the automation code. I added a few new template functions to make it convenient to read the parameters from a message, and updated the code to use them.I also removed unnecessary includes of render/plugin_messages.h from headers to speed up compiling.I moved the traits of IPC structs beside the struct definition to make it more apparent what's going on, so we avoid people modifying the struct and forgetting to update the traits.Amit: please look at chrome/test/automation/tab_proxy.ccMarc-Antoine: chrome/browser/printing/*Matt: the rest Review URL: http://codereview.chromium.org/20015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9123 0039d316-1c4b-4281-b951-d872f2087c98
* Merged with latest media pipeline and cleaned up some style stuff.hclam@chromium.org2009-02-031-1/+1
| | | | | | | | Changed WebMediaPlayerDelegateImpl to contains a PipelineImpl object rather keeping a pointer to Pipeline interface. Also added code for task coordination between pipeline thread and main thread. Review URL: http://codereview.chromium.org/19481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9069 0039d316-1c4b-4281-b951-d872f2087c98
* Change chrome:// to chrome-ui://, fix up one chrome-resource:// reference.glen@chromium.org2009-01-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/18175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8896 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land revision 8821 with the ui test fixed.maruel@chromium.org2009-01-291-25/+4
| | | | | | | | | | Disconnect the "browser controlled printing" and always delegate the control flow to the renderer. Simplify the tests by not using a message loop anymore. Followup changes will remove more parts that are not needed anymore. Review URL: http://codereview.chromium.org/19460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8886 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back r8821mark@chromium.org2009-01-281-4/+25
| | | | | | Review URL: http://codereview.chromium.org/19453 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8834 0039d316-1c4b-4281-b951-d872f2087c98
* Disconnect the "browser controlled printing" and always delegate the control ↵maruel@chromium.org2009-01-281-25/+4
| | | | | | | | | flow to the renderer. Followup changes will remove more parts that are not needed anymore. Review URL: http://codereview.chromium.org/18860 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8821 0039d316-1c4b-4281-b951-d872f2087c98
* Context menus for text selections in editable boxes and links should include ↵pkasting@chromium.org2009-01-281-2/+2
| | | | | | | | the Search menu item. Original patch by Brian Duff (see http://codereview.chromium.org/16510 ), r=me. BUG=1925 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8815 0039d316-1c4b-4281-b951-d872f2087c98
* Remove extraneous uses of the --enable-user-scriptaa@chromium.org2009-01-281-11/+6
| | | | | | | | | | switch. It's better to check this at one chokepoint (initialization) and let the rest of the code work the same, but end up as no-ops. Review URL: http://codereview.chromium.org/18401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8800 0039d316-1c4b-4281-b951-d872f2087c98
* Rolback r8793: Remove extraneous uses of the --enable-user-scriptmal@chromium.org2009-01-281-6/+11
| | | | | | | | | | | | | switch. It's better to check this at one chokepoint (initialization) and let the rest of the code work the same, but end up as no-ops. This seems to break ui_tests. Review URL: http://codereview.chromium.org/19418 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8794 0039d316-1c4b-4281-b951-d872f2087c98
* Remove extraneous uses of the --enable-user-scriptaa@chromium.org2009-01-281-11/+6
| | | | | | | | | | switch. It's better to check this at one chokepoint (initialization) and let the rest of the code work the same, but end up as no-ops. Review URL: http://codereview.chromium.org/18401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8793 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: gfx::NativeViewId and CrossProcessEventagl@chromium.org2009-01-271-22/+8
| | | | | | | | | | | | | | | | | | | Create a couple new typedefs for porting work. Firstly, gfx::NativeViewId is a handle to a platform specific widget in the renderer process. For Windows, this is just a HWND as before. However, in other platforms the ids used in the renderer process will be something else. CrossProcessEvent is the type of a HANDLE to a Windows event object which is used across processes. Since we aren't going to support these sorts of events on non-Windows platforms, this will have to go away at some point. For now, however, this lets us build code without too many ifdefs all over the place. Review URL: http://codereview.chromium.org/18768 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8756 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Make render_view_host compile on Mac & Linux, add to the build."agl@chromium.org2009-01-261-4/+3
| | | | | | | Review URL: http://codereview.chromium.org/18796 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8683 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the build.brettw@chromium.org2009-01-261-3/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8681 0039d316-1c4b-4281-b951-d872f2087c98
* Link Doctor is expecting the query param connectionfailure, nottc@google.com2009-01-261-1/+1
| | | | | | | | | | | connectionerror. BUG=1599954 Review URL: http://codereview.chromium.org/18811 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8659 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: Porting renderer/render_view.cc, low hanging fruitagl@chromium.org2009-01-221-20/+146
| | | | | | | Review URL: http://codereview.chromium.org/18468 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8440 0039d316-1c4b-4281-b951-d872f2087c98
* Make CommandLine into a normal object, with some statics for getting at the ↵evan@chromium.org2009-01-211-3/+3
| | | | | | | | | | | current process's command line. One explicit goal of this change is to *not* deal with the string/wstring issues at the API on POSIX; the functions are the same as before, which means they remain as broken as before. (I did try to fix the internals, though, so migrating the callers is now possible by adding platform-appropriate hooks.) Review URL: http://codereview.chromium.org/18248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8347 0039d316-1c4b-4281-b951-d872f2087c98
* First pass as implementing the greasemonkey API. This patchaa@chromium.org2009-01-171-1/+3
| | | | | | | | | | | | | | | | | | | includes a javascript file with stubbed versions of all the greasemoney API methods as well as changes to the Greasemonkey slave to inject this javascript file along with other user scripts into the page.I also have a userscript I'm using for the unit testing of the API methods. I don't think there is a good place for it in the chrome tree (if there is I'd like to know), but you can view it here: http://skrul.com/greasemonkey/test.user.js Right now all the tests fail except for testLog and testUnsafeWindow. Review URL: http://codereview.chromium.org/18183 Patch from Steve Krulewitz <skrulx@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8247 0039d316-1c4b-4281-b951-d872f2087c98
* WaitableEvent is the replacement for Windows events. Previously in the code, ↵agl@chromium.org2009-01-151-8/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | a HANDLE from CreateEvent was used for signaling, both within a process and across processes. WaitableEvent is the cross platform replacement for this. To convert: * HANDLE -> base::WaitableEvent* * ScopedHandle -> scoped_ptr<base::WaitableEvent> * CreateEvent -> new base::WaitableEvent * SetEvent -> base::WaitableEvent::Signal * ResetEvent -> base::WaitableEvent::Reset * ObjectWatcher -> base::WaitableEventWatcher * WaitForMultipleObjects -> static base::WaitableEvent::WaitMany ObjectWatcher remains for Windows specific code. WaitableEventWatcher has an identical interface save, * It uses WaitableEvents, not HANDLEs * It returns void from StartWatching and StopWatcher, rather than errors. System internal errors are fatal to the address space IMPORTANT: There are semantic differences between the different platforms. WaitableEvents on Windows are implemented on top of events. Windows events work across process and this is used mostly for modal dialog support. Windows events can be duplicated with DuplicateHandle. On other platforms, WaitableEvent works only within a single process. In the future we shall have to replace the current uses of cross-process events with IPCs. BEWARE: HANDLE, on Windows, is a void *. Since any pointer type coerces to void *, you can pass a WaitableEvent * where a HANDLE is expected without any build-time errors. Review URL: http://codereview.chromium.org/16554 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8126 0039d316-1c4b-4281-b951-d872f2087c98
* Updating so that Gears can spawn file selectors when running in the renderer ↵zork@google.com2009-01-131-4/+9
| | | | | | | | process Review URL: http://codereview.chromium.org/14907 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7986 0039d316-1c4b-4281-b951-d872f2087c98
* This is a rename of the term 'Greasemonkey' to 'user script' in Chromium.aa@chromium.org2009-01-091-8/+8
| | | | | | | | | | | I'm doing this to avoid confusion with the Firefox version of Greasemonkey and also because 'user script' is really the correct generic term. At the same time, I also moved user_script_master* into extensions/ because I want these two pieces to get closer and closer such that standalone user scripts are just a very small extension. Also extensions will be relying on most of the user script code. Review URL: http://codereview.chromium.org/17281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7827 0039d316-1c4b-4281-b951-d872f2087c98
* The popup for autofill is now never activated, even when clicked.jcampan@chromium.org2009-01-091-2/+2
| | | | | | | | | | | | | This allows us to hide it when the page loses focus. (doing that previously would have caused the popup to be hidden before the click in the popup was sent to the renderer). Most of the file changes are just renaming focus_on_show to activatable. TEST=Open a form and make an autofill popup. Focus another window, the popup should disappear. Ensure the autofill still work properly, and the combo-box as well. BUG=3844,5830 Review URL: http://codereview.chromium.org/17455 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7823 0039d316-1c4b-4281-b951-d872f2087c98
* Move plugins to FilePaths, some cleanupavi@google.com2009-01-061-4/+5
| | | | | | Review URL: http://codereview.chromium.org/16456 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7588 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an uninitialized memory read that purify exposed.brettw@chromium.org2009-01-051-6/+7
| | | | | | Review URL: http://codereview.chromium.org/16520 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7568 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the render widget unittest so it can be reused to create a render viewbrettw@chromium.org2009-01-051-40/+46
| | | | | | | | | | | | | | | | | unit test. Change the mock render thread to save all IPC messages it is asked to send so that tests can verify that the correct ones were sent. There are some new functions that support this checking. Plumb the form state change notification through the render view so that we will correctly update the form state to the browser. Write two RenderView unit tests. One arbitrarily tests OnLoadAlternateHTMLText which I used as a testcase for my testing framework. The other tests the above form state change notification. I had to expose the timeout of this message through the RenderView API so that the test can change it. Review URL: http://codereview.chromium.org/16482 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7549 0039d316-1c4b-4281-b951-d872f2087c98
* Make the global render thread object a regular global object rather than abrettw@google.com2008-12-181-8/+8
| | | | | | | | | | | special TLS value. This is slightly faster for this commonly-used function, and we don't ever have more than one (it's like this because we were originally planning on having more than one RenderThread). BUG=5635 Review URL: http://codereview.chromium.org/15052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7272 0039d316-1c4b-4281-b951-d872f2087c98
* Bridge out media player from MediaPlayerPrivate.hclam@chromium.org2008-12-181-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove MediaPlayerPrivateChromium.cpp and move it to webkit/glue/media_player_private_impl.cc - Added the following classes: WebMediaPlayer WebMediaPlayerImpl WebMediaPlayerDelegate WebMediaPlayerDelegateImpl TestWebMediaPlayerDelegate VideoStackMediaPlayer (Just a forward declaration) - One include fix for webkit/glue/webframe.h - Overview of what each class is doing: WebMediaPlayer and WebMediaPlayerImpl Wrapper over the MediaPlayerPrivate, it provides methods like Repaint(), NotifyNetworkStateChange(), etc to VideoStackMediaPlayer. It also creates the ResourceHandle for VideoStackMediaPlayer for resource loading, or maybe VideoStackMediaPlayer can simply use webkit_glue::ResourceDispatcher? WebMediaPlayerDelegate, WebMediaPlayerDelegateImpl Delegate calls from webkit to the internal media player. MediaPlayerPrivate Forward calls to WebMidiaPlayerDelegate, creates WebMediaPlayerDelegate and WebMediaPlayer in the constructor. Expose some public methods to WebMediaPlayer so we can actually do repaint and notification of changes. Review URL: http://codereview.chromium.org/13762 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7256 0039d316-1c4b-4281-b951-d872f2087c98
* Move the "platform" wrappers in skia/ext to the skia namespace.brettw@google.com2008-12-171-4/+4
| | | | | | Review URL: http://codereview.chromium.org/14110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7182 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Enable spell check for this field" menu option in sub context menu for ↵sidchat@google.com2008-12-151-0/+10
| | | | | | | | context menu over text box, and deploy its functionality accordingly across the code. This patch also allows manual switch-on of spell check in single line text box fields. Review URL: http://codereview.chromium.org/13731 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7000 0039d316-1c4b-4281-b951-d872f2087c98
* Move Image operations and convolver to the skia namespace and clean up a few ↵brettw@google.com2008-12-121-2/+2
| | | | | | | | (but not all) base types. Review URL: http://codereview.chromium.org/13726 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6921 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 6709,6708,6706.brettw@google.com2008-12-101-2/+2
| | | | | | Review URL: http://codereview.chromium.org/13345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6710 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base dependency from image_operations and associated unittests. I ↵brettw@google.com2008-12-101-2/+2
| | | | | | | | | also renamed the namespace from "gfx" to "skia". This also adds back the image_operations_unittest to a project (this had gotten lost in my move). Review URL: http://codereview.chromium.org/13143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6706 0039d316-1c4b-4281-b951-d872f2087c98
* Reupload of 12418glen@chromium.org2008-12-071-1/+1
| | | | | | Review URL: http://codereview.chromium.org/13183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6497 0039d316-1c4b-4281-b951-d872f2087c98
* Move convolver and image_operations from base/gfx to skia/ext. This is justbrettw@google.com2008-12-031-1/+1
| | | | | | | | like my previous change except does no namespace renaming and doesn't touch skia_utils. Review URL: http://codereview.chromium.org/13080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6290 0039d316-1c4b-4281-b951-d872f2087c98
* Revert my skia file moves because of layout test failures.brettw@google.com2008-12-031-3/+4
| | | | | | Review URL: http://codereview.chromium.org/12892 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6266 0039d316-1c4b-4281-b951-d872f2087c98
* Move convolver, image_operations, and skia_utils from base/gfx to skia/ext.brettw@google.com2008-12-021-4/+3
| | | | | | | | | | | This changes the namespace in those files from "gfx" to "skia". I split skia_utils into two parts, the Windows specific part is now in a separate file called skia_utils_win. There were several obsolete includes of these headers which I removed. I also removed img_resize_perftest which isn't used and has bitrotted. Review URL: http://codereview.chromium.org/12842 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6248 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the URL and title from the state getting functions and IPC messages.brettw@google.com2008-12-021-11/+5
| | | | | | | If the title or URL changes, we'll be updated in other ways, so this extra processing is wasted. Review URL: http://codereview.chromium.org/12859 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6225 0039d316-1c4b-4281-b951-d872f2087c98
* Fix window.open()/window.close() regression by disabling window.close() ↵erg@google.com2008-12-011-1/+18
| | | | | | | | | | | until a message comes back from the Browser thread saying that it's OK to allow javascript close calls. ISSUE=http://crbug.com/4007 Review URL: http://codereview.chromium.org/12691 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6165 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply 5971 which was reverted in 5974. The unit test wasn't unregistering ↵maruel@chromium.org2008-12-011-0/+1
| | | | | | | | the observer correctly. Review URL: http://codereview.chromium.org/12474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6142 0039d316-1c4b-4281-b951-d872f2087c98
* src/webkit side of webKit merge 38653:38729ojan@google.com2008-11-271-1/+1
| | | | | | Review URL: http://codereview.chromium.org/12708 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6081 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 5971.maruel@chromium.org2008-11-251-1/+0
| | | | | | Review URL: http://codereview.chromium.org/12637 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5974 0039d316-1c4b-4281-b951-d872f2087c98
* Add superficial unit test for PrintJob. That's a start.maruel@chromium.org2008-11-251-0/+1
| | | | | | | | Add more DCHECKs. Same as r5607 except that Thread.StopSoon is fixed. Review URL: http://codereview.chromium.org/11534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5971 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the WebRequest API to consistently use std::string instead ofdarin@chromium.org2008-11-251-4/+4
| | | | | | | | | | | | | | | | | | | std::wstring for HTTP header fields The HTTP specification guarantees that all fields in the header will be ASCII and thus fit fine in a std::string. The GetHttpHeaders/SetHttpHeaders interfaces use std::string values for HTTP headers. This patch fixes GetHttpMethod(), SetHttpMethod(), GetHttpHeaderValue() and SetHttpHeaderValue() and callers to use std::string as well. Patch by James Robinson <jamesr@google.com> R=darin Review URL: http://codereview.chromium.org/12412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5955 0039d316-1c4b-4281-b951-d872f2087c98
* Find now uses WebKit's TextMatch highlighting for Find-in-page.finnur@google.com2008-11-241-10/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows us to discard a bunch of code and plumbing related to maintaining and passing around the tickmark vector. WebKit now owns the drawing of the highlights for inactive matches and we use the selection controller to draw the active highlight. I also simplified the code by eliminating the separate FindNext function, which has been merged into Find. This change also requires minor changes to WebKit upstream (sold seperately, void where prohibited). It simply consists of adding one empty virtual paint function to ScrollbarThemeComposite.h (paintTickmarks) and in ScrollbarThemeComposite::paint call paintTickmarks(). This fixes/makes obsolete a slew of bugs: BUG=1326399, 1241554,1143991, 1070190, 1023019, 984786, 893737, 868599 ... and a couple of external ones as well. Full list: 1326399 Find highlighting disappears on ThinkPad x60s 1241554 Find doesn't highlight word inside blinky tag 1143991 Have find-in-page code use skia and have inspected node highlighting set the right xfermode 1070190 Find should begin searching from caret/selection 1023019 Find not highlighting correctly 984786 Find highlight drawing code causes ClearType text to look bad 893737 Find in page should search textareas 868599 Find in page tick marks incorrectly appear on nested scrollbars 298 Find-In-page should highlight elided entries 4389 Find-in-box is not highlighting all the instances of the search word 3908 Find in page highlighting and tickmarks are broken Review URL: http://codereview.chromium.org/11364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5946 0039d316-1c4b-4281-b951-d872f2087c98
* Don't save state when the page ID doesn't change.brettw@google.com2008-11-241-2/+9
| | | | | | | | http://code.google.com/p/chromium/issues/detail?id=4684 Review URL: http://codereview.chromium.org/12613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5942 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base versions of the graphics headers, which previously just ↵brettw@google.com2008-11-221-2/+2
| | | | | | | | forwarded to the skia ones. Review URL: http://codereview.chromium.org/11588 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5894 0039d316-1c4b-4281-b951-d872f2087c98