| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason: It broke the Win Builder (dbg)(shared), aka. shared_library bot.
Search for defaultMaxLength on:
http://build.chromium.org/p/chromium/builders/Win%20Builder%20(dbg)(shared)/builds/9/steps/compile/logs/stdio
Review URL: http://codereview.chromium.org/5770002
BUG=none
TEST=none
TBR=isherman@chromium.org
Review URL: http://codereview.chromium.org/5891003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To print the character code, we should cast the wchar_t to an int.
The code currently happens to work because we don't compile with -fshort-wchars,
and thus wchar_t is four bytes, which coincides with what %d in the
snprintf format string expects. However, it's not portable, and Clang
complains about this.
BUG=none
TEST=browser_tests --gtest_filter=RenderViewTest.OnHandleKeyboardEvent
Review URL: http://codereview.chromium.org/5755005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5770002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
fields one at a time.
BUG=63437, 62638
TEST=unit_tests --gtest_filter=AutoFillManagerTest.*
Review URL: http://codereview.chromium.org/5334005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ensures that the fix for WebKit bug 48809 works in Chrome.
Also re-enables a UI test that failed after a partial fix.
BUG=58082, 62156
TEST=RenderViewTest.LastCommittedUpdateState
TEST=SessionHistoryTest.FragmentBackForward
Review URL: http://codereview.chromium.org/4444001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63440
TEST=browser_tests --gtest_filter=FormManagerTest.*
Review URL: http://codereview.chromium.org/5137004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3588011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is that string16 is a typedef for a std::basic_string with a custom base::char_traits, hence ADL looks for operator<< only in std and base, not in the global namespace. Since adding stuff to the global namespace isn't permitted, move the operator to namespace base instead.
Also give WebString an explicit operator<< because clang can't figure out that it can use WebString's |operator string16| to print WebStrings.
string16 is just wstring on windows, and gtest has special code to make printing wstrings to non-wide ostreams work already, so nothing is required on windows.
Fix a few other minor issues.
Based on a patch by hans@chromium.org
BUG=57294
TEST=still compiles with gcc, fewer build errors in tests with clang
Review URL: http://codereview.chromium.org/3515003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=56246
TEST=none
TBR=jorlow
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change adds default constructors to ViewHostMsgs defined in 'chrome/common/render_messages_params.h' to prevent its variables from being used uninitialized, and adds destructors to prevent compilers from synthesizing them when including the header file. This change also removes code that inserts constants to the structs because we do not need it any more.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3252001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original message:
"""
Move the keyboard files from base/ to app/.
Also moves the associated classes/enums from base:: to app::.
TEST=try bots compile
BUG=NONE
Review URL: http://codereview.chromium.org/3165064
"""
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3354005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/ to app/.
Also moves the associated classes/enums from base:: to app::.
TEST=try bots compile
BUG=NONE
Review URL: http://codereview.chromium.org/3165064
TBR=bryeung@chromium.org
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3361003
TBR=bryeung@chromium.org
Review URL: http://codereview.chromium.org/3337006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also moves the associated classes/enums from base:: to app::.
TEST=try bots compile
BUG=NONE
Review URL: http://codereview.chromium.org/3165064
TBR=bryeung@chromium.org
TBR=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/3361003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also moves the associated classes/enums from base:: to app::.
TEST=try bots compile
BUG=NONE
Review URL: http://codereview.chromium.org/3165064
TBR=bryeung@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also moves the associated classes/enums from base:: to app::.
TEST=try bots compile
BUG=NONE
Review URL: http://codereview.chromium.org/3165064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also IsPageTranslatable was moved to TranslateHelper as it is where it belongs.
BUG=51454
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/3236008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For example, there are differences between unit_tests and browser_tests,
which cause ridiculous problems when moving a test between those.
We're using the symbols anyway, so let's centralize it for maintainability.
TEST=compile
BUG=none
Review URL: http://codereview.chromium.org/3173044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- FormManagerTest.LabelsInferredFromParagraph
- RenderViewTest.OnHandleKeyboardEvent
TBR=dhollowa
TEST=browser_tests
BUG=52643, 52731
Review URL: http://codereview.chromium.org/3152051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
TEST=browser_tests
BUG=53247
Review URL: http://codereview.chromium.org/3141040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=rohitrao
Review URL: http://codereview.chromium.org/3110036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
to avoid crashes.
TBR=dhollowa, sky, erikkay
TEST=unit_tests, browser_tests
BUG=52731, 52643
Review URL: http://codereview.chromium.org/3150034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57236 0039d316-1c4b-4281-b951-d872f2087c98
|