| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The renderer sandbox breaks the Chinese Handwriting shortcut while Chrome
is running, even when Chrome is not active: In a nutshell, Carbon tries to load
the IME in every process, and if that fails, it uninstalls the toggle shorcut. It
fails in the renderer process due to the sandbox. See the bug for details.
Prewarming (patch set 1) doesn't work because that opens up clipboard
access to the renderer – the IME doesn't load correctly if it doesn't have
clipboard access.
dyld __interpose based interposing (patch set 2) doesn't work because
TISCreateInputSourceList and its broken caller are in the same
framework (HIToolbox).
Hence, use binary rewriting to return an arbitrary array with size > 0 to make
HIToolbox believe that the IME loads correctly, so that it doesn't uninstall the
global handwriting keyboard shortcut (only on >= 10.6).
BUG=31225
TEST=Enable Chinese in the input menu. Make sure Chrome's not running.
Note that ctrl-shift-space opens and dismisses the Handwriting IME
(you need a multitouch trackpad for that). Open Chrome, note that the
IME still works.
(If you run Chrome without this patch, the IME will be broken until you do
ps aux | grep Chinese
and then
kill $CHINESE_HANDWRITING_PID
and then toggle the IME once through the Menu Extra menu.)
It is a good idea to have a Terminal open during testing, because killing
the task is the only way to dismiss the IME with the keyboard without this
CL.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81308
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81332
Review URL: http://codereview.chromium.org/6801056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
regression in vm_size_final_r on Mac 10.5 only: http://build.chromium.org/f/chromium/perf/mac-release-10.5/intl2/report.html?history=150&rev=-1&graph=vm_size_final_r]
Revert 81332 - Mac: Let chrome coexist with the Chinese Handwriting IME.The renderer sandbox breaks the Chinese Handwriting shortcut while Chromeis running, even when Chrome is not active: In a nutshell, Carbon tries to loadthe IME in every process, and if that fails, it uninstalls the toggle shorcut. Itfails in the renderer process due to the sandbox. See the bug for details.Prewarming (patch set 1) doesn't work because that opens up clipboardaccess to the renderer - the IME doesn't load correctly if it doesn't haveclipboard access.dyld __interpose based interposing (patch set 2) doesn't work becauseTISCreateInputSourceList and its broken caller are in the sameframework (HIToolbox).Hence, use binary rewriting to return an arbitrary array with size > 0 to makeHIToolbox believe that the IME loads correctly, so that it doesn't uninstall theglobal handwriting keyboard shortcut.BUG=31225TEST=Enable Chinese in the input menu. Make sure Chrome's not running.Note that ctrl-shift-space opens and dismisses the Handwriting IME(you need a multitouch trackpad for that). Open Chrome, note that theIME still works.(If you run Chrome without this patch, the IME will be broken until you do ps aux | grep Chineseand then kill $CHINESE_HANDWRITING_PIDand then toggle the IME once through the Menu Extra menu.)It is a good idea to have a Terminal open during testing, because killingthe task is the only way to dismiss the IME with the keyboard without thisCL.Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81308Review URL: http://codereview.chromium.org/6801056
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/6836022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The renderer sandbox breaks the Chinese Handwriting shortcut while Chrome
is running, even when Chrome is not active: In a nutshell, Carbon tries to load
the IME in every process, and if that fails, it uninstalls the toggle shorcut. It
fails in the renderer process due to the sandbox. See the bug for details.
Prewarming (patch set 1) doesn't work because that opens up clipboard
access to the renderer – the IME doesn't load correctly if it doesn't have
clipboard access.
dyld __interpose based interposing (patch set 2) doesn't work because
TISCreateInputSourceList and its broken caller are in the same
framework (HIToolbox).
Hence, use binary rewriting to return an arbitrary array with size > 0 to make
HIToolbox believe that the IME loads correctly, so that it doesn't uninstall the
global handwriting keyboard shortcut.
BUG=31225
TEST=Enable Chinese in the input menu. Make sure Chrome's not running.
Note that ctrl-shift-space opens and dismisses the Handwriting IME
(you need a multitouch trackpad for that). Open Chrome, note that the
IME still works.
(If you run Chrome without this patch, the IME will be broken until you do
ps aux | grep Chinese
and then
kill $CHINESE_HANDWRITING_PID
and then toggle the IME once through the Menu Extra menu.)
It is a good idea to have a Terminal open during testing, because killing
the task is the only way to dismiss the IME with the keyboard without this
CL.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=81308
Review URL: http://codereview.chromium.org/6801056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Handwriting IME.The renderer sandbox breaks the Chinese Handwriting shortcut while Chromeis running, even when Chrome is not active: In a nutshell, Carbon tries to loadthe IME in every process, and if that fails, it uninstalls the toggle shorcut. Itfails in the renderer process due to the sandbox. See the bug for details.Prewarming (patch set 1) doesn't work because that opens up clipboardaccess to the renderer – the IME doesn't load correctly if it doesn't haveclipboard access.dyld __interpose based interposing (patch set 2) doesn't work becauseTISCreateInputSourceList and its broken caller are in the sameframework (HIToolbox).Hence, use binary rewriting to return an arbitrary array with size > 0 to makeHIToolbox believe that the IME loads correctly, so that it doesn't uninstall theglobal handwriting keyboard shortcut.BUG=31225TEST=Enable Chinese in the input menu. Make sure Chrome's not running.Note that ctrl-shift-space opens and dismisses the Handwriting IME(you need a multitouch trackpad for that). Open Chrome, note that theIME still works.(If you run Chrome without this patch, the IME will be broken until you do ps aux | grep Chineseand then kill $CHINESE_HANDWRITING_PIDand then toggle the IME once through the Menu Extra menu.)It is a good idea to have a Terminal open during testing, because killingthe task is the only way to dismiss the IME with the keyboard without thisCL.Review URL: http://codereview.chromium.org/6801056
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/6839001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The renderer sandbox breaks the Chinese Handwriting shortcut while Chrome
is running, even when Chrome is not active: In a nutshell, Carbon tries to load
the IME in every process, and if that fails, it uninstalls the toggle shorcut. It
fails in the renderer process due to the sandbox. See the bug for details.
Prewarming (patch set 1) doesn't work because that opens up clipboard
access to the renderer – the IME doesn't load correctly if it doesn't have
clipboard access.
dyld __interpose based interposing (patch set 2) doesn't work because
TISCreateInputSourceList and its broken caller are in the same
framework (HIToolbox).
Hence, use binary rewriting to return an arbitrary array with size > 0 to make
HIToolbox believe that the IME loads correctly, so that it doesn't uninstall the
global handwriting keyboard shortcut.
BUG=31225
TEST=Enable Chinese in the input menu. Make sure Chrome's not running.
Note that ctrl-shift-space opens and dismisses the Handwriting IME
(you need a multitouch trackpad for that). Open Chrome, note that the
IME still works.
(If you run Chrome without this patch, the IME will be broken until you do
ps aux | grep Chinese
and then
kill $CHINESE_HANDWRITING_PID
and then toggle the IME once through the Menu Extra menu.)
It is a good idea to have a Terminal open during testing, because killing
the task is the only way to dismiss the IME with the keyboard without this
CL.
Review URL: http://codereview.chromium.org/6801056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make all histogram macros thread safe, and fast by again
using statics to achieve performance.
...at the cost of:
Leak all histograms to avoid races at shutdown.
Also included leak suppression for valgrind.
r=rtenneti
BUG=78207
Review URL: http://codereview.chromium.org/6780035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Clean up gfx NativeThemeLinux/Chromeos code to use ResourceBundle.
This should also fix valgrind failures in issue 77712 and 77721.
- Remove no longer needed gfx_module and gfx_resource_provider files.
- Update linux/chromeos test_shell and DumpRenderTree to use
ResourceBundle as well.
BUG=77712,77721
TEST=Build should pass and valgrind failure in issue 77712 and 77721 should be gone.
Review URL: http://codereview.chromium.org/6773021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
raw_scoped_refptr_mismatch_checker.h
ref_counted.cc
ref_counted.h
ref_counted_memory.cc
ref_counted_memory.h
ref_counted_unittest.cc
scoped_callback_factory.h
scoped_comptr_win.h
scoped_handle.h
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_nsobject.h
scoped_open_process.h
scoped_ptr.h
scoped_ptr_unittest.cc
scoped_temp_dir.cc
scoped_temp_dir.h
scoped_temp_dir_unittest.cc
scoped_vector.h
singleton.h
singleton_objc.h
singleton_unittest.cc
linked_ptr.h
linked_ptr_unittest.cc
weak_ptr.cc
weak_ptr.h
weak_ptr_unittest.cc
BUG=None
TEST=Compile
Review URL: http://codereview.chromium.org/6714032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
being initialized. Also moved Mac one-time renderer initialization code into the same location, instead of RenderView's constructor.
Review URL: http://codereview.chromium.org/6718008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6670029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Since we don't have a need for a chrome/gpu or chrome/plugin directory, their chrome implementations are in chrome/common. Use the renderer one for getting the sad plugin image.
Review URL: http://codereview.chromium.org/6708013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
thread.
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78511
Review URL: http://codereview.chromium.org/6670029
TBR=bryner@chromium.org
Review URL: http://codereview.chromium.org/6677107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78511
Review URL: http://codereview.chromium.org/6670029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
thread.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6670029
TBR=bryner@chromium.org
Review URL: http://codereview.chromium.org/6665062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6670029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
for moving worker code.
TBR=avi
Review URL: http://codereview.chromium.org/6685027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=avi
Review URL: http://codereview.chromium.org/6686002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6667024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=none
Review URL: http://codereview.chromium.org/6635046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
See also https://bugs.webkit.org/show_bug.cgi?id=55453
for WebKit side of the change.
BUG=chromium-os:11699
TEST=manually
Review URL: http://codereview.chromium.org/6592065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71063
TEST=compiled
Review URL: http://codereview.chromium.org/6312156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move linux web widgets painting code from webkit;
- Move dependent resources from webkit_resources into gfx_resources and
follow the pattern in net package to add resource loading support to
gfx package;
- Update ChromeOS theme engine to follow mocks in chromium-os:9256.
BUG=chromium-os:9256
TEST=Verify default web widgets has desired look on ChromeOS.
Review URL: http://codereview.chromium.org/6254004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests are (usually) monitored for a fixed length of time. With this change
field trial tests turn them selves off (will use the default group) after
the expiration time (specified in the Field Trial constructor).
BUG=13463
TEST=field_trial_unittests tests this code thorougly. spdy session and testing
field_trials in renderer process would be very helpful. thanks much.
Review URL: http://codereview.chromium.org/6317004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
src/chrome/common.
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6361002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
reflect the move. Consolidate how we DEPS in WebKit source files. Cross fingers.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move HiResTimerManager to src/chrome/common.
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6361002
TBR=ben@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move HiResTimerManager to src/chrome/common.
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6361002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
location and namespace.
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were a few race conditions where the static method would test the validity of the hitograms_ static variable before attempting to use the lock_ to protect access to it but nothing then prevented the destructor to free both the lock_ and the hitograms_ memory.
So I decided to not use a dynamic allocation of the static lock_ to resolve this problem.
BUG=38354
TEST=Hard to repro exit scenario crashes.
Review URL: http://codereview.chromium.org/5784005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sandbox config allows everything for now; I will put in restrictions in a follow-up CL (which should be small).
This CL should have no visible effect (other than changing a few LOG(WARNING) to LOG(ERROR)).
BUG=48607
TEST=GPU process still works
Review URL: http://codereview.chromium.org/5491001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
single-process mode.
BUG=None
TEST=Make sure select and autofill/autocomplete popups work
on Mac and other platforms.
Review URL: http://codereview.chromium.org/5160001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The select popup on Mac was based on a hack: we would create an invisible RenderWidget and redirect mouse and keyboard events to it and we would display a native Cocoa menu. With this CL we do not use a RenderWidget anymore, we send the user selection to the RenderView which in turns communicates to WebKit that selection.
BUG=None
TEST=On Mac, ensures the select popup works as expected. Also test that for an extension with a browser action containing a select popup, the select popup does work. Also ensures autocomplete/autofill still works (especially popups).
Original review:
http://codereview.chromium.org/3795006/show
Review URL: http://codereview.chromium.org/4078003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base::debug namespace.
This splits apart debug_util into base/debugger and base/stack_trace
There are still two functions in debug_util that I'm not sure what to do with.
Since this uses the base::debug namespace, I removed the functions in
debugger.h from the static class and just made them free functions in the
namespace.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3945002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3908005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move scoped_aedesc from base to base/mac
Use namespace and proper Google-style class naming.
TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3828009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
put them in the base namespace.
TEST=it compiles
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to help measure and track performance.
Bug=51638
Review URL: http://codereview.chromium.org/3152001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3057033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit r54966.
Meant to try it, not commit it, sorry everyone. :(
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3057033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3066014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Before we carefully used the app (Chrome/Chromium) name, but:
1) these are for internal debugging use only, so why compute this name
2) on Linux the thread ids are limited to 16 characters, and "Chromium"
is too long
Review URL: http://codereview.chromium.org/2741003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Querying the plugin path and actual mime type is moved from creation of the
WebPluginDelegate to creation of the WebPlugin. This cleaned up some code.
R=jam
BUG=45289
TEST=none
Review URL: http://codereview.chromium.org/2262002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Command line looks like this:
chrome.exe --register-pepper-plugins="c:\foo\bar.dll;application/x-bar"
This causes the registered plugins to be loaded on startup before the sandbox
is engaged. As a result, registered plugins can function within the sandbox.
R=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2104002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
errors, i.e. CHECK(false). Also enable tests to make sure we assert/crash as expected.
BUG=none
TEST=Chrome in release mode generates crash dumps when CHECK() fails. See UI tests: AssertionTest.*:CheckFalseTest.*:RendererCrashTest.*
Review URL: http://codereview.chromium.org/830003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
get called asynchronously when the bits are actually copied to the screen,
rather than synchronously from inside the paint function. This makes it useful
for plugins to use the callback for rate limiting. This also adds a lot of
infrastructure for running tests on pepper devices, and includes a unit test
for the new flush behavior. I made the existing RenderProcess object an
abstract interface and made the existing MockProcess (renamed to be more clear)
implement that. This avoids a static cast that would actually crash during a
unit test because some code was hardcoded to expect a RenderProcess object.
This fixes base's IDMap iterator which has apparently never been used for an
IDMap with ownership semantics.
TEST=Unit test included
BUG=none
Original review URL: http://codereview.chromium.org/661124
Review URL: http://codereview.chromium.org/664001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
advertised. It will now
get called asynchronously when the bits are actually copied to the screen,
rather than synchronously from inside the paint function. This makes it useful
for plugins to use the callback for rate limiting.
This also adds a lot of infrastructure for running tests on pepper devices, and
includes a unit test for the new flush behavior.
I made the existing RenderProcess object an abstract interface and made the
existing MockProcess (renamed to be more clear) implement that. This avoids
a static cast that would actually crash during a unit test because some code
was hardcoded to expect a RenderProcess object.
This fixes base's IDMap iterator which has apparently never been used for an
IDMap with ownership semantics.
TEST=Unit test included
BUG=none
Review URL: http://codereview.chromium.org/661124
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/660439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
get called asynchronously when the bits are actually copied to the screen,
rather than synchronously from inside the paint function. This makes it useful
for plugins to use the callback for rate limiting.
This also adds a lot of infrastructure for running tests on pepper devices, and
includes a unit test for the new flush behavior.
I made the existing RenderProcess object an abstract interface and made the
existing MockProcess (renamed to be more clear) implement that. This avoids
a static cast that would actually crash during a unit test because some code
was hardcoded to expect a RenderProcess object.
This fixes base's IDMap iterator which has apparently never been used for an
IDMap with ownership semantics.
TEST=Unit test included
BUG=none
Review URL: http://codereview.chromium.org/661124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test:
1. Build a (branded) Google Chrome.
2. From the command-line, run: "launchctl bslist | wc -l" and note the number.
3. Start Google Chrome on a fresh profile.
4. Once a browser window has opened, do #2 again, and note the number -- it should have increased (by 2).
5. Close the tab, and do #2 again. The number should have decreased by 1.
6. Open tabs, navigate, etc., and do #2 between each stage. Whenever a new (e.g., renderer) process is started, the number should increase (e.g., when you go to a "new" site). When a process is terminated (e.g., you close the last tab for a particular site), the number should decrease.
7. Quit, and do #2 again. Hopefully, the number should be the same as the first time.
(Note: when a renderer crashes, the number will not decrease -- so the number after quitting will not be the same as before starting. This is why this is only a stopgap. For comparison, do this on a branded Google Chrome without this patch; typically, the numbers will not decrease on renderer termination.)
BUG=28547
TEST=See above.
Review URL: http://codereview.chromium.org/484007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not yet for review.
Landing to measure perf impact, will revert immediately.
BUG=13156
TEST=unittests
Review URL: http://codereview.chromium.org/460126
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/466088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34147 0039d316-1c4b-4281-b951-d872f2087c98
|