summaryrefslogtreecommitdiffstats
path: root/chrome/renderer/spellchecker/spellcheck.h
Commit message (Collapse)AuthorAgeFilesLines
* [Spellcheck] Cleanup for async posting of spellcheck requests.groby@chromium.org2012-11-011-19/+11
| | | | | | | | | BUG=154918 Review URL: https://chromiumcodereview.appspot.com/11365021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165460 0039d316-1c4b-4281-b951-d872f2087c98
* Remove hunspell-only code from spellcheck.cc, in preparation of a merge of ↵groby@chromium.org2012-10-301-29/+3
| | | | | | | | | | | | spellcheck.cc and spellcheck_provider.cc TBR=jhawkins@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11264022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164976 0039d316-1c4b-4281-b951-d872f2087c98
* Factored out OSX spelling into a separate subclass.groby@chromium.org2012-10-241-0/+5
| | | | | | | | | | | | Hunspell to follow in later CL, so SpellCheck can become platform-agnostic. R=rlp@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/11237007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163756 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: IWYU for base/time.h. Also fix misc lint errors.thestig@chromium.org2012-10-101-1/+0
| | | | | | | | TBR=ben,brettw,oshima,rdsmith Review URL: https://chromiumcodereview.appspot.com/11087021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160999 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Use grammar markers for contextually-misspelled words.hbono@chromium.org2012-05-281-15/+13
| | | | | | | | | | | This change double-checks misspelled words returned by the Spelling service and adds grammar markers to contextually-misspelled words to visualize differences between local spellchecker and the Spelling service. BUG=107371 TEST=SpellingServiceClientTest.RequestTextCheck, SpellCheckTest.CreateTextCheckingResults Review URL: https://chromiumcodereview.appspot.com/10408058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139223 0039d316-1c4b-4281-b951-d872f2087c98
* This patch implements asynchronous spellchecker on Windows and Linux.shinyak@chromium.org2012-04-191-6/+56
| | | | | | | | | | | | Though Mac already has its own spellchecker, Linux and Windows don't have one. So we have implemented asynchronous spellchecker posting a task. BUG=6424, 111593 TEST=SpellCheckTest.* Review URL: http://codereview.chromium.org/9169082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133029 0039d316-1c4b-4281-b951-d872f2087c98
* Removed WebTextCheckingResult legacy API use.morrita@chromium.org2012-02-171-5/+2
| | | | | | | | | | BUG=none TEST=unit_tests Review URL: http://codereview.chromium.org/9368052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122429 0039d316-1c4b-4281-b951-d872f2087c98
* In http://trac.webkit.org/changeset/105491, WebKit introduced an interface ↵shinyak@chromium.org2012-01-261-1/+14
| | | | | | | | | | | | | | | | WebSpellCheckClient::checkTextOfParagraph to spellcheck. This patch introduces the Chromium side implementation of WebSpellCheckClient::checkTextOfParagraph. This function is currently enabled only when USE_UNIFIED_TEXT_CHECKING is enable. It is currently enabled on Mac Snow Leopard or Lion, though this function will not be used in such ports. I will enable it in chromium port later. BUG=106941 TEST=SpellCheckTest.SpellCheckParagraph* Review URL: http://codereview.chromium.org/8912006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119210 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all usages of FRIEND_TEST() with FRIEND_TEST_ALL_PREFIXES()robertshield@chromium.org2011-11-291-1/+1
| | | | | | | | BUG=105287 TEST=NONE Review URL: http://codereview.chromium.org/8678017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111935 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE to chrome/renderer.avi@chromium.org2011-11-211-1/+1
| | | | | | | | | BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8613004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110942 0039d316-1c4b-4281-b951-d872f2087c98
* Move RenderProcessObserver and RenderViewVisitor to content\public\renderer ↵jam@chromium.org2011-10-031-2/+2
| | | | | | | | | and put them in the content namespace. BUG=98716 Review URL: http://codereview.chromium.org/8116009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103796 0039d316-1c4b-4281-b951-d872f2087c98
* A speculative fix for Bug 92364.hbono@chromium.org2011-09-161-0/+8
| | | | | | | | | | SpellcheckWordIterator::Initialize() may crash in a low-memory situation because this function needs lots of temporal memory to compile a custom word-break rule into a DFA (Deterministic Finite Automaton). As WebKit does, this change reuses the compiled DFA to avoid compiling a custom-word-break rule every time when we check text. BUG=92364 TEST=Spellche kWordIterator::Initialize() does not crash. Review URL: http://codereview.chromium.org/7780030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101462 0039d316-1c4b-4281-b951-d872f2087c98
* Virtual destructors should have virtual keyword.hans@chromium.org2011-05-251-1/+1
| | | | | | | | | | | | | | | | | Make sure user-declared virtual destructors always have the virtual keyword. The Clang style-check plugin will check for this soon. No functionality change: virtual is only added to destructors that are already implicitly virtual. Also fix a couple of in-line destructor definitions. BUG=83408 TEST=none Review URL: http://codereview.chromium.org/7064033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of Chrome specific code out of RenderThread, in preparation of ↵jam@chromium.org2011-04-141-10/+17
| | | | | | | | moving it to content. Review URL: http://codereview.chromium.org/6850003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81614 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 79705 - Revert 79651 - Coverity: Pass parameters by reference.dhollowa@chromium.org2011-03-291-1/+1
| | | | | | | | | | | | | | | | | | | | | Also remove an unused function that I found. CID=2634,4471,5392,6433,6434,6535,6777,6780,6781,6792,6810,7665,7759,8056,8072, 8637,8718,8726 BUG=none TEST=non R=csilv@chromium.org Review URL: http://codereview.chromium.org/6730046 TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/6773015 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/6772013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79714 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 79651 - Coverity: Pass parameters by reference.dhollowa@chromium.org2011-03-291-1/+1
| | | | | | | | | | | | | | | | | | Also remove an unused function that I found. CID=2634,4471,5392,6433,6434,6535,6777,6780,6781,6792,6810,7665,7759,8056,8072, 8637,8718,8726 BUG=none TEST=non R=csilv@chromium.org Review URL: http://codereview.chromium.org/6730046 TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/6773015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79705 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass parameters by reference.jhawkins@chromium.org2011-03-291-1/+1
| | | | | | | | | | | | | | | Also remove an unused function that I found. CID=2634,4471,5392,6433,6434,6535,6777,6780,6781,6792,6810,7665,7759,8056,8072, 8637,8718,8726 BUG=none TEST=non R=csilv@chromium.org Review URL: http://codereview.chromium.org/6730046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79651 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-281-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Integrating Mac OS Grammar checker into Chromium.morrita@chromium.org2011-02-221-0/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6392045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75577 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove "obviously" unneeded standard C++ library #includes.viettrungluu@chromium.org2010-08-151-2/+1
| | | | | | | | | BUG=none TEST=builds Review URL: http://codereview.chromium.org/3179017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56171 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/thestig@chromium.org2010-07-291-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54102 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Move Mac to using renderer spellchecker.estade@chromium.org2009-11-191-0/+3
| | | | | | | | BUG=25677 Review URL: http://codereview.chromium.org/395007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32561 0039d316-1c4b-4281-b951-d872f2087c98
* reland 31875. Revert was:estade@chromium.org2009-11-161-7/+3
| | | | | | | | | | | | | | ------ Revert 31875 to see whether it fixes reliability bot. BUG=25677 TEST=None ------ TBR=huanr Review URL: http://codereview.chromium.org/397017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32112 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31875 to see whether it fixes reliability bot.huanr@chromium.org2009-11-161-3/+7
| | | | | | | | | BUG=25677 TEST=None Review URL: http://codereview.chromium.org/397014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32074 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-131-3/+3
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* Use renderer spellchecker for windows.estade@chromium.org2009-11-131-7/+3
| | | | | | | BUG=25677 Review URL: http://codereview.chromium.org/372075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31875 0039d316-1c4b-4281-b951-d872f2087c98
* Move the spellchecker to the renderer.estade@chromium.org2009-11-061-0/+127
The motivation is that this removes the sync IPC on every call to the spellchecker. Also, currently we spellcheck in the IO thread, which frequently needs to go to disk (in particular, the entire spellcheck dictionary starts paged out), so this will block just the single renderer when that happens, rather than the whole IO thread. This breaks the SpellChecker class into two new classes. 1) On the browser side, we have SpellCheckHost. This class handles browser-wide tasks, such as keeping the custom words list in sync with the on-disk custom words dictionary, downloading missing dictionaries, etc. On Posix, it also opens the bdic file since the renderer isn't allowed to open files. SpellCheckHost is created and destroyed on the UI thread. It is initialized on the file thread. 2) On the renderer side, SpellChecker2. This class will one day be renamed SpellChecker. It handles actual checking of the words, memory maps the dictionary file, loads hunspell, etc. There is one SpellChecker2 per RenderThread (hence one per render process). My intention is for this patch to move Linux to this new approach, and follow up with ports for Windows (which will involve passing a dictionary file name rather than a file descriptor through to the renderer) and Mac (which will involve adding sync ViewHost IPC callsfor when the platform spellchecker is enabled). Note that anyone using the platform spellchecker rather than Hunspell will get no benefit out of this refactor. There should be no loss of functionality for Linux (or any other platform) in this patch. The following should all still work: - dictionary is loaded lazily - hunspell is initialized lazily, per renderer - language changes work. - Dynamic downloading of new dictionaries - auto spell correct works (as well as toggling it). - disabling spellcheck works. - custom words work (including adding in one renderer and immediately having it take effect in other renderers, for certain values of "immediate") TODO: - move spellchecker unit tests to test SpellCheck2 - add sync IPC for platform spellchecker; port to Mac - add dictionary location fallback; port to Windows - remove SpellChecker classes from browser/ BUG=25677 Review URL: http://codereview.chromium.org/357003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31199 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 13:24:07 +0000