| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This works around a bug in the Mac UI message pump (72007) that can lead to starvation
of delayed tasks. To avoid starving WebCore timers indefinitely when using
requestAnimationFrame, this patch explicitly pumps the WebCore Timer queue one each animate() call.
BUG=71735
TEST=open the WebGL aquarium demo (http://webglsamples.googlecode.com/hg/aquarium/aquarium.html) and click on the * next to "Change View". The animation should always happen without multi-second delays.
Review URL: http://codereview.chromium.org/6524030
TBR=jamesr@chromium.org
Review URL: http://codereview.chromium.org/6531009
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@75187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This simplifies the schedule for requestAnimationFrame callbacks and always invokes
the callbacks from the top of DoDeferredUpdate. Also adds a histogram for catch-up
timers so we can more easily quantify the effects of base::Time / base::TimeTicks
skew.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6519005
Needed to ensure that the bugfix for 71735 merges cleanly to the branch.
TBR=jamesr@chromium.org
Review URL: http://codereview.chromium.org/6507021
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@75185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome-extension://.
These checks were causing lots of subtle bugs and fixing them will be difficult to get correct for the upcoming milestone. The checks were originally intended to be an 'extra line of defense' and are not critical for security.
I will reintroduce them separately on trunk.
BUG=72455,72407
Review URL: http://codereview.chromium.org/6478019
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/6502003
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@74631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72437
TEST=see bug for manual test
Review URL: http://codereview.chromium.org/6476006
TBR=bauerb@chromium.org
Review URL: http://codereview.chromium.org/6483014
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@74434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=IndexedDB should not be accessible from the web.
BUG=70378
Review URL: http://codereview.chromium.org/6461004
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@74197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
do some minor test organization.
BUG=57263,71955
TEST=Install https://chrome.google.com/webstore/detail/odmpalfplhaahlgnkkonchfhpegdcgjm and a few apps from the web store. Open popup. Popup should contain icons for each app and should not crash.
Review URL: http://codereview.chromium.org/6410088
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/6246163
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@74064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
checks into renderer. One cannot be moved because we
don't have the bit of state we need in the renderer.
This should have fixed the bug 57263, but it doesn't.
So maybe something else is going on?
BUG=57263
TBR=mpcomplete@chromium.org
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/6410132
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@74060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6383013
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/6286158
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@74057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
renderer processes by sending the full extension object instead.
ExtensionRendererInfo remains, but it is now just a
convenience wrapper around a map of Extension objects.
This allows us to reuse all the helper methods on Extension,
ExtensionIconSet, ExtensionExtent, etc without duplicating
them in the renderer.
Also changed broadcasts to renderers to send only changed
information, not entire set of extension data again.
BUG=70516
Review URL: http://codereview.chromium.org/6242010
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/6368151
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@74056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=try, doesn't crash after exiting chrome while viewing WebGL.
BUG=none
Review URL: http://codereview.chromium.org/6287036
TBR=apatrick@chromium.org
Review URL: http://codereview.chromium.org/6312072
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@73346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Effects of this refactor:
1. The WebPluginInfo now keep information not only if a plugin is disabled but also the reason for that. It can either be user, policy or both. That way we can restore the right value after policies stop to control the feature.
2. Plugins can be correctly enabled and disabled either as a group or separately.
3. The code is cleaner and PluginGroup is not duplicating information from PluginList but stores all needed information and provides it through cleaner interface.
BUG=54681,66505,69374,69148
TEST=Manual for the policy. DefaultPluginUITest.DefaultPluginLoadTest from ui_tests and Plugin* from test_shell_tests.
Review URL: http://codereview.chromium.org/5699005
TBR=pastarmovj@chromium.org
Review URL: http://codereview.chromium.org/6260059
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@73268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I broke them in revision 71992
(http://codereview.chromium.org/6247013/)
BUG=71166
TEST=none
Review URL: http://codereview.chromium.org/6335017
(LGTMed for merge by kerz)
Review URL: http://codereview.chromium.org/6347038
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@73148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=IndexedDB should not be accessible from the web.
BUG=70378
Review URL: http://codereview.chromium.org/6374021
TBR=jorlow@chromium.org
Review URL: http://codereview.chromium.org/6408001
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@73069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It appears that PostDelayedTask on windows is firing a bit earlier than this code expects. This patch adds logic to reschedule a second timer if this occurs and adds a log.
BUG=70992
TEST=manual
Review URL: http://codereview.chromium.org/6391007
TBR=jamesr@chromium.org
Review URL: http://codereview.chromium.org/6376018
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@73057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=IndexedDB should not be accessible from the web.
BUG=70378
Review URL: http://codereview.chromium.org/6374021
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@73041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ensures that if a plugin is removed from the page, or crashes, the renderer doesn't continue to think that it has focus (thus interfering with non-plugin IME).
BUG=70982
TEST=Try to type on a page after a plugin with focus is removed or crashes.
Review URL: http://codereview.chromium.org/6298018
TBR=stuartmorgan@chromium.org
Review URL: http://codereview.chromium.org/6395008
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@72900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make new chrome UI security model the default.
allows us to update URL in chrome://settings when the user navigates within it.
BUG=57485
TEST=manual
Review URL: http://codereview.chromium.org/6240010
TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/6292016
git-svn-id: svn://svn.chromium.org/chrome/branches/648/src@72862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is effectively a pared-down version of the already reviewed:
http://codereview.chromium.org/6308014/
BUG=none
TEST=none
(tested locally for Mac OS X which is the only platform this affects)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac OS X
This is a more limited version of the patch already reviewed here:
http://codereview.chromium.org/6308014/
BUG=none
TEST=none
(tested locally on Mac OS X to verify build and that the feature could be enabled)
Review URL: http://codereview.chromium.org/6388002
TBR=crogers@google.com
Review URL: http://codereview.chromium.org/6271014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a more limited version of the patch already reviewed here:
http://codereview.chromium.org/6308014/
BUG=none
TEST=none
(tested locally on Mac OS X to verify build and that the feature could be enabled)
Review URL: http://codereview.chromium.org/6388002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=rniwa
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows browser tests are failing.
BUG=none
TEST=none
(tested locally on Mac OS X to verify about:flags shows the web audio feature and that it can be enabled/disabled)
Review URL: http://codereview.chromium.org/6339004
TBR=crogers@google.com
Review URL: http://codereview.chromium.org/6364005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
(tested locally on Mac OS X to verify about:flags shows the web audio feature and that it can be enabled/disabled)
Review URL: http://codereview.chromium.org/6339004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the current menu command to whoever opened the custom menu. We have to track
it in a slightly ugly manner thanks to GTK's out-of-order messaging for
"menu item selected" vs. "context menu closed".
BUG=NONE
TEST=manual
Review URL: http://codereview.chromium.org/6278013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
to view it with Adobe Reader if it's installed. If it's not, ask them if they want to launch the url to install it. If it's installed and out of date, show an interstitial.
BUG=65339
Review URL: http://codereview.chromium.org/6259008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a very simple scheduler that targets 100fps.
BUG=64848
TEST=layout tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71909
Review URL: http://codereview.chromium.org/6136005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
paints.
This just intersects the paint rect with the plugin rect (previously we used
the entire plugin rect, even when the paint rect was smaller).
TEST=manual
BUG=none
Review URL: http://codereview.chromium.org/6296010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes IME handling per the recent NPAPI spec clarification, and adds the new bool to indicate conformance to the new model.
Also:
- Fixes an existing bug where the initial key down would be sent to the wrong IME system (since it happens before plugin IME starts) by having the render widget track whether a plugin is focused.
- Changes ComplexTextInputPanel to match recent upstream changes.
BUG=70427
TEST=None (plugins have not yet implemented Cocoa IME).
Review URL: http://codereview.chromium.org/6259013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72190 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKit change http://trac.webkit.org/changeset/76291 may have affected this test.
TBR=brettw
BUG=70408
TEST=BrowserTest: RenderViewTest.OnNavStateChanged
Review URL: http://codereview.chromium.org/6330006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6293007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The feature is now behind --enable-in-browser-thumbnailing flag.
The in-browser thumbnailing works as follows:
- The scroll offset is sent from the renderer to the browser.
- The thumbnail is taken when the page info is sent from the renderer process.
- Since thumbnails are generated in the browser, we can avoid the generation when unnecessary (ex. off-the-record mode, or New Tab Page).
- The quality of thumbnails is as good as before, as the patch doesn't change timing heuristics.
- The drawback is that we cannot take thumbnails from background tabs.
New functions are added to ThumbnailGenerator for clipping thumbnails, with tests.
BUG=65936
TEST=add unit tests for thumbnail_generator. confirmed that the thumbnails are updated with and without --enable-in-browser-thumbnailing
Review URL: http://codereview.chromium.org/6246007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the base namespace. Fix several files including lock.h unnecessarily.
BUG=none
TEST=none
Original review=http://codereview.chromium.org/6142009/
Patch by leviw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
RenderView::OnPrintPreview.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6296018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
a new IPC test_support project that references it.
This is necessary because I want to make a test that uses the sink outside of chrome.
TEST=this is a test
BUG=none
Review URL: http://codereview.chromium.org/6290008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6263008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
If the gpu process dies, CommandBufferProxy might be the first one to find out about it. When the context is being created, GpuChannelHost still thinks there is no error. It will send CreateViewCommandBuffer message to establish a communication channel, which will fail, and GPU process will not restart. To prevent that, we set GpuChannelHost state to lost as soon as CommandBufferProxy finds out about it.
BUG=58785
TEST=open a composited tab, in another tab go to about:gpucrash
Review URL: http://codereview.chromium.org/6384003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
consistent.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6352001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61745
TEST=in progress
Review URL: http://codereview.chromium.org/6247013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The |WebViewClient::didAcceptAutocompleteSuggestion| method is no longer dispatched from the WebKit side, and had been replaced by |WebViewClient::didAcceptAutoFillSuggestion|. The PasswordAutocompleteManager had not been updated to account for this. Those updates are made in this patch. Follow up is to remove the |WebViewClient::didAcceptAutocompleteSuggestion| method from WebKit. Also, the |PasswordAutocompleteManager::FrameClosing| method was not getting properly dispatched to perform cleanup tasks. This is fixed now.
BUG=68681
TEST=PasswordAutocompleteManagerTest.SuggestionSelect
Review URL: http://codereview.chromium.org/6262008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=brettw
Review URL: http://codereview.chromium.org/6257006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Move linux web widgets painting code from webkit;
- Move dependent resources from webkit_resources into gfx_resources and
follow the pattern in net package to add resource loading support to
gfx package;
- Update ChromeOS theme engine to follow mocks in chromium-os:9256.
BUG=chromium-os:9256
TEST=Verify default web widgets has desired look on ChromeOS.
Review URL: http://codereview.chromium.org/6254004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=printing works after code change.
Review URL: http://codereview.chromium.org/6374004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
origin to the server.
This is the chromium side of the webkit patch https://bugs.webkit.org/show_bug.cgi?id=52718.
Suggested reviewer split:
wtc@ - the 2 url_fetcher.* files
hans@ - rest of the files
I needed to add a URLFetcher::set_referrer() method to send the origin url in the Referer header.
Also I had to create a new IPC params struct for startRecognition since the
number of parameters exceed what is provided by the macros. And in the process I also moved
the speech input IPC messages to their own source files.
BUG=none
TEST=No change in functionality except additional debug info sent to server.
Review URL: http://codereview.chromium.org/6308009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a very simple scheduler that targets 100fps.
BUG=64848
TEST=layout tests
Review URL: http://codereview.chromium.org/6136005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In order to better log mixed-scripting issues I want to get the URL into
Chrome land. This involves a WebKit change ([1]) but, by making this
change first, we can decouple of the two changes.
[1] https://bugs.webkit.org/show_bug.cgi?id=52384
BUG=none
TEST=compile
http://codereview.chromium.org/6272003/
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(This was a TODO for phajdan.jr).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6354005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests are (usually) monitored for a fixed length of time. With this change
field trial tests turn them selves off (will use the default group) after
the expiration time (specified in the Field Trial constructor).
BUG=13463
TEST=field_trial_unittests tests this code thorougly. spdy session and testing
field_trials in renderer process would be very helpful. thanks much.
Review URL: http://codereview.chromium.org/6317004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This mirrors the behaviour on other platforms, and allows the optimized Pepper
plugin painting path to be used (see RenderWidget::DoDeferredUpdate()).
BUG=none
TEST=MacFlapper paints correctly in the "windowed" case
Review URL: http://codereview.chromium.org/6359005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome tab/window/session
The password manager was incorrectly down-casting from WebNode to WebInputElement and then upon method invocation, was crashing. This change adds extra checks to |FindFormInputElements| before down-casting. Also, when "name" attributes are ambiguous, the code now rejects filling. This fixes the case where password text can erroneously get filled in the username field.
BUG=29352
TEST=PasswordAutocompleteManagerTest.*, and manual according to bugs.
Review URL: http://codereview.chromium.org/6271007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71806 0039d316-1c4b-4281-b951-d872f2087c98
|