| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ExtensionApiTest.WebRequestEvents
Review URL: http://codereview.chromium.org/7542010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=91335
TEST=see bug
Review URL: http://codereview.chromium.org/7551007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and |page_slot| from PrintMsg_PrintPage_Params.
We will not add preview pages to the complete metafile in out of order fashion.
BUG=none
TEST=print preview works after code changes.
Review URL: http://codereview.chromium.org/7549001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Show display warning if the form is autocomplete off.
Need WebKit side patch. https://bugs.webkit.org/show_bug.cgi?id=65304
BUG=63553
TEST=1,Make form with autocomplete="off", make sure the warning message is shown.
2, Make form with field with autocomple="off", make sure the warning message is not shown.
Review URL: http://codereview.chromium.org/7514003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch is the first working version using a preload message in the style of
viewsource.
NOTIFICATION_NAV_ENTRY_COMMITTED was too late as it was after the navigate
command was sent and was a race condition to inject before the onload ran.
Basic gist of this patch is:
- Wait for RVH creation by listening for NOTIFICATION_RENDER_VIEW_HOST_CREATED.
Since this is called from constructor, we must listen to AllSources() and
assume the next RVH creation is ours. This is controlled test case, so we're
probably ok.
- When RenderViewHostInitialized, call the OnJsInjectionReady passing the
RVH. JsInjectionReadyObserver should now use that RVH to Send a
ViewMsg_WebUIJavascript message to register javascript to preload.
- the ChromeRenderViewObserver will stash the javascript and load it when
DidStartLoading.
BUG=90476
TEST=browser_tests --gtest_filter=PrintPreview*WebUI*.*
Review URL: http://codereview.chromium.org/7531029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support HTML like """Name <span class="required">*</span> <input type="text" name="name">"""
Of course, pull at a thread and...
Other changes also included to avoid regressions:
* When parsing address fields for heuristics, we try to skip over unlabeled fields in the middle of an address. Updated the code not to also skip over unlabeled fields at the *end* of an address, as these might be part of a different section entirely.
* Tighten the credit card number regex to require the word "card".
* Add "csc" to the credit card security code regex.
* When inferring labels based on <div> structure, be willing to scan up the tree past the closest parent that is a <div>.
* Also when inferring labels based on <div> structure, we previously would only stop early if we were about to escape from a <table> element. Also stop early if we are about to escape from a <fieldset> element. If we see either of these elements, we expect the field label to be contained with the element.
* Allow <label> elements to misuse the 'for' attribute to specify the element's name rather than its id.
BUG=87517
TEST=browser_tests --gtest_filter=FormStructureBrowserTest.DataDrivenHeuristics*
Review URL: http://codereview.chromium.org/7531023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=91256
TEST=None
Review URL: http://codereview.chromium.org/7545018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=90905
Review URL: http://codereview.chromium.org/7537033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
proxy. This does not, however, actually use these in the proxy yet, I'll do
that in a subsequent pass.
ObjectVar is now renamed NPObjectVar and continues to be in webkit/plugins
since it uses NPObjects. There will be a corresponding future class in the
proxy for proxied objects.
The TryCatch that was in var.h is now in npapi_glue.h
Most of the rest of the change is updating namespaces.
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/7488062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When determining whether or not to swap processes on navigation, check the top frame's URL.
Otherwise having an inner frame that matches the app's extent could mean that the process
is not swapped, even if we're not in an app process.
BUG=89272
TEST=no
R=creis@chromium.org
Review URL: http://codereview.chromium.org/7537014
TBR=mihaip@chromium.org
Review URL: http://codereview.chromium.org/7544002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
top frame's URL.
Otherwise having an inner frame that matches the app's extent could mean that the process
is not swapped, even if we're not in an app process.
BUG=89272
TEST=no
R=creis@chromium.org
Review URL: http://codereview.chromium.org/7537014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=90905
Review URL: http://codereview.chromium.org/7541001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=90905
Review URL: http://codereview.chromium.org/7532034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=PrintWebViewHelperTest.PrintLayoutTest passes
Review URL: http://codereview.chromium.org/7480048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension API"
Now ExtensionApiTest.TtsChromeOs is failing.
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/7530016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94577 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
calls.
It was reverted after causing flakiness in ExtensionWebstorePrivateApiTest.InstallAccepted. I am no longer able to reproduce the failure locally, so I'm hoping it was an issue with some other piece of code that has since been fixed.
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/7477028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
programatic CSS injection.
Inserting CSS as a user stylesheet is both consistent with content script
injection and better for compatibility, since it does not affect the page's DOM.
Removes the other call of insertStyleText (for infobar CSS injection),
thus it should be possible to remove it after a WebKit roll.
Depends on http://webkit.org/b/65158
BUG=82220
TEST=no
R=mpcomplete@chromium.org
Review URL: http://codereview.chromium.org/7517001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=90781
Review URL: http://codereview.chromium.org/7522011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
labels.
In particular, if the <input> element is in an actual <table>, do not try to infer its label from a "div table".
BUG=90472
TEST=browser_tests --gtest_filter=FormStructureBrowserTest.DataDrivenHeuristics11
Review URL: http://codereview.chromium.org/7477026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=88762
TEST=print preview works after code changes.
Review URL: http://codereview.chromium.org/7461096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The permissions API lets extensions specify optional permissions in their manifest that they can request at run-time. It currently supports API permissions through a white-list. Host permissions will come later. This also fixes some clang errors from the previous attempt.
BUG=48119, 70466, 84507
TEST=*Extension*
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94288
Review URL: http://codereview.chromium.org/7432006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The permissions API lets extensions specify optional permissions in their manifest that they can request at run-time. It currently supports API permissions through a white-list. Host permissions will come later.
BUG=48119, 70466, 84507
TEST=*Extension*
Review URL: http://codereview.chromium.org/7432006
TBR=jstritar@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The permissions API lets extensions specify optional permissions in their manifest that they can request at run-time. It currently supports API permissions through a white-list. Host permissions will come later.
BUG=48119, 70466, 84507
TEST=*Extension*
Review URL: http://codereview.chromium.org/7432006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7517002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=71891
TEST=browser_tests --gtest_filter=FormStructureBrowserTest.DataDrivenHeuristics*
Review URL: http://codereview.chromium.org/7488036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=I've put an api test in your api tests, so you can test your api while testing your api
Review URL: http://codereview.chromium.org/7514004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous review comments:
http://codereview.chromium.org/7395016/
http://codereview.chromium.org/7210042/
BUG=88762
TEST=NONE
Review URL: http://codereview.chromium.org/7495003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=83894
TEST=NONE
Review URL: http://codereview.chromium.org/7513004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-landing http://codereview.chromium.org/7457001:
Adding support for mount point different from removable
devices to MountLibrary
(work in progress..have to add GetMountPoints support)
tested on ChromeOS with these three patches:
http://gerrit.chromium.org/gerrit/#change,4447
http://gerrit.chromium.org/gerrit/#change,4449
http://gerrit.chromium.org/gerrit/#change,4544
http://codereview.chromium.org/7471039/:
UI for mounting/unmounting archive files.
BUG=chromium-os:17673, chromium-os:17783
TEST=Made sure mounting devices still works and that MountCompleted event gets through to file_browser_event_router (checking ui and chrome logs for mount completed entries)
TBR=tbarzic, dgozman
Review URL: http://codereview.chromium.org/7488044
Review URL: http://codereview.chromium.org/7502010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/7495021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7492031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
a different change for URLFixerUpper, and the prefs will be done in a future change.
BUG=82782
Review URL: http://codereview.chromium.org/7461017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
big source of mixed scripting.
Review URL: http://codereview.chromium.org/7493001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file browser:
Re-landing http://codereview.chromium.org/7457001:
Adding support for mount point different from removable
devices to MountLibrary
(work in progress..have to add GetMountPoints support)
tested on ChromeOS with these three patches:
http://gerrit.chromium.org/gerrit/#change,4447
http://gerrit.chromium.org/gerrit/#change,4449
http://gerrit.chromium.org/gerrit/#change,4544
http://codereview.chromium.org/7471039/:
UI for mounting/unmounting archive files.
BUG=chromium-os:17673, chromium-os:17783
TEST=Made sure mounting devices still works and that MountCompleted event gets through to file_browser_event_router (checking ui and chrome logs for mount completed entries)
TBR=tbarzic, dgozman
Review URL: http://codereview.chromium.org/7488044
TBR=zelidrag@chromium.org
Review URL: http://codereview.chromium.org/7495024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-landing http://codereview.chromium.org/7457001:
Adding support for mount point different from removable
devices to MountLibrary
(work in progress..have to add GetMountPoints support)
tested on ChromeOS with these three patches:
http://gerrit.chromium.org/gerrit/#change,4447
http://gerrit.chromium.org/gerrit/#change,4449
http://gerrit.chromium.org/gerrit/#change,4544
http://codereview.chromium.org/7471039/:
UI for mounting/unmounting archive files.
BUG=chromium-os:17673, chromium-os:17783
TEST=Made sure mounting devices still works and that MountCompleted event gets through to file_browser_event_router (checking ui and chrome logs for mount completed entries)
TBR=tbarzic, dgozman
Review URL: http://codereview.chromium.org/7488044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93838 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will let us add pages to a metafile out of order for print preview.
Also, make PdfMetafileSkia::GetMetafileForCurrentPage use draft mode, now that it's available.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/7481019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
preview.
Restructures settings handling code to share more code with the traditional
print path.
Modifies backends to treat cloud printers the same as printing to PDF.
This change also (incidently) causes parsing of page ranges to work correctly.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=16082
TEST=Load print preview dialog with cloud print enabled on a document with multiple pages. All pages should appear in the preview when a GCP printer is selected.
Review URL: http://codereview.chromium.org/7490001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=84078
TEST=
Review URL: http://codereview.chromium.org/7461019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FYI, this rolls back changes made in
http://codereview.chromium.org/7080040/
to disable Mac for M13, plus does changes to print_preview.js (WebUI tests).
BUG=84500
R=vandebo@chromium.org
TEST=trybots
Review URL: http://codereview.chromium.org/7486016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7346036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ping back to the server. That will be used to detect client-side false
negatives as well as help us train a model for FakeAV pages.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7408001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Right click on an embedded PDF, print, print with system dialog. This should generate the same output as the initial preview.
Review URL: http://codereview.chromium.org/7395028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We keep track of:
* Windows media player (appluication/x-mplayer2)
* Silverlight (application/x-silverlight*)
* RealPlayer (audio/x-pn-realaudio*)
* Java (application/x-java-applet)
* QuickTime (video/quicktime)
TEST=Ran PluginUMATest.* unit_test
BUG=chromium-os:16696
Review URL: http://codereview.chromium.org/7351023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7472020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
them new explicit permissions and install warning messages.
Also change the hidden event ttsEngine.onEvent to tts.onEvent, which is
where it belongs because it's sent to clients who call tts.speak and has
nothing to do with engines.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7258007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a new preview.
Adds handling of the request ID to PrintWebViewHelper::UpdatePrintSettingsCloud
BUG=http://code.google.com/p/chromium-os/issues/detail?id=16082
TEST=Run chrome with --enable-cloud-printers and --enable-print-preview.
Open a web page and hit ctrl-p to open print preview
Select a cloud printer from the dropdown.
You should get a preview.
Review URL: http://codereview.chromium.org/7461014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: http://codereview.chromium.org/7396031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the limit the crowdsourcing server imposes. Data collected via Google Feedback indicates that this is a reasonable limit.
Previously, we limited the number of fields to 1000, just to avoid DOS.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7459005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
removed unused/irrelevant functions
removed irrelevant comments
Moved stl_util-inl.h => stl_util.h
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7342047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=82782
Review URL: http://codereview.chromium.org/7396029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93041 0039d316-1c4b-4281-b951-d872f2087c98
|