summaryrefslogtreecommitdiffstats
path: root/chrome/renderer
Commit message (Collapse)AuthorAgeFilesLines
* Implement a max worker count of 16 per tab and 64 total. Any workers ↵jam@chromium.org2009-06-182-8/+33
| | | | | | | | created after that are queued. Review URL: http://codereview.chromium.org/125242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18763 0039d316-1c4b-4281-b951-d872f2087c98
* Delete files from webkit/glue that have been made obsolete by correspondingdarin@chromium.org2009-06-188-112/+147
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | files in webkit/api. Here's the mapping: webkit/glue/webdatasource.h -> webkit/api/public/WebDataSource.h webkit/glue/weberror.h -> webkit/api/public/WebURLError.h webkit/glue/weburlrequest.h -> webkit/api/public/WebURLRequest.h webkit/glue/webresponse.h -> webkit/api/public/WebURLResponse.h I kept the implementation of WebDataSource in webkit/glue for now because it helps to have it close to WebFrameImpl and WebFrameLoaderClient. To facilitate this change, I needed to make use of WrappedResourceRequest and WrappedResourceResponse from webkit/api/src within the implementation files of webkit/glue. This is only a temporary usage of webkit/api/src from the outside. It will go away when WebFrame, etc. get moved into webkit/api. I modified these wrapper classes to expose the 'bind' function so that I can re-bind a wrapper. This is used in WebDataSourceImpl::request() and related methods to allow the interface to return a const reference to a WebURLRequest and WebURLResponse. The changes here are fairly mechanical. I'm not too happy about the way WebDataSource::redirectChain now works. I would prefer a solution that didn't involve so much copying, but I'm not going to worry about optimizing that now. R=brettw BUG=10041 TEST=none Review URL: http://codereview.chromium.org/126286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18747 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Limit the size of the shared memory segment a renderer will request.estade@chromium.org2009-06-172-2/+33
| | | | | | | | | TEST=everything behaves the same, and you don't sad tab when resizing a very large autocomplete popup BUG=13805 Review URL: http://codereview.chromium.org/125274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18660 0039d316-1c4b-4281-b951-d872f2087c98
* Add a port disconnect event for when one side of an extension message portmpcomplete@google.com2009-06-176-70/+74
| | | | | | | | | | | | | goes away. Combine the various ExtensionMessageService IPC message into a single "Invoke" message. BUG=12686 TEST=no Review URL: http://codereview.chromium.org/126234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18645 0039d316-1c4b-4281-b951-d872f2087c98
* Adds kind-of-live thumbnail generation for a potential tab switcher.brettw@chromium.org2009-06-162-17/+1
| | | | | | | | | | | | | | | | | | | | This listens to tab events and tries to keep thumbnails ready to go. See thumbnail_generator.cc for a more detailed design. This adds a painting observer to the RenderWidgetHost to enable this new behavior, as well as a notification to allow the thumbnail generator to hook its observer in. There is also a new notification that a backing store has been disabled, which required making the backing stores know about their owning widget hosts. This component is currently disabled. We just need to uncomment the member in Profile and it will start to work. Original review: http://codereview.chromium.org/118420 Review URL: http://codereview.chromium.org/126101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18540 0039d316-1c4b-4281-b951-d872f2087c98
* Since the introduction of PushSource, there are two buffering layers in thehclam@chromium.org2009-06-165-211/+302
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | browser process, the hardware buffer used in AudioOutputStream and transportation buffer in PushSource. Together with the latency in the IPC audio layer we have a serious AV sync problem. To compensate the delay and latency introduced by these three factors two parameters are added in RequestAudioPacket message that include the buffer fill level and timestamp of the request. These two parameters are used to determine the playback delay to be used by the audio renderer to update the pipeline with the time delta. So we have three parameters we need to care about: 1. Hardware buffer in AudioOutputStream 2. Buffered data in PushSource 3. IPC latency We have accurate values for 2 and 3 but not 1. We currently don't have the API in AudioOutputStream to query the remaining buffer in the hardware buffer. But usually there is a large amount of data in it, e.g. on Windows 400ms worth of data. Since we now detached the hardware buffer request of OnMoreData() from the actual packet request of IPC (by the introduction of PushSource), it is really critical to know the buffer level in the hardware. I made a guess of this buffer level by using the amount of last buffer copy. Review URL: http://codereview.chromium.org/122020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18536 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18512 - Revert 18373 Consider a redirect following user gesture as ↵laforge@chromium.org2009-06-161-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | userinitiated in maintaining navigation entries. Also, ignore redirect or machineinitiated new subframe navigations. The current code treats all redirects as machineinitiated in processing navigation to a new page (to fix Bugs 9663 and 10531). This is not always appropriate, because some sites, e.g., www.google.com/ig, use redirect to implement userinitiated navigation (Bug 11896). This change assumes that a machineinitiated redirect happens within 300ms since the last document load was completed, while a userinitiated one happens later. This assumption is not always correct, e.g., a user may cause transition within 300ms. But I cannot think of any better ways to tell if a redirect is machine initiated or userinitiated. I believe this change works good enough, at least better than the status quo. Review URL: http://codereview.chromium.org/115919 TEST=Open http://www.hp.com and observe it redirects to http://www.hp.com/#Product . Hit Back button and observe the former URL is not visited. Open http://www.google.com/ig and click tabs inside the page, and try hitting Back and Forward to see if the navigation is right. Open http://www.google.com/codesearch, search for something, click on a result item, and try hitting Back. BUG=11896,12820 TBR=yuzo@chromium.org Review URL: http://codereview.chromium.org/125202 TBR=laforge@chromium.org Review URL: http://codereview.chromium.org/126221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18522 0039d316-1c4b-4281-b951-d872f2087c98
* Extract load times from WebDataSource. Move them to NavigationState.darin@chromium.org2009-06-164-110/+180
| | | | | | | | | | | | Move PasswordForm into the webkit_glue namespace. TEST=none BUG=10041 R=brettw Review URL: http://codereview.chromium.org/126190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18515 0039d316-1c4b-4281-b951-d872f2087c98
* Access RenderThread::current() only on render threadhclam@chromium.org2009-06-163-47/+80
| | | | | | | | | | Since the renfer to RenderThread is now stored in the thread local storage, we can only access RenderThread::current() from render thread. Change BufferedDataSource accordingly. Review URL: http://codereview.chromium.org/126183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18513 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18373 - Consider a redirect following user gesture as userinitiated ↵laforge@chromium.org2009-06-161-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in maintaining navigation entries. Also, ignore redirect or machineinitiated new subframe navigations. The current code treats all redirects as machineinitiated in processing navigation to a new page (to fix Bugs 9663 and 10531). This is not always appropriate, because some sites, e.g., www.google.com/ig, use redirect to implement userinitiated navigation (Bug 11896). This change assumes that a machineinitiated redirect happens within 300ms since the last document load was completed, while a userinitiated one happens later. This assumption is not always correct, e.g., a user may cause transition within 300ms. But I cannot think of any better ways to tell if a redirect is machine initiated or userinitiated. I believe this change works good enough, at least better than the status quo. Review URL: http://codereview.chromium.org/115919 TEST=Open http://www.hp.com and observe it redirects to http://www.hp.com/#Product . Hit Back button and observe the former URL is not visited. Open http://www.google.com/ig and click tabs inside the page, and try hitting Back and Forward to see if the navigation is right. Open http://www.google.com/codesearch, search for something, click on a result item, and try hitting Back. BUG=11896,12820 TBR=yuzo@chromium.org Review URL: http://codereview.chromium.org/125202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18512 0039d316-1c4b-4281-b951-d872f2087c98
* Hack to enable video on mac by creating a blank PlatformContextMac to draw on.ajwong@chromium.org2009-06-161-3/+0
| | | | | | | | This isn't a great solution, but it kinda works. Video renders, and the speed is acceptable even though we're doing an extra copy for each frame. The image shows up upside-down though. :( Review URL: http://codereview.chromium.org/126087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18503 0039d316-1c4b-4281-b951-d872f2087c98
* Make XHR work in Workers. Creates a 'shadow page' in a worker process to ↵dimich@google.com2009-06-161-2/+2
| | | | | | | | | | proxy the loading requests through. BUG=4361 TEST=none Review URL: http://codereview.chromium.org/126070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18465 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where clicking an external link from an extension page would reusempcomplete@google.com2009-06-151-0/+1
| | | | | | | | | the same process. BUG=13997 Review URL: http://codereview.chromium.org/126067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18451 0039d316-1c4b-4281-b951-d872f2087c98
* Switch child threads so that current() only works on the correct thread and ↵jam@chromium.org2009-06-152-4/+11
| | | | | | | | the correct process. Review URL: http://codereview.chromium.org/126086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18409 0039d316-1c4b-4281-b951-d872f2087c98
* Extract form related classes from the guts of WebFrameImpl.darin@chromium.org2009-06-152-101/+151
| | | | | | | | | | | | | | | | | | | Instead of having WebFrameImpl generate SearchableFormData, PasswordForm, and AutofillForm classes, allow the embedder (RenderView) to do so. This is done to help minimize the dependencies WebFrameImpl has on other code, which will make it easier to move WebFrame and WebDataSource into the WebKit API. Most significant change: Now, RenderView always sets a NavigationState on WebDataSource instances. We used to only do so for browser initiated navigations. This is done so that we can store things like SearchableFormData and friends on the NavigationState. To facilitate this change, it was necessary to add a way through the WebKit API to refer to a HTMLFormElement. This CL introduces WebForm, which is like a RefPtr<HTMLFormElement>, so you can just copy a WebForm around by value and the right thing happens. Some of the other changes are about moving more things into the webkit_glue namespace. On hindsight, I probably should have done that as a separate CL. BUG=10041 TEST=none R=brettw Review URL: http://codereview.chromium.org/126083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18395 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting Rev 18383 since it brings down the performance of single core page ↵mad@chromium.org2009-06-152-145/+30
| | | | | | cyclers too much... git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18385 0039d316-1c4b-4281-b951-d872f2087c98
* This is to thest the page cycler performance without the resize corner, to ↵mad@chromium.org2009-06-152-30/+145
| | | | | | | | | | | | | see if these paint optimizations are worth it. I will revert these changes as needed... You may revert them yourself if they cause you trouble before I get to revert them. I have tested these changes on two different linux configuration, but there are more code paths that I couldn't verify myself, though agl gave me the OK anyway. These changes have already been reviewed here: http://codereview.chromium.org/108040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18383 0039d316-1c4b-4281-b951-d872f2087c98
* Revert processing naming change, which breaks UI tests iterating over thedeanm@chromium.org2009-06-151-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | chrome processes by name. Reverting: commit b60e93b5ccb3bf0eefbc5b15b74b5a8be30aa589 Author: deanm@chromium.org <deanm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Mon Jun 15 09:59:38 2009 +0000 Set process name on Linux This uses PR_SET_NAME to set the process name. It was useful in looking at memory numbers with the zygote patches. PR_SET_NAME is only avalaible in kernels >= 2.6.9 according to the man page: > PR_SET_NAME (since Linux 2.6.9) > Set the process name for the calling process, using the value in > the location pointed to by (char *) arg2. The name can be up to > 16 bytes long, and should be null terminated if it contains > fewer bytes. shenki@moya ~/src/chromium/src :process-name $ ps --forest PID TTY TIME CMD 5581 pts/2 00:00:00 bash 9559 pts/2 00:00:02 \_ Chromium_Browse 9573 pts/2 00:00:00 | \_ Chromium_Render 9581 pts/2 00:00:02 | \_ Chromium_Render 9584 pts/2 00:00:00 | \_ Chromium_Render Patch by Joel Stanley. Review URL: http://codereview.chromium.org/118060 git-svn-id: svn://chrome-svn/chrome/trunk/src@18376 0039d316-1c4b-4281-b951-d872f2087c98 Review URL: http://codereview.chromium.org/126119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18380 0039d316-1c4b-4281-b951-d872f2087c98
* Set process name on Linuxdeanm@chromium.org2009-06-151-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This uses PR_SET_NAME to set the process name. It was useful in looking at memory numbers with the zygote patches. PR_SET_NAME is only avalaible in kernels >= 2.6.9 according to the man page: > PR_SET_NAME (since Linux 2.6.9) > Set the process name for the calling process, using the value in > the location pointed to by (char *) arg2. The name can be up to > 16 bytes long, and should be null terminated if it contains > fewer bytes. shenki@moya ~/src/chromium/src :process-name $ ps --forest PID TTY TIME CMD 5581 pts/2 00:00:00 bash 9559 pts/2 00:00:02 \_ Chromium_Browse 9573 pts/2 00:00:00 | \_ Chromium_Render 9581 pts/2 00:00:02 | \_ Chromium_Render 9584 pts/2 00:00:00 | \_ Chromium_Render Patch by Joel Stanley. Review URL: http://codereview.chromium.org/118060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18376 0039d316-1c4b-4281-b951-d872f2087c98
* Consider a redirect following user gesture as user-initiated in maintainingyuzo@chromium.org2009-06-151-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | navigation entries. Also, ignore redirect- or machine-initiated- new subframe navigations. The current code treats all redirects as machine-initiated in processing navigation to a new page (to fix Bugs 9663 and 10531). This is not always appropriate, because some sites, e.g., www.google.com/ig, use redirect to implement user-initiated navigation (Bug 11896). This change assumes that a machine-initiated redirect happens within 300ms since the last document load was completed, while a user-initiated one happens later. This assumption is not always correct, e.g., a user may cause transition within 300ms. But I cannot think of any better ways to tell if a redirect is machine- initiated or user-initiated. I believe this change works good enough, at least better than the status quo. Review URL: http://codereview.chromium.org/115919 TEST=Open http://www.hp.com and observe it redirects to http://www.hp.com/#Product . Hit Back button and observe the former URL is not visited. Open http://www.google.com/ig and click tabs inside the page, and try hitting Back and Forward to see if the navigation is right. Open http://www.google.com/codesearch, search for something, click on a result item, and try hitting Back. BUG=11896,12820 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18373 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the PlatformContext layer to have only one class.brettw@chromium.org2009-06-143-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | Previously we had three classes of PlatformCanvas*, one for each platform. Then we had a typedef of PlatformContext to PlatformCanvas[Mac|Win|Linux] for the specific platform. This means that it was almost impossible to forward-declare PlatformCanvas and there were a bunch of unnecessary includes of platform_canvas.h in header files. This change makes there be only one platform_canvas.h header with ifdefs, which removes a decent amount of duplicated code. There is a platform-independent file, and one platform-dependent file of platform_canvas for each platform. I also renamed PlatformDevice[Mac|Win|Linux] to PlatformDevice, althouth in this case I kept the separate headers since there was much less overlap. I also broke out CanvasPaint into separate headers so this template doesn't need to be included all over the project (only a couple of files actually need it). Review URL: http://codereview.chromium.org/125109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18363 0039d316-1c4b-4281-b951-d872f2087c98
* DEPS cleanup.thestig@chromium.org2009-06-121-3/+1
| | | | | | Review URL: http://codereview.chromium.org/118317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18312 0039d316-1c4b-4281-b951-d872f2087c98
* Use pointers instead of references in SpellCheck function.sidchat@google.com2009-06-122-6/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/126054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18304 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: refactor zygote supportagl@chromium.org2009-06-121-5/+3
| | | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxZygote * Move Chrome specific bits out of base * Move away from the idea of reserved file descriptors (which don't really work with zygotes) * Load resources before forking renderers (means that we don't need communication between the zygote process and the renderers) * Make sure that gdb works against the browser again * Make sure that we have different ASLR between the renderers and the browser. http://codereview.chromium.org/119335 (This is a reland. First landed in r18109, reverted in r18112.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18291 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most field trial uses of DNS impact testjar@chromium.org2009-06-121-24/+14
| | | | | | | | | | | | | | | | | The focus on DNS prefetching has moved to optimize primarilly the RequestToFinish time in the renderer. As a result, I've removed most of the modulations of the histogram names other than that focal histogram. I've also extended the duration for RequestToFinish, and enhanced its granularity, changing the name to RequestToFinish_L. Dave: Please review the renderer histogram changes. Will: Please review the network histogram changes. You can also suggest any histograms that you think would be removed at this point. r=davemoore,willchan Review URL: http://codereview.chromium.org/126023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18283 0039d316-1c4b-4281-b951-d872f2087c98
* Enable <video> in test_shellhclam@chromium.org2009-06-116-962/+16
| | | | | | | | | | | | | | | | | | | | | This is a work in progress draft. Summary of changes: 1. Moved code shared by chrome and test_shell to webkie/glue: WebMediaPlayerImpl SimpleDataSource VideoRendererImpl 2. Since WebMediaPlayerImpl is shared, chrome specific renderers are enabled by passing the FilterFactoryCollection into WebMediaPlayerImpl, this is done in RenderView. And WebMediaPlayerImpl provides some default renderer filters, which are used by the test shell and also chrome. Review URL: http://codereview.chromium.org/119229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18182 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure to pump windowserver events that accumulate.avi@google.com2009-06-111-13/+33
| | | | | | | | | BUG=http://crbug.com/11319 TEST=As in bug; use Chromium and ensure renderers don't get marked as not responding Review URL: http://codereview.chromium.org/121004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18173 0039d316-1c4b-4281-b951-d872f2087c98
* Move renderer_preferences.h from chrome/browser into chrome/common. Wetc@google.com2009-06-115-7/+5
| | | | | | | | | | include the file in chrome/renderer and chrome/browser so to make check deps happy, I'm putting the file in chrome/common. Review URL: http://codereview.chromium.org/123001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18166 0039d316-1c4b-4281-b951-d872f2087c98
* Revert mad's backing store changes, it completely hosed Linux painting.deanm@chromium.org2009-06-112-145/+30
| | | | | | | | | This was r18090, reverted in r18092, recommitted without review in 18130. Review URL: http://codereview.chromium.org/122034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18158 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding reverted patch 18090.mad@google.com2009-06-112-30/+145
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18130 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18109, 18111: Windows UI tests failed.agl@chromium.org2009-06-101-3/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18112 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: refactor zygote supportagl@chromium.org2009-06-101-5/+3
| | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/wiki/LinuxZygote * Move Chrome specific bits out of base * Move away from the idea of reserved file descriptors (which don't really work with zygotes) * Load resources before forking renderers (means that we don't need communication between the zygote process and the renderers) * Make sure that gdb works against the browser again * Make sure that we have different ASLR between the renderers and the browser. http://codereview.chromium.org/119335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18109 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome/browser to chrome/renderer deps temporarily. I will movetc@google.com2009-06-101-0/+1
| | | | | | | | | | | the header to chrome/common in a follow up change. TBR=beng Review URL: http://codereview.chromium.org/120007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18108 0039d316-1c4b-4281-b951-d872f2087c98
* Do not allow URL drops on app windows to cause a navigation awaytc@google.com2009-06-104-6/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | from the currently loaded site. We are careful in this patch to continue to allow dropping URLs in text fields within the app window, and behavior for normal browser windows remains as before. There is a slight glitch when dragging a to an app window on the border of the window. Even though it is very brief, it is still disturbing. BUG=7171 TEST=Open Chrome (1), load google.com. Open Chrome (2), load yahoo.com. Drag a link from 1 to 2 and a link from 2 to 1 (both allowed). Create an app shortcut from 1, drag a link from 1 to 2 (allowed) and a link from 2 to 1 (denied). Verify that link scan be dragged to the omnibox and to text fields. Patch by Chase Phillips <chase@chromium.org> via http://codereview.chromium.org/119298 Review URL: http://codereview.chromium.org/121003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18100 0039d316-1c4b-4281-b951-d872f2087c98
* Stop auto-correcting abbreviations.BUG= www.crbug.com/12921TEST= For command ↵sidchat@google.com2009-06-102-4/+6
| | | | | | | | line --auto-spell-correct, "IMB" should not change to "IBM" Review URL: http://codereview.chromium.org/119210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18099 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 18090jrg@chromium.org2009-06-102-145/+30
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18092 0039d316-1c4b-4281-b951-d872f2087c98
* To help resolve the performance issue introduced when enabling the resize ↵mad@google.com2009-06-102-30/+145
| | | | | | | | corner, we now keep all non-intersecting rects separately and send an array of invalidation bitmaps via IPC as opposed to a single unionized rect :-) Review URL: http://codereview.chromium.org/108040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18090 0039d316-1c4b-4281-b951-d872f2087c98
* Make a comment change to the grd file so that my resource change from the ↵erikkay@google.com2009-06-101-1/+1
| | | | | | | | | | previous checkin will be picked up. TBR=aa Review URL: http://codereview.chromium.org/118503 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18057 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up bookmark API to match style of other extension APIserikkay@google.com2009-06-103-40/+50
| | | | | | | | | | BUG=11823 TEST=--load-extension test/data/extensions/samples/bookmarks TEST=unit_tests.exe --gtest_filter=ExtensionAPIClientTest.* Review URL: http://codereview.chromium.org/118209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18056 0039d316-1c4b-4281-b951-d872f2087c98
* Change the extension callback system to work more like events, where we trackmpcomplete@google.com2009-06-108-126/+119
| | | | | | | | | | | | | contexts rather than frames. Also change the way we call through to javascript, to avoid a v8::Compile. This is so we don't skew the histogram stats on our script cache. BUG=? TEST=none Review URL: http://codereview.chromium.org/119369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18001 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a flash plugin hang caused by opening google finance ticker symbols in ↵ananta@chromium.org2009-06-096-64/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | a background tab. From what I can tell this bug always existed in Chrome. The flash plugin gets instantiated and gets initial geometry updates during initialization. We download the plugin url after the geometry update. After these geometry updates the webkit layout timer runs and the plugin gets additional geometry updates. However these don't get sent over to the flash plugin instance in the plugin process as the geometry updates for windowed plugins are only flushed during paint, which does not happen in this case. The flash plugin ends up receiving data before geometry update and ends up behaving in a wierd fashion, i.e. not peeking for messages, etc. The fact that this is a windowed plugin results in the browser ui thread also getting hung until the plugin gets out of this state. The fix for the geometry update issue is to remove the deferred geometry update stuff. This only exists for windowed plugins anyway. The geometry update IPC is a plain routed message and it should not be a big overhead to send these IPCs to the plugin process. I found that while this change fixes the basic issue, we still see some hangs in the flash plugin because of it receiving data before the valid geometry update kicks in. John is working on a fix where we never have to call setFrameRect ourselves and always honor the setFrameRect calls made by Webkit. This issue can be marked as fixed once both fixes get checked in. This fixes http://code.google.com/p/chromium/issues/detail?id=12993 Bug=12993 TEST=Open google finance and Ctrl Click on the tickers in the page like Basic Materials, etc. Review URL: http://codereview.chromium.org/119200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17918 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 17889. It broke the extensions_uitests. And I didn't even get itmpcomplete@google.com2009-06-088-117/+127
| | | | | | | | | reviewed! (Wow, brainfart.) TBR=aa Review URL: http://codereview.chromium.org/119324 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17893 0039d316-1c4b-4281-b951-d872f2087c98
* Change the extension callback system to work more like events, where we trackmpcomplete@google.com2009-06-088-127/+117
| | | | | | | | | | | | | contexts rather than frames. Also change the way we call through to javascript, to avoid a v8::Compile. This is so we don't skew the histogram stats on our script cache. BUG=? TEST=none Review URL: http://codereview.chromium.org/118353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17889 0039d316-1c4b-4281-b951-d872f2087c98
* Revert has_selection flag back to false (was testing that this worked and ↵sverrir@google.com2009-06-081-1/+1
| | | | | | | | | | | forgot to change back in my last changelist). BUG=none TEST=Print Dialog on Windows should not have the print selection option active. Review URL: http://codereview.chromium.org/118391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17885 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for printing selection only flag. This only adds the flag to the ↵sverrir@google.com2009-06-085-2/+23
| | | | | | | | | | | IPC and implements the Windows dialog interaction but does not enable this just yet. BUG=http://crbug.com/1682 TEST=none Review URL: http://codereview.chromium.org/118338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17867 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on DevTools Profiler.mnaganov@chromium.org2009-06-081-1/+3
| | | | | | | | | | | Works on Windows and Linux. On Mac V8's sampling doesn't work with Chromium due to an unknown reason. BUG=none TEST=none Review URL: http://codereview.chromium.org/118384 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17866 0039d316-1c4b-4281-b951-d872f2087c98
* Add a test to print using javascript. This is to make sure I don't break ↵sverrir@google.com2009-06-051-0/+31
| | | | | | | | | | | anything when I start to do the async printing. BUG=none TEST=run unit tests Review URL: http://codereview.chromium.org/119245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17747 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a one pixel offset error in PrintLayoutTest. Now checks with a 5% ↵sverrir@google.com2009-06-051-2/+8
| | | | | | | | | | | margin. We need to figure out why this is different between machines and runs. BUG=none TEST=none Review URL: http://codereview.chromium.org/118312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17746 0039d316-1c4b-4281-b951-d872f2087c98
* Refuse to load extension-private plugins for pages that don't belong to thatmpcomplete@google.com2009-06-051-1/+5
| | | | | | | | | | extension. BUG=12960 TEST=none Review URL: http://codereview.chromium.org/118198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17743 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable unittest and fix the failure. This failed after a change in thesverrir@google.com2009-06-051-4/+1
| | | | | | | | | | | page sizing. BUG=none TEST=none Review URL: http://codereview.chromium.org/118271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17731 0039d316-1c4b-4281-b951-d872f2087c98