| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it.
Changed the shared worker startup code to assign a route ID at the time that we
initially lookup the worker, and pass that same route ID in when we later try
to create the worker, to gracefully handle this race condition.
BUG=29243
TEST=existing tests suffice (can't reproduce race condition in tests)
Review URL: http://codereview.chromium.org/600103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Send forms seen in the renderer to the AutoFillManager.
TBR=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/623003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=e.g. double click a word to select it, hit delete. should only delete the word (not the whitespace before)
Review URL: http://codereview.chromium.org/601093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/616003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
size_t's from the IPC code.
Review URL: http://codereview.chromium.org/581001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=33497
Review URL: http://codereview.chromium.org/593109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change re-implements the SpellcheckWordIterator class to use ICU custom rules so we can use the ICU dictionary to handle Thai and Korean.
Also, this class has added a couple of new features to improve the spell-checking quality:
* Decompose Hangul syllables into Korean Jamos.
This helps us support Korean spell-checking.
* Filter out some characters not needed by our spell-checker (e.g. Hebrew niqquds and Arabic vowel signs).
This prevents us from marking a word that includes these characters as misspelled.
BUG=8487
TEST=unit_test.exe --gtest_filter=SpellcheckWordIteratorTest*
Review URL: http://codereview.chromium.org/577020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This effectively reverts patch set 6 from http://codereview.chromium.org/596039 and adds patch set 1 instead.
Also add a regression test to make sure the bug is actually fixed.
The problem with using navigation state was that allowScripts() was still called before the FrameNavigate message was sent.
BUG=35011
TEST=See bug.
Review URL: http://codereview.chromium.org/608001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also add some plumbing for popping up an icon when it's blocked.
TEST=Turn on the ask content setting for a domain and set local storage and then clear it. Only the set should prompt you.
BUG=34668
Review URL: http://codereview.chromium.org/600078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
notification.
We get the RenderView identifier by looking at the current WebFrame.
This will need to be changed since we do not always have a current
WebFrame (e.g., when processing a <META http-equiv="set-cookie">).
I'd like to proceed with this temporary fix for now since I think it
is actually good enough for a 4.1 release. I'll work to make the
necessary webkit changes to expose the WebFrame properly in parallel.
R=jorlow
BUG=34573
TEST=none
Review URL: http://codereview.chromium.org/605003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/606030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/577015 for the review status of this CL.
BUG=None
TEST=ExtensionApiTest.Popup
Review URL: http://codereview.chromium.org/600101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I believe that the bug happened in this sequence of events:
1.) JS gets blocked on the web page, icon appears. The renderer (correctly) thinks js is blocked.
2.) User hits "reload"
3.) RenderView::didCommitProvisionalLoad() calls RenderView::UpdateURL() which sends ViewHostMsg_FrameNavigate to the browser which clears the content settings images in the location bar
4.) RenderView::allowScripts() gets called during page loading. The renderer still thinks that js is blocked and hence doesn't notify the browser.
5.) RenderView::didReceiveResponse() clears the content blocked flags (too late)
This CL moves the content blocked flags into navigationstate, which should prevent this "race" because there's one new navigationstate per page.
BUG=35011
TEST=See bug.
Review URL: http://codereview.chromium.org/596039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This merely adds a way to enable content scripts and browser actions in incognito windows. They still don't work properly because none of the APIs work with incognito tabs.
The way to enable an extension is to add an "incognito" bit in the user prefs file. My plan is to add UI for this later.
BUG=32365
Review URL: http://codereview.chromium.org/567037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Also mark the history test as flaky.
BUG=35430, 26296
TEST=ExtensionApiTest.FLAKY_History
Review URL: http://codereview.chromium.org/601049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes two cases where message delays can cause the plugin painting system to use invalidation rects that are larger than the plugin is by the time they are handled.
BUG=35328
TEST=See bug.
Review URL: http://codereview.chromium.org/593063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
it with calls to the new applyAutocompleteSuggestions.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/597033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
blocked cookie
notification.
We get the RenderView identifier by looking at the current WebFrame.
R=jorlow
BUG=34573
TEST=none
Review URL: http://codereview.chromium.org/596050
TBR=darin@chromium.org
Review URL: http://codereview.chromium.org/597047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/584009
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/597045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38797 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
notification.
We get the RenderView identifier by looking at the current WebFrame.
R=jorlow
BUG=34573
TEST=none
Review URL: http://codereview.chromium.org/596050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
messages.
We avoid replacing messages within html and js extension files for security reasons. Also, developers can already localize messages in html/js using chrome.i18n.getMessage calls.
TEST=Localize extension, try body{direction: __MSG_@@bidi_reversed_dir__;} in popup.css, while using non-rtl locale. Text should be alligned to the right (as if we were using rtl locale).
BUG=26144
Review URL: http://codereview.chromium.org/570007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
process. Create an API to get the size of the audio shared memory
region.
Review URL: http://codereview.chromium.org/596038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- we were not computing the max request text size correctly in some cases (by forgetting the size of the &q= string) causing assertions.
- the translate server might send inconsistent response in some cases, this CL makes sure we deal with them.
A common case is when sending separators only strings, which
we are not doing now anymore.
Other more complicated case are less clear.
BUG=35055
TEST=Visit www.spiegel.de and translate the page. The page
should be translated correctly.
Review URL: http://codereview.chromium.org/594023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=34411
Review URL: http://codereview.chromium.org/599005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38590 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from pepper. Notably, the existing pepper implementation was, by
default, creating a high-priority producer thread. For the NaCl
version this thread should be in the NaCl module, and hence we
need to separate thread creation from pre-filling with the callback.
The latter is used to send an RPC to NaCl to pass the shared memory
and sync socket. Getting the shared memory was done by the first
reserved state value. Getting the sync socket required allocating
a second. Also changed the pepper test plugin to use the
new startThread member.
Review URL: http://codereview.chromium.org/593023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added waitForProgress field to NPDeviceContext3D to select between a flush (that pushes more work to the GPU process and waits for at least some of it to have been completed) and getting the current state as quickly as possible. The previous method of checking to see if the put offset had advanced was incorrect.
TEST=trybots
BUG=none
Review URL: http://codereview.chromium.org/561058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=23066
TEST=notify_demo.html
Review URL: http://codereview.chromium.org/548208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38533 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=23066
TEST=notify_demo.html
Review URL: http://codereview.chromium.org/548208
TBR=johnnyg@chromium.org
Review URL: http://codereview.chromium.org/600015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
parent_context.
This fixes a DCHECK which gets hit when a content script runs when javascript
has been disabled.
Review URL: http://codereview.chromium.org/595001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/584009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
any more
Review URL: http://codereview.chromium.org/593015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This CL makes it also translate frames and iframes.
BUG=34533
TEST=See bug for repro case.
Review URL: http://codereview.chromium.org/577032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23066
TEST=notify_demo.html
Review URL: http://codereview.chromium.org/548208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
used on the IO thread.
Review URL: http://codereview.chromium.org/600002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
using the CurrentContext, not the EnteredContext so that it grabs the right
object based on the frame being called.
The security of this object is not in question - access to the window itself
is already protected from XSS access.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/593003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
hideSuggestionsPopup.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/586011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28292
TEST=none
Review URL: http://codereview.chromium.org/577019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=29541
TEST=Install a test extension that has a browser action that uses
executeScript when you click on it to do something in the current tab like
call alert (the bug report has one). Then:
1) navigate to any site like http://www.google.com/
2) Add #foo to the end of url and hit enter.
3) Hit browser action button.
4) You should see the results.
Review URL: http://codereview.chromium.org/566041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sends any window frame and relevent content view location changes to the plugin process via IPC, so that the plugin process always knows where the plugin is rather than only knowing when the mouse is within the plugin area. This will be necessary for supporting NPN_ConvertPoint, and for supporting Java2 as currently implemented.
Related changes:
- Now that window information is being sent on init and un-hide, use that to get correct initial window focus information.
- Add a missing window focus change notification uncovered by the above.
- Use live mouse location for idle events, instead of a cached location, now that we have live plugin frame information.
- Refactor and simplify the logic for moving the plugin.
Note that containing_window_frame_ is currently unused, but will be shortly for NPN_ConvertPoint, and is so closely related to the added IPC that I added it now rather than having to immediately change the new messages and functions.
BUG=34046,31858,31543,29457
TEST=Mouse tracking in Carbon plugins should still work correctly, even across window moves, info/bookmark bar show/hides, etc. (Automated tests of location tracking will follow shortly with full NPN_ConvertPoint implementation.)
Review URL: http://codereview.chromium.org/573015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Divided the case of link-navigation based on whether the cache
was being used.
Many histograms were further divided. I depricated one enum so that
the existing histogram could be compared better.
r=darin
Review URL: http://codereview.chromium.org/582010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
The change got to this size because I had to modify the surrounding code (I didn't want to just cast at the last minute).
Review URL: http://codereview.chromium.org/577006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=20772
TEST=Open gnome-keyboard-properties. Un-set the "Cursor Blinking" checkbox. Open a new tab in chromium and the cursor should not blink. Do the same with the slider, and the rate of blinking should vary.
Review URL: http://codereview.chromium.org/398003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added call to RenderView::DidMovePlugin upon creating the command buffer so
the nested delegate is initially placed properly on the page; thanks to jam
for this suggestion. Added necessary accessor to fetch the plugin window
handle from the nested delegate, which is the "fake" GPU plugin window handle
on Mac OS X. Verified that Pepper 3D test plugin initially shows up in the
correct place.
BUG=34167
TEST=none (ran Pepper test plugin on Mac and Linux)
Review URL: http://codereview.chromium.org/561068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18201
TEST=FormManagerTest
Review URL: http://codereview.chromium.org/577009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Remove files we don't use that come from toolbar
2. Simplify the directory structure by removing the redundant
intermediary directories bar/toolbar/cld/i18n
This will bring CLD a step closer to where it can be open-sourced separately (or along with CED for encoding detection.). It's not there yet.
In addition to the clean-up, change |LanguageCode*| return
'nb', 'he', 'fil' instead of 'no', 'iw', and 'tl'.
Also, use LanguageCodeWithDialects instead of LanguageCode to get 'zh-CN'
instead of 'zh'. This is to simplify the 3-way mapping between
Chrome's UI locale code, CLD's language code and what's accepted by
Google Translate. It's also another preparation for open-sourcing because
we'd better use the standard code rather than the obsolete code like 'iw'
when open-sourcing.
BUG=32759, 33613
TEST=third_party/cld builds on all platforms and pass the following tests:
- unit_tests: Extension*.DetectTabLanguage and CompactLangDetTest.*
- browser_tests: ExtensionBrowserTest.Toolstrip
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of 'zh'.
This was a part of http://codereview.chromium.org/549123/show (LGTM'd by jcampan by email), but that CL is failing the unittest after the CLD update by jcampan. So,
I'm landing this small change first.
BUG=32759
TEST=NONE
TBR=jcampan
Review URL: http://codereview.chromium.org/561065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AllowContentType needs to return false when blocking content. The code to limit notifications to the UI was interfering with this. This CL also fixes the naming of "allowContentType" to follow google style.
R=jochen
BUG=none
TEST=enable image blocking, and then load images.google.com. you should
see more than just one image get blocked.
Review URL: http://codereview.chromium.org/566039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pepper APIs in Chrome. Specifically, we need to be able to get the base::SharedMemory
or TransportDIB memory regions used to communicate with devices. To enable doing this,
especially in 64-bit Chrome, I needed to change the GetStateContext and SetStateContext
functions to manipulate 64-bit values. This CL does not include the Native Client
hookup to the new APIs, but is needed to do so.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/569004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Go to a page with blocked stuff. Icons should appear in omnibox.
Review URL: http://codereview.chromium.org/565010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
caret if there is no selected text.
See http://webkit.org/b/33364
BUG=8841
TEST=Open www.google.com on Windows or Linux (not Mac OS)
type "qeury"
Right-click on the text field
Select "query"
Confirm that qeury is replaced with "query"
Review URL: http://codereview.chromium.org/562014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37939 0039d316-1c4b-4281-b951-d872f2087c98
|