| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
even when navigating to an external URL. See bug for details.
BUG=39025
Review URL: http://codereview.chromium.org/2800005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2846007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make loops use {} instead of a ';' to make it clear there is no body to the loop.
- Remove checks of unsigned values for <0
- coordinates should be CGFloat, not NSUInteger.
BUG=34160
TEST=none
Review URL: http://codereview.chromium.org/2865003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
The original CL: http://codereview.chromium.org/577020
Review URL: http://codereview.chromium.org/2449002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
for the most part by the extension api tests.
BUG=34994,43775,46217,22248
Review URL: http://codereview.chromium.org/2847008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
loop so we can now enforce that there is only one pending Flush at a time.
Also removes the ability to have multiple flushes pending at the same time.
TEST=covered by ppapi unit test
BUG=none
Review URL: http://codereview.chromium.org/2862002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
path, as that'll fail in the sandbox and we don't care about the result then.
Review URL: http://codereview.chromium.org/2799009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
focus.
Note that this patch includes support for Views (Windows/chromeos) and GTK (Linux). I was going to do mac as well, but decided my objective-c skillz were too rusty.
BUG=32932
TEST=none
Review URL: http://codereview.chromium.org/2778001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49884 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When a page was closed, a pending task on the TranslationHelper was accessing the WebView that would be NULL.
BUG=46584
TEST=None
Review URL: http://codereview.chromium.org/2852005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
As discussed on irc, we're getting rid of const NSObjects, and we're making all properties nonatomic.
const: All of cocoa takes nonconst NSObjects, and passing a const NSString to a function that takes NSString is a const violation. gcc doesn't complain about this, but clang intentionally does. constness is usually done via immutable base classes and mutable subclasses in cocoa anyway, so getting rid of const isn't that bad. Also, we don't really have a choice.
nonatomic: Some of our classes have custom setters that are not @synchronized. If the @property for that is not non-atomic, then the interface claims that the method is synchronized but the implementation actually isn't. That's a bug. gcc happens not to complain about this, but clang does. Since we shouldn't need atomic properties anywhere, the simple rule is now to just make all properties nonatomic.
Review URL: http://codereview.chromium.org/2769014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the StringPiece version. In most cases, I didn't bother trying
to make the calling code more efficient since nothing seems to
be in time sensitive code.
Review URL: http://codereview.chromium.org/2827001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
as being auto-fillable.
BUG=46463
TEST=AutoFillManagerTest.HiddenFields, FormManagerTest.LabelsHiddenFields,
FormManagerTest.LabelForElementHidden
Review URL: http://codereview.chromium.org/2809005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2847001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
R=thomasvl
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also refactor a bunch of the dispatcher/dispatcherHost and IndexedDBCallbacks
code to clean things up.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2749013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added recursion depth limit to label scraping traversal. The page in question
was holding very large amounts of textual data in select fields within form
elements. This was slow to traverse, timing out on Mac, and exceeding string
size limits on Windows.
BUG=46328
TEST=manual tests with site in bug and FormManagerTest.*
Review URL: http://codereview.chromium.org/2813001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44616
TEST=FormManagerTest.*
Review URL: http://codereview.chromium.org/2752010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=lzheng
Review URL: http://codereview.chromium.org/2810001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Webkit layer.
Extended ViewMsg_New and ViewHostMsg_CreateWindow to have a new frame_name
parameter. This allows the RVH to know the initial name of the frame associated
with its RenderView, and also to set the name of the frame when creating a new
RenderView.
Review URL: http://codereview.chromium.org/2775003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/2673003.
Review URL: http://codereview.chromium.org/2794004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
silly because it would capture it in UTF16, then convert to wide, send it to
the browser, then convert it to UTF-8 for FTS.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2714012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
1) I fixed a bug where we recorded the wrong value for BeginToFinish
histograms.
2) Because of (1), it means we need to rename "Renderer4" to something
else (so that we don't mix the old wrong values with the new right
ones). I decided to rename to "PLT", because it is more accurate.
3) DumpLoadHistograms() is long and the order was a bit confused.
4) There were instances where we used different histogram ranges for
a few (possibly legacy?) histograms. Made all of them uses a
common format.
Overall, it's not very different than the original version, except it will
look like a huge diff. I hope it is more readable now.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2749016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the second issue regarding making Stop() asynchronous.
All Stop() in subclasses of MediaFilter is made to accept a callback and
runs the callback at the end of its stop.
BUG=16059
TEST=media_unittest, unit_tests, test_shell_tests still passes
Review URL: http://codereview.chromium.org/2541003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Corresponding Webkit patch to make this work is here:
https://bugs.webkit.org/show_bug.cgi?id=40317
BUG=16735
TEST=webkitSupportsFullscreen() js call should return true with switch.
(Requires webkit patch)
Review URL: http://codereview.chromium.org/2775001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
evaluate performance.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2764004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
popup.
BUG=45144
TEST=none
Review URL: http://codereview.chromium.org/2773005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
typing in. This change also conveniently removes filling the default profile,
since this feature has been removed from AutoFill.
BUG=46219
TEST=FormManagerTest.FillFormNonEmptyField
Review URL: http://codereview.chromium.org/2766005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
made categories for most of the private data, but since I couldn't figure out any categorization for the private functions, I just alphabetized them.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2749012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
initialize it until it's needed).
Review URL: http://codereview.chromium.org/2747007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
There should be no behavior change. I fixed a bunch of naming, alphabetized the message handlers, made some public stuff private, and deleted a smattering of functions that are never used.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2730006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46217
TEST=greener tree
TBR=jcivelli
Review URL: http://codereview.chromium.org/2751004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this doesn't open up the same extra privileges as javascript: scheme, which is still disallowed.
BUG=32470
TEST=create HTML notifications using data:
Review URL: http://codereview.chromium.org/2779005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/2770005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the comment, I suspect it used to be private but got moved around and now it's
public.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2740008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Before we carefully used the app (Chrome/Chromium) name, but:
1) these are for internal debugging use only, so why compute this name
2) on Linux the thread ids are limited to 16 characters, and "Chromium"
is too long
Review URL: http://codereview.chromium.org/2741003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is a clone of
http://codereview.chromium.org/2607001/show
which was reviewd and LGTM'ed by Jeremy Orlow.
Review URL: http://codereview.chromium.org/2740003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The strongbad demo plays an audio file of 11kHz. However we hardcoded
in the AudioRendererHost to always open an audio device of 8k samples
which happens to be too big for streams of 11khz. This makes the IPC
transport packet size much smaller than the hardware buffer size and
hardware packet is always partially filled.
This change allow the AudioRendererHost to designate the transport
packet size based on the hardware packet size. The hardware packet
size is now adjusted based on the sample rate.
BUG=46007
TEST=http://smokescreen.us/demos/sb45demo.html
The above audio plays fine.
Review URL: http://codereview.chromium.org/2651001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- simplify the y geolocation IPC protocol, by using the error code already in Geoposition
- convert Geoposition's error_message to UTF8 as this is easier alround
- simplify the dispatcher host render id set (as the process_id part is implicit from the dispatcher host instance)
BUG=40103
TEST=unit_tests --gtest_filter=*Geol*
Review URL: http://codereview.chromium.org/2648002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently Chrome, Firefox, and IE8 have the number of outgoing connections to each host(server) set at 6.
Safari uses 4, and Fasterfox (a plugin for Firefox that supposedly
configures it to run faster) uses 8. We would like to see how much of an
effect this value has on browsing. Too large a value might cause us to
run into SYN flood detection mechanisms. This experiment assigns a value of (4, 6, 8, 16) at random at program launch, and uses it throughout the run.
r=jar
Review URL: http://codereview.chromium.org/2685005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
To be able to stop on top-level breakpoints We need to enable javascript debugger before
any scripts are executed. That's why DebuggerScript.js contents should be retrieved synchronously.
Review URL: http://codereview.chromium.org/2609001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
directory.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/2657003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a small TODO in the benchmarking extension. Keep the disk cache
turned on during benchmarking, and doom all entries between benchmark
runs, rather than disabling it entirely.
BUG=none
TEST=All tests pass.
Review URL: http://codereview.chromium.org/669115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I believe the following CL had accidentally broken them:
http://src.chromium.org/viewvc/chrome?view=rev&revision=47972
I haven't yet added end-to-end tests for the context menu API that would catch
problems like this, but I just created a bug for that (crbug.com/45811) and
made the bug for bringing the API out of experimental blocked on it.
I also fixed a small >80 chars style nit in this CL.
BUG=45741
TEST=The onclick handler for an extension-added context menu item should now
be called. See the bug for a minimal code snippet to put into a background page
for this.
Review URL: http://codereview.chromium.org/2626001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
computation which originally assumed that source coordinate
as windows coordinate, but actually it was o screen coordinate.
This patch should wait for https://bugs.webkit.org/show_bug.cgi?id=39725.
BUG=37320
TEST=none
Original patch written by morrita@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=willchan
Review URL: http://codereview.chromium.org/2113017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Now it happens before the command buffer is initialized, which fixes an occasional race condition in Pepper 3D plugins that are not animated.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/2461003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
reasons.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2444005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This adds IDBIndex support. The majority of this CL was boilerplate type code in indexed_db_dispatcher_host so I did my best to factor it into template functions and split things into multiple sub-dispatcher hosts.
Review URL: http://codereview.chromium.org/2449005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48822 0039d316-1c4b-4281-b951-d872f2087c98
|