| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To address the vulnerability of stale WebFrame pointers in the FormManager's cache this CL changes the cache from a map (with the WebFrame pointer as "key") to a flat vector of simplified "FormElement*" items.
To avoid leaking memory, we need to still observe |frameDetached|, and use that as a signal to reap any associated WebFormElements or WebFormControlElements.
BUG=48857
TEST=FormMananagerTest.*, and manual test of regular form filling, form filling a form with sub-iframes, and form filling a form with sub-frames.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60949
Review URL: http://codereview.chromium.org/3492015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=compiles
Review URL: http://codereview.chromium.org/3555002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=sergeyu
BUG=None.
TEST=None.
Review URL: http://codereview.chromium.org/3571007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60959 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To address the vulnerability of stale WebFrame pointers in the FormManager's cache this CL changes the cache from a map (with the WebFrame pointer as "key") to a flat vector of simplified "FormElement*" items.
To avoid leaking memory, we need to still observe |frameDetached|, and use that as a signal to reap any associated WebFormElements or WebFormControlElements.
BUG=48857
TEST=FormMananagerTest.*, and manual test of regular form filling, form filling a form with sub-iframes, and form filling a form with sub-frames.
Review URL: http://codereview.chromium.org/3492015
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/3543003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To address the vulnerability of stale WebFrame pointers in the FormManager's cache this CL changes the cache from a map (with the WebFrame pointer as "key") to a flat vector of simplified "FormElement*" items.
To avoid leaking memory, we need to still observe |frameDetached|, and use that as a signal to reap any associated WebFormElements or WebFormControlElements.
BUG=48857
TEST=FormMananagerTest.*, and manual test of regular form filling, form filling a form with sub-iframes, and form filling a form with sub-frames.
Review URL: http://codereview.chromium.org/3492015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Seeing that GpuVideoDecoderHost has a very similar interface to
VideoDecodeEngine, this patch makes GpuVideoDecoderHost implments
VideoDecodeEngine.
Also did some cleanup work to remove code patch that doesn't fit
into the buffer allocation model we are moving to.
BUG=53714
TEST=Tree is green. Code still doesn't work yet.
Review URL: http://codereview.chromium.org/3393014
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/3531002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Seeing that GpuVideoDecoderHost has a very similar interface to
VideoDecodeEngine, this patch makes GpuVideoDecoderHost implments
VideoDecodeEngine.
Also did some cleanup work to remove code patch that doesn't fit
into the buffer allocation model we are moving to.
BUG=53714
TEST=Tree is green. Code still doesn't work yet.
Review URL: http://codereview.chromium.org/3393014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement ProduceVideoFrame() in GpuVideoDecoder and unit tests for testing
the loginc in GpuVideoDecoder.
BUG=53714
TEST=unit_tests --gtest_filter=GpuVideoDecoder*
Review URL: http://codereview.chromium.org/3414003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new AudioBuffersState contains current state of the audio buffers. This
object is passed all the way from the device to the audio renderer. Audio
renderer uses this information to synchronize audio.
BUG=52196,49110
TEST=see repro steps for 51637 and 52196.
Review URL: http://codereview.chromium.org/3444017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
accessibility object before sending an accessibility notification.
I accidentally commit the wrong change.
BUG=46209
TEST=interative_ui_tests:AccessibilityWinBrowserTest.TestNotificationChildrenChanged2
Review URL: http://codereview.chromium.org/3506004
TBR=ctguil@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
before sending an accessibility notification.
BUG=46209
TEST=interative_ui_tests:AccessibilityWinBrowserTest.TestNotificationChildrenChanged2
Review URL: http://codereview.chromium.org/3506004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and to know that we're handling installation and elevation warnings correctly.
BUG=54151
BUG=54332
TEST=ExtensionTest.IsPrivilegeIncrease (and others)
Review URL: http://codereview.chromium.org/3307010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/3439026/show. This file was toughed after http://codereview.chromium.org/3380001 is submitted. So, drover did not revert it.
Review URL: http://codereview.chromium.org/3441036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3394017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(corresponds to https://bugs.webkit.org/show_bug.cgi?id=45808)
No support for shared workers yet.
BUG=32277
TEST=none; layout tests will be added later.
Review URL: http://codereview.chromium.org/3394003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3448027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=56933
TEST=None
Review URL: http://codereview.chromium.org/3421036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Update WebAccessibility::ConvertState to function similarly to WebCore's AccessibleBase::get_accState.
2. Use WebKit's load complete notification to send the renderer's tree to the browser.
We enable accessibility on the renderer now instead of requesting a tree.
3. Use WebKit's focused ui element notification to send renderer focus events to the browser.
BUG=13291
BUG=38106
TEST=interactive_ui_tests:AccessibilityWinBrowserTest.TestNotificationActiveDescendantChanged
TEST=interactive_ui_tests:AccessibilityWinBrowserTest.TestNotificationFocusChanged
Review URL: http://codereview.chromium.org/3380017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebGraphicsContext3DCommandBufferImpl::initialize(Attributes, WebView*).
Built and tested Chromium with 3D CSS and WebGL to verify.
BUG=52863
TEST=none
Review URL: http://codereview.chromium.org/3443027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60559 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
view.
Client-side phishing detection needs to be able to take a snapshot of a
particular page that has a constant size and aspect ratio (e.g., 1024x768).
This CL adds a helper function (safe_browsing::GrabPhishingThumbnail)
which re-sizes the view a given size, grabs the snapshot, and then re-sizes
the view back to its previous size. Note: this function can be slow since
it might re-layout the page twice.
This function will only be called if we are very confident that the current page
is a phishing site in which case we are OK with taking a slow snapshot.
Also, this CL adds a test for the OnMsgPaintAtSize method in the RenderWidget
since it does something very similar than the new Thumbnailer.
BUG=None
TEST=GrabPhishingThumbnail
Review URL: http://codereview.chromium.org/3380001
TBR=noelutz@google.com
Review URL: http://codereview.chromium.org/3439026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
plumbing"
This reverts commit b1e231ca824b2fb9a96bffc04f26eae336ff6ed5.
Also disable the transaction_get.html test, added in this CL.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3466018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(depends on https://bugs.webkit.org/show_bug.cgi?id=44700)
TEST=IndexedDBBrowserTest.TransactionGetTest
This takes over http://codereview.chromium.org/3310022/show
Review URL: http://codereview.chromium.org/3394007
TBR=andreip@chromium.org
Review URL: http://codereview.chromium.org/3405031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(depends on https://bugs.webkit.org/show_bug.cgi?id=44700)
TEST=IndexedDBBrowserTest.TransactionGetTest
This takes over http://codereview.chromium.org/3310022/show
Review URL: http://codereview.chromium.org/3394007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The simplest one is to disable blending when the plugin is opaque. The more
complicated one is to bypass webkit painting the background of plugins when we
know the plugin to be always on top and also opaque. The always on top flag is
currently set by a new "Private2" API. Bypassing WebKit makes animations
faster.
This is a re-land of the previous patch with a trivial compilation fix. This
also adds a clip rect to the GetBitmap... function so we can properly handle
plugins in nested iframes with proper clipping.
BUG=none
TEST=none
Original review URL: http://codereview.chromium.org/3421030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
string_split.h
BUG=None
TEST=trybos
Review URL: http://codereview.chromium.org/3447008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=noelutz
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3470011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic in NavigationController::ClassifyNavigation assumes that all new pages will have an id LARGER than the maximal id that is locally cached in the SiteInstance of the active RenderViewHost.
Because page ids are doled out by incrementing a static variable that resides in the render process - see RenderView::next_page_id_ - resetting this counter while the render process is still in use will confuse the browser, and trigger the assert logic in NavigationController::ClassifyNavigation. Newly created RenderView objects in this render process will send page ids less than the value stored in SiteInstance::max_page_id during navigation operations.
This problem was manifested during the interaction of multiple instances of a chrome-extension residing in ActiveX controls. Consider navigating a Chrome-Frame instance to an extension page. Now navigate a second Chrome-Frame instance to another extension page within the same extension. If a top-level link navigation is initiated on the second CF instance, then the extension will be torn down, but the old logic would have reset the next_page_id_ counter. If a subsequent CF was navigated to a page within the same extension, it would be backed by the same extension process, yet it would be assigned an incorrect page id, as described above.
BUG=55138
TEST=none
Review URL: http://codereview.chromium.org/3442007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove logging.h and other headers where possible.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3461019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Client-side phishing detection needs to be able to take a snapshot of a
particular page that has a constant size and aspect ratio (e.g., 1024x768).
This CL adds a helper function (safe_browsing::GrabPhishingThumbnail)
which re-sizes the view a given size, grabs the snapshot, and then re-sizes
the view back to its previous size. Note: this function can be slow since
it might re-layout the page twice.
This function will only be called if we are very confident that the current page
is a phishing site in which case we are OK with taking a slow snapshot.
Also, this CL adds a test for the OnMsgPaintAtSize method in the RenderWidget
since it does something very similar than the new Thumbnailer.
BUG=None
TEST=GrabPhishingThumbnail
Review URL: http://codereview.chromium.org/3380001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This hooks up both webkit focus and content area focus like we do for NPAPI plugins.
BUG=56671
TEST=none
Review URL: http://codereview.chromium.org/3493011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix regression introduced by
http://src.chromium.org/viewvc/chrome?view=rev&revision=57788
Add a delegate interface so that chromium have more fine-grained control over
whether a V8 extension is injected into a script context. This is the
chromium-side change of webkit bug
https://bugs.webkit.org/show_bug.cgi?id=45721
BUG=37290
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/3464005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 60329.
TBR=brettw
BUG=
TEST=
Review URL: http://codereview.chromium.org/3442013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The simplest one is to disable blending when the plugin is opaque.
The more complicated one is to bypass webkit painting the background of plugins
when we know the plugin to be always on top and also opaque. The always on top
flag is currently set by a new "Private2" API. Bypassing WebKit makes
animations faster.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3421030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=52865
TEST=none
Review URL: http://codereview.chromium.org/3432021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3435022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3478003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=
Review URL: http://codereview.chromium.org/3441019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from the browser to the renderer.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3484001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a call to |setSuggestedValue| in FormManager::FillFormField(). This is a work-around to a regression caused by WebKit r67122. Once the core issue is fixed in WebKit, this work-around should be removed.
BUG=56081
TEST=Manual, double click on input field in fillable form, fill the form, notice that clicked field now fills correctly.
Review URL: http://codereview.chromium.org/3414015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=evan@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The PhishingClassifier ties together the feature extractors and the scorer,
and will be invoked by the RenderView when a page finishes loading. This
change also makes the feature extractors have a non-owned pointer to the clock
so that it can be shared, and fixes a problem where the DOM feature extractor
cleared out any already-present features.
BUG=none
TEST=PhishingClassifierTest
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60082
Review URL: http://codereview.chromium.org/3452010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebInputElement::inputType is deprecated because
HTMLInputElement::inputType is deprecated. We should stop using it
and use is<Type>() functions.
BUG=webkit.org/b/45872
TEST=none; no functional changes.
Review URL: http://codereview.chromium.org/3421023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a prerequisite to deletion of GLES2Context and WebGLES2Context
from the WebKit repository. There is a TODO, to which the video stack
team has agreed, to switch over the experimental hardware-accelerated
video decoding from WebGLES2Context to WebGraphicsContext3D.
The remaining vestige, removal of the implementation of
WebGraphicsContext3D::initialize(Attributes, WebView*), will occur
once the associated method is deleted from WebKit.
Built and tested 3D CSS and WebGL content on Mac OS X and Windows.
BUG=52863
TEST=none
Review URL: http://codereview.chromium.org/3449017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The PhishingClassifier ties together the feature extractors and the scorer,
and will be invoked by the RenderView when a page finishes loading. This
change also makes the feature extractors have a non-owned pointer to the clock
so that it can be shared, and fixes a problem where the DOM feature extractor
cleared out any already-present features.
BUG=none
TEST=PhishingClassifierTest
Review URL: http://codereview.chromium.org/3452010
TBR=bryner@chromium.org
Review URL: http://codereview.chromium.org/3436026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3389005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The PhishingClassifier ties together the feature extractors and the scorer,
and will be invoked by the RenderView when a page finishes loading. This
change also makes the feature extractors have a non-owned pointer to the clock
so that it can be shared, and fixes a problem where the DOM feature extractor
cleared out any already-present features.
BUG=none
TEST=PhishingClassifierTest
Review URL: http://codereview.chromium.org/3452010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
plugins.
Currently we use the plugin path as identifier for per-plugin content settings, which is not stable across Chrome updates or plugin moves.
The new identifier is either hardcoded (for predefined plugin groups), or the filename without path.
BUG=39252
TEST=none
Review URL: http://codereview.chromium.org/3384014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rendering directly to the passed WebViewImpl. This will allow the
compositor implementation in WebKit to switch over to using
GraphicsContext3D rather than WebGLES2Context. Once this is complete,
the old code paths will be deleted.
Tested 3D CSS demos with and without the upstream WebKit changes to
the compositor, and verified that both configurations work. This
ensures that the WebKit roll in which the compositor is switched to
GraphicsContext3D will go smoothly.
BUG=52863
TEST=none
Review URL: http://codereview.chromium.org/3425012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=56246
TEST=none
TBR=jorlow
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59939 0039d316-1c4b-4281-b951-d872f2087c98
|