summaryrefslogtreecommitdiffstats
path: root/chrome/renderer
Commit message (Collapse)AuthorAgeFilesLines
* Mac: for branded Google Chrome, handle SIGTERM in renderer to clean up Breakpad.viettrungluu@chromium.org2009-12-111-0/+137
| | | | | | | | | | | | | | | | | | | | Test: 1. Build a (branded) Google Chrome. 2. From the command-line, run: "launchctl bslist | wc -l" and note the number. 3. Start Google Chrome on a fresh profile. 4. Once a browser window has opened, do #2 again, and note the number -- it should have increased (by 2). 5. Close the tab, and do #2 again. The number should have decreased by 1. 6. Open tabs, navigate, etc., and do #2 between each stage. Whenever a new (e.g., renderer) process is started, the number should increase (e.g., when you go to a "new" site). When a process is terminated (e.g., you close the last tab for a particular site), the number should decrease. 7. Quit, and do #2 again. Hopefully, the number should be the same as the first time. (Note: when a renderer crashes, the number will not decrease -- so the number after quitting will not be the same as before starting. This is why this is only a stopgap. For comparison, do this on a branded Google Chrome without this patch; typically, the numbers will not decrease on renderer termination.) BUG=28547 TEST=See above. Review URL: http://codereview.chromium.org/484007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34318 0039d316-1c4b-4281-b951-d872f2087c98
* Handle the case of two scroll events cancelling each other out.darin@chromium.org2009-12-112-0/+21
| | | | | | | | | | R=pkasting BUG=none TEST=covered by unittests Review URL: http://codereview.chromium.org/491022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34314 0039d316-1c4b-4281-b951-d872f2087c98
* re-apply r34183estade@chromium.org2009-12-101-0/+6
| | | | | | | | | | | | | | | | | | | --------------- linux: theme scrollbars from GTK theme Pick the color of the slider's thumbpart and rail from the GTK theme. We cannot match the exact visual appearance of the GTK theme, as rendering engines can make arbitrary changes to the actual visual appearance. But by sampling a representative set of pixels, we ensure that we will at least match the general color scheme. BUG=10949 patch by <markus [at] chromium> original review: http://codereview.chromium.org/400027/show Review URL: http://codereview.chromium.org/479006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34285 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent 2 types of extension crashes.asargent@chromium.org2009-12-101-0/+14
| | | | | | | | | | | | | | | | | If javascript code puts custom toJSON functions on Array.prototype, our extension API code detects malformed requests and kills the offending renderer. Also, the browser can crash if a browser action popup process dies (for various reasons, including this json serialization problem). BUG=29283 TEST=Create an extension with a browser action popup that loads prototype.js, and then calls chrome.tabs.update(). Before this change, the popup bubble will crash, and when you click away, crash the browser too. Review URL: http://codereview.chromium.org/466065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34263 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the keyboard events handling code related to ↵suzhe@chromium.org2009-12-102-6/+23
| | | | | | | | | | | | | | | | | | | | | | | | | RenderViewHostDelegate::View and TabContentsDelegate interfaces. Significant changes made by this CL: 1. The keyboard event handling code has been moved from TabContentsView implementation classes into BrowserWindow implementation classes. Please refer to this discussion thread: http://groups.google.com/group/chromium-dev/browse_thread/thread/e6e0b5cc105659b7/9953c4308bb0000c This change makes the keyboard event flow comply with the relationship between TabContents/TabContentsView and TabContentsDelegate/BrowserWindow. Besides it, the code is also simplified a lot, for example, the keyboard event handling code in chrome/browser/views/tab_contents/tab_contents_view_{gtk,win}.cc are now merged into one copy and moved into chrome/browser/views/frame/browser_view.cc. 2. A pre-handle phrase has been added into the keyboard event handling flow. A keyboard event will be first sent to the browser for pre-handling before being sent to the renderer. Then if the event was not handled by the renderer, it'll be sent to the browser again for post-handling. 3. The keyboard accelerator handling code of Windows and Linux ports have been optimized to get rid off extra command lookup. 4. The keyboard event message flow between the browser and the renderer is changed back to full async mode, all complex logics introduced by revision 29857 are removed. BUG=24479, 26054, 26131, 28839 TEST=See bug reports. Review URL: http://codereview.chromium.org/400012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34234 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable the build of Pepper support by default (issue 464074, svn revision ↵sehr@google.com2009-12-101-12/+20
| | | | | | | | | | | | | | | | | 34161). There were problems building Skia and others for the 64-bit linux versions of the Pepper test plugin, so I have disabled building that plugin except on Windows for now and added a TODO. One significant addition to the previous comment lines. The flag enable_gpu=1 now causes the build definition ENABLE_GPU=1 to allow guarding of dependent code. BUG=none TEST=none Review URL: http://codereview.chromium.org/481001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34227 0039d316-1c4b-4281-b951-d872f2087c98
* A collection of fixes allowing the chrome.experimental.popup.* set of APIs ↵twiz@google.com2009-12-101-3/+14
| | | | | | | | to function in circumstances where there is no Browser instance present. This is a symptom of a tab-contents view hosted in an ExternalTabContainer.The major change here is the removal of the explicit dependency on a Browser instance across all of the delegates involved when showing a pop-up API. I modified the following delegates:- ExtensionPopupHost::Delegate- TabContentsDelegate- ExtensionFunctionDispatcher::DelegateBecause the pop-up requires a Profile, and a gfx::NativeWindow, I added methods to the above interfaces to provide them.BUG=noneTEST=ExtensionApiTest.FLAKY_Popup Review URL: http://codereview.chromium.org/434046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34219 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce kMaxPaintRects to test impact on single-core bot.darin@chromium.org2009-12-091-1/+1
| | | | | | | | | | TBR=brettw BUG=29589 TEST=none Review URL: http://codereview.chromium.org/479015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34204 0039d316-1c4b-4281-b951-d872f2087c98
* Limit the total number of paint rects.darin@chromium.org2009-12-093-11/+50
| | | | | | | | | | | | | | | | Based on some testing on a single core machine, reducing this number below 10 doesn't seem to help. On some of the page cycler tests (intl2 in particular), I observed some excessive paint rect counts (>50). Those outliers seem to explain the perf regression observed for single core machines. R=brettw BUG=29589 TEST=none Review URL: http://codereview.chromium.org/481002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34189 0039d316-1c4b-4281-b951-d872f2087c98
* rollback r34183estade@chromium.org2009-12-091-6/+0
| | | | | | | | tbr=asargent Review URL: http://codereview.chromium.org/482002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34187 0039d316-1c4b-4281-b951-d872f2087c98
* linux: theme scrollbars from GTK theme estade@chromium.org2009-12-091-0/+6
| | | | | | | | | | | | | | | | Pick the color of the slider's thumbpart and rail from the GTK theme. We cannot match the exact visual appearance of the GTK theme, as rendering engines can make arbitrary changes to the actual visual appearance. But by sampling a representative set of pixels, we ensure that we will at least match the general color scheme. BUG=10949 patch by <markus [at] chromium> original review: http://codereview.chromium.org/400027/show Review URL: http://codereview.chromium.org/466080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34183 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34161 - Enable Pepper support by default, including building the test ↵sehr@google.com2009-12-091-20/+12
| | | | | | | | | | | | | | | | | | | | plugin. This is needed because the NaCl plugin code that runs in the renderer needs to use Pepper APIs all the time, and NaCl support has been enabled by default for several months now. To cause an untrusted Pepper plugin to run in the renderer one needs to specify the internalpepper flag. I have also removed the enable_pepper flag from gyp. As the build of the GPU process was tied to this flag, I have renamed the flag to enable_gpu. TEST=none BUG=none Review URL: http://codereview.chromium.org/464074 TBR=sehr@google.com Review URL: http://codereview.chromium.org/475004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34162 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Pepper support by default, including building the test plugin.sehr@google.com2009-12-091-12/+20
| | | | | | | | | | | | | | | This is needed because the NaCl plugin code that runs in the renderer needs to use Pepper APIs all the time, and NaCl support has been enabled by default for several months now. To cause an untrusted Pepper plugin to run in the renderer one needs to specify the --internal-pepper flag. I have also removed the enable_pepper flag from gyp. As the build of the GPU process was tied to this flag, I have renamed the flag to enable_gpu. TEST=none BUG=none Review URL: http://codereview.chromium.org/464074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34161 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium: support custom WebCore context menu items in Chromium port ↵pfeldman@chromium.org2009-12-092-1/+10
| | | | | | | | (downstream). Review URL: http://codereview.chromium.org/465123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34154 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34146 - A place to store the pid>mach_port_t mapping.thakis@chromium.org2009-12-091-62/+0
| | | | | | | | | | | | | | | | Not yet for review. Landing to measure perf impact, will revert immediately. BUG=13156 TEST=unittests Review URL: http://codereview.chromium.org/460126 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/466088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34147 0039d316-1c4b-4281-b951-d872f2087c98
* A place to store the pid->mach_port_t mapping.thakis@chromium.org2009-12-091-0/+62
| | | | | | | | | | | | | Not yet for review. Landing to measure perf impact, will revert immediately. BUG=13156 TEST=unittests Review URL: http://codereview.chromium.org/460126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34146 0039d316-1c4b-4281-b951-d872f2087c98
* Remove DCHECK because it's invalid in single process mode.mpcomplete@chromium.org2009-12-091-1/+0
| | | | | | Review URL: http://codereview.chromium.org/460151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34123 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where content scripts would get run twice in some cases.mpcomplete@chromium.org2009-12-091-2/+7
| | | | | | | | BUG=29644 Review URL: http://codereview.chromium.org/466079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34122 0039d316-1c4b-4281-b951-d872f2087c98
* Add a 'minus' graphic to the local error page if you expand thetony@chromium.org2009-12-082-32/+56
| | | | | | | | | | | | | | "more details" link. Also add a slide transition for showing/hiding the details. BUG=28923 TEST=Turn off error pages in Options, navigate to http://dev.chromium.org:8024/ and play with the "More information on this error" link. Review URL: http://codereview.chromium.org/463045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34083 0039d316-1c4b-4281-b951-d872f2087c98
* Re-apply 34040. Now after 34055 build should succeed.mnaganov@chromium.org2009-12-083-6/+77
| | | | | | | | | | BUG=28689 TEST=none TBR=pfeldman@chromium.org Review URL: http://codereview.chromium.org/465120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34057 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34040 - DevTools: make possible profiling of scripts doing heavy ↵mnaganov@chromium.org2009-12-083-77/+6
| | | | | | | | | | | | | | | | | | | | | calculations. Start / stop profiling commands are now sent using debugger protocol, effectively breaking into script execution. Getting profiler log and active modules is executed on IO thread. BUG=28689 TEST=none Review URL: http://codereview.chromium.org/460018 TBR=mnaganov@chromium.org interactive_ui_tests all failed Review URL: http://codereview.chromium.org/467043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34041 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: make possible profiling of scripts doing heavy calculations.mnaganov@chromium.org2009-12-083-6/+77
| | | | | | | | | | | | | Start / stop profiling commands are now sent using debugger protocol, effectively breaking into script execution. Getting profiler log and active modules is executed on IO thread. BUG=28689 TEST=none Review URL: http://codereview.chromium.org/460018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34040 0039d316-1c4b-4281-b951-d872f2087c98
* Enable pepper events to flow to the plugin. Also enable printing of the eventsehr@google.com2009-12-081-1/+5
| | | | | | | | types observed at NPP_HandleEvent. Review URL: http://codereview.chromium.org/465110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34038 0039d316-1c4b-4281-b951-d872f2087c98
* Addition of a new parameter to the popup.show(...) Chrome extension API that ↵twiz@google.com2009-12-081-6/+18
| | | | | | | | | | | | | | | allows the caller to specify the behaviour of the window focus when the pop-up is displayed. I added a test for the new parameter in the ExtensionApiTest.FLAKY_Popup test. I also corrected a truncated string in the unit-test. Because the pop-up actually uses two windows, I had to change the WidgetWin::Show() routine to also reposition the window at the top. If a window is shown and activated, it is automatically brought to the front. Because we don't activate the pop-up when we want to keep the focus in the current extension view, I had to bring it to the front so that it wouldn't be hidden behind the 'chrome-bubble' window. BUG=none TEST=ExtensionApiTest.FLAKY_Popup Review URL: http://codereview.chromium.org/454019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34037 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Allow silent extension installations from the extensions gallery - ↵rafaelw@chromium.org2009-12-081-25/+0
| | | | | | | | | | | | | | | Part 1." Original CL: http://codereview.chromium.org/400018/show Looks like we're no longer hoping to get this approach into mstone4 release, so I'm unwinding this. BUG=27431 TBR=aa Review URL: http://codereview.chromium.org/467042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34025 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up V8 idle notifications for extension prcoesses.mpcomplete@chromium.org2009-12-072-26/+67
| | | | | | | | | | | | We reset the idle timer after any activity, which includes an extension event or message, or a new extension view being created. The timer runs after 10 seconds of idleness. BUG=29329 Review URL: http://codereview.chromium.org/460062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34002 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the pepper API implementation to make it more scalable as we add morebrettw@chromium.org2009-12-072-2/+79
| | | | | | | | | | | device types. Implement a stub of the 3D device API. Fix style in some of the plugin related code. TEST=run the pepper_test_plugin BUG=none Review URL: http://codereview.chromium.org/468012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33989 0039d316-1c4b-4281-b951-d872f2087c98
* WebSocket in Worker: render_thread->child_thread change.ukai@chromium.org2009-12-075-264/+2
| | | | | | | | | | | | SocketStream should be handled in ChildThread instead of RenderThread to be used in Worker process. Move SocketStream in chrome/common to satisfy check_deps. BUG=27618 TEST=none Review URL: http://codereview.chromium.org/443015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33954 0039d316-1c4b-4281-b951-d872f2087c98
* Allow silent extension installations from the extensions gallery - Part 1.rafaelw@chromium.org2009-12-071-0/+25
| | | | | | | | | | | | | | | | In this episode we: -Create a new ChildProcess privilege (SILENT_INSTALL_EXTENSION) which is granted to the extension gallery pages. -Ensure that extension gallery pages are isolated into their own process which is never shared with other urls. Important: The SILENT_INSTALL_EXTENSION privilege is never granted any additional abilities in this patch, so this patch only has the effect of grouping gallery URLs into a separate process. In subsequent patch(es) we plan to (a) observe this new privilege and allow gallery urls to install extensions bypassing the normal prompts, (b) polish this UI flow [in particular, do not show the black "loading" dilaog, (c) check the id of the extension to be installed (from the crx) matches the expected id (from gallery url). BUG=27431 Review URL: http://codereview.chromium.org/400018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33952 0039d316-1c4b-4281-b951-d872f2087c98
* Coalesce damage rects that share an edge.darin@chromium.org2009-12-072-23/+26
| | | | | | | | | | | | | | | | | | | | | | | | | This fixes the Bloat HTTP page cycler regression, and allows me to remove the hack I checked in to disable multiple-paints due to an observed DHTML page cycler regression. I added a new histogram, RW_IntermediatePaintRectCount, that would have shown the problem clearly had it been there before. I included some cleanup in PaintAggregator: 1- rename "r" to "existing_rect" for clarity 2- check for contained (i.e., redundant) invalidates up front I also changed the opacity of the paint rects used when --show-paint-rects is specified. I find myself dogfooding with this command line option enabled, and I want it to be a little less annoying but still just as useful. R=brettw BUG=29477 TEST=none Review URL: http://codereview.chromium.org/464057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33949 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash bug on user script installation and add a testaa@chromium.org2009-12-061-1/+1
| | | | | | | | | | | | | | | | to make sure it doesn't happen again. Also, re-enable a test nearby. The history has been lost of why this was failing, so it may fail again, but at least we'll have data. Finally, fix a Greasemonkey compat issue. BUG=29298 Review URL: http://codereview.chromium.org/466053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33945 0039d316-1c4b-4281-b951-d872f2087c98
* Use factory to create histograms, and refcounts to track lifetimesjar@chromium.org2009-12-061-5/+11
| | | | | | | | | | | | | | | This is CL patch 377028 by Raman Tenneti, with minor changes to make the try-bots happier. It is cleanup that better ensures lifetimes of histograms (making it harder for users to abuse them). bug=16495 (repairs leak induced by the first landing) bug=18840 (should make leaks less possible) tbr=raman.tenneti Review URL: http://codereview.chromium.org/462027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33933 0039d316-1c4b-4281-b951-d872f2087c98
* Remember zoom on a per-host basis.pkasting@chromium.org2009-12-044-24/+77
| | | | | | | | BUG=567 TEST=Visit a page, zoom in or out, then navigate to a different host. The new page should not be zoomed. Go back, or restart, or open a new tab and navigate to the old page, and it should be zoomed. Review URL: http://codereview.chromium.org/437077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33886 0039d316-1c4b-4281-b951-d872f2087c98
* Return to painting smallest bounding box when not scrolling.darin@chromium.org2009-12-041-1/+8
| | | | | | | | | | | | This is a temporary change to fix the page cycler regressions. TBR=brettw BUG=25905 TEST=none Review URL: http://codereview.chromium.org/460082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33880 0039d316-1c4b-4281-b951-d872f2087c98
* Preserve optimized scrolling in the presence of multiple animating rects.darin@chromium.org2009-12-046-89/+457
| | | | | | | | | | | | | | Change PlatformCanvas so that it only fills with "sea foam green" when bitmap data is not externally supplied. Modifying the interface to make this an option bloated the CL too much. I may do this as a follow-up. Adds a new --show-paint-rects command line flag that will render a border around paint rects to help debug and study WebKit painting issues. R=brettw BUG=25905 TEST=none Review URL: http://codereview.chromium.org/414016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33861 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid including gtk & glib headers in message_pump_glib.h, saves 1 sec on ↵mattm@chromium.org2009-12-041-0/+4
| | | | | | | | | | | do-nothing make. TEST=manual browser test, trybots BUG=none Review URL: http://codereview.chromium.org/464031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33851 0039d316-1c4b-4281-b951-d872f2087c98
* Make no-tcmalloc (really, non-base/allocator) builds work again,dank@chromium.org2009-12-031-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (i.e. this is a plain vanilla build used when layers like base/allocator are getting in the way of debugging) and make sure they use msvcrt rather than libcmt (libcmt is used to help shim malloc/free, but it gets in the way of valgrind doing the same thing). Sadly, this is now a gyp-time operation rather than a Configuration option. Had to remove hardcoded C prototype for _set_new_mode, as that caused link errors. Also add variables win_{release,debug}_{Optimization,RuntimeLibrary} to let the valgrind build override those settings. Fix calling convention on _set_new_mode to match the one in <new.h> BUG=none TEST=build with ~/.gyp/include.gypi set as described in comment in common.gypi, gclient runhooks, do release build, verify all exe's and dll's linked against msvcrt dll Review URL: http://codereview.chromium.org/455037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33719 0039d316-1c4b-4281-b951-d872f2087c98
* Send resource load notifications from plugins to devtools agent. This is a ↵yurys@chromium.org2009-12-034-9/+10
| | | | | | | | | | part of a fix which would allow to inspect plugin resources. BUG=2084 Review URL: http://codereview.chromium.org/435044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33672 0039d316-1c4b-4281-b951-d872f2087c98
* Ok, here is a different approach at this change.aa@chromium.org2009-12-022-0/+43
| | | | | | | | | | | | Instead of storing pointers into a vector, store offsets. That way, if the vector resizes, we should still be OK. Also, add a DCHECK that we only enter this method once, which is my current assumption. Review URL: http://codereview.chromium.org/457028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33541 0039d316-1c4b-4281-b951-d872f2087c98
* Update the Pepper APIs to the latest spec for the 2D demo plugin.brettw@chromium.org2009-12-012-134/+137
| | | | | | | | | | | | | | | | | | | | | This also adds the npapi headers to the npapi.gyp file since I got tired of Visual Studio not finding the files. This removes the "open file in sandbox" feature which it doesn't look like we will use. One more significant change is that I changed to including pepper.h in all cases, even when pepper is disabled. We used to have a forward declare in npapi.h for the structs in question, but we'll be adding a lot more structs for the different contexts and I don't think this will scale. I think its OK fo rthe pepper API declarations to be available when Pepper isn't enabled. BUT=none TEST=none Review URL: http://codereview.chromium.org/453015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33501 0039d316-1c4b-4281-b951-d872f2087c98
* Point #include lines to files in the new tcmalloc/chromium local branch.sgk@chromium.org2009-12-011-1/+1
| | | | | | | | | Add +third_party\tcmalloc to webkit\DEPS. BUG=27911 TEST=none Review URL: http://codereview.chromium.org/449016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33440 0039d316-1c4b-4281-b951-d872f2087c98
* Changed AudioRendererImplTest and DeferredResourceLoadingTest tests so they ↵apatrick@google.com2009-11-301-1/+9
| | | | | | | | | | | duplicate the shared memory before passing it to another object that takes ownership. Prevents same handle from being closed twice. TEST=none BUG=none Review URL: http://codereview.chromium.org/449026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33372 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: process pause script request on the IO thread. To pause already ↵yurys@chromium.org2009-11-304-12/+20
| | | | | | | | | | | running script we need to call v8::Debug::DebugBreak() on a thread different from the Render thread which may be busy with JS execution. BUG=28892 TEST=DevToolsSanityTest.TestPauseWhenScriptIsRunning Review URL: http://codereview.chromium.org/444017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33279 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33255 - Report active extensions in crash reports. This only ↵nsylvain@chromium.org2009-11-302-43/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | implements Windows right now. Mac and linux will be separate CLs. "Active" is overloaded to mean different things depending on the process type: browser: all enabled extensions renderer: unique set of extensions from all user scripts extension: extensions running in the process BUG=27169 Review URL: http://codereview.chromium.org/437078 -- There are thousands of new crashes with reivison 33256 and 33255, so i'm reverting. the crashes are in chrome_2610000!child_process_logging::SetActiveURL TBR=aa@chromium.org Review URL: http://codereview.chromium.org/448006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33269 0039d316-1c4b-4281-b951-d872f2087c98
* Add acknowledgement messages for PluginMsg_UpdateGeometry. On the Mac, usemark@chromium.org2009-11-302-9/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | these acknowledgements to know when it's safe to dump old TransportDIBs in the renderer process. The Mac TransportDIB implementation uses base::SharedMemory, which cannot be disposed of if an in-flight UpdateGeometry message refers to the shared memory file descriptor. BUG=27510, 26754 TEST=1. From bug 25710: a. Visit http://www.dkmsoftware.com/Yubotu.htm b. Click "Play Now" c. Resize vigorously. Expect: no sad plug-in icon. 2. Test case from bug 26754 (affected machines only): a. Visit http://news.google.com/ b. Click the [+] to the left of a YouTube link. On affected machines, you'll get a sad plug-in icon. c. Click the [+] to the left of a different YouTube link. Expect: no crash. 3. Test case from bug 26754 comment 9 (affected machines only): a. Have lots of bookmarks (import Safari defaults) b. Right-click on bookmark bar, and choose "Open All Bookmarks" Expect: no crash. This change may not actually fix the third test case. Review URL: http://codereview.chromium.org/417005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33264 0039d316-1c4b-4281-b951-d872f2087c98
* Report active extensions in crash reports. This only implements Windows ↵aa@chromium.org2009-11-302-0/+43
| | | | | | | | | | | | | | | | | right now. Mac and linux will be separate CLs. "Active" is overloaded to mean different things depending on the process type: - browser: all enabled extensions - renderer: unique set of extensions from all user scripts - extension: extensions running in the process BUG=27169 Review URL: http://codereview.chromium.org/437078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33255 0039d316-1c4b-4281-b951-d872f2087c98
* Make SystemMonitor not a Singleton and move it out of basephajdan.jr@chromium.org2009-11-261-3/+4
| | | | | | | | | | | | | SystemMonitor makes an assumption that through its lifetime a MessageLoop exists and stays the same. It is difficult and error-prone to satisfy that when it is a Singleton. It has caused problems in the past. Additionally, extract HighResoltionTimerManager out of time_win.cc, eliminating yet another Singleton. TEST=none BUG=none Review URL: http://codereview.chromium.org/431008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33214 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce a new 'all_frames' property to content scripts andaa@chromium.org2009-11-251-0/+4
| | | | | | | | | | | default it to false. This should improve performance in sites that use frames and elimiate confusion, since in most cases developers *don't* expect content scripts to match frames. Review URL: http://codereview.chromium.org/412008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33035 0039d316-1c4b-4281-b951-d872f2087c98
* Stab-in-the-dark at fixing a top crasher.aa@chromium.org2009-11-251-9/+23
| | | | | | | | | | | | GetCurrentRenderView() can actually return NULL, which means that GetExtensionIdForCurrentContext() can also return empty string. Hillarity ensues. BUG=28487 Review URL: http://codereview.chromium.org/441005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33034 0039d316-1c4b-4281-b951-d872f2087c98
* Assorted cleanup.estade@chromium.org2009-11-232-6/+4
| | | | | | | | process: grep for TODO(port), find cruft, clean it up Review URL: http://codereview.chromium.org/427004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32844 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 12:58:28 +0000