| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Over-reverted. Adding back in.
BUG=40306
TEST=FormManagerTest.*
TBR=jhawkins@chromium.org
Related to:
http://codereview.chromium.org/1519026
Committed revision 43922.
Review URL: http://codereview.chromium.org/1578022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37394
TEST=unit_tests + manual
Review URL: http://codereview.chromium.org/1567010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverting due to perf regression.
BUG=40306
TEST=FormManagerTest.*
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/1519026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40274
TEST=FormManager.FillFormMaxLength
Review URL: http://codereview.chromium.org/1630005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
TBR=darin
Review URL: http://codereview.chromium.org/1578019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Match both the name and the label when sending FormData values for the renderer to fill.
* Use a vector of bools to indicate which WebFormControlElements are extracted instead of matching on element name, which is not guaranteed to be unique.
BUG=38325
TEST=FormManagerTest.InferredLabelsWithSameName
Review URL: http://codereview.chromium.org/1558029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with trusted Pepper plugins. The shared memory was not being used to create
the skia bitmap due to a missing mmap() call. Adding this call (via
TransportDIB::Map()) generates the right shared mem region.
Note: this is an interim fix. Really, the browser should make the TransportDIB
as it does onthe Mac for the GPU plugin.
BUG=40701
TEST=Run any Pepper 2D application as a .nexe
Review URL: http://codereview.chromium.org/1542016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1612008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Tests that all popups (select popup, autofill, browser actions, bookmark bubble...)
work as expected and get the focus correctly.
Review URL: http://codereview.chromium.org/1523013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40306
TEST=FormManagerTest.*
Review URL: http://codereview.chromium.org/1575020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
window.open(). Such cases should inherit settings from the parent.
BUG=39740
TEST=TODO
TBR=darin
Review URL: http://codereview.chromium.org/1524014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
files).
Add UserScriptSlave unittest.
BUG=39899
TEST=List css file in content_scripts section of the manifest. Refer to an image using url(chromeextension://__MSG_@@extension_id_/image.png); within that css. @@extension_id message should be replaced with actual id of the extension.
Review URL: http://codereview.chromium.org/1585013
TBR=cira@chromium.org
Review URL: http://codereview.chromium.org/1525014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the user indicates that a page should be translated, the browser first fetches the Google Translate Element JS code.
It then sends it to the renderer, which injects the script in the page, waits for the Translate element to be initialized and then calls the translate method on it.
The TranslationService class previously used to translate text chunks is now unused and has been removed. Some of its static methods that are still used have been moved to the TranslateManager class.
This CL also implements the "revert" translation behavior.
BUG=35474,37778,35553,39375
TEST=Test the translation feature extensively.
Review URL: http://codereview.chromium.org/1599016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in extension calls
This changes the json schema validation to treat a object property set to null as significant, rather than meaning the property is not specified.
original review: http://codereview.chromium.org/1558021/show
BUG=39465
TBR=oshima
TEST=all tests should pass
Review URL: http://codereview.chromium.org/1618005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40306
TEST=FormManagerTest.Labels
Review URL: http://codereview.chromium.org/1622004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
plugins, by ensuring that an extension's plugins are shut down and unloaded when the extension unloads.
BUG=34670
BUG=32806
Review URL: http://codereview.chromium.org/1596009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=aa
BUG=none
TEST=Trivial change. Not worth verifying.
Review URL: http://codereview.chromium.org/1612007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
thread. This simplifies code that needs to do this (i.e. webkit db and file threads).
BUG=23423
Review URL: http://codereview.chromium.org/1601005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
webkitNotifications.checkPermission() & requestPermission() went awry and notification_provider.cc was no longer implementing a called method. As a result requestPermission() became non-functional.
Review URL: http://codereview.chromium.org/1542010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38352
TEST=none
Review URL: http://codereview.chromium.org/1120006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browser window
BUG=40090
TEST=none
Review URL: http://codereview.chromium.org/1567014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add UserScriptSlave unittest.
BUG=39899
TEST=List css file in content_scripts section of the manifest. Refer to an image using url(chrome-extension://__MSG_@@extension_id_/image.png); within that css. @@extension_id message should be replaced with actual id of the extension.
Review URL: http://codereview.chromium.org/1585013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in extension calls."
This reverts commit 02bd0a11dd8cee6e19c201e30b3984b638b2ddd1.
Review URL: http://codereview.chromium.org/1512019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the AutoFillManager. Don't check field labels for equality until we parse
labels again.
BUG=40297
TEST=FormManagerTest.WebFormElementToFormData
Review URL: http://codereview.chromium.org/1609007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension calls.
This changes the json schema validation to treat a object property set to null as significant, rather than meaning the property is not specified.
BUG=39465
TEST=all tests should pass
Review URL: http://codereview.chromium.org/1558021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also needs a webkit patch to do anything ( https://bugs.webkit.org/show_bug.cgi?id=37069 ), but can be landed independently.
BUG=11457,18992
TEST=(all require the webkit patch, so this won't work yet)
http://html5demos.com/drag and http://ljouanneau.com/lab/html5/demodragdrop.html
Dragging should show image
http://www.google.com/
Dragging google image should show image
http://www.travelvivi.com/wp-content/uploads/2009/09/Eiffel_Tower.jpg
Dragging image should work, drag image should be smaller than image itself
Random website
Mark some text, drag it. Should show drag cursor and no image
Review URL: http://codereview.chromium.org/1539018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dhollowa
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1520016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also changed TestSink to be derived from IPC::Channel and made MockRenderThread service AddFilter/RemoveFilter, so that it can be used by MessageFilters.
Review URL: http://codereview.chromium.org/1591009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the process of trying to do this, I discovered some unnecessary
config.h includes as well as some remaining WebCore function calls.
R=dglazkov
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1521010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43574 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Attempt to fix the perf regression: remove the code that calls LabelForElement.
TBR=dhollowa
BUG=40306
TEST=none
Review URL: http://codereview.chromium.org/1597005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
calls LabelForElement.
Repair tree bustage across mac and linux.
TBR=dhollowa
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1520015
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/1604010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dhollowa
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1520015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the FormFieldValues class and replace its usage with FormData.
BUG=38325,33032
TEST=none
Review URL: http://codereview.chromium.org/1606005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=23055
TEST=layout tests and audio won't cut off too early with this file:
http://commons.wikimedia.org/wiki/File:Montreal2.ogg
This patch fix the problem by adding an extra condition to
determine the end of playback by using the information of
buffered audio data in the browser process. If both the
renderer process and browser process don't have any more
audio data then end of playback is resulted.
Review URL: http://codereview.chromium.org/1581008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Additionally, in the extension and tabs api, compute & report UMA histogram data for relative URL use in API calls so we can decide if it's possible to change the behavior of relative url resolution to use the calling frame's url rather than the extension's base url.
Review URL: http://codereview.chromium.org/1605005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
renderer sandbox to support running Native Client.
2. Put the Native Client sel_ldr (which contains the user's untrusted code)
into a new Mac sandbox type.
3. Open /dev/random in SandboxWarmup().
4. Remove the "--nosandbox" flag when running Mac tests.
See http://codereview.chromium.org/1234003/show and
http://codereview.chromium.org/1525005/show which were both reverted because
of problems on Mac 10.6. This change is identical except for the ";NACL"
lines in renderer.sb files and the corresponding lines in nacl-loader.sb.
Unix socket support for the sandbox changed considerably from 10.5 to 10.6.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=327
TEST=nacl_ui_tests still pass while running in the sandbox.
Review URL: http://codereview.chromium.org/1559012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changelist should have no visible effect until the V8
bindings for the Database get added to the Worker context in WebKit.
BUG=none
TEST=webkit layout tests
Review URL: http://codereview.chromium.org/1387001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
page.
BUG=32362
TEST=ExtensionApiTest.History, ExtensionApiTest.Overrides, manual testing.
Review URL: http://codereview.chromium.org/1530002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implements cancelGeolocationPermissionRequestForFrame()
Queues infobars.
BUG=39686,39804
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/1573002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=39808
TEST=run browser with & withou --disable-geolocaiton.
Review URL: http://codereview.chromium.org/1534008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Removes obsolete #include.
Review URL: http://codereview.chromium.org/1589006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dhollowa
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1596002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Factor out WebFormControlElementToFormField.
* Misc. readability cleanups.
* Make FormElementToFormData static.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1595006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
step in consolidating FormData and FormFieldValues.
BUG=33032
TEST=none
Review URL: http://codereview.chromium.org/1558012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also changed TestSink to be derived from IPC::Channel and made MockRenderThread service AddFilter/RemoveFilter, so that it can be used by MessageFilters.
Also removed some logging because it triggers Valgrind errors.
Review URL: http://codereview.chromium.org/1466001
TBR=neb@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implementation checks for
whether the page id has changed and only then sends the navigation to ChromeFrame. This does not
work if the page id does not change, which could occur if the link click sends over some parameters
to the current page.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=38456
Will figure out a good way to test this and send that in a subsequent CL.
Bug=38456
Review URL: http://codereview.chromium.org/1560010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
sockets in the Mac
renderer sandbox to support running Native Client.
2. Put the Native Client sel_ldr (which contains the user's untrusted code)
into a new Mac sandbox type.
3. Open /dev/random in SandboxWarmup().
4. Remove the "nosandbox" flag when running Mac tests.
See http://codereview.chromium.org/1234003/show which was reverted because of
problems on Mac 10.6. This change is identical except for the ";NACL" lines
in the *.sb files. I've removed the 10.6specific sandbox commands and used
the generic commands that work on 10.5 and 10.6. I will work on adding the
10.6specific commands in a different change list.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=327
TEST=nacl_ui_tests still pass while running in the sandbox.
Review URL: http://codereview.chromium.org/1525005
TBR=msneck@google.com
Review URL: http://codereview.chromium.org/1572009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
renderer sandbox to support running Native Client.
2. Put the Native Client sel_ldr (which contains the user's untrusted code)
into a new Mac sandbox type.
3. Open /dev/random in SandboxWarmup().
4. Remove the "--nosandbox" flag when running Mac tests.
See http://codereview.chromium.org/1234003/show which was reverted because of
problems on Mac 10.6. This change is identical except for the ";NACL" lines
in the *.sb files. I've removed the 10.6-specific sandbox commands and used
the generic commands that work on 10.5 and 10.6. I will work on adding the
10.6-specific commands in a different change list.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=327
TEST=nacl_ui_tests still pass while running in the sandbox.
Review URL: http://codereview.chromium.org/1525005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also changed TestSink to be derived from IPC::Channel and made MockRenderThread service AddFilter/RemoveFilter, so that it can be used by MessageFilters.
Also removed some logging because it triggers Valgrind errors.
Review URL: http://codereview.chromium.org/1466001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Renames GeolocationServiceBridgeChromium.h to WebGeolocationService.h
Renames WebGeolocationServiceInterface to WebGeolocationService
TEST=geolocation_browsertest.cc
Review URL: http://codereview.chromium.org/1552002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43209 0039d316-1c4b-4281-b951-d872f2087c98
|