| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3029019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Always show a "translating..." infobar when initiating a translation from the context menu, or when the translation is automatic (always translate option). It does not make sense not to show one, as translation may take several seconds and no having any feedback during that time is confusing (also this is what translate in toolbar does).
- Don't enable the translate context menu until we get the page language. This is an effort to ensure the translate infobar delegate always get an original language.
- Makes the translate manager deals correctly with unknown languages to avoid a crasher (bug 49018)
BUG=49018
TEST=See bug. And also, start a translation from the context menu, while the page is being translated a "translating..." infobar should be shown. Also, tests that when a language was selected for "always translate", navigating to a page in that language triggers a "translating..." infobar.
Review URL: http://codereview.chromium.org/3026002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
merge).
This goes back to the M5 logic for managing Flash model negotiation on the Mac.
BUG=49169
TEST=Flash should not negotation Core Animation mode unless --enable-flash-core-animation is passed. White flickering shouldn't happen, find bar and full screen UI should show.
Review URL: http://codereview.chromium.org/3044015
TBR=viettrungluu@chromium.org
Review URL: http://codereview.chromium.org/2832074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
save form data if the form was not user-submitted.
BUG=48225
TEST=none
Review URL: http://codereview.chromium.org/2842062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This goes back to the M5 logic for managing Flash model negotiation on the Mac.
BUG=49169
TEST=Flash should not negotation Core Animation mode unless --enable-flash-core-animation is passed. White flickering shouldn't happen, find bar and full screen UI should show.
Review URL: http://codereview.chromium.org/3044015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the new NaClMainForChromium() from the NaCl tree, instead of
sel_main.cc in the Chromium tree.
Use the new variant of RegisterInternalNaClPlugin() that can receive
multiple functions instead of just one.
This depends on r2744 from NaCl.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=642
BUG=http://code.google.com/p/nativeclient/issues/detail?id=469
TEST=Chromium's nacl_ui_tests
Review URL: http://codereview.chromium.org/3039016
TBR=mseaborn@chromium.org
Review URL: http://codereview.chromium.org/2832071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the new NaClMainForChromium() from the NaCl tree, instead of
sel_main.cc in the Chromium tree.
Use the new variant of RegisterInternalNaClPlugin() that can receive
multiple functions instead of just one.
This depends on r2744 from NaCl.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=642
BUG=http://code.google.com/p/nativeclient/issues/detail?id=469
TEST=Chromium's nacl_ui_tests
Review URL: http://codereview.chromium.org/3039016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flip the compile-time enable switch for device orientation to on,
and add a command-line switch to put the functionality behind.
The command-line flag will be used both on the Chromium side,
and in WebKit via WebRuntimeFeatures.
BUG=44654
TEST=browser_tests --gtest_filter=DeviceOrientationEnableSwitchTest.*
Review URL: http://codereview.chromium.org/3042009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PDF plugin. We want to persist zoom state for PDF separately from the zoom state for other content. As a stopgap measure, disabled all browser zoom controls in that scenario.
BUG=None
TEST=Test zooming when displaying a PDF using the Chrome PDF plugin. Then load or switch to another page (non-PDF) and check that zoom works.
Review URL: http://codereview.chromium.org/3007009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
null check the opener's WebView before using it.
BUG=42974
TEST=Flaky, no known repro steps
Review URL: http://codereview.chromium.org/2850037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=38222
TEST=in the bug
Patch by George Yakovleg <georgey@chromium.org>
Review URL: http://codereview.chromium.org/2832064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
sendRequest.
BUG=46094
TEST=no
Review URL: http://codereview.chromium.org/3005022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the browser with extremely large field data.
BUG=49332
TEST=none
Review URL: http://codereview.chromium.org/2811058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=46666
TEST=none
Review URL: http://codereview.chromium.org/3007008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Don't fill CC data on non-HTTPS pages.
* Don't display non-unique suggestions in the popup.
* Fix displaying the 'AutoFill Options' suggestion (was a regression).
BUG=48499
TEST=none
Review URL: http://codereview.chromium.org/3040004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Adding a null plugin delegate to current_oldstyle_pepper_plugins_ caused a crash when the element was later dereferenced.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/2945019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TransportDIB handles are file descriptors on mac, which are duped when sent over IPC. Hence, they change their value, and the handle that comes back over IPC is not the same that was originally sent -- so they can't be used as map keys.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3037006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35316
TEST=Disable plugins, go to a site with a flash animation. You should see a placeholder for the flash animation. When you click on it, the animation should load.
Review URL: http://codereview.chromium.org/2862031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we don't provide any support to the system sqlite.
BUG=None
TEST=trybots
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/3049001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in order for it to do bind() and connect().
BUG=http://code.google.com/p/chromium/issues/detail?id=26781
TEST=all tests pass, especially nacl_ui_tests
Review URL: http://codereview.chromium.org/2881016
TBR=msneck@google.com
Review URL: http://codereview.chromium.org/2842059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in order for it to do bind() and connect().
BUG=http://code.google.com/p/chromium/issues/detail?id=26781
TEST=all tests pass, especially nacl_ui_tests
Review URL: http://codereview.chromium.org/2881016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=408198
TEST=Extensions context menu API should work with changes described.
Review URL: http://codereview.chromium.org/2811049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=49012
TEST=See bug.
Original review:
http://codereview.chromium.org/2819051
Review URL: http://codereview.chromium.org/3040007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=48725,39508
Review URL: http://codereview.chromium.org/2840038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52784 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is currently off by default and one must pass in a flag
(--enable-search-provider-api-v2) to use it. Api details are
in the bug.
BUG=38475
TEST=ui_tests --gtest_filter=SearchProviderTest.TestIsSearchProviderInstalled
Review URL: http://codereview.chromium.org/2823042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, anyone who included tab_contents.h would bring in a bunch of
implementation details of the password manager from webkit_glue. This breaks
the delegate interface out of the rest of password manager system and makes
FillData not an inner-class so anyone can forward declare FillData instead of
having to include the header to meet a delegate interface.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2877022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3019001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=41663,48726
Review URL: http://codereview.chromium.org/2982008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
internal state correctly.
BUG=48886
TEST=delete an entry from the autofill/autocomplete popup then chose
'AutoFill Options' or 'Clear form' and make sure it works.
Review URL: http://codereview.chromium.org/3015004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52591 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
description and bug association. Will re-land with correct
information.
TBR=thakis@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hack we were doing before.
This has a side-effect of fixing a bunch of content-interaction
bugs because we will be using real user-level styles (in the
CSS sense) rather than content-level styles.
BUG=29995
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52581
Review URL: http://codereview.chromium.org/2932007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hack we were doing before.
This has a side-effect of fixing a bunch of content-interaction
bugs because we will be using real user-level styles (in the
CSS sense) rather than content-level styles.
BUG=29995
Review URL: http://codereview.chromium.org/2932007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2891016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52575 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a nacl permission.
BUG=45881
TEST=None
Review URL: http://codereview.chromium.org/2941011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=39885
Pause for audio is now in effect in less than 200ms.
Seek for audio is also much better as we play also very short amount
after seek.
Review URL: http://codereview.chromium.org/2931014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
My previous 1st refactor step of the password autofill broke
the feature by removing the call to fill the form.
BUG=49173
TEST=See bug.
Review URL: http://codereview.chromium.org/2812053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52543 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=48857
TEST=none
Review URL: http://codereview.chromium.org/3017003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the CONNECTED state.
I modified things so that GpuChannelHost goes into the CONNECTED state as soon as the SyncChannel is created. This is safe because any IPC messages that are send are just queued up in the named pipe.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/2959016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Test printing with Chrome PDF Pepper v2 plugin.
Review URL: http://codereview.chromium.org/2819047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebPluginDelegatePepper::Device3DInitializeContext error case.
CID=8366
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2802035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebPluginDelegatePepper::Device3DCreateContext override arg.
CID=8540
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2881014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RendererWebIDBDatabaseImpl methods.
CID=9390,9389,9388,10844,10845,10846,10847
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2891023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously committed as r52349 and r52336. Related commits: r52367, r52364
and r52343.
Rerunning trybots due to previous trybot breakage.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2965015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Erik ran into a problem related to this while working on some changes to
permissions handling for event listening.
BUG=none
TEST=Context Menus API onclick callbacks should work normally.
Review URL: http://codereview.chromium.org/2963012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To make recycle work, we had to define the usage scope of current frame. otherwise we are introducing tearing because we will begin to decode into the buffer before it is done by the renderer/painter/compositor.
current mechanism depends on hold reference of a copied picture. we had no that luxury if we do not copy output buffers. we had to compromise by
1. in pause() ( which is not the sense of pipeline->pause(), which is implemented by set playrate = 0 ) in filter->pause() ( or in the future flush() ), which is part of seeking ( and in the future, part of stop() too) , we had to return all the buffers to owner. we had no current buffer to display. we use NULL as current frame in this case.
2. remove black frame from render base, this is only valid for system memory based video frame, even that should we use color fill instead of color conversion and scale.
3. pause and stop has to wait for pending read (actually flush) and pending paint.
4. we only advance frame when there are two or more frames in ready queue.
Review URL: http://codereview.chromium.org/2836038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the contextMenus.create method to synchronously return an id
instead of aysynchronously in the callback. This meant moving the generating of
id's from a globally unique integer in C++ code to an extension-unique integer
in javascript. The C++ unique id thus becomes a pair of <extension_id,int>.
Also a couple of small drive-by cleanups while I was in some of the files.
BUG=48198
TEST=The context menu API should work normally, given the changes described
above.
Review URL: http://codereview.chromium.org/2911007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2982009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Update the chrome code search sample extension to have some fancier
highlighting.
TEST=none
Review URL: http://codereview.chromium.org/2944012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2934018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(I accidentally committed a previous version of the patch (the fixed version
was in codereview since I had switched to my mac to address this exact compile
failure.)
BUG=none
TEST=none
TBR=evan
Review URL: http://codereview.chromium.org/2937010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52349 0039d316-1c4b-4281-b951-d872f2087c98
|