| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Before we carefully used the app (Chrome/Chromium) name, but:
1) these are for internal debugging use only, so why compute this name
2) on Linux the thread ids are limited to 16 characters, and "Chromium"
is too long
Review URL: http://codereview.chromium.org/2741003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is a clone of
http://codereview.chromium.org/2607001/show
which was reviewd and LGTM'ed by Jeremy Orlow.
Review URL: http://codereview.chromium.org/2740003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The strongbad demo plays an audio file of 11kHz. However we hardcoded
in the AudioRendererHost to always open an audio device of 8k samples
which happens to be too big for streams of 11khz. This makes the IPC
transport packet size much smaller than the hardware buffer size and
hardware packet is always partially filled.
This change allow the AudioRendererHost to designate the transport
packet size based on the hardware packet size. The hardware packet
size is now adjusted based on the sample rate.
BUG=46007
TEST=http://smokescreen.us/demos/sb45demo.html
The above audio plays fine.
Review URL: http://codereview.chromium.org/2651001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- simplify the y geolocation IPC protocol, by using the error code already in Geoposition
- convert Geoposition's error_message to UTF8 as this is easier alround
- simplify the dispatcher host render id set (as the process_id part is implicit from the dispatcher host instance)
BUG=40103
TEST=unit_tests --gtest_filter=*Geol*
Review URL: http://codereview.chromium.org/2648002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently Chrome, Firefox, and IE8 have the number of outgoing connections to each host(server) set at 6.
Safari uses 4, and Fasterfox (a plugin for Firefox that supposedly
configures it to run faster) uses 8. We would like to see how much of an
effect this value has on browsing. Too large a value might cause us to
run into SYN flood detection mechanisms. This experiment assigns a value of (4, 6, 8, 16) at random at program launch, and uses it throughout the run.
r=jar
Review URL: http://codereview.chromium.org/2685005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
To be able to stop on top-level breakpoints We need to enable javascript debugger before
any scripts are executed. That's why DebuggerScript.js contents should be retrieved synchronously.
Review URL: http://codereview.chromium.org/2609001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
directory.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/2657003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes a small TODO in the benchmarking extension. Keep the disk cache
turned on during benchmarking, and doom all entries between benchmark
runs, rather than disabling it entirely.
BUG=none
TEST=All tests pass.
Review URL: http://codereview.chromium.org/669115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I believe the following CL had accidentally broken them:
http://src.chromium.org/viewvc/chrome?view=rev&revision=47972
I haven't yet added end-to-end tests for the context menu API that would catch
problems like this, but I just created a bug for that (crbug.com/45811) and
made the bug for bringing the API out of experimental blocked on it.
I also fixed a small >80 chars style nit in this CL.
BUG=45741
TEST=The onclick handler for an extension-added context menu item should now
be called. See the bug for a minimal code snippet to put into a background page
for this.
Review URL: http://codereview.chromium.org/2626001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
computation which originally assumed that source coordinate
as windows coordinate, but actually it was o screen coordinate.
This patch should wait for https://bugs.webkit.org/show_bug.cgi?id=39725.
BUG=37320
TEST=none
Original patch written by morrita@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=willchan
Review URL: http://codereview.chromium.org/2113017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48861 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Now it happens before the command buffer is initialized, which fixes an occasional race condition in Pepper 3D plugins that are not animated.
TEST=try
BUG=none
Review URL: http://codereview.chromium.org/2461003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48848 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
reasons.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2444005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This adds IDBIndex support. The majority of this CL was boilerplate type code in indexed_db_dispatcher_host so I did my best to factor it into template functions and split things into multiple sub-dispatcher hosts.
Review URL: http://codereview.chromium.org/2449005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change just pulls the hunspell dictionaries moved by my r48011.
TBR=estade
BUG=44543
TEST=none
Review URL: http://codereview.chromium.org/2074023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
selection. Refactor form field enumeration into ForEachMatchingFormField().
BUG=38582
TEST=FormManagerTest.PreviewForm
Review URL: http://codereview.chromium.org/2138005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
into SVG and raw XML documents as well.
Injecting into SVG could conceivably be a feature, but I expect it would count as a "bug" more often than that, so I'm starting conservative.
BUG=39845
Review URL: http://codereview.chromium.org/2389004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45142
TEST=FormManagerTest.FillForm
Review URL: http://codereview.chromium.org/2453004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38857
TEST=none
Review URL: http://codereview.chromium.org/2387002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
pointless comment about use of ARRAYSIZE_UNSAFE().
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2364003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The notification that the focus changed in the page now uses webkit::WebViewClient::focusedNodeChanged() implemented by RenderView.
It was previously relying on the more general webkit::WebWidgetClient::didFocus() implemented in RenderWidget. (that should ideally only be fired when the frame gets focused, not everytime the focus in the frame changes).
BUG=None
TEST=Interactive UI tests should still pass (especially BrowserFocus*)
Review URL: http://codereview.chromium.org/2301001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
WebKit roll 60462:60647
Original review: http://codereview.chromium.org/2422001
Review URL: http://codereview.chromium.org/2459002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2429001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
pixels on Windows and points on the Mac). Also fixed a bug with Mac dpi calculation.
BUG=None.
TEST=Test printing on Windows and Mac.
Review URL: http://codereview.chromium.org/2351003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None.
TEST=Test printing from a Pepper plugin that supports the raster print interface on a Mac.
Review URL: http://codereview.chromium.org/2349003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2361002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Includes:
- Makes it so that the PaintAtSize message does what it should do:
render the page at the size given and then scale (in the render
process) the result to the desired size.
- Changed some of the timeouts for updating snapshots to help with
performance
- Reduced the number of cases where we refresh snapshots in response
to tabs changing.
- Removed the need to force updates whenever we switch to overview
mode, which makes it faster, and avoids the "shuffling" effect.
- Started listening to TAB_CONTENTS_CONNECTED in order to detect new
browsers, instead of BROWSER_WINDOW_READY, because there were still
times when the tab contents didn't have any dimensions by the time
BROWSER_WINDOW_READY was sent. This helps fix the bug referenced
below.
- Stopped updating snapshots in active mode. Now we just invalidate
the snapshots and render them when we enter overview mode.
- Added a parameter to indicate whether we prefer using the backing
store or not when asking for snapshots from the thumbnail generator.
- Added tracking of a timestamp for events from the window manager so
we can avoid racing.
TEST=ran in chromeos under WM and verified snapshot contents
BUG=chromium-os:3142, 3136
Review URL: http://codereview.chromium.org/2098006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was important because the browser process couldn't keep up
with the input stream, resulting in poor 2 finger scroll
behavior. It's now tuned to the settings in cros.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/2239001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
features to work on, but it's in a usable state.
When an extension is installed that specifies an omnibox keyword in its manifest, we add that keyword to the user's list of Search Engines. The user can then edit this keyword later.
I'm leveraging most of the original search engine keyword code. An extension keyword has a special URL that identifies it as an extension keyword. There is some special case code to treat these keywords slightly differently throughout
the omnibox code.
BUG=38884
Review URL: http://codereview.chromium.org/2078021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
action is these days.
Review URL: http://codereview.chromium.org/2373003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Querying the plugin path and actual mime type is moved from creation of the
WebPluginDelegate to creation of the WebPlugin. This cleaned up some code.
R=jam
BUG=45289
TEST=none
Review URL: http://codereview.chromium.org/2262002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
or non-empty fields.
BUG=45143
TEST=FormManagerTest.FillForm
Review URL: http://codereview.chromium.org/2348001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
platform specific shortcut. Also, this makes copying through the page menu work on Mac and Linux.
Review URL: http://codereview.chromium.org/2329001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The mcphee.com site demonstrates two issues. One is label scraping for forms that use <dl> <dt> and <dd> elements to partition labels and input elements. The other is dynamic html where JavaScript is used to manipulate the form elements dynamically as the user proceeds through checkout. These changes address both. Label scraping is implemented for <dl> <dt> and <dd> elements. Form filling, both at the FormManager and AutoFillManager levels are now more robust in the face of changing form structure between the time of page load and form fill.
This does not "fix" the mcphee page though, as we still do not fill the elements that are added to the page after the initial page load.
BUG=44323
TEST=AutoFillManagerTest.FormChangesRemoveField, AutoFillManagerTest.FormChangesAddField, FormManagerTest.LabelsInferredFromTableCellNested, FormManagerTest.LabelsInferredFromDefinitionList, FormManagerTest.FillFormChangedFormDataFields, manual tests using mphee.html and mcphee2.html sample files attached to bug report and original bug steps using live mcphee checkout.
Review URL: http://codereview.chromium.org/2240004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2299001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Remove modify_database flag.
Make sure we delete data structures on the WebKit thread.
Handle single process mode.
Review URL: http://codereview.chromium.org/2125017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
make sure that devtools client is detached from devtools agent if inspected render view is closing. It is necessary because render thread may be blocked by a script staying on a breakpoint in which case close message will never be dispatched(close message is posted as a non nestable task so it cannot be processed in the message loop in ScriptDebugServer).
Review URL: http://codereview.chromium.org/2238002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
1. install permanent buffer exchange callback.
2. render provide buffer in read=>fillthisbuffer.
3. for ffmpeg path, the provided buffer is just dummy. it had no relation to decoded buffer. so as to keep the code almost same.
Review URL: http://codereview.chromium.org/2101022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2271002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The caller can use the much shorter "gfx::Rect(size())", since gfx::Rect
has a constructor that just takes a Size.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2204001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
events back to the browser.
This isn't a problem on OSX because we clear the compositon before
sending WebCompositionCommandDiscard (hbono even asked about this
during the OSX review).
BUG=45003
Review URL: http://codereview.chromium.org/2247003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2191001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(http://codereview.chromium.org/2137012/show).
TEST=none
BUG=36301
Review URL: http://codereview.chromium.org/2214001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Change GTK+ theme while text is selected. The text selection colors
should change.
Review URL: http://codereview.chromium.org/2190001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
as failing.
TBR=jcivelli
BUG=36520
TEST=FormAutocompleteTest.AutoCompleteOffInputSubmit
Review URL: http://codereview.chromium.org/2191002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
attributes.
On these pages we were hitting the DCHECK_EQ in autofill_manager.cc:237 when filling these forms. This was due to the lack of <input> elements with
autoComplete="off" attributes set when originally sending the form data with the RenderView::SendForms() call. This changes the renderer to add
these elements when originally sent and processed by the AutoFillManager::FormsSeen() call.
BUG=40700, 41702
TEST=Manual tests of pages in bug reports.
Review URL: http://codereview.chromium.org/2135012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new work will take a very different approach (using a component extension,
similar to the bookmark manager).
This basically reverts the following commits:
- http://src.chromium.org/viewvc/chrome?view=rev&revision=20595
(http://codereview.chromium.org/155067)
- http://src.chromium.org/viewvc/chrome?view=rev&revision=19918
(http://codereview.chromium.org/155051)
- http://src.chromium.org/viewvc/chrome?view=rev&revision=19906
(http://codereview.chromium.org/150207)
BUG=173
TEST=everything still builds
Review URL: http://codereview.chromium.org/2156003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Focus on printing tests. The ones I didn't port may not be worth the effort if we are going to change Linux printing soon.
BUG=none
TEST=tests pass
Review URL: http://codereview.chromium.org/2066016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Associate a RequestContext with a WorkerProcessHost. This corresponds to themain request context of the profile for which the worker process is running. Also associate the context with each WorkerInstance which comes into existance priorto the WorkerProcessHost that will host the instance.
* Give the WorkerProcessHost an AppCacheDispatcherHost.
* Fix up some recently botched IPC plumbing for ViewHostMsg_CreateWorker_Params.
BUG=39368
TEST=there are no worker unit tests
Review URL: http://codereview.chromium.org/2010010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since polling is required only for the preferred height and mac only needs preferred width, add a flag that specifies if the client is interested in width and/or height.
This is a band-aid, the Real Fix is tracked in 44850.
BUG=44494
TEST=Open chrome's task manager. Idle renderer processes should take close to 0 %cpu instead of ~1.5 before.
Review URL: http://codereview.chromium.org/2145002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48056 0039d316-1c4b-4281-b951-d872f2087c98
|