summaryrefslogtreecommitdiffstats
path: root/chrome/renderer
Commit message (Collapse)AuthorAgeFilesLines
* Remove base versions of the graphics headers, which previously just ↵brettw@google.com2008-11-222-3/+3
| | | | | | | | forwarded to the skia ones. Review URL: http://codereview.chromium.org/11588 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5894 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of wide characters in stats table identifiers.evanm@google.com2008-11-221-2/+2
| | | | | | | Review URL: http://codereview.chromium.org/11544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5880 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback "Remove use of wide characters in stats table identifiers."evanm@google.com2008-11-211-2/+2
| | | | | | | This reverts commit r5847. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5850 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of wide characters in stats table identifiers.evanm@google.com2008-11-211-2/+2
| | | | | | | Review URL: http://codereview.chromium.org/11544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5847 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb WebCore's windowResizerRect() through glue and renderer. Enables Mac ↵pinkerton@google.com2008-11-212-0/+6
| | | | | | | | scrollbars to not overlap the in-window resizer widget. Review URL: http://codereview.chromium.org/11353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5831 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 5607 because it caused a base_unittest failure.maruel@chromium.org2008-11-181-1/+0
| | | | | | Review URL: http://codereview.chromium.org/11234 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5608 0039d316-1c4b-4281-b951-d872f2087c98
* Add superficial unit test for PrintJob. That's a start.maruel@chromium.org2008-11-181-0/+1
| | | | | | | Add more DCHECKs. Review URL: http://codereview.chromium.org/10957 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5607 0039d316-1c4b-4281-b951-d872f2087c98
* A workaround fix for Issue 343 "Chinese Sogou input method lose first ↵hbono@chromium.org2008-11-173-3/+12
| | | | | | | | | | | | | | initial letter". This issue is caused by our IME code that does not filter out focus events raised by an IME function of WebKit, WebCore::Editor::setComposition(). Its details are listed below: 1. WebKit sometimes creates a WebCore::EditingText instance and moves the input focus to the instance while updating a composition string in the Editor::setComposition() function; 2. Our IME code automatically finishes the ongoing composition everytime when WebKit moves the input focus to the WebCore::EditingText instance. As a wordaround for this issue, this change ignores focus events while a renderer process updates a composition string with the Editor::setComposition() function. Review URL: http://codereview.chromium.org/10827 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5556 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/10958mbelshe@google.com2008-11-141-4/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5509 0039d316-1c4b-4281-b951-d872f2087c98
* Change to integrate SystemMonitor changes into chrome.mbelshe@google.com2008-11-141-0/+4
| | | | | | | | | | | | This enables the dynamic detection of battery status changes so that we can turn on/off the hi-res timer. Review URL: http://codereview.chromium.org/10264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5489 0039d316-1c4b-4281-b951-d872f2087c98
* Add Terminate() to the Process object, have RenderProcessHost use this to ↵brettw@google.com2008-11-1416-55/+53
| | | | | | | | | | avoid some more Windows specific code. Move Process and SharedMemory into the base namespace (most changes). Review URL: http://codereview.chromium.org/10895 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5446 0039d316-1c4b-4281-b951-d872f2087c98
* Re-do the way browser windows are shown:ben@chromium.org2008-11-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove the path from WinMain to the Browser object passing the show_command. For the Browser object, this is a problem since this value isn't portable. For the code in general it involves a lot of ugly wiring. It's completely unnecessary since the value is obtainable via GetStartupInfo. - Remove show_command plumbing from all over the place (session restore, web app launcher, etc) Change the way browser windows are constructed: - The browser constructor now takes just a type and a profile, and simply initializes the object. - Some configuration that used to be part of the constructor that was only used in one or two use cases (initial bounds, maximized state, web app name) are split into separate setters. - Window creation is split out into a separate step to be called post configuration. - Assorted static helper functions added to Browser to make construction of common types easy. - Remove Browser::Show in favor of BrowserWindow::Show - Adjust all callers to use the new helpers. Change the way ChromeViews restores window placement: - Split restored size determination from restored maximized determination. They are needed by the code at different times. Size restoration happens when the window is constructed and Window::SetInitialBounds is called. Maximized state restoration happens when the window is shown for the first time and SW_SHOWMAXIMIZED or SW_SHOWNORMAL is needed. Thus, replace WindowDelegate::RestoreWindowPosition with WindowDelegate::RestoreWindowBounds and WindowDelegate::RestoreMaximizedState. - Window::SetInitialBounds calls WindowDelegate::RestoreWindowBounds - Window::Show calls WindowDelegate::RestoreMaximizedState - Adjusts all WindowDelegate implementations that override RestoreWindowPosition to implement these new methods instead. - Move "playback/record" mode window size setting from browser_init to Browser::RestoreWindowBounds. - Provide a virtual function on Window called GetShowState that determines the default show state to be used when Window::Show is called. For most windows and dialogs this is SW_SHOWNORMAL. AeroGlassFrame/OpaqueFrame (the browser window frames) override this since they're the app's main windows to return the value provided by GetStartupInfo which gives the value from the app shortcut. http://crbug.com/3557 Review URL: http://codereview.chromium.org/10896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5417 0039d316-1c4b-4281-b951-d872f2087c98
* * Copy webkit_glue font functions into ChromiumBridge.erikkay@google.com2008-11-133-61/+0
| | | | | | | | | * removed a few unneeded headers from MIMETypeRegistry * removed all uses of IMLangFontLang2 Review URL: http://codereview.chromium.org/10661 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5369 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent crash due to DIB allocation failure joshia@google.com2008-11-123-11/+23
| | | | | | | | | | | | | Change the way we capture tab thumbnail images so that the capturing code can deal with failure. BUG=3795 Review URL: http://codereview.chromium.org/9717 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5244 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/10005petersont@google.com2008-11-112-3/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5151 0039d316-1c4b-4281-b951-d872f2087c98
* Change old code from "unloadListnerChanged" model to new WebKit ↵erikkay@google.com2008-11-102-19/+8
| | | | | | | | | | | EnableSuddenTermination, unforking a bunch of code. BUG=http://crbug.com/4064 Review URL: http://codereview.chromium.org/9746 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5116 0039d316-1c4b-4281-b951-d872f2087c98
* Don't crash on chrome.exe --type=renderer. Don't try to GlobalCleanup() if ↵deanm@chromium.org2008-11-101-1/+2
| | | | | | | | GlobalInit() wasn't successful. Review URL: http://codereview.chromium.org/10247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5104 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/10237petersont@google.com2008-11-082-11/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5059 0039d316-1c4b-4281-b951-d872f2087c98
* Entries in a form get recorded when the user submits the form. Database and ↵petersont@google.com2008-11-082-3/+11
| | | | | | | | pop-up menu talk to each other. Pop-up menu appears containing suggestions. Review URL: http://codereview.chromium.org/9462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5058 0039d316-1c4b-4281-b951-d872f2087c98
* Landing this again as I cannot reproduce the perf regression locally.jcampan@chromium.org2008-11-075-14/+68
| | | | | | | | | | | Will investigate on the bot. TBR=nsylvain Review URL: http://codereview.chromium.org/9700 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5018 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the autofill popu CL as it creates perf regression.jcampan@chromium.org2008-11-065-68/+14
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/9460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4908 0039d316-1c4b-4281-b951-d872f2087c98
* Changed the call to attach the debugger to V8 to run in the renderer thread. ↵sgjesse@chromium.org2008-11-062-2/+21
| | | | | | | | | | | | | With V8 r648 (Review URL: http://codereview.chromium.org/8909) attaching the debugger to V8 will initialize V8 if not already initialized. This needs to be serialized with the initialization of V8 in the renderer thread. This change does not require the changes in V8 r648, but will not have any effect without. Added a few comments. BUG=3723 Review URL: http://codereview.chromium.org/8735 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4875 0039d316-1c4b-4281-b951-d872f2087c98
* Changes parameters used by IME code to fix several issues caused by Japanese ↵hbono@chromium.org2008-11-061-19/+23
| | | | | | | | | | | | | | IMEs. Recent Japanese IMEs (ATOK2008 and MSIME 2007) display a suggestion window (a window which contains suggestions) above a composition string. To fix this issue, we do not only send the lower-left corner of a composition string but also send its upper-left corner and its upper-right corner. So, this change changes IPC parameters used by IME from a tuple of integers to gfx::Rect. Also, this change fixes cursor positions for Japanese IMEs. BUG=2770 "IME: Candidate window of Japanese IME follows the end of composition" BUG=2771 "ATOK 2008 IME pop-ups are displayed below the main Chrome window." BUG=2775 "IME: Caret is always displayed at the last of IME composition." Review URL: http://codereview.chromium.org/7385 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4872 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds the autofill UI in forms.jcampan@chromium.org2008-11-055-14/+68
| | | | | | | | | | | | When the user types text in a text field in a form, the renderer queries the browser for suggestion based on the entered text and displays the suggestions in a popup. Listeners are set on the form text field in a similar fashion than for password save. The popup showing the suggestion uses the same mechanism as the select popup. Note that a difference between the select and the autofill popup is that the autofill should not take focus, so the page still has focus and the user can still type in while it shows. The creation of the render widget was modified for that purpose so we can specify the popup should not be focused when shown. Review URL: http://codereview.chromium.org/8885 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4804 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrote the clipboard API to be more concurrent. Added a helper class to ↵estade@chromium.org2008-11-051-52/+67
| | | | | | | | make it more foolproof. Updated all clients and unittests. Mac port by jeremy@chromium.org Review URL: http://codereview.chromium.org/9154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4719 0039d316-1c4b-4281-b951-d872f2087c98
* Finish unforking the async history item changes.mpcomplete@google.com2008-11-042-3/+6
| | | | | | | BUG=3912 Review URL: http://codereview.chromium.org/9273 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4530 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for crash in NPN_Invoke. This happened because the window script ↵jam@chromium.org2008-11-041-13/+15
| | | | | | | | | | NPObject was deallocated by the script controller but WebPluginDelegateProxy wasn't telling NPObjectStub that it's contained object was garbage soon enough. BUG=1036087 Review URL: http://codereview.chromium.org/9066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4526 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome\renderer to new SCons naming.sgk@google.com2008-11-032-74/+109
| | | | | | Review URL: http://codereview.chromium.org/9053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4510 0039d316-1c4b-4281-b951-d872f2087c98
* Change some places where we were using javascript: URLs to useaa@google.com2008-11-034-12/+11
| | | | | | | | WebFrame::ExecuteJavaScript() instead. Review URL: http://codereview.chromium.org/8826 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4480 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for @include in Greasemonkey scripts.aa@google.com2008-11-033-13/+215
| | | | | | Review URL: http://codereview.chromium.org/8020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4478 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the VerifyHistoryLength ui test flakiness. The test initiates ↵ananta@chromium.org2008-10-311-0/+15
| | | | | | | | | | | | | | page navigations in timers and reads the history length to validate it. When we receive a request to initiate a navigation in the browser, we send out the request to the renderer and then immediately read the history length and send it out in an update history length request. This causes the test to fail at times as it reads a stale history length. When we receive the DidAddHistoryItem notification in the renderer, we should not update the history length for the start page navigation. This results in the test failure at times as it reads an incorrect history length. R=jam Review URL: http://codereview.chromium.org/8898 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4344 0039d316-1c4b-4281-b951-d872f2087c98
* Takes steps to make our PlatformScreen implementation more portable.darin@chromium.org2008-10-311-5/+4
| | | | | | | | | | | | | | | | | | Introduces ChromiumBridge as a means for our WebCore port to depend on the embedder indirectly. This will be extended to support the rest of our port. WebWidgetImpl and ChromeClientImpl both needed to have their platformWindow getter implemented. This fixes a regression related to the most recent merge. Removes the orphaned Language.cpp (see the real one in the platform/chromium directory. Changed webkit_glue::GetMonitorInfoForWindow to webkit_glue::GetScreenInfo. This resulted in a varied amount of plumbing changes. It also pushes the platform specific bits up into the browser where they belong. ScreenInfo is a struct that is part of the webkit/glue API. R=dglazkov,eseidel Review URL: http://codereview.chromium.org/8761 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4335 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of the CL to unfork our changes to FrameLoader.cpp to support thempcomplete@google.com2008-10-312-3/+24
| | | | | | | | | | | | | | window.history object. I've reverted our original changes and gone with a different approach. The idea is to fake the HistoryItem that FrameLoader asks for synchronously, and give it a special URL that we can intercept later and do the back/forward navigation. BUG=3912 Review URL: http://codereview.chromium.org/8756 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4308 0039d316-1c4b-4281-b951-d872f2087c98
* A fix for Issue 3234 in chromium "Input type password: IME is not disabled."hbono@chromium.org2008-10-311-7/+3
| | | | | | | | This issue is caused by my bonehead mistake that I forgot removing my legacy code, which raises a false event to Chrome. Sorry. This change also fixes a crash that happens in Google Sites. Review URL: http://codereview.chromium.org/8745 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4301 0039d316-1c4b-4281-b951-d872f2087c98
* Make ImageBuffer creation and handling conform to proper WebKit form rather ↵brettw@google.com2008-10-311-3/+2
| | | | | | | | | | than using tacked-on functions on GraphicsContext. Clean up the associated GraphicsContext objects. Merge SkGraphicsContext, SkPaintContext, and PlatformContextSkia into one class, PlatformContextSkia. This tries to change no code related to this, the code in PlatformContextSkia is just a concatenation of those existing files, and hopefully doesn't need much review. This file is in the wrong style and is a terrible mess, I will clean it up in successive passes so it can be reviewed reasonably. Review URL: http://codereview.chromium.org/8754 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4270 0039d316-1c4b-4281-b951-d872f2087c98
* Accumulated SCons changes for Windows chrome build, round II:sgk@google.com2008-10-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Includes other recent additions, and doesn't fix everything, but gets significant pieces back on track: * New/additional library dependencies in various test executables (too many to be worth listing). * Portability: put library base names in $LIBS instead of explicitly listing .lib files. * Have interactive_ui re-use various object files from test/ui instead of (re-)listing the .cc files. * Add new files: chrome\browser\bookmarks\bookmark_drag_data.cc chrome\browser\bookmarks\bookmark_drag_utils.cc chrome\browser\bookmarks\bookmark_table_model.cc chrome\browser\browser_trial.cc chrome\browser\download\download_request_manager_unittest.cc chrome\browser\greasmonkey_master.cc chrome\browser\spellcheck_unittest.cc chrome\browser\views\find_bar_view.cc chrome\browser\views\find_bar_win.cc chrome\renderer\greasemonkey_slave.cc * Remove old files: chrome\browser\find_in_page_controller.cc chrome\browser\find_in_page_view.cc chrome\renderer\spellcheck_unittest.cc * Remove relative reference to ../../app/google_update_settings$OBJSUFFIX. * Get rid of by-hand /IMPLIB and /MAP flags. * Prefix / suffix portability in the jscre library. * Rename $LIBXML_DIR/scons => $LIBXML_DIR/DerivedSources. * Add $CHROME_DIR/app/resources to CPPPATH. * Add icu38 directories to CPPPATH for building chrome/views files. Review URL: http://codereview.chromium.org/8742 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4215 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r4205 to track down buildbot unit_tests failure.sgk@google.com2008-10-301-1/+0
| | | | | | Review URL: http://codereview.chromium.org/8730 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4206 0039d316-1c4b-4281-b951-d872f2087c98
* Accumulated SCons changes for Windows chrome build and othersgk@google.com2008-10-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | recent additions (doesn't fix everything, but gets significant pieces back on track). * New/additional library dependencies in various test executables (too many to be worth listing). * Portability: put library base names in $LIBS instead of explicitly listing .lib files. * Have interactive_ui re-use various object files from test/ui instead of (re-)listing the .cc files. * Add new files: chrome\browser\bookmarks\bookmark_drag_data.cc chrome\browser\bookmarks\bookmark_drag_utils.cc chrome\browser\bookmarks\bookmark_table_model.cc chrome\browser\browser_trial.cc chrome\browser\download\download_request_manager_unittest.cc chrome\browser\greasmonkey_master.cc chrome\browser\spellcheck_unittest.cc chrome\browser\views\find_bar_view.cc chrome\browser\views\find_bar_win.cc chrome\renderer\greasemonkey_slave.cc * Remove old files: chrome\browser\find_in_page_controller.cc chrome\browser\find_in_page_view.cc chrome\renderer\spellcheck_unittest.cc * Remove relative reference to ../../app/google_update_settings$OBJSUFFIX. * Get rid of by-hand /IMPLIB and /MAP flags. * Prefix / suffix portability in the jscre library. * Rename $LIBXML_DIR/scons => $LIBXML_DIR/DerivedSources. * Add $CHROME_DIR/app/resources to CPPPATH. * Add icu38 directories to CPPPATH for building chrome/views files. Review URL: http://codereview.chromium.org/8725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4205 0039d316-1c4b-4281-b951-d872f2087c98
* Add referrer to session restore.ericroman@google.com2008-10-281-1/+1
| | | | | | | | http://code.google.com/p/chromium/issues/detail?id=3774 Review URL: http://codereview.chromium.org/8649 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4086 0039d316-1c4b-4281-b951-d872f2087c98
* Add the language to the google help center URL (hl=lang).tc@google.com2008-10-281-2/+8
| | | | | | Review URL: http://codereview.chromium.org/8803 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4048 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb the referrer throughout the OpenURL APIs.ericroman@google.com2008-10-272-3/+10
| | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=3224 Caveats: * Did not update TabNavigation yet. Hence session restore will continue to load the tabs with empty referrer. * Did not plumb referrer into incognito url open. (Not sure what the right thing to do is here with respect to privacy vs compatibility.) * Did not plumb referrer throughout the automation controller. No functional impact here, but it makes the code inconsistent with the non-automation version. Review URL: http://codereview.chromium.org/8186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4036 0039d316-1c4b-4281-b951-d872f2087c98
* Add a suggestion to "Learn more about this problem." if there istc@google.com2008-10-273-8/+40
| | | | | | | | | | a redirect loop. We could easily use this for other errors too if there are URLs to the help center. BUG=http://crbug.com/2445 Review URL: http://codereview.chromium.org/8174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4023 0039d316-1c4b-4281-b951-d872f2087c98
* Move Time, TimeDelta and TimeTicks into namespace base.dsh@google.com2008-10-271-0/+2
| | | | | | Review URL: http://codereview.chromium.org/7995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
* Move the spellcheck unittest into browser next to the filetc@google.com2008-10-261-487/+0
| | | | | | | it tests. Review URL: http://codereview.chromium.org/8176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3989 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the Google Cache link from local error pages.tc@google.com2008-10-243-30/+4
| | | | | | | BUG=2712 Review URL: http://codereview.chromium.org/8140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3902 0039d316-1c4b-4281-b951-d872f2087c98
* Switching hash/ to $CHROME_SRC_DIR/chrome down in chrome.bradnelson@google.com2008-10-221-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7856 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3727 0039d316-1c4b-4281-b951-d872f2087c98
* Using $CHROME_SRC_DIR in place of hash/..bradnelson@google.com2008-10-221-1/+1
| | | | | | | | This will facilitate changing where the main sconstruct lives. Review URL: http://codereview.chromium.org/7847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3725 0039d316-1c4b-4281-b951-d872f2087c98
* Include chrome/renderer/SConscript in Linux build. Patch by Paweł Hajdan jrmark@chromium.org2008-10-216-40/+51
| | | | | | | <phajdan.jr@gmail.com>. Review: http://codereview.chromium.org/7822. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3691 0039d316-1c4b-4281-b951-d872f2087c98
* Show the path to the Greasemonkey script that caused an erroraa@chromium.org2008-10-212-14/+23
| | | | | | | | in the console. Review URL: http://codereview.chromium.org/7533 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3643 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes http://code.google.com/p/chromium/issues/detail?id=205, which was ↵ananta@chromium.org2008-10-202-1/+36
| | | | | | | | | | | | | an issue with a windowed flash instance not rendering content at times.The bug occurs as a result of the following:-1. The flash plugin executes a script via GetURLNotify. This script calls window.open with the target as self, which shows up as a new tab in the browser. This causes a new RenderView object to be instantiated (See RenderView::CreateWebView).2. RenderView::CreateWebView sends over the ViewHostMsg_CreateWindow IPC message to the browser. The handler in the browser sends over an ack for this message with the window handle. This is used as the parent window for any plugins instantiated in the page.3. At times, the newly created view starts receiving data which is processed before the ViewMsg_CreatingNew_ACK message is received and processed by the view. This causes the plugin to be instantiated without a parent window thus ending up as a top level window.The fix is to queue up resource messages and process them after we receive the ack for the ViewHostMsg_CreateWindow IPC. Tests :- Covered by UI tests. R=jam Review URL: http://codereview.chromium.org/7514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3631 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-10 17:37:37 +0000