| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was currently processed as a control message.
This is an actual part of the previous CLD related CL:
http://codereview.chromium.org/548057
It kept failing on the bots for some tests, I am not sure why yet and cannot repro locally. Hopefully splitting it will help pinpoint the issue.
TEST=All unit-tests, ui tests should still work.
Navigate to a page with some specific words in it, then go
to the history tab and search for pages with these specific
words. Make sure the page you navigated is shown in the results.
TBR=brettw
Review URL: http://codereview.chromium.org/553012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
4th attempt at landing this.
It caused several tests to fails previously.
Cannot repro any of the failure. I am suspecting a clobber would have probably fixed it. (there is a change in one of the IPC messages that probably messed up the build somehow).
No code change.
Enabling language detection on page load.
A memory error has been fixed in the CLD library in the meantime.
This should hopefully fixes the crashers in the reliability tests.
Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.)
Original review:
http://codereview.chromium.org/492024/show
BUG=30662
TEST=Run the unittests.
TBR=brettw
Review URL: http://codereview.chromium.org/548057
TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/536085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It caused several tests to fails previously.
Cannot repro any of the failure. I am suspecting a clobber would have probably fixed it. (there is a change in one of the IPC messages that probably messed up the build somehow).
No code change.
Enabling language detection on page load.
A memory error has been fixed in the CLD library in the meantime.
This should hopefully fixes the crashers in the reliability tests.
Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.)
Original review:
http://codereview.chromium.org/492024/show
BUG=30662
TEST=Run the unit-tests.
TBR=brettw
Review URL: http://codereview.chromium.org/548057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
equivalent to their counterparts under browser/views/notifications; CL also enables the exposure of notifications in WebKit on linux platform.
BUG=23954
TEST=none
Review URL: http://codereview.chromium.org/525050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
replacement is in query part of the URL or not.
Removed duplicate EscapeQueryParamValue functions without |use_plus| argument.
BUG=24571
TEST=Verify that space is escaped as stated in description; see bug description for example with search on Wikipedia.
Review URL: http://codereview.chromium.org/543077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Someone mistakenly disabled it.
This also factorizes the various platforms. In particular, PluginInstance::set_window_handle, cause of complexity isn't needed. That window_handle is only used for regular plugins in 2 places:
- on Win32 windowed plugins to invalidate the plugin window. There's no plugin window on Pepper so this isn't needed.
- on Win32 and Linux for windowless plugins to get a reference to the browser's window. That isn't cross-platform so shouldn't be in Pepper.
Review URL: http://codereview.chromium.org/551042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
3rd attempt at landing the language detection on page load.
A memory error has been fixed in the CLD library in the meantime.
This should hopefully fixes the crashers in the reliability tests.
Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.)
Original review:
http://codereview.chromium.org/492024/show
BUG=30662
TEST=Run the unittests.
Review URL: http://codereview.chromium.org/518075
TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/546062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A memory error has been fixed in the CLD library in the meantime.
This should hopefully fixes the crashers in the reliability tests.
Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.)
Original review:
http://codereview.chromium.org/492024/show
BUG=30662
TEST=Run the unit-tests.
Review URL: http://codereview.chromium.org/518075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
2 files. (not sure how it happened).
Relanding the change.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/543069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
New fields of WebFileChooserParams are not used yet.
BUG=none
TEST=none, no functional changes
Review URL: http://codereview.chromium.org/497001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
creating and tracking namespace ids in conjunction with the tabs. This is essentially just a bunch of dead code at the moment, but the next patch will get rid of the old way of generating/cloning IDs (initiated by the renderer) and instead use these IDs.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/550017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
messages pass through to the browser window.
TEST=trybots
BUG=none
Review URL: http://codereview.chromium.org/549025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=needed
Review URL: http://codereview.chromium.org/549032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TESTS=none
Review URL: http://codereview.chromium.org/546041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
adds a Translate method to the renderer.
On invocation this method triggers a traversal of the DOM page to retrieve the text nodes. The text node contents are then sent to the browser for actual translation (at this point, we just up-case the text for testing purpose).
The browser sends back the translated text to the renderer that replace the DOM text node values with the translated text.
BUG=None
TEST=Run the unit-tests.
Review URL: http://codereview.chromium.org/547013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One of my previous CL accidentaly reverted the change 35951
for this 2 files. (not sure how it happened).
Relanding the change.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/548035
TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/536062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
for this 2 files. (not sure how it happened).
Relanding the change.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/548035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a nonexistent icon.
BUG=NONE
TEST=Install chrome/common/extensions/docs/examples/api/pageAction/set_icon/, click the page action three times, look at the console.
Review URL: http://codereview.chromium.org/536035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32194
TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.BookmarkManager
Review URL: http://codereview.chromium.org/550021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This method is (and was) just for debugging; while it was closing
idle connections, that was not aggressive enough; the benchmark needs
to close all connections, not just the idle ones.
To ensure connections are abandoned, create a new pool; leaving the old pool
to languish as any pending sockets die.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/549031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
preparation for deleting that file.
R=dglazkov
BUG=24607
TEST=none
Review URL: http://codereview.chromium.org/551012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
application to freeze. This was
because we were not passing the renderer routing id in the PluginMsg_Init params when the plugin was
initialized. We need the routing id in ChromeFrame to be able to intercept network requests and route
them via the host network stack.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=26375
Bug=26375
Review URL: http://codereview.chromium.org/541040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1850
Review URL: http://codereview.chromium.org/549005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27544
TEST=none
Review URL: http://codereview.chromium.org/542044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36101 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebKitClient::createSessionStorageNamespace to using
WebViewClient::createSessionStorageNamespace doesn't break us while the rest of
the SessionStorage change lands.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/546017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36097 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jcampan
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/543030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
TEST=Run the unit-tests.
Review URL: http://codereview.chromium.org/541013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36045 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28292
TEST=none
Patch by neb@chromium.org
Original review: http://codereview.chromium.org/524006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the renderer for a snapshot of the page.
BUG=19274
TEST=Manual testing on Mac,Linux,Win
Review URL: http://codereview.chromium.org/502034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Augments the loadTimes() API with a new field, "wasFetchedViaSpdy".
BUG=31615
TEST=flip_network_transaction_unittest
Review URL: http://codereview.chromium.org/518039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/547005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
includes base/logging.h which is difficult to compile under nacl. base-logging is stubbed in gpu by gpu/common/logging.h.
BUG=26104
Review URL: http://codereview.chromium.org/527009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
crashing.
TEST=trybots
BUG=none
Review URL: http://codereview.chromium.org/529004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
EmptyGURL(), since the code in question can just use the default constructor.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/517054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Still causes redness on the reliability bot.
The code would crash if multiple PageContents notifications
were received rapidly. The CLDHelper now notifies the
TabContents directly and the TabContents ensures only one
language detection can be performed at a time.
Added unittests to validate these cases in web_contents_unittest.cc.
Note that patch set 1 is the original patch, patch set 2 contains the new changes.
Original review:
http://codereview.chromium.org/492024/show
BUG=30662
TEST=Run the unittests.
Review URL: http://codereview.chromium.org/504051
TBR=jcampan@chromium.org
Review URL: http://codereview.chromium.org/523149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The code would crash if multiple PageContents notifications
were received rapidly. The CLDHelper now notifies the
TabContents directly and the TabContents ensures only one
language detection can be performed at a time.
Added unit-tests to validate these cases in web_contents_unittest.cc.
Note that patch set 1 is the original patch, patch set 2 contains the new changes.
Original review:
http://codereview.chromium.org/492024/show
BUG=30662
TEST=Run the unit-tests.
Review URL: http://codereview.chromium.org/504051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
fix pepper_test_plugin so that it is loaded on Linux
remove skia & base dependency in test plugin so that it can be compiled with fPIC
remove ifdef WIN in pepper code
Patch by neb@chromium.org
Original review: http://codereview.chromium.org/501124/show
BUG=none
TEST=none
TBR=brettw@chromium.org
Review URL: http://codereview.chromium.org/524051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- fix pepper_test_plugin so that it is loaded on Linux
- remove skia & base dependency in test plugin so that it can be compiled with -fPIC
- remove ifdef WIN in pepper code
Patch by neb@chromium.org
Original review: http://codereview.chromium.org/501124/show
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25520
TEST=none
Review URL: http://codereview.chromium.org/525026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35509
Review URL: http://codereview.chromium.org/500132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/523053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35541 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/500132
TBR=piman@chromium.org
Review URL: http://codereview.chromium.org/525022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/500132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
(I screwed up and committed in the wrong terminal.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WARNING: We need to watch the perf charts when this lands to be
sure that it doesn't cause a regression.
Since there is no finalizer for a renderer, and some renderers
are just terminated with no warning, the only way to get
consistent page data is to send it to the browser after
each page loads. That is the bulk of this change.
I also fixed up a few nits relating to making this work
in single process mode.
BUG=16495
r=raman.tenneti
Review URL: http://codereview.chromium.org/515072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Auto-updated extension docs.
Review URL: http://codereview.chromium.org/522017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Even if plugins will crash when they are too large, we should try to
have the renderer stay up.
BUG=28606
Review URL: http://codereview.chromium.org/515043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Generic cleanup of histogram class, renaming *FactoryGet to FactoryGet,
along with reformatting.
The macros were cleaned up to use common sub-macros rather than
repeating code as much.
Removed ThreadSafeHistogram (and associated ASSET_HISTOGRAM macros)
since this class was not getting used.
I introduced UMA_HISTOGRAM_ENUMERATION to support the common use
of LinearHistograms to count various enumerated values.
I added a Flags argument to all the FactoryGet routines to help avoid
needing to call SetFlags each time a new sample is Add()ed. This also
simplifies the code.
This will all help prepare for a "don't histogram at all" macro setting
so that I can test the impact of the histogram macro calls on
performance (since there are now so many active histograms).
BUG=31206
r=raman.tenneti
Review URL: http://codereview.chromium.org/515033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
See corresponding changes in webkit here: https://bugs.webkit.org/show_bug.cgi?id=31737
Review URL: http://codereview.chromium.org/434087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35216 0039d316-1c4b-4281-b951-d872f2087c98
|