summaryrefslogtreecommitdiffstats
path: root/chrome/renderer
Commit message (Collapse)AuthorAgeFilesLines
* Move FTP LIST parsing code to the renderer process.phajdan.jr@chromium.org2009-09-221-0/+5
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/210027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26860 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize instance_id_ in the constructor.jhawkins@chromium.org2009-09-221-0/+1
| | | | | | | | | CID=6212 BUG=none TEST=none Review URL: http://codereview.chromium.org/208051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26858 0039d316-1c4b-4281-b951-d872f2087c98
* On 'window.print()' javascript command, print only the frame that is ↵maruel@chromium.org2009-09-221-5/+2
| | | | | | | | | | | | represented by 'window'. The behavior was broken in r20876. BUG=18749 TEST=window.print() on a subframe works. Review URL: http://codereview.chromium.org/206033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26847 0039d316-1c4b-4281-b951-d872f2087c98
* Create an enum for local storage vs. session storage rather than usingjorlow@chromium.org2009-09-223-14/+15
| | | | | | | | | | | | a boolean. TEST=It still works. BUG=21070 Review URL: http://codereview.chromium.org/212033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26793 0039d316-1c4b-4281-b951-d872f2087c98
* Update renderer plugin cache when we load/unload extensions with plugins.mpcomplete@chromium.org2009-09-212-3/+3
| | | | | | | | | BUG=12306 TEST=Load and unload extensions that contain plugins and visit pages that use them. Also covered by tests. Review URL: http://codereview.chromium.org/201111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26748 0039d316-1c4b-4281-b951-d872f2087c98
* Allow <audio> to work in extensionhclam@chromium.org2009-09-211-1/+11
| | | | | | | | | | | | | | | | | | BUG=22152 TEST=use <audio> extension with relative paths We used to exclude file:// for checks for valid HTTP response but since chrome extension resources use chrome-extension:// as scheme response from such scheme require valid HTTP response. This change changes the logic to limit the check for valid HTTP response only for http:// and https:// schemes. This impose a strong assumption that file://, ftp:// and new protocols need to know how to handle range requests or at least know how to fail. Review URL: http://codereview.chromium.org/216022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26746 0039d316-1c4b-4281-b951-d872f2087c98
* Add histograms for tab count, RenderProcessHost count, and the number ofbrettw@chromium.org2009-09-211-0/+5
| | | | | | | | | | glyph "pages" in memory per load (to check memory consumption). BUG=none TEST=none Review URL: http://codereview.chromium.org/195104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26688 0039d316-1c4b-4281-b951-d872f2087c98
* Change the view mode when switching between moles and toolstrips, anderikkay@chromium.org2009-09-197-17/+202
| | | | | | | | | | | | | | propogate this into the class of the document element so that it's possible to use CSS rules to control the display of your toolstrip/mole. BUG=21939,15494 TEST=run the Mappy extension and verify it can open and close Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26635 Review URL: http://codereview.chromium.org/208020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26654 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 26635 - Change the view mode when switching between moles and ↵mbelshe@google.com2009-09-187-202/+17
| | | | | | | | | | | | | | | | | | toolstrips, and propogate this into the class of the document element so that it's possible to use CSS rules to control the display of your toolstrip/mole. BUG=21939,15494 TEST=run the Mappy extension and verify it can open and close Review URL: http://codereview.chromium.org/208020 TBR=erikkay@chromium.org Review URL: http://codereview.chromium.org/210024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26636 0039d316-1c4b-4281-b951-d872f2087c98
* Change the view mode when switching between moles and toolstrips, anderikkay@chromium.org2009-09-187-17/+202
| | | | | | | | | | | | propogate this into the class of the document element so that it's possible to use CSS rules to control the display of your toolstrip/mole. BUG=21939,15494 TEST=run the Mappy extension and verify it can open and close Review URL: http://codereview.chromium.org/208020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26635 0039d316-1c4b-4281-b951-d872f2087c98
* Fold WebEditingClient into WebViewClient.darin@chromium.org2009-09-184-119/+143
| | | | | | | | | | R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/211032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26631 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes the browser focus tests faster by replacingjcampan@chromium.org2009-09-181-0/+6
| | | | | | | | | | | | some time-outs with notifications. BUG=22065 TEST=Run the interactive tests, especially BrowserFocusTest*FocusTraversal* These tests should run in few seconds. Review URL: http://codereview.chromium.org/210013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26597 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionAPIClientTest.GetLastFocusedWindow is flakymaruel@chromium.org2009-09-181-1/+2
| | | | | | | | | TBR=rafaelw TEST=ExtensionAPIClientTest.GetLastFocusedWindow in unit_tests BUG=22248 Review URL: http://codereview.chromium.org/207029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26565 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to land "Implement script API:executeScript"aa@chromium.org2009-09-184-5/+86
| | | | | | | | | http://codereview.chromium.org/173556 TBR=mpcomplete@chromium.org Patch from Jerry Tang <tangjie@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26556 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce WebKit::WebSecurityOrigin as a wrapper arounddarin@chromium.org2009-09-182-4/+5
| | | | | | | | | | | | | | | | | WebCore::SecurityOrigin. This provides us a little wiggle room in the future in case we ever want to provide more details about a security origin beyond just its stringified value. This was done on recommendation from Adam Barth. R=jorlow BUG=21967 TEST=none Review URL: http://codereview.chromium.org/211013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26554 0039d316-1c4b-4281-b951-d872f2087c98
* Preparing rollback in case things don't work out.bradnelson@google.com2009-09-182-19/+1
| | | | | | | | | | | This rolls back 26540, gregoryd's attempt at a nacl landing. BUG=None TEST=None Review URL: http://codereview.chromium.org/213019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26543 0039d316-1c4b-4281-b951-d872f2087c98
* This is a copy of http://codereview.chromium.org/153002/showgregoryd@google.com2009-09-182-1/+19
| | | | | | | | | | First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. This CL relies on another CL that contains the changes on the Native Client side: http://codereview.chromium.org/1501904. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin.5. NaCl still cannot run in Chrome sandbox, so the "--no-sandbox" flag is also required TBR=bradnelson Review URL: http://codereview.chromium.org/207025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26540 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mouse over status bubble.darin@chromium.org2009-09-171-1/+1
| | | | | | | | | | R=dglazkov BUG=22050 TEST=none Review URL: http://codereview.chromium.org/215001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26434 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up WebViewClient, part 1.darin@chromium.org2009-09-165-268/+313
| | | | | | | | | | | | | | This change makes WebViewDelegate extend from WebViewClient as a temporary means to start having consumers implement and use WebViewClient. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/196128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26355 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: print page to file rather than using shared memory to send it to the ↵estade@chromium.org2009-09-161-55/+41
| | | | | | | | | | | | browser. BUG=9847 adapted from patch by <minyu.huang [at] gmail> Review URL: http://codereview.chromium.org/203062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26308 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 172109: Enable scavenging in RenderThread::IdleHandler.agl@chromium.org2009-09-152-18/+23
| | | | | | | | | | | | Landing of Anton Muhin's patch (antonm@google.com) (Reland. First landed in r26264, reverted in r26276. This reland hopefully doesn't build tcmalloc on Linux.) Review URL: http://codereview.chromium.org/206017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26298 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Issue 172109: Enable scavenging in RenderThread::IdleHandler."agl@chromium.org2009-09-152-23/+18
| | | | | | | This reverts commit r26264. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26276 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 172109: Enable scavenging in RenderThread::IdleHandler.mbelshe@google.com2009-09-152-18/+23
| | | | | | | | | | | | Landing of Anton Muhin's patch (antonm@google.com) BUG=none TEST=none Review URL: http://codereview.chromium.org/206017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26264 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a bunch of hardcoded URLs with constants from url_constants.hbrettw@chromium.org2009-09-151-2/+2
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/193092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26263 0039d316-1c4b-4281-b951-d872f2087c98
* Address ExtensionApiTest.Tabs flakinessrafaelw@chromium.org2009-09-152-14/+13
| | | | | | | | | | | | This addresses two problems. (1) relativeUrlTabsUpdate could fail because it was depending on testTabId getting set from relativeUrlTabsCreate, which may have happened out of order. I have refactored the callback blocking so additional blocks can be created with chrome.test.callbackAdded(). (2) tabs.update({url:}) is still failing intermitantly. This changes addeds valid html files in the extension which can be navitation targets (previously, non-existent urls had been used), in the hopes that the random failures had to do with load errors. BUG=20828 Review URL: http://codereview.chromium.org/195090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26258 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add support for SELinux.agl@chromium.org2009-09-151-1/+1
| | | | | | | | | | | | | | | | | | This patch adds support for a selinux GYP variable which, when set to one, does the following: * Removes the seccomp sandbox from the compile * Removes support for SUID sandboxing from the zygote * Performs a dynamic transition, in the zygote, to chromium_renderer_t. This code requires that the system policy have a sensible set of access vectors for the chromium_renderer_t type. Such a policy will be found in sandbox/selinux in the future. http://codereview.chromium.org/203071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26257 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionShelf now uses the BookmarkExtensionBackground, just like the ↵finnur@chromium.org2009-09-153-8/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | BookmarkBarView. Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added. Added an interface that both BookmarkBarView and ExtensionShelf implement. This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not. Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions). Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process. Toolstrip text color values are no longer hard-coded but use the color specified in the theme. Decreased the timeouts for showing and hiding the toolstrip handle. Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses. Known issues: Some themes expose the fact that: - The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though. - Didn't spend much time theming the shelf handle (just used the solid color from the theme). - When extension shelf is merged with the bookmark bar, there is a painting artifact (horizontal dotted line) that appears (apparently it was known to appear before this change). BUG=18452, 21272, 21273 TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed. Review URL: http://codereview.chromium.org/204022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26227 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 26184, 26181 and 26178 to fixnsylvain@chromium.org2009-09-153-14/+8
| | | | | | | | | | the compile error on the toolkit builder. TBR:finnur Review URL: http://codereview.chromium.org/203064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26186 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionShelf now uses the BookmarkExtensionBackground, just like the ↵finnur@chromium.org2009-09-143-8/+14
| | | | | | | | | | | | | | | | | | | | | | | | | BookmarkBarView. Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added. Added an interface that both BookmarkBarView and ExtensionShelf implement. This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not. Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions). Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process. Toolstrip text color values are no longer hard-coded but use the color specified in the theme. Decreased the timeouts for showing and hiding the toolstrip handle. Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses. Known issues: Some themes expose the fact that: - The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though. - Didn't spend much time theming the shelf handle (just used the solid color from the theme). BUG=18452, 21272, 21273 TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed. Review URL: http://codereview.chromium.org/203034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26178 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for bug 2932: Chrome should not trigger page reloading when turn off ↵jshin@chromium.org2009-09-142-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | auto detect In order to fix the bug I added new interfaces to allow resetting the override encoding (including a new render message). The new logic is as follows: -) If the user turns auto-detect OFF, nothing happens (as requested in the bug description) -) If the user turns auto-detect ON, then the page is reloaded with an empty override encoding I.e., turning auto-detect on resets a previous override setting. The reverse is not true, however: specifiying a new override setting will not turn auto-detect off. BUG=2932 TEST=do the following steps, using the test file (encoding-gb18030.htm) attached to comment 14 of the original bug http://crbug.com/2932 : 1.) load the file while auto-detect is turned off -> garbage is displayed 2.) turn auto-detect on -> proper Chinese text should appear -> in the encoding menu, Chinese encoding should be highlighted 3.) turn auto-detect off -> proper Chinese text should remain -> in the encoding menu, Chinese encoding should remain highlighted 4.) choose any other encoding -> garbage is again displayed (in the new encoding) 5.) turn auto-detect on -> proper Chinese text should again appear -> in the encoding menu, Chinese should again be highlighted Original Review: http://codereview.chromium.org/173265 Patch by Roland Steiner (rolandsteiner@google.com) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26168 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where content scripts can get GC'd if they don'taa@chromium.org2009-09-143-7/+34
| | | | | | | | | | | attach to any DOM events. BUG=17410 TEST=none Review URL: http://codereview.chromium.org/200116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26136 0039d316-1c4b-4281-b951-d872f2087c98
* Remove code doing a no-op due to float -> int rounding.phajdan.jr@chromium.org2009-09-141-3/+3
| | | | | | | | | | | | | | | | Make implicit float -> int/long conversions explicit. (Implicit float -> int conversions can be found by compiling with -Wconversion in gcc [versions 4.1.1 and 4.2.4, and surely many others].) Landing the patch for Jacob Mandelson, original review: http://codereview.chromium.org/201091 BUG=none TEST=app_unittests & base_unittests Review URL: http://codereview.chromium.org/200122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26119 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some mixed content layout tests.darin@chromium.org2009-09-141-0/+3
| | | | | | | | | | | | | 1. Make test shell ignore certificate errors. 2. Extend WebFrameClient for new notifications and printf these. R=abarth BUG=21644 TEST=covered by layout tests Review URL: http://codereview.chromium.org/200110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26108 0039d316-1c4b-4281-b951-d872f2087c98
* Warm up the generic CMYK profile before building a sandbox.mark@chromium.org2009-09-131-15/+17
| | | | | | | | BUG=21114 TEST=http://twitter.com/kuechengoettin, no sad tab on Snow Leopard Review URL: http://codereview.chromium.org/201104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26089 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix build.thakis@chromium.org2009-09-122-0/+6
| | | | | | | TBR=pinkerton git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26076 0039d316-1c4b-4281-b951-d872f2087c98
* Let cmd-e write the selection into the find pasteboard.thakis@chromium.org2009-09-122-0/+18
| | | | | | | | | | | Note that chrome still does not support _reading_ from the find pasteboard, so hitting cmd-e followed by cmd-g in chrome still doesn't work. Also, cmd-f doesn't write to the find pasteboard yet either. BUG=14562 TEST=Select some text on a web page, hit cmd-e, go to the same web page in safari, hit cmd-g. Safari should search for the text you selected in chrome. Review URL: http://codereview.chromium.org/197035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26075 0039d316-1c4b-4281-b951-d872f2087c98
* Linux focus ring color: Go through WebKit::WebColor api rather than through ↵estade@chromium.org2009-09-111-3/+4
| | | | | | | | | | | | the webview. Also use SkColor isntead of a triplet of colors in RenderPreferences. BUG=21521 Review URL: http://codereview.chromium.org/195059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26013 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WebViewDelegate::SpellCheckerDocumentTag method and eliminatedarin@chromium.org2009-09-112-27/+38
| | | | | | | | | | | | synchronous IPCs to fetch a document tag on platforms other than Mac. R=pinkerton BUG=none TEST=none Review URL: http://codereview.chromium.org/201096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26009 0039d316-1c4b-4281-b951-d872f2087c98
* Update ExtensionApiTest.Tabs and re-enablerafaelw@chromium.org2009-09-112-19/+23
| | | | | | | | BUG=20828 Review URL: http://codereview.chromium.org/199091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26002 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate some methods.darin@chromium.org2009-09-112-8/+6
| | | | | | | | | | | | | | | | Removes WebFrame::reportFindInPageSelection since it was only ever called by WebFrameImpl. Now it is a private method. Removes WebViewDelegate::DownloadUrl since it can be expressed using WebFrameClient::loadURLExternally. R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/201092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25987 0039d316-1c4b-4281-b951-d872f2087c98
* add mole collapse/expand events. convert mappy to use this.erikkay@chromium.org2009-09-112-0/+19
| | | | | | | | | BUG=15494 TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Toolstrip Review URL: http://codereview.chromium.org/203023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25976 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow updating tabs to javascript URLs without hostaa@chromium.org2009-09-112-5/+13
| | | | | | | | | | | | | | | | | | | | | | | | permissions to that tab. Cleaned up a few things along the way: - added a GetExtension() method to ExtensionFunctionDispatcher and ExtensionFunction since it was used in more than one place. - Removed first param from chrome.test.failCallback() since it wasn't used anywhere. - Added a convenience CanAccessHost() method to Extension, since it seems likely to be commonly used. - Refactored setup of mock host resolver in browsertest, since the way it was, you could only customize it at the testsuite level, not the test level. Review URL: http://codereview.chromium.org/199074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25971 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the half-working traces of locking, caching, and quotas. Itjorlow@chromium.org2009-09-113-163/+9
| | | | | | | | | | | probably shoudln't have been added in to begin with. BUG=none TEST=none Review URL: http://codereview.chromium.org/203015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25966 0039d316-1c4b-4281-b951-d872f2087c98
* Make extensions use ViewMsg_EnableIntrinsicWidthChangedMode.mpcomplete@chromium.org2009-09-101-6/+1
| | | | | | | | | BUG=11974 TEST=no Review URL: http://codereview.chromium.org/194064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25928 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringPiece into the base namespace. It is collidingtony@chromium.org2009-09-104-7/+7
| | | | | | | | | | with the StringPiece class in icu4.2, which is a problem when trying to use the system version of icu. Review URL: http://codereview.chromium.org/193072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25920 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up WebFrameClient::didUpdateCurrentHistoryItemdarin@chromium.org2009-09-102-9/+9
| | | | | | | | | | | | This replaces WebViewDelegate::OnNavStateChanged. R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/196080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25916 0039d316-1c4b-4281-b951-d872f2087c98
* Supports Gtk keyboard themes.suzhe@chromium.org2009-09-104-0/+49
| | | | | | | | | | | | | | | | | | | | | | | | This CL fixes issue 11480: Support GTK keyboard themes (emacs keybindings). A new class GtkKeyBindingsHandler has been added, which matches a key event against key bindings defined in current Gtk keyboard theme. A new render message ViewMsg_SetEditCommandsForNextKeyEvent has been added for sending edit commands associated to a key event to renderer. This message shall be sent just before sending the key event. RenderView will handle this event and cache the edit commands until the key event is processed. When processing the key event, EditClientImpl::handleKeyboardEvent() will eventually be called to handle the key event, if it's not handled by DOM and the focus is inside an input box. Then a newly added method WebViewDelegate::ExecuteEditCommandsForCurrentKeyEvent(), which is implemented in RenderView, will be called by EditClientImpl::handleKeyboardEvent() to execute edit commands previously sent from browser by ViewMsg_SetEditCommandsForNextKeyEvent message. If WebViewDelegate::ExecuteEditCommandsForCurrentKeyEvent() returns false, which means the key event doesn't have edit command associated, EditClientImpl will handle the key event with built-in logic, which may trigger a built-in key binding. With this approach, system defined key bindings always have higher priority than built-in key bindings defined in editor_client_impl.cc. Known issue: If a key event matches not only a system defined key binding but also an accesskey of a DOM element, then both corresponding edit commands and accesskey action will be executed. Because accesskey is handled in WebViewImpl::CharEvent(), while edit commands are bound to RawKeyDown or KeyUp events. BUG=11480 "Support GTK keyboard themes (emacs keybindings)" TEST=Switch to Emacs keyboard theme by changing the value of gconf key "/desktop/gnome/interface/gtk_key_theme" to "Emacs", then starts chrome and opens a webpage with a text input box. Input something into the text box, then press any of the Emacs key bindings defined in /usr/share/themes/Emacs/gtk-2.0-key/gtkrc, to see if it works as expected. For example, ctrl-p should move the cursor up one line, and ctrl-k should delete to the end of paragraph. Review URL: http://codereview.chromium.org/165293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25852 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up WebFrameClient, replacing many WebViewDelegate methods.darin@chromium.org2009-09-104-659/+672
| | | | | | | | | | | | | | | | | | | Moved NavigationGesture out of webview_delegate.h into its own header in chrome/common since it is only needed by Chrome. Adds WebFrame::isProcessingUserGesture to facilitate the removal of NavigationGesture. Cleaned up some TestShell methods related to URL loading. The method to load an URL now takes a GURL instead of a wchar_t*. R=dglazkov BUG=21332 TEST=none Review URL: http://codereview.chromium.org/200054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25841 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression of transparent plugins not displaying correctly.jam@chromium.org2009-09-101-3/+3
| | | | | | | BUG=21157 Review URL: http://codereview.chromium.org/203013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25830 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Use gtk-cursor-blink from GtkSettings"evan@chromium.org2009-09-091-1/+0
| | | | | | This reverts commit r25797 due to Valgrind errors. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25812 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 03:32:40 +0000