summaryrefslogtreecommitdiffstats
path: root/chrome/renderer
Commit message (Collapse)AuthorAgeFilesLines
* Hook up WebViewClient, part 1.darin@chromium.org2009-09-165-268/+313
| | | | | | | | | | | | | | This change makes WebViewDelegate extend from WebViewClient as a temporary means to start having consumers implement and use WebViewClient. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/196128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26355 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: print page to file rather than using shared memory to send it to the ↵estade@chromium.org2009-09-161-55/+41
| | | | | | | | | | | | browser. BUG=9847 adapted from patch by <minyu.huang [at] gmail> Review URL: http://codereview.chromium.org/203062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26308 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 172109: Enable scavenging in RenderThread::IdleHandler.agl@chromium.org2009-09-152-18/+23
| | | | | | | | | | | | Landing of Anton Muhin's patch (antonm@google.com) (Reland. First landed in r26264, reverted in r26276. This reland hopefully doesn't build tcmalloc on Linux.) Review URL: http://codereview.chromium.org/206017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26298 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Issue 172109: Enable scavenging in RenderThread::IdleHandler."agl@chromium.org2009-09-152-23/+18
| | | | | | | This reverts commit r26264. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26276 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 172109: Enable scavenging in RenderThread::IdleHandler.mbelshe@google.com2009-09-152-18/+23
| | | | | | | | | | | | Landing of Anton Muhin's patch (antonm@google.com) BUG=none TEST=none Review URL: http://codereview.chromium.org/206017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26264 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a bunch of hardcoded URLs with constants from url_constants.hbrettw@chromium.org2009-09-151-2/+2
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/193092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26263 0039d316-1c4b-4281-b951-d872f2087c98
* Address ExtensionApiTest.Tabs flakinessrafaelw@chromium.org2009-09-152-14/+13
| | | | | | | | | | | | This addresses two problems. (1) relativeUrlTabsUpdate could fail because it was depending on testTabId getting set from relativeUrlTabsCreate, which may have happened out of order. I have refactored the callback blocking so additional blocks can be created with chrome.test.callbackAdded(). (2) tabs.update({url:}) is still failing intermitantly. This changes addeds valid html files in the extension which can be navitation targets (previously, non-existent urls had been used), in the hopes that the random failures had to do with load errors. BUG=20828 Review URL: http://codereview.chromium.org/195090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26258 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add support for SELinux.agl@chromium.org2009-09-151-1/+1
| | | | | | | | | | | | | | | | | | This patch adds support for a selinux GYP variable which, when set to one, does the following: * Removes the seccomp sandbox from the compile * Removes support for SUID sandboxing from the zygote * Performs a dynamic transition, in the zygote, to chromium_renderer_t. This code requires that the system policy have a sensible set of access vectors for the chromium_renderer_t type. Such a policy will be found in sandbox/selinux in the future. http://codereview.chromium.org/203071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26257 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionShelf now uses the BookmarkExtensionBackground, just like the ↵finnur@chromium.org2009-09-153-8/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | BookmarkBarView. Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added. Added an interface that both BookmarkBarView and ExtensionShelf implement. This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not. Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions). Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process. Toolstrip text color values are no longer hard-coded but use the color specified in the theme. Decreased the timeouts for showing and hiding the toolstrip handle. Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses. Known issues: Some themes expose the fact that: - The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though. - Didn't spend much time theming the shelf handle (just used the solid color from the theme). - When extension shelf is merged with the bookmark bar, there is a painting artifact (horizontal dotted line) that appears (apparently it was known to appear before this change). BUG=18452, 21272, 21273 TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed. Review URL: http://codereview.chromium.org/204022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26227 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 26184, 26181 and 26178 to fixnsylvain@chromium.org2009-09-153-14/+8
| | | | | | | | | | the compile error on the toolkit builder. TBR:finnur Review URL: http://codereview.chromium.org/203064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26186 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionShelf now uses the BookmarkExtensionBackground, just like the ↵finnur@chromium.org2009-09-143-8/+14
| | | | | | | | | | | | | | | | | | | | | | | | | BookmarkBarView. Changed the WebKit API to add an optional |id| parameter to the insertStyleText, which is needed to be able to replace style sheets that have been previously added. Added an interface that both BookmarkBarView and ExtensionShelf implement. This new interface tells us whether we are located at the top or at the bottom and whether we are detached from the frame or not. Factored out some of the duplicate painting-related code to a namespace of its own. Not happy with the name (welcome suggestions). Moved the check for whether extensions are on top to new class and now cache the value for the lifetime of the process. Toolstrip text color values are no longer hard-coded but use the color specified in the theme. Decreased the timeouts for showing and hiding the toolstrip handle. Replaced the pressed background image and the hover background image for the toolstrip to match what the bookmark bar uses. Known issues: Some themes expose the fact that: - The background for the extension shelf when in detached mode (and located on the bottom) does not seamlessly blend in with background of new tab page. Still works surprisingly well when it breaks, though. - Didn't spend much time theming the shelf handle (just used the solid color from the theme). BUG=18452, 21272, 21273 TEST=Install a theme for Chrome and make sure everything looks correct and is updated on a theme change. Also make sure painting problems in bugs 21272 and 21273 are fixed. Review URL: http://codereview.chromium.org/203034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26178 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for bug 2932: Chrome should not trigger page reloading when turn off ↵jshin@chromium.org2009-09-142-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | auto detect In order to fix the bug I added new interfaces to allow resetting the override encoding (including a new render message). The new logic is as follows: -) If the user turns auto-detect OFF, nothing happens (as requested in the bug description) -) If the user turns auto-detect ON, then the page is reloaded with an empty override encoding I.e., turning auto-detect on resets a previous override setting. The reverse is not true, however: specifiying a new override setting will not turn auto-detect off. BUG=2932 TEST=do the following steps, using the test file (encoding-gb18030.htm) attached to comment 14 of the original bug http://crbug.com/2932 : 1.) load the file while auto-detect is turned off -> garbage is displayed 2.) turn auto-detect on -> proper Chinese text should appear -> in the encoding menu, Chinese encoding should be highlighted 3.) turn auto-detect off -> proper Chinese text should remain -> in the encoding menu, Chinese encoding should remain highlighted 4.) choose any other encoding -> garbage is again displayed (in the new encoding) 5.) turn auto-detect on -> proper Chinese text should again appear -> in the encoding menu, Chinese should again be highlighted Original Review: http://codereview.chromium.org/173265 Patch by Roland Steiner (rolandsteiner@google.com) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26168 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where content scripts can get GC'd if they don'taa@chromium.org2009-09-143-7/+34
| | | | | | | | | | | attach to any DOM events. BUG=17410 TEST=none Review URL: http://codereview.chromium.org/200116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26136 0039d316-1c4b-4281-b951-d872f2087c98
* Remove code doing a no-op due to float -> int rounding.phajdan.jr@chromium.org2009-09-141-3/+3
| | | | | | | | | | | | | | | | Make implicit float -> int/long conversions explicit. (Implicit float -> int conversions can be found by compiling with -Wconversion in gcc [versions 4.1.1 and 4.2.4, and surely many others].) Landing the patch for Jacob Mandelson, original review: http://codereview.chromium.org/201091 BUG=none TEST=app_unittests & base_unittests Review URL: http://codereview.chromium.org/200122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26119 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some mixed content layout tests.darin@chromium.org2009-09-141-0/+3
| | | | | | | | | | | | | 1. Make test shell ignore certificate errors. 2. Extend WebFrameClient for new notifications and printf these. R=abarth BUG=21644 TEST=covered by layout tests Review URL: http://codereview.chromium.org/200110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26108 0039d316-1c4b-4281-b951-d872f2087c98
* Warm up the generic CMYK profile before building a sandbox.mark@chromium.org2009-09-131-15/+17
| | | | | | | | BUG=21114 TEST=http://twitter.com/kuechengoettin, no sad tab on Snow Leopard Review URL: http://codereview.chromium.org/201104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26089 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix build.thakis@chromium.org2009-09-122-0/+6
| | | | | | | TBR=pinkerton git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26076 0039d316-1c4b-4281-b951-d872f2087c98
* Let cmd-e write the selection into the find pasteboard.thakis@chromium.org2009-09-122-0/+18
| | | | | | | | | | | Note that chrome still does not support _reading_ from the find pasteboard, so hitting cmd-e followed by cmd-g in chrome still doesn't work. Also, cmd-f doesn't write to the find pasteboard yet either. BUG=14562 TEST=Select some text on a web page, hit cmd-e, go to the same web page in safari, hit cmd-g. Safari should search for the text you selected in chrome. Review URL: http://codereview.chromium.org/197035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26075 0039d316-1c4b-4281-b951-d872f2087c98
* Linux focus ring color: Go through WebKit::WebColor api rather than through ↵estade@chromium.org2009-09-111-3/+4
| | | | | | | | | | | | the webview. Also use SkColor isntead of a triplet of colors in RenderPreferences. BUG=21521 Review URL: http://codereview.chromium.org/195059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26013 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WebViewDelegate::SpellCheckerDocumentTag method and eliminatedarin@chromium.org2009-09-112-27/+38
| | | | | | | | | | | | synchronous IPCs to fetch a document tag on platforms other than Mac. R=pinkerton BUG=none TEST=none Review URL: http://codereview.chromium.org/201096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26009 0039d316-1c4b-4281-b951-d872f2087c98
* Update ExtensionApiTest.Tabs and re-enablerafaelw@chromium.org2009-09-112-19/+23
| | | | | | | | BUG=20828 Review URL: http://codereview.chromium.org/199091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26002 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate some methods.darin@chromium.org2009-09-112-8/+6
| | | | | | | | | | | | | | | | Removes WebFrame::reportFindInPageSelection since it was only ever called by WebFrameImpl. Now it is a private method. Removes WebViewDelegate::DownloadUrl since it can be expressed using WebFrameClient::loadURLExternally. R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/201092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25987 0039d316-1c4b-4281-b951-d872f2087c98
* add mole collapse/expand events. convert mappy to use this.erikkay@chromium.org2009-09-112-0/+19
| | | | | | | | | BUG=15494 TEST=browser_tests.exe --gtest_filter=ExtensionApiTest.Toolstrip Review URL: http://codereview.chromium.org/203023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25976 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow updating tabs to javascript URLs without hostaa@chromium.org2009-09-112-5/+13
| | | | | | | | | | | | | | | | | | | | | | | | permissions to that tab. Cleaned up a few things along the way: - added a GetExtension() method to ExtensionFunctionDispatcher and ExtensionFunction since it was used in more than one place. - Removed first param from chrome.test.failCallback() since it wasn't used anywhere. - Added a convenience CanAccessHost() method to Extension, since it seems likely to be commonly used. - Refactored setup of mock host resolver in browsertest, since the way it was, you could only customize it at the testsuite level, not the test level. Review URL: http://codereview.chromium.org/199074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25971 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the half-working traces of locking, caching, and quotas. Itjorlow@chromium.org2009-09-113-163/+9
| | | | | | | | | | | probably shoudln't have been added in to begin with. BUG=none TEST=none Review URL: http://codereview.chromium.org/203015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25966 0039d316-1c4b-4281-b951-d872f2087c98
* Make extensions use ViewMsg_EnableIntrinsicWidthChangedMode.mpcomplete@chromium.org2009-09-101-6/+1
| | | | | | | | | BUG=11974 TEST=no Review URL: http://codereview.chromium.org/194064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25928 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringPiece into the base namespace. It is collidingtony@chromium.org2009-09-104-7/+7
| | | | | | | | | | with the StringPiece class in icu4.2, which is a problem when trying to use the system version of icu. Review URL: http://codereview.chromium.org/193072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25920 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up WebFrameClient::didUpdateCurrentHistoryItemdarin@chromium.org2009-09-102-9/+9
| | | | | | | | | | | | This replaces WebViewDelegate::OnNavStateChanged. R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/196080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25916 0039d316-1c4b-4281-b951-d872f2087c98
* Supports Gtk keyboard themes.suzhe@chromium.org2009-09-104-0/+49
| | | | | | | | | | | | | | | | | | | | | | | | This CL fixes issue 11480: Support GTK keyboard themes (emacs keybindings). A new class GtkKeyBindingsHandler has been added, which matches a key event against key bindings defined in current Gtk keyboard theme. A new render message ViewMsg_SetEditCommandsForNextKeyEvent has been added for sending edit commands associated to a key event to renderer. This message shall be sent just before sending the key event. RenderView will handle this event and cache the edit commands until the key event is processed. When processing the key event, EditClientImpl::handleKeyboardEvent() will eventually be called to handle the key event, if it's not handled by DOM and the focus is inside an input box. Then a newly added method WebViewDelegate::ExecuteEditCommandsForCurrentKeyEvent(), which is implemented in RenderView, will be called by EditClientImpl::handleKeyboardEvent() to execute edit commands previously sent from browser by ViewMsg_SetEditCommandsForNextKeyEvent message. If WebViewDelegate::ExecuteEditCommandsForCurrentKeyEvent() returns false, which means the key event doesn't have edit command associated, EditClientImpl will handle the key event with built-in logic, which may trigger a built-in key binding. With this approach, system defined key bindings always have higher priority than built-in key bindings defined in editor_client_impl.cc. Known issue: If a key event matches not only a system defined key binding but also an accesskey of a DOM element, then both corresponding edit commands and accesskey action will be executed. Because accesskey is handled in WebViewImpl::CharEvent(), while edit commands are bound to RawKeyDown or KeyUp events. BUG=11480 "Support GTK keyboard themes (emacs keybindings)" TEST=Switch to Emacs keyboard theme by changing the value of gconf key "/desktop/gnome/interface/gtk_key_theme" to "Emacs", then starts chrome and opens a webpage with a text input box. Input something into the text box, then press any of the Emacs key bindings defined in /usr/share/themes/Emacs/gtk-2.0-key/gtkrc, to see if it works as expected. For example, ctrl-p should move the cursor up one line, and ctrl-k should delete to the end of paragraph. Review URL: http://codereview.chromium.org/165293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25852 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up WebFrameClient, replacing many WebViewDelegate methods.darin@chromium.org2009-09-104-659/+672
| | | | | | | | | | | | | | | | | | | Moved NavigationGesture out of webview_delegate.h into its own header in chrome/common since it is only needed by Chrome. Adds WebFrame::isProcessingUserGesture to facilitate the removal of NavigationGesture. Cleaned up some TestShell methods related to URL loading. The method to load an URL now takes a GURL instead of a wchar_t*. R=dglazkov BUG=21332 TEST=none Review URL: http://codereview.chromium.org/200054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25841 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression of transparent plugins not displaying correctly.jam@chromium.org2009-09-101-3/+3
| | | | | | | BUG=21157 Review URL: http://codereview.chromium.org/203013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25830 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Use gtk-cursor-blink from GtkSettings"evan@chromium.org2009-09-091-1/+0
| | | | | | This reverts commit r25797 due to Valgrind errors. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25812 0039d316-1c4b-4281-b951-d872f2087c98
* Added chrome.i18n extension API.xji@chromium.org2009-09-091-0/+16
| | | | | | | | | | | | | | | | | | The API proposal doc is http://sites.google.com/a/chromium.org/dev/developers/design-documents/extensions/i18n-api This CL only adds the getter of accept languages: chrome.i18n.getAcceptLanguages(). The setter of accept languages will be added in a separate CL. BUG=http://crbug.com/14574 TEST=TEST=There is an extension in chrome\test\data\extensions\samples\i18n. Load this extension. It creates a toolstrip button. Click this button, you should get chrome's accept languages. Review URL: http://codereview.chromium.org/174116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25810 0039d316-1c4b-4281-b951-d872f2087c98
* Use gtk-cursor-blink from GtkSettings to set theevan@chromium.org2009-09-091-0/+1
| | | | | | | | | | | | | | | | caret blink interval on Linux This can be set with the "Cursor Blinking" slider and checkbox in gnome-keyboard-properties. The changed setting will appear in a new renderer, so opening a new tab will see the change. WebKit side is at https://bugs.webkit.org/show_bug.cgi?id=28931 Patch by Joel Stanley <joel@jms.id.au> BUG=20772 Review URL: http://codereview.chromium.org/186009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25797 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for the os x spelling panel to chromium. Users canpinkerton@chromium.org2009-09-092-9/+67
| | | | | | | | | | | now access it from the main menu and context menu and use it to perform spelling tasks. For more detail, see http://code.google.com/p/chromium/wiki/SpellingPanelPlanningDoc Patch from pwicks86@gmail.com (Paul Wicks). BUG=None TEST=The spelling panel should work in os x. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25786 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused ATL headers.jhawkins@chromium.org2009-09-091-12/+9
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/194051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25761 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit deps 48155:48185 and remove a couple of passing tests from ↵japhet@chromium.org2009-09-083-22/+12
| | | | | | | | | | | | | | | test_expectations.txt. Also, merge in http://codereview.chromium.org/174367 (original author: vandebo@chromium.org), which is the downstream half of r48168. BUG=4360 BUG=21228 BUG=18792 TEST=none TBR=eroman git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25669 0039d316-1c4b-4281-b951-d872f2087c98
* Take out the activex control.BUG=20259jam@chromium.org2009-09-084-11/+4
| | | | | | Review URL: http://codereview.chromium.org/200031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25650 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb the DragOperation through all the layers between the platform ↵snej@chromium.org2009-09-082-19/+33
| | | | | | | | | | | | | Drag-n-drop code and WebCore. This allows the HTML5 DataTransfer effectAllowed and dropEffect properties to be set correctly in JS handlers, as per the HTML5 spec. (The drag-dropeffect test isn't in WebKit yet -- it's part of a separate WebKit patch that's been in review for weeks.) R=darin,pink BUG=http://code.google.com/p/chromium/issues/detail?id=14654, http://code.google.com/p/chromium/issues/detail?id=20985 TEST=LayoutTests/fast/events/drag-dropeffect.html, LayoutTests/editing/pasteboard/files-during-page-drags.html Review URL: http://codereview.chromium.org/174364 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25629 0039d316-1c4b-4281-b951-d872f2087c98
* finished testing functions and added events to bookmark tests.erikkay@chromium.org2009-09-082-24/+78
| | | | | | | | added infrastructure to better support events and cleaned up callback testing. Review URL: http://codereview.chromium.org/192028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25623 0039d316-1c4b-4281-b951-d872f2087c98
* Pass printing result to the browser.maruel@chromium.org2009-09-085-54/+141
| | | | | | | | | | | | The resulting PDF file will now be passed to the browser and be saved as "chromium_printing_test.pdf" under current directory. BUG=9847 TEST=printing on linux should now generate chromium_printing_test.pdf in download directory. Printing on Windows should still work. Patch contributed by minyu.huang@gmail.com Review URL: http://codereview.chromium.org/172115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25615 0039d316-1c4b-4281-b951-d872f2087c98
* Convert std::wstring encoding names to std::string in a bunch of files.tony@chromium.org2009-09-042-11/+11
| | | | | | | | | | | | | | | BUG=8647 (http://crbug.com/8647) TEST=run unit_tests.exe and ui_tests.exe Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/179057/show Some linux related fixes by me. Review URL: http://codereview.chromium.org/192017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25529 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Updating the thumbnail size to match the size we use on the newarv@google.com2009-09-041-2/+2
| | | | | | | | | | | | | | | tab page. This should reduce the amount of work needed since the images do not need to be resized. BUG=17455 TEST=No visible changes Review URL: http://codereview.chromium.org/194028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25520 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 24211 - Implement a readsize throttle within the TCP socket.laforge@chromium.org2009-09-041-10/+0
| | | | | | | | | | | | | | | Add a fieldgroup trial for testing it. BUG=none TEST=none Review URL: http://codereview.chromium.org/173259 TBR=mbelshe@google.com Review URL: http://codereview.chromium.org/192027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25510 0039d316-1c4b-4281-b951-d872f2087c98
* Make PrintWebViewHelper::PrintPageAsJPEG compile on Mac.craig.schlenter@chromium.org2009-09-042-5/+6
| | | | | | Review URL: http://codereview.chromium.org/197026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25456 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build for mac botsmhm@chromium.org2009-09-042-4/+4
| | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/201016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25446 0039d316-1c4b-4281-b951-d872f2087c98
* Implement PrintPageAsJPEG feature for Print Preview.In order to show the tab ↵mhm@chromium.org2009-09-045-1/+93
| | | | | | | | contents to the print tab, the renderer should print the page as a JPEG image so it could be rendered in the DOMUI. A unit test case has been created to make sure the image contains something from deciding whether its not 100% white.MockPrinter has been altered to remove the const parameter, since its useful to retrieve the DefaultSettings not via IPC.BUG=173 (http://crbug.com/173)TEST=created a unit test and ran it. Review URL: http://codereview.chromium.org/196021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25445 0039d316-1c4b-4281-b951-d872f2087c98
* This changelist fixes some issues with the NPAPI WMP plugin work in Chrome. ↵jam@chromium.org2009-09-043-79/+52
| | | | | | | | | | | | The first is that we need to disable windowless mode since it doesn't work in the NPAPI plugin (Safari does this as well, and sites don't use windowless for Firefox). The second is to make UpdateGeometry message synchronous for WMP. The problem I saw was that while handling that message, the plugin might disaptch a NPObject Invoke method to play a video, which WMP doesn't expect and it leads to the video never playing. While touching these files, I made some small cleanup by reverting the change that made WebPluginProxy not have a WebPluginDelegateImpl pointer, which added a bunch of unnecessary methods to WebPluginDelegate. BUG=20259 TEST=use --no-activex and try playing the videos on http://www.nana10.co.il/Section/?SectionID=10847&sid=235 Review URL: http://codereview.chromium.org/196012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25433 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up WebEditingClient.darin@chromium.org2009-09-043-66/+137
| | | | | | | | | | | | | | | | | | | | Moves the WebViewDelegate parameter back to WebView::Create and adds a second parameter for WebEditingClient. I had hoped to make the WebEditingClient NULL for RenderView on Windows and Mac, but that turned out to not be an option. I need a few methods on all platforms. The Describe* functions from EditorClientImpl are moved into the TestWebViewDelegate since they are only applicable to layout tests. R=dglazkov BUG= TEST=none Review URL: http://codereview.chromium.org/195008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25432 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust color spaces so that Mac Chrome renders colors properly.amanda@chromium.org2009-09-031-0/+4
| | | | | | | | | | | BUG=19951,20552 TEST=compare pages rendered in Chromium and Safari. They should appear the same. mark: review jrg/brettw: FYI Review URL: http://codereview.chromium.org/194013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25380 0039d316-1c4b-4281-b951-d872f2087c98