summaryrefslogtreecommitdiffstats
path: root/chrome/renderer
Commit message (Collapse)AuthorAgeFilesLines
* Fix memory leak in ExtensionAPIClientTest.mpcomplete@chromium.org2009-10-061-2/+2
| | | | | | TBR=aa git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28151 0039d316-1c4b-4281-b951-d872f2087c98
* Fix scripting during NPP_Destroy. Note that if the plugin is making a call ↵jam@chromium.org2009-10-062-31/+23
| | | | | | | | | | to the renderer so this instance is in the callstack, destruction will have to be asynchronous and so scripting still won't work. This change also fixes use of PluginChannel after it's deleted (if this was the last instance). BUG=23713, 23706 TEST=added ui test Review URL: http://codereview.chromium.org/258026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28141 0039d316-1c4b-4281-b951-d872f2087c98
* Implement browserAction.setIcon(ImageData) for extensions.mpcomplete@chromium.org2009-10-062-20/+88
| | | | | | | | | BUG=23269 TEST=load the test_browser_action sample extension, and click the browser action. Watch it dynamically update. Review URL: http://codereview.chromium.org/242150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28136 0039d316-1c4b-4281-b951-d872f2087c98
* Move runFileChooser from webview_delegate to WebViewClient.yaar@chromium.org2009-10-063-27/+50
| | | | | | | | More details here: http://code.google.com/p/chromium/issues/detail?id=23385 Review URL: http://codereview.chromium.org/259031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28134 0039d316-1c4b-4281-b951-d872f2087c98
* Modify extension request IPC messages to pass a ListValue instead of a string.mpcomplete@chromium.org2009-10-064-5/+30
| | | | | | | | | | | | This allows us to pass binary values through extension requests. I use this in my next CL to pass SkBitmaps. BUG=23269 TEST=no Review URL: http://codereview.chromium.org/251093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28130 0039d316-1c4b-4281-b951-d872f2087c98
* Change flag "auto-spell-correct" to "experimental-spellchecker-features". I ↵sidchat@chromium.org2009-10-051-1/+1
| | | | | | | | | | will be making a series of new features in spellchecking, and will keep all of them under this flag till they become mature enough for default use. BUG=none TEST=none Review URL: http://codereview.chromium.org/260006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28055 0039d316-1c4b-4281-b951-d872f2087c98
* Add a dummy call to icu::TimeZone.createDefault() before the sandbox kicks in.jshin@chromium.org2009-10-051-1/+13
| | | | | | | | | | | This is necessary to get the datetime formatting work correctly in a renderer process (e.g. FTP directory list that is now done in a renderer process.) BUG=23361,23082 TEST=... Review URL: http://codereview.chromium.org/243060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27999 0039d316-1c4b-4281-b951-d872f2087c98
* Adds desktop notification support for renderer process, and enables the ↵johnnyg@chromium.org2009-10-054-0/+243
| | | | | | | | | | | | build flag for chromium build of webkit. Doesn't expose the feature to any websites yet. BUG=none TEST=none (This is part 1 of 3 for this feature; tests will follow). Review URL: http://codereview.chromium.org/194079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27973 0039d316-1c4b-4281-b951-d872f2087c98
* Another stab at the Chromium side of storage events. Re-submission of ↵jorlow@chromium.org2009-10-033-5/+35
| | | | | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=27756 with slight changes in dom_storage_dispatch er_host.cc TBR=darin TEST=Manually inspected that storage events fired. Will turn on more layout tests in a subsequent patch. BUG=19972 Original review URL: http://codereview.chromium.org/223013 Review URL: http://codereview.chromium.org/258010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27943 0039d316-1c4b-4281-b951-d872f2087c98
* Add quota support.jorlow@chromium.org2009-10-033-5/+5
| | | | | | | | | | | Add a 5mb quota to DOM Storage. Most of the details are in an upstream patch (https://bugs.webkit.org/show_bug.cgi?id=29991 ). BUG=16876 TEST=I added a layout test upstream and it works. Review URL: http://codereview.chromium.org/255050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27942 0039d316-1c4b-4281-b951-d872f2087c98
* More WebView / WebViewDelegate cleanup.darin@chromium.org2009-10-033-49/+60
| | | | | | | | | | | | Moves a bunch of methods from glue to the WebKit API. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/246079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27941 0039d316-1c4b-4281-b951-d872f2087c98
* Move the clipboard stuff out of base and into app/clipboard. I renamedbrettw@chromium.org2009-10-031-3/+3
| | | | | | | | | | | clipboard_util to clipboard_util_win since it's Windows-only. This patch makes test_shell depend on app as well. There should be no logic change. TEST=none BUG=none Review URL: http://codereview.chromium.org/260003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27937 0039d316-1c4b-4281-b951-d872f2087c98
* Move the JPEG and PNG codecs from base/gfx to app/gfx/codec. Move the classesbrettw@chromium.org2009-10-033-7/+7
| | | | | | | | | | | | | | | into the gfx namespace. Combine the PNGEncoder and PNGDecoder. There were separate when we had different executables for the browser and renderer, and linked the encoder only in one of them (which saved us some space used by libpng). This hasn't been the case for years, so combining them (again) makes sense. TEST=none BUG=none Review URL: http://codereview.chromium.org/243076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27930 0039d316-1c4b-4281-b951-d872f2087c98
* Add an option to disable NaCl at compile time for platforms where it doesn't ↵piman@chromium.org2009-10-021-0/+2
| | | | | | | | | | build yet Just add disable_nacl=1 to gyp defines Review URL: http://codereview.chromium.org/257029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27873 0039d316-1c4b-4281-b951-d872f2087c98
* Restore plumbing for the spelling panel on Mac.darin@chromium.org2009-10-023-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | It turns out this is reached through a very awkward code path. We send an IPC to the renderer so that it can call WebFrame::executeCommand passing it the "ToggleSpellingPanel" command. That is intercepted in our code--in WebFrameImpl--and results in calling a method on Editor that just turns around and calls EditorClient. EditorClient is again our code, which just pokes the embedder via WebViewClient to get it to send an IPC back to the browser so that it can show the spelling panel. I would have just short-circuited all of this plumbing if it weren't for the side-effect that this code has of triggering an update to the spelling panel. That way it can show the correct word. I think that could be done a simpler way, but for now, I'm content to just restore the way things were. R=pinkerton BUG=23543 TEST=manual test: right click on a misspelled word and select the option on Mac Chrome to show the spelling panel. you should see it appear :) Review URL: http://codereview.chromium.org/246071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27848 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup in WebKitClient.darin@chromium.org2009-10-022-4/+5
| | | | | | | | | | | | | | 1. Avoid including windows.h 2. Rename FileType to FileHandle 3. Fix consumers to use FileHandle R=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/246072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27845 0039d316-1c4b-4281-b951-d872f2087c98
* Make sudden termination into a counter.estade@chromium.org2009-10-022-0/+21
| | | | | | | | | | | | | | | | | We were incorrectly interpreting enableSuddenTermination to mean "enable sudden termination". Really it should just decrement a counter, and we should only enable sudden termination when that counter reaches 0. Related to, but not the fix for, http://crbug.com/5638 This may have been causing memory corruption due to shutting down the renderer process while writing to a storage area or icon database (although honestly I don't actually know if we even use those parts of webkit). Also, add a ui test that fails before this patch and succeeds with this patch. BUG=none TEST=sudden termination still works on a simple page Review URL: http://codereview.chromium.org/245036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27831 0039d316-1c4b-4281-b951-d872f2087c98
* Move various methods from glue/webview.h to api/public/WebView.h darin@chromium.org2009-10-013-16/+11
| | | | | | | | | | | | | | | | | | I'll re-order the methods in webview_impl.cc in a follow-up CL. I wanted to keep this one easy to review. SetBackForwardListSize is no longer necessary given that BackForwardListChromium.cpp doesn't care about its capacity. R=dglazkov BUG=10033 TEST=none Originally reviewed here: http://codereview.chromium.org/251051 Review URL: http://codereview.chromium.org/255042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27780 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27756.jorlow@chromium.org2009-10-013-35/+5
| | | | | | Review URL: http://codereview.chromium.org/249058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27759 0039d316-1c4b-4281-b951-d872f2087c98
* Another stab at the Chromium side of storage events. The WebKit side can be ↵jorlow@chromium.org2009-10-013-5/+35
| | | | | | | | | | | found here: https://bugs.webkit.org/show_bug.cgi?id=29655 TEST=Manually inspected that storage events fired. Will turn on more layout tests in a subsequent patch. BUG=19972 Review URL: http://codereview.chromium.org/223013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27756 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 27705 - Move various methods from glue/webview.h to api/public/WebView.hmal@chromium.org2009-10-013-11/+16
| | | | | | | | | | | | | | | | | | | | | | | | ** browser_tests started failing at this revision. See: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20XP/builds/7697/steps/browser_tests/logs/stdio ** I'll reorder the methods in webview_impl.cc in a followup CL. I wanted to keep this one easy to review. SetBackForwardListSize is no longer necessary given that BackForwardListChromium.cpp doesn't care about its capacity. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/251051 TBR=darin@chromium.org Review URL: http://codereview.chromium.org/246060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27711 0039d316-1c4b-4281-b951-d872f2087c98
* Move various methods from glue/webview.h to api/public/WebView.hdarin@chromium.org2009-10-013-16/+11
| | | | | | | | | | | | | | | | I'll re-order the methods in webview_impl.cc in a follow-up CL. I wanted to keep this one easy to review. SetBackForwardListSize is no longer necessary given that BackForwardListChromium.cpp doesn't care about its capacity. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/251051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27705 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback Scavenge implemetation and rely on existing functionality to freejar@chromium.org2009-10-011-2/+2
| | | | | | | | | | | | | | This is a landing of a patch provided by antonm. See: http://codereview.chromium.org/235022 Also included change to browser_about_handler.cc to fix build, and I set TCMALLOC_RELEASE_RATE to 1.0 on line 40 of page_heap.cc (I think this was an inadvertent rollback element). r=antonm Review URL: http://codereview.chromium.org/257009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27692 0039d316-1c4b-4281-b951-d872f2087c98
* Turn extension script injection histograms into uma histograms.asargent@chromium.org2009-09-301-8/+11
| | | | | | | | | | | | | | | -Switch to UMA_HISTOGRAM_* macros. -Rename to reflect that extensions are subsuming content scripts, and better fit the common style of histogram names. -Count css and scripts separately, and fix script count to account for multiple scripts per extension. BUG=none TEST=none Review URL: http://codereview.chromium.org/244038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27685 0039d316-1c4b-4281-b951-d872f2087c98
* Enable <video> using cachehclam@chromium.org2009-09-301-0/+4
| | | | | | | | | | | | Retrying the following two patches: http://codereview.chromium.org/253001/show http://codereview.chromium.org/248012/show TBR=scherkus Review URL: http://codereview.chromium.org/242073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27632 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up webkit/api/public/WebView.hdarin@chromium.org2009-09-305-90/+88
| | | | | | | | | | | | | | This change does not completely eliminate webkit/glue/webview.h. Instead, the old WebView extends from the new WebView temporarily as we complete the transition. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/257001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27620 0039d316-1c4b-4281-b951-d872f2087c98
* Address review comments.thakis@chromium.org2009-09-302-8/+11
| | | | | | | | | | | Belongs to http://codereview.chromium.org/254002 BUG=none TEST=none Review URL: http://codereview.chromium.org/244044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27609 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding:mbelshe@google.com2009-09-301-0/+10
| | | | | | | | | | | | | | | Implement a readsize throttle within the TCP socket. Add a fieldgroup trial for testing it. BUG=none TEST=none Original Review URL: http://codereview.chromium.org/173259 Review URL: http://codereview.chromium.org/243038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27595 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r27589 that broke the treehclam@chromium.org2009-09-301-4/+0
| | | | | | | | TBR=scherkus Review URL: http://codereview.chromium.org/246043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27590 0039d316-1c4b-4281-b951-d872f2087c98
* <video> use cache if --enable-byte-range-support is presenthclam@chromium.org2009-09-301-0/+4
| | | | | | | | | | | BUG=16013 TEST=Playing a video should still work with the flag in incognito mode or not. Allow <video> to use cache if running with experimental byte range support. Review URL: http://codereview.chromium.org/253001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27589 0039d316-1c4b-4281-b951-d872f2087c98
* WebView::DownloadImage refactoredyaar@chromium.org2009-09-292-10/+51
| | | | | | | | | The implementation was dependent on webkit_glue::image_resource_fetcher and had to be removed if we want to upstream WebView. DownloadImage has been moved into RenderView::DownloadImage. WebViewImpl's set of ImageResourceFetchers has been ripped off and moved into RenderView. Review URL: http://codereview.chromium.org/255006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27564 0039d316-1c4b-4281-b951-d872f2087c98
* Fix stupid gcc warning.thakis@chromium.org2009-09-291-1/+1
| | | | | | | The real fix is probably to add attribute __noreturn__ to CHECK() somehow, but let's fix the tree first. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27465 0039d316-1c4b-4281-b951-d872f2087c98
* Fix cmd-up/cmd-down.thakis@chromium.org2009-09-294-43/+183
| | | | | | | | | | | | | | | | | The approach is to special-case moveToBeginningOfDocument and moveToEndOfDocument in WebFrameImpl::executeCommand(). With this (and the cocoa keyboard bindings patch being landed), the special-case code in WebViewImpl::ScrollViewWithKeyboard() can be removed. Also add a test for cmd-up/down. Change chrome.gyp so that it supports osx-only unit tests (_unittest_mac.mm). Move OnPrintPageAsBitmap to the other printing tests. BUG=22585 TEST=Go to a page with both text box and scrollbar (e.g. http://en.wikipedia.org ). Pressing cmd-down should scroll to end of page, cmd-up back to start. Clicking the text box and trying some emacs shortcuts should work (ctrl-a jumps to start of line, cmd-h acts as backspace, etc). Review URL: http://codereview.chromium.org/254002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27464 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the need for cross process events in order to get plugin ↵jam@chromium.org2009-09-294-29/+13
| | | | | | | | | | processes to run nested message loops when a dialog is shown. Instead use an async message that's broadcast from the renderer to all plugin processes that are connected to it, and which is dispatched on the plugin IO thread to set a process-local waitable event. This fixes showModalDialog on Linux/Mac. BUG=15891 TEST=covered by UI tests, undef's them for POSIX Review URL: http://codereview.chromium.org/242043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27456 0039d316-1c4b-4281-b951-d872f2087c98
* First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in ↵gregoryd@google.com2009-09-293-1/+30
| | | | | | | | | | | plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27397 Review URL: http://codereview.chromium.org/153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27445 0039d316-1c4b-4281-b951-d872f2087c98
* Use the current frame's URL when initializing the extension framework for a ↵mpcomplete@chromium.org2009-09-291-5/+4
| | | | | | | | | | | | | frame. Previously we were using the toplevel frame's URL. BUG=22658 TEST=no Review URL: http://codereview.chromium.org/249026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27440 0039d316-1c4b-4281-b951-d872f2087c98
* Fix deadlock when plugin puts an alert and right afterwards the browser ↵jam@chromium.org2009-09-285-64/+45
| | | | | | | | | | process makes a win32 call that ends up waiting on the plugin. Since the plugin thread is blocked, the Windows message doesn't get dispatched and the browser ui thread deadlocks. The message from the renderer would make the plugin run a nested message loop but it doesn't get run on the browser ui thread since it's blocked. The fix is to set the event that runs nested message loop in the renderer process. BUG=23147 TEST=ui tests already cover nested message loops and plugins. This particular scenario is hard to write a test case for because it's a race condition involving the browser. Review URL: http://codereview.chromium.org/243018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27421 0039d316-1c4b-4281-b951-d872f2087c98
* Implement about:ipc dialog for Mac.jrg@chromium.org2009-09-281-0/+5
| | | | | | | | | Convert IPC logging trigger from x-process waitable event to a messages sent to all processes. Review URL: http://codereview.chromium.org/192070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27405 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 27397 - First step towards NaClChrome integration:1. NaCl plugin ↵gregoryd@google.com2009-09-283-30/+1
| | | | | | | | | | | | | becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324 Review URL: http://codereview.chromium.org/153002 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/235042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27400 0039d316-1c4b-4281-b951-d872f2087c98
* First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in ↵gregoryd@google.com2009-09-283-1/+30
| | | | | | | | | plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27324 Review URL: http://codereview.chromium.org/153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27397 0039d316-1c4b-4281-b951-d872f2087c98
* Implementing chrome.i18n.getMessage call, that loads message from the ↵cira@chromium.org2009-09-286-6/+132
| | | | | | | | | | | | | | | | | | | extension catalog, and if necessary replaces placeholders (up to 9). I have 3 forms of getMessage call: getMessage("name") for simple messages without placeholders. getMessage("name", "one param") for messages with only one placeholder. getMessage("name", ["one", "two"]) for messages with only one or more placeholders. getMessage returns string. BUG=12131 TEST=Load samples/i18n extension (switch Chrome to sr locale) and observe ext. name, description and toolstrip texts should be in Serbian. Review URL: http://codereview.chromium.org/225009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27393 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 27324 - First step towards NaClChrome integration:1. NaCl plugin ↵gregoryd@google.com2009-09-263-30/+1
| | | | | | | | | | | | becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Review URL: http://codereview.chromium.org/153002 TBR=bradnelson@google.com Review URL: http://codereview.chromium.org/244017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27326 0039d316-1c4b-4281-b951-d872f2087c98
* First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in ↵gregoryd@google.com2009-09-263-1/+30
| | | | | | | | plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandboxCommitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=27315 Review URL: http://codereview.chromium.org/153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27324 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Browser Actions extensions.finnur@chromium.org2009-09-262-1/+9
| | | | | | | | | | | | | | | | Browser Actions are like Page Actions, except they appear next to the Omnibox and are always visible. For details see http://code.google.com/p/chromium/wiki/BrowserActions. Added a simple browser action sample that adds a Print button to the chrome toolbar (which brings up the Print dialog for the current page). Removed |type| from PageActions, which is currently ignored and was already removed from the docs. Each extension can only have 1 browser_action. Each browser action can specify more than one icon, but only the first is used. And no API has been added yet (besides the event definition). BUG=22099 TEST=Install the sample browser action, navigate to google.com, press the print button. A print dialog should come up. Review URL: http://codereview.chromium.org/243001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27319 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 27315 - First step towards NaClChrome integration:1. NaCl plugin ↵gregoryd@google.com2009-09-263-30/+1
| | | | | | | | | | | | becomes a builtin plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "internalnacl" is required to enable the builtin NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandbox Review URL: http://codereview.chromium.org/153002 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/244014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27317 0039d316-1c4b-4281-b951-d872f2087c98
* First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in ↵gregoryd@google.com2009-09-263-1/+30
| | | | | | | | plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin. NaCl still cannot run in Chrome sandbox, the flag automatically disables the sandbox Review URL: http://codereview.chromium.org/153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27315 0039d316-1c4b-4281-b951-d872f2087c98
* Make --show-extensions-on-top look exactly, pixel-for-pixelaa@chromium.org2009-09-251-17/+24
| | | | | | | | | | | | | | | identical to the bookmark bar. Used the same semi-transparent image for the button background that the bookmarkbar uses, so that it will work for themes. The upside of this is that we look the same as the bookmark bar. The downside is that we look the same as the bookmark bar (which currently looks pretty bad with some themes). However, with the default theme, I think that the bookmark bar currently looks better than our toolstrips. The UI team should probably create some images that look good with different themes for the bookmark bar, then we can update this again. Review URL: http://codereview.chromium.org/225025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27258 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb the new mixed content API callbacks to the tab contents. We'll actuallyabarth@chromium.org2009-09-252-2/+14
| | | | | | | | | | | | use these notifications in a future patch. No behavior change. R=agl Review URL: http://codereview.chromium.org/241004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27249 0039d316-1c4b-4281-b951-d872f2087c98
* Force garbage collection after running any unit tests that initialize WebViews.jorlow@chromium.org2009-09-251-14/+11
| | | | | | | | | | | | | It's quite possible that we just plain shouldn't allow any unit tests to initialize WebKit for philosophical and theoretical reasons. But this does seem to work, so I guess we should just go this route for now. BUG=22971 TEST=none Review URL: http://codereview.chromium.org/240001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27239 0039d316-1c4b-4281-b951-d872f2087c98
* Move another method from WebViewDelegate to WebViewClient.darin@chromium.org2009-09-253-5/+6
| | | | | | | | | | | | This is kinda like yelling, right? R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/241002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27210 0039d316-1c4b-4281-b951-d872f2087c98