summaryrefslogtreecommitdiffstats
path: root/chrome/service
Commit message (Collapse)AuthorAgeFilesLines
* Move some chrome\common code to content in preparation for moving chrome\gpu.jam@chromium.org2011-03-111-2/+2
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6686002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77868 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member variables.jhawkins@chromium.org2011-03-111-1/+2
| | | | | | | | | | CID=11644,14447,14816,15428 BUG=none TEST=none Review URL: http://codereview.chromium.org/6670016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77763 0039d316-1c4b-4281-b951-d872f2087c98
* Added the HttpAuthHandlerFactory pointer to the ↵sanjeevr@chromium.org2011-03-101-0/+2
| | | | | | | | | | | | net::HttpNetworkSession::Params structure. This fixes the service process crash as seen here: http://crash/reportdetail?reportid=2e6994509abbee7b BUG=75692 TEST=Cloud Print proxy for regressions, we should not see that crash any more. Review URL: http://codereview.chromium.org/6672002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77708 0039d316-1c4b-4281-b951-d872f2087c98
* Move ChildProcessHost and ChildProcessInfo to content.jam@chromium.org2011-03-091-2/+2
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/6612040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77496 0039d316-1c4b-4281-b951-d872f2087c98
* Mac/Linux proxy fix.scottbyer@chromium.org2011-03-071-0/+5
| | | | | | | | | | | | | | | On Mac/Linux we keep the socket open, so don't get an OnChannelConnected message when a new Chromium launches and connects to the service, so we weren't properly marking ourselves as having a client connected. When the service was disable and Chromium exited, it meant we weren't properly exiting immediately. This is only a partial fix for the bug. BUG=74983 TEST=Start Chromium, enable the proxy, quit Chromium, start Chromium, disable the proxy, quit Chromium. With this fix the service process immediately exits. Review URL: http://codereview.chromium.org/6635023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77206 0039d316-1c4b-4281-b951-d872f2087c98
* Service process crash on Windows.scottbyer@chromium.org2011-03-051-4/+4
| | | | | | | | | | | | A crash not caught by the service process browser tests, revert the timeline of creating the proxy service on Windows to what it was previously. BUG=74992 TEST=enable cloud print proxy on Windows, service doesn't crash withing 5 minutes. Review URL: http://codereview.chromium.org/6626038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77017 0039d316-1c4b-4281-b951-d872f2087c98
* Mac print proxy out from flag.scottbyer@chromium.org2011-03-051-0/+5
| | | | | | | | | | | | | We found the issue with control of the service process, and with that fix the proxy is stable enough to be exposed. The fix also improves the Linux proxy control, but an autostarted service process on Linux still has an issue, so that remains behind the flag. BUG=74223 TEST=See that cloud print proxy is not in about:flags on the Mac, and the sign in is availble in Under the Hood. Signing in, restarting Chromium, and disabling the proxy works (removes the autostart file is the quickest visible way to verify). Review URL: http://codereview.chromium.org/6633004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77005 0039d316-1c4b-4281-b951-d872f2087c98
* Tear down service IPC channel before creating a new one.wez@chromium.org2011-03-041-0/+1
| | | | | | | | | BUG=74820 TEST=Start Chrome and enable Chromoting. Restart Chromer and open Preferences, and check that Remoting is correctly detected as enabled. Review URL: http://codereview.chromium.org/6612028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76903 0039d316-1c4b-4281-b951-d872f2087c98
* Service process fixes for Linux.scottbyer@chromium.org2011-03-036-21/+54
| | | | | | | | | | | | | | | | | | Linux requires that the proxy_config_service be created on the I/O thread. Fortunately, ServiceURLRequestContextGetter was already thread safe ref counted, so we lift creation of that and the (also, fortunately) thread safe ref counted net::ProxyService up to service process initialization time. That created proxy service now gets passed in to the dynamic creation of the ServiceURLRequestContexts. Should have no effect on other platforms. BUG=74226 TEST=Start Chromium on Linux with --enable-cloud-print-proxy, sign in, and examine ~/.config/chromium/Service State. With the fix, Service State properly contains the needed tokens to properly re-launch and be a proxy. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76612 Review URL: http://codereview.chromium.org/6602041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76760 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76612 - Service process fixes for Linux.scottbyer@chromium.org2011-03-026-54/+21
| | | | | | | | | | | | | | | | | | | Linux requires that the proxy_config_service be created on the I/O thread. Fortunately, ServiceURLRequestContextGetter was already thread safe ref counted, so we lift creation of that and the (also, fortunately) thread safe ref counted net::ProxyService up to service process initialization time. That created proxy service now gets passed in to the dynamic creation of the ServiceURLRequestContexts. Should have no effect on other platforms. BUG=74226 TEST=Start Chromium on Linux with --enable-cloud-print-proxy, sign in, and examine ~/.config/chromium/Service State. With the fix, Service State properly contains the needed tokens to properly re-launch and be a proxy. Review URL: http://codereview.chromium.org/6602041 TBR=scottbyer@chromium.org Review URL: http://codereview.chromium.org/6606022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76638 0039d316-1c4b-4281-b951-d872f2087c98
* Service process fixes for Linux.scottbyer@chromium.org2011-03-026-21/+54
| | | | | | | | | | | | | | | | Linux requires that the proxy_config_service be created on the I/O thread. Fortunately, ServiceURLRequestContextGetter was already thread safe ref counted, so we lift creation of that and the (also, fortunately) thread safe ref counted net::ProxyService up to service process initialization time. That created proxy service now gets passed in to the dynamic creation of the ServiceURLRequestContexts. Should have no effect on other platforms. BUG=74226 TEST=Start Chromium on Linux with --enable-cloud-print-proxy, sign in, and examine ~/.config/chromium/Service State. With the fix, Service State properly contains the needed tokens to properly re-launch and be a proxy. Review URL: http://codereview.chromium.org/6602041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76612 0039d316-1c4b-4281-b951-d872f2087c98
* Applying factory pattern (through NativeMetafileFactory class). It is used ↵dpapad@chromium.org2011-03-021-5/+9
| | | | | | | | | | | | | | | to retrieve different printing contexts (based on the platform and user preferences). BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76553 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=76555 Review URL: http://codereview.chromium.org/6544028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76581 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 76553 - Applying factory pattern (through NativeMetafileFactory ↵jam@chromium.org2011-03-021-9/+5
| | | | | | | | | | | | | | class). It is used to retrieve different printing contexts (based on the platform and user preferences). BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6544028 TBR=dpapad@chromium.org Review URL: http://codereview.chromium.org/6594121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76555 0039d316-1c4b-4281-b951-d872f2087c98
* Applying factory pattern (through NativeMetafileFactory class). It is used ↵dpapad@chromium.org2011-03-021-5/+9
| | | | | | | | | | | to retrieve different printing contexts (based on the platform and user preferences). BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/6544028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76553 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes service_process.cc when not using ENABLE_REMOTING flag.bulach@chromium.org2011-02-281-0/+2
| | | | | | | | | BUG=none TEST=compiles without the flag Review URL: http://codereview.chromium.org/6598034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76222 0039d316-1c4b-4281-b951-d872f2087c98
* Added a command-line option to disable adding the service process to ↵sanjeevr@chromium.org2011-02-262-4/+7
| | | | | | | | | | | autorun. This is for use by enterprise proxies that use their own custom autostart mechanism. Also honored the kNoErrorDialogs flag to not show the token expired notification. BUG=None TEST=Launching the service process with --no-service-autorun should not register the service process to autorun. Also running it with --noerrdialogs and an expired token should not show the token expired notification. Review URL: http://codereview.chromium.org/6592023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76128 0039d316-1c4b-4281-b951-d872f2087c98
* Removed the command line from ServiceProcessState::AddToAutoRun() and had ↵sanjeevr@chromium.org2011-02-252-4/+1
| | | | | | | | | | | the class calculate its own command line. Wired up Linux autorun code and added unit tests. BUG=None TEST=Test service process autorun when enabling the cloud print proxy, unit-tests. Review URL: http://codereview.chromium.org/6591002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76077 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove a bunch of unneeded includes.thestig@chromium.org2011-02-241-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6580021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75964 0039d316-1c4b-4281-b951-d872f2087c98
* Get service process running standalone on the mac by hooking it into launchd.dmaclach@chromium.org2011-02-244-12/+25
| | | | | | | | | BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/6482016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75893 0039d316-1c4b-4281-b951-d872f2087c98
* Run event executor on the ui thread to remove the need to explicitly ↵ajwong@chromium.org2011-02-194-6/+15
| | | | | | | | | | | | XFlush() the XTest calls. BUG=none TEST=Connect to a host and try moving the mouse and typing. Both inputs should be reflected correctly. Review URL: http://codereview.chromium.org/6489031 Patch from Jamie Walch <jamiewalch@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75477 0039d316-1c4b-4281-b951-d872f2087c98
* Fix service process to not idle-timeout if Chromoting is enabled.wez@chromium.org2011-02-181-0/+5
| | | | | | | | | | | | | | | | When Chromoting is enabled via Chrome, the service process is started if necessary and notified that the Chromoting service has become enabled. When the service process is later auto-started (or run manually) it will initialize Chromoting, which detects that it is enabled and starts up, but fails to inform the service process that it's enabled, so the process waits a while and then exits. BUG=73168 TEST=Enable Chromoting in Chrome. Kill the existing service process and start a new one manually. Ensure that the new one runs for at least two minutes without quitting. Review URL: http://codereview.chromium.org/6532023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75381 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize media library on service process startup.wez@chromium.org2011-02-182-5/+28
| | | | | | | | | BUG=73166 TEST=Enable Chromoting Host in Chrome, and try to connect to it. The service process should not crash trying to retrieve the VP8 codec. Review URL: http://codereview.chromium.org/6539017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75379 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a corner case issue with printing XPS documents to the Microsoft XPS ↵sanjeevr@chromium.org2011-02-181-4/+9
| | | | | | | | | | | Document Writer which would not generate a job id. BUG=None TEST=Test submitting an XPS document to the XPS Document Writer via cloud print. Review URL: http://codereview.chromium.org/6544002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75333 0039d316-1c4b-4281-b951-d872f2087c98
* Added support to the Windows cloud print proxy to print XPS documents ↵sanjeevr@chromium.org2011-02-179-68/+242
| | | | | | | | | | | directly without any conversion (only works on Windows 7). The proxy uses the Accept: header to specify what data types it can accept. BUG=None. TEST=When the cloud print service supports this, submitting an XPS document should go through to the Win 7 proxy without any conversions. Review URL: http://codereview.chromium.org/6523040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75286 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r74842willchan@chromium.org2011-02-162-30/+28
| | | | | | | | | | | Merged correctly this time. BUG=none TEST=none Review URL: http://codereview.chromium.org/6523067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75165 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 75143 - Reland r74842willchan@chromium.org2011-02-162-28/+30
| | | | | | | | | | | | | | The bug was that the ProfilePolicyContext was getting initialized before the ProfileImplIOData::Handle was initialized. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6526029 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6480120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75152 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r74842willchan@chromium.org2011-02-162-30/+28
| | | | | | | | | | | The bug was that the ProfilePolicyContext was getting initialized before the ProfileImplIOData::Handle was initialized. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6526029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75143 0039d316-1c4b-4281-b951-d872f2087c98
* Added code to restart the service process in the event of a crash.sanjeevr@chromium.org2011-02-151-1/+44
| | | | | | | | | BUG=None. TEST=A crash in the cloud print proxy should prompt the user for a restart. Review URL: http://codereview.chromium.org/6474030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74886 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74842 - It seems to have broken the ChromeOS "PFQ bot"?willchan@chromium.org2011-02-142-28/+30
| | | | | | | | | | | | | | | | r74561 added a DCHECK to make sure users didn't try to access the ChromeURLRequestContextGetter from the Profile, since the Profile should only be read on the UI thread. ChromeOS apparently tried to access it from another thread, and therefore hit the new DCHECK. I'm relanding without the DCHECK. I'm also eagerly initializing the off the record context getter to prevent the ChromeOS race. ChromeOS should fix that code so the eager initialization isn't necessary. BUG=none TEST=none Review URL: http://codereview.chromium.org/6484041 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6517021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74848 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r74728 which reverted r74561 for exposing a ChromeOS bug.willchan@chromium.org2011-02-142-30/+28
| | | | | | | | | | | | | r74561 added a DCHECK to make sure users didn't try to access the ChromeURLRequestContextGetter from the Profile, since the Profile should only be read on the UI thread. ChromeOS apparently tried to access it from another thread, and therefore hit the new DCHECK. I'm relanding without the DCHECK. I'm also eagerly initializing the off the record context getter to prevent the ChromeOS race. ChromeOS should fix that code so the eager initialization isn't necessary. BUG=none TEST=none Review URL: http://codereview.chromium.org/6484041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74842 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r74632 "Reland r74561 after fixing ChromeOS build breakage."oshima@google.com2011-02-122-28/+30
| | | | | | | | | | | | This reverts commit f19e6d524e086ed8182a475680e931a9a870d2a8. TBR=willchan@chromium.org BUG=none TEST=chromeos pfq bot should cycle green Review URL: http://codereview.chromium.org/6512009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74728 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r74561 after fixing ChromeOS build breakage.willchan@chromium.org2011-02-112-30/+28
| | | | | | | | | | | | | | | | | Introduce OffTheRecordProfileIOData and ProfileImplIOData. They both inherit from ProfileIOData. The former is for the off the record (incognito) profile. The latter is for the normal ProfileImpl profile. All of the IO related Profile objects are now initialized at the same time, in the subtype implementations of ProfileIOData::LazyInitializeInternal(). I also took this opportunity to clean URLRequestContext up so it is a class and keeps its member variables private. This required touching a fair number of files. TODO: Remove lots of the refcounting of member variables, since they can now be owned by ProfileIOData. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6500002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74632 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74561 for breaking the ChromeOS buildwillchan@chromium.org2011-02-112-28/+30
| | | | | | | | | | | | | | | | | | | | Introduce OffTheRecordProfileIOData and ProfileImplIOData. They both inherit from ProfileIOData. The former is for the off the record (incognito) profile. The latter is for the normal ProfileImpl profile. All of the IO related Profile objects are now initialized at the same time, in the subtype implementations of ProfileIOData::LazyInitializeInternal(). I also took this opportunity to clean URLRequestContext up so it is a class and keeps its member variables private. This required touching a fair number of files. TODO: Remove lots of the refcounting of member variables, since they can now be owned by ProfileIOData. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6286133 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/6489020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74564 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce OffTheRecordProfileIOData and ProfileImplIOData.willchan@chromium.org2011-02-112-30/+28
| | | | | | | | | | | | | | | They both inherit from ProfileIOData. The former is for the off the record (incognito) profile. The latter is for the normal ProfileImpl profile. All of the IO related Profile objects are now initialized at the same time, in the subtype implementations of ProfileIOData::LazyInitializeInternal(). I also took this opportunity to clean URLRequestContext up so it is a class and keeps its member variables private. This required touching a fair number of files. TODO: Remove lots of the refcounting of member variables, since they can now be owned by ProfileIOData. BUG=67237 TEST=none Review URL: http://codereview.chromium.org/6286133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74561 0039d316-1c4b-4281-b951-d872f2087c98
* Fix service process crash when chromoting is enabled and browser shuts down.hclam@chromium.org2011-02-084-30/+71
| | | | | | | | | | | This also make disable remoting to actually work. BUG=69713, 71615 TEST=None Review URL: http://codereview.chromium.org/6410104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74146 0039d316-1c4b-4281-b951-d872f2087c98
* More out-of-lining of test code, along with a bunch of GMOCK objects.erg@google.com2011-02-082-0/+3
| | | | | | | | | | | Most notably, rename various mock_objects.h files in remoting/ because after deinlining, there were compile failures. This fixes Windows compiling because you can't have two implementation files with the same name in a project, even if they are in different directories. (The output from one compile will clobber the others!) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6250198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74059 0039d316-1c4b-4281-b951-d872f2087c98
* Change includes of gfx/* to ui/gfx/*sail@chromium.org2011-02-052-2/+2
| | | | | | | | | BUG=71063 TEST=compiled Review URL: http://codereview.chromium.org/6312156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73890 0039d316-1c4b-4281-b951-d872f2087c98
* Added CUPS error handling.gene@google.com2011-02-031-8/+10
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6250144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73706 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor HttpNetworkSession construction.willchan@chromium.org2011-02-031-15/+7
| | | | | | | | | | | Introduce HttpNetworkSession::Params. This should make it easy to add new optionally NULL parameters. I also took this opportunity to eliminate some copy/pastes of TestURLRequestContext and make them use the original. I was also able to remove the need for ClientSocketFactory::GetDefaultFactory() calls and new SpdySessionPool() calls in most places. BUG=none TEST=none Review URL: http://codereview.chromium.org/6349028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73669 0039d316-1c4b-4281-b951-d872f2087c98
* Make changes sanjeev suggesteddmaclach@chromium.org2011-02-032-3/+1
| | | | | | | | | BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/6286082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73656 0039d316-1c4b-4281-b951-d872f2087c98
* Get service processes working on Mac and Linux.dmaclach@chromium.org2011-02-025-30/+34
| | | | | | | | | | | Service processes will now launch, and attach to ipc channels. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/6349029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73425 0039d316-1c4b-4281-b951-d872f2087c98
* Initialized CrApplication for the service process.sanjeevr@chromium.org2011-01-291-0/+8
| | | | | | | | | BUG=None TEST=Service process should run on the Mac Review URL: http://codereview.chromium.org/6269026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73091 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed a corner-case crash that would be triggered when a new printer was ↵sanjeevr@chromium.org2011-01-281-1/+5
| | | | | | | | | | | added while an existing printer was being registered. BUG=None TEST=Adding several printers to Windows via a script should not crash the proxy. Review URL: http://codereview.chromium.org/6270009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73032 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify HttpCache/HttpNetworkLayer/HttpNetworkSession interaction.willchan@chromium.org2011-01-281-12/+18
| | | | | | | | | | | | | Eliminate lazy initialization of HttpNetworkSession in HttpNetworkLayer. * This eliminates the need to update parameters for HttpNetworkLayer, it just takes a HttpNetworkSession. * It is OK to eliminate lazy initialization since these variables are cheap. BUG=none TEST=none Review URL: http://codereview.chromium.org/6402002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72931 0039d316-1c4b-4281-b951-d872f2087c98
* Part 1 of repairing regressions to my old clang check plugins so Nico canerg@google.com2011-01-272-1/+6
| | | | | | | | | | | deploy the clang plugins to the waterfall/trybots. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6366019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72846 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up net unit testing code.erg@google.com2011-01-261-3/+3
| | | | | | | | | | | | | | | | | | | | (Reapply r72562 with willchan's nits + locally tested shlib fixes + removing duplicate code that was partially responsible for the failure.) - Move code included from blah_unittest.h (where blah_unittest.cc has actual unittests) into their own files, often completely out-of-lining the definitions. - Remove anonymous namespaces from headers. - Reorder method declarations. - Make other unit test link against net_test_support instead of reaching in and including .h files in their targets directly. BUG=68682 TEST=compiles First Review URL: http://codereview.chromium.org/6264013 Review URL: http://codereview.chromium.org/6248021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72682 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Clean up net unit testing code." since it breaks the shlib builder.erg@google.com2011-01-251-1/+1
| | | | | | | | | | This reverts commit 006f377bbb65ece3490b7c76e58e0dc4cb330909 (r72562). BUG=68682 TEST=compiles TBR=thomasvl git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72564 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up net unit testing code.erg@google.com2011-01-251-1/+1
| | | | | | | | | | | | | | | | | - Move code included from blah_unittest.h (where blah_unittest.cc has actual unittests) into their own files, often completely out-of-lining the definitions. - Remove anonymous namespaces from headers. - Reorder method declarations. - Make other unit test link against net_test_support instead of reaching in and including .h files in their targets directly. BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6264013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72562 0039d316-1c4b-4281-b951-d872f2087c98
* Added a diagnostic user message when enumerating printers fails. Also ↵sanjeevr@chromium.org2011-01-248-48/+120
| | | | | | | | | | | tweaked some of the strings. BUG=None TEST=Test Cloud Print Proxy. Review URL: http://codereview.chromium.org/6356007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72422 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to ui/baseben@chromium.org2011-01-212-2/+2
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98