summaryrefslogtreecommitdiffstats
path: root/chrome/service
Commit message (Collapse)AuthorAgeFilesLines
* Move URLFetcherDelegate to net/ and split URLFetcher between net/ and content/akalin@chromium.org2012-05-1115-59/+59
| | | | | | | | | | | | | | | | | | | | | Temporarily make a shim content::URLFetcherDelegate class. A future CL will replace all instances of content::URLFetcherDelegate with net::URLFetcherDelegate and remove that class. Move most URLFetcher methods to net::URLFetcher, except for the static methods (which will be handled in a future CL) and AssociateWithRenderView, which is content-specific. Replace all instances of content::URLFetcher* in the URLFetcherDelegate callbacks with net::URLFetcher* (except for rlz, which required its own special hack). BUG=118220 TEST= TBR=mnissler@chromium.org,jhawkins@chromium.org,cpu@chromium.org,estade@chromium.org,sky@chromium.org,joth@chromium.org,satish@chromium.org Review URL: https://chromiumcodereview.appspot.com/10386063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136514 0039d316-1c4b-4281-b951-d872f2087c98
* Stop refcounting URLRequestContext.willchan@chromium.org2012-05-113-11/+10
| | | | | | | | | | | | While doing so, fix a few issues with the code like ordering of URLRequestContext to ensure correct destruction order. Also fix const correctness in some places. BUG=58859 TEST=none TBR=willchan Review URL: https://chromiumcodereview.appspot.com/10299002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136497 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix pass by value errors.kmadhusu@chromium.org2012-05-104-5/+5
| | | | | | | | | | | CID=103965, 103964 BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10386054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136214 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix uninitialized member variable.kmadhusu@chromium.org2012-05-091-0/+1
| | | | | | | | | | | | CID=103963 BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10381074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136158 0039d316-1c4b-4281-b951-d872f2087c98
* Add new ResourceBundle::Delegate interface.marshall@chromium.org2012-05-091-1/+1
| | | | | | | | | BUG=125351 TEST=ResourceBundle.* Review URL: https://chromiumcodereview.appspot.com/10270023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136039 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 135222 - it broke multiprofile tests - Use worker pool for IO in ↵sergeyu@chromium.org2012-05-072-4/+4
| | | | | | | | | | | JsonPrefStore. Review URL: https://chromiumcodereview.appspot.com/10344007 TBR=sergeyu@chromium.org Review URL: https://chromiumcodereview.appspot.com/10384047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135723 0039d316-1c4b-4281-b951-d872f2087c98
* Added wipeout functionality when Cloud Print Connector get disabled by user ↵gene@chromium.org2012-05-0415-38/+301
| | | | | | | | | | | | in settings. This will unregister all local printers from the server. TEST=Disable CLoud Print in Chrome and verify printers get unregistered. Review URL: http://codereview.chromium.org/10373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135420 0039d316-1c4b-4281-b951-d872f2087c98
* Use worker pool for IO in JsonPrefStore.sergeyu@chromium.org2012-05-032-4/+4
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10344007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135222 0039d316-1c4b-4281-b951-d872f2087c98
* win: Fix a few minor issues found by clang.thakis@chromium.org2012-05-021-1/+1
| | | | | | | | | | | | No intended functionality change. BUG=82385 TEST=compiles Review URL: http://codereview.chromium.org/10332002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134988 0039d316-1c4b-4281-b951-d872f2087c98
* Make URLRequestThrottlerManager a member of URLRequestContext.joi@chromium.org2012-05-021-29/+39
| | | | | | | | | | | | | | This addresses a long-standing TODO and allows us to simplify the logic in the class a bit as it now lives fully on the IO thread. It should also allow further cleanup in follow-up changes e.g. to stop using scoped_refptr for the URLRequestThrottlerEntry instances. BUG=119760 Review URL: http://codereview.chromium.org/10203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134963 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 130578 - Enable cookies per default in net. Add an API to disable ↵jochen@chromium.org2012-04-301-1/+6
| | | | | | | | | | | | them by default, and do that in Chrome BUG=none TEST=existing tests shouldn't break Review URL: http://codereview.chromium.org/10178009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134524 0039d316-1c4b-4281-b951-d872f2087c98
* RefCounted types should not have public destructors, chrome/ editionrsleevi@chromium.org2012-04-2515-322/+368
| | | | | | | | | | BUG=123295 TEST=none Review URL: http://codereview.chromium.org/10065040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133927 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash if GetPrinterCapsAndDefaults returns after the calling printer ↵abodenha@chromium.org2012-04-132-3/+6
| | | | | | | | | | | | | | | | | is deleted. There was a crash when disconnecting from a machine via Windows RDP. RDP injects client machine printers into the host machine. GetPrinterCapsAndDefaults blocks on these printers. When the user disconnects, the printer is deleted and then GetPrinterCapsAndDefaults returns. The failure handler fires and attempts to access the now-freed PrinterJobHandler that was passed with the callback resulting in a crash. The solution is to pass a WeakPtr to the callback so that if the PrinterJobHandler is destroyed the callback wont fire. BUG=122996 TEST=Verify bug. Review URL: http://codereview.chromium.org/10079017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132283 0039d316-1c4b-4281-b951-d872f2087c98
* Modify the base::JSONReader interface to take a set of options rather than a ↵rsesek@chromium.org2012-04-111-3/+2
| | | | | | | | | | | | | | boolean flag. This is just prep work for a large CL that rewrites the JSON parser. Splitting out this interface change will make it easier to review the other CL. BUG=121469 TEST=No functional change. Review URL: https://chromiumcodereview.appspot.com/9960077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131680 0039d316-1c4b-4281-b951-d872f2087c98
* Stop processing in case of authentication errors.gene@chromium.org2012-04-051-3/+5
| | | | | | | | If recovering from auth error takes some significant time, it will reduce the number of wrong-auth requests. Review URL: http://codereview.chromium.org/9959111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131001 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TOOLKIT_USES_GTK and consolidate it into TOOLKIT_GTKoshima@chromium.org2012-04-051-2/+2
| | | | | | | | | | | Add gtk dependency to base.gyp for android host_os="linux" case BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9969080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130784 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 130578 - Enable cookies per default in net. Add an API to disable ↵jochen@chromium.org2012-04-041-6/+1
| | | | | | | | | | | | | | them by default, and do that in Chrome BUG=none TEST=existing tests shouldn't break Review URL: https://chromiumcodereview.appspot.com/9865018 TBR=jochen@chromium.org Review URL: https://chromiumcodereview.appspot.com/9956142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130581 0039d316-1c4b-4281-b951-d872f2087c98
* Enable cookies per default in net. Add an API to disable them by default, ↵jochen@chromium.org2012-04-041-1/+6
| | | | | | | | | | | and do that in Chrome BUG=none TEST=existing tests shouldn't break Review URL: https://chromiumcodereview.appspot.com/9865018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130578 0039d316-1c4b-4281-b951-d872f2087c98
* Driver related info would be included into PrinterBasicInfo::options so it ↵vitalybuka@chromium.org2012-03-221-27/+1
| | | | | | | | | | | would be uploaded to cloud print backend. BUG=118797 TEST=none Review URL: http://codereview.chromium.org/9812002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128141 0039d316-1c4b-4281-b951-d872f2087c98
* Make CertVerifier a pure virtual interface.rsleevi@chromium.org2012-03-211-1/+1
| | | | | | | | | | | | | The existing CertVerifier implementation has been renamed to MultiThreadedCertVerifier, consistent with ProxyResolver naming. This is patch 1 of N for http://crbug.com/114343 BUG=114343 TEST=Compiles and existing unittests pass. Review URL: https://chromiumcodereview.appspot.com/9476035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128090 0039d316-1c4b-4281-b951-d872f2087c98
* ScopedPrinterInfoSetter sets printer related information to be available for ↵vitalybuka@chromium.org2012-03-162-5/+37
| | | | | | | | | | | breakpad. This CL inserts ScopedPrinterInfoSetter in places where Cloud print accesses printers and crash is possible. BUG=108194 TEST=none Review URL: http://codereview.chromium.org/9693064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127131 0039d316-1c4b-4281-b951-d872f2087c98
* Update net/base/cookie_*.h includes to net/cookies/cookie_*.h .erikwright@chromium.org2012-03-152-4/+4
| | | | | | | | | | | | Once complete, forwarding headers will be removed from net/base/ . TEST=none R=willchan Review URL: http://codereview.chromium.org/9703062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126999 0039d316-1c4b-4281-b951-d872f2087c98
* Add Chrome To Mobile Service and Views Page Action.msw@chromium.org2012-03-137-177/+83
| | | | | | | | | | | | | | | | | | | | | Implements the Chrome To Mobile extension in Chrome. List the user's mobile devices via the Cloud Print server. Add a page action icon when the service reports 1+ devices. Add a bubble to send the current page URL / MHTML snapshot. The bubble shows a radio group for multiple devices. (or it shows a single device as part of the title label) The bubble also shows a checkbox to send an offline copy. Send URLFetcher requests to GET/POST the URL/Snapshot. The bubble shows "Sending..."/"Sent"/ error request status. BUG=102709 TEST=New Chrome To Mobile bubble works as expected :) Review URL: http://codereview.chromium.org/9443007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126343 0039d316-1c4b-4281-b951-d872f2087c98
* Do cookie checks in NetworkDelegate instead of the URLRequest::Delegate.jochen@chromium.org2012-03-091-1/+2
| | | | | | | | | | | As a side effect, requests going through URLFetcher now also have to pass cookie checks. Requests from the URLFetcher can be optionally annotated with a render view, so the user can be notified about blocked cookies. This plumbing is done for the alternate nav url fetcher, and the template url fetcher. BUG=116322 TEST=manual/pyauto Review URL: https://chromiumcodereview.appspot.com/9572001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125831 0039d316-1c4b-4281-b951-d872f2087c98
* Make Cloud Print job status upper case (as required by server).gene@chromium.org2012-03-092-10/+10
| | | | | | Review URL: http://codereview.chromium.org/9619031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125777 0039d316-1c4b-4281-b951-d872f2087c98
* Making GenericScopedHandle capable of handling handle types other than HANDLE.alexeypa@chromium.org2012-03-051-0/+13
| | | | | | Review URL: http://codereview.chromium.org/9582045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124980 0039d316-1c4b-4281-b951-d872f2087c98
* Move TestURLRequestContextGetter to url_request_test_util.{h,cc}akalin@chromium.org2012-03-021-19/+7
| | | | | | | | | | | Make everything use this instead of rolling their own. BUG=113723 TEST= Review URL: https://chromiumcodereview.appspot.com/9562037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124758 0039d316-1c4b-4281-b951-d872f2087c98
* Improved resource management by using ScopedPrinterHandle.vitalybuka@chromium.org2012-03-021-27/+29
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/9569029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124755 0039d316-1c4b-4281-b951-d872f2087c98
* Replace chrome/common/net/http_return.h with net/http/http_status_code.hakalin@chromium.org2012-02-273-9/+8
| | | | | | | | | | | | | Fill out all HTTP status codes from RFC 2616. Clean up sync deps. BUG=113723 TEST= Review URL: https://chromiumcodereview.appspot.com/9447046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123807 0039d316-1c4b-4281-b951-d872f2087c98
* Remove usage of a deprecated TestServer constructor.erikwright@chromium.org2012-02-221-5/+13
| | | | | | | | | | | | | | | | | | Hostname must now be explicitly specified (previously default was 127.0.0.1). See the following CL for further details: http://codereview.chromium.org/9369029/ A follow-up CL will remove the deprecated constructor: http://codereview.chromium.org/9431002/ BUG=114369 TEST=everything still compiles and passes Review URL: http://codereview.chromium.org/9372104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123099 0039d316-1c4b-4281-b951-d872f2087c98
* Flakiness cleanup: disable flaky tests under chrome/evan@chromium.org2012-02-151-3/+3
| | | | | | | | | BUG=84299,99469,90557,109292,38497,45243,84854,59785,59783,59784,100567,62777,60426 TBR=thakis Review URL: https://chromiumcodereview.appspot.com/9406017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122137 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 121840 - Make scoped dc objects smartercpu@chromium.org2012-02-141-15/+16
| | | | | | | | | | | | | | So we don't destroy the dc with gdi objects selected. Also remove implicit conversion to HDC. BUG=110113,113683 TEST=chrome runs, base unittests green. Review URL: https://chromiumcodereview.appspot.com/9212020 TBR=cpu@chromium.org Review URL: https://chromiumcodereview.appspot.com/9387027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121843 0039d316-1c4b-4281-b951-d872f2087c98
* Make scoped dc objects smartercpu@chromium.org2012-02-141-16/+15
| | | | | | | | | | | So we don't destroy the dc with gdi objects selected. Also remove implicit conversion to HDC. BUG=110113,113683 TEST=chrome runs, base unittests green. Review URL: https://chromiumcodereview.appspot.com/9212020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121840 0039d316-1c4b-4281-b951-d872f2087c98
* Convert use of int ms to TimeDelta in chrome/service files.tedvessenes@gmail.com2012-01-314-28/+29
| | | | | | | | | | | R=gene@chromium.org BUG=108171 TEST= Review URL: http://codereview.chromium.org/9230002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119952 0039d316-1c4b-4281-b951-d872f2087c98
* content: Modfiy ResourceBundle and content_shell to run with alternative pak ↵erg@chromium.org2012-01-281-1/+1
| | | | | | | | | | | | files. BUG=111326 R=jam TBR=sky,tony,ajwong,ananta Review URL: http://codereview.chromium.org/9232060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119566 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed printing gets cut-off issue for CloudPrint and Chrome.gene@chromium.org2012-01-283-26/+34
| | | | | | | | | | | | Background: Print output is rendering to metafile that is based on the screen DC. The metafile was scaled to 72/600 for Chrome printing and 96/600 for CloudPrint. When the resolution of the screen is low and print output is large, it is possible for metafile output to go outside of the boundaries and be cut-off the print out. Fix: This CL calculates scaling dynamically based on the printer and metafile sizes and revert scaling correspondingly in the browser/service for the actual printout. BUG=chromium-os:16088 TEST=Verify Chrome and CloudPrint printing is working fine. Lower screen resolution (to 800x600 for Chrome, for CloudPrint it is enough to lower to 1280x800). Run Chrome and enable CloudPrint support. Try printing files from the bug 16088. Review URL: http://codereview.chromium.org/9288081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119546 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove static storage for variables in an unnamed namespace.jhawkins@chromium.org2012-01-281-6/+7
| | | | | | | | | | BUG=none TEST=none R=binji Review URL: https://chromiumcodereview.appspot.com/9271061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119535 0039d316-1c4b-4281-b951-d872f2087c98
* Add OSSTATUS_LOG API.mark@chromium.org2012-01-271-12/+6
| | | | | | Review URL: https://chromiumcodereview.appspot.com/9235084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119511 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Content API around BrowserChildProcessHost, similar to what was done ↵jam@chromium.org2012-01-202-9/+0
| | | | | | | | | | | | with ChildProcessHost. Now classes like PluginProcessHost don't derive from it, but instead use composition. I've also moved the iterator class into its own file in the public directory. Since classes don't derive from BrowserChildProcessHost and so can't static_cast from it, I added a template helper that does this. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118415 Review URL: https://chromiumcodereview.appspot.com/9150017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118516 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 118415 - Add a Content API around BrowserChildProcessHost, similar to ↵jam@chromium.org2012-01-202-0/+9
| | | | | | | | | | | | | what was done with ChildProcessHost. Now classes like PluginProcessHost don't derive from it, but instead use composition. I've also moved the iterator class into its own file in the public directory. Since classes don't derive from BrowserChildProcessHost and so can't static_cast from it, I added a template helper that does this. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9150017 TBR=jam@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118420 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Content API around BrowserChildProcessHost, similar to what was done ↵jam@chromium.org2012-01-202-9/+0
| | | | | | | | | | | with ChildProcessHost. Now classes like PluginProcessHost don't derive from it, but instead use composition. I've also moved the iterator class into its own file in the public directory. Since classes don't derive from BrowserChildProcessHost and so can't static_cast from it, I added a template helper that does this. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9150017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118415 0039d316-1c4b-4281-b951-d872f2087c98
* Cloud Print Connector Policy, Service-side enforcement.scottbyer@chromium.org2012-01-145-10/+62
| | | | | | | | | | | | | | | | | | | Have the service process periodically launch the browser (if not connected to the browser already) with a command line switch that instructs the browser to check the policy, shut the service down if it's set, then quit. If the service is already connected to the browser, the launch is not done since the browser is already watching for policy changes and would immediately inform the service. BUG=98049 TEST=Launch the browser, sign into the cloud print connector, quit the browser, set the policy, wait a long time (8 hours) or relaunch the service process - the service process should end up disabled and shut itself down. Review URL: http://codereview.chromium.org/8905023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117732 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 117531 - Convert use of int ms to TimeDelta in files owned by ajwong.lambroslambrou@google.com2012-01-124-24/+23
| | | | | | | | | | | | | | R=ajwong@chromium.org BUG=108171 TEST= Review URL: http://codereview.chromium.org/9187023 TBR=tedvessenes@gmail.com Review URL: http://codereview.chromium.org/9187072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117539 0039d316-1c4b-4281-b951-d872f2087c98
* Convert use of int ms to TimeDelta in files owned by ajwong.tedvessenes@gmail.com2012-01-124-23/+24
| | | | | | | | | | | R=ajwong@chromium.org BUG=108171 TEST= Review URL: http://codereview.chromium.org/9187023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117531 0039d316-1c4b-4281-b951-d872f2087c98
* Remove task.h and finish base::Bind() migration.ajwong@chromium.org2012-01-063-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Over 341 CLs, in ~3 months, touching 3251 unique files! Top 5 most CLs: (121) jhawkins ( 45) dcheng ( 24) achuith ( 23) csilv ( 12) tfarina ( 12) groby ~1000 files touched: (918) jhawkins 100+ files touched: (486) ajwong (385) willchan (372) dcheng (126) csilv (123) fischman (112) sergeyu 49+ files touched: (65) tfarina (57) acolwell (52) adamk (49) tzik BUG=35223 TEST=existing Review URL: http://codereview.chromium.org/9114020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116748 0039d316-1c4b-4281-b951-d872f2087c98
* And now NewRunnableMethod(), you die.ajwong@chromium.org2012-01-041-5/+1
| | | | | | | | | | | Kill off NewRunnableMethod() and remove silly declarations of unused ScopedRunnableMethodFactory(s). BUG=none TEST=existing. Review URL: http://codereview.chromium.org/9034032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116250 0039d316-1c4b-4281-b951-d872f2087c98
* Remove PrefService::ScheduleSavePersistentPrefs and change ↵bauerb@chromium.org2011-12-271-1/+1
| | | | | | | | | | | | | SavePersistentPrefs calls to CommitPendingWrites. TBR=ncarter@chromium.org BUG=99306 TEST=none Review URL: http://codereview.chromium.org/8198007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115829 0039d316-1c4b-4281-b951-d872f2087c98
* Delete meabodenha@chromium.org2011-12-213-5/+9
| | | | | | | | | | | | | | Localize Google Cloud Print in strings. Change UI interaction points to reference connector instead of proxy. Fix strings for connector in options to be more clearly about the connector. BUG=107252,107592 TEST= Review URL: http://codereview.chromium.org/8936013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115396 0039d316-1c4b-4281-b951-d872f2087c98
* [Coverity] More pass by val to pass by const ref conversions.dbeam@chromium.org2011-12-213-4/+4
| | | | | | | | | | | R=groby@chromium.org CID=101879 CID=100226 Review URL: http://codereview.chromium.org/8965067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115342 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member variables.jhawkins@chromium.org2011-12-201-1/+2
| | | | | | | | | | | | | CID=100356,100360,100368,100373,100374,100562,101529,101530,101536,101541, 101542,101595,101630,101685,101687,101689,101776,101812,101813,101854, 101861,101862,101871,101883,101886,101887,102034 BUG=none TEST=none R=binji Review URL: http://codereview.chromium.org/8965054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115225 0039d316-1c4b-4281-b951-d872f2087c98