summaryrefslogtreecommitdiffstats
path: root/chrome/test/automation/browser_proxy.h
Commit message (Collapse)AuthorAgeFilesLines
* Remove all the unnused automation IPCs. These were used by UI tests that ↵jam@chromium.org2012-05-171-46/+0
| | | | | | | | | have been converted to browser_tests. BUG=121574 Review URL: https://chromiumcodereview.appspot.com/10388175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137593 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the keyboard access interactive ui_test use InProcessBrowserTest. ↵jam@chromium.org2012-05-161-9/+0
| | | | | | | | | Deflake the tests. BUG=121574, 62311, 62310 Review URL: https://chromiumcodereview.appspot.com/10389154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137365 0039d316-1c4b-4281-b951-d872f2087c98
* Add tests for the page visibility, position, and clip in the new view API. ↵brettw@chromium.org2012-01-051-0/+3
| | | | | | | | This adds some additional capabilities to the UI test framework to support navigating background tabs. Review URL: http://codereview.chromium.org/9034001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116507 0039d316-1c4b-4281-b951-d872f2087c98
* gtest / gmock shouldn't be in the shipping productthakis@chromium.org2011-11-221-2/+5
| | | | | | | | | | | | Remove dependencies from automation on testing libraries that pull in gtest / gmock directly or indirectly. Do this by pulling ASSERTs out of chrome code and putting them into test code instead. Also delete some unused code. BUG=none TEST=none Review URL: http://codereview.chromium.org/8584013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111187 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enabled the policy.PolicyTest.testBookmarkBarPolicy test.joaodasilva@chromium.org2011-10-211-2/+5
| | | | | | | | | | BUG=98918 TEST=policy.PolicyTest.testBookmarkBarPolicy passes Review URL: http://codereview.chromium.org/8233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106711 0039d316-1c4b-4281-b951-d872f2087c98
* Automation: fix chrome/browser dependency on chrome/test headers.phajdan.jr@chromium.org2011-06-021-6/+0
| | | | | | | | | | | | | | This change also fixes a duplication of declarations introduced by Chrome Frame. Also, this removes AutocompleteEditProxy and its only two callers; we now have coverage from browser and unit tests which are much more solid. BUG=60803 Review URL: http://codereview.chromium.org/7104029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87648 0039d316-1c4b-4281-b951-d872f2087c98
* Browser::Type cleanup.jianli@chromium.org2011-05-051-0/+4
| | | | | | | | | | BUG=None TEST=Existing tests R=ben@chromium.org,stevenjb@chromium.org,phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/6697032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84303 0039d316-1c4b-4281-b951-d872f2087c98
* Removing command_execution_timeout_ms in favor of action_max_timeout_ms.hnguyen@chromium.org2011-04-111-1/+2
| | | | | | | R=jcivelli@chromium.org,sky@chromium.org,phajdan.jr@chromium.org,nirnimesh@chromium.org Review URL: http://codereview.chromium.org/6685099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81164 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74118 - Remove wstring from RVH's run Javascript command.avi@chromium.org2011-02-081-4/+4
| | | | | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6312154 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6459002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74158 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from RVH's run Javascript command.avi@chromium.org2011-02-081-4/+4
| | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6312154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74118 0039d316-1c4b-4281-b951-d872f2087c98
* - Add ChromeOS login and lock screen automation hooks.dtu@chromium.org2011-02-011-1/+1
| | | | | | | | | | | | | | - Add AutomationProxy::SendJSONRequest that does not require a handle to a Browser/BrowserProxy. - Fix issue where AutomationProvider thinks it's never finished loading the login screen. - Not included: UI tests for login, since they should be PyAuto tests. - Not included: fix for Chrome quitting as a result of channel disconnect. BUG=chromium-os:11538 TEST=none Review URL: http://codereview.chromium.org/6320022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73327 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Fix some out of date comments.thestig@chromium.org2010-12-021-10/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5538001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67974 0039d316-1c4b-4281-b951-d872f2087c98
* Update a couple of out of date comments.thestig@chromium.org2010-11-301-6/+8
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5319001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67659 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Include browser.h -> ui/browser.h [Part 2].jhawkins@chromium.org2010-11-161-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5046002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66229 0039d316-1c4b-4281-b951-d872f2087c98
* Split out command IDs from chrome_dll_resource.h.evan@chromium.org2010-11-081-1/+1
| | | | | | | | | | | | The name of this file is a leftover from Windows. Split the command ids (which are used on all platforms) out, leaving just the Windows-specific resource IDs in the original file. TEST=compiles Review URL: http://codereview.chromium.org/4710001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65453 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Make WaitForTabCountToBecome automation call not Sleep.phajdan.jr@chromium.org2010-09-071-2/+1
| | | | | | | | | | | | Sleeping is an unreliable method to wait for things. Instead, we set up an observer. BUG=none TEST=none Review URL: http://codereview.chromium.org/3300011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58731 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58563 - GTTF: Make WaitForTabCountToBecome automation call not Sleep.gavinp@chromium.org2010-09-041-1/+2
| | | | | | | | | | | | | | | | | (unfortunately, Mac & Windows started failing tab perf tests on this change) Sleeping is an unreliable method to wait for things. Instead, we set up an observer. BUG=none TEST=none Review URL: http://codereview.chromium.org/3300011 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3344009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58566 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Make WaitForTabCountToBecome automation call not Sleep.phajdan.jr@chromium.org2010-09-031-2/+1
| | | | | | | | | | | | Sleeping is an unreliable method to wait for things. Instead, we set up an observer. BUG=none TEST=none Review URL: http://codereview.chromium.org/3300011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58563 0039d316-1c4b-4281-b951-d872f2087c98
* Make prefs use std::string for keys rather than wstrings.viettrungluu@chromium.org2010-08-111-4/+4
| | | | | | | | | | | Much remains to be converted. BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3076037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55660 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the page and app menus.pkasting@chromium.org2010-07-201-3/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3033007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52985 0039d316-1c4b-4281-b951-d872f2087c98
* Change a bunch of string types.estade@chromium.org2010-06-291-1/+1
| | | | | | | | | | | | | Started out just trying to change PrefService::GetString and ::SetString. This snowballed a little bit. Had to change a bunch of url strings in search_engines/ from wstring to string (some of them may be better off as GURLs, but UTF-8 is a step in the right direction, since that's what GURL uses internally, as well as externally via its setters/getters). TODO (later patch): things that ask for accepted languages should use std::string, not std::wstring. BUG=none TEST=try bots Review URL: http://codereview.chromium.org/2854015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51157 0039d316-1c4b-4281-b951-d872f2087c98
* Make new startup test use GetInitialLoadTimes for more accurate times.pathorn@chromium.org2010-06-171-1/+11
| | | | | | | | | | | | | This change modifies RunStartupTest to call GetInitialLoadTimes, if applicable, to print out additional statistics for each tab computed on the browser. Additionally, changes |test_cold| and |important| parameters to be enums instead of booleans to make tests more readable. BUG=44129 TEST=none Review URL: http://codereview.chromium.org/2714015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50075 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r46909: "Reland r46681: Use IPC to wait for download in DownloadTest."bauerb@chromium.org2010-05-111-3/+0
| | | | | | | | | | TBR=bauerb TEST=ui_tests on 10.6 and ChromiumOS should go green. BUG=43066 Review URL: http://codereview.chromium.org/1985014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46915 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r46681: Use IPC to wait for download in DownloadTest.bauerb@chromium.org2010-05-111-0/+3
| | | | | | | | | | | | | Add AutomationMsg_WaitForDownloadShelfVisibilityChange and use it in UITestBase for the download tests. This should decrease flakiness of download tests. TEST=DownloadTest.*, especially DownloadTest.[Dont]CloseNewTab* BUG=43066 Review URL: http://codereview.chromium.org/2051002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46909 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 46681 - Add AutomationMsg_WaitForDownloadShelfVisibilityChange and ↵bauerb@chromium.org2010-05-071-3/+0
| | | | | | | | | | | | | | | | use it in UITestBase for the download tests. This should decrease flakiness of download tests. TEST=DownloadTest.*, especially DownloadTest.[Dont]CloseNewTab* BUG=43066 Review URL: http://codereview.chromium.org/1933005 TBR=bauerb@chromium.org Review URL: http://codereview.chromium.org/2037003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46685 0039d316-1c4b-4281-b951-d872f2087c98
* Add AutomationMsg_WaitForDownloadShelfVisibilityChange and use it in ↵bauerb@chromium.org2010-05-071-0/+3
| | | | | | | | | | | | | UITestBase for the download tests. This should decrease flakiness of download tests. TEST=DownloadTest.*, especially DownloadTest.[Dont]CloseNewTab* BUG=43066 Review URL: http://codereview.chromium.org/1933005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46681 0039d316-1c4b-4281-b951-d872f2087c98
* Add generic "json dict" entry point for pyauto commands. Will preventjrg@chromium.org2010-04-021-0/+4
| | | | | | | | | | | | | | | | the need to modify the automation proxy anymore. New pyauto commands will only need to edit pyauto.py (to add a new SendJSONCommand() call) and browser_proxy.cc (to implement the other side). Contrast with the normal editing of ~8 files. Also added WaitForAllDownloadsToComplete using new JSON path. BUG=http://crbug.com/39274 Review URL: http://codereview.chromium.org/1547012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43436 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-311-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43216 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this CL to fix the interactive ui test failures.ananta@chromium.org2010-03-261-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert 42498 - Keyboard accessibility for the page and app menus. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1428001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42779 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-241-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42498 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42465 - Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-241-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reverting because newly added Test*MenuKeyboardAccess tests fail on some of the Windows buildbots, and possibly a XP Perf regression. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1257003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42468 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-241-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42465 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce number of automation methods ending with WithTimeout.phajdan.jr@chromium.org2010-03-221-39/+3
| | | | | | | | | | | | | | | | | | | | | They are just too easy to misuse. People started inventing their own hardcoded timeouts all over the place. Also, the is_timeout return parameter was not checked consistently. Additionally, some calls actually had no timeout at all, making hangs possible. This change also removes useless DLOG statements. We should get the required info from the ASSERT/EXPECT macros in test code, which is quite well checked by WARN_UNUSED_RESULT. TEST=all ui-based BUG=none Review URL: http://codereview.chromium.org/1076005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42213 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Make automation framework more solid by making sure thatphajdan.jr@chromium.org2010-03-161-42/+51
| | | | | | | | | | | | | | | | | | | important return values are not ignored. The macro used here, WARN_UNUSED_RESULT, takes effect only for GCC, but that's enough since we have bots for all platforms. Adding these warnings already detected some cases where a return value was ignored. In some of them the test was trying to get the information about success "some other way", in some it could sometimes confuse test failure with test success. TEST=ui_tests BUG=none Review URL: http://codereview.chromium.org/948002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41696 0039d316-1c4b-4281-b951-d872f2087c98
* Add pyauto hooks for bookmarks.jrg@chromium.org2010-03-121-0/+19
| | | | | | | | | | Get model, add/remove, add folder, reparent, change title/url. BUG=34492 Review URL: http://codereview.chromium.org/792003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41450 0039d316-1c4b-4281-b951-d872f2087c98
* Test cookie prompting.darin@chromium.org2010-03-041-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds automation plumbing to support changing the content settings. This change also fixes WaitForNavigation to watch for the LOAD_STOP event instead of the NAV_ENTRY_COMMITTED event. This better matches the intent (I think) of the automation interface, and it also matches the similar function defined in ui_test_utils (used by browser tests). This also better matches the NavigationNotificationObserver, which seems desirable given the implementation of AutomationProvider::WaitForNavigation. It turns out that only one UI test was using WaitForNavigation, and I confirmed that it still functions properly. This change also modifies the NavigationNotificationObserver to allow it to watch for the current page load to complete. Normally, it waits for the first LOAD_START or NAV_ENTRY_COMMITTED event to switch into the mode where it watches for LOAD_STOP. However, that makes it not so useful for WaitForNavigation, which is intended to be called after triggering the start of a new navigation. This change also makes it so that the cookie prompt supports the automation message box 'OK' and 'Cancel' buttons, so that we can remotely press those buttons. Leveraging all of these changes enables some basic cookie prompting tests to be written. I had to modify browser_frame_win.cc to ensure that BrowserList::SetLastActive is called even while running under remote desktop. R=phajdan.jr@chromium.org BUG=37182 TEST=cookie_modal_dialog_uitest.cc Review URL: http://codereview.chromium.org/661102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40575 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes flakiness in session restore test. I'm adding two things:sky@chromium.org2010-01-261-0/+4
| | | | | | | | | | | | | | | | . Make the newly created popup navigate to a url. Without this session restore won't restore the tab. . Before exiting manually shutdown the session service. Without this the windows are closed, which, depending upon timing, is treated as though the user closed the window so that session restore won't restore the window. BUG=32716 TEST=this is only a test fix Review URL: http://codereview.chromium.org/552134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37148 0039d316-1c4b-4281-b951-d872f2087c98
* Kiosk Mode implementation.mhm@chromium.org2009-11-091-0/+7
| | | | | | | | | | | | Kiosk mode will just hide the status bar and initially set it as full screen. Added some tests to add --kiosk mode as a command switch that tests if its in fullscreen state and doesn't have a status bubble. BUG=23145 TEST=Kiosk Mode functions and Run the ./ui_tests --gtest_filter=KioskModeTest.* Review URL: http://codereview.chromium.org/244003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31412 0039d316-1c4b-4281-b951-d872f2087c98
* Changes ui proxy classes to use Browser::Types rather than copyingsky@chromium.org2009-10-281-8/+2
| | | | | | | | | | them. BUG=none TEST=none Review URL: http://codereview.chromium.org/343018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30355 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at this. The only change between this and the first is to add the ↵sky@chromium.org2009-10-271-0/+11
| | | | | | | | | | | | | | | GetType message to the end of the list and to keep the old message for creating a new browser as well as adding one that takes the type. To change the params of the message requires updating the reference build. That's best done on a weekend when I'm bored. Makes session restore on Chrome OS restore popups. BUG=18862 TEST=none Review URL: http://codereview.chromium.org/329040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30255 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 30194 - Makes session restore on Chrome OS restore popups.sky@chromium.org2009-10-271-11/+0
| | | | | | | | | | | | BUG=18862 TEST=none Review URL: http://codereview.chromium.org/337030 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/335047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30204 0039d316-1c4b-4281-b951-d872f2087c98
* Makes session restore on Chrome OS restore popups.sky@chromium.org2009-10-271-0/+11
| | | | | | | | | BUG=18862 TEST=none Review URL: http://codereview.chromium.org/337030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30194 0039d316-1c4b-4281-b951-d872f2087c98
* Automated ui test porting + cleanup:estade@chromium.org2009-09-221-17/+10
| | | | | | | | | | | | | | | | - Change POINTs to gfx::Point - Get rid of 2 unused automation messages (the messages themselves are staying for now so we don't mess with the reference build) -- add new automation messages to replace GetWindowHWND, which is not portable - re-enable automated_ui_test_interactive_test (it seems to have been dropped when we converted to gyp) - compile additional tests on linux (they don't pass, so they are disabled) - stub out linux tab dragging automation implementation (browser side) - delete various cruft BUG=19758 Review URL: http://codereview.chromium.org/211033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26846 0039d316-1c4b-4281-b951-d872f2087c98
* Move download shelf from per-tab to per-window. Also disable auto-hiding ofthakis@chromium.org2009-06-041-0/+8
| | | | | | | | | | | | | | the shelf. BUG=9025 TEST=Download file in one tab, open new tab, and check that download shelf is still open. Also try the shelf's close button and the "show all downloads" link. When saving a file, the download animation should not show up. Review URL: http://codereview.chromium.org/115740 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17595 0039d316-1c4b-4281-b951-d872f2087c98
* Make automation proxy objects to ref_counted. That allows to process async ↵stoyan@chromium.org2009-05-281-6/+8
| | | | | | | | | | | notifications directly in channel background thread. Add support for listener-less ChannelProxy. BUG=none TEST=none Review URL: http://codereview.chromium.org/113722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17093 0039d316-1c4b-4281-b951-d872f2087c98
* Restore closed tabs into new windows when necessary, and track the windows theypam@chromium.org2009-04-221-1/+0
| | | | | | | | | | | | | | | | | | | came from so they're restored together (into the same new window) when appropriate. Fix safety check on tab index when restoring: make it check the correct browser. Change some ASSERTs to EXPECTs in the unit test for greater coverage. BUG=5278 TEST=Open a window with two tabs, close both (closing the window), then restore both. Make sure both restored tabs are in the same window. Open a window with multiple tabs, close a tab, then close the window using its close box. Restore both and make sure the tab goes back into the window. Review URL: http://codereview.chromium.org/92001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14234 0039d316-1c4b-4281-b951-d872f2087c98
* When restoring a closed tab using either ctrl-shift-T or the context menu, putpam@chromium.org2009-04-201-1/+1
| | | | | | | | | | | | | | | | | | | it back into the window it came from, at the tabstrip index it occupied before, and activate (select) both the window and the tab. Restoring a tab from the New Tab Page replaces the NTP, as before. If the window the tab was in no longer exists, put the tab at the end of the current window's tabstrip. This behavior may change in a later patch. BUG=5278 TEST=Open two windows, with >1 tabs each. Close a tab, not the one at the end, in one of the windows. Switch to the other window and choose "Undo Closed Tab" from the tabstrip context menu, or type ctrl-shift-T. The tab should be restored where it was, and activated (selected and brought to the front). Review URL: http://codereview.chromium.org/69015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14062 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate ApplyAccelerator and RunCommand codehuanr@chromium.org2009-04-161-0/+1
| | | | | | | | | | | | | | | | paths which do the same thing. - On browser side, remove AutomationMsg_ApplyAccelerator IPC message and ApplyAccelerator function in automation_provider. - On client side, let ApplyAccelerator simply call RunCommandAsync. With the change, converting all commands to synchronous mode should benefit both. Review URL: http://codereview.chromium.org/67152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13825 0039d316-1c4b-4281-b951-d872f2087c98
* Mechanic change based on comment from previous code review.huanr@chromium.org2009-03-311-2/+2
| | | | | | | | | Rename RunCommand to RunCommandAsync and RunCommandSync to RunCommand. Review URL: http://codereview.chromium.org/57039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12836 0039d316-1c4b-4281-b951-d872f2087c98