summaryrefslogtreecommitdiffstats
path: root/chrome/test/automation/tab_proxy.cc
Commit message (Collapse)AuthorAgeFilesLines
* Get rid of SavePackage usage in Chrome. I've moved IsSavableContents onto ↵jam@chromium.org2012-01-201-1/+1
| | | | | | | | | WebContents itself, IsSavableURL to a file in chrome, and made Chrome's DownloadManagerDelegate give SavePackage the file path through a callback. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9254051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118452 0039d316-1c4b-4281-b951-d872f2087c98
* Update Sleep() calls in chrome/test to use TimeDelta instead of ints.tedvessenes@gmail.com2012-01-041-3/+5
| | | | | | | | | | | R=phajdan.jr@chromium.org BUG=108171 TEST= Review URL: http://codereview.chromium.org/9066001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116376 0039d316-1c4b-4281-b951-d872f2087c98
* Have ChromeDriver return the correct error code for alerts.kkania@chromium.org2011-12-161-3/+4
| | | | | | | | | | | | Also, don't throw an alert error in set selected if the selection causes an alert. BUG=94959 TEST=none Review URL: http://codereview.chromium.org/8965008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114874 0039d316-1c4b-4281-b951-d872f2087c98
* Add commands to custom Chrome WebDriver for installing and manipulating ↵kkania@chromium.org2011-12-091-2/+3
| | | | | | | | | | | | extensions. BUG=93571 TEST=none Review URL: http://codereview.chromium.org/8806030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113726 0039d316-1c4b-4281-b951-d872f2087c98
* Update automation messages to use the new way of declaring message structs, ↵jam@chromium.org2011-10-211-2/+1
| | | | | | | | to cut back on unnecessary code. Review URL: http://codereview.chromium.org/8356020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106734 0039d316-1c4b-4281-b951-d872f2087c98
* Move SecurityStyle enum into content/public/common and put it into the ↵jam@chromium.org2011-10-211-1/+1
| | | | | | | | content namespace.BUG=98716 Review URL: http://codereview.chromium.org/8361019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106642 0039d316-1c4b-4281-b951-d872f2087c98
* Move the PageType enum to content/public/common, put it into the content ↵jam@chromium.org2011-10-181-1/+1
| | | | | | | | | | namespace, and also make it conform to the Content API enum naming convention. BUG=98716 TBR=ananta Review URL: http://codereview.chromium.org/8336013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106076 0039d316-1c4b-4281-b951-d872f2087c98
* Move json_value_serializer from content/common to base.dpranke@chromium.org2011-10-071-1/+1
| | | | | | | | | | R=darin@chromium.org BUG=92044 TEST= Review URL: http://codereview.chromium.org/8165009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104527 0039d316-1c4b-4281-b951-d872f2087c98
* For the SSL cert status, convert anonymous enum that gives bit values into a ↵pkasting@chromium.org2011-09-231-1/+1
| | | | | | | | | | | | | | typedefed uint32. This allows code all over Chromium to use an explicit type instead of "int". This also means the individual named bit constants themselves have the same explicit type. I find the resulting code to be noticeably clearer. This also exposed a bug in SSLErrorInfo::GetErrorsForCertStatus() where not having an explicit type allowed a function argument ordering bug to creep in, so I claim this is safer too. Normally this makes things like DCHECK_EQ() unhappy, but when I'd originally tested this I didn't seem to need to make any changes due to that. Will be watching the trybots... The original motiviation for this change was to find a way to eliminate some cases of passing anonymous-typed values as template arguments (which happens when you use a value from the enum in e.g. EXPECT_EQ()), which is technically illegal in C++03, though we don't warn about it. Simply naming the enum would have done this, but this would have encouraged readers to actually use the enum name as a type, which for a bitfield is inappropriate for the reason given in the first paragraph. BUG=92247 TEST=Compiles Review URL: http://codereview.chromium.org/7969023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102415 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 102322 - For the SSL cert status, convert anonymous enum that gives ↵pkasting@chromium.org2011-09-221-1/+1
| | | | | | | | | | | | | | | | | | | bit values into a typedefed uint32. This allows code all over Chromium to use an explicit type instead of "int". (This isn't possible by simply naming the enum as technically the enum doesn't define all of the possible combinations of bits.) This also means the individual named bit constants themselves have the same explicit type. I find the resulting code to be noticeably clearer. This also exposed a bug in SSLErrorInfo::GetErrorsForCertStatus() where not having an explicit type allowed a function argument ordering bug to creep in, so I claim this is safer too. I also added CERT_STATUS_NO_ERROR in place of "0" as a magic number. Normally this makes things like DCHECK_EQ() unhappy, but when I'd originally tested this I didn't seem to need to make any changes due to that. Will be watching the trybots... The original motiviation for this change was to find a way to eliminate some cases of passing anonymous-typed values as template arguments (which happens when you use a value from the enum in e.g. EXPECT_EQ()), which is technically illegal in C++03, though we don't warn about it. Simply naming the enum would have done this, but this would have encouraged readers to actually use the enum name as a type, which for a bitfield is inappropriate for the reason given in the first paragraph. BUG=92247 TEST=Compiles Review URL: http://codereview.chromium.org/7819009 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/7995014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102325 0039d316-1c4b-4281-b951-d872f2087c98
* For the SSL cert status, convert anonymous enum that gives bit values into a ↵pkasting@chromium.org2011-09-221-1/+1
| | | | | | | | | | | | | | | | typedefed uint32. This allows code all over Chromium to use an explicit type instead of "int". (This isn't possible by simply naming the enum as technically the enum doesn't define all of the possible combinations of bits.) This also means the individual named bit constants themselves have the same explicit type. I find the resulting code to be noticeably clearer. This also exposed a bug in SSLErrorInfo::GetErrorsForCertStatus() where not having an explicit type allowed a function argument ordering bug to creep in, so I claim this is safer too. I also added CERT_STATUS_NO_ERROR in place of "0" as a magic number. Normally this makes things like DCHECK_EQ() unhappy, but when I'd originally tested this I didn't seem to need to make any changes due to that. Will be watching the trybots... The original motiviation for this change was to find a way to eliminate some cases of passing anonymous-typed values as template arguments (which happens when you use a value from the enum in e.g. EXPECT_EQ()), which is technically illegal in C++03, though we don't warn about it. Simply naming the enum would have done this, but this would have encouraged readers to actually use the enum name as a type, which for a bitfield is inappropriate for the reason given in the first paragraph. BUG=92247 TEST=Compiles Review URL: http://codereview.chromium.org/7819009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102322 0039d316-1c4b-4281-b951-d872f2087c98
* Removed leak in tests.dilmah@chromium.org2011-09-161-31/+16
| | | | | | | | | BUG=None TEST=Manual Review URL: http://codereview.chromium.org/7908003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101502 0039d316-1c4b-4281-b951-d872f2087c98
* Preliminary work to allow Chrome to build with USE_AURA.ben@chromium.org2011-09-061-1/+1
| | | | | | | | | | This gets browser.lib to build. http://crbug.com/93947 TEST=none Review URL: http://codereview.chromium.org/7834048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99787 0039d316-1c4b-4281-b951-d872f2087c98
* Revert recent changes to base::Valuestevenjb@google.com2011-08-261-6/+6
| | | | | | | | | | | | | | | | | | Reverts: 98223: base: Add AsList() function to Value API. 98266: base: Add AsBinary() function to Value API. There are two issues with these commits: 1. libcros uses base::Value to pass data to Chrome. It includes values.h from libchrome which contains its own copy. This is a terrible design flaw in libcros and is being addressed (http://crosbug.com/19576), however we need some time to address this before we can make these changes without breaking Chrome on ChromeOS. 2. AsList() and AsBinary() should be const. The fact that they were not const caused re-factoring that changed const Value& input arguments to Value*, which is against the spec. When we re-introduce this, these members should be made const. BUG=chromium-os:19604 TEST=Check bots + ChromeOS autotests Review URL: http://codereview.chromium.org/7753020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98378 0039d316-1c4b-4281-b951-d872f2087c98
* base: Add AsList() function to Value API.tfarina@chromium.org2011-08-251-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | This function should simplify some constructions. Instead of: if (!value->IsType(Value::TYPE_LIST)) return false; ListValue* list_value = static_cast<ListValue*>(value); You can do: ListValue* list_value = value->AsList(); if (!list_value) return false; BUG=None TEST=base_unittests --gtest_filter=Values* R=evan@chromium.org,tony@chromium.org Review URL: http://codereview.chromium.org/7714004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98223 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor error handling in chromedriver. Introduce new error class ↵kkania@chromium.org2011-05-201-2/+3
| | | | | | | | | | | | containing a webdriver error code, possible error details, and a stack trace. Also some minor cleanup of the command files. BUG=none TEST=none Review URL: http://codereview.chromium.org/7042018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86081 0039d316-1c4b-4281-b951-d872f2087c98
* Move json_value_serializer to content\common since it's used by code in ↵jam@chromium.org2011-04-161-1/+1
| | | | | | | | | content now. TBR=avi Review URL: http://codereview.chromium.org/6875018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81857 0039d316-1c4b-4281-b951-d872f2087c98
* Remove extension automation support that was used only by CEEE.joi@chromium.org2011-04-061-9/+0
| | | | | | | | | BUG=none TEST=all automated tests pass Review URL: http://codereview.chromium.org/6756044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80626 0039d316-1c4b-4281-b951-d872f2087c98
* Send screenshots back to the client for debiggingjmikhail@google.com2011-03-291-4/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5572001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79721 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the reliability tests to run more than on URL in JS stress modesgjesse@google.com2011-02-221-1/+1
| | | | | | | | | | | | There was i bug in the reliability tests where passing --stress-opt or --stress-deopt would cause the loading of the second URL from the list passed with the --list argument did not wotk. This was not an issur for the reliability test runner as it currently only loads one URL in each test when running in JS stress mode. Also changed the JS stress message to be a control message. BUG=none TEST=none Review URL: http://codereview.chromium.org/6538078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75576 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the target locator commands for ChromeDriver.kkania@chromium.org2011-02-171-0/+24
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6507015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75279 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74118 - Remove wstring from RVH's run Javascript command.avi@chromium.org2011-02-081-16/+18
| | | | | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6312154 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6459002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74158 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from RVH's run Javascript command.avi@chromium.org2011-02-081-18/+16
| | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6312154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74118 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup:pkasting@chromium.org2011-02-081-4/+4
| | | | | | | | | | | | | | | | | | | | | | * Change int to size_t in a few APIs. * Rename infobar_delegate_count() to infobar_count() in preparation for TabContents owning InfoBars rather than InfoBarDelegates. * Move some code from PluginInstallerInfoBarDelegate to PluginObserver since it's more related to who's instantiating the infobar(delegate)s. * Unify InfoBarDelegate behavior by making no delegates auto-add themselves to tabs (callers now all do this explicitly). * Eliminate unused member TabContentsSSLHelper::SSLAddCertData::handler_. * De-inline a couple classes. * Make more functions private. * Add some consts. * Change DCHECK() to DCHECK_EQ() where possible. * Rename the delegates in plugin_observer.cc to have "Delegate" in the names. * Remove unnecessary qualifiers. * Simplify. * Misc. style issues, naming issues, etc. BUG=none TEST=none Review URL: http://codereview.chromium.org/6250172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74086 0039d316-1c4b-4281-b951-d872f2087c98
* Couple of changes in hopes of finally making ShareProcessesOnRestoresky@chromium.org2011-01-311-1/+4
| | | | | | | | | | | | | | | | | | | | | | | not flakey. Here's the set of changes: . Before getting the process count we wait for the PROCESS_LAUNCHER thread to go idle. On linux we push process shutdown to the PROCESS_LAUNCHER thread. So, it's important we wait for this thread to process all requests before getting the process count. . Makes TabRestore take a boolean indicating if it succeeded. . Change IDC_NEW_TAB from waiting for INITIAL_NEW_TAB_UI_LOAD to waiting until the tab loads. INITIAL_NEW_TAB_UI_LOAD isn't really a good indication that the new tab has finished loading. A key part of making this test not flakey is http://codereview.chromium.org/6398005/, but that'll be landed separately. BUG=52022 TEST=none Review URL: http://codereview.chromium.org/6263018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73156 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete base/lock.h and fix up callers to use the new header file andbrettw@chromium.org2011-01-211-4/+4
| | | | | | | | | | | the base namespace. Fix several files including lock.h unnecessarily. BUG=none TEST=none Original review=http://codereview.chromium.org/6142009/ Patch by leviw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72106 0039d316-1c4b-4281-b951-d872f2087c98
* Add options to enable stressing of the V8 crankshaft optimizations when ↵sgjesse@google.com2011-01-101-0/+8
| | | | | | | | | | | | | | | | | | | running reliability tests To do stress testing V8 crankshaft optimizations the same JavaScript code needs to be run a number of times first without optimizations and then with different levels of optimizations. V8 has a stress test API which can provide information on how many times to run the same code and set the optimization level for each run. This change adds an automation message to tell the V8 instance in the renderer: * which type of stress test to conduct * the number of times the page is loaded. The two options --stress-opt and --stress-deopt have been added the reliability test runner. When one of these options is used the reliability test runner will load each page several times and notify the render using the new automation messages. BUG=none TEST=none Review URL: http://codereview.chromium.org/5594008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70877 0039d316-1c4b-4281-b951-d872f2087c98
* Move platform_thread to base/threading and put in the base namespace. I left abrettw@chromium.org2010-12-311-2/+3
| | | | | | | | | | | stub and "using" declarations in the old location to avoid having to change the entire project at once. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6001010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70342 0039d316-1c4b-4281-b951-d872f2087c98
* Make IPC::Channel::Listener:OnMessageReceived have a return value indicating ↵jam@chromium.org2010-12-241-1/+2
| | | | | | | | | whether a message was processed or not. TBR=brettw Review URL: http://codereview.chromium.org/5978003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70139 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up Automation and Chrome Frame IPC code.-only use routed messages when ↵jam@chromium.org2010-12-231-71/+62
| | | | | | | | needed-use routing IDs to avoid manually unpacking messages-remove data structures from IPC namespace (that should only be used for IPC code, and param traits)Note that I temporarily commented out part of a test in external_tab_test.cc because I couldn't figure out how to get the updated gmock macros to compile. Review URL: http://codereview.chromium.org/5998006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70105 0039d316-1c4b-4281-b951-d872f2087c98
* ipc: Simplify the magic required to create IPC message headers.This gets rid ↵jam@chromium.org2010-12-081-14/+0
| | | | | | | | | of having to include the files in a magic place because of xcode dependency issues, and just makes it simpler to create new IPC message classes. It also gets rid of including the X_messages_internal.h file multiple times, which simplifies things and should make the build a little faster. In a future change, I will remove the "internal.h" files since they're no longer needed. Review URL: http://codereview.chromium.org/5526008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68664 0039d316-1c4b-4281-b951-d872f2087c98
* Add tab proxy call for taking a snapshot of the entire page.kkania@chromium.org2010-11-121-0/+10
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3358019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65999 0039d316-1c4b-4281-b951-d872f2087c98
* Part 3 of reapplying r64637.erg@google.com2010-11-121-1/+1
| | | | | | | | | | | | | This moves SecurityStyle and PageType into chrome/common/ and removes the chrome_frame dependency on chrome/browser/tab_contents/. This undoes the temporary DEPS hack on chrome/common/. BUG=51409 TEST=compiles Review URL: http://codereview.chromium.org/4697005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65965 0039d316-1c4b-4281-b951-d872f2087c98
* Part 2 of reapplying r64637.erg@google.com2010-11-101-2/+1
| | | | | | | | | | | | | Move the automation message files from chrome/test/automation to chrome/common/. This requires a temporary override to chrome/common/DEPS until Part 3 lands. BUG=51409 TEST=compiles Review URL: http://codereview.chromium.org/4758001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65695 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor automation messages." due to mysterious problems on mac.erg@google.com2010-11-011-2/+3
| | | | | | | | | | | | | This reverts commit c1c1fed998ee4d839bfe256150e5e59220ebc0ef (r64637). TBR=nirnimesh@ BUG=51409 TEST=none Review URL: http://codereview.chromium.org/4194007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64644 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor automation messages.erg@google.com2010-11-011-3/+2
| | | | | | | | | | | | | | | | | automation_messages used to live in chrome/test/automation, when it's needed by browser and chrome_frame. When I started lifting code out of headers and into implementation files, I was getting link errors and temporarily solved the problem by compiling the cc files manually into libbrowser.a. Now this is part of chrome/common/ which is included by all targets needed. While doing this, discover that automation IPC redefines the ContextMenuParams struct. Rename it to MiniContextMenuParams. BUG=51409 TEST=none Review URL: http://codereview.chromium.org/4200007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64637 0039d316-1c4b-4281-b951-d872f2087c98
* Add UI test for click-to-play.bauerb@chromium.org2010-10-251-0/+9
| | | | | | | | | BUG=57277 TEST=NPAPIVisiblePluginTester.ClickToPlay:ClickToPlayPluginTest.* Review URL: http://codereview.chromium.org/3539002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63722 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Even more ctor/virtual deinlining.erg@google.com2010-10-191-0/+9
| | | | | | | | | | | (Only 424k off Linux debug .a files). BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3859003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63059 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Make WaitForInfoBarCount not Sleep.phajdan.jr@chromium.org2010-09-081-11/+7
| | | | | | | | | | | Use an observer instead, to wait more reliably. BUG=none TEST=none Review URL: http://codereview.chromium.org/3344006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58880 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated wstring Get(As)String() methods from Value, etc.viettrungluu@chromium.org2010-08-161-2/+4
| | | | | | | | | BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3117017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56187 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r52486. Display a tab modal dialog of the allowed/blocked cookies.jochen@chromium.org2010-07-161-0/+6
| | | | | | | | | BUG=45230 TEST=CollectedCookiesTest.* Review URL: http://codereview.chromium.org/3034007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52655 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52486 - Display a tab modal dialog of the allowed/blocked cookies.dmaclach@chromium.org2010-07-151-6/+0
| | | | | | | | | | | | BUG=45230 TEST=CollectedCookiesTest.* Review URL: http://codereview.chromium.org/2907003 TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/3016003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52505 0039d316-1c4b-4281-b951-d872f2087c98
* Display a tab modal dialog of the allowed/blocked cookies.jochen@chromium.org2010-07-151-0/+6
| | | | | | | | | BUG=45230 TEST=CollectedCookiesTest.* Review URL: http://codereview.chromium.org/2907003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52486 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up external-tab related code in automation provider and automation proxy.estade@chromium.org2010-06-101-36/+36
| | | | | | | | | BUG=44695 TEST=compile Review URL: http://codereview.chromium.org/2743006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49448 0039d316-1c4b-4281-b951-d872f2087c98
* Rename "mixed content" to "insecure content" in as many places as possible, ↵pkasting@chromium.org2010-05-181-4/+4
| | | | | | | | | | to standardize on a consistent naming scheme. BUG=none TEST=none Review URL: http://codereview.chromium.org/2069005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47531 0039d316-1c4b-4281-b951-d872f2087c98
* Add delete cookie option to Automation Proxyjmikhail@google.com2010-04-211-0/+7
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45256 0039d316-1c4b-4281-b951-d872f2087c98
* Close a newly opened (by cmd-clicking on a link) tab if it resulted in a ↵bauerb@chromium.org2010-04-211-1/+19
| | | | | | | | | | | | | | | | download. To test this, the CL adds an automation message AutomationMsg_NavigateAsyncWithDisposition, and a method NavigateToURLAsyncWithDisposition to TabProxy. The only functional change is in TabContents::OnStartDownload, the rest of the changes is for testing. BUG=10764 TEST=DownloadTest.CloseNewTab Manual test: go to http://build.chromium.org/buildbot/continuous/mac/LATEST/, open the link "chrome-mac.zip" in a new tab. The tab should close as soon as the download starts. Review URL: http://codereview.chromium.org/1151007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45158 0039d316-1c4b-4281-b951-d872f2087c98
* Context menu operations like Cut/Copy/Paste etc would not work in pages ↵ananta@chromium.org2010-04-191-2/+3
| | | | | | | | | | | | | | | | | | | rendered by ChromeFrame. The context menu is displayed by the ChromeFrame plugin which grabs focus to ensure that the menu has focus, and then restores focus back once we select an item. The latter step sends over a notification to Chrome via an automation message which then informs the view. This resets the webview item selection which results in this bug. Fix is to send over an additional flag to Chrome in the SetInitialFocus which indicates whether we need to inform the view about the focus change or not. Fixes bug http://code.google.com/p/chromium/issues/detail?id=41523 Bug=41523 Review URL: http://codereview.chromium.org/1574033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44951 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to manipulate DOM elements from the automation proxy. Rework the ↵kkania@chromium.org2010-04-161-0/+32
| | | | | | | | | | way that javascript is packaged and parsed in the JavascriptExecutionController, and add some waiting methods. BUG=none TEST=none Review URL: http://codereview.chromium.org/1632001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44778 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from using std::min to std::max to fix an obvious bug in tab_proxy.brettw@chromium.org2010-04-141-7/+11
| | | | | | | | | | | | | Using std::min in these cases limits the loops to only 0 or 1 iteration, so the loops were never waiting for the given timeout before returning an error. BUG=none TEST=Tests which were passing before should continue to pass, some flaky ones may start working because we are waiting for the correct timeout now. Patch by satish@chromium.org Original review: http://codereview.chromium.org/1530034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44553 0039d316-1c4b-4281-b951-d872f2087c98