summaryrefslogtreecommitdiffstats
path: root/chrome/test/automation
Commit message (Collapse)AuthorAgeFilesLines
* Implement the webdriver window sizing commands.kkania@chromium.org2012-01-282-0/+30
| | | | | | | | | | BUG=107630 TEST=none Review URL: http://codereview.chromium.org/9288051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119555 0039d316-1c4b-4281-b951-d872f2087c98
* Remove UNIMPLEMENTED in TerminateSession for Aura.mukai@chromium.org2012-01-211-1/+1
| | | | | | | | | | | | | This is only meaningful in (non-Aura) Windows to send the WM_ENDSESSION to the native window. Aura does not need to do such task here. BUG=99706 TEST= Review URL: http://codereview.chromium.org/9254024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118625 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of SavePackage usage in Chrome. I've moved IsSavableContents onto ↵jam@chromium.org2012-01-202-3/+4
| | | | | | | | | WebContents itself, IsSavableURL to a file in chrome, and made Chrome's DownloadManagerDelegate give SavePackage the file path through a callback. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9254051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118452 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 117964 - UILayoutTest: Use DOMAutomation to retrieve ↵apatrick@chromium.org2012-01-182-7/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | document.body.innerText Also enable some tests that can run now. We currently store innerText in a cookie and then read the cookie. So we can only run tests whose output is < 4096 bytes. This change removes that limitation. BUG=33472 TEST= Trying to diagnose this test failure on windows. Will reland if this patch is not the cause. http://chromegw.corp.google.com/i/chromium/builders/XP%20Tests%20%28dbg%29%282%29/builds/13488 WorkerFileSystemTest.FileWriterSyncWriteOverlapped: [2960:2576:0117/155221:2999875:INFO:ui_layout_test.cc(57)] Assume LayoutTests in e:\b\build\slave\XP_Tests__dbg__2_\build\src\chrome\test\data\layout_tests\LayoutTests [2960:2576:0117/155221:2999890:INFO:ui_layout_test.cc(143)] Assume LayoutTests in fast\filesystem [2960:2576:0117/155221:3000093:INFO:ui_layout_test.cc(143)] Assume LayoutTests in fast\js .\test\ui\ui_test.cc(720): error: Failed Timeout reached in WaitUntilCookieNonEmpty Google Test trace: .\test\ui\ui_layout_test.cc(174): file-writer-sync-write-overlapped.html .\test\ui\ui_layout_test.cc(254): error: Value of: inner_text.c_str() Actual: "[Worker] Test using FileWriterSync.seek to write overlapping existing data in a file. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". Starting worker: ../resources/file-writer-sync-write-overlapped.js " Expected: expected_result_value.c_str() Which is: "[Worker] Test using FileWriterSync.seek to write overlapping existing data in a file. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". Starting worker: ../resources/file-writer-sync-write-overlapped.js PASS [Worker] Overlapped write 1 verified. PASS [Worker] Overlapped write 2 verified. PASS [Worker] Overlapped write 3 verified. PASS successfullyParsed is true TEST COMPLETE " Google Test trace: .\test\ui\ui_layout_test.cc(174): file-writer-sync-write-overlapped.html The theory is that the test is timing out waiting for a cookie and this patch modified how cookies and tests work. Review URL: http://codereview.chromium.org/9127021 TBR=dgrogan@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118015 0039d316-1c4b-4281-b951-d872f2087c98
* UILayoutTest: Use DOMAutomation to retrieve document.body.innerTextdgrogan@chromium.org2012-01-172-2/+7
| | | | | | | | | | | | | | | | Also enable some tests that can run now. We currently store innerText in a cookie and then read the cookie. So we can only run tests whose output is < 4096 bytes. This change removes that limitation. BUG=33472 TEST= Review URL: http://codereview.chromium.org/9127021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117964 0039d316-1c4b-4281-b951-d872f2087c98
* Change chromedriver to use the current session key modifier state whenkkania@chromium.org2012-01-102-14/+75
| | | | | | | | | | | processing mouse events. BUG=109029 TEST=none Review URL: http://codereview.chromium.org/9030034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116966 0039d316-1c4b-4281-b951-d872f2087c98
* Mark AutomationProxyTest.AcceleratorExtensions flaky on Macbinji@chromium.org2012-01-091-1/+7
| | | | | | | | | | | TBR=phajdan.jr@chromium.org BUG=109642 TEST=AutomationProxyTest.AcceleratorExtensions Review URL: http://codereview.chromium.org/9151008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116925 0039d316-1c4b-4281-b951-d872f2087c98
* Add tests for the page visibility, position, and clip in the new view API. ↵brettw@chromium.org2012-01-052-0/+14
| | | | | | | | This adds some additional capabilities to the UI test framework to support navigating background tabs. Review URL: http://codereview.chromium.org/9034001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116507 0039d316-1c4b-4281-b951-d872f2087c98
* Update Sleep() calls in chrome/test to use TimeDelta instead of ints.tedvessenes@gmail.com2012-01-044-10/+14
| | | | | | | | | | | R=phajdan.jr@chromium.org BUG=108171 TEST= Review URL: http://codereview.chromium.org/9066001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116376 0039d316-1c4b-4281-b951-d872f2087c98
* Create a Content API interface around NavigationController, and move all the ↵jam@chromium.org2011-12-291-0/+1
| | | | | | | | | | methods used by chrome code to it. BUG=98716 TBR=brettw Review URL: http://codereview.chromium.org/8989071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115946 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ui::EventFlags mouse flags to be more sensibledhollowa@chromium.org2011-12-201-1/+1
| | | | | | | | | | | | | | | | Changes EF_(LEFT|MIDDLE|RIGHT)_BUTTON_DOWN to EF_(LEF|MIDDLE|RIGHT)_MOUSE_BUTTON since these are not specific to "down" button events. This is follow up from review http://codereview.chromium.org/8953037 BUG=none TEST=Compiles. R=ben@chromium.org Review URL: http://codereview.chromium.org/9007016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115188 0039d316-1c4b-4281-b951-d872f2087c98
* Make ui_tests fail faster if all tests fail.thakis@chromium.org2011-12-193-1/+16
| | | | | | | | | | | | | | | | | | UITest::CreateProxyLauncher() creates a proxy launcher that severes the IPC connection to the browser process on AutomationProxy::Send(). If a bug makes the browser misbehave on startup, the IPC connection is dropped immediately, which means that ProxyLauncher::WaitForBrowserProcessToQuit() will always timeout. Fix this by assuming that waiting for shutdown will always fail if the IPC connection was prematurely dropped. BUG=106517 TEST=Change a test to timeout. The runner now takes 2*action_timeout (90s) instead 3*action_timeout (135s) to realize that. Review URL: http://codereview.chromium.org/8907004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115017 0039d316-1c4b-4281-b951-d872f2087c98
* Have ChromeDriver return the correct error code for alerts.kkania@chromium.org2011-12-163-137/+145
| | | | | | | | | | | | Also, don't throw an alert error in set selected if the selection causes an alert. BUG=94959 TEST=none Review URL: http://codereview.chromium.org/8965008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114874 0039d316-1c4b-4281-b951-d872f2087c98
* Don't include too much info in chromedriver errors.kkania@chromium.org2011-12-141-7/+4
| | | | | | | | | | | | | Drops the stacktrace and automation request details. The stacktrace confuses users and symbols aren't present on official linux builds anymore. BUG=none TEST=none Review URL: http://codereview.chromium.org/8918015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114359 0039d316-1c4b-4281-b951-d872f2087c98
* Change chromedriver to set geolocation/notification content setting defaults ↵kkania@chromium.org2011-12-122-0/+43
| | | | | | | | | | | | | to allow. Also disable cert revocation checking. These changes can be overruled by setting the noWebsiteTestingDefaults capability. BUG=none TEST=none Review URL: http://codereview.chromium.org/8890026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114026 0039d316-1c4b-4281-b951-d872f2087c98
* Add commands to custom Chrome WebDriver for installing and manipulating ↵kkania@chromium.org2011-12-093-193/+472
| | | | | | | | | | | | extensions. BUG=93571 TEST=none Review URL: http://codereview.chromium.org/8806030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113726 0039d316-1c4b-4281-b951-d872f2087c98
* Move the ProcessType enum out to its own file. This is in preparation for ↵jam@chromium.org2011-12-011-2/+2
| | | | | | | | | getting rid of ChildProcessInfo. BUG=98716 Review URL: http://codereview.chromium.org/8760011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112353 0039d316-1c4b-4281-b951-d872f2087c98
* Allow chromedriver to install an extension and get all installed extension IDs.kkania@chromium.org2011-11-292-0/+56
| | | | | | | | | | | Fix install extension hook to only watch for internal extension install. BUG=103033,93571 TEST=none Review URL: http://codereview.chromium.org/8649004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111927 0039d316-1c4b-4281-b951-d872f2087c98
* Implement ui_controls for auraoshima@chromium.org2011-11-221-1/+1
| | | | | | | | | | | | | | | | | | | | - Move windows impl to ui_controls_internal_win.cc so that aurawin can use it. - For windows, we can simply adjust coordinates, so ConvertPointToNativeScreen is added. - Aurax11 uses PostNativeEvent to send event. I changed XPutBackEvent to XSendEvent as PutBackEvent puts the event at the top. - Aurax11 uses synthesized flash event to run "run-after-events" task. - exclude events_x.cc from gtk build as it's not necessary. BUG=103497, 104396 TEST=following tests now passes on aura PrintDialogCloudTest.HandlersRegistered (browser tests) several tests in interactive_ui_tests (MenuModelAdapterTest,MenuItemViewTestInsert00) now passes. I'll post the list in the bug. Review URL: http://codereview.chromium.org/8585015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111219 0039d316-1c4b-4281-b951-d872f2087c98
* gtest / gmock shouldn't be in the shipping productthakis@chromium.org2011-11-2210-167/+128
| | | | | | | | | | | | Remove dependencies from automation on testing libraries that pull in gtest / gmock directly or indirectly. Do this by pulling ASSERTs out of chrome code and putting them into test code instead. Also delete some unused code. BUG=none TEST=none Review URL: http://codereview.chromium.org/8584013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111187 0039d316-1c4b-4281-b951-d872f2087c98
* Allow proxy channels to be created without initializing the underlying channel.kkania@chromium.org2011-11-161-14/+13
| | | | | | | | | | | | | | This fixes a bug where a client needed to guarantee a message filter was in place before any messages were received. It also follows the style of not having constructors that do complex initialization. BUG=102894 TEST=none Review URL: http://codereview.chromium.org/8417054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110229 0039d316-1c4b-4281-b951-d872f2087c98
* Remove CRLF in automation_proxy.cc, which is preventing my try job fromkkania@chromium.org2011-11-151-2/+2
| | | | | | | | | | | working. BUG=none TEST=none TBR=hnguyen Review URL: http://codereview.chromium.org/8565038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110106 0039d316-1c4b-4281-b951-d872f2087c98
* views: Remove the old views/window/ directory and its stubbed files.tfarina@chromium.org2011-11-141-1/+1
| | | | | | | | | BUG=104039 R=ben@chromium.org Review URL: http://codereview.chromium.org/8497067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109887 0039d316-1c4b-4281-b951-d872f2087c98
* share all the needed linux code with OpenBSD in chrome and contentrobert.nagy@gmail.com2011-11-111-0/+4
| | | | | | | | | | | | | | disabled code for OpenBSD: - AdjustRendererOOMScore() - SECCOMP_SANDBOX BUG= TEST=compile Review URL: http://codereview.chromium.org/8341052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109679 0039d316-1c4b-4281-b951-d872f2087c98
* Add kAllowFileAccessFromFiles switch for all tests.zmo@google.com2011-11-091-3/+0
| | | | | | | | BUG=none TEST=all existing passing tests still pass Review URL: http://codereview.chromium.org/8497023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109253 0039d316-1c4b-4281-b951-d872f2087c98
* Don't return error from EndTracing when there are no events.jbates@chromium.org2011-11-071-9/+9
| | | | | | Review URL: http://codereview.chromium.org/8456002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108933 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move DialogButton enum into ui/base/ and put it into the ui namespace.tfarina@chromium.org2011-11-043-28/+21
| | | | | | | | R=sky@chromium.org Review URL: http://codereview.chromium.org/8334041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108692 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land 107645 with static initializer removed.kkania@chromium.org2011-10-281-105/+14
| | | | | | | | | | | | Don't inherit from content::RenderViewObserver, instead just create it on the fly when needed in tests. BUG=69370, 66371, 63022 TEST=none Review URL: http://codereview.chromium.org/8416024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107792 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 107645 (To see if it was responsible for increase in static ↵eroman@chromium.org2011-10-271-14/+105
| | | | | | | | | | | | | | | | initializers) - Fix test snapshotting on linux by creating a separate automation path for snapshots outside of the thumbnail generator. BUG=69370,66371,63022 TEST=none Review URL: http://codereview.chromium.org/8294030 TBR=kkania@chromium.org Review URL: http://codereview.chromium.org/8416022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107647 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test snapshotting on linux by creating a separate automation path forkkania@chromium.org2011-10-271-105/+14
| | | | | | | | | | | snapshots outside of the thumbnail generator. BUG=69370,66371,63022 TEST=none Review URL: http://codereview.chromium.org/8294030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107645 0039d316-1c4b-4281-b951-d872f2087c98
* add Begin/EndTracing to AutomationProxy. This adds the necessary wiring and ↵jbates@chromium.org2011-10-252-0/+55
| | | | | | | | | | IPC messages to allow AutomationProxy to enable and disable tracing and collect traced data from an external browser instance. BUG=95714 Review URL: http://codereview.chromium.org/7978005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107232 0039d316-1c4b-4281-b951-d872f2087c98
* Update automation messages to use the new way of declaring message structs, ↵jam@chromium.org2011-10-213-41/+46
| | | | | | | | to cut back on unnecessary code. Review URL: http://codereview.chromium.org/8356020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106734 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enabled the policy.PolicyTest.testBookmarkBarPolicy test.joaodasilva@chromium.org2011-10-212-4/+8
| | | | | | | | | | BUG=98918 TEST=policy.PolicyTest.testBookmarkBarPolicy passes Review URL: http://codereview.chromium.org/8233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106711 0039d316-1c4b-4281-b951-d872f2087c98
* Move SecurityStyle enum into content/public/common and put it into the ↵jam@chromium.org2011-10-212-3/+3
| | | | | | | | content namespace.BUG=98716 Review URL: http://codereview.chromium.org/8361019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106642 0039d316-1c4b-4281-b951-d872f2087c98
* Move the PageType enum to content/public/common, put it into the content ↵jam@chromium.org2011-10-182-3/+3
| | | | | | | | | | namespace, and also make it conform to the Content API enum naming convention. BUG=98716 TBR=ananta Review URL: http://codereview.chromium.org/8336013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106076 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race in setting up named client automation proxy, which particularlykkania@chromium.org2011-10-141-3/+10
| | | | | | | | | | affects pyauto webdriver tests. BUG=98526 TEST=none Review URL: http://codereview.chromium.org/8283013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105505 0039d316-1c4b-4281-b951-d872f2087c98
* Move json_value_serializer from content/common to base.dpranke@chromium.org2011-10-074-5/+5
| | | | | | | | | | R=darin@chromium.org BUG=92044 TEST= Review URL: http://codereview.chromium.org/8165009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104527 0039d316-1c4b-4281-b951-d872f2087c98
* Mark AutomationProxyTest2.GetTabTitle flaky.torne@chromium.org2011-09-271-1/+7
| | | | | | | | | | | | AutomationProxyTest2.GetTabTitle has been failing often on Mac only. Marking flaky. BUG=98071 TBR=stoyan@chromium.org Review URL: http://codereview.chromium.org/8060010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102917 0039d316-1c4b-4281-b951-d872f2087c98
* For the SSL cert status, convert anonymous enum that gives bit values into a ↵pkasting@chromium.org2011-09-232-2/+2
| | | | | | | | | | | | | | typedefed uint32. This allows code all over Chromium to use an explicit type instead of "int". This also means the individual named bit constants themselves have the same explicit type. I find the resulting code to be noticeably clearer. This also exposed a bug in SSLErrorInfo::GetErrorsForCertStatus() where not having an explicit type allowed a function argument ordering bug to creep in, so I claim this is safer too. Normally this makes things like DCHECK_EQ() unhappy, but when I'd originally tested this I didn't seem to need to make any changes due to that. Will be watching the trybots... The original motiviation for this change was to find a way to eliminate some cases of passing anonymous-typed values as template arguments (which happens when you use a value from the enum in e.g. EXPECT_EQ()), which is technically illegal in C++03, though we don't warn about it. Simply naming the enum would have done this, but this would have encouraged readers to actually use the enum name as a type, which for a bitfield is inappropriate for the reason given in the first paragraph. BUG=92247 TEST=Compiles Review URL: http://codereview.chromium.org/7969023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102415 0039d316-1c4b-4281-b951-d872f2087c98
* Don't waste time on browser that crashed before connecting to the IPC channel.phajdan.jr@chromium.org2011-09-223-21/+18
| | | | | | | | BUG=90489 Review URL: http://codereview.chromium.org/7980053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102362 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 102322 - For the SSL cert status, convert anonymous enum that gives ↵pkasting@chromium.org2011-09-222-2/+2
| | | | | | | | | | | | | | | | | | | bit values into a typedefed uint32. This allows code all over Chromium to use an explicit type instead of "int". (This isn't possible by simply naming the enum as technically the enum doesn't define all of the possible combinations of bits.) This also means the individual named bit constants themselves have the same explicit type. I find the resulting code to be noticeably clearer. This also exposed a bug in SSLErrorInfo::GetErrorsForCertStatus() where not having an explicit type allowed a function argument ordering bug to creep in, so I claim this is safer too. I also added CERT_STATUS_NO_ERROR in place of "0" as a magic number. Normally this makes things like DCHECK_EQ() unhappy, but when I'd originally tested this I didn't seem to need to make any changes due to that. Will be watching the trybots... The original motiviation for this change was to find a way to eliminate some cases of passing anonymous-typed values as template arguments (which happens when you use a value from the enum in e.g. EXPECT_EQ()), which is technically illegal in C++03, though we don't warn about it. Simply naming the enum would have done this, but this would have encouraged readers to actually use the enum name as a type, which for a bitfield is inappropriate for the reason given in the first paragraph. BUG=92247 TEST=Compiles Review URL: http://codereview.chromium.org/7819009 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/7995014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102325 0039d316-1c4b-4281-b951-d872f2087c98
* For the SSL cert status, convert anonymous enum that gives bit values into a ↵pkasting@chromium.org2011-09-222-2/+2
| | | | | | | | | | | | | | | | typedefed uint32. This allows code all over Chromium to use an explicit type instead of "int". (This isn't possible by simply naming the enum as technically the enum doesn't define all of the possible combinations of bits.) This also means the individual named bit constants themselves have the same explicit type. I find the resulting code to be noticeably clearer. This also exposed a bug in SSLErrorInfo::GetErrorsForCertStatus() where not having an explicit type allowed a function argument ordering bug to creep in, so I claim this is safer too. I also added CERT_STATUS_NO_ERROR in place of "0" as a magic number. Normally this makes things like DCHECK_EQ() unhappy, but when I'd originally tested this I didn't seem to need to make any changes due to that. Will be watching the trybots... The original motiviation for this change was to find a way to eliminate some cases of passing anonymous-typed values as template arguments (which happens when you use a value from the enum in e.g. EXPECT_EQ()), which is technically illegal in C++03, though we don't warn about it. Simply naming the enum would have done this, but this would have encouraged readers to actually use the enum name as a type, which for a bitfield is inappropriate for the reason given in the first paragraph. BUG=92247 TEST=Compiles Review URL: http://codereview.chromium.org/7819009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102322 0039d316-1c4b-4281-b951-d872f2087c98
* Add a gyp flag to enable dcheck by default in release withoutnsylvain@chromium.org2011-09-201-1/+1
| | | | | | | | | having the pass a flag. This will be used on the try bots. BUG=96753 Review URL: http://codereview.chromium.org/7719007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102017 0039d316-1c4b-4281-b951-d872f2087c98
* Obsoleting --unlimited-quota-for-fileskinuko@chromium.org2011-09-201-3/+0
| | | | | | | | | BUG=94360 TEST=existing tests should pass Review URL: http://codereview.chromium.org/7839027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101928 0039d316-1c4b-4281-b951-d872f2087c98
* Redirect chrome://extensions to the new chrome://settings/extensions ↵finnur@chromium.org2011-09-191-1/+1
| | | | | | | | | | | | | | | | | | | (attempt 3). I split up an API test because it times out (it is doing too much). The other two modifications to the tests were needed because they were trying to open chrome://extensions in incognito. In one case, the test just needed any page (so I switched to about:blank) and in the other we are testing for a condition that cannot happen anymorebecause chrome://extensions could be loaded in incognito but chrome://settingsdoesn't allow that -- it shunts the request to the non-incognito profile. The test was testing that we don't crash in incognito, so I removed that test. Also change the URL for the Extension Settings page fromchrome://settings/extensionSettings -> chrome://settings/extensions. BUG=87377, 96836 TEST=Well... type in chrome://extensions and notice it redirects. TEST=chrome://settings/extensions (or chrome://extensions) should take you to the extension settings page, and chrome://settings/extensionSettings should not. Review URL: http://codereview.chromium.org/7918019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101804 0039d316-1c4b-4281-b951-d872f2087c98
* Wait properly for renderer crashesphajdan.jr@chromium.org2011-09-194-24/+24
| | | | | | | | | | | | | | This replaces a Sleep in automation with a wait for renderer crash. It turns out that our IPC on POSIX had one loophole that caused it not to notice very early crashes, so I also fixed that. The problem was that when the child process died before connecting to the parent's IPC channel, the parent wouldn't notice the crash because the child end of the IPC pipe was kept open for too long. This change makes the code close the child end of the pipe right after forking the child. This might also help with automation not noticing the browser crash during initial launch, or at least should be a good step toward fixing that problem. BUG=38497,90489 Review URL: http://codereview.chromium.org/7870008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101760 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup AutomationProviderList to fix shutdown crashes on ChromeOS auto testsstevenjb@google.com2011-09-161-0/+1
| | | | | | | | | | | | | | There is a circular relationship between BrowserProcessImpl and AutomationProvider. To clean this up and eliminate a shutdown crash: 1. Eliminate the AutomationProviderList singleton instance; it is already clearly owned by BrowserProcessImpl 2. Eliminate the calls to g_browser_process->Add/ReleaseModule in AutomationProvider since BrowserProcessImpl already owns AutomationProviderList (which owns any AutomationProvider instances). This could possibly have side effects if AutomationProvider attempts to access the message loop after the last call to BrowserProcessImpl::ReleaseModule exits the message loop, but that shouldn't be happening. BUG=96030 TEST=./run_remote_tests.sh --remote=localhost --ssh_port 9222 --use_emerged suite_Smoke and ensure no crashes occur in ~AutomationProvider Review URL: http://codereview.chromium.org/7790031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101582 0039d316-1c4b-4281-b951-d872f2087c98
* Removed leak in tests.dilmah@chromium.org2011-09-162-34/+21
| | | | | | | | | BUG=None TEST=Manual Review URL: http://codereview.chromium.org/7908003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101502 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from chrome://extensions to chrome://settings/extensionSettings.finnur@chromium.org2011-09-131-2/+1
| | | | | | | | BUG=87377 TEST=All links that went to chrome://extensions (from the wrench menu/extension action context menu etc) should go to the new settings page. Review URL: http://codereview.chromium.org/7782026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100893 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize |show_error_dialog_| bool variable before it is used.kmadhusu@chromium.org2011-09-071-4/+3
| | | | | | | | | | BUG=95589 TEST=Valgrind should go green when you run ./tools/valgrind/valgrind.sh out/Debug/ui_tests --gtest_filter=SearchProviderTest.TestIsSearchProviderInstalled Review URL: http://codereview.chromium.org/7838011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99970 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 05:31:46 +0000