| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Description:
Make sure extension_uitest.cc is actually built (my bad - got confused
about the whole .gyp vs. .sln thing).
Also, to get things building now that extension_uitest.cc is built,
shuffle the extension automation constants around so they end up in
the browser library (I didn't realize the UI tests are already linking
with that, and the linker was bringing in the
automation_extension_function.obj file ended up causing lots of
unresolved linker problems). Note that this did build the other day
when I submitted the file originally, but it must have been
essentially a fluke that the linker chose the other .obj file to get
the constants.
BUG=none
TEST=none
Original issue: http://codereview.chromium.org/113734
Review URL: http://codereview.chromium.org/113788
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16835 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Moved the new automation message in automation_messages_internal.h to the END of the enum as per the large scary warning that I skillfully missed last time around.
TBR=amit
Review URL: http://codereview.chromium.org/115711
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
builder.
TBR=thomasvl
Review URL: http://codereview.chromium.org/115708
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
interface for automated testing.
Review URL: http://codereview.chromium.org/113482
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
automation interface. This adds a method to turn on automation of
extension API functions, plumbing that redirects API requests
through the automation interface when appropriate, and a couple
of UITests that exercise the functionality.
See http://codereview.chromium.org/113277 for the original review.
Review URL: http://codereview.chromium.org/115427
Patch from Joi Sigurdsson <joi.sigurdsson@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115408
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Move resource.h to app.
http://crbug.com/11387
Review URL: http://codereview.chromium.org/113435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115210
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
automation interface.
Review URL: http://codereview.chromium.org/115134
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
message_box_flags, os_exchange_data to src/app
http://crbug.com/11387
Review URL: http://codereview.chromium.org/115012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Enable a lot of (already essentially working) automation code along the way.
Review URL: http://codereview.chromium.org/100278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99298
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
synchronous and robust.
Adding automation APIs with corresponding
IPC messages to count and find normal browser
windows.
Review URL: http://codereview.chromium.org/99268
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
didn't realize that now window.open() will result in a popup with this flag, where before it resulted in a tab. This necessitated changes to a test that expected one window and two tabs to expect two windows each with one tab.
I also fixed the test to not crash when some expectations were not met (by using ASSERT_ instead of EXPECT_), and to properly use (expected, actual) instead of (actual, expected).
Review URL: http://codereview.chromium.org/99203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
First stage to make tests/others cross-platform.
BUG=None
TEST=Ran tests successfully (windows)
Review URL: http://codereview.chromium.org/63113
Patch from Mohamed Mansour <m0.interactive@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14688 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it's not ready yet for mac.
TBR=evan
Review URL: http://codereview.chromium.org/100083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/92106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/88051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
came from so they're restored together (into the same new window) when
appropriate.
Fix safety check on tab index when restoring: make it check the correct
browser.
Change some ASSERTs to EXPECTs in the unit test for greater coverage.
BUG=5278
TEST=Open a window with two tabs, close both (closing the window), then
restore both. Make sure both restored tabs are in the same window. Open
a window with multiple tabs, close a tab, then close the window using
its close box. Restore both and make sure the tab goes back into the window.
Review URL: http://codereview.chromium.org/92001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
code. This is the same as the last change except I renamed
class MessageBox to class MessageBoxFlags to avoid conflicting
with the same name in windows.h.
Review URL: http://codereview.chromium.org/87065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r14146.
MessageBox is redefined to MessageBoxW by windows. I need to rename the
class.
Review URL: http://codereview.chromium.org/87064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
code.
This is mostly a find & replace in our code to use the new location
of the enum.
I also deleted some GetDialogButtons methods in child classes
because they were identical to the parent version in DialogDelegate.
This will allow more code to be enabled on linux/mac in the
automation provider.
Review URL: http://codereview.chromium.org/88008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it back into the window it came from, at the tabstrip index it occupied before,
and activate (select) both the window and the tab.
Restoring a tab from the New Tab Page replaces the NTP, as before.
If the window the tab was in no longer exists, put the tab at the end of the
current window's tabstrip. This behavior may change in a later patch.
BUG=5278
TEST=Open two windows, with >1 tabs each. Close a tab, not the one at the end,
in one of the windows. Switch to the other window and choose "Undo Closed
Tab" from the tabstrip context menu, or type ctrl-shift-T. The tab should
be restored where it was, and activated (selected and brought to the front).
Review URL: http://codereview.chromium.org/69015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
external tab has finished loading. Unfortunately we cannot
reuse AutomationMsg_InitialLoadsComplete because it has
overloaded meaning.
Review URL: http://codereview.chromium.org/69018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
paths which do the same thing.
- On browser side, remove
AutomationMsg_ApplyAccelerator IPC message
and ApplyAccelerator function in
automation_provider.
- On client side, let ApplyAccelerator simply
call RunCommandAsync.
With the change, converting all commands to
synchronous mode should benefit both.
Review URL: http://codereview.chromium.org/67152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
To get the PID from the socket, we use lsof (fuser doesn't work with unix sockets apparently).
The download shelf, save page, and browser ui tests now pass.
Review URL: http://codereview.chromium.org/66071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
as the function is flakey.
BUG=10501
Review URL: http://codereview.chromium.org/67139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
parent_window argument
to the Reposition function in tab_proxy
Review URL: http://codereview.chromium.org/73019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/62061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
first try here: <http://codereview.chromium.org/63149>
Review URL: http://codereview.chromium.org/67006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a window.
Bug=1751431
Review URL: http://codereview.chromium.org/62042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove following deprecated wstring-using functions:
net/net_util: FilePathToFileURL
net/net_util: FileURLToFilePath
Switch net/base/upload_data to FilePath.
Switch upload-related parts of net/url_request/url_request to FilePath.
Made necessary adjustments in rest of code (a lot).
Review URL: http://codereview.chromium.org/63011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
This reverts commit r13062 which, unsurprisingly, broke the build.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
(No review URL: Rietvelt couldn't cope)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/53121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces some helper functions in glue_util.cc for efficient
conversion between WebString and WebCore::String when inside the implementation
of webkit/glue. This is a temporary change since eventually all code in glue
that uses WebCore will be moved into the WebKit API implementation.
Instead of making the Chrome automation use WebFindInPageRequest, I decided to
introduce AutomationMsg_Find_Params as a copy of the old FindInPageRequest
structure. That preserves the IPC protocol and avoids making the automation
library depend on WebKit.
R=dglazkov
Review URL: http://codereview.chromium.org/57060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Rename RunCommand to RunCommandAsync and RunCommandSync to
RunCommand.
Review URL: http://codereview.chromium.org/57039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
WaitForTabCountToBecome is easier to use and more reliable.
Also removed Windows2000-specific code from accessibility unit tests.
Review URL: http://codereview.chromium.org/45070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12774 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
automation framework. Currently we are not consistent in
UI automation. After receiving the automation message,
the automation provider in browser does not always
execute UI commands synchronously. In many cases, it
simply sends back an acknowledgement and dispatches
the command. On the test client side, it waits and
polls the result after sending the message.
I think this causes lots of UI test flakeyness and makes
the test slow. I plan to convert all asynchronous
execution to synchronous. It may take some time to get
them all done. I CC'ed a few people so they are aware of
this ongoing work. Feel free to comment on whether and
how to address the issue.
This check in adds an UI automation message
AutomationMsg_WindowExecuteCommandSync that executes
accelerators synchronously. The existing automation
message AutomationMsg_WindowExecuteCommand only
dispatches the accelerator.
There are many UI accelerators using the existing async
version. In this check in I only made the conversion
for IDC_NEW_TAB to try out the new mechanism.
Review URL: http://codereview.chromium.org/53108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The function had confusing semantics, was marked to be removed,
and could induce flakiness in tests which used it.
WaitForWindowCountToBecome is much better replacement for it.
Review URL: http://codereview.chromium.org/49007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42408
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: http://codereview.chromium.org/42272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
SetWindowPos call
can fail on Vista if the caller is running under low IL.
Review URL: http://codereview.chromium.org/42150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
It looks like these were originally meant to be deleted, but instead all of their lines were removed and the empty file was left behind.
Review URL: http://codereview.chromium.org/43021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Normalize end of file newlines in chrome/. All files end in a single newline.
Review URL: http://codereview.chromium.org/42015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Fix files with lines > 80 cols. Part 2.
Review URL: http://codereview.chromium.org/40226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MessageEvent object to the onmessage handler.
Also adding support for origin and target parameters. The origin parameter is
implicit but target can be specified when calling postMessage. If no target
is specified we default to "*".
At the moment I'm only allowing target == "*" messages to pass through since
I haven't implemented support for matching more complicated patterns :)
Review URL: http://codereview.chromium.org/40128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11275 0039d316-1c4b-4281-b951-d872f2087c98
|