summaryrefslogtreecommitdiffstats
path: root/chrome/test/automation
Commit message (Collapse)AuthorAgeFilesLines
* Delete automation code needed by old (and deleted) ChromeDriver.kkania@chromium.org2013-09-246-1765/+2
| | | | | | | | BUG=none Review URL: https://chromiumcodereview.appspot.com/24396002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224949 0039d316-1c4b-4281-b951-d872f2087c98
* Moves most files from ui/base/keycodes to ui/events/keycodessky@chromium.org2013-09-172-2/+2
| | | | | | | | | | | | | I'm leaving usb_keycodes_map in ui/base for now. BUG=none TEST=none R=ben@chromium.org, benm@chromium.org, scherkus@chromium.org TBR=benm@chromium.org, brettw@chromium.org, scherkus@chromium.org Review URL: https://codereview.chromium.org/23480084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223739 0039d316-1c4b-4281-b951-d872f2087c98
* Use base::GlobalDescriptors::kBaseDescriptor instead of magic number 3.dongseong.hwang@intel.com2013-09-061-1/+3
| | | | | | Review URL: https://chromiumcodereview.appspot.com/23814006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221809 0039d316-1c4b-4281-b951-d872f2087c98
* Make element removal methods in DictionaryValue and ListValue take ↵bauerb@chromium.org2013-08-062-10/+10
| | | | | | | | | | | scoped_ptr's as outparams. TBR=pneubeck@chromium.org,scottbyer@chromium.org BUG=263894 Review URL: https://chromiumcodereview.appspot.com/21030009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215885 0039d316-1c4b-4281-b951-d872f2087c98
* Use content instead of WebKit for synthesizing keycodesjamesr@chromium.org2013-07-262-7/+0
| | | | | | | | | | | Also removes unused automation provider code related to key synthesis. BUG=237267 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/20581002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213987 0039d316-1c4b-4281-b951-d872f2087c98
* Update include paths in chrome/test for base/process changes.rsesek@chromium.org2013-07-244-3/+3
| | | | | | | | | BUG=242290 R=jcivelli@chromium.org Review URL: https://chromiumcodereview.appspot.com/19860007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213389 0039d316-1c4b-4281-b951-d872f2087c98
* Rename base::Delete to base::DeleteFilebrettw@chromium.org2013-07-161-1/+1
| | | | | | | | | | | Also renames DeleteAfterReboot to DeleteFileAfterReboot, and removes FileUtilProxy::RecursiveDelete which was never called. BUG= R=shess@chromium.org Review URL: https://codereview.chromium.org/18584011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211822 0039d316-1c4b-4281-b951-d872f2087c98
* Move PathExists to base namespace.brettw@chromium.org2013-07-111-1/+1
| | | | | | | | | BUG= TBR=jam@chromium.org Review URL: https://codereview.chromium.org/18286004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211147 0039d316-1c4b-4281-b951-d872f2087c98
* Move Copy* into the base namespace.brettw@chromium.org2013-07-091-2/+2
| | | | | | | | | | | This also creates a new base::internal namespace in file_util and I moved some of the internal functions in file_util to there. BUG= TBR=jam Review URL: https://codereview.chromium.org/18332014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210600 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Migrate from googleurl/ includes to url/ ones. Part 3.tfarina@chromium.org2013-07-043-4/+4
| | | | | | | | | | BUG=229660 TBR=thestig@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/18523004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210197 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_util::Delete to the base namespacebrettw@chromium.org2013-07-011-1/+1
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/16950028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209475 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in chrome/test/, chrome/tools/.avi@chromium.org2013-06-284-4/+4
| | | | | | | | | | BUG=254986 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/18148002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209147 0039d316-1c4b-4281-b951-d872f2087c98
* Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"rsleevi@chromium.org2013-06-111-4/+3
| | | | | | | | | | | | | | | | | | | This upates calls to bound temporary objects to also use get(). While it has the same semantic equivalence to the existing code, this generally represents a dangerous pattern - indeed, part of the whole motivation for this change is to make this anti-pattern very visible to authors. This change simply updates all of the call sites, to allow the "operator T*" to be removed and preventing new instances. The existing instances will then be reviewed for "suspicious" changes and updated to use/pass scoped_refptr<T> rather than T*, as appropriate. BUG=110610 TBR=darin Review URL: https://codereview.chromium.org/15984016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205560 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in chrome/test/.avi@chromium.org2013-06-114-4/+4
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205422 0039d316-1c4b-4281-b951-d872f2087c98
* Move FileEnumerator to its own file, do some refactoring.brettw@chromium.org2013-06-081-8/+6
| | | | | | | | | | | | | | It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked. BUG=175002 Reland of 198820 and 298824 Original review = https://codereview.chromium.org/13165005 R=rvargas@chromium.org Review URL: https://codereview.chromium.org/16392011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205019 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in chrome/renderer/, ↵avi@chromium.org2013-06-072-2/+2
| | | | | | | | | | | | chrome/service/, chrome/test/, chrome/third_party/, chrome/tools/. BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15709008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204931 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"rsleevi@chromium.org2013-06-021-1/+1
| | | | | | | | | | | Linux fixes, Part 1 of N BUG=110610 TBR=darin Review URL: https://chromiumcodereview.appspot.com/15836003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203632 0039d316-1c4b-4281-b951-d872f2087c98
* Delete Automation[Tab/Renderer]Helper and fix users.kkania@chromium.org2013-05-244-29/+12
| | | | | | | | | | For Chrome Endure, use the memory benchmarking V8 extension instead. For the old ChromeDriver, just mark the messages as deprecated on the client side. I'll remove all the old ChromeDriver code later. I want to keep it here since we release ChromeDriver from HEAD, and we might need to do critical fixes for Chrome 28 and below still. BUG=240580 Review URL: https://chromiumcodereview.appspot.com/14977013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202205 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Use base::MessageLoop. (Part 1)xhwang@chromium.org2013-05-101-1/+1
| | | | | | | | | | | chrome/browser/* will be updated in another CL BUG=236029 R=sky@chromium.org Review URL: https://codereview.chromium.org/14314025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199547 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 198820 "Move FileEnumerator to its own file, do some refa..."dbeam@chromium.org2013-05-081-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | Broke both windows clobber and official builders' compile with this error: 771>Link: 771> Creating library ..\..\..\build\Release\lib\gcp_portmon64.lib and object ..\..\..\build\Release\lib\gcp_portmon64.exp 771>base.lib(path_service.obj) : fatalerror LNK1112: module machine type 'X86' conflicts with target machine type 'x64' 771> 771>Build FAILED. > Move FileEnumerator to its own file, do some refactoring. > > It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked. > > BUG=175002 > R=rvargas@chromium.org > > Review URL: https://codereview.chromium.org/13165005 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/14824006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198850 0039d316-1c4b-4281-b951-d872f2087c98
* Move FileEnumerator to its own file, do some refactoring.brettw@chromium.org2013-05-071-8/+6
| | | | | | | | | | | It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked. BUG=175002 R=rvargas@chromium.org Review URL: https://codereview.chromium.org/13165005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198820 0039d316-1c4b-4281-b951-d872f2087c98
* Delete CopyRecursiveDirNoCache from test_file_util.brettw@chromium.org2013-05-061-2/+37
| | | | | | | | | | | | | | | | This function was used in only one place and the implementation was copy-and-pasted. This replaces the call with a cross-platform implementation in the one file that needs it. This is a reland of r194664 which was a reland of r192940. This version does not attempt to fix the startup test caching bugs I discovered when rewriting the function. I filed bug 237904 for this. BUG= Review URL: https://codereview.chromium.org/14577009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198539 0039d316-1c4b-4281-b951-d872f2087c98
* Remove myself from some OWNERS files and make per-file ownership more specific.ben@chromium.org2013-05-031-1/+0
| | | | | | | | | BUG=none R=brettw@chromium.org Review URL: https://codereview.chromium.org/14945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198229 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 194664 "Delete CopyRecursiveDirNoCache from test_file_util."tonyg@chromium.org2013-05-031-24/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Broke the results of the startup_benchmark on linux. BUG=237858 > Delete CopyRecursiveDirNoCache from test_file_util. > > This function was used in only one place and that place was wrong. > > The implementation was long and complicated on Windows, and long and > complicated and copied verbatim from elsewhere with 3 lines different on Posix. > > The place it was used was in the proxy launcher when copying the profile. It's > not clear to me why we wouldn't want the profile files in the filesystem cache > when running tests. Quite the opposite, we want the tests to run as fast as > possible. > > The only place this should matter is in the startup tests. And the startup > tests do things to the profile after it gets copied that should page some files > back in! This adds another step to the startup tests to evict the profile files > for cold startup tests only. > > This is a reland of r192940 which crashed on Mac. The previous perf startup > test used the profile directory before it was initialized. That patch was in > turn a reland r191854 which broke the startup test. The previous patch > replaced the CopyRecursive call with CopyDirectory which does something > slightly different. This new patch implements a CopyDirectoryContents function > to do what's required here. TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/14799003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198175 0039d316-1c4b-4281-b951-d872f2087c98
* Kill all chrome processes on linux when shutting down the ProxyLauncher.tonyg@chromium.org2013-05-031-3/+10
| | | | | | | | | | | | | | | | | | | The startup performance_ui_tests have been hanging on the perf bots since they were upgraded to Precise. The hang is due to the performance_ui_tests binary not killing all of its child chrome processes which is due to bug 177218. When that happens, the buildbot step hangs until timeout waiting for the process group to end. The suggested workaround for the bug is to disable tcmalloc, which works, but is undesireable to do on the perf bots. So this patch works around the subprocess hang by always kill()ing all chrome processes on linux. BUG=235893 TEST=performance_ui_tests --gtest_filter=ShutdownTest.* Review URL: https://chromiumcodereview.appspot.com/14707006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198045 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 197847 "Teach the ProxyLauncher to kill() child processes..."tonyg@chromium.org2013-05-021-17/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Did not solve the problem on the bots that it was intended to solve. > Teach the ProxyLauncher to kill() child processes in addition to the browser. > > The startup performance_ui_tests have been hanging on the perf bots since they > were upgraded to Precise. The hang is due to the performance_ui_tests binary not > killing all of its child chrome processes. When that happens, the buildbot step > hangs until timeout waiting for the process group to end. > > I found that simply sending the children a SIGTERM like we do to the browser > process causes them to exit cleanly. So I'm not sure what the root cause is to > child processes occassionally being left running after the browser exits, but > it seems reasonable to me for the ProxyLauncher to be robust against that case > rather than letting the buildbots hang. > > BUG=235893 > TEST=Startup performance_ui_tests > > Review URL: https://chromiumcodereview.appspot.com/14559003 TBR=tonyg@chromium.org Review URL: https://codereview.chromium.org/14854013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197941 0039d316-1c4b-4281-b951-d872f2087c98
* Teach the ProxyLauncher to kill() child processes in addition to the browser.tonyg@chromium.org2013-05-021-0/+17
| | | | | | | | | | | | | | | | | | | | The startup performance_ui_tests have been hanging on the perf bots since they were upgraded to Precise. The hang is due to the performance_ui_tests binary not killing all of its child chrome processes. When that happens, the buildbot step hangs until timeout waiting for the process group to end. I found that simply sending the children a SIGTERM like we do to the browser process causes them to exit cleanly. So I'm not sure what the root cause is to child processes occassionally being left running after the browser exits, but it seems reasonable to me for the ProxyLauncher to be robust against that case rather than letting the buildbots hang. BUG=235893 TEST=Startup performance_ui_tests Review URL: https://chromiumcodereview.appspot.com/14559003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197847 0039d316-1c4b-4281-b951-d872f2087c98
* Fix --dump-histograms-on-exit and make it work for Release builds.tonyg@chromium.org2013-05-022-8/+0
| | | | | | | | | | | | | | | | There were two bugs: 1) Using a Leaky LazyInstance caused the dtor not to be run at all. We must run it in order for --dump-histograms-on-exit to work. This was broken by https://chromiumcodereview.appspot.com/10779040 . 2) DLOG is only output for Debug builds. I changed this to printf() so that the user doesn't have to mess with logging flags at all. BUG=234644 TEST=out/Release/chrome --dump-histograms-on-exit Review URL: https://chromiumcodereview.appspot.com/14154007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197795 0039d316-1c4b-4281-b951-d872f2087c98
* Category group support/Renamings.rubentopo@gmail.com2013-04-192-9/+11
| | | | | | | | | | | | | Related review: https://codereview.chromium.org/11823016/ BUG=168284 TEST=TraceEventTestFixture.Categories, TraceEventTestFixture.CategoryFilter R=nduca Review URL: https://chromiumcodereview.appspot.com/12150004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195109 0039d316-1c4b-4281-b951-d872f2087c98
* Delete CopyRecursiveDirNoCache from test_file_util.brettw@chromium.org2013-04-171-2/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | This function was used in only one place and that place was wrong. The implementation was long and complicated on Windows, and long and complicated and copied verbatim from elsewhere with 3 lines different on Posix. The place it was used was in the proxy launcher when copying the profile. It's not clear to me why we wouldn't want the profile files in the filesystem cache when running tests. Quite the opposite, we want the tests to run as fast as possible. The only place this should matter is in the startup tests. And the startup tests do things to the profile after it gets copied that should page some files back in! This adds another step to the startup tests to evict the profile files for cold startup tests only. This is a reland of r192940 which crashed on Mac. The previous perf startup test used the profile directory before it was initialized. That patch was in turn a reland r191854 which broke the startup test. The previous patch replaced the CopyRecursive call with CopyDirectory which does something slightly different. This new patch implements a CopyDirectoryContents function to do what's required here. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194664 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 192940 "Delete CopyRecursiveDirNoCache from test_file_util."tonyg@chromium.org2013-04-091-24/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Likely culprit for startup test crashes on mac. BUG=229665 > Delete CopyRecursiveDirNoCache from test_file_util. > > This function was used in only one place and that place was wrong. > > The implementation was long and complicated on Windows, and long and > complicated and copied verbatim from elsewhere with 3 lines different on Posix. > > The place it was used was in the proxy launcher when copying the profile. It's > not clear to me why we wouldn't want the profile files in the filesystem cache > when running tests. Quite the opposite, we want the tests to run as fast as > possible. > > The only place this should matter is in the startup tests. And the startup > tests do things to the profile after it gets copied that should page some files > back in! This adds another step to the startup tests to evict the profile files > for cold startup tests only. > > This is a reland of r191854 which broke the startup test. The previous patch replaced the CopyRecursive call with CopyDirectory which does something slightly different. This new patch implements a CopyDirectoryContents function to do what's required here. > > patch from issue 13394003 > > Review URL: https://codereview.chromium.org/13646016 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/13958002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193253 0039d316-1c4b-4281-b951-d872f2087c98
* Delete CopyRecursiveDirNoCache from test_file_util.brettw@chromium.org2013-04-081-2/+24
| | | | | | | | | | | | | | | | | | | | | | | | | This function was used in only one place and that place was wrong. The implementation was long and complicated on Windows, and long and complicated and copied verbatim from elsewhere with 3 lines different on Posix. The place it was used was in the proxy launcher when copying the profile. It's not clear to me why we wouldn't want the profile files in the filesystem cache when running tests. Quite the opposite, we want the tests to run as fast as possible. The only place this should matter is in the startup tests. And the startup tests do things to the profile after it gets copied that should page some files back in! This adds another step to the startup tests to evict the profile files for cold startup tests only. This is a reland of r191854 which broke the startup test. The previous patch replaced the CopyRecursive call with CopyDirectory which does something slightly different. This new patch implements a CopyDirectoryContents function to do what's required here. patch from issue 13394003 Review URL: https://codereview.chromium.org/13646016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192940 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 191854 "Delete CopyRecursiveDirNoCache from test_file_util."sullivan@chromium.org2013-04-041-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | > Delete CopyRecursiveDirNoCache from test_file_util. > > This function was used in only one place and that place was wrong. > > The implementation was long and complicated on Windows, and long and > complicated and copied verbatim from elsewhere with 3 lines different on Posix. > > The place it was used was in the proxy launcher when copying the profile. It's > not clear to me why we wouldn't want the profile files in the filesystem cache > when running tests. Quite the opposite, we want the tests to run as fast as > possible. > > The only place this should matter is in the startup tests. And the startup > tests do things to the profile after it gets copied that should page some files > back in! This adds another step to the startup tests to evict the profile files > for cold startup tests only. > > BUG= > > Review URL: https://codereview.chromium.org/13394003 TBR=brettw@chromium.org BUG=226099 Review URL: https://codereview.chromium.org/13459005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192335 0039d316-1c4b-4281-b951-d872f2087c98
* Delete CopyRecursiveDirNoCache from test_file_util.brettw@chromium.org2013-04-021-2/+2
| | | | | | | | | | | | | | | | | | | | | | | This function was used in only one place and that place was wrong. The implementation was long and complicated on Windows, and long and complicated and copied verbatim from elsewhere with 3 lines different on Posix. The place it was used was in the proxy launcher when copying the profile. It's not clear to me why we wouldn't want the profile files in the filesystem cache when running tests. Quite the opposite, we want the tests to run as fast as possible. The only place this should matter is in the startup tests. And the startup tests do things to the profile after it gets copied that should page some files back in! This adds another step to the startup tests to evict the profile files for cold startup tests only. BUG= Review URL: https://codereview.chromium.org/13394003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191854 0039d316-1c4b-4281-b951-d872f2087c98
* net: extract net/cert out of net/basephajdan.jr@chromium.org2013-03-291-1/+1
| | | | | | | | | | | | This introduces the following dependency of net/base on things outside: net/base/openssl_client_key_store.cc:#include "net/cert/x509_certificate.h" BUG=70818 Review URL: https://codereview.chromium.org/13006020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191450 0039d316-1c4b-4281-b951-d872f2087c98
* [Cleanup] Remove StringPrintf from global namespacegroby@chromium.org2013-03-181-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | use of StringPrintf now requires prefixing with base:: or a per-scope using directive TBR'd: abodenha: chrome/service brettw: content, third_party, webkit darin: base, chrome/browser, chrome/renderer dgarret: courgette enne: cc fischmann: media gbillock: sql joi: google_apis,components rsleevi: net, crypto sky: chrome/test thestig: printing, chrome/common, tsepez: ipc wez: remoting yfriedman: testing/android NOTRY=true R=brettw@chromium.org TBR=joi@chromium.org, rsleevi@chromium.org, enne@chromium.org, thestig@chromium.org, darin@chromium.org, abodenha@chromium.org, sky@chromium.org, dgarret@chromium.org, tsepez@chromium.org, fishman@chromium.org, wez@chromium.org, gbillock@chromium.org, yfriedman@chromium.org BUG= Review URL: https://codereview.chromium.org/12767006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188857 0039d316-1c4b-4281-b951-d872f2087c98
* Minimal Chrome Frame with Aura.grt@chromium.org2013-02-283-34/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It builds and runs, but not a whole lot else. This change includes: * ChromeFrameAutomationProvider is now OS_WIN only. In practice, this has been the case for some time. Now it's formalized by giving the implementation files the _win suffix. * Automation messages and datatypes used exclusively by Chrome Frame now use HWND directly rather than a toolkit-specific gfx typedef of one since the requirement is that an actual HWND be sent over the channel. A change in toolkit (e.g., switching to Aura) must not change this. As a consequence of this change, some automation types and messages are now only defined for OS_WIN builds. * ExternalTabContainerWin is no longer derived from a NativeWidget type (this was previously the case so that the ETCW could be notified of NW lifecycle events). Now, in contrast, ETCW registers itself as an observer of its Widget. Two additional lifecycle methods have been added to WidgetObserver: OnWidgetCreated and OnWidgetDestroyed. * ExternalTabContianerWin initializes its Widget with an instance of DesktopNativeWidgetAura when use_aura. * A special note about HWND IPC marshaling: this change adds a type mapping from HWND to a generic HANDLE in ipc_message_utils.h, which allows for the removal of a hack in content_message_generator.h to marshal HWNDs. This change reverts all of: * r178752 -- Remove CF from all.gyp targets if use_aura is defined. * r164590 -- Remove setup -> Chrome Frame dependency. Make it possible to build an installer for Aura. and portions of: * r99993 -- Get chrome to link with USE_AURA * r99787 -- Preliminary work to allow Chrome to build with USE_AURA. BUG=171018 TEST=chrome_frame_tests provides good coverage in non-Aura builds. Review URL: https://chromiumcodereview.appspot.com/12220101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185328 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Update include paths of string_split.h to its new location.tfarina@chromium.org2013-02-281-1/+1
| | | | | | | | | | BUG=175186 TBR=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/12378016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185315 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 184352brettw@chromium.org2013-02-242-3/+3
| | | | | | | | | | | | | | | | | > Add utf_string_conversions to base namespace. > > This adds "using"s for all functions so those can be fixed in a separate pass. > > This converts the "Wide" versions of the functions in the Chrome directory as a first pass on the changeover. > > BUG= > > Review URL: https://codereview.chromium.org/12314090 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/12315071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184355 0039d316-1c4b-4281-b951-d872f2087c98
* Add utf_string_conversions to base namespace.brettw@chromium.org2013-02-242-3/+3
| | | | | | | | | | | | This adds "using"s for all functions so those can be fixed in a separate pass. This converts the "Wide" versions of the functions in the Chrome directory as a first pass on the changeover. BUG= Review URL: https://codereview.chromium.org/12314090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184352 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_path.h to base/files.brettw@chromium.org2013-02-242-2/+2
| | | | | | TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184344 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove deprecated base::Value methods from various chrome ↵thestig@chromium.org2013-02-152-4/+4
| | | | | | | | sub-directories. Use base::Value too. Review URL: https://chromiumcodereview.appspot.com/12255027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182672 0039d316-1c4b-4281-b951-d872f2087c98
* Move FilePath->base::FilePathbrettw@chromium.org2013-02-114-10/+10
| | | | | | Review URL: https://codereview.chromium.org/12213104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181663 0039d316-1c4b-4281-b951-d872f2087c98
* Rename FilePath to base::FilePath and use new location of ↵brettw@chromium.org2013-02-082-2/+2
| | | | | | | | string_number_conversions in some chrome subdirectories. Review URL: https://codereview.chromium.org/12218065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181564 0039d316-1c4b-4281-b951-d872f2087c98
* Add FilePath to base namespace.brettw@chromium.org2013-02-022-6/+7
| | | | | | | This updates headers that forward-declare it and a few random places to use the namespace explicitly. There us a using declaration in file_path.h that makes the rest compile, which we can do in future passes. Review URL: https://codereview.chromium.org/12163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180245 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 178387cpu@chromium.org2013-01-232-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now broke mac > Revert 178043 > > Which reverted 178037, because now android does not include automation > as of r178375 > > > > Revert 178037 > > > > It broke android. > > > > > Fix official builder compile error when building aura on windows > > > > > > The error is in the chrome_frame_common project > > > chrome_frame_automation.cc (833) : error C2440: '=' cannot convert from HWND to gfx::NativeWindow > > > > > > That is because in aura the gfx::NativeWindow is a aura::Window* instead of HWND > > > > > > BUG=171018 > > > TEST=see bug > > > Review URL: https://codereview.chromium.org/12022038 > > > > TBR=cpu@chromium.org > > Review URL: https://codereview.chromium.org/12035027 > > TBR=cpu@chromium.org > Review URL: https://codereview.chromium.org/11803003 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/11953063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178390 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 178043cpu@chromium.org2013-01-232-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Which reverted 178037, because now android does not include automation as of r178375 > Revert 178037 > > It broke android. > > > Fix official builder compile error when building aura on windows > > > > The error is in the chrome_frame_common project > > chrome_frame_automation.cc (833) : error C2440: '=' cannot convert from HWND to gfx::NativeWindow > > > > That is because in aura the gfx::NativeWindow is a aura::Window* instead of HWND > > > > BUG=171018 > > TEST=see bug > > Review URL: https://codereview.chromium.org/12022038 > > TBR=cpu@chromium.org > Review URL: https://codereview.chromium.org/12035027 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/11803003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178387 0039d316-1c4b-4281-b951-d872f2087c98
* Move window_open_disposition.h from webkit/ into ui/base.tfarina@chromium.org2013-01-221-1/+1
| | | | | | | | | | | | This reduces one more dependency on webkit from chrome. BUG=146251 R=jam@chromium.org,ben@chromium.org TBR=darin@chromium.org,tsepez@chromium.org Review URL: https://codereview.chromium.org/12036003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178082 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 178037cpu@chromium.org2013-01-222-4/+4
| | | | | | | | | | | | | | | | | | | | It broke android. > Fix official builder compile error when building aura on windows > > The error is in the chrome_frame_common project > chrome_frame_automation.cc (833) : error C2440: '=' cannot convert from HWND to gfx::NativeWindow > > That is because in aura the gfx::NativeWindow is a aura::Window* instead of HWND > > BUG=171018 > TEST=see bug > Review URL: https://codereview.chromium.org/12022038 TBR=cpu@chromium.org Review URL: https://codereview.chromium.org/12035027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178043 0039d316-1c4b-4281-b951-d872f2087c98
* Fix official builder compile error when building aura on windowscpu@chromium.org2013-01-222-4/+4
| | | | | | | | | | | | | The error is in the chrome_frame_common project chrome_frame_automation.cc (833) : error C2440: '=' cannot convert from HWND to gfx::NativeWindow That is because in aura the gfx::NativeWindow is a aura::Window* instead of HWND BUG=171018 TEST=see bug Review URL: https://codereview.chromium.org/12022038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178037 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 09:19:44 +0000