summaryrefslogtreecommitdiffstats
path: root/chrome/test/automation
Commit message (Collapse)AuthorAgeFilesLines
* Remove the remaining automation-based tests.jam@chromium.org2014-04-0413-2898/+0
| | | | | | | | | BUG=316203 R=avi@chromium.org Review URL: https://codereview.chromium.org/223163003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261839 0039d316-1c4b-4281-b951-d872f2087c98
* Move some functions in test_file_util to base namespace.brettw@chromium.org2014-03-171-1/+1
| | | | | | | | | R=viettrungluu@chromium.org TBR=viettrungluu Review URL: https://codereview.chromium.org/200883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257515 0039d316-1c4b-4281-b951-d872f2087c98
* Move CommandLine to base namespace.brettw@chromium.org2014-03-171-2/+2
| | | | | | | | | | | | Fix all forward-declares and header files referencing CommandLine. This keeps a "using base::CommandLine" in the command line header file so that the rest of the source files can be changes in a follow-up. TBR=sky Review URL: https://codereview.chromium.org/196413016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257514 0039d316-1c4b-4281-b951-d872f2087c98
* Implement ScopedFD in terms of ScopedGeneric.brettw@chromium.org2014-03-171-4/+4
| | | | | | | | | | | | | | | Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later. I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified. I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition). Reland of https://codereview.chromium.org/191673003/ R=agl, viettrungluu Review URL: https://codereview.chromium.org/202113004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257473 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Implement ScopedFD in terms of ScopedGeneric. ↵jochen@chromium.org2014-03-151-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/191673003/) Reason for revert: Doesn't correctly link /mnt/data/b/build/slave/Chromium_Linux_Codesearch/build/src/third_party/gold/gold64: warning: hidden symbol 'base::internal::ScopedFDCloseTraits::Free(int)' in obj/base/files/nacl_helper.scoped_file.o is referenced by DSO lib/libipc.so Original issue's description: > Implement ScopedFD in terms of ScopedGeneric. > > Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later. > > I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified. > > I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition). > > BUG= > R=agl@chromium.org, viettrungluu@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257001 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257179 TBR=viettrungluu@chromium.org,agl@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/201203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257323 0039d316-1c4b-4281-b951-d872f2087c98
* Implement ScopedFD in terms of ScopedGeneric.brettw@chromium.org2014-03-141-4/+4
| | | | | | | | | | | | | | | | | Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later. I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified. I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition). BUG= R=agl@chromium.org, viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257001 Review URL: https://codereview.chromium.org/191673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257179 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Implement ScopedFD in terms of ScopedGeneric. ↵thakis@chromium.org2014-03-141-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/191673003/) Reason for revert: Doesn't build on android: FAILED: /mnt/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/base/memory/base.discardable_memory_allocator_android.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD -DCOMPONENT_BUILD -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_CONFIGURATION_POLICY -DENABLE_NEW_GAMEPAD_API=1 -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DENABLE_EGLIMAGE=1 -DENABLE_AUTOFILL_DIALOG=1 -DCLD_VERSION=1 -DENABLE_PRINTING=1 -DENABLE_MANAGED_USERS=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DBASE_IMPLEMENTATION -DANDROID -D__GNU_SOURCE=1 -DUSE_STLPORT=1 -D_STLP_USE_PTR_SPECIALIZATIONS=1 '-DCHROME_BUILD_ID=""' -DHAVE_SYS_UIO_H -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -Igen/base -I../../third_party/android_tools/ndk/sources/android/cpufeatures -I../.. -fstack-protector --param=ssp-buffer-size=4 -Werror -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-reserved-user-defined-literal -Wno-deprecated-register -Xclang -load -Xclang /mnt/data/b/build/slave/Android_Clang_Builder__dbg_/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-url-directory -fcolor-diagnostics -Wexit-time-destructors -march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=softfp -mthumb -no-integrated-as -B/mnt/data/b/build/slave/Android_Clang_Builder__dbg_/build/src/third_party/android_tools/ndk//toolchains/arm-linux-androideabi-4.6/prebuilt/linux-x86_64/bin -ffunction-sections -funwind-tables -g -fstack-protector -fno-short-enums -Wa,--noexecstack -D__compiler_offsetof=__builtin_offsetof -Dnan=__builtin_nan -target arm-linux-androideabi -mllvm -arm-enable-ehabi --sysroot=/mnt/data/b/build/slave/Android_Clang_Builder__dbg_/build/src/third_party/android_tools/ndk//platforms/android-14/arch-arm -I/mnt/data/b/build/slave/Android_Clang_Builder__dbg_/build/src/third_party/android_tools/ndk//sources/cxx-stl/stlport/stlport -Os -g -fomit-frame-pointer -fdata-sections -ffunction-sections -funwind-tables -g0 -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -Wno-implicit-exception-spec-mismatch -Wno-abi -c ../../base/memory/discardable_memory_allocator_android.cc -o obj/base/memory/base.discardable_memory_allocator_android.o ../../base/memory/discardable_memory_allocator_android.cc:84:25:error: no matching function for call to 'mmap' void* const address = mmap( ^~~~ /mnt/data/b/build/slave/Android_Clang_Builder__dbg_/build/src/third_party/android_tools/ndk//platforms/android-14/arch-arm/usr/include/sys/mman.h:47:15: note: candidate function not viable: no known conversion from 'base::ScopedFD' (aka 'ScopedGeneric<int, internal::ScopedFDCloseTraits>') to 'int' for 5th argument extern void* mmap(void *, size_t, int, int, int, off_t); ^ 1 error generated. Original issue's description: > Implement ScopedFD in terms of ScopedGeneric. > > Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later. > > I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified. > > I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition). > > BUG= > R=agl@chromium.org, viettrungluu@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257001 TBR=viettrungluu@chromium.org,agl@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/197873014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257005 0039d316-1c4b-4281-b951-d872f2087c98
* Implement ScopedFD in terms of ScopedGeneric.brettw@chromium.org2014-03-141-4/+4
| | | | | | | | | | | | | | | Move to a new file base/files/scoped_file.h. I will also add ScopedFILE to here (currently in file_util.h) later. I think there is a crash in the old code in content/browser/zygote_host/zygote_host_impl_linux.cc that this patch should fix. The old ScopedFD took the address of something in a vector that is being modified. I removed SafeScopedFD from content/common/sandbox_linux/sandbox_linux.cc since base's ScopedFD not CHECKs on close failure (this is a more recent addition). BUG= R=agl@chromium.org, viettrungluu@chromium.org Review URL: https://codereview.chromium.org/191673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257001 0039d316-1c4b-4281-b951-d872f2087c98
* Let DCHECK in non-official-release build be opt-in with dcheck_always_on=1 onlywangxianzhu@chromium.org2014-03-102-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | - Remove DCHECK in non-official-release build by default - Gyp variable dcheck_always_on=1 (existing) forces to enable DCHECK in release build - Remove flag --enable-dcheck Other effects/notes: - Now allow "buildtype=Official dcheck_always_on=1" (which will enable DCHECK in official build) combination. - Gyp variable logging_like_official_build no longer has an effect - Leave DCHECK_IS_ON() unchanged. May deal with it in a later change if needed. This won't affect bots which use dcheck_always_on=1. BUG=350462 TEST=LoggingTest.Dcheck R=thakis@chromium.org TBR=darin,sehr (command line changes in components/nacl and mojo) Review URL: https://codereview.chromium.org/189603007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255987 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some automation code that's not used.jam@chromium.org2014-02-042-23/+0
| | | | | | | | | BUG=304341 R=nasko@chromium.org Review URL: https://codereview.chromium.org/148213013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248737 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more non-aura windows code.jam@chromium.org2014-01-151-6/+0
| | | | | | | | | BUG=BUG=330735 R=scottmg@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/137993009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244831 0039d316-1c4b-4281-b951-d872f2087c98
* Remove UTF string conversion functions from the global namespace.avi@chromium.org2013-12-261-2/+2
| | | | | | | | | | BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/102993018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242519 0039d316-1c4b-4281-b951-d872f2087c98
* Update uses of UTF conversions in chrome/installer, chrome/renderer, ↵avi@chromium.org2013-12-251-1/+1
| | | | | | | | | | | | chrome/service, chrome/test, chrome/third_party, chrome/tools, chrome/utility to use the base:: namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/119103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242472 0039d316-1c4b-4281-b951-d872f2087c98
* Update some uses of Value in chrome/ to use the base:: namespace.avi@chromium.org2013-12-232-24/+25
| | | | | | | | | | BUG=88666 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/119583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242408 0039d316-1c4b-4281-b951-d872f2087c98
* Add base:: to string16s in chrome/.dbeam@chromium.org2013-12-201-1/+1
| | | | | | | | | TBR=sky@chromium.org BUG=329295 Review URL: https://codereview.chromium.org/94013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242048 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the automation code for ChromeFrame since it's not used anymore.jam@chromium.org2013-12-174-153/+0
| | | | | | | | | | | This allows us to more clearly see which automation calls are left, since that code is also deprecated and will be removed in Q1. BUG=316496,316203 R=ananta@chromium.org Review URL: https://codereview.chromium.org/117033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241349 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply "Remove TraceController"wangxianzhu@chromium.org2013-12-031-24/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts https://codereview.chromium.org/101543004/ which was created when suspected the reason of failure of telemetry tests, but turned out not the real reason. Reapply. Reapply the following change: > Revert "Revert 237280 "Remove TraceController"" > > This reverts commit 6aa58b8599840160df945afa89e7482d14d1c4d4. > > Fixed double-close issue when ending recording. > > > Revert 237280 "Remove TraceController" > > > > Seems to have broken trace-based telemetry benchmarks on android. > > > > BUG=323749 > > > > > Remove TraceController > > > > > > TraceController is obsoleted by TracingController. > > > Changed all remaining clients to use TracingController. > > > > > > BUG=none > > > > > > Review URL: https://codereview.chromium.org/67683003 > > > > TBR=wangxianzhu@chromium.org > > > > Review URL: https://codereview.chromium.org/89753004 > > > > git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237452 0039d316-1c4b-4281-b951-d872f2087c98 > > TBR=wangxianzhu@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238234 TBR= Review URL: https://codereview.chromium.org/102003003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238442 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of https://codereview.chromium.org/99103004/wangxianzhu@chromium.org2013-12-031-6/+24
| | | | | | | | | | | | Reason for revert: Bug 323749 still unresolved TBR= NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/101543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238424 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert 237280 "Remove TraceController""wangxianzhu@chromium.org2013-12-021-24/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 6aa58b8599840160df945afa89e7482d14d1c4d4. Fixed double-close issue when ending recording. > Revert 237280 "Remove TraceController" > > Seems to have broken trace-based telemetry benchmarks on android. > > BUG=323749 > > > Remove TraceController > > > > TraceController is obsoleted by TracingController. > > Changed all remaining clients to use TracingController. > > > > BUG=none > > > > Review URL: https://codereview.chromium.org/67683003 > > TBR=wangxianzhu@chromium.org > > Review URL: https://codereview.chromium.org/89753004 > > git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237452 0039d316-1c4b-4281-b951-d872f2087c98 TBR=wangxianzhu@chromium.org Review URL: https://codereview.chromium.org/99103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238234 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 237280 "Remove TraceController"tonyg@chromium.org2013-11-271-6/+24
| | | | | | | | | | | | | | | | | | | | | Seems to have broken trace-based telemetry benchmarks on android. BUG=323749 > Remove TraceController > > TraceController is obsoleted by TracingController. > Changed all remaining clients to use TracingController. > > BUG=none > > Review URL: https://codereview.chromium.org/67683003 TBR=wangxianzhu@chromium.org Review URL: https://codereview.chromium.org/89753004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237452 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TraceControllerwangxianzhu@chromium.org2013-11-261-24/+6
| | | | | | | | | | | TraceController is obsoleted by TracingController. Changed all remaining clients to use TracingController. BUG=none Review URL: https://codereview.chromium.org/67683003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237280 0039d316-1c4b-4281-b951-d872f2087c98
* Delete automation code needed by old (and deleted) ChromeDriver.kkania@chromium.org2013-09-246-1765/+2
| | | | | | | | BUG=none Review URL: https://chromiumcodereview.appspot.com/24396002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224949 0039d316-1c4b-4281-b951-d872f2087c98
* Moves most files from ui/base/keycodes to ui/events/keycodessky@chromium.org2013-09-172-2/+2
| | | | | | | | | | | | | I'm leaving usb_keycodes_map in ui/base for now. BUG=none TEST=none R=ben@chromium.org, benm@chromium.org, scherkus@chromium.org TBR=benm@chromium.org, brettw@chromium.org, scherkus@chromium.org Review URL: https://codereview.chromium.org/23480084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223739 0039d316-1c4b-4281-b951-d872f2087c98
* Use base::GlobalDescriptors::kBaseDescriptor instead of magic number 3.dongseong.hwang@intel.com2013-09-061-1/+3
| | | | | | Review URL: https://chromiumcodereview.appspot.com/23814006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221809 0039d316-1c4b-4281-b951-d872f2087c98
* Make element removal methods in DictionaryValue and ListValue take ↵bauerb@chromium.org2013-08-062-10/+10
| | | | | | | | | | | scoped_ptr's as outparams. TBR=pneubeck@chromium.org,scottbyer@chromium.org BUG=263894 Review URL: https://chromiumcodereview.appspot.com/21030009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215885 0039d316-1c4b-4281-b951-d872f2087c98
* Use content instead of WebKit for synthesizing keycodesjamesr@chromium.org2013-07-262-7/+0
| | | | | | | | | | | Also removes unused automation provider code related to key synthesis. BUG=237267 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/20581002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213987 0039d316-1c4b-4281-b951-d872f2087c98
* Update include paths in chrome/test for base/process changes.rsesek@chromium.org2013-07-244-3/+3
| | | | | | | | | BUG=242290 R=jcivelli@chromium.org Review URL: https://chromiumcodereview.appspot.com/19860007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213389 0039d316-1c4b-4281-b951-d872f2087c98
* Rename base::Delete to base::DeleteFilebrettw@chromium.org2013-07-161-1/+1
| | | | | | | | | | | Also renames DeleteAfterReboot to DeleteFileAfterReboot, and removes FileUtilProxy::RecursiveDelete which was never called. BUG= R=shess@chromium.org Review URL: https://codereview.chromium.org/18584011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211822 0039d316-1c4b-4281-b951-d872f2087c98
* Move PathExists to base namespace.brettw@chromium.org2013-07-111-1/+1
| | | | | | | | | BUG= TBR=jam@chromium.org Review URL: https://codereview.chromium.org/18286004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211147 0039d316-1c4b-4281-b951-d872f2087c98
* Move Copy* into the base namespace.brettw@chromium.org2013-07-091-2/+2
| | | | | | | | | | | This also creates a new base::internal namespace in file_util and I moved some of the internal functions in file_util to there. BUG= TBR=jam Review URL: https://codereview.chromium.org/18332014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210600 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Migrate from googleurl/ includes to url/ ones. Part 3.tfarina@chromium.org2013-07-043-4/+4
| | | | | | | | | | BUG=229660 TBR=thestig@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/18523004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210197 0039d316-1c4b-4281-b951-d872f2087c98
* Move file_util::Delete to the base namespacebrettw@chromium.org2013-07-011-1/+1
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/16950028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209475 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in chrome/test/, chrome/tools/.avi@chromium.org2013-06-284-4/+4
| | | | | | | | | | BUG=254986 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/18148002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209147 0039d316-1c4b-4281-b951-d872f2087c98
* Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"rsleevi@chromium.org2013-06-111-4/+3
| | | | | | | | | | | | | | | | | | | This upates calls to bound temporary objects to also use get(). While it has the same semantic equivalence to the existing code, this generally represents a dangerous pattern - indeed, part of the whole motivation for this change is to make this anti-pattern very visible to authors. This change simply updates all of the call sites, to allow the "operator T*" to be removed and preventing new instances. The existing instances will then be reviewed for "suspicious" changes and updated to use/pass scoped_refptr<T> rather than T*, as appropriate. BUG=110610 TBR=darin Review URL: https://codereview.chromium.org/15984016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205560 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in chrome/test/.avi@chromium.org2013-06-114-4/+4
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205422 0039d316-1c4b-4281-b951-d872f2087c98
* Move FileEnumerator to its own file, do some refactoring.brettw@chromium.org2013-06-081-8/+6
| | | | | | | | | | | | | | It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked. BUG=175002 Reland of 198820 and 298824 Original review = https://codereview.chromium.org/13165005 R=rvargas@chromium.org Review URL: https://codereview.chromium.org/16392011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205019 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in chrome/renderer/, ↵avi@chromium.org2013-06-072-2/+2
| | | | | | | | | | | | chrome/service/, chrome/test/, chrome/third_party/, chrome/tools/. BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15709008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204931 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"rsleevi@chromium.org2013-06-021-1/+1
| | | | | | | | | | | Linux fixes, Part 1 of N BUG=110610 TBR=darin Review URL: https://chromiumcodereview.appspot.com/15836003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203632 0039d316-1c4b-4281-b951-d872f2087c98
* Delete Automation[Tab/Renderer]Helper and fix users.kkania@chromium.org2013-05-244-29/+12
| | | | | | | | | | For Chrome Endure, use the memory benchmarking V8 extension instead. For the old ChromeDriver, just mark the messages as deprecated on the client side. I'll remove all the old ChromeDriver code later. I want to keep it here since we release ChromeDriver from HEAD, and we might need to do critical fixes for Chrome 28 and below still. BUG=240580 Review URL: https://chromiumcodereview.appspot.com/14977013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202205 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Use base::MessageLoop. (Part 1)xhwang@chromium.org2013-05-101-1/+1
| | | | | | | | | | | chrome/browser/* will be updated in another CL BUG=236029 R=sky@chromium.org Review URL: https://codereview.chromium.org/14314025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199547 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 198820 "Move FileEnumerator to its own file, do some refa..."dbeam@chromium.org2013-05-081-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | Broke both windows clobber and official builders' compile with this error: 771>Link: 771> Creating library ..\..\..\build\Release\lib\gcp_portmon64.lib and object ..\..\..\build\Release\lib\gcp_portmon64.exp 771>base.lib(path_service.obj) : fatalerror LNK1112: module machine type 'X86' conflicts with target machine type 'x64' 771> 771>Build FAILED. > Move FileEnumerator to its own file, do some refactoring. > > It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked. > > BUG=175002 > R=rvargas@chromium.org > > Review URL: https://codereview.chromium.org/13165005 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/14824006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198850 0039d316-1c4b-4281-b951-d872f2087c98
* Move FileEnumerator to its own file, do some refactoring.brettw@chromium.org2013-05-071-8/+6
| | | | | | | | | | | It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked. BUG=175002 R=rvargas@chromium.org Review URL: https://codereview.chromium.org/13165005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198820 0039d316-1c4b-4281-b951-d872f2087c98
* Delete CopyRecursiveDirNoCache from test_file_util.brettw@chromium.org2013-05-061-2/+37
| | | | | | | | | | | | | | | | This function was used in only one place and the implementation was copy-and-pasted. This replaces the call with a cross-platform implementation in the one file that needs it. This is a reland of r194664 which was a reland of r192940. This version does not attempt to fix the startup test caching bugs I discovered when rewriting the function. I filed bug 237904 for this. BUG= Review URL: https://codereview.chromium.org/14577009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198539 0039d316-1c4b-4281-b951-d872f2087c98
* Remove myself from some OWNERS files and make per-file ownership more specific.ben@chromium.org2013-05-031-1/+0
| | | | | | | | | BUG=none R=brettw@chromium.org Review URL: https://codereview.chromium.org/14945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198229 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 194664 "Delete CopyRecursiveDirNoCache from test_file_util."tonyg@chromium.org2013-05-031-24/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Broke the results of the startup_benchmark on linux. BUG=237858 > Delete CopyRecursiveDirNoCache from test_file_util. > > This function was used in only one place and that place was wrong. > > The implementation was long and complicated on Windows, and long and > complicated and copied verbatim from elsewhere with 3 lines different on Posix. > > The place it was used was in the proxy launcher when copying the profile. It's > not clear to me why we wouldn't want the profile files in the filesystem cache > when running tests. Quite the opposite, we want the tests to run as fast as > possible. > > The only place this should matter is in the startup tests. And the startup > tests do things to the profile after it gets copied that should page some files > back in! This adds another step to the startup tests to evict the profile files > for cold startup tests only. > > This is a reland of r192940 which crashed on Mac. The previous perf startup > test used the profile directory before it was initialized. That patch was in > turn a reland r191854 which broke the startup test. The previous patch > replaced the CopyRecursive call with CopyDirectory which does something > slightly different. This new patch implements a CopyDirectoryContents function > to do what's required here. TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/14799003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198175 0039d316-1c4b-4281-b951-d872f2087c98
* Kill all chrome processes on linux when shutting down the ProxyLauncher.tonyg@chromium.org2013-05-031-3/+10
| | | | | | | | | | | | | | | | | | | The startup performance_ui_tests have been hanging on the perf bots since they were upgraded to Precise. The hang is due to the performance_ui_tests binary not killing all of its child chrome processes which is due to bug 177218. When that happens, the buildbot step hangs until timeout waiting for the process group to end. The suggested workaround for the bug is to disable tcmalloc, which works, but is undesireable to do on the perf bots. So this patch works around the subprocess hang by always kill()ing all chrome processes on linux. BUG=235893 TEST=performance_ui_tests --gtest_filter=ShutdownTest.* Review URL: https://chromiumcodereview.appspot.com/14707006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198045 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 197847 "Teach the ProxyLauncher to kill() child processes..."tonyg@chromium.org2013-05-021-17/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Did not solve the problem on the bots that it was intended to solve. > Teach the ProxyLauncher to kill() child processes in addition to the browser. > > The startup performance_ui_tests have been hanging on the perf bots since they > were upgraded to Precise. The hang is due to the performance_ui_tests binary not > killing all of its child chrome processes. When that happens, the buildbot step > hangs until timeout waiting for the process group to end. > > I found that simply sending the children a SIGTERM like we do to the browser > process causes them to exit cleanly. So I'm not sure what the root cause is to > child processes occassionally being left running after the browser exits, but > it seems reasonable to me for the ProxyLauncher to be robust against that case > rather than letting the buildbots hang. > > BUG=235893 > TEST=Startup performance_ui_tests > > Review URL: https://chromiumcodereview.appspot.com/14559003 TBR=tonyg@chromium.org Review URL: https://codereview.chromium.org/14854013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197941 0039d316-1c4b-4281-b951-d872f2087c98
* Teach the ProxyLauncher to kill() child processes in addition to the browser.tonyg@chromium.org2013-05-021-0/+17
| | | | | | | | | | | | | | | | | | | | The startup performance_ui_tests have been hanging on the perf bots since they were upgraded to Precise. The hang is due to the performance_ui_tests binary not killing all of its child chrome processes. When that happens, the buildbot step hangs until timeout waiting for the process group to end. I found that simply sending the children a SIGTERM like we do to the browser process causes them to exit cleanly. So I'm not sure what the root cause is to child processes occassionally being left running after the browser exits, but it seems reasonable to me for the ProxyLauncher to be robust against that case rather than letting the buildbots hang. BUG=235893 TEST=Startup performance_ui_tests Review URL: https://chromiumcodereview.appspot.com/14559003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197847 0039d316-1c4b-4281-b951-d872f2087c98
* Fix --dump-histograms-on-exit and make it work for Release builds.tonyg@chromium.org2013-05-022-8/+0
| | | | | | | | | | | | | | | | There were two bugs: 1) Using a Leaky LazyInstance caused the dtor not to be run at all. We must run it in order for --dump-histograms-on-exit to work. This was broken by https://chromiumcodereview.appspot.com/10779040 . 2) DLOG is only output for Debug builds. I changed this to printf() so that the user doesn't have to mess with logging flags at all. BUG=234644 TEST=out/Release/chrome --dump-histograms-on-exit Review URL: https://chromiumcodereview.appspot.com/14154007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197795 0039d316-1c4b-4281-b951-d872f2087c98
* Category group support/Renamings.rubentopo@gmail.com2013-04-192-9/+11
| | | | | | | | | | | | | Related review: https://codereview.chromium.org/11823016/ BUG=168284 TEST=TraceEventTestFixture.Categories, TraceEventTestFixture.CategoryFilter R=nduca Review URL: https://chromiumcodereview.appspot.com/12150004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195109 0039d316-1c4b-4281-b951-d872f2087c98