| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Remove old, empty suppressions file.
BUG=12539
Review URL: http://codereview.chromium.org/115738
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
different every time.
Review URL: http://codereview.chromium.org/114049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113800
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115718
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
that the extension unpacker process parsed.
BUG=11680
Review URL: http://codereview.chromium.org/115595
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
multiple messages from the renderer about the status of the find operation and some contain the selection rect (others don't). Therefore, we have to use the last known good selection rect if none is passed in.
BUG=12463
TEST=Covered by in-process browser test now.
Review URL: http://codereview.chromium.org/115667
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed all external dependencies from ExtensionsService.
It now only sends out notifications, which other services
consume. This should allow us to unit test the
ExtensionsService frontend, but I haven't added that yet.
Review URL: http://codereview.chromium.org/113493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit ebb5f616663f9d5ee78584187da16bba4ce96811.
Review URL: http://codereview.chromium.org/113680
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed all external dependencies from ExtensionsService.
It now only sends out notifications, which other services
consume. This should allow us to unit test the
ExtensionsService frontend, but I haven't added that yet.
Review URL: http://codereview.chromium.org/113493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit 5b2fc12fbca26b20ed4176ac740c58fe49360c4a.
Review URL: http://codereview.chromium.org/113664
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed all external dependencies from ExtensionsService.
It now only sends out notifications, which other services
consume. This should allow us to unit test the
ExtensionsService frontend, but I haven't added that yet.
Review URL: http://codereview.chromium.org/113493
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
convert the remaining ones, but this is enough for a first pass.
I also added a new disabled test, which will soon be enabled.
BUG=None
TEST=This whole changelist is about tests. :)
Review URL: http://codereview.chromium.org/113646
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The heart of this is that I wrapped up the request to the feed in a timeout and a bunch more error handling and abstracted all that into one function so I could be sure all the errors were getting handled the same way.
Also general cleaning while I was in there.
BUG=11969
TEST=Install Gmail Checker, go offline, go back online. It should start showing message counts again when you go back online.
Review URL: http://codereview.chromium.org/115584
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
navigating to a new url. If a reload is in progress, 'loading' will not be accompanied by 'url'.
Also, refactored some code so that string constants are defined and shared.
BUG=11200
R=erikkay
Review URL: http://codereview.chromium.org/113552
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=12060
TEST=Enable this extension, browse to a page with a Feed and an RSS icon should show up in the Omnibox. Clicking it brings you to a subscribe page. No feed preview is displayed.
Review URL: http://codereview.chromium.org/115536
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=10896
Review URL: http://codereview.chromium.org/115513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When an HTML page has a title, it is used as the suggested file name in saving
the page. Then the file extension is guessed from the suggested file name.
This results in a wrong extension if the title contains a period ".".
This the source of Bug 10581.
Merely setting ignore_suggested_ext to true in win_util::SaveFileAsWithFilter
is not a good fix, because then we have an issue in saving a page without
a title, where the extension can be correctly derived from the suggested
file name.
This change solves the issue by appending ".htm" to the suggested file name
if the page content type is HTML and the suggested file name doesn't have a
proper extension.
BUG=10581
--------
patch by yuzo@google.com
review here: <http://codereview.chromium.org/115235>
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR
Review URL: http://codereview.chromium.org/115471
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115467
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113526
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
extension toolstrips and background pages can now retrieve a list of the other "views" (window objects) in their extension and script them directly
R=mpComplete
Review URL: http://codereview.chromium.org/115419
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
automation interface. This adds a method to turn on automation of
extension API functions, plumbing that redirects API requests
through the automation interface when appropriate, and a couple
of UITests that exercise the functionality.
See http://codereview.chromium.org/113277 for the original review.
Review URL: http://codereview.chromium.org/115427
Patch from Joi Sigurdsson <joi.sigurdsson@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Move/Copy paths used by app to app_paths.
http://crbug.com/11387
Review URL: http://codereview.chromium.org/115420
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/11387
Review URL: http://codereview.chromium.org/113452
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Haven't hooked this up to anything yet though. Still trying to figure out the best way to shut everything down, so I figured I'd send this easy part out alone.
Review URL: http://codereview.chromium.org/113376
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=11200
R=aa,rafaelw
http://codereview.chromium.org/115250
Review URL: http://codereview.chromium.org/113442
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Move resource.h to app.
http://crbug.com/11387
Review URL: http://codereview.chromium.org/113435
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the content.
Review URL: http://codereview.chromium.org/109031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Dan and I were unable to reproduce the errors. Perhaps they've been fixed.
BUG=9046,9170
Review URL: http://codereview.chromium.org/113357
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115339
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 81242e3b9c6e6fbc42ccf5f973b27ed4cf4401d6.
This wasn't the cause of the breakage.
Review URL: http://codereview.chromium.org/115337
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit f2d9a44f3886aeab1378c8dbc1ce445202bc0ca5.
Review URL: http://codereview.chromium.org/115335
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
currently only supports {left, top, width, height}.
Also, added extensions_api_client_unittest tests for CreateWindow, UpdateWindow & RemoveWindow
BUG=11200
R=mpComplete
Review URL: http://codereview.chromium.org/115316
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113373
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make forward/backward navigation work even when redirection is involved.
Currently, Chrome tries to go back to the page immediately before
the current one. This doesn't work if the current page was visited
by redirection; redirection just occurs again.
With this change, Chrome first tries to find the redirection source
of the current page and then to go back to the page before the source.
BUG=9663,10531
Tested: unit_tests, ui_tests, manually.
Patch contributed by Yuzo Fujishima <yuzo@google.com>
Review: http://codereview.chromium.org/100245
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionErrorUtils.
ExtensionTabsModule implements a bunch of error_messages.
Extension Calls now always deliver a response to the calling context and route error messages if any to the window.console.error log.
Review URL: http://codereview.chromium.org/113105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=11533
Review URL: http://codereview.chromium.org/115127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(No code change.)
git ls-tree -r HEAD | grep '^100755' | cut -f2 |
egrep '\.(png|txt|mm|cc|h|checksum|asm|js|html|c|css|xml|grd|json)$' |
xargs chmod a-x
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=huanr
Review URL: http://codereview.chromium.org/115213
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115203
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/11757
Review URL: http://codereview.chromium.org/115199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is paired with http://codereview.chromium.org/67284
This CL (for commit purposes) includes http://codereview.chromium.org/67284
BUG=4463,11232,11233,11234,11235
Review URL: http://codereview.chromium.org/99030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/113164
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also:
* Add ID to the information in chrome://extensions.
* Call ExtensionMessageService::RegisterExtension() for all
RVHs, not just ExtensionHost.
* Teach RVHD to be able to return the current URL.
* Renamed "background" to "background_page" in the manifest.
Review URL: http://codereview.chromium.org/113027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/99324
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
unresolved issues with InProcessBrowserTest.
BUG=8362
BUG=9846
TEST=purify bots should go green after this checkin (or try tools/purify/chrome_tests.py -t unit --gtest_filter=ExtensionViewTest.BottomBar)
TBR=hclam
Review URL: http://codereview.chromium.org/113062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
size that should fit on even the smallest of likely desktop resolutions.
Review URL: http://codereview.chromium.org/115037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15439 0039d316-1c4b-4281-b951-d872f2087c98
|