summaryrefslogtreecommitdiffstats
path: root/chrome/test/data
Commit message (Collapse)AuthorAgeFilesLines
* Remove leaks that are now fixed.rvargas@google.com2009-02-111-112/+0
| | | | | | | | BUG=7374 Review URL: http://codereview.chromium.org/20270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9617 0039d316-1c4b-4281-b951-d872f2087c98
* More purify wack-a-mole.erikkay@google.com2009-02-062-0/+63
| | | | | | | | | TBR=nobody (feel free to volunteer if you actually want to see these reviews) Review URL: http://codereview.chromium.org/20148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9356 0039d316-1c4b-4281-b951-d872f2087c98
* another attempt to get the current errors into the known errors listerikkay@google.com2009-02-062-6/+85
| | | | | | | | | TBR=ojan Review URL: http://codereview.chromium.org/21136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9328 0039d316-1c4b-4281-b951-d872f2087c98
* Add a few errors to the known errors list:erikkay@google.com2009-02-052-0/+172
| | | | | | | | | | | BUG=7394 BUG=7374 BUG=7410 BUG=6532 Review URL: http://codereview.chromium.org/20067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9196 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for loading Current Version. (haven't removed the old style ↵erikkay@google.com2009-01-312-0/+7
| | | | | | | | loading yet) Review URL: http://codereview.chromium.org/19525 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9005 0039d316-1c4b-4281-b951-d872f2087c98
* fixed a manifest file I hadn't renamed beforeerikkay@google.com2009-01-311-0/+0
| | | | | | Review URL: http://codereview.chromium.org/19518 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9002 0039d316-1c4b-4281-b951-d872f2087c98
* Simple installation of extensions using chrome.exe ↵erikkay@google.com2009-01-297-2/+2
| | | | | | | | --install-extensionChanged manifest filename to end in .json.Updated authoring script to include sha256 hash of zip file. Review URL: http://codereview.chromium.org/18477 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8926 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to commit r8486, which updates the manifestaa@chromium.org2009-01-231-3/+9
| | | | | | | | | | | | | | | | | | | | | | | parsing in the Extension class to also parse out user script details. The problem was that extension_protocols.cc appears to link OK if you don't refer to anything in it, but as soon as you try to use something defined in it, a bunch of other symbols it refers to turn up undefined. To avoid this problem in the future, I stopped compiling extensions_protocol.cc so that we would realize if we tried to use it. Also in this change, I absolutified paths in ExtensionsService before creating Extension instances. On Linux, the path that PathService was giving us was not absolute. Review URL: http://codereview.chromium.org/18704 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8576 0039d316-1c4b-4281-b951-d872f2087c98
* Backs out 8523 in hopes of a greener tree.sky@google.com2009-01-231-21/+0
| | | | | | | | | | BUG=none TEST=none TBR=brg Review URL: http://codereview.chromium.org/18548 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8548 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to insure that when in app-mode, links open in the default browser. ↵brg@chromium.com2009-01-231-0/+21
| | | | | | | | This change should have no affect on Chrome when not in app-mode.Tested against Gmail. UITests added as app_mode_navigation_uitest. Review URL: http://codereview.chromium.org/18093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8523 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Parse more user script info out of the manifest and expose"aa@chromium.org2009-01-221-9/+3
| | | | | | | | This reverts commit fc3fd1062c06f803775c16d11f742d85d540e415. Review URL: http://codereview.chromium.org/18681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8494 0039d316-1c4b-4281-b951-d872f2087c98
* Parse more user script info out of the manifest and exposeaa@chromium.org2009-01-221-3/+9
| | | | | | | | | | | | | | | | | it on the Extension class. Removed Extension::CopyToValue() because it was only being used in unit tests. Centralize functions for creation of absolute URLs and paths to extension resources in Extension class and move corresponding unit tests. Various other minor nitpickery. Review URL: http://codereview.chromium.org/18352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8486 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable the SSLUITest.* tests on the Purifypaulg@google.com2009-01-161-0/+4
| | | | | | | ui_test build bot since it is a source of regular hangs. Review URL: http://codereview.chromium.org/18338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8242 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude some ui_tests from the purify bot that often stall.paulg@google.com2009-01-151-2/+10
| | | | | | | These tests will be added back later. Review URL: http://codereview.chromium.org/18062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8135 0039d316-1c4b-4281-b951-d872f2087c98
* Add version to list of required fields. This is required prep work for ↵erikkay@google.com2009-01-122-0/+2
| | | | | | | | extension installation. Review URL: http://codereview.chromium.org/17320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7887 0039d316-1c4b-4281-b951-d872f2087c98
* Add a UI test to make sure we sanitize the filenametc@google.com2009-01-071-0/+2
| | | | | | | | | | | of files saved using the "Save page as..." menu item. This involves adding a new automation provider method for disabling the dialog prompting for a filename. Review URL: http://codereview.chromium.org/16555 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7683 0039d316-1c4b-4281-b951-d872f2087c98
* Add generic unzip support. This is to be used by extensions.erikkay@google.com2008-12-316-0/+42
| | | | | | | depends on http://codereview.chromium.org/16605 Review URL: http://codereview.chromium.org/16487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7530 0039d316-1c4b-4281-b951-d872f2087c98
* Add some ui_tests to the Purify skip filter until we can fix them.paulg@google.com2008-12-231-0/+5
| | | | | | | | TBR=erikkay Review URL: http://codereview.chromium.org/16245 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7435 0039d316-1c4b-4281-b951-d872f2087c98
* Add a filter for ui_tests that don't (yet) work under Purify.paulg@google.com2008-12-191-0/+9
| | | | | | Review URL: http://codereview.chromium.org/14879 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7285 0039d316-1c4b-4281-b951-d872f2087c98
* Test to make sure issue 4737 doesn't regress.erg@google.com2008-12-121-0/+24
| | | | | | Review URL: http://codereview.chromium.org/13800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6942 0039d316-1c4b-4281-b951-d872f2087c98
* Apply svn:executable to .py files which should have it.phajdan.jr@chromium.org2008-12-121-1/+3
| | | | | | Review URL: http://codereview.chromium.org/14012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6884 0039d316-1c4b-4281-b951-d872f2087c98
* Move to using data URLs for unload tests and generallyojan@google.com2008-12-116-69/+0
| | | | | | | | cleanup the unload tests in preparation for adding in tests for beforeunload. Review URL: http://codereview.chromium.org/14017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6839 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two minor issues with ExtensionsService test data:aa@chromium.org2008-12-082-0/+2
| | | | | | | | | | | | | * I forgot to add the invalid manifest file in the original checkin. * Git cannot track empty directories, so the no_manifest directory was not showing up in git checkouts. So I added an empty file there. The tests were passing because the error message for invalid and missing manifests are the same. Review URL: http://codereview.chromium.org/11015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6523 0039d316-1c4b-4281-b951-d872f2087c98
* Third time's a charm?dkegel@google.com2008-12-074-158/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | Fix part of http://code.google.com/p/chromium/issues/detail?id=4510 and improve https support in test shell on linux. This is the same as the earlier ssl cert cl (see http://codereview.chromium.org/11249), but with the certs moved so net can use them without reaching over into chrome's pants and causing test failure on the 'modules' Windows build server, which is set up to test net and base but not chrome. For this to pass, we will need to install the certs on the windows module and try servers. (And make sure tlslite is present.) (A later CL will finish implementing SSLInfo for Linux, and probably reference net/base/ssl_test_util.cc from all three vcproj files that need it, even though that's ugly, because that's less ugly that referencing it from net.lib's vcproj.) Review URL: http://codereview.chromium.org/12930 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6495 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up junk in content sniffing mock-http-headers.abarth@chromium.org2008-12-056-12/+1
| | | | | | | | R=deanm Review URL: http://codereview.chromium.org/13166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6423 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the content sniffing algorithm if the server instructs us to do so ↵abarth@chromium.org2008-12-052-0/+9
| | | | | | | | | | | | with the nosniff directive. For context, see http://blogs.msdn.com/ie/archive/2008/09/02/ie8-security-part-vi-beta-2-update.aspx R=deanm,darin Review URL: http://codereview.chromium.org/12982 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6422 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce ExtensionsService. Load extensions on startup from a directory inaa@chromium.org2008-12-052-0/+15
| | | | | | | | | | the profile if a command-line flag is present. Please carefully scrutinize the threading/ref-counting schenanigans. Review URL: http://codereview.chromium.org/12876 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6403 0039d316-1c4b-4281-b951-d872f2087c98
* Fix http://code.google.com/p/chromium/issues/detail?id=4270. Test case added.mpcomplete@google.com2008-11-121-0/+43
| | | | | | | | BUG=4270 Review URL: http://codereview.chromium.org/10620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5310 0039d316-1c4b-4281-b951-d872f2087c98
* Only block alert() requests from blocked popups; not all popups.erg@google.com2008-11-113-0/+40
| | | | | | | | | Add two unit tests to make sure we do the right thing; required adding a bunch of stuff to the automation layer. Review URL: http://codereview.chromium.org/10282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5198 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that we deny javascript window.close() requests when we are showingerg@google.com2008-11-103-0/+32
| | | | | | | a blocked popup notification. Review URL: http://codereview.chromium.org/9709 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5115 0039d316-1c4b-4281-b951-d872f2087c98
* Disable one IPCSyncChannel test in purify to see if the tree remains green. ↵jam@chromium.org2008-11-061-0/+3
| | | | | | | | | | | | I tested on the buildbot and this is the only one I could see leaks in. If it stays green, I'll narrow it more by modifying the test. TBR=erikkay Review URL: http://codereview.chromium.org/9451 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4871 0039d316-1c4b-4281-b951-d872f2087c98
* Bandaid patch so that we continue with crosssite navigations instead of ↵ojan@google.com2008-11-066-1/+31
| | | | | | | | | | | | | | | closing the tab if the beforeunload /unload handler hangs. This patch does the right user-visible behavior, but I'm not a huge fan of the plumbing necessary to make it work. Totally open to cleanup suggestions. There's also currently one bug that I haven't been able to pinpoint in the UI test. It only treats the first UI test of the four that I run as a cross-site navigation. No matter which test I run first. I wonder if there is some state I should be setting/clearing before/after each test run? Also there's a DHECK that we hit that the UI test exposed. I 'm not sure it's a case that a user could actually hit though and it's not new with this code, so I added a TODO. Can I get help from a mac person on adding the UI test to the xcode project? BUG=3198 Review URL: http://codereview.chromium.org/8920 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4855 0039d316-1c4b-4281-b951-d872f2087c98
* Tell the user that HTML documents can harm their computer because they can. abarth@chromium.org2008-11-052-2/+2
| | | | | | | | | | | This patch blocks all the extensions that we register. R=nsylvain BUG=1463961 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4769 0039d316-1c4b-4281-b951-d872f2087c98
* Add the test certificates. Rename the directory to make the transition easier.maruel@chromium.org2008-11-054-0/+158
| | | | | | | BUG=b/1330770 Review URL: http://codereview.chromium.org/9332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4721 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the VerifyHistoryLength ui test flakiness. The test initiates ↵ananta@chromium.org2008-10-312-6/+5
| | | | | | | | | | | | | | page navigations in timers and reads the history length to validate it. When we receive a request to initiate a navigation in the browser, we send out the request to the renderer and then immediately read the history length and send it out in an update history length request. This causes the test to fail at times as it reads a stale history length. When we receive the DidAddHistoryItem notification in the renderer, we should not update the history length for the start page navigation. This results in the test failure at times as it reads an incorrect history length. R=jam Review URL: http://codereview.chromium.org/8898 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4344 0039d316-1c4b-4281-b951-d872f2087c98
* Moved the SelfDeletePluginInvokeInSynchronousMouseMove to interactive ui testsananta@chromium.org2008-10-291-0/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | as we need to simulate mousemoves here. ui tests run on machines which are locked, causing this test to fail. Moved the NPAPITester and NPAPIVisiblePluginTester classes to a common file npapi_test_helper.cc so it can be used from both tests. Relanding the SetCursor patch. It has already been approved by John. Description below:- Proposed fix for http://b/issue?id=1362948, which is a crash in the rendererwhen we invoke the setCursor call on the parent view in WebPluginImpl::handleEvent. This crash occurs because the plugin is deleted in the context of a mouse down event. This could occur by invoking a javascript function via NPN_Evaluate. On return from the HandleEvent sync call we attempt to retreive the parent frame, which returns NULL and hence the crash. The fix is to retreive the parent frameview at the start of the WebPluginImpl::handleMouseEvent function and use it whereever needed. Added a unit test which deletes the plugin instance in a mousemove event. R=jam Bug=1362948 Review URL: http://codereview.chromium.org/8691 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4115 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r4094; ui_tests failures in SelfDeletePluginInvokeInSynchronousMouseMove.sgk@google.com2008-10-281-39/+0
| | | | | | Review URL: http://codereview.chromium.org/8861 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4107 0039d316-1c4b-4281-b951-d872f2087c98
* Proposed fix for http://b/issue?id=1362948, which is a crash in the ↵ananta@chromium.org2008-10-281-0/+39
| | | | | | | | | | | | | | rendererwhen we invoke the setCursor call on the parent view in WebPluginImpl::handleEvent. This crash occurs because the plugin is deleted in the context of a mouse down event. This could occur by invoking a javascript function via NPN_Evaluate. On return from the HandleEvent sync call we attempt to retreive the parent frame, which returns NULL and hence the crash. The fix is to retreive the parent frameview at the start of the WebPluginImpl::handleMouseEvent function and use it whereever needed. Added a unit test which deletes the plugin instance in a mousemove event.R=jamBug=1362948 Review URL: http://codereview.chromium.org/8178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4094 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes http://code.google.com/p/chromium/issues/detail?id=205, which was ↵ananta@chromium.org2008-10-202-0/+54
| | | | | | | | | | | | | an issue with a windowed flash instance not rendering content at times.The bug occurs as a result of the following:-1. The flash plugin executes a script via GetURLNotify. This script calls window.open with the target as self, which shows up as a new tab in the browser. This causes a new RenderView object to be instantiated (See RenderView::CreateWebView).2. RenderView::CreateWebView sends over the ViewHostMsg_CreateWindow IPC message to the browser. The handler in the browser sends over an ack for this message with the window handle. This is used as the parent window for any plugins instantiated in the page.3. At times, the newly created view starts receiving data which is processed before the ViewMsg_CreatingNew_ACK message is received and processed by the view. This causes the plugin to be instantiated without a parent window thus ending up as a top level window.The fix is to queue up resource messages and process them after we receive the ack for the ViewHostMsg_CreateWindow IPC. Tests :- Covered by UI tests. R=jam Review URL: http://codereview.chromium.org/7514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3631 0039d316-1c4b-4281-b951-d872f2087c98
* Remove throttling code from the Browser process and implement throttling in ↵erg@google.com2008-10-172-0/+25
| | | | | | | | | | | | | the Renderer. The previous way of doing throttling was just calling CloseContents() on a window to reject it. But since the Browser is notified about a window opening asynchronously, by the time the CloseContents() sends a message back to the Renderer, a bunch more windows have been opened, leading to memory exhaustion. Instead, make all RenderViews created from a parent RenderView share a counter and start refusing to create RenderViews if too many RV have been created. Every RenderView (except for the first one) is assumed to be an unrequested popup, until notified by the Browser process by either a ViewMsg_DisassociateFromPopupCount message (this RenderView is a new top level page) or a ViewMsg_DisassociatePopup message (this RenderView is a requested popup and therefore shouldn't count against the count.) BUG=3382, 2632 Review URL: http://codereview.chromium.org/7388 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3568 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes http://code.google.com/p/chromium/issues/detail?id=146&,ananta@chromium.org2008-10-163-0/+154
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | which was an issue with navigation attempts initiated by Flash not working correctly in Chrome. The plugin would initiate a navigation in response to a user click. This would eventually result in a call to a script on the page, which would query the history in a timer, and would end up resetting the selected URL to the original URL as the history length would not be updated as yet. The reason being the following:- 1. A Frame navigation is initiated by the renderer in response to the user click. 2. This is sent as an async message to the browser UI thread. 3. When the navigation in the browser completes we update the history info in render view asynchronously. The fix is to attempt to update the history count when we receive notifications from webkit. These include notifications for items being added to the history, navigations based on history (like history.back/forward/goto, etc). These counts continue to be updated as before from the browser as well. Added UI tests to test these cases. Bug=146 R=jam Review URL: http://codereview.chromium.org/7412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3457 0039d316-1c4b-4281-b951-d872f2087c98
* Disable alternate error pages on frames and iframes. This istc@google.com2008-09-293-0/+5
| | | | | | | | | a request from the link doctor team. Add a UI test that verifies that no link doctor page is loaded. Review URL: http://codereview.chromium.org/5032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2684 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds new UI tests for the SSL UI.jcampan@chromium.org2008-09-245-7/+47
| | | | | | | | | | | | | | | | | | | | Some more info: SSL UI Tests: Added new tests for redirects and frames. Also improved the mixed-content test to exercise the "block mixed-contents" preference and the show info-bar. Automation: For the new UI tests, added methods to tab_proxy and browser_proxy. The ones of most interest are GetLastNavigatinTime and WaitForNavigation that ensures we wait for a navigation to occur or have occured when taking actions that asynchronously trigger navigations. Resource loading: Added a flag to the response we get when loading a resource that indicates whether that resource was filtered (blocked or altered) by the security peer. We use this flag to notify back the browser when we report a load has been committed. This is so the SSL manager knows a frame has been filtered (in which case we have no cert info but should not consider that as unsafe). BUG=2004 Review URL: http://codereview.chromium.org/3165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2553 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an old leak in tab_strip_model_unittest which had recently contributed ↵erikkay@google.com2008-09-181-59/+0
| | | | | | | | to a new leak showing up. The leak was caused by not cleaning up after ReplaceTabContents. Review URL: http://codereview.chromium.org/2954 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2374 0039d316-1c4b-4281-b951-d872f2087c98
* filter out a couple of tests which seem to be causing a lot of purify crasheserikkay@google.com2008-09-181-1/+6
| | | | | | | | | BUG=http://code.google.com/p/chromium/issues/detail?id=2468 TBR=pamg Review URL: http://codereview.chromium.org/2952 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2343 0039d316-1c4b-4281-b951-d872f2087c98
* Closing a tab with a constrained pop-up showing an SSL interstitial would ↵jcampan@chromium.org2008-09-111-0/+7
| | | | | | | | | | crash the browser. BUG=1966 TEST=Open a page that opens a popup which is served over bad SSL. Close the tab. Review URL: http://codereview.chromium.org/1898 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2058 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a test to make sure Find restarts properly after a timeout.finnur@google.com2008-08-271-0/+2245
| | | | | | | BUG=1155639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1456 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a UI test to catch the crash described in issue 1341577.This test is ↵finnur@google.com2008-08-271-0/+8
| | | | | | disabled, and will be turned on once we fix the issue.I added to TabProxy the ability to do FindNext, which was necessary to reproduce the crash, and changed the automation IPC to take a FindInPageRequest struct, which makes it identical to the IPC we pass to render_view.BUG=1341577 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1425 0039d316-1c4b-4281-b951-d872f2087c98
* Moves bookmarks out of history into its own file (JSON).sky@google.com2008-08-213-0/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Interesting points: . Migration was a bit atypical. Here is the approach I took: . If the URL db contains bookmarks it writes the bookmarks to a temporary file. . When the bookmark bar model is loaded it assumes bookmarks are stored in a file. If the bookmarks file doesn't exist it then attempts to load from history, after waiting for history to finish processing tasks. . I've broken having the omnibox query for starred only. This patch was already too ginormous for me to contemplate this too. I'll return to it after I land this. . Similarly the history page isn't searching for starred titles now. As we discussed with Glen, that is probably fine for now. . I've converted NOTIFY_STARRED_FAVICON_CHANGED to NOTIFY_FAVICON_CHANGED and it is notified ANY time a favicon changes. I'm mildly concerned about the extra notifications, but without having history know about starred it's the best I can do for now. . Autocomplete (specifically URLDatabase::AutocompleteForPrefix) previously sorted by starred. It can no longer do this. I don't think I can get this functionality back:( Luckily it only mattered if you had a starred and non-starred URL with the same type count that matched a query. Probably pretty rare. What's left: . Fix up HistoryContentsProvider to query for starred entries titles. . Clean up the delete all case. I basically just made it compile; it can be greatly simplified. . Rename BookmarkBarModel to BookmarksModel. BUG=1256202 TEST=this is a huge change to bookmarks. Thanfully it's pretty well covered by tests, none-the-less make sure you exercise bookmarks pretty heavily to make sure nothing is busted. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1153 0039d316-1c4b-4281-b951-d872f2087c98
* A first stab at testing browser close behavior when there are unload listenersojan@google.com2008-08-145-0/+39
| | | | | | | | registered. There are still a ton of tests to add as listed in the TODO, but I figured it would be good to get this reviewed first before delving too far into figuring out how to deal with beforeunload dialogs. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@890 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 20:59:20 +0000