summaryrefslogtreecommitdiffstats
path: root/chrome/test/interactive_ui
Commit message (Collapse)AuthorAgeFilesLines
* Make it possible to build DRT in a chromium checkout.tony@chromium.org2010-05-121-1/+1
| | | | | | | | | | | | | | | | | The problem was the circular gyp dependency between webkit.gyp and WebKit.gyp: webkit.gyp:pull_in_webkit_unit_tests -> WebKit.gyp -> webkit.gyp:webkit_support. The fix is to move webkit_support into its own gyp file (like we do in an webkit only checkout). We can't use the same gyp file for in- chromium and in-webkit because we need to change the include path for features.gypi. In gyp, variable expansion happens after includes (otherwise you'd have to expand variables twice and they could change values), so we can't use a single gyp file for this. Review URL: http://codereview.chromium.org/1995013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47012 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated things from net test suite:phajdan.jr@chromium.org2010-04-301-2/+2
| | | | | | | | | | | | - URLRequestTestContext (from now on use TestURLRequestContext) - TestServerPageW (use TestServerPage). TEST=none BUG=none Review URL: http://codereview.chromium.org/1814002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46044 0039d316-1c4b-4281-b951-d872f2087c98
* gyp: unify toolkit_views usageevan@chromium.org2010-04-271-10/+11
| | | | | | | | | | | Now that we can rely on toolkit_views to be set when appropriate, we can simplify a bunch of logic in gyp. TEST=compiles Review URL: http://codereview.chromium.org/1741010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45727 0039d316-1c4b-4281-b951-d872f2087c98
* Run the notifications info bar tests as interactive ui tests rather than ↵johnnyg@chromium.org2010-04-231-0/+1
| | | | | | | | | | | just ui tests. BUG=32807 TEST=included Review URL: http://codereview.chromium.org/1699007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45498 0039d316-1c4b-4281-b951-d872f2087c98
* Close previous theme info bars when resetting to default themebulach@chromium.org2010-04-202-0/+51
| | | | | | | | | | | | Select and close previous theme info bars when resetting to default theme via the options dialog. As a nice side effect if one tab is showing a theme info bar and the user switches to a different theme in another tab, this change closes the previous theme info bars as well. (landing for satish@chromium.org / http://codereview.chromium.org/1622017/show) BUG=35607 TEST=Install a theme, and with the theme info bar visible open Preferences dialog and click 'reset to default theme' and check the info bar. (full steps given in the above bug entry) Review URL: http://codereview.chromium.org/1650016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45034 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Tests cleanup:phajdan.jr@chromium.org2010-04-082-4/+3
| | | | | | | | | | | | | | - use timeouts correctly - use more automation methods to make test code more clear - use more reliable ways of waiting - remove unnecessary automation calls TEST=none BUG=none Review URL: http://codereview.chromium.org/1553016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43932 0039d316-1c4b-4281-b951-d872f2087c98
* Remove FLAKY_ from KeyboardAccessTests now that they work on both Vista and XP.dmazzoni@chromium.org2010-04-071-2/+2
| | | | | | | | | | TBR=maruel TEST=Test has been always passing on interactive build slave for several days. BUG=http://crbug.com/39320, http://crbug.com/39213 Review URL: http://codereview.chromium.org/1542014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43841 0039d316-1c4b-4281-b951-d872f2087c98
* Enable interactive_ui_testsoshima@chromium.org2010-04-062-7/+17
| | | | | | | | | | | | | | | | | | | | | | | * changed DCHECK in tree_node_model to make it easy to find how it failed. * Fixed compilation error in find_bar_host_interactive_uitest.cc on linux/views. * Disabled BrowserKeyEventsTest.AccessKeys for Chromeos Added/Changed ui_test_utils::RunAllPendingInMessageLoop where necessary. * Disabled tab_dragging_tests. I included the source so that we can catch compilation error even if tests do not run. Changed the comment from // -> /* as GCC complains the use of "\" (and potentially dangerous) * Added SleepInMessageLoop to allow event loop to execute the tasks/events while waiting. * For RunAllPendingInMessageLoop change, please see http://codereview.chromium.org/1591004 BUG=39736 TEST=interactive_ui_tests should pass with following cls http://codereview.chromium.org/1594003 http://codereview.chromium.org/1545011. Review URL: http://codereview.chromium.org/1576008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43701 0039d316-1c4b-4281-b951-d872f2087c98
* Change KeyboardAccessTests from DISABLED to FLAKY to see if they pass now.dmazzoni@chromium.org2010-04-021-2/+2
| | | | | | | | | | BUG=39213 TEST=interactive_ui_tests pass for me locally on Linux, Vista, and XP. TBR=maruel Review URL: http://codereview.chromium.org/1553009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43474 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-311-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43216 0039d316-1c4b-4281-b951-d872f2087c98
* Merge UiTest::GetTest* and ui_test_utils::GetTest*. Convert these utility ↵thestig@chromium.org2010-03-311-7/+8
| | | | | | | | | | functions to use FilePaths. BUG=none TEST=none Review URL: http://codereview.chromium.org/1567009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43190 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting this CL to fix the interactive ui test failures.ananta@chromium.org2010-03-261-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Revert 42498 - Keyboard accessibility for the page and app menus. Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 TBR=dmazzoni@chromium.org Review URL: http://codereview.chromium.org/1428001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42779 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Remove the in-process test launcher, which is no longer used.phajdan.jr@chromium.org2010-03-261-2/+0
| | | | | | | | | | | I plan to further rearrange the files after landing this CL so that the names make sense again. TEST=browser tests and live sync tests BUG=none Review URL: http://codereview.chromium.org/1310003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42737 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling tests because failures are leading to zombie processes that aredmazzoni@chromium.org2010-03-251-2/+2
| | | | | | | | | | | | | disrupting other tests. BUG=http://crbug.com/39320 BUG=http://crbug.com/39213 TEST=hopefully makes the Interactive Tests bot (Windows) green. TBR=maruel Review URL: http://codereview.chromium.org/1313006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42624 0039d316-1c4b-4281-b951-d872f2087c98
* Mark keyboard access tests as flaky until I figure out why they'redmazzoni@chromium.org2010-03-241-2/+2
| | | | | | | | | | | | not running on the Interactive Tests buildbot. BUG=http://crbug.com/39213 TEST=none TBR=maruel Review URL: http://codereview.chromium.org/1233005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42526 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard accessibility for the page and app menus.dmazzoni@chromium.org2010-03-242-0/+105
| | | | | | | | | | | | | | | | | | | | | | | | | | Works on Windows, and on Linux with toolkit_views. The goal is to make Chrome behave more like a standard Windows application, for users who rely on the keyboard and expect standard keyboard accelerators to work. Pressing F10, or pressing and releasing Alt, will set focus to the Page menu, as if it was the first item in a menu bar. Pressing enter, space, up arrow, or down arrow will open the focused menu. Once a menu is opened, pressing left and right arrows will switch between the two menus. Pressing escape will return focus to the title of the previously open menu. A new UI test attempts to select something from the menus using only the keyboard. It works on Linux (with toolkit_views) and on Windows. BUG=none TEST=New keyboard accessibility interactive ui test. Review URL: http://codereview.chromium.org/660323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42498 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce number of automation methods ending with WithTimeout.phajdan.jr@chromium.org2010-03-221-1/+1
| | | | | | | | | | | | | | | | | | | | | They are just too easy to misuse. People started inventing their own hardcoded timeouts all over the place. Also, the is_timeout return parameter was not checked consistently. Additionally, some calls actually had no timeout at all, making hangs possible. This change also removes useless DLOG statements. We should get the required info from the ASSERT/EXPECT macros in test code, which is quite well checked by WARN_UNUSED_RESULT. TEST=all ui-based BUG=none Review URL: http://codereview.chromium.org/1076005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42213 0039d316-1c4b-4281-b951-d872f2087c98
* Move cert_test_util.{h,cc} and ssl_test_util.{h,cc} to thewtc@chromium.org2010-03-171-0/+1
| | | | | | | | | | | net_test_support build target. R=eroman BUG=none TEST=no build errors Review URL: http://codereview.chromium.org/1047003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41856 0039d316-1c4b-4281-b951-d872f2087c98
* Move devtool resources from webkit_resources.grd to an upstream grd file.tony@chromium.org2010-03-111-0/+1
| | | | | | | | This gets rid of third_party references in webkit_resources.grd which will allow us to build this file upstream. Review URL: http://codereview.chromium.org/792005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41238 0039d316-1c4b-4281-b951-d872f2087c98
* Move wtl from chrome/third_party to third_party/. Thistony@chromium.org2010-03-091-1/+1
| | | | | | | | | | | breaks dependencies on chrome from webkit, app, views and base. BUG=37649 TEST=compiles Review URL: http://codereview.chromium.org/699001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41001 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: add some interactive tests to catch common bookmark bar regressions.estade@chromium.org2010-02-181-0/+1
| | | | | | | | | BUG=33220, 34564 TEST=test passes Review URL: http://codereview.chromium.org/606009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39309 0039d316-1c4b-4281-b951-d872f2087c98
* Include test_shell.gypi in webkit.gyp instead of maintaining a distinctmark@chromium.org2010-02-101-1/+1
| | | | | | | | | | | | | | | | | | test_shell.gyp. This allows the removal of webkit.gyp:pull_in_test_shell, eliminating the circular relationship between webkit.gyp and test_shell.gyp. The expected semantics of building all of test_shell during a webkit.gyp:All build is performed are retained. This change depends on GYP r781 (in Chromium at r38526) for GYP suffix operator path section treatment. It also depends on Chromium r38519 and r38658 for common.gypi treatment of chromium_code. BUG=33186 TEST=Xcode no longer holds stale project files in memory Review URL: http://codereview.chromium.org/602006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38664 0039d316-1c4b-4281-b951-d872f2087c98
* Wire popup blocking UI to the new machinery and port over the user's old ↵pkasting@chromium.org2010-02-021-2/+0
| | | | | | | | | | | | | | | | whitelist. Notably, this removes the UI entirely for Mac and Linux. We need to rebuild it. This also guts the old system's testing, since most of it disappeared or changed radically. We should test the new stuff. I will file a followup bug for that. There are various tiny edge cases, like if you click the address bar icon really quickly, sometimes you'll get popups without any title yet, which makes them leave gaps in the bubble that appears. We can fix that sort of thing. The critical bit I tried to ensure was that we never try to open a dead popup or use a dead TabContents, no matter what. BUG=33314 TEST=Go visit some sites with popups and play with things Review URL: http://codereview.chromium.org/562013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37819 0039d316-1c4b-4281-b951-d872f2087c98
* Change chromeos build to use viewsoshima@chromium.org2009-12-221-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/508025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35186 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring build configurations - make it clearer and allow better support ↵gregoryd@google.com2009-12-221-1/+1
| | | | | | | | | | | | | for x64 on Windows TEST=none BUG=29467 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35012 Review URL: http://codereview.chromium.org/501127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35129 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35012 - Rearrange build configurations make it clearer and allow ↵gregoryd@google.com2009-12-191-1/+1
| | | | | | | | | | | | | | better support for x64 on Windows TEST=none BUG=29467 Review URL: http://codereview.chromium.org/501127 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/500149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35016 0039d316-1c4b-4281-b951-d872f2087c98
* Rearrange build configurations - make it clearer and allow better support ↵gregoryd@google.com2009-12-191-1/+1
| | | | | | | | | | | for x64 on Windows TEST=none BUG=29467 Review URL: http://codereview.chromium.org/501127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35012 0039d316-1c4b-4281-b951-d872f2087c98
* Make no-tcmalloc (really, non-base/allocator) builds work again,dank@chromium.org2009-12-031-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (i.e. this is a plain vanilla build used when layers like base/allocator are getting in the way of debugging) and make sure they use msvcrt rather than libcmt (libcmt is used to help shim malloc/free, but it gets in the way of valgrind doing the same thing). Sadly, this is now a gyp-time operation rather than a Configuration option. Had to remove hardcoded C prototype for _set_new_mode, as that caused link errors. Also add variables win_{release,debug}_{Optimization,RuntimeLibrary} to let the valgrind build override those settings. Fix calling convention on _set_new_mode to match the one in <new.h> BUG=none TEST=build with ~/.gyp/include.gypi set as described in comment in common.gypi, gclient runhooks, do release build, verify all exe's and dll's linked against msvcrt dll Review URL: http://codereview.chromium.org/455037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33719 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the existing .gyp configuration to use the new base\allocatorsgk@chromium.org2009-11-261-1/+1
| | | | | | | | | | library with upstream source code from the new vendor branch patterns in third_party\jemalloc and third_party\tcmalloc. BUG=27911 TEST=none Review URL: http://codereview.chromium.org/435040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33208 0039d316-1c4b-4281-b951-d872f2087c98
* Making grd dependencies more correct for grds in app.bradnelson@google.com2009-11-201-1/+2
| | | | | | | | | BUG=17706 TEST=None Review URL: http://codereview.chromium.org/414006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32602 0039d316-1c4b-4281-b951-d872f2087c98
* test_shell buildable on ARMhclam@chromium.org2009-11-181-1/+1
| | | | | | | | | GYP changes to allow test_shell be buildable on ARM so we can use it as a minimal browser for testing purpopse. Review URL: http://codereview.chromium.org/399077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32386 0039d316-1c4b-4281-b951-d872f2087c98
* Partially revert WebKit.gyp switch-over, because it broke build bot setupdglazkov@google.com2009-11-131-1/+1
| | | | | | | | | | | | | | | | | in subtle and devious ways. Renaming webkit.gyp -> webkit_glue.gyp changed webkit.sln to webkit_glue.sln, which occured unbeknownst to the builders who continued to build webkit.sln for most of the day. This wasn't an issue until we did a WebKit roll, where the trickery was discovered and hell broke loose. TBR=yaar TEST=green bots BUG=none Review URL: http://codereview.chromium.org/385084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31887 0039d316-1c4b-4281-b951-d872f2087c98
* Upstreaming WebKit.gypyaar@chromium.org2009-11-121-1/+1
| | | | | | | | | | | | This mega patch contains a few simple but tightly dependent changes: 1. Deletion of webkit/api/WebKit.gyp. The file now lives in webkit.org. 2. Rename of webkit/webkit.gyp to webkit/webkit_glue.gyp. Having two webkit.gyp was a source of developer confusion. 3. Gyp dependencies are updated across chromium to point at the upstream WebKit.gyp and the renamed webkit_glue.gyp. 4. Some 200+ files include paths fixed to point to third_party/WebKit/WebKit/chromium instead of webkit/api. The later will be deleted in a subsequent patch. Review URL: http://codereview.chromium.org/387020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31749 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the CL that made interactive UI tests run out-of-proc.jcampan@chromium.org2009-11-061-5/+6
| | | | | | | | | | | | | | | | | It was causing them to hang on Windows. I cannot repro on my box. I added a timeout to the ViewEventTest as I suspect they are the ones causing the timeout. Original review: http://codereview.chromium.org/355014/show TEST=None TBR=rafael Review URL: http://codereview.chromium.org/360016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31327 0039d316-1c4b-4281-b951-d872f2087c98
* Addin a time-out to view base tests to prevent them fromjcampan@chromium.org2009-11-042-5/+38
| | | | | | | | | | | potentially hanging the interactive ui tests. BUG=None TEST=Run the interactive ui tests. R=sky Review URL: http://codereview.chromium.org/355024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30972 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 30879.jcampan@chromium.org2009-11-041-6/+5
| | | | | | | | | | | Some devtool tests hang on Windows, one fails on Linux. I need to investigate more. BUG=None TBR=rafael Review URL: http://codereview.chromium.org/348067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30897 0039d316-1c4b-4281-b951-d872f2087c98
* Making the interactive ui tests run out of process to avoid runningjcampan@chromium.org2009-11-031-5/+6
| | | | | | | | | | | | into problems when running several browser tests in the same process. Turning previously failing tests on. BUG=26540 TEST=Run the interactive UI tests on Windows and Linux. Review URL: http://codereview.chromium.org/355014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30879 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing in-process-browser interactive_ui_tests.rafaelw@chromium.org2009-11-031-0/+4
| | | | | | | | BUG=26540 Review URL: http://codereview.chromium.org/341078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30835 0039d316-1c4b-4281-b951-d872f2087c98
* Fix interactive_ui_tests.tony@chromium.org2009-11-021-0/+2
| | | | | | | | | | | Need to add theme resources to this binary as well. Missed in r30755. TBR=rafael Review URL: http://codereview.chromium.org/348049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30767 0039d316-1c4b-4281-b951-d872f2087c98
* Implements tests for testing browser's overall key events handling behavior.suzhe@chromium.org2009-10-231-0/+2
| | | | | | | | | | | | This CL implements some basic tests for testing browser's overall key events handling behavior. This CL depends on http://codereview.chromium.org/235039 and http://codereview.chromium.org/195062. Currently, only Linux and Windows are supported. The tests assume US keyboard layout is used and no IME is activated. We still need to investigate how to write tests that involving different keyboard layout and input methods. BUG=none TEST=none Review URL: http://codereview.chromium.org/268035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29866 0039d316-1c4b-4281-b951-d872f2087c98
* Removing an unused gyp file that somehow did not get removed when I reverted ↵jcampan@chromium.org2009-10-141-150/+0
| | | | | | | | | | | my CL last week. BUG=None TEST=None Review URL: http://codereview.chromium.org/276020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29042 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath in URLRequestMocks.evan@chromium.org2009-10-141-1/+2
| | | | | | | | | BUG=24672 TEST=compiles Review URL: http://codereview.chromium.org/271066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29013 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring out the interactive UI tests in their own GYP file.jcampan@chromium.org2009-10-131-0/+132
| | | | | | | | | | | Although turning back on the browser focus tests that had been turned off last week because of my previous attempt at performing this refactoring (that change was reverted). BUG=None TEST=Build and run the interactive ui tests on Windows and Linux. Review URL: http://codereview.chromium.org/273029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28866 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the interactive UI tests GYP factor out, as it turnsjcampan@chromium.org2009-10-091-0/+150
| | | | | | | | | | | out it is not responsible for breaking the interactive ui tests. See http://codereview.chromium.org/259018/show TBR=brettw Review URL: http://codereview.chromium.org/270042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28558 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 28404, it seems to break the interactive ui tests in mysterious ways.jcampan@chromium.org2009-10-091-150/+0
| | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/268024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28492 0039d316-1c4b-4281-b951-d872f2087c98
* Extracting the interactive ui tests to their own GYP file.jcampan@chromium.org2009-10-081-0/+150
| | | | | | | | BUG=None TEST=The interactive tests should still build and run on Windows and Linux Review URL: http://codereview.chromium.org/259018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28404 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27389.darin@chromium.org2009-09-301-0/+1
| | | | | | Review URL: http://codereview.chromium.org/246027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27594 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding keyboard code refactoring:jcampan@chromium.org2009-09-291-1/+2
| | | | | | | | | | | | | | | | http://codereview.chromium.org/248010/show Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to several places where I had to switch from VK_ to VKEY_. Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly. BUG=None TEST=Make sure short-cuts works as expected, especially in the omnibox. Review URL: http://codereview.chromium.org/251020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27444 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 27412 it breaks the toolkit views Linux build.jcampan@chromium.org2009-09-281-2/+1
| | | | | | | TBR=sky Review URL: http://codereview.chromium.org/254005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27416 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the KeyboardEvent to use a KeyboardCode instead of a w_char. Led to ↵jcampan@chromium.org2009-09-281-1/+2
| | | | | | | | | | | | several places where I had to switch from VK_ to VKEY_. Also cleaned-up the table view OnKeyDown method. Since TableView is a NativeControl it can use the NativeControl::OnKeyDown directly. BUG=None TEST=Make sure short-cuts works as expected, especially in the omnibox. Review URL: http://codereview.chromium.org/248010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27412 0039d316-1c4b-4281-b951-d872f2087c98