summaryrefslogtreecommitdiffstats
path: root/chrome/test/live_sync
Commit message (Collapse)AuthorAgeFilesLines
* 2nd attempt at http://codereview.chromium.org/3305003/showjohnnyg@chromium.org2010-09-095-71/+82
| | | | | | | | | | | | | | | | | | The difference between this patch and the other one is plumbing setup_in_test_mode through the Initialization process, rather than using a separate SetupInTestMode() method, which happens too late to safely stop the syncer thread. [see syncapi.cc|h for most of the changes.] --- This patch removes: authenticator.cc, auth_watcher.cc removes calls to user_settings.cc, removes an authenticate PB request to the server, and moves token storage into the Chrome TokenService. This patch introduces the SigninManager, which is an interim solution for user management prior to moving the system into chrome. Other changes include removing the dependency on the sync backend to be running while the sync wizard is intially displayed. This means that the backend can be brought up in response to credentials becoming available. The backend now is always provided credentials on startup. If an auth error occurs, it propogates it up via a notification. Some event handlers were removed and streamlined for more straightforward sync system startup. BUG=51001, 50293, 35158 TEST=Unit tests && Start up sync, log in, log out, run with expired credentials, run with new gaia credentials, run with gaia credentials updated while system is syncing. Try logging in with incorrect username. Trigger CAPTCHA. Try logging out and in repeatedly. Check about:sync works. Try going offline and back online again. Expire gaia credentials and try renewing it with the UI dialog. Review URL: http://codereview.chromium.org/3342025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58993 0039d316-1c4b-4281-b951-d872f2087c98
* Marking sync many-client stress tests as flaky.rsimha@chromium.org2010-09-092-2/+4
| | | | | | | | | | | | | | | | These tests are flaky on the trybots and builders because they spin up 10 clients that all need to receive notifications through flaky network connectivity. Fixing crbug.com/53931 should make these reliable once again. TBR=akalin@chromium.org BUG=none TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3365001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58989 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the sync-notification-host command line parameter to the integration ↵rsimha@chromium.org2010-09-081-0/+5
| | | | | | | | | | | | | | | | | | tests. The sync integration tests currently access the network to communicate with the notification server. We need to move to a model where all server accesses are stubbed out by local servers. This is the first step towards implementing a local notification server. BUG=53933,53931 TEST=sync_integration_tests First time committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58768 Review URL: http://codereview.chromium.org/3326007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58860 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58778 - New authorization framework for sync. johnnyg@chromium.org2010-09-085-82/+71
| | | | | | | | | | | | | | | | | | | | | To quote chron's original patch (http://codereview.chromium.org/3148036/show) <blockquote> This patch removes: authenticator.cc, auth_watcher.cc removes calls to user_settings.cc, removes an authenticate PB request to the server, and moves token storage into the Chrome TokenService. This patch introduces the SigninManager, which is an interim solution for user management prior to moving the system into chrome. Other changes include removing the dependency on the sync backend to be running while the sync wizard is intially displayed. This means that the backend can be brought up in response to credentials becoming available. The backend now is always provided credentials on startup. If an auth error occurs, it propogates it up via a notification. Some event handlers were removed and streamlined for more straightforward sync system startup. </blockquote> BUG=51001, 50293, 35158 TEST=Unit tests && Start up sync, log in, log out, run with expired credentials, run with new gaia credentials, run with gaia credentials updated while system is syncing. Try logging in with incorrect username. Trigger CAPTCHA. Try logging out and in repeatedly. Check about:sync works. Try going offline and back online again. Expire gaia credentials and try renewing it with the UI dialog. Review URL: http://codereview.chromium.org/3305003 TBR=johnnyg@chromium.org Review URL: http://codereview.chromium.org/3310019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58782 0039d316-1c4b-4281-b951-d872f2087c98
* New authorization framework for sync. johnnyg@chromium.org2010-09-085-71/+82
| | | | | | | | | | | | | | | | | | To quote chron's original patch (http://codereview.chromium.org/3148036/show) <blockquote> This patch removes: authenticator.cc, auth_watcher.cc removes calls to user_settings.cc, removes an authenticate PB request to the server, and moves token storage into the Chrome TokenService. This patch introduces the SigninManager, which is an interim solution for user management prior to moving the system into chrome. Other changes include removing the dependency on the sync backend to be running while the sync wizard is intially displayed. This means that the backend can be brought up in response to credentials becoming available. The backend now is always provided credentials on startup. If an auth error occurs, it propogates it up via a notification. Some event handlers were removed and streamlined for more straightforward sync system startup. </blockquote> BUG=51001, 50293, 35158 TEST=Unit tests && Start up sync, log in, log out, run with expired credentials, run with new gaia credentials, run with gaia credentials updated while system is syncing. Try logging in with incorrect username. Trigger CAPTCHA. Try logging out and in repeatedly. Check about:sync works. Try going offline and back online again. Expire gaia credentials and try renewing it with the UI dialog. Review URL: http://codereview.chromium.org/3305003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58778 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58768 - Adding the sync-notification-host command line parameter to ↵rsimha@chromium.org2010-09-071-5/+0
| | | | | | | | | | | | | | | | | | | the integration tests. The sync integration tests currently access the network to communicate with the notification server. We need to move to a model where all server accesses are stubbed out by local servers. This is the first step towards implementing a local notification server. BUG=53933,53931 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3326007 TBR=rsimha@chromium.org Review URL: http://codereview.chromium.org/3318016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58769 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the sync-notification-host command line parameter to the integration ↵rsimha@chromium.org2010-09-071-0/+5
| | | | | | | | | | | | | | | | tests. The sync integration tests currently access the network to communicate with the notification server. We need to move to a model where all server accesses are stubbed out by local servers. This is the first step towards implementing a local notification server. BUG=53933,53931 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3326007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58768 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the wstring TreeModelNode::GetTitle() and rename GetTitleAsString16() ↵viettrungluu@chromium.org2010-08-302-12/+11
| | | | | | | | | | | to GetTitle(). BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3279005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57834 0039d316-1c4b-4281-b951-d872f2087c98
* Move prefs-related files under chrome/browser/ into a prefs/ subdir.evan@chromium.org2010-08-265-5/+5
| | | | | | | | | | | | Rename includes, resort header include order in places where the rename changed the order. BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from bookmarks, part 6.viettrungluu@chromium.org2010-08-211-2/+2
| | | | | | | | | | | Remove the wstring version of BookmarkModel::SetTitle(). BUG=23581 TEST=builds and passes enough tests Review URL: http://codereview.chromium.org/3142030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56985 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings in bookmarks, part 5.viettrungluu@chromium.org2010-08-202-21/+24
| | | | | | | | | | | Remove wstring BookmarkModel::AddURL(). BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3152034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56860 0039d316-1c4b-4281-b951-d872f2087c98
* Adding debugging info for sync integration tests.rsimha@chromium.org2010-08-203-9/+50
| | | | | | | | | | | | | The sync integration test logs do not reveal when different sync events occur on the ProfileSyncServiceTestHarness objects. This checkin adds logging for sync events so that failures are easier to debug. BUG=52761 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3169028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56800 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up unnecessary TODO comments in sync integration tests.rsimha@chromium.org2010-08-191-3/+0
| | | | | | | | | | | | There were a bunch of TODO comments whose action items were already completed. Removing said comments. BUG=50306 TEST=none Review URL: http://codereview.chromium.org/3143031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56765 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to GoogleServiceAuthError struct instead of GaiaAuthError.chron@chromium.org2010-08-192-2/+2
| | | | | | | | | | | | Remove CAPTCHA code from existing user controller and plumb into google authenticator2. TEST=Install ChromeOS build. Hit Captcha. Enter captcha. BUG=50408 Review URL: http://codereview.chromium.org/3134009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56724 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from bookmarks, part 3.viettrungluu@chromium.org2010-08-192-7/+12
| | | | | | | | | | | | Get rid of wstring BookmarkModel::AddGroup() (and convert lots of uses; also convert many uses of the wstring AddURL() as drive-by's). BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3115017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56689 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling offline sync test.rsimha@chromium.org2010-08-181-1/+1
| | | | | | | | | | | | | | | The offline sync test was disabled due to bug 51820, which has now been fixed. This patch enables the test since it now passes. TBR=tim@chromium.org BUG=47918 TEST=OfflineSyncTest.OfflineStart Review URL: http://codereview.chromium.org/3159025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56577 0039d316-1c4b-4281-b951-d872f2087c98
* Fix failing sync integration tests.rsimha@chromium.org2010-08-182-12/+20
| | | | | | | | | | | | | | | | | | TwoClientLivePreferencesSyncTest.Security was failing due to a couple of EXPECT_NEs that ought to have been EXPECT_EQs. TwoClientLiveAutofillSyncTest.Client1HasData was failing due to a change in autofill behavior introduced in r55781 to fix security bug crbug.com/51727. This changelist also includes a clarification in the logic used by TwoClientLiveAutofillSyncTest.BothHaveData. BUG=51727,51956 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3169019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56469 0039d316-1c4b-4281-b951-d872f2087c98
* Test server cleanup patch of death:phajdan.jr@chromium.org2010-08-172-11/+9
| | | | | | | | | | | | | | - reduce the number of different classes - clean up the internal code - modify the interface to expose less internal details (this will allow more flexibility with port numbers) TEST=many BUG=49680 Review URL: http://codereview.chromium.org/3080029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56405 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling previously failing test, adding more preferences tests.rsimha@chromium.org2010-08-171-11/+92
| | | | | | | | | | | Patch from Anna Popinova <annapop@chromium.org>. BUG=none TEST=none Review URL: http://codereview.chromium.org/3109020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56284 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sync integration tests on Chrome OS.rsimha@chromium.org2010-08-161-7/+11
| | | | | | | | | | | | | | | | The sync integration tests were failing on Chrome OS because we were incorrectly calling OnUserChoseDatatypes() during sync setup. This is something that needs to be done only on non-Chrome OS platforms. With this fix, the sync integration tests should run on Windows, Mac, Linux and Chrome OS. BUG=52006 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3175013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56254 0039d316-1c4b-4281-b951-d872f2087c98
* Simple offline startup integration test.skrul@chromium.org2010-08-135-10/+190
| | | | | | | | | | This is a simple offline startup integration test. This change also includes the groundwork for more complex offline startup test cases, including the ability to enable and disable network connectivity as well as configure the mock sync server with a username. BUG=47918 Review URL: http://codereview.chromium.org/3078031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56087 0039d316-1c4b-4281-b951-d872f2087c98
* Marking Client1HasData test as failed due to bug 51956.rsimha@chromium.org2010-08-121-1/+3
| | | | | | | | | | | | | | The TwoClientLiveAutofillSyncTest.Client1HasData test fails due to bug 51956. Marking it as FAILS until the bug is fixed. TBR=tim@chromium.org BUG=51956 TEST=TwoClientLiveAutofillSyncTest.Client1HasData Review URL: http://codereview.chromium.org/3146013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55948 0039d316-1c4b-4281-b951-d872f2087c98
* Adding automation for Pri0 and Pri1 test cases for syncing Chrome preferences.rsimha@chromium.org2010-08-121-4/+467
| | | | | | | | | | | Patch from Anna Popivanova <annapop@chromium.org>. BUG=none TEST=none Review URL: http://codereview.chromium.org/3047050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55818 0039d316-1c4b-4281-b951-d872f2087c98
* Error reporting for sync setup failure.rsimha@chromium.org2010-08-112-20/+14
| | | | | | | | | | | | | The setup step in the sync integration tests sometimes fails on builders due to timing or networking issues. The tests, however, do not report the exact cause of failure. (Setup can fail due to a number of reasons). Adding some logging that will help debug test failures. BUG=51741 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3160002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55645 0039d316-1c4b-4281-b951-d872f2087c98
* Use SSL/TCP port for notifications in sync tests.rsimha@chromium.org2010-08-101-0/+9
| | | | | | | | | | | | | The sync integration tests start off by using the XMPP port (5222) to connect to the sync notification server. Since this port is blocked on the chromium builders, the tests wait for upto a minute before they failover to the SSL/TCP port (443), by which time the tests time out and fail. This checkin adds a switch that, when enabled, causes the tests to try the SSL/TCP port before the XMPP port. BUG=50595 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3050036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55599 0039d316-1c4b-4281-b951-d872f2087c98
* Remove sync_types.h. No functions from this file are used, and some of them arebrettw@chromium.org2010-08-081-0/+1
| | | | | | | | | | | | | | | explicitly disallowed in Google code (DWORD). This implicitly brought string_util into a number of files which got ASCII conversion routimes. I replaced these with *ToUTF8 from utf_string_conversions since I am trying to delete WideToASCII. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3063021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55367 0039d316-1c4b-4281-b951-d872f2087c98
* Add #include utf_string_conversions.h to all files that use ASCIIToWide andbrettw@chromium.org2010-08-031-0/+1
| | | | | | | | | | | | | | | ASCIIToUTF16. I removed string_util includes from a few places where it obviously wasn't needed. In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm going to do an even later pass to find the unnecessary string_util.h includes and remove them. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3058027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more callers of the integer/string functions to usingbrettw@chromium.org2010-07-312-95/+103
| | | | | | | | | | string_number_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3013046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
* Revert timeout value for sync integration tests.rsimha@chromium.org2010-07-301-2/+2
| | | | | | | | | | | | | | | | The XP bots still need a longer timeout for the sync integration tests, so I'm reverting my earlier change to the timeout value. Also fixing an issue where InProcessBrowserTest::TimedOut() incorrectly reports the current value of timeout. TBR=timsteele BUG=50589,50590 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3077009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54348 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a bunch of easy AppendSwitchWithValue to *ASCII.evan@chromium.org2010-07-301-4/+4
| | | | | | | | | For this patch, I skipped over any instance where it wasn't a nearly trivial change. Review URL: http://codereview.chromium.org/3069014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54285 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move more test server code from net/url_request/url_request_unittest.hphajdan.jr@chromium.org2010-07-291-0/+1
| | | | | | | | | | | | | to net/test/test_server.h No code changes, just a move. TEST=none BUG=49680 Review URL: http://codereview.chromium.org/3034038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54201 0039d316-1c4b-4281-b951-d872f2087c98
* Update python sync server to support recursive deletion.rsimha@chromium.org2010-07-281-3/+3
| | | | | | | | | | | | | The python sync server does not support recursive deletion, as a result of which test cases that remove a directory of sync entries end up failing. This checkin updates the sync server to support recursive deletion of sync entries and all their childen. BUG=50306 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3051019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54012 0039d316-1c4b-4281-b951-d872f2087c98
* base/ header cleanup. Forward declaration instead of including.erg@google.com2010-07-282-0/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3068004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53969 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing broken Integration tests.rsimha@chromium.org2010-07-275-53/+52
| | | | | | | | | | | | | Several integration tests use the wrong method to wait for sync to complete, as a result of which they fail during verification. Also making the condition for the detection of sync completion more robust. BUG=50114 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3037019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53759 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-266-0/+6
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Significantly speed up sync integration tests.rsimha@chromium.org2010-07-264-19/+49
| | | | | | | | | | | | | | | The sync integration tests currently use the method AwaitSyncCycleCompletion(), which ends up waiting for a sync event before it signals the end of a sync cycle. However, if it is called after the sync cycle is already complete, it ends up waiting for several seconds for a random unrelated sync event before it returns. This checkin fixes this unnecessary delay by checking to see if the client has any unsynced items before it waits, thereby significantly speeding up the sync integration tests. In addition to this, a new method called AwaitQuiescence() is now available to test cases so they can wait for racy updates initiated by multiple clients to propagate across the system. BUG=49998 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3041018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53712 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring sync startup code in ProfileSyncServiceTestHarnessrsimha@chromium.org2010-07-232-11/+25
| | | | | | | | | | | After r53023 was checked in, the startup code in ProfileSyncServiceTestHarness needs a refactor where it must now wait for the OnBackendInitialized() callback. BUG=49719 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3009015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53420 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move net/socket/ssl_test_util to net/test/test_serverphajdan.jr@chromium.org2010-07-211-1/+1
| | | | | | | | | | | This is a first step to make test server easier to use and more reliable. TEST=none BUG=49680 Review URL: http://codereview.chromium.org/3040011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53137 0039d316-1c4b-4281-b951-d872f2087c98
* Set sync-notification-method to "transitional" for integration tests.rsimha@chromium.org2010-07-191-1/+8
| | | | | | | | | | | | | | | | The sync integration tests do not have a fake Tango server that provides clients with XMPP notifications. Therefore, we rely on clients nudging each other via the server when changes need to be synced. Until we implement a fake Tango server, this switch needs to be set for all integration tests. BUG=48141 TEST=sync_integration_tests:echo Review URL: http://codereview.chromium.org/2834051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52939 0039d316-1c4b-4281-b951-d872f2087c98
* This checkin contains 2 new types of sync integration tests.rsimha@chromium.org2010-07-169-4/+176
| | | | | | | | | | | | | The first type of tests ("multiple client") creates a small number of clients (3) that make simultaneous, sometimes conflicting updates to a sync item and verifies that the system reaches a sane state in spite of racy conditions. The second type of tests ("many client") creates several clients (10) that all sync to the same account and process updates sent out due to one or more of them syncing a change, and verifies that the system reaches a known sane state at the end of the test. BUG=49035 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/2897017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52724 0039d316-1c4b-4281-b951-d872f2087c98
* Adding "--password-file-for-test" parameter to sync integration tests. (Take 2)rsimha@chromium.org2010-07-092-8/+41
| | | | | | | | | | | | | | | | | | | | | | In order to run the sync integration tests on the chromium buildbots, we need a way to load the GAIA credentials from a local password file instead of via command line parameters. This changelist implements a new command line parameter called "--password-file-for-test" for this purpose. ================================================== NOTE: This code was originally checked in as http://codereview.chromium.org/2899001, but checkin http://codereview.chromium.org/2850042 broke it, resulting in the original checkin being reverted with http://codereview.chromium.org/2905004. This is a new attempt at checking in the code, where password_file_ is a FilePath instead of a wstring. BUG=48525 TEST=sync_integration_tests;valid password file;invalid password file;blank password file;non-existent password file Review URL: http://codereview.chromium.org/2899006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51991 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51882 - In order to run the sync integration tests on the chromium ↵cbentzel@chromium.org2010-07-082-38/+6
| | | | | | | | | | | | | | | | buildbots, we need a way to load the GAIA credentials from a local password file instead of via command line parameters. This changelist implements a new command line parameter called "--password-file-for-test" for this purpose. BUG=48525 TEST=sync_integration_tests;valid password file;invalid password file;blank password file;non-existent password file Review URL: http://codereview.chromium.org/2899001 TBR=rsimha@chromium.org Review URL: http://codereview.chromium.org/2905004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51884 0039d316-1c4b-4281-b951-d872f2087c98
* In order to run the sync integration tests on the chromium buildbots, we ↵rsimha@chromium.org2010-07-082-6/+38
| | | | | | | | | | | | | need a way to load the GAIA credentials from a local password file instead of via command line parameters. This changelist implements a new command line parameter called "--password-file-for-test" for this purpose. BUG=48525 TEST=sync_integration_tests;valid password file;invalid password file;blank password file;non-existent password file Review URL: http://codereview.chromium.org/2899001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51882 0039d316-1c4b-4281-b951-d872f2087c98
* There were typos in lines 1575, 1578 and 1581.rsimha@chromium.org2010-07-081-4/+4
| | | | | | | | | BUG=43893 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/2901001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51873 0039d316-1c4b-4281-b951-d872f2087c98
* Reviewed by ncarter: See http://codereview.chromium.org/2838042/showrsimha@chromium.org2010-07-052-17/+17
| | | | | | | | | | | | | | | | ================================================= This changelist includes some minor fixes suggested during a C++ readability review. There are no code logic changes -- all edits are cosmetic. Review URL on Rietveld code review tool: http://codereview.appspot.com/1737041/show Buganizer URL for readability review: http://b/issue?id=2786642 BUG=none TEST=none Review URL: http://codereview.chromium.org/2840034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51623 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51595 - Incorporating feedback from C++ readability review.rsimha@chromium.org2010-07-032-17/+17
| | | | | | | | | | | | | | | | | This changelist includes some minor fixes suggested during a C++ readability review. There are no code logic changes -- all edits are cosmetic. Review URL on Rietveld code review tool: http://codereview.appspot.com/1737041/show Buganizer URL for readability review: http://b/issue?id=2786642 BUG=none TEST=none Review URL: http://codereview.chromium.org/2838042 TBR=rsimha@chromium.org Review URL: http://codereview.chromium.org/2823039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51596 0039d316-1c4b-4281-b951-d872f2087c98
* Incorporating feedback from C++ readability review.rsimha@chromium.org2010-07-032-17/+17
| | | | | | | | | | | | | | This changelist includes some minor fixes suggested during a C++ readability review. There are no code logic changes -- all edits are cosmetic. Review URL on Rietveld code review tool: http://codereview.appspot.com/1737041/show Buganizer URL for readability review: http://b/issue?id=2786642 BUG=none TEST=none Review URL: http://codereview.chromium.org/2838042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51595 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling failing sync integration tests.rsimha@chromium.org2010-07-022-18/+18
| | | | | | | | | | | | | These tests currently fail due to known issues. Marking them as "FAILS" before I deploy the remaining ones on the buildbots. The failing tests will be fixed during the upcoming quarter. BUG=none TEST=sync_integration_tests Review URL: http://codereview.chromium.org/2843047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51571 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the wait code in ProfileSyncServiceTestHarness.rsimha@chromium.org2010-07-023-24/+42
| | | | | | | | | | | | | | | | | | The sync integration tests use the methods defined in the ProfileSyncServiceTestHarness class to coordinate various sync related activities carried out by each test case. The sync codebase has ungergone significant change since this class was originally implemented. In this checkin, the class has been refactored to match the sync codebase. The pass rate for integration tests went up from ~20% to 90+% with this checkin. BUG=44957 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/2876029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51500 0039d316-1c4b-4281-b951-d872f2087c98
* Change a bunch of string types.estade@chromium.org2010-06-291-2/+2
| | | | | | | | | | | | | Started out just trying to change PrefService::GetString and ::SetString. This snowballed a little bit. Had to change a bunch of url strings in search_engines/ from wstring to string (some of them may be better off as GURLs, but UTF-8 is a step in the right direction, since that's what GURL uses internally, as well as externally via its setters/getters). TODO (later patch): things that ask for accepted languages should use std::string, not std::wstring. BUG=none TEST=try bots Review URL: http://codereview.chromium.org/2854015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51157 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 12:23:54 +0000