| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
last_sync_timestamp from the new_timestamp only, never from per-entry
timestamps. Use what the server sends us to know whether or not there
are more updates to fetch. Eliminate some unnecessarily complicated
logic having to do with the # of updates returned -- that's always a red
herring; with server-side filtering, it is indeed possible for 0 updates
to be returned along with a new timestamp.
BUG=37373
TEST=manual testing of 2 browser sync; unit tests.
Review URL: http://codereview.chromium.org/1161006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
from the sync engine rather than waiting for "a couple syncs" to happen
before declaring sync "done".
BUG=37351
Review URL: http://codereview.chromium.org/1042008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37353
TEST=this is a test
Review URL: http://codereview.chromium.org/843004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to chrome/browser.
This is a part of an effort to remove bad dependency of chrome/common
on chrome/browser.
TEST=unit_tests and ui_tests, just moving code
BUG=none
Review URL: http://codereview.chromium.org/621004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=If it compiles it is perfect.
Review URL: http://codereview.chromium.org/585008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, do a better job of making sure we don't write useless default values to disk, and we force the in-memory copy of the default prefs to never say "DEFAULT" even if a caller provides that to SetDefaultContentSetting().
BUG=32719
TEST=unittests
Review URL: http://codereview.chromium.org/562003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
platforms.
Patch by Brian Lum (brianlum at google.com)
Original Review http://codereview.chromium.org/526016
Review URL: http://codereview.chromium.org/536025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and nonexistent addresses to custom pages, and plumb it to the code that puts up infobars when users type in a search that appears to be an intranet address, so we don't show these for erroneous cases.
BUG=31556
TEST=none
Review URL: http://codereview.chromium.org/525079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35807 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
will build on all platforms.
Patch by Brian Lum (brianlum at google.com)
Original Review: http://codereview.chromium.org/526016
Review URL: http://codereview.chromium.org/523113
TBR=tim@chromium.org
Review URL: http://codereview.chromium.org/525091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
all platforms.
Patch by Brian Lum (brianlum at google.com)
Original Review: http://codereview.chromium.org/526016
Review URL: http://codereview.chromium.org/523113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
call FindPreference directly.
BUG=None
TEST=compiles and passes existing tests
Original patch by Thiago Farina <thiago.farina@gmail.com> at
http://codereview.chromium.org/460117/show
Review URL: http://codereview.chromium.org/463044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/384062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the really hard ones which will need actual review instead of rubber-stamping.)
Review URL: http://codereview.chromium.org/386026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=19738
TEST=Get a Google Account into captcha state. Start syncing. You should
be presented with a captcha image and textbox to answer the challenge.
Doing so correctly shoud unlock your account and proceed with sync setup.
Review URL: http://codereview.chromium.org/389017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added GoogleServiceAuthError, which is the same as the incumbent AuthErrorState but can support captcha information too. I moved it because it just had nothing specific to sync about it. This CL is mostly a rename and basic plumbing CaptchaRequired error state from browser_sync::AuthWatcher through to UI thread.
Ben, I added a .h to chrome/browser/ alongside other google_* stuff. I'm just looking for your blessing here, or suggestion of alternate location.
BUG=19738
Review URL: http://codereview.chromium.org/384040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26749
Review URL: http://codereview.chromium.org/372013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Get rid of sync_char16 from syncapi
- Use wstring for title in syncapi since that gets converted to wstring
later on anyway.
- Use GURL for urls in syncapi
- Return const string references from syncapi instead of pointers to
C-style strings.
- Make appropriate changes to calling code.
BUG=26342
TEST=Already exist.
Review URL: http://codereview.chromium.org/362019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/337034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch authored by Thiago Farina (thiago.farina@gmail.com)
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/328025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename GetType and SetType using the Unix style to match with the other usages in BookmarkNode.
GetType -> type
SetType -> set_type
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/297005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Avoid #ifdef in general, favoring #if defined().
In one spot, use PlatformThread::Sleep instead of rolling our own.
Review URL: http://codereview.chromium.org/267125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
makes it so that bookmark all tabs only creates the folder if the user
presses ok. I wasn't happy adding another random arg to
BookmarkEditor::Show, so I added in a structure an enum. This makes it
clearer what Show should do.
I also fixed the following:
. On gtk we wouldn't always pick the right parent for nodes.
. The context menu item is now enabled on views/gtk.
And this now breaks the mac side. I'll straighten that out right after
landing this.
BUG=24367
TEST=Make sure 'bookmark all tabs' works, as well as the bookmark
editor work. (get to the bookmark editor by creating a new bookmark,
then clicking edit, or right clicking a bookmark on the bookmark bar and
choosing edit).
Review URL: http://codereview.chromium.org/271115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/246022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
under src/.
TEST=TwoClientLiveBookmarksSyncTest
BUG=23478
Review URL: http://codereview.chromium.org/242085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
default.
BUG=none
Test=Sync my bookmarks should be enabled by default.
Review URL: http://codereview.chromium.org/248024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
InProcessBrowserTest that let tests do
what is normally done by overriding SetUp/TearDown methods. This special method is needed because
of the way SetUp winds up at the bottom of the stack that invokes your test fixture methods.
Make the LiveBookmarksSyncTest class allow direct lookup for google.com domain as part of setup,
which these tests need to access GAIA and sync servers.
Review URL: http://codereview.chromium.org/214047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
should just exit, rather go through rest of the code.
Review URL: http://codereview.chromium.org/183022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
supplied as a parameter. This change is required for buildbot slave security, as buildbot will call this script without password and can't store password for calling.
Review URL: http://codereview.chromium.org/173500
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
separate parameter.
Review URL: http://codereview.chromium.org/174503
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24452 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1109011 (Internal Review)
Added 2 new test cases + Code to handle favicon loading, copying History and
Favicon verification.
Fixed all the comments.Fixed jcampan's comments about removing virtual method for setting user-data-dir.
Review URL: http://codereview.chromium.org/165277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/173085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23833 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
will replace the original script which is used by buildbot to run sync test.
Review URL: http://codereview.chromium.org/172068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
they work. Currently they are broken in buildbot due to this issue.
Review URL: http://codereview.chromium.org/174073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=ProfileSyncServiceTest, sync integration tests
Review URL: http://codereview.chromium.org/172040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Removes ProfilePersonalization (which is why the CL appears huge)
- Makes Profile do the work ProfilePersonalization did for creating PSS
- cloudy:stats > about:sync
- Removes the cloudy:// scheme and uses chrome:// for resources.
(Note SyncResourcesSource is a straight copy of CloudyResourceSource).
- Moves prefs and switches to pref_names and chrome_switches.
BUG=none
TEST=ProfileSyncServiceTest, LiveBookmarkSyncTests, SyncSetupWizardTest
Review URL: http://codereview.chromium.org/164544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/165015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22549 0039d316-1c4b-4281-b951-d872f2087c98
|
|
building because
the files are wrapped in #ifdef CHROME_PERSONALIZATION which is not defined anywhere at the moment.
Add live_sync to chrome\test and corresponding target to chrome.gyp
Review URL: http://codereview.chromium.org/159902
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22521 0039d316-1c4b-4281-b951-d872f2087c98
|